---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60651/#review179621
---
Ship it!
Ship It!
- haosdent huang
On July 5, 2017, 11:08
/agent.html
Lines 176 (patched)
<https://reviews.apache.org/r/60370/#comment254402>
Should we use * here to keep consistent with other parts? Beside this,
other changes LGTM!
- haosdent huang
On June 28, 2017, 8:52 p.m., Andrei Budnik
> On July 3, 2017, 6:27 p.m., haosdent huang wrote:
> > src/webui/master/static/js/controllers.js
> > Lines 610 (patched)
> > <https://reviews.apache.org/r/60370/diff/3/?file=1766481#file1766481line610>
> >
> > How about
> >
> >
> On July 3, 2017, 6:27 p.m., haosdent huang wrote:
> > src/webui/master/static/js/controllers.js
> > Lines 610 (patched)
> > <https://reviews.apache.org/r/60370/diff/3/?file=1766481#file1766481line610>
> >
> > How about
> >
> >
> On June 27, 2017, 5:33 p.m., haosdent huang wrote:
> > src/webui/master/static/js/controllers.js
> > Lines 604 (patched)
> > <https://reviews.apache.org/r/60370/diff/2/?file=1764203#file1764203line604>
> >
> > `ng-repeat` support map, have you try
)
<https://reviews.apache.org/r/60370/#comment254292>
How about
```
$scope.agent.resource_reservations =
_($scope.state.reserved_resources).map(function(role, reservation)) {
reservation.role = role
return reservation;
}
```
- haosdent huang
On J
s/MacOSX/MacOS
- haosdent huang
On June 29, 2017, 9:59 p.m., Vinod Kone wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
possible to merge
build.sh into entrypoint.sh
- haosdent huang
On June 29, 2017, 9:59 p.m., Vinod Kone wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
tps://reviews.apache.org/r/60439/#comment254264>
Sorry, just saw `LOCAL_USER_ID`.
- haosdent huang
On June 29, 2017, 9:59 p.m., Vinod Kone wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
tps://reviews.apache.org/r/60439/#comment254263>
Should we move `bundle install` to here?
- haosdent huang
On June 29, 2017, 9:59 p.m., Vinod Kone wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
tps://reviews.apache.org/r/60439/#comment254262>
Is it OK to run support/mesos-website/build.sh as root?
- haosdent huang
On June 29, 2017, 9:59 p.m., Vinod Kone wrote:
>
> ---
> This is an automatically generated e-mail.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60438/#review179124
---
Ship it!
Ship It!
- haosdent huang
On June 26, 2017, 5:54
> On June 23, 2017, 4:06 p.m., haosdent huang wrote:
> > src/webui/master/static/agent.html
> > Lines 184 (patched)
> > <https://reviews.apache.org/r/60370/diff/1/?file=1758433#file1758433line184>
> >
> > Is `|| 0` necessary here?
>
> Andrei Budn
> On June 27, 2017, 5:33 p.m., haosdent huang wrote:
> > src/webui/master/static/js/controllers.js
> > Lines 604 (patched)
> > <https://reviews.apache.org/r/60370/diff/2/?file=1764203#file1764203line604>
> >
> > `ng-repeat` support map, have you try
dpoints_tests.cpp
Line 1739 (original), 1739 (patched)
<https://reviews.apache.org/r/60369/#comment253382>
Nit: Add one blank line below.
- haosdent huang
On June 27, 2017, 5:10 p.m., Andrei Budnik wrote:
>
> ---
> This i
)
<https://reviews.apache.org/r/60370/#comment253372>
`ng-repeat` support map, have you try
```
ng-repeat="(role, reservation) in $data"
```
- haosdent huang
On June 27, 2017, 5:10 p.m., And
> On June 23, 2017, 4:06 p.m., haosdent huang wrote:
> > src/webui/master/static/agent.html
> > Lines 176 (patched)
> > <https://reviews.apache.org/r/60370/diff/1/?file=1758433#file1758433line176>
> >
> > Should we use `*` here to keep consistent wit
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60170/#review178943
---
Ship it!
Ship It!
- haosdent huang
On June 26, 2017, 10:39
ml
Lines 186 (patched)
<https://reviews.apache.org/r/60370/#comment253025>
Is `|| 0` necessary here?
- haosdent huang
On June 22, 2017, 3:26 p.m., Andrei Budnik wrote:
>
> ---
> This is an automatically generated e-mai
/master/static/css/mesos.css
9f3de5427071fc61d3791c4bc2a660368c2cd3c2
Diff: https://reviews.apache.org/r/58874/diff/4/
Testing
---
Thanks,
haosdent huang
---
Thanks,
haosdent huang
src/webui/master/static/js/controllers.js
1aca25ab6e0856128ebefe5037cbe63430857c99
Diff: https://reviews.apache.org/r/58872/diff/3/
Changes: https://reviews.apache.org/r/58872/diff/2-3/
Testing
---
Thanks,
haosdent huang
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60169/#review178353
---
Ship it!
Ship It!
- haosdent huang
On June 17, 2017, 4:58
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60170/#review178350
---
Ship it!
Ship It!
- haosdent huang
On June 17, 2017, 4:58
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58872/#review174374
---
On May 3, 2017, 4:15 a.m., haosdent huang wrote:
>
> -
about adding a comment here that reroute is expected to always
> > route away from the page and so the listener is removed after the first
> > state update?
Thanks @bmahler's detail review. Let me add a comment for it.
- haosdent
-------
/namespaces_isolator_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/53517/diff/6/
Changes: https://reviews.apache.org/r/53517/diff/5-6/
Testing
---
Thanks,
haosdent huang
a7262cd97361b55ff31238341657e764df6c9ea5
Diff: https://reviews.apache.org/r/54105/diff/4/
Changes: https://reviews.apache.org/r/54105/diff/3-4/
Testing
---
Thanks,
haosdent huang
9f3de5427071fc61d3791c4bc2a660368c2cd3c2
Diff: https://reviews.apache.org/r/58874/diff/4/
Testing
---
Thanks,
haosdent huang
> ```
Hi, @janisz very sorry for the delay. I try this patch, but the spcaces is
still there. Seems didn't resolve our problem.
- haosdent
---
This is an automatically generated e-mail. To reply, v
e.gif
https://reviews.apache.org/media/uploaded/files/2017/05/03/79afd0b1-5fb1-437c-a91c-732009af8fe3__strip_space.gif
Thanks,
haosdent huang
.png
Thanks,
haosdent huang
-dd0d-49c2-a683-6a0ffe08f7a6__screenshot.png
screenshot_1.png
https://reviews.apache.org/media/uploaded/files/2017/06/07/17460501-4b6e-4b02-9f52-6165d58cf83f__screenshot_1.png
Thanks,
haosdent huang
-
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59796/#review176947
---
On June 7, 2017, 2:30 a.m., haosdent huang wrote:
>
>
https://reviews.apache.org/media/uploaded/files/2017/06/05/240a56ea-dd0d-49c2-a683-6a0ffe08f7a6__screenshot.png
screenshot_1.png
https://reviews.apache.org/media/uploaded/files/2017/06/07/17460501-4b6e-4b02-9f52-6165d58cf83f__screenshot_1.png
Thanks,
haosdent huang
Thanks,
haosdent huang
/
Testing
---
Thanks,
haosdent huang
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59732/#review176894
---
Ship it!
Ship It!
- haosdent huang
On June 1, 2017, 10:06
ace?
Yes, this still insert a space
```
')">
https://reviews.apache.org/r/58874/#review174590
---
On May 8, 2017, 8:01 a.m., haosdent huang wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
omatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58874/#review174590
---
On May 8, 2017, 8:01 a.m., haosdent huang wrote:
>
> ---
> This is
patch and have
not finished. Could return my comments if it works at my side. Thanks a lot for
your contributions.
- haosdent huang
On May 5, 2017, 9:23 p.m., Tim Anderegg wrote:
>
> ---
> This is an automatically generated e-mail.
-732009af8fe3__strip_space.gif
Thanks,
haosdent huang
-5fb1-437c-a91c-732009af8fe3__strip_space.gif
Thanks,
haosdent huang
-
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58874/#review173801
---
On May 3, 2017, 4:29 a.m., haosdent huang wrote:
>
> ---
Diff: https://reviews.apache.org/r/53517/diff/5/
Changes: https://reviews.apache.org/r/53517/diff/4-5/
Testing
---
Thanks,
haosdent huang
4c6c8f6656b62e5d8fbd8d4e8f2d7903f71e884c
Diff: https://reviews.apache.org/r/54105/diff/3/
Changes: https://reviews.apache.org/r/54105/diff/2-3/
Testing
---
Thanks,
haosdent huang
/namespaces_isolator_tests.cpp PRE-CREATION
src/tests/slave_recovery_tests.cpp 9cf1d461cf5c6ac1f51ac963360a17e37f558505
Diff: https://reviews.apache.org/r/53516/diff/5/
Changes: https://reviews.apache.org/r/53516/diff/4-5/
Testing
---
Thanks,
haosdent huang
-CREATION
Diff: https://reviews.apache.org/r/53296/diff/8/
Changes: https://reviews.apache.org/r/53296/diff/7-8/
Testing
---
Test case is: https://reviews.apache.org/r/53517/
Thanks,
haosdent huang
), 40-41 (patched)
<https://reviews.apache.org/r/58998/#comment247089>
I think change `ng-show` to `ng-if` should be enough.
```
-
...
```
- haosdent huang
On May 4, 2017, 7:04 p.m., Neil Conway
g/r/58942/#comment246745>
Should we add `MESOS-7453` at here?
- haosdent huang
On May 2, 2017, 11:48 p.m., Michael Park wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
views.apache.org/r/58874/#review173526
---
On May 3, 2017, 4:29 a.m., haosdent huang wrote:
>
> ---
> This is an automatically generated e-mail. To rep
Diff: https://reviews.apache.org/r/58874/diff/2/
Testing
---
File Attachments (updated)
strip_space.gif
https://reviews.apache.org/media/uploaded/files/2017/05/03/79afd0b1-5fb1-437c-a91c-732009af8fe3__strip_space.gif
Thanks,
haosdent huang
9f3de5427071fc61d3791c4bc2a660368c2cd3c2
Diff: https://reviews.apache.org/r/58874/diff/2/
Changes: https://reviews.apache.org/r/58874/diff/1-2/
Testing
---
Thanks,
haosdent huang
e copy content would
not include `` in my browser. Is it work in your side?
- haosdent
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58874/#review173499
-------
On April 30, 2017, 4:29 a.m., haosden
ut the
> > problem and the fix in the description?
Fixed, thank you.
- haosdent
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58872/#review173525
---
On May 3, 2017, 4:15 a.m., haos
);
$scope.$on('$routeChangeStart', removeListener);
```
Do you think we need to add comment about this here?
- haosdent
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache
://reviews.apache.org/r/58872/diff/1-2/
Testing
---
Thanks,
haosdent huang
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58944/#review173691
---
Ship it!
Ship It!
- haosdent huang
On May 3, 2017, 3:58 a.m
"Example:\n"
"{\n"
" \"allowed_devices\": [\n"
"{\n"
" \"device\": {\n"
"\"path\": \"/path/to/device\"\n"
" },\n&qu
/58874/diff/1/
Testing
---
Thanks,
haosdent huang
://reviews.apache.org/r/58872/diff/1/
Testing
---
Thanks,
haosdent huang
.
- haosdent huang
On April 27, 2017, 7:01 a.m., Zhongbo Tian wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
t;https://reviews.apache.org/r/58603/#comment246094>
Nit: we prefer to put `+` at the end.
- haosdent huang
On April 25, 2017, 5:40 a.m., Zhongbo Tian wrote:
>
> ---
> This is an automatically generated e-mail. To re
-139 (patched)
<https://reviews.apache.org/r/58548/#comment245861>
hi, @bamhler, do you think if we need to replace `used_` to `allocated_` in
these variables as well?
- haosdent huang
On April 20, 2017, 1:53 a.m., Benjamin Mahler
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58547/#review172828
---
Ship it!
Ship It!
- haosdent huang
On April 20, 2017, 1:53
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58548/#review172827
---
Ship it!
Ship It!
- haosdent huang
On April 20, 2017, 1:53
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58549/#review172826
---
Ship it!
Ship It!
- haosdent huang
On April 20, 2017, 1:53
\"/path/to/device\",\n"
"\"read_access\": true,\n"
" \"write_access\": false,\n"
"\"mknod_access\": false\n"
"}\n"
"]\n"
test this tmr and
then could go head. Thanks a lot @windreamer's contributions!
- haosdent huang
On April 12, 2017, 4:17 a.m., Zhongbo Tian wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
ters();
+capAddParameter->set_key("cap-add");
+capAddParameter->set_value("SYS_ADMIN");
+capAddParameter = dockerInfo.add_parameters();
+capAddParameter->set_key("cap-add");
+ capAddParameter->set_value("SYS_PTRACE
r to what we do in
`add(&Flags::allowed_capabilities`.
- haosdent huang
On April 11, 2017, 9:40 a.m., Zhongbo Tian wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https:
tps://reviews.apache.org/r/58200/#comment244303>
I think it is fine to use priviliged to lauch mesos-executor. But after
discussed with @xiaods, let me find if we could avoid to use privileged via
--cap-add.
- haosdent huang
On April 8, 2017, 11:12 a.m., Deshi Xiao
> On April 7, 2017, 4:31 p.m., haosdent huang wrote:
> >
This requires `mesos-docker-executor` share the same namespace with
`mesos-agent`. So need `--pid=host`.
And `nsenter` requires privileged permissions, so need `--privileged=true`.
-
eter = dockerInfo.add_parameters();
+privilegedParameter->set_key("privileged");
+privilegedParameter->set_value("true");
+
```
and work in my side. May you help to double check again?
- haosd
tps://reviews.apache.org/r/58200/#comment244255>
Got this error
```
Failed to enter the net namespace of task (pid: '78851'): Operation not
permitted
```
Need to add capacity.
- haosdent huang
On April 5, 2017, 11:35 p.m.,
? I would like
to do the verification in my side.
- haosdent huang
On April 5, 2017, 6:59 a.m., Deshi Xiao wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
number}}
+ {{role.resources.cpus | decimalFloat}}
+ {{role.resources.gpus | decimalFloat}}
+ {{role.resources.mem * (1024 * 1024) | dataSize}}
+ {{role.resources.disk * (1024 * 1024) | dataSize}}
```
here
- haosdent huang
On March 16, 2017, 1:28 a.m., Benjamin Mahler
/app.js
Lines 21-22 (patched)
<https://reviews.apache.org/r/57622/#comment241712>
Let's ensure the order is alphabetically.
- haosdent huang
On March 16, 2017, 1:28 a.m., Benjamin Mahler wrote:
>
> ---
> This
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57623/#review169357
---
Ship it!
Ship It!
- haosdent huang
On March 14, 2017, 10:30
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57629/#review168966
---
Ship it!
Ship It!
- haosdent huang
On March 15, 2017, 2:06
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57575/#review168861
---
Ship it!
Ship It!
- haosdent huang
On March 14, 2017, 12:05
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57574/#review168856
---
Ship it!
Ship It!
- haosdent huang
On March 14, 2017, 12:04
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57422/#review168303
---
Ship it!
Ship It!
- haosdent huang
On March 8, 2017, 3:56
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56732/#review168234
---
Ship it!
Ship It!
- haosdent huang
On Feb. 15, 2017, 11:22
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56731/#review168233
---
Ship it!
Ship It!
- haosdent huang
On Feb. 15, 2017, 11:24
: $(SHARED_LIBS) $(SHARED_PROGRAMS) $(STATIC_OUTDIR)/libleveldb.a
$(STATIC_OUTDIR)/libmemenv.a $(STATIC_PROGRAMS)
+all: $(STATIC_OUTDIR)/libleveldb.a
``
- haosdent huang
On Feb. 20, 2017, 4:45 p.m., Tomasz Janiszewski wrote:
>
> ---
> T
.
```
-all: $(SHARED_LIBS) $(SHARED_PROGRAMS) $(STATIC_OUTDIR)/libleveldb.a
$(STATIC_OUTDIR)/libmemenv.a $(STATIC_PROGRAMS)
+all: $(STATIC_OUTDIR)/libleveldb.a
```
- haosdent huang
On Feb. 20, 2017, 11:52 a.m., Tomasz Janiszewski wrote
docs.google.com/document/d/1fv2OMvH6hVm6waacOejSrTJwUuDQeXlqqPDZjBmbcKU/edit#
> and check if everything is OK.
>
> haosdent huang wrote:
> I could help to run from 1.14 to 1.19 if it is necessary. :)
>
> Tomasz Janiszewski wrote:
> I took care of it. Folloed steps presented by Haosdent it works the same
docs.google.com/document/d/1fv2OMvH6hVm6waacOejSrTJwUuDQeXlqqPDZjBmbcKU/edit#
> and check if everything is OK.
>
> haosdent huang wrote:
> I could help to run from 1.14 to 1.19 if it is necessary. :)
>
> Tomasz Janiszewski wrote:
> I took care of it. Folloed steps presented by Haosdent it works the same
)
```
- haosdent huang
On Feb. 20, 2017, 4:41 a.m., Tomasz Janiszewski wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
g/r/54821/#comment237921>
Since we use `int_fd` now, I update to
```
Try fd = os::open(
```
here.
- haosdent huang
On Feb. 6, 2017, 9:28 p.m., Zhitao Li wrote:
>
> ---
> This is an automatically generated e
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56238/#review166018
---
Ship it!
Ship It!
- haosdent huang
On Feb. 18, 2017, 2:23
eply, visit:
https://reviews.apache.org/r/51624/#review163743
---
On Oct. 8, 2016, 12:37 p.m., haosdent huang wrote:
>
> ---
> This is an automatically generated e-mai
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55160/#review164450
---
Ship it!
Ship It!
- haosdent huang
On Feb. 6, 2017, 9:29
...@mesos.apache.org about this. So other develpers would not foget to add
`syntax 2` in protobuf files..
- haosdent huang
On Feb. 2, 2017, 8:12 p.m., Anthony Sottile wrote:
>
> ---
> This is an automatically generated e-mail. To rep
```
src/webui/master/static/maintenance.html (line 30)
<https://reviews.apache.org/r/53741/#comment236017>
Nit: Indent should be 2.
``
{{machine_ids.hostname ? machine_ids.hostname
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56214/#review164322
---
Ship it!
Ship It!
- haosdent huang
On Feb. 2, 2017, 9:57
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56209/#review164321
---
Ship it!
Ship It!
- haosdent huang
On Feb. 2, 2017, 9:56
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56288/#review164314
---
Ship it!
Ship It!
- haosdent huang
On Feb. 3, 2017, 7:50
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55900/#review164311
---
Ship it!
Ship It!
- haosdent huang
On Feb. 2, 2017, 4:54
1 - 100 of 3998 matches
Mail list logo
