/containerizer/mesos/isolators/cgroups/cgroups.cpp
2f6723c64261fb3295626d6479fe844fb23b0650
Diff: https://reviews.apache.org/r/51185/diff/
Testing
---
Thanks,
haosdent huang
/linux/cgroups.cpp 1475c8eb848ece2a093e8243b51e9ce08981dd7d
src/tests/containerizer/cgroups_tests.cpp
0afaec6ae948cabf1472bf01103210d8f9809cb1
src/tests/mesos.cpp 2aae160fb941ab3672a5665ae27f517ff40600e2
Diff: https://reviews.apache.org/r/51031/diff/
Testing
---
Thanks,
haosdent
80)
<https://reviews.apache.org/r/53013/#comment222530>
A extra blank line below?
- haosdent huang
On Oct. 19, 2016, 4:47 a.m., Joris Van Remoortere wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53012/#review153251
---
Ship it!
Ship It!
- haosdent huang
On Oct. 19, 2016, 4:47
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53017/#review153250
---
Ship it!
Ship It!
- haosdent huang
On Oct. 19, 2016, 8:23
>
> (Updated Oct. 12, 2016, 5:02 p.m.)
>
>
> Review request for mesos, Gilbert Song, haosdent huang, and Jie Yu.
>
>
> Bugs: MESOS-6134
> https://issues.apache.org/jira/browse/MESOS-6134
>
>
> Repository: mesos
>
>
> Descriptio
ted e-mail. To reply, visit:
> https://reviews.apache.org/r/52880/
> -------
>
> (Updated Oct. 14, 2016, 5:18 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Anand Mazumdar, haosdent
> huang, Jie Yu, and Jiang Yan
> On Oct. 17, 2016, 5:52 p.m., haosdent huang wrote:
> > src/launcher/default_executor.cpp, line 1034
> > <https://reviews.apache.org/r/52879/diff/1/?file=1538032#file1538032line1034>
> >
> > Let's use `agent_pid` here? Since we rename slave to agent.
&
> On Oct. 17, 2016, 5:52 p.m., haosdent huang wrote:
> > src/launcher/default_executor.cpp, line 1034
> > <https://reviews.apache.org/r/52879/diff/1/?file=1538032#file1538032line1034>
> >
> > Let's use `agent_pid` here? Since we rename slave to agent.
` in
`docker-executor`?
- haosdent huang
On Oct. 14, 2016, 5:17 p.m., Gastón Kleiman wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52878/#review152913
---
Ship it!
Ship It!
- haosdent huang
On Oct. 14, 2016, 1:35
/r/52879/#comment222098>
If rephrase to
```
The directory's absolute path of Mesos binaries
```
would be better?
- haosdent huang
On Oct. 14, 2016, 5:17 p.m., Gastón Kleiman wrote:
>
> ---
> Th
if (paused) {
return;
}
```
here?
- haosdent huang
On Oct. 14, 2016, 12:52 p.m., Alexander Rukletsov wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52869/#review152907
---
Ship it!
Ship It!
- haosdent huang
On Oct. 14, 2016, 12:41
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52870/#review152906
---
Ship it!
Ship It!
- haosdent huang
On Oct. 14, 2016, 12:42
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52871/#review152905
---
Ship it!
Ship It!
- haosdent huang
On Oct. 14, 2016, 12:52
(lines 142 - 143)
<https://reviews.apache.org/r/52873/#comment222091>
`clone` looks not an internal state here? How about just remove this
comment?
- haosdent huang
On Oct. 14, 2016, 12:45 p.m., Alexander Rukletsov wrote:
>
> --
>
> (Updated Oct. 14, 2016, 3:26 p.m.)
>
>
> Review request for mesos, Daniel Pravat, Gastón Kleiman, haosdent huang, and
> Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> ---
>
> Additionally persist health check par
tps://reviews.apache.org/r/52867/#comment222070>
Here need to be `checkGracePeriod.secs()`, otherwise would compile failed.
- haosdent huang
On Oct. 14, 2016, 3:26 p.m., Alexander Rukletsov wrote:
>
> ---
> This is an automatically g
ATION
src/tests/containerizer/health_check_test_helper.cpp PRE-CREATION
src/tests/test_helper_main.cpp 129a5e427b72fb577e55c3756d071f72ced9ff14
Diff: https://reviews.apache.org/r/52786/diff/
Testing
---
Thanks,
haosdent huang
] 19 tests.
```
Thanks,
haosdent huang
://reviews.apache.org/r/52561/diff/
Testing
---
Thanks,
haosdent huang
s.cpp 1d1676d7259bf52cfb1e499954fa815fe7e37522
Diff: https://reviews.apache.org/r/52251/diff/
Testing
---
Thanks,
haosdent huang
/52560/diff/
Testing
---
Thanks,
haosdent huang
generated e-mail. To reply, visit:
https://reviews.apache.org/r/52786/#review152863
---
On Oct. 17, 2016, 2:51 p.m., haosdent huang wrote:
>
> ---
> This
1d1676d7259bf52cfb1e499954fa815fe7e37522
Diff: https://reviews.apache.org/r/52250/diff/
Testing
---
Thanks,
haosdent huang
s.cpp 1d1676d7259bf52cfb1e499954fa815fe7e37522
Diff: https://reviews.apache.org/r/52250/diff/
Testing
---
Thanks,
haosdent huang
> On Oct. 17, 2016, 7:03 a.m., haosdent huang wrote:
> > Is there any reason we try to avoid `check.interval_seconds()` in
> > `reschedule`. Would be greate if could update the commit message about the
> > motivation.
>
> haosdent huang wrote:
> I feel i
> On Oct. 17, 2016, 7:03 a.m., haosdent huang wrote:
> > Is there any reason we try to avoid `check.interval_seconds()` in
> > `reschedule`. Would be greate if could update the commit message about the
> > motivation.
I feel it would be better to use https://reviews.apach
tps://reviews.apache.org/r/52867/#comment221954>
Is it possible to use `checkTimeout` here directly?
- haosdent huang
On Oct. 14, 2016, 3:26 p.m., Alexander Rukletsov wrote:
>
> ---
> This is an automatically generated e
`reschedule`.
Would be greate if could update the commit message about the motivation.
- haosdent huang
On Oct. 14, 2016, 12:38 p.m., Alexander Rukletsov wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
tps://reviews.apache.org/r/52865/#comment221953>
Should add
```
.WillRepeatedly(Return()); // Ignore subsequent updates.
```
here?
- haosdent huang
On Oct. 14, 2016, 12:37 p.m., Alexander Rukletsov
tps://reviews.apache.org/r/52865/#comment221952>
After we never stop health check, `consecutiveFailures` may become to 0
after success again. Then `killTask` would transform from `true` to `false`
here. Is it a expected bahaviour?
- haosdent huang
On Oct. 14, 2016, 12:37 p.m., Ale
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52864/#review152826
---
Ship it!
Ship It!
- haosdent huang
On Oct. 14, 2016, 12:35
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52863/#review152825
---
Ship it!
Ship It!
- haosdent huang
On Oct. 14, 2016, 12:35
OCK
??? LOG
??? MANIFEST-02
13 directories, 7 files
```
Thanks,
haosdent huang
OCK
??? LOG
??? MANIFEST-02
13 directories, 7 files
```
Thanks,
haosdent huang
-S0
? ??? provisioner
??? master
??? work_dir
??? replicated_log
??? 04.log
??? CURRENT
??? LOCK
??? LOG
??? MANIFEST-02
13 directories, 7 files
```
Thanks,
haosdent huang
work_dir
??? replicated_log
??? 04.log
??? CURRENT
??? LOCK
??? LOG
??? MANIFEST-02
12 directories, 7 files
```
Thanks,
haosdent huang
: https://reviews.apache.org/r/52856/diff/
Testing
---
Thanks,
haosdent huang
2e95d2-S0
? ??? provisioner
??? master
??? work_dir
??? replicated_log
??? 04.log
??? CURRENT
??? LOCK
??? LOG
??? MANIFEST-02
12 directories, 7 files
```
Thanks,
haosdent huang
rk_dir
??? replicated_log
??? 04.log
??? CURRENT
??? LOCK
??? LOG
??? MANIFEST-02
20 directories, 9 files
```
Thanks,
haosdent huang
t.
- haosdent
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52787/#review152763
---
On Oct. 16, 2016, 4:59 a.m., haosd
$ mesos-execute --master=127.0.0.1:5050 --name="test-single-1" --command="sleep
2000"
WARNING: Logging before InitGoogleLogging() is written to STDERR
W1014 12:25:39.922174 3211264 scheduler.cpp:161]
**
Scheduler driver bound to loopback interface! Cannot communicate with remote
master(s). You might want to set 'LIBPROCESS_IP' environment variable to use a
routable IP address.
**
I1014 12:25:39.922353 3211264 scheduler.cpp:176] Version: 1.1.0
I1014 12:25:39.927863 3211264 scheduler.cpp:465] New master detected at
master@127.0.0.1:5050
Subscribed with ID b3af099b-8ee5-4fbe-b27b-fe4832b141c2-0001
Submitted task 'test-single-1' to agent
'ed8e545b-d1e5-4d22-bc88-517be5632779-S0'
Received status update TASK_RUNNING for task 'test-single-1'
source: SOURCE_EXECUTOR
```
Thanks,
haosdent huang
: https://reviews.apache.org/r/52856/diff/
Testing
---
Thanks,
haosdent huang
l.cpp 257179443827ffdfc946ed655a6840fcea70d454
Diff: https://reviews.apache.org/r/52856/diff/
Testing
---
Thanks,
haosdent huang
://reviews.apache.org/r/52906/diff/
Testing
---
```
sudo GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="*TaskUsesExecutor*" --verbose
sudo GLOG_v=1 ./bin/mesos-tests.sh
--gtest_filter="*TaskGroupValidationTest.TaskUsesDifferentExecutor*" --verbose
```
Thanks,
haosdent huang
est_filter="*TaskGroupValidationTest.TaskUsesDifferentExecutor*" --verbose
```
Thanks,
haosdent huang
tor*" --verbose
```
Thanks,
haosdent huang
---
Thanks,
haosdent huang
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52817/#review152756
---
On Oct. 13, 2016, 6:36 a.m., haosdent huang wrote:
>
>
rote:
> Changing `mesos-local-flags.in.sh` to have the following should address
> both issues:
>
> ```
> : ${MESOS_WORK_DIR:=/tmp/mesos/work_dir}
> : ${MESOS_RUNTIME_DIR:=/tmp/mesos/runtime_dir}
>
> export MESOS_WORK_DIR
> export ME
RUNTIME_DIR
> ```
yep, now use `.sh` would have this problem. Use `src/mesos-local` would be fine.
- haosdent
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52787/#review152704
os/containers/8e3a559a-5b13-4460-bb7f-d1e107ab49f0':
> > Permission denied; Abnormal executor termination: unknown container'
> > source: SOURCE_AGENT
> > reason: REASON_CONTAINER_LAUNCH_FAILED
> > ```
> >
> > Digging into the code in `local.cpp`,
,
haosdent huang
*
Scheduler driver bound to loopback interface! Cannot communicate with remote
master(s). You might want to set 'LIBPROCESS_IP' environment variable to use a
routable IP address.
**
I1014 12:25:39.922353 3211264 scheduler.cpp:176] Version: 1.1.0
I1014 12:25:39.927863 3211264 scheduler.cpp:465] New master detected at
master@127.0.0.1:5050
Subscribed with ID b3af099b-8ee5-4fbe-b27b-fe4832b141c2-0001
Submitted task 'test-single-1' to agent
'ed8e545b-d1e5-4d22-bc88-517be5632779-S0'
Received status update TASK_RUNNING for task 'test-single-1'
source: SOURCE_EXECUTOR
```
Thanks,
haosdent huang
g/r/50003/#comment221720>
The `flags` is shadown with the outside variable `flags`. Need to rename to
`masterFlags`.
- haosdent huang
On Aug. 10, 2016, 11:28 p.m., Ammar Askar wrote:
>
> ---
> This is an automatically gener
visit:
https://reviews.apache.org/r/52251/#review152507
-------
On Oct. 12, 2016, 2:37 p.m., haosdent huang wrote:
>
> ---
> This is an automatically genera
ed e-mail. To reply, visit:
https://reviews.apache.org/r/52250/#review152509
-------
On Oct. 12, 2016, 2:37 p.m., haosdent huang wrote:
>
> ---
> This is an automatically genera
to our health
check test cases don't depends on `nc`.
But another simple solution is we make `agent` bind to `0.0.0.0` as this
email said http://search-hadoop.com/m/0Vlr6SPE4d1hepk5
- haosdent huang
On Oct. 12, 2016, 2:37 p.m., haosdent
t;MESOS_");
```
in `local.cpp`, it works although the code in `local.cpp` have not been
updated. But I think it should work in your side as well? How you launch the
`mesos-local`? Do you use `./bin/mesos-local.sh`?
- haosdent
-------
y, visit:
https://reviews.apache.org/r/52787/#review152530
---
On Oct. 13, 2016, 5:06 p.m., haosdent huang wrote:
>
> ---
> This is an automatically generated e-mail.
ected at
master@127.0.0.1:5050
Subscribed with ID 51e0d33f-d7b2-4c01-9bb3-10731cc7d1ab-
Submitted task 'test-single-1' to agent
'8fba7ecb-b70e-48ac-9541-2070c4d9b1d5-S0'
Received status update TASK_RUNNING for task 'test-single-1'
source: SOURCE_EXECUTOR
```
Thanks,
haosdent huang
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52787/#review152455
---
On Oct. 13, 2016, 6:44 a.m., haosdent huang wrote:
>
> ---
ntime directory
'/var/run/mesos/containers/f2d6947f-2916-4f1a-90dc-3d137b360b9c': Permission
denied; Abnormal executor termination: unknown container'
```
Thanks,
haosdent huang
ter/static/home.html 179cb15140f85811df0ea0a87620dd3c90dd30c7
src/webui/master/static/js/app.js 400a4286d9358c699453326d87a0bd49dbb105a7
src/webui/master/static/js/controllers.js
29a5a1c8754cc2fb934854750d6dfb04f1eaeae4
Diff: https://reviews.apache.org/r/52471/diff/
Testing
---
Thanks,
29a5a1c8754cc2fb934854750d6dfb04f1eaeae4
Diff: https://reviews.apache.org/r/52664/diff/
Testing
---
Thanks,
haosdent huang
src/slave/http.cpp a1fbb7aa8209c92aa59833f1df98475b46830537
src/tests/default_executor_tests.cpp 9e0fd678a7f5e9c2288fbb11a60cf6f339efa24f
Diff: https://reviews.apache.org/r/52520/diff/
Testing
---
Thanks,
haosdent huang
cad243f7222e93030fa5a9c00955e9ef55f3c805
Diff: https://reviews.apache.org/r/52817/diff/
Testing
---
Thanks,
haosdent huang
case `DefaultExecutorTest.ROOT_TaskUsesExecutor`.
Thanks,
haosdent huang
`DefaultExecutorTest.ROOT_TaskUsesExecutor`.
Thanks,
haosdent huang
ter/static/home.html 179cb15140f85811df0ea0a87620dd3c90dd30c7
src/webui/master/static/js/app.js 400a4286d9358c699453326d87a0bd49dbb105a7
src/webui/master/static/js/controllers.js
29a5a1c8754cc2fb934854750d6dfb04f1eaeae4
Diff: https://reviews.apache.org/r/52471/diff/
Testing
---
Thanks,
src/slave/http.cpp 79061c3cd94d856ec695e5a82bf6792bf089d1f8
src/tests/default_executor_tests.cpp 9e0fd678a7f5e9c2288fbb11a60cf6f339efa24f
Diff: https://reviews.apache.org/r/52520/diff/
Testing
---
Thanks,
haosdent huang
/controllers.js
29a5a1c8754cc2fb934854750d6dfb04f1eaeae4
Diff: https://reviews.apache.org/r/52664/diff/
Testing
---
Thanks,
haosdent huang
e5da3c9bf0a1042b42522f1ab74ce798fbb1738d
src/tests/default_executor_tests.cpp 9e0fd678a7f5e9c2288fbb11a60cf6f339efa24f
src/tests/master_validation_tests.cpp
99e350e0587e73e9ee25ef20dd369cd146bd446a
Diff: https://reviews.apache.org/r/52470/diff/
Testing
---
Thanks,
haosdent huang
r'
```
Thanks,
haosdent huang
://reviews.apache.org/r/52561/diff/
Testing
---
Thanks,
haosdent huang
1d1676d7259bf52cfb1e499954fa815fe7e37522
Diff: https://reviews.apache.org/r/52251/diff/
Testing
---
Thanks,
haosdent huang
SSED ] 19 tests.
```
Thanks,
haosdent huang
/test_helper_main.cpp 129a5e427b72fb577e55c3756d071f72ced9ff14
Diff: https://reviews.apache.org/r/52786/diff/
Testing
---
Thanks,
haosdent huang
://reviews.apache.org/r/52560/diff/
Testing
---
Thanks,
haosdent huang
1d1676d7259bf52cfb1e499954fa815fe7e37522
Diff: https://reviews.apache.org/r/52250/diff/
Testing
---
Thanks,
haosdent huang
xecutorInfo` (Call `Master::addTask`) as well.
- haosdent
-------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52470/#review152218
--
e5da3c9bf0a1042b42522f1ab74ce798fbb1738d
Diff: https://reviews.apache.org/r/52470/diff/
Testing
---
Thanks,
haosdent huang
ter/static/home.html 179cb15140f85811df0ea0a87620dd3c90dd30c7
src/webui/master/static/js/app.js 400a4286d9358c699453326d87a0bd49dbb105a7
src/webui/master/static/js/controllers.js
29a5a1c8754cc2fb934854750d6dfb04f1eaeae4
Diff: https://reviews.apache.org/r/52471/diff/
Testing
---
Thanks,
29a5a1c8754cc2fb934854750d6dfb04f1eaeae4
Diff: https://reviews.apache.org/r/52664/diff/
Testing
---
Thanks,
haosdent huang
src/slave/http.cpp 79061c3cd94d856ec695e5a82bf6792bf089d1f8
src/tests/default_executor_tests.cpp 9e0fd678a7f5e9c2288fbb11a60cf6f339efa24f
Diff: https://reviews.apache.org/r/52520/diff/
Testing
---
Thanks,
haosdent huang
ter/static/home.html 179cb15140f85811df0ea0a87620dd3c90dd30c7
src/webui/master/static/js/app.js 400a4286d9358c699453326d87a0bd49dbb105a7
src/webui/master/static/js/controllers.js
29a5a1c8754cc2fb934854750d6dfb04f1eaeae4
Diff: https://reviews.apache.org/r/52471/diff/
Testing
---
Thanks,
n.cpp e5da3c9bf0a1042b42522f1ab74ce798fbb1738d
Diff: https://reviews.apache.org/r/52470/diff/
Testing (updated)
---
Thanks,
haosdent huang
(35264 ms total)
[ PASSED ] 19 tests.
```
Thanks,
haosdent huang
://reviews.apache.org/r/52561/diff/
Testing
---
Thanks,
haosdent huang
/52560/diff/
Testing
---
Thanks,
haosdent huang
1d1676d7259bf52cfb1e499954fa815fe7e37522
Diff: https://reviews.apache.org/r/52251/diff/
Testing
---
Thanks,
haosdent huang
1d1676d7259bf52cfb1e499954fa815fe7e37522
Diff: https://reviews.apache.org/r/52250/diff/
Testing
---
Thanks,
haosdent huang
> On Oct. 10, 2016, 6:54 p.m., Vinod Kone wrote:
> > I think it's probably worth to just mutate TaskInfo like you did in the
> > very first diff rather than doing all these changes. They are bit messy and
> > incomplete.
>
> haosdent huang wrote:
>
ter/static/home.html 179cb15140f85811df0ea0a87620dd3c90dd30c7
src/webui/master/static/js/app.js 400a4286d9358c699453326d87a0bd49dbb105a7
src/webui/master/static/js/controllers.js
29a5a1c8754cc2fb934854750d6dfb04f1eaeae4
Diff: https://reviews.apache.org/r/52471/diff/
Testing
---
Thanks,
src/slave/http.cpp 79061c3cd94d856ec695e5a82bf6792bf089d1f8
src/tests/default_executor_tests.cpp 9e0fd678a7f5e9c2288fbb11a60cf6f339efa24f
Diff: https://reviews.apache.org/r/52520/diff/
Testing
---
Thanks,
haosdent huang
`CommandExecutorTest.EmptyExecutorIdInTask`.
Thanks,
haosdent huang
use mutating way.
- haosdent
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52470/#review152034
---
On Oct. 8, 2016, 1
he.org/r/52092/#review152004
---
On Oct. 11, 2016, 3:53 a.m., haosdent huang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://
401 - 500 of 3998 matches
Mail list logo
