Re: Review Request 63271: Windows: Added `os::set_job_mem_limit` to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63271/#review190955 --- Ship it! Ship It! - Aaron Wood On Nov. 14, 2017, 12:20

Re: Review Request 63279: Increased check tests task resources for Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63279/#review189972 --- Ship it! Ship It! - Aaron Wood On Nov. 2, 2017, 8:40 p.m.,

Re: Review Request 63278: Windows: Documented the `cpuset` and `mem` isolators.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63278/#review189971 --- Ship it! Ship It! - Aaron Wood On Nov. 2, 2017, 8:40 p.m.,

Re: Review Request 63273: Windows: Added `os::get_job_processes` to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63273/#review189966 --- 3rdparty/stout/include/stout/windows/os.hpp Lines 793 (patched)

Re: Review Request 63268: Windows: Fixed variable casing in `windows/os.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63268/#review189963 --- Ship it! Ship It! - Aaron Wood On Nov. 2, 2017, 8:39 p.m.,

Re: Review Request 63268: Windows: Fixed variable casing in `windows/os.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63268/#review189962 --- 3rdparty/stout/include/stout/windows/os.hpp Line 669 (original),

Re: Review Request 60280: Provide full path to the custom executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60280/ --- (Updated July 6, 2017, 10:44 p.m.) Review request for mesos, Jie Yu, James

Review Request 60693: Move permissions.hpp under posix

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60693/ --- Review request for mesos, Andrew Schwartzmeyer and Jie Yu. Bugs: MESOS-7764

Re: Review Request 60280: Provide full path to the custom executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60280/ --- (Updated July 6, 2017, 3:32 p.m.) Review request for mesos, Jie Yu, James

Re: Review Request 60280: Provide full path to the custom executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60280/ --- (Updated July 6, 2017, 3:27 p.m.) Review request for mesos, Jie Yu, James

Re: Review Request 60280: Provide full path to the custom executor.

> On July 6, 2017, 2:59 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/launch.cpp > > Lines 808 (patched) > > > > > > This line is longger than 80 chars: > > > > ``` > > Jies-MacBook-Pro:mesos

Re: Review Request 60280: Provide full path to the custom executor.

> On July 6, 2017, 2:59 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/launch.cpp > > Lines 808 (patched) > > > > > > This line is longger than 80 chars: > > > > ``` > > Jies-MacBook-Pro:mesos

Re: Review Request 60280: Provide full path to the custom executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60280/ --- (Updated July 5, 2017, 9:03 p.m.) Review request for mesos, Jie Yu, James

Re: Review Request 60280: Provide full path to the custom executor.

> On June 30, 2017, 11:48 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/launch.cpp > > Lines 799 (patched) > > > > > > What if `launchInfo.working_directory()` is not set? Maybe use > > os::realpath here to

Re: Review Request 60280: Provide full path to the custom executor.

> On July 5, 2017, 4:48 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/launch.cpp > > Lines 799 (patched) > > > > > > This is still based on the assumption that `launchInfo` has > > `working_directory()`

Re: Review Request 60546: Harden Mesos when building with cmake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60546/ --- (Updated July 5, 2017, 4:06 p.m.) Review request for mesos, Andrew

Re: Review Request 60546: Harden Mesos when building with cmake.

> On July 4, 2017, 3:06 p.m., Benjamin Bannier wrote: > > cmake/CompilationConfigure.cmake > > Lines 213-214 (patched) > > > > > > Not sure this is needed, see below. Relating to my comment below, I saw that `-pie`

Re: Review Request 60280: Provide full path to the custom executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60280/ --- (Updated July 3, 2017, 6:35 p.m.) Review request for mesos, Jie Yu, James

Re: Review Request 60280: Provide full path to the custom executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60280/ --- (Updated July 3, 2017, 4:18 p.m.) Review request for mesos, Jie Yu, James

Re: Review Request 60280: Provide full path to the custom executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60280/ --- (Updated July 3, 2017, 4 p.m.) Review request for mesos, Jie Yu, James Peach,

Re: Review Request 60280: Provide full path to the custom executor.

> On June 30, 2017, 11:48 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/launch.cpp > > Lines 799 (patched) > > > > > > What if `launchInfo.working_directory()` is not set? Maybe use > > os::realpath here to

Review Request 60546: Harden Mesos when building with cmake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60546/ --- Review request for mesos, Andrew Schwartzmeyer and Joseph Wu. Bugs: MESOS-7737

Re: Review Request 60280: Provide full path to the custom executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60280/ --- (Updated June 22, 2017, 3:20 p.m.) Review request for mesos, Jie Yu, James

Re: Review Request 60280: Provide full path to the custom executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60280/ --- (Updated June 22, 2017, 3:19 p.m.) Review request for mesos, Jie Yu, James

Re: Review Request 60280: Provide full path to the custom executor.

> On June 21, 2017, 11:07 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/launch.cpp > > Lines 671-674 (patched) > > > > > > Sorry, I got confused. User should be the one setting argv[0]. So we > > don't need

Re: Review Request 60280: Provide full path to the custom executor.

> On June 21, 2017, 9:54 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/launch.cpp > > Lines 801 (patched) > > > > > > Why this is necessary? I think execvp will look into the current > > working directory?

Re: Review Request 60280: Provide full path to the custom executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60280/ --- (Updated June 21, 2017, 10:26 p.m.) Review request for mesos, Jie Yu, James

Re: Review Request 60280: Provide full path to the custom executor.

> On June 21, 2017, 7:28 p.m., Aaron Wood wrote: > > Someone correct me if I'm wrong, but I don't think we need this anymore: > > ``` > > if (launchInfo.has_working_directory()) { > > Try chdir = os::chdir(launchInfo.working_directory()); > > if (chdir.isError()) { > > cerr <<

Re: Review Request 60280: Provide full path to the custom executor.

> On June 21, 2017, 9:54 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/launch.cpp > > Lines 801 (patched) > > > > > > Why this is necessary? I think execvp will look into the current > > working directory?

Re: Review Request 60280: Provide full path to the custom executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60280/#review178534 --- Someone correct me if I'm wrong, but I don't think we need this

Review Request 60280: Provide full path to the custom executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60280/ --- Review request for mesos, Jie Yu, James Peach, and Zhitao Li. Bugs: MESOS-7703

Re: Review Request 59641: Attach latest symlink when executor is registered.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59641/ --- (Updated June 5, 2017, 9:36 p.m.) Review request for mesos, Andrew

Re: Review Request 59641: Follow symlinks when resolving paths specified in the various master/agent endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59641/ --- (Updated June 2, 2017, 8:59 p.m.) Review request for mesos, Andrew

Re: Review Request 59641: Follow symlinks when resolving paths specified in the various master/agent endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59641/ --- (Updated June 2, 2017, 2:28 p.m.) Review request for mesos, Andrew

Re: Review Request 59641: Follow symlinks when resolving paths specified in the various master/agent endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59641/ --- (Updated June 1, 2017, 9:22 p.m.) Review request for mesos, Andrew

Re: Review Request 59641: Follow symlinks when resolving paths specified in the various master/agent endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59641/ --- (Updated May 31, 2017, 6:57 p.m.) Review request for mesos, Andrew

Re: Review Request 59641: Follow symlinks when resolving paths specified in the various master/agent endpoints.

> On May 31, 2017, 1:05 a.m., Vinod Kone wrote: > > src/files/files.cpp > > Line 874 (original), 874 (patched) > > > > > > I don't follow this. Why are we checking random prefixes for whether > > they are symlinks

Re: Review Request 59641: Follow symlinks when resolving paths specified in the various master/agent endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59641/ --- (Updated May 30, 2017, 8:14 p.m.) Review request for mesos, Andrew

Re: Review Request 59641: Follow symlinks when resolving paths specified in the various master/agent endpoints.

> On May 30, 2017, 6:31 p.m., Zhitao Li wrote: > > Is it possible to add an integration test in `src/tests/files_tests.cpp`? Sure, I can create a directory and a symlink pointing to it and make sure it passes. FWIW that test is currently disabled on Windows. > On May 30, 2017, 6:31 p.m.,

Review Request 59641: Follow symlinks when resolving paths specified in the various master/agent endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59641/ --- Review request for mesos, Andrew Schwartzmeyer, James Peach, Vinod Kone, and

Re: Review Request 59413: Fix bytes.hpp constexpr compilation failure with GCC 7.1.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59413/ --- (Updated May 25, 2017, 6:13 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 59413: Fix bytes.hpp constexpr compilation failure with GCC 7.1.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59413/ --- (Updated May 25, 2017, 4:42 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 59536: CMake: Added SHA256 hashes for 3rdparty downloads.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59536/#review175985 --- Ship it! Ship It! - Aaron Wood On May 24, 2017, 7:13 p.m.,

Re: Review Request 59536: CMake: Added SHA256 hashes for 3rdparty downloads.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59536/#review175979 --- Are these hashes checked anywhere? I didn't seen anything that's

Re: Review Request 59454: Adjust tests to account for GCC 7.1 fix in bytes.hpp.

> On May 23, 2017, 10:50 p.m., James Peach wrote: > > src/tests/role_tests.cpp > > Line 909 (original), 909 (patched) > > > > > > I think this should be: > > ``` > > constexpr Bytes DISK_SIZE = Megabytes(1);

Re: Review Request 59454: Adjust tests to account for GCC 7.1 fix in bytes.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59454/ --- (Updated May 24, 2017, 5:53 p.m.) Review request for mesos, Benjamin Bannier,

Review Request 59454: Adjust test to account for changes to bytes.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59454/ --- Review request for mesos, Benjamin Bannier, James Peach, Michael Park, and Neil

Re: Review Request 59413: Fix bytes.hpp constexpr compilation failure with GCC 7.1.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59413/ --- (Updated May 22, 2017, 4:56 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 59413: Fix bytes.hpp constexpr compilation failure with GCC 7.1.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59413/ --- (Updated May 22, 2017, 4:52 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 59413: Fix constexpr compilation failure with GCC 7.1.

> On May 19, 2017, 6:51 p.m., Neil Conway wrote: > > `stout`, `libprocess`, and `mesos` are nominally distinct projects, so a > > single RR should touch no more than one of them. i.e., please split the > > `stout` changes into a separate review. > > > > Might also be worth waiting to see if

Re: Review Request 59413: Fix constexpr compilation failure with GCC 7.1.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59413/ --- (Updated May 19, 2017, 7 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 59413: Fix constexpr compilation failure with GCC 7.1.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59413/ --- (Updated May 19, 2017, 6:58 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 59413: Fix constexpr compilation failure with GCC 7.1.

> On May 19, 2017, 6:51 p.m., Neil Conway wrote: > > `stout`, `libprocess`, and `mesos` are nominally distinct projects, so a > > single RR should touch no more than one of them. i.e., please split the > > `stout` changes into a separate review. > > > > Might also be worth waiting to see if

Re: Review Request 59413: Fix constexpr compilation failure with GCC 7.1.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59413/ --- (Updated May 19, 2017, 6:51 p.m.) Review request for mesos, Benjamin Bannier,

Review Request 59413: Fix constexpr compilation failure with GCC 7.1.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59413/ --- Review request for mesos, Benjamin Bannier, James Peach, Michael Park, and Neil

Re: Review Request 58317: Prevent agent from crashing when the ID is longer than the maximum file name length.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58317/ --- (Updated April 11, 2017, 3:14 p.m.) Review request for mesos, Jie Yu and James

Re: Review Request 58317: Prevent agent from crashing when the ID is longer than the maximum file name length.

> On April 10, 2017, 11:48 p.m., Jie Yu wrote: > > src/common/validation.cpp > > Lines 42 (patched) > > > > > > 255? Cau you use NAME_MAX in the error message as well? My fault, I should have done that initially

Re: Review Request 58317: Prevent agent from crashing when the ID is longer than the maximum file name length.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58317/ --- (Updated April 10, 2017, 10:37 p.m.) Review request for mesos, Jie Yu and

Re: Review Request 58317: Prevent agent from crashing when the ID is longer than the maximum file name length.

> On April 10, 2017, 9:05 p.m., Aaron Wood wrote: > > src/common/validation.cpp > > Lines 40 (patched) > > > > > > Maybe it's better to put this check in `src/slave/paths.cpp` and add up > > the length of `rootDir`,

Re: Review Request 58317: Prevent agent from crashing when the ID is longer than the maximum file name length.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58317/#review171483 --- src/common/validation.cpp Lines 40 (patched)

Re: Review Request 58317: Prevent agent from crashing when the ID is longer than the maximum file name length.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58317/#review171456 --- src/common/validation.cpp Line 46 (original), 50 (patched)

Review Request 58317: Prevent agent from crashing when the ID is longer than the maximum file name length.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58317/ --- Review request for mesos, Jie Yu and James Peach. Bugs: MESOS-7346

Re: Review Request 54993: Modify LevelDB patch to add ARM64/AArch64 support.

> On Dec. 27, 2016, 1:48 p.m., Till Toenshoff wrote: > > This sums up the following changes on `atomic_pointer.h` done within the > > upstream project; > > https://github.com/google/leveldb/commit/803d69203a62faf50f1b77897310a3a1fcae712b > >