1e49013
src/examples/test_hook_module.cpp 43d6cb9
src/slave/slave.cpp e9f2d1b
src/tests/common/http_tests.cpp c2e7704
src/tests/hook_tests.cpp 5a5d019
Diff: https://reviews.apache.org/r/39531/diff/
Testing
---
make && make check
Thanks,
Connor Doyle
el free to drop
Updated, hopefully it's more clear now.
- Connor
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39531/#review103690
-------
On Oct. 23, 2015, 7:21 p.m., Connor Doyle wrote:
>
> ---
e Framework here. Will fix.
- Connor
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39531/#review103690
---
On Oct. 2
)
-
include/mesos/mesos.proto 9400434
include/mesos/v1/mesos.proto 8131778
src/common/http.hpp 0cc98a8
src/common/http.cpp f56d8a1
src/tests/common/http_tests.cpp c2e7704
Diff: https://reviews.apache.org/r/39531/diff/
Testing
---
make && make check
Thanks,
Connor Doyle
> On Oct. 22, 2015, 12:45 a.m., Joseph Wu wrote:
> > Can you also sync this with the V1 API? (If so, I'll remove that section
> > from this: https://reviews.apache.org/r/39502 ).
>
> Connor Doyle wrote:
> Yes, I will update the v1 proto file as well. Thanks fo
/
Testing
---
make && make check
Thanks,
Connor Doyle
)
-
include/mesos/mesos.proto 9400434
include/mesos/v1/mesos.proto 8131778
src/common/http.hpp 0cc98a8
src/common/http.cpp f56d8a1
src/tests/common/http_tests.cpp c2e7704
Diff: https://reviews.apache.org/r/39531/diff/
Testing
---
make && make check
Thanks,
Connor Doyle
Thanks,
Connor Doyle
apil, I'll try it out.
- Connor
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39531/#review103650
---
On Oct. 22, 20
Diff: https://reviews.apache.org/r/39531/diff/
Testing
---
make && make check
Thanks,
Connor Doyle
g/r/39531/diff/
Testing
---
make && make check
Thanks,
Connor Doyle
> On Oct. 22, 2015, 8:13 p.m., Kapil Arya wrote:
> > src/common/http.cpp, lines 165-180
> > <https://reviews.apache.org/r/39531/diff/5/?file=1103491#file1103491line165>
> >
> > Dumb question -- could we have used `JSON::Protobuf()` instead?
>
> Connor
eviews.apache.org/r/39531/#review103650
---
On Oct. 22, 2015, 11:30 p.m., Connor Doyle wrote:
>
> ---
> This is an automatically generated e-mail. To re
/
Testing
---
make && make check
Thanks,
Connor Doyle
der.
- Connor
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39531/#review103497
---
On Oct. 22, 2015, 5:08 p.m., Con
-guide.md c7aa08d
Diff: https://reviews.apache.org/r/38943/diff/
Testing
---
Visually verified the generated output in Chrome, using
http://github.com/mesosphere/mesos-website-container.
Thanks,
Connor Doyle
> On Sept. 22, 2015, 12:40 a.m., Connor Doyle wrote:
> > Ship It!
>
> Connor Doyle wrote:
> Please re-run the post-reviews so the patch applies cleanly
> (`src/slave/http.cpp` was concurrently modified).
>
> Felix Abecassis wrote:
> Done. Please verify.
> On Sept. 22, 2015, 12:40 a.m., Connor Doyle wrote:
> > Ship It!
Please re-run the post-reviews so the patch applies cleanly
(`src/slave/http.cpp` was concurrently modified).
- Connor
---
This is an automatically generat
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38517/#review99883
---
Ship it!
Ship It!
- Connor Doyle
On Sept. 19, 2015, 12:59 a.m
> On Sept. 14, 2015, 5:34 p.m., Connor Doyle wrote:
> > src/hook/manager.cpp, line 261
> > <https://reviews.apache.org/r/38279/diff/1/?file=1067842#file1067842line261>
> >
> > Please add a comment describing how the order of hook execution is
> > deter
tps://reviews.apache.org/r/38279/#comment155545>
Please add a test to verify that the modified resources are reflected in
the resource offers formed by the master. There are some good examples to
follow in `src/tests/hook_tests.cpp`.
- Connor Doyle
On Sept. 14, 2015, 5:39 p.m., Felix Abecassis
g/r/38279/#comment18>
Please also add a test that verifies that the hooks are executed in the
expected order. For example, have two hooks that both modify the `cpus`
resource and verify that the second value is indeed retained.
- Connor Doyle
On Sept. 14, 2015, 5:39 p.m., Felix Abe
---
On June 27, 2015, 1:18 a.m., Connor Doyle wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35961/
---
(Updated
---
On June 29, 2015, 3:53 p.m., Connor Doyle wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35961
On June 27, 2015, 6:59 p.m., Adam B wrote:
src/java/mesos.pom.in, line 134
https://reviews.apache.org/r/35961/diff/1/?file=993817#file993817line134
Is `${project.basedir}/generated` any better/different than
`@abs_top_builddir@/src/java/generated`
Connor Doyle wrote
/src/org/apache/mesos/MesosExecutorDriver.java 1b5ed60
Diff: https://reviews.apache.org/r/35961/diff/
Testing
---
- configure
- make
- Manual verification of generated Javadoc HTML
Thanks,
Connor Doyle
26 matches
Mail list logo
