Re: Review Request 60651: Updated bundled ruby dependencies.

2017-07-05 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60651/#review179621 --- Ship it! Ship It! - haosdent huang On July 5, 2017, 11:08

Re: Review Request 60370: Updated agent webui page to display allocated resources per each role.

2017-07-04 Thread haosdent huang
/agent.html Lines 176 (patched) <https://reviews.apache.org/r/60370/#comment254402> Should we use * here to keep consistent with other parts? Beside this, other changes LGTM! - haosdent huang On June 28, 2017, 8:52 p.m., Andrei Budnik

Re: Review Request 60370: Updated agent webui page to display allocated resources per each role.

2017-07-04 Thread haosdent huang
> On July 3, 2017, 6:27 p.m., haosdent huang wrote: > > src/webui/master/static/js/controllers.js > > Lines 610 (patched) > > <https://reviews.apache.org/r/60370/diff/3/?file=1766481#file1766481line610> > > > > How about > > > >

Re: Review Request 60370: Updated agent webui page to display allocated resources per each role.

2017-07-04 Thread haosdent huang
> On July 3, 2017, 6:27 p.m., haosdent huang wrote: > > src/webui/master/static/js/controllers.js > > Lines 610 (patched) > > <https://reviews.apache.org/r/60370/diff/3/?file=1766481#file1766481line610> > > > > How about > > > >

Re: Review Request 60370: Updated agent webui page to display allocated resources per each role.

2017-07-03 Thread haosdent huang
> On June 27, 2017, 5:33 p.m., haosdent huang wrote: > > src/webui/master/static/js/controllers.js > > Lines 604 (patched) > > <https://reviews.apache.org/r/60370/diff/2/?file=1764203#file1764203line604> > > > > `ng-repeat` support map, have you try

Re: Review Request 60370: Updated agent webui page to display allocated resources per each role.

2017-07-03 Thread haosdent huang
) <https://reviews.apache.org/r/60370/#comment254292> How about ``` $scope.agent.resource_reservations = _($scope.state.reserved_resources).map(function(role, reservation)) { reservation.role = role return reservation; } ``` - haosdent huang On J

Re: Review Request 60440: Updated local development workflow of mesos website.

2017-07-03 Thread haosdent huang
s/MacOSX/MacOS - haosdent huang On June 29, 2017, 9:59 p.m., Vinod Kone wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 60439: Added scripts to automate website publishing.

2017-07-03 Thread haosdent huang
is it possible to merge build.sh into entrypoint.sh - haosdent huang On June 29, 2017, 9:59 p.m., Vinod Kone wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 60439: Added scripts to automate website publishing.

2017-07-03 Thread haosdent huang
tps://reviews.apache.org/r/60439/#comment254264> Sorry, just saw `LOCAL_USER_ID`. - haosdent huang On June 29, 2017, 9:59 p.m., Vinod Kone wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 60439: Added scripts to automate website publishing.

2017-07-03 Thread haosdent huang
tps://reviews.apache.org/r/60439/#comment254263> Should we move `bundle install` to here? - haosdent huang On June 29, 2017, 9:59 p.m., Vinod Kone wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 60439: Added scripts to automate website publishing.

2017-07-03 Thread haosdent huang
tps://reviews.apache.org/r/60439/#comment254262> Is it OK to run support/mesos-website/build.sh as root? - haosdent huang On June 29, 2017, 9:59 p.m., Vinod Kone wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 60438: Updated endpoint help generator script to work inside Docker.

2017-06-28 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60438/#review179124 --- Ship it! Ship It! - haosdent huang On June 26, 2017, 5:54

Re: Review Request 60370: Updated agent webui page to display allocated resources per each role.

2017-06-28 Thread haosdent huang
> On June 23, 2017, 4:06 p.m., haosdent huang wrote: > > src/webui/master/static/agent.html > > Lines 184 (patched) > > <https://reviews.apache.org/r/60370/diff/1/?file=1758433#file1758433line184> > > > > Is `|| 0` necessary here? > > Andrei Budn

Re: Review Request 60370: Updated agent webui page to display allocated resources per each role.

2017-06-28 Thread haosdent huang
> On June 27, 2017, 5:33 p.m., haosdent huang wrote: > > src/webui/master/static/js/controllers.js > > Lines 604 (patched) > > <https://reviews.apache.org/r/60370/diff/2/?file=1764203#file1764203line604> > > > > `ng-repeat` support map, have you try

Re: Review Request 60369: Exposed allocated resources per each role in /state endpoint on agent.

2017-06-27 Thread haosdent huang
ne 1739 (original), 1739 (patched) <https://reviews.apache.org/r/60369/#comment253382> Nit: Add one blank line below. - haosdent huang On June 27, 2017, 5:10 p.m., Andrei Budnik wrote: > > --- > This is an automati

Re: Review Request 60370: Updated agent webui page to display allocated resources per each role.

2017-06-27 Thread haosdent huang
) <https://reviews.apache.org/r/60370/#comment253372> `ng-repeat` support map, have you try ``` ng-repeat="(role, reservation) in $data" ``` - haosdent huang On June 27, 2017, 5:10 p.m., And

Re: Review Request 60370: Updated agent webui page to display allocated resources per each role.

2017-06-27 Thread haosdent huang
> On June 23, 2017, 4:06 p.m., haosdent huang wrote: > > src/webui/master/static/agent.html > > Lines 176 (patched) > > <https://reviews.apache.org/r/60370/diff/1/?file=1758433#file1758433line176> > > > > Should we use `*` here to keep consistent wit

Re: Review Request 60170: Supported auto cgroups in unified cgroup isolator.

2017-06-26 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60170/#review178943 --- Ship it! Ship It! - haosdent huang On June 26, 2017, 10:39

Re: Review Request 60370: Updated agent webui page to display allocated resources per each role.

2017-06-23 Thread haosdent huang
ml Lines 186 (patched) <https://reviews.apache.org/r/60370/#comment253025> Is `|| 0` necessary here? - haosdent huang On June 22, 2017, 3:26 p.m., Andrei Budnik wrote: > > --- > This is an automatically generated e-mai

Re: Review Request 58874: Stripped spaces between directory elements in WebUI.

2017-06-20 Thread haosdent huang
/master/static/css/mesos.css 9f3de5427071fc61d3791c4bc2a660368c2cd3c2 Diff: https://reviews.apache.org/r/58874/diff/4/ Testing --- Thanks, haosdent huang

Re: Review Request 58872: Ensured sandbox URI request reroute after fetched `$scope.state`.

2017-06-20 Thread haosdent huang
--- Thanks, haosdent huang

Re: Review Request 58872: Ensured sandbox URI request reroute after fetched `$scope.state`.

2017-06-20 Thread haosdent huang
src/webui/master/static/js/controllers.js 1aca25ab6e0856128ebefe5037cbe63430857c99 Diff: https://reviews.apache.org/r/58872/diff/3/ Changes: https://reviews.apache.org/r/58872/diff/2-3/ Testing --- Thanks, haosdent huang

Re: Review Request 60169: Introduced a new agent flag 'cgroups_auto'.

2017-06-20 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60169/#review178353 --- Ship it! Ship It! - haosdent huang On June 17, 2017, 4:58

Re: Review Request 60170: Supported 'cgroups_auto' flag in unified cgroup isolator.

2017-06-20 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60170/#review178350 --- Ship it! Ship It! - haosdent huang On June 17, 2017, 4:58

Re: Review Request 58872: Ensured sandbox URI request reroute after fetched `$scope.state`.

2017-06-20 Thread haosdent huang
-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58872/#review174374 ------- On May 3, 2017, 4:15 a.m., haosdent huang wrote: > > --

Re: Review Request 58872: Ensured sandbox URI request reroute after fetched `$scope.state`.

2017-06-20 Thread haosdent huang
route is expected to always > > route away from the page and so the listener is removed after the first > > state update? Thanks @bmahler's detail review. Let me add a comment for it. - haosdent ------- This is

Re: Review Request 53517: Added test case for cgroup namespace isolator.

2017-06-19 Thread haosdent huang
/namespaces_isolator_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/53517/diff/6/ Changes: https://reviews.apache.org/r/53517/diff/5-6/ Testing --- Thanks, haosdent huang

Re: Review Request 54105: Added `CgroupNamespaceFilter`.

2017-06-19 Thread haosdent huang
a7262cd97361b55ff31238341657e764df6c9ea5 Diff: https://reviews.apache.org/r/54105/diff/4/ Changes: https://reviews.apache.org/r/54105/diff/3-4/ Testing --- Thanks, haosdent huang

Re: Review Request 58874: Stripped spaces between directory elements in WebUI.

2017-06-19 Thread haosdent huang
9f3de5427071fc61d3791c4bc2a660368c2cd3c2 Diff: https://reviews.apache.org/r/58874/diff/4/ Testing --- Thanks, haosdent huang

Re: Review Request 58874: Stripped spaces between directory elements in WebUI.

2017-06-19 Thread haosdent huang
z very sorry for the delay. I try this patch, but the spcaces is still there. Seems didn't resolve our problem. - haosdent --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/

Re: Review Request 58874: Stripped spaces between directory elements in WebUI.

2017-06-19 Thread haosdent huang
https://reviews.apache.org/media/uploaded/files/2017/05/03/79afd0b1-5fb1-437c-a91c-732009af8fe3__strip_space.gif Thanks, haosdent huang

Re: Review Request 59796: Show allocated and offered resources in per-framework page.

2017-06-07 Thread haosdent huang
.png Thanks, haosdent huang

Re: Review Request 59796: Show used resources in per-framework page.

2017-06-07 Thread haosdent huang
-dd0d-49c2-a683-6a0ffe08f7a6__screenshot.png screenshot_1.png https://reviews.apache.org/media/uploaded/files/2017/06/07/17460501-4b6e-4b02-9f52-6165d58cf83f__screenshot_1.png Thanks, haosdent huang

Re: Review Request 59796: Show used resources in per-framework page.

2017-06-06 Thread haosdent huang
- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59796/#review176947 --- On June 7, 2017, 2:30 a.m., haosdent huang wrote: > >

Re: Review Request 59796: Show used resources in per-framework page.

2017-06-06 Thread haosdent huang
://reviews.apache.org/media/uploaded/files/2017/06/05/240a56ea-dd0d-49c2-a683-6a0ffe08f7a6__screenshot.png screenshot_1.png https://reviews.apache.org/media/uploaded/files/2017/06/07/17460501-4b6e-4b02-9f52-6165d58cf83f__screenshot_1.png Thanks, haosdent huang

Re: Review Request 59796: Show used resources in per-framework page.

2017-06-04 Thread haosdent huang
Thanks, haosdent huang

Review Request 59796: Show used resources in per-framework page.

2017-06-04 Thread haosdent huang
/ Testing --- Thanks, haosdent huang

Re: Review Request 59732: Added bmahler to the webui maintainers.

2017-06-04 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59732/#review176894 --- Ship it! Ship It! - haosdent huang On June 1, 2017, 10:06

Re: Review Request 58874: Stripped spaces between directory elements in WebUI.

2017-05-10 Thread haosdent huang
ace? Yes, this still insert a space ``` ')"> https://reviews.apache.org/r/58874/#review174590 --- On May 8, 2017, 8:01 a.m., haosdent huang wrote: > > --- > This is an automatically generated e-mail. To reply, visi

Re: Review Request 58874: Stripped spaces between directory elements in WebUI.

2017-05-10 Thread haosdent huang
il. To reply, visit: https://reviews.apache.org/r/58874/#review174590 ------- On May 8, 2017, 8:01 a.m., haosdent huang wrote: > > --- > This is an automatically generat

Re: Review Request 52064: Support for multiple versions of docs.

2017-05-09 Thread haosdent huang
patch and have not finished. Could return my comments if it works at my side. Thanks a lot for your contributions. - haosdent huang On May 5, 2017, 9:23 p.m., Tim Anderegg wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 58874: Stripped spaces between directory elements in WebUI.

2017-05-08 Thread haosdent huang
-732009af8fe3__strip_space.gif Thanks, haosdent huang

Re: Review Request 58874: Stripped spaces between directory elements in WebUI.

2017-05-08 Thread haosdent huang
-437c-a91c-732009af8fe3__strip_space.gif Thanks, haosdent huang

Re: Review Request 58874: Stripped spaces between directory elements in WebUI.

2017-05-08 Thread haosdent huang
his is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58874/#review173801 --- On May 3, 2017, 4:29 a.m., haosdent huang wrote: > > --- > T

Re: Review Request 53517: Added test case for cgroup namespace isolator.

2017-05-07 Thread haosdent huang
Diff: https://reviews.apache.org/r/53517/diff/5/ Changes: https://reviews.apache.org/r/53517/diff/4-5/ Testing --- Thanks, haosdent huang

Re: Review Request 54105: Added `CgroupNamespaceFilter`.

2017-05-07 Thread haosdent huang
4c6c8f6656b62e5d8fbd8d4e8f2d7903f71e884c Diff: https://reviews.apache.org/r/54105/diff/3/ Changes: https://reviews.apache.org/r/54105/diff/2-3/ Testing --- Thanks, haosdent huang

Re: Review Request 53516: Moved namespaces associated test cases to a separate file.

2017-05-07 Thread haosdent huang
/namespaces_isolator_tests.cpp PRE-CREATION src/tests/slave_recovery_tests.cpp 9cf1d461cf5c6ac1f51ac963360a17e37f558505 Diff: https://reviews.apache.org/r/53516/diff/5/ Changes: https://reviews.apache.org/r/53516/diff/4-5/ Testing --- Thanks, haosdent huang

Re: Review Request 53296: Added cgroup namespace support for unified container.

2017-05-07 Thread haosdent huang
-CREATION Diff: https://reviews.apache.org/r/53296/diff/8/ Changes: https://reviews.apache.org/r/53296/diff/7-8/ Testing --- Test case is: https://reviews.apache.org/r/53517/ Thanks, haosdent huang

Re: Review Request 58998: Fixed extra newline in webui for re-registered frameworks.

2017-05-04 Thread haosdent huang
), 40-41 (patched) <https://reviews.apache.org/r/58998/#comment247089> I think change `ng-show` to `ng-if` should be enough. ``` - ... ``` - haosdent huang On May 4, 2017, 7:04 p.m., Neil Conway

Re: Review Request 58942: CHANGELOG for 1.3.0 release.

2017-05-03 Thread haosdent huang
g/r/58942/#comment246745> Should we add `MESOS-7453` at here? - haosdent huang On May 2, 2017, 11:48 p.m., Michael Park wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 58874: Stripped spaces between directory elements in WebUI.

2017-05-02 Thread haosdent huang
.apache.org/r/58874/#review173526 --- On May 3, 2017, 4:29 a.m., haosdent huang wrote: > > --- > This is an automatically generated e-mail. To reply, v

Re: Review Request 58874: Stripped spaces between directory elements in WebUI.

2017-05-02 Thread haosdent huang
Diff: https://reviews.apache.org/r/58874/diff/2/ Testing --- File Attachments (updated) strip_space.gif https://reviews.apache.org/media/uploaded/files/2017/05/03/79afd0b1-5fb1-437c-a91c-732009af8fe3__strip_space.gif Thanks, haosdent huang

Re: Review Request 58874: Stripped spaces between directory elements in WebUI.

2017-05-02 Thread haosdent huang
9f3de5427071fc61d3791c4bc2a660368c2cd3c2 Diff: https://reviews.apache.org/r/58874/diff/2/ Changes: https://reviews.apache.org/r/58874/diff/1-2/ Testing --- Thanks, haosdent huang

Re: Review Request 58874: Stripped spaces between directory elements in WebUI.

2017-05-02 Thread haosdent huang
y content would not include `` in my browser. Is it work in your side? - haosdent --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58874/#review173499 ----

Re: Review Request 58872: Ensured sandbox URI request reroute after fetched `$scope.state`.

2017-05-02 Thread haosdent huang
t; > problem and the fix in the description? Fixed, thank you. - haosdent --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58872/#review173525 ------

Re: Review Request 58872: Ensured sandbox URI request reroute after fetched `$scope.state`.

2017-05-02 Thread haosdent huang
on('$routeChangeStart', removeListener); ``` Do you think we need to add comment about this here? - haosdent --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58872/#review17350

Re: Review Request 58872: Ensured sandbox URI request reroute after fetched `$scope.state`.

2017-05-02 Thread haosdent huang
://reviews.apache.org/r/58872/diff/1-2/ Testing --- Thanks, haosdent huang

Re: Review Request 58944: Fixed compilation error on recent glibc for device whitelist.

2017-05-02 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58944/#review173691 --- Ship it! Ship It! - haosdent huang On May 3, 2017, 3:58 a.m

Re: Review Request 58603: Allowed whitelist additional devices in cgroups devices subsystem.

2017-04-30 Thread haosdent huang
"Example:\n" "{\n" " \"allowed_devices\": [\n" "{\n" " \"device\": {\n" "\"path\&qu

Review Request 58874: Stripped spaces between directory elements in WebUI.

2017-04-29 Thread haosdent huang
/58874/diff/1/ Testing --- Thanks, haosdent huang

Review Request 58872: Ensured sandbox URI request reroute after fetched `$scope.state`.

2017-04-29 Thread haosdent huang
://reviews.apache.org/r/58872/diff/1/ Testing --- Thanks, haosdent huang

Re: Review Request 58603: Allowed whitelist additional devices in cgroups devices subsystem.

2017-04-27 Thread haosdent huang
. - haosdent huang On April 27, 2017, 7:01 a.m., Zhongbo Tian wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 58603: Allowed whitelist additional devices in cgroups devices subsystem.

2017-04-25 Thread haosdent huang
t;https://reviews.apache.org/r/58603/#comment246094> Nit: we prefer to put `+` at the end. - haosdent huang On April 25, 2017, 5:40 a.m., Zhongbo Tian wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 58548: Fixed inconsistent terminology for 'Used' vs 'Allocated' in the webui.

2017-04-24 Thread haosdent huang
-139 (patched) <https://reviews.apache.org/r/58548/#comment245861> hi, @bamhler, do you think if we need to replace `used_` to `allocated_` in these variables as well? - haosdent huang On April 20, 2017, 1:53 a.m., Benjamin Mahler

Re: Review Request 58548: Fixed inconsistent terminology for 'Used' vs 'Allocated' in the webui.

2017-04-24 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58548/#review172827 --- Ship it! Ship It! - haosdent huang On April 20, 2017, 1:53

Re: Review Request 58547: Fixed an inaccurately named table header in the agent webui page.

2017-04-24 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58547/#review172828 --- Ship it! Ship It! - haosdent huang On April 20, 2017, 1:53

Re: Review Request 58549: Updated agent webui page to display allocated and available resources.

2017-04-24 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58549/#review172826 --- Ship it! Ship It! - haosdent huang On April 20, 2017, 1:53

Re: Review Request 58337: Allowed whitelist additional devices in cgroups devices subsystem.

2017-04-16 Thread haosdent huang
h/to/device\",\n" "\"read_access\": true,\n" "\"write_access\": false,\n" "\"mknod_access\": false\n" "}\n" "]\n" ); ``

Re: Review Request 58337: Add allowed devices whitelist for cgroups/devices isolator.

2017-04-16 Thread haosdent huang
to test this tmr and then could go head. Thanks a lot @windreamer's contributions! - haosdent huang On April 12, 2017, 4:17 a.m., Zhongbo Tian wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Re: Review Request 58200: Fix mesos runs with docker(pid namespace mismatch).

2017-04-16 Thread haosdent huang
ters(); +capAddParameter->set_key("cap-add"); +capAddParameter->set_value("SYS_ADMIN"); +capAddParameter = dockerInfo.add_parameters(); +capAddParameter->set_key("cap-add"); + capAddParameter->set_value("SYS_PTRACE

Re: Review Request 58337: Add allowed devices whitelist for cgroups/devices isolator.

2017-04-11 Thread haosdent huang
r to what we do in `add(::allowed_capabilities`. - haosdent huang On April 11, 2017, 9:40 a.m., Zhongbo Tian wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 58200: Fix mesos runs with docker(pid namespace mismatch).

2017-04-08 Thread haosdent huang
tps://reviews.apache.org/r/58200/#comment244303> I think it is fine to use priviliged to lauch mesos-executor. But after discussed with @xiaods, let me find if we could avoid to use privileged via --cap-add. - haosdent huang On April 8, 2017, 11:12 a.m., Deshi Xiao

Re: Review Request 58200: Fix mesos runs with docker(pid namespace mismatch).

2017-04-07 Thread haosdent huang
> On April 7, 2017, 4:31 p.m., haosdent huang wrote: > > This requires `mesos-docker-executor` share the same namespace with `mesos-agent`. So need `--pid=host`. And `nsenter` requires privileged permissions, so need `--privileged=true`. -

Re: Review Request 58200: Fix mesos runs with docker(pid namespace mismatch).

2017-04-07 Thread haosdent huang
eter = dockerInfo.add_parameters(); +privilegedParameter->set_key("privileged"); +privilegedParameter->set_value("true"); + ``` and work in my side. May you help to double check again? - haosd

Re: Review Request 58200: Fix mesos runs with docker(pid namespace mismatch).

2017-04-07 Thread haosdent huang
tps://reviews.apache.org/r/58200/#comment244255> Got this error ``` Failed to enter the net namespace of task (pid: '78851'): Operation not permitted ``` Need to add capacity. - haosdent huang On April 5, 2017, 11:35 p.m., Deshi Xiao

Re: Review Request 58200: Fix mesos runs with docker(pid namespace mismatch).

2017-04-05 Thread haosdent huang
? I would like to do the verification in my side. - haosdent huang On April 5, 2017, 6:59 a.m., Deshi Xiao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 57622: Introduced a Roles tab in the webui.

2017-03-18 Thread haosdent huang
number}} + {{role.resources.cpus | decimalFloat}} + {{role.resources.gpus | decimalFloat}} + {{role.resources.mem * (1024 * 1024) | dataSize}} + {{role.resources.disk * (1024 * 1024) | dataSize}} ``` here - haosdent huang On March 16, 2017, 1:28 a.m., Benjamin Mahler

Re: Review Request 57622: Introduced a Roles tab in the webui.

2017-03-18 Thread haosdent huang
/app.js Lines 21-22 (patched) <https://reviews.apache.org/r/57622/#comment241712> Let's ensure the order is alphabetically. - haosdent huang On March 16, 2017, 1:28 a.m., Benjamin Mahler wrote: > > --- > This is a

Re: Review Request 57623: Updated the maintenance tab in the webui to auto-refresh.

2017-03-17 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57623/#review169357 --- Ship it! Ship It! - haosdent huang On March 14, 2017, 10:30

Re: Review Request 57629: Fixed a webui bug where the maintenance tab is not shown as active.

2017-03-14 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57629/#review168966 --- Ship it! Ship It! - haosdent huang On March 15, 2017, 2:06

Re: Review Request 57575: Added a test to test the cgroup limit swap functionality.

2017-03-13 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57575/#review168861 --- Ship it! Ship It! - haosdent huang On March 14, 2017, 12:05

Re: Review Request 57574: Ensured the cgroup memory+swap limit is no less than the memory limit.

2017-03-13 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57574/#review168856 --- Ship it! Ship It! - haosdent huang On March 14, 2017, 12:04

Re: Review Request 57422: Removed misleading comment from protobuf file.

2017-03-08 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57422/#review168303 --- Ship it! Ship It! - haosdent huang On March 8, 2017, 3:56

Re: Review Request 56732: Remove unnecessary perf version checks.

2017-03-07 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56732/#review168234 --- Ship it! Ship It! - haosdent huang On Feb. 15, 2017, 11:22

Re: Review Request 56731: Fix perf-stat parsing for recent perf releases.

2017-03-07 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56731/#review168233 --- Ship it! Ship It! - haosdent huang On Feb. 15, 2017, 11:24

Re: Review Request 56847: Removed unnecessary leveldb build rules.

2017-02-20 Thread haosdent huang
: $(SHARED_LIBS) $(SHARED_PROGRAMS) $(STATIC_OUTDIR)/libleveldb.a $(STATIC_OUTDIR)/libmemenv.a $(STATIC_PROGRAMS) +all: $(STATIC_OUTDIR)/libleveldb.a `` - haosdent huang On Feb. 20, 2017, 4:45 p.m., Tomasz Janiszewski wrote

Re: Review Request 56847: Remove unecessary leveldb build rule.

2017-02-20 Thread haosdent huang
. ``` -all: $(SHARED_LIBS) $(SHARED_PROGRAMS) $(STATIC_OUTDIR)/libleveldb.a $(STATIC_OUTDIR)/libmemenv.a $(STATIC_PROGRAMS) +all: $(STATIC_OUTDIR)/libleveldb.a ``` - haosdent huang On Feb. 20, 2017, 11:52 a.m., Tomasz Janiszewski wrote

Re: Review Request 51053: Update leveldb to 1.19.

2017-02-20 Thread haosdent huang
google.com/document/d/1fv2OMvH6hVm6waacOejSrTJwUuDQeXlqqPDZjBmbcKU/edit# > and check if everything is OK. > > haosdent huang wrote: > I could help to run from 1.14 to 1.19 if it is necessary. :) > > Tomasz Janiszewski wrote: > I took care of it. Folloed steps presented by Haosdent it works the same. &g

Re: Review Request 51053: Update leveldb to 1.19.

2017-02-19 Thread haosdent huang
google.com/document/d/1fv2OMvH6hVm6waacOejSrTJwUuDQeXlqqPDZjBmbcKU/edit# > and check if everything is OK. > > haosdent huang wrote: > I could help to run from 1.14 to 1.19 if it is necessary. :) > > Tomasz Janiszewski wrote: > I took care of it. Folloed steps presented by Haosdent it works the same. &g

Re: Review Request 51053: Update leveldb to 1.19.

2017-02-19 Thread haosdent huang
) ``` - haosdent huang On Feb. 20, 2017, 4:41 a.m., Tomasz Janiszewski wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 54821: Refactored Docker::run() to make it only aware of docker cli options.

2017-02-18 Thread haosdent huang
g/r/54821/#comment237921> Since we use `int_fd` now, I update to ``` Try fd = os::open( ``` here. - haosdent huang On Feb. 6, 2017, 9:28 p.m., Zhitao Li wrote: > > --- > This is an automatically generated e

Re: Review Request 56238: Allowed using protobuf 3 in python bindings.

2017-02-17 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56238/#review166018 --- Ship it! Ship It! - haosdent huang On Feb. 18, 2017, 2:23

Re: Review Request 51624: Implemented 'GetAgent' call in v1 agent API.

2017-02-14 Thread haosdent huang
eply, visit: https://reviews.apache.org/r/51624/#review163743 --- On Oct. 8, 2016, 12:37 p.m., haosdent huang wrote: > > --- > This is an automatically generated e-mai

Re: Review Request 55160: Added test for DockerContainerizer when `cgroups_enable_cfs` is set.

2017-02-06 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55160/#review164450 --- Ship it! Ship It! - haosdent huang On Feb. 6, 2017, 9:29

Re: Review Request 56236: Add `syntax = "proto2"` to some files automatically.

2017-02-06 Thread haosdent huang
...@mesos.apache.org about this. So other develpers would not foget to add `syntax 2` in protobuf files.. - haosdent huang On Feb. 2, 2017, 8:12 p.m., Anthony Sottile wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request 53741: Show maintainance schedule info in the WebUI.

2017-02-06 Thread haosdent huang
src/webui/master/static/maintenance.html (line 30) <https://reviews.apache.org/r/53741/#comment236017> Nit: Indent should be 2. `` {{machine_ids.hostname ? machine_ids.hostname : machine_ids.ip}} ``` - haosdent huang On Feb. 6, 2017, 9:29

Re: Review Request 56214: Hashed unacknowledged updates by UUID string in default executor.

2017-02-06 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56214/#review164322 --- Ship it! Ship It! - haosdent huang On Feb. 2, 2017, 9:57

Re: Review Request 56209: Hashed unacknowledged updates by UUID string in command executor.

2017-02-06 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56209/#review164321 --- Ship it! Ship It! - haosdent huang On Feb. 2, 2017, 9:56

Re: Review Request 56288: Improved the wording of what's logged on command health check timeouts.

2017-02-05 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56288/#review164314 --- Ship it! Ship It! - haosdent huang On Feb. 3, 2017, 7:50

Re: Review Request 55900: Improved style in `HealthChecker`.

2017-02-05 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55900/#review164311 --- Ship it! Ship It! - haosdent huang On Feb. 2, 2017, 4:54

  1   2   3   4   5   6   7   8   9   10   >