Re: Review Request 37314: Maintenance Primitives: Populate master's maintenance-related local state upon recovery from registry.

2015-08-28 Thread Joseph Wu
> On Aug. 28, 2015, 8:19 a.m., Joris Van Remoortere wrote: > > include/mesos/type_utils.hpp, line 158 > > > > > > You have this on a new line to call it out for readability right? It > > would fit above otherwise.

Re: Review Request 37314: Maintenance Primitives: Populate master's maintenance-related local state upon recovery from registry.

2015-08-28 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37314/ --- (Updated Aug. 28, 2015, 10:38 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37314: Maintenance Primitives: Populate master's maintenance-related local state upon recovery from registry.

2015-08-28 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37314/#review96870 --- Ship it! include/mesos/type_utils.hpp (line 153)

Re: Review Request 37314: Maintenance Primitives: Populate master's maintenance-related local state upon recovery from registry.

2015-08-27 Thread Joseph Wu
> On Aug. 26, 2015, 11:05 p.m., Alexander Rukletsov wrote: > > include/mesos/maintenance/maintenance.hpp, line 29 > > > > > > If it's not a protobuf, remove `Info` suffix. The suffix is there only > > to avoid collis

Re: Review Request 37314: Maintenance Primitives: Populate master's maintenance-related local state upon recovery from registry.

2015-08-27 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37314/ --- (Updated Aug. 27, 2015, 6:07 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37314: Maintenance Primitives: Populate master's maintenance-related local state upon recovery from registry.

2015-08-27 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37314/#review96748 --- Ship it! include/mesos/type_utils.hpp (lines 152 - 153)

Re: Review Request 37314: Maintenance Primitives: Populate master's maintenance-related local state upon recovery from registry.

2015-08-26 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37314/#review96643 --- include/mesos/maintenance/maintenance.hpp (line 29)

Re: Review Request 37314: Maintenance Primitives: Populate master's maintenance-related local state upon recovery from registry.

2015-08-26 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37314/ --- (Updated Aug. 26, 2015, 11:49 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37314: Maintenance Primitives: Populate master's maintenance-related local state upon recovery from registry.

2015-08-26 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37314/#review96548 --- include/mesos/maintenance/maintenance.hpp (line 29)

Re: Review Request 37314: Maintenance Primitives: Populate master's maintenance-related local state upon recovery from registry.

2015-08-24 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37314/#review96302 --- Ship it! Ship It! - Guangya Liu On Aug. 24, 2015, 6:43 p.m., Jos

Re: Review Request 37314: Maintenance Primitives: Populate master's maintenance-related local state upon recovery from registry.

2015-08-24 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37314/ --- (Updated Aug. 24, 2015, 11:43 a.m.) Review request for mesos, Benjamin Hindman,