Re: Review Request 44514: Implemented prepare() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44514/#review125362 --- Ship it! Ship It! - Jie Yu On March 24, 2016, 2:34 a.m., Qia

Re: Review Request 44514: Implemented prepare() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44514/ --- (Updated March 24, 2016, 10:34 a.m.) Review request for mesos, Avinash sridhara

Re: Review Request 44514: Implemented prepare() method of "network/cni" isolator.

> On March 24, 2016, 5:04 a.m., Cong Wang wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, line 228 > > > > > > You always have ifIndex==0 here, it is never changed. So either you > > miss som

Re: Review Request 44514: Implemented prepare() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44514/#review125131 --- src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (line

Re: Review Request 44514: Implemented prepare() method of "network/cni" isolator.

> On March 11, 2016, 6:19 p.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/network/cni.cpp, line 228 > > > > > > Can there be a use case where you want multiple NICs to be attached to > > t

Re: Review Request 44514: Implemented prepare() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44514/ --- (Updated March 23, 2016, 1:10 p.m.) Review request for mesos, Avinash sridharan

Re: Review Request 44514: Implemented prepare() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44514/#review124881 --- src/slave/containerizer/mesos/isolators/network/cni/cni.hpp (line

Re: Review Request 44514: Implemented prepare() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44514/ --- (Updated March 22, 2016, 5:50 p.m.) Review request for mesos, Avinash sridharan

Re: Review Request 44514: Implemented prepare() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44514/ --- (Updated March 22, 2016, 5:30 p.m.) Review request for mesos, Avinash sridharan

Re: Review Request 44514: Implemented prepare() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44514/ --- (Updated March 22, 2016, 5:06 p.m.) Review request for mesos, Avinash sridharan

Re: Review Request 44514: Implemented prepare() method of "network/cni" isolator.

> On March 20, 2016, 7:06 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.hpp, line 82 > > > > > > s/NetworkResultInfo/Info/ > > > > We typically use 'Info' to store informatio

Re: Review Request 44514: Implemented prepare() method of "network/cni" isolator.

> On March 20, 2016, 7:06 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.hpp, line 82 > > > > > > s/NetworkResultInfo/Info/ > > > > We typically use 'Info' to store informatio

Re: Review Request 44514: Implemented prepare() method of "network/cni" isolator.

> On March 21, 2016, 3:06 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.hpp, line 82 > > > > > > s/NetworkResultInfo/Info/ > > > > We typically use 'Info' to store informatio

Re: Review Request 44514: Implemented prepare() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44514/#review124451 --- src/slave/containerizer/mesos/isolators/network/cni/cni.hpp (line

Re: Review Request 44514: Implemented prepare() method of "network/cni" isolator.

> On March 17, 2016, 5:35 a.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.hpp, line 88 > > > > > > Should this be a `Result` instead of an `Option` ? Since either the > > co

Re: Review Request 44514: Implemented prepare() method of "network/cni" isolator.

> On March 17, 2016, 1:35 p.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.hpp, line 88 > > > > > > Should this be a `Result` instead of an `Option` ? Since either the > > co

Re: Review Request 44514: Implemented prepare() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44514/ --- (Updated March 18, 2016, 2:31 p.m.) Review request for mesos, Avinash sridharan

Re: Review Request 44514: Implemented prepare() method of "network/cni" isolator.

> On March 17, 2016, 1:35 p.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, lines 240-244 > > > > > > I think this comment is for static IP addresses. You should be > >

Re: Review Request 44514: Implemented prepare() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44514/ --- (Updated March 16, 2016, 8:57 p.m.) Review request for mesos, Avinash sridharan

Re: Review Request 44514: Implemented prepare() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44514/#review123984 --- src/slave/containerizer/mesos/isolators/network/cni/cni.hpp (line

Re: Review Request 44514: Implemented prepare() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44514/ --- (Updated March 17, 2016, 9:17 p.m.) Review request for mesos, Avinash sridharan

Re: Review Request 44514: Implemented prepare() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44514/ --- (Updated March 16, 2016, 3:49 p.m.) Review request for mesos, Avinash sridharan

Re: Review Request 44514: Implemented prepare() method of "network/cni" isolator.

> On March 11, 2016, 8:02 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni.hpp, line 85 > > > > > > I would suggest we have a `Info` for each container. > > > > ``` > > struct I

Re: Review Request 44514: Implemented prepare() method of "network/cni" isolator.

> On March 12, 2016, 4:02 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni.hpp, line 85 > > > > > > I would suggest we have a `Info` for each container. > > > > ``` > > struct I

Re: Review Request 44514: Implemented prepare() method of "network/cni" isolator.

> On March 11, 2016, 8:02 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni.hpp, line 85 > > > > > > I would suggest we have a `Info` for each container. > > > > ``` > > struct I

Re: Review Request 44514: Implemented prepare() method of "network/cni" isolator.

> On March 12, 2016, 4:02 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni.hpp, line 85 > > > > > > I would suggest we have a `Info` for each container. > > > > ``` > > struct I

Re: Review Request 44514: Implemented prepare() method of "network/cni" isolator.

> On March 11, 2016, 8:02 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni.hpp, line 85 > > > > > > I would suggest we have a `Info` for each container. > > > > ``` > > struct I

Re: Review Request 44514: Implemented prepare() method of "network/cni" isolator.

> On March 11, 2016, 6:19 p.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/network/cni.cpp, line 228 > > > > > > Can there be a use case where you want multiple NICs to be attached to > > t

Re: Review Request 44514: Implemented prepare() method of "network/cni" isolator.

> On March 12, 2016, 4:02 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni.hpp, line 85 > > > > > > I would suggest we have a `Info` for each container. > > > > ``` > > struct I

Re: Review Request 44514: Implemented prepare() method of "network/cni" isolator.

> On March 12, 2016, 2:19 a.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/network/cni.cpp, line 228 > > > > > > Can there be a use case where you want multiple NICs to be attached to > > t

Re: Review Request 44514: Implemented prepare() method of "network/cni" isolator.

> On March 11, 2016, 8:02 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni.hpp, line 85 > > > > > > I would suggest we have a `Info` for each container. > > > > ``` > > struct I

Re: Review Request 44514: Implemented prepare() method of "network/cni" isolator.

> On March 11, 2016, 8:02 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni.hpp, line 85 > > > > > > I would suggest we have a `Info` for each container. > > > > ``` > > struct I

Re: Review Request 44514: Implemented prepare() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44514/#review123200 --- src/slave/containerizer/mesos/isolators/network/cni.hpp (line 85)

Re: Review Request 44514: Implemented prepare() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44514/#review123176 --- src/slave/containerizer/mesos/isolators/network/cni.hpp (line 85)

Re: Review Request 44514: Implemented prepare() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44514/ --- (Updated March 10, 2016, 10:20 p.m.) Review request for mesos, Avinash sridhara