Re: Review Request 46825: Fully-typed all FlagsBase::add overloads.

2016-10-17 Thread Benjamin Bannier 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46825/
---

(Updated Oct. 17, 2016, 5:24 p.m.)


Review request for mesos, Alexander Rukletsov and Michael Park.


Changes
---

Rebased.


Bugs: MESOS-3335
https://issues.apache.org/jira/browse/MESOS-3335


Repository: mesos


Description
---

Fully-typed all FlagsBase::add overloads.


Diffs (updated)
-

  3rdparty/stout/include/stout/flags/flags.hpp 
e00aedfe1a1fbb5b8ad4786c6a3ca6db5d5faff0 

Diff: https://reviews.apache.org/r/46825/diff/


Testing
---

Tested as part of the review chain ending in 
https://reviews.apache.org/r/52388/ on various Linux configurations in internal 
CI.


Thanks,

Benjamin Bannier

Re: Review Request 46825: Fully-typed all FlagsBase::add overloads.

2016-10-17 Thread Michael Park 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46825/#review152882
---


Ship it!




Ship It!

- Michael Park


On Oct. 6, 2016, 2:59 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46825/
> ---
> 
> (Updated Oct. 6, 2016, 2:59 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Michael Park.
> 
> 
> Bugs: MESOS-3335
> https://issues.apache.org/jira/browse/MESOS-3335
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fully-typed all FlagsBase::add overloads.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/flags/flags.hpp 
> eab8a001ed19755de58386a55ed4972f58026b29 
> 
> Diff: https://reviews.apache.org/r/46825/diff/
> 
> 
> Testing
> ---
> 
> Tested as part of the review chain ending in 
> https://reviews.apache.org/r/52388/ on various Linux configurations in 
> internal CI.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 46825: Fully-typed all FlagsBase::add overloads.

2016-10-06 Thread Benjamin Bannier 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46825/
---

(Updated Oct. 6, 2016, 4:59 p.m.)


Review request for mesos, Alexander Rukletsov and Michael Park.


Changes
---

Rebased.


Bugs: MESOS-3335
https://issues.apache.org/jira/browse/MESOS-3335


Repository: mesos


Description
---

Fully-typed all FlagsBase::add overloads.


Diffs (updated)
-

  3rdparty/stout/include/stout/flags/flags.hpp 
eab8a001ed19755de58386a55ed4972f58026b29 

Diff: https://reviews.apache.org/r/46825/diff/


Testing
---

Tested as part of the review chain ending in 
https://reviews.apache.org/r/52388/ on various Linux configurations in internal 
CI.


Thanks,

Benjamin Bannier

Re: Review Request 46825: Fully-typed all FlagsBase::add overloads.

2016-09-29 Thread Benjamin Bannier 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46825/
---

(Updated Sept. 29, 2016, 2:55 p.m.)


Review request for mesos, Alexander Rukletsov and Michael Park.


Changes
---

Rebased.


Bugs: MESOS-3335
https://issues.apache.org/jira/browse/MESOS-3335


Repository: mesos


Description
---

Fully-typed all FlagsBase::add overloads.


Diffs (updated)
-

  3rdparty/stout/include/stout/flags/flags.hpp 
eab8a001ed19755de58386a55ed4972f58026b29 

Diff: https://reviews.apache.org/r/46825/diff/


Testing (updated)
---

Tested as part of the review chain ending in 
https://reviews.apache.org/r/52388/ on various Linux configurations in internal 
CI.


Thanks,

Benjamin Bannier

Re: Review Request 46825: Fully-typed all FlagsBase::add overloads.

2016-08-11 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46825/#review145534
---



Bad patch!

Reviews applied: [46825, 46824, 46823, 46822, 46821]

Failed command: ./support/apply-review.sh -n -r 46822

Error:
2016-08-11 18:01:48 URL:https://reviews.apache.org/r/46822/diff/raw/ 
[16997/16997] -> "46822.patch" [1]
error: patch failed: src/health-check/health_checker.hpp:224
error: src/health-check/health_checker.hpp: patch does not apply
error: patch failed: src/tests/containerizer/launcher.hpp:65
error: src/tests/containerizer/launcher.hpp: patch does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/14755/console

- Mesos ReviewBot


On Aug. 11, 2016, 4:33 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46825/
> ---
> 
> (Updated Aug. 11, 2016, 4:33 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Michael Park, and Vinod Kone.
> 
> 
> Bugs: MESOS-3335
> https://issues.apache.org/jira/browse/MESOS-3335
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fully-typed all FlagsBase::add overloads.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/flags.hpp 
> bc4684d499bad6e409953f608330325c4a13d6a6 
>   3rdparty/stout/include/stout/flags/flags.hpp 
> 4ca6c69aeb1e3343e9b0ae2562c450c4c645890c 
>   3rdparty/stout/tests/flags_tests.cpp 
> 94ba915c40836e476cf6097274a85c55acd4d73b 
>   3rdparty/stout/tests/subcommand_tests.cpp 
> 9213d6b9faec30b5be320ab37ca29c2406c964ac 
> 
> Diff: https://reviews.apache.org/r/46825/diff/
> 
> 
> Testing
> ---
> 
> make check (OS X clang-trunk w/o optimizations)
> 
> The mesos tests suite do not execute at all with an optimizing clang-trunk 
> since copying of the `map` inside `FlagsBase` reference random memory leading 
> to `SEGFAULTs`. With these patches all of `stout-tests` and 
> `libprocess-tests` can be executed, but some remaining failures persist in 
> `mesos-tests` (their number is reduced though).
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 46825: Fully-typed all FlagsBase::add overloads.

2016-08-11 Thread Benjamin Bannier 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46825/
---

(Updated Aug. 11, 2016, 6:32 p.m.)


Review request for mesos, Alexander Rukletsov and Vinod Kone.


Changes
---

Rebased.


Bugs: MESOS-3335
https://issues.apache.org/jira/browse/MESOS-3335


Repository: mesos


Description
---

Fully-typed all FlagsBase::add overloads.


Diffs (updated)
-

  3rdparty/stout/include/stout/flags.hpp 
bc4684d499bad6e409953f608330325c4a13d6a6 
  3rdparty/stout/include/stout/flags/flags.hpp 
4ca6c69aeb1e3343e9b0ae2562c450c4c645890c 
  3rdparty/stout/tests/flags_tests.cpp 94ba915c40836e476cf6097274a85c55acd4d73b 
  3rdparty/stout/tests/subcommand_tests.cpp 
9213d6b9faec30b5be320ab37ca29c2406c964ac 

Diff: https://reviews.apache.org/r/46825/diff/


Testing
---

make check (OS X clang-trunk w/o optimizations)

The mesos tests suite do not execute at all with an optimizing clang-trunk 
since copying of the `map` inside `FlagsBase` reference random memory leading 
to `SEGFAULTs`. With these patches all of `stout-tests` and `libprocess-tests` 
can be executed, but some remaining failures persist in `mesos-tests` (their 
number is reduced though).


Thanks,

Benjamin Bannier

Re: Review Request 46825: Fully-typed all FlagsBase::add overloads.

2016-07-05 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46825/#review140768
---



Patch looks great!

Reviews applied: [46821, 46822, 46823, 46824, 46825]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On July 5, 2016, 8:58 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46825/
> ---
> 
> (Updated July 5, 2016, 8:58 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Vinod Kone.
> 
> 
> Bugs: MESOS-3335
> https://issues.apache.org/jira/browse/MESOS-3335
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fully-typed all FlagsBase::add overloads.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/flags.hpp 
> 169f959ab2770744d615cc235062ba2becc8af64 
>   3rdparty/stout/include/stout/flags/flags.hpp 
> dd9362772d1fbd32638fc7e70126fd49d4a03c68 
>   3rdparty/stout/tests/flags_tests.cpp 
> 77f3a6af110da1ffcdf2b7ab2b66431a6b5c91d3 
>   3rdparty/stout/tests/subcommand_tests.cpp 
> 9213d6b9faec30b5be320ab37ca29c2406c964ac 
> 
> Diff: https://reviews.apache.org/r/46825/diff/
> 
> 
> Testing
> ---
> 
> make check (OS X clang-trunk w/o optimizations)
> 
> The mesos tests suite do not execute at all with an optimizing clang-trunk 
> since copying of the `map` inside `FlagsBase` reference random memory leading 
> to `SEGFAULTs`. With these patches all of `stout-tests` and 
> `libprocess-tests` can be executed, but some remaining failures persist in 
> `mesos-tests` (their number is reduced though).
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 46825: Fully-typed all FlagsBase::add overloads.

2016-07-05 Thread Benjamin Bannier 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46825/
---

(Updated July 5, 2016, 10:58 a.m.)


Review request for mesos, Alexander Rukletsov and Vinod Kone.


Changes
---

Also updated documentation.


Bugs: MESOS-3335
https://issues.apache.org/jira/browse/MESOS-3335


Repository: mesos


Description
---

Fully-typed all FlagsBase::add overloads.


Diffs (updated)
-

  3rdparty/stout/include/stout/flags.hpp 
169f959ab2770744d615cc235062ba2becc8af64 
  3rdparty/stout/include/stout/flags/flags.hpp 
dd9362772d1fbd32638fc7e70126fd49d4a03c68 
  3rdparty/stout/tests/flags_tests.cpp 77f3a6af110da1ffcdf2b7ab2b66431a6b5c91d3 
  3rdparty/stout/tests/subcommand_tests.cpp 
9213d6b9faec30b5be320ab37ca29c2406c964ac 

Diff: https://reviews.apache.org/r/46825/diff/


Testing
---

make check (OS X clang-trunk w/o optimizations)

The mesos tests suite do not execute at all with an optimizing clang-trunk 
since copying of the `map` inside `FlagsBase` reference random memory leading 
to `SEGFAULTs`. With these patches all of `stout-tests` and `libprocess-tests` 
can be executed, but some remaining failures persist in `mesos-tests` (their 
number is reduced though).


Thanks,

Benjamin Bannier

Re: Review Request 46825: Fully-typed all FlagsBase::add overloads.

2016-07-05 Thread Benjamin Bannier 


> On May 11, 2016, 11:38 p.m., Vinod Kone wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp, lines 
> > 147-179
> > 
> >
> > do we even need these overloads anymore? can't we just use the below 
> > overloads that use 'Flags' as a template parameter?

Make perfect sense, removed them.


> On May 11, 2016, 11:38 p.m., Vinod Kone wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp, lines 
> > 181-189
> > 
> >
> > why did you move this overload? makes is really hard to understand what 
> > changed. :(

This overload needs to be accessible to users so I made it `public`.


> On May 11, 2016, 11:38 p.m., Vinod Kone wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp, lines 
> > 289-290
> > 
> >
> > this comment needs to be updated.

The overload this comment refers to was removed with all the other overloads 
not taking pointers to members. I also removed the comment in that change.


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46825/#review132753
---


On July 5, 2016, 1:13 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46825/
> ---
> 
> (Updated July 5, 2016, 1:13 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Vinod Kone.
> 
> 
> Bugs: MESOS-3335
> https://issues.apache.org/jira/browse/MESOS-3335
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fully-typed all FlagsBase::add overloads.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/flags/flags.hpp 
> dd9362772d1fbd32638fc7e70126fd49d4a03c68 
>   3rdparty/stout/tests/flags_tests.cpp 
> 77f3a6af110da1ffcdf2b7ab2b66431a6b5c91d3 
>   3rdparty/stout/tests/subcommand_tests.cpp 
> 9213d6b9faec30b5be320ab37ca29c2406c964ac 
> 
> Diff: https://reviews.apache.org/r/46825/diff/
> 
> 
> Testing
> ---
> 
> make check (OS X clang-trunk w/o optimizations)
> 
> The mesos tests suite do not execute at all with an optimizing clang-trunk 
> since copying of the `map` inside `FlagsBase` reference random memory leading 
> to `SEGFAULTs`. With these patches all of `stout-tests` and 
> `libprocess-tests` can be executed, but some remaining failures persist in 
> `mesos-tests` (their number is reduced though).
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 46825: Fully-typed all FlagsBase::add overloads.

2016-07-04 Thread Benjamin Bannier 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46825/
---

(Updated July 5, 2016, 1:13 a.m.)


Review request for mesos, Alexander Rukletsov and Vinod Kone.


Changes
---

Rebased.


Bugs: MESOS-3335
https://issues.apache.org/jira/browse/MESOS-3335


Repository: mesos


Description
---

Fully-typed all FlagsBase::add overloads.


Diffs (updated)
-

  3rdparty/stout/include/stout/flags/flags.hpp 
dd9362772d1fbd32638fc7e70126fd49d4a03c68 
  3rdparty/stout/tests/flags_tests.cpp 77f3a6af110da1ffcdf2b7ab2b66431a6b5c91d3 
  3rdparty/stout/tests/subcommand_tests.cpp 
9213d6b9faec30b5be320ab37ca29c2406c964ac 

Diff: https://reviews.apache.org/r/46825/diff/


Testing
---

make check (OS X clang-trunk w/o optimizations)

The mesos tests suite do not execute at all with an optimizing clang-trunk 
since copying of the `map` inside `FlagsBase` reference random memory leading 
to `SEGFAULTs`. With these patches all of `stout-tests` and `libprocess-tests` 
can be executed, but some remaining failures persist in `mesos-tests` (their 
number is reduced though).


Thanks,

Benjamin Bannier

Re: Review Request 46825: Fully-typed all FlagsBase::add overloads.

2016-07-04 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46825/#review140647
---



Patch looks great!

Reviews applied: [46821, 46822, 46823, 46824, 46825]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On July 4, 2016, 8:17 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46825/
> ---
> 
> (Updated July 4, 2016, 8:17 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Vinod Kone.
> 
> 
> Bugs: MESOS-3335
> https://issues.apache.org/jira/browse/MESOS-3335
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fully-typed all FlagsBase::add overloads.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/flags/flags.hpp 
> dd9362772d1fbd32638fc7e70126fd49d4a03c68 
>   3rdparty/stout/tests/flags_tests.cpp 
> 77f3a6af110da1ffcdf2b7ab2b66431a6b5c91d3 
>   3rdparty/stout/tests/subcommand_tests.cpp 
> 9213d6b9faec30b5be320ab37ca29c2406c964ac 
> 
> Diff: https://reviews.apache.org/r/46825/diff/
> 
> 
> Testing
> ---
> 
> make check (OS X clang-trunk w/o optimizations)
> 
> The mesos tests suite do not execute at all with an optimizing clang-trunk 
> since copying of the `map` inside `FlagsBase` reference random memory leading 
> to `SEGFAULTs`. With these patches all of `stout-tests` and 
> `libprocess-tests` can be executed, but some remaining failures persist in 
> `mesos-tests` (their number is reduced though).
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 46825: Fully-typed all FlagsBase::add overloads.

2016-07-04 Thread Benjamin Bannier 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46825/
---

(Updated July 4, 2016, 10:17 a.m.)


Review request for mesos, Alexander Rukletsov and Vinod Kone.


Changes
---

Fixed a couple of instances where test flags were suddenly wrapped in Flags<>.


Bugs: MESOS-3335
https://issues.apache.org/jira/browse/MESOS-3335


Repository: mesos


Description
---

Fully-typed all FlagsBase::add overloads.


Diffs (updated)
-

  3rdparty/stout/include/stout/flags/flags.hpp 
dd9362772d1fbd32638fc7e70126fd49d4a03c68 
  3rdparty/stout/tests/flags_tests.cpp 77f3a6af110da1ffcdf2b7ab2b66431a6b5c91d3 
  3rdparty/stout/tests/subcommand_tests.cpp 
9213d6b9faec30b5be320ab37ca29c2406c964ac 

Diff: https://reviews.apache.org/r/46825/diff/


Testing
---

make check (OS X clang-trunk w/o optimizations)

The mesos tests suite do not execute at all with an optimizing clang-trunk 
since copying of the `map` inside `FlagsBase` reference random memory leading 
to `SEGFAULTs`. With these patches all of `stout-tests` and `libprocess-tests` 
can be executed, but some remaining failures persist in `mesos-tests` (their 
number is reduced though).


Thanks,

Benjamin Bannier

Re: Review Request 46825: Fully-typed all FlagsBase::add overloads.

2016-07-03 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46825/#review140597
---



Patch looks great!

Reviews applied: [46821, 46822, 46823, 46824, 46825]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On July 3, 2016, 3:22 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46825/
> ---
> 
> (Updated July 3, 2016, 3:22 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Vinod Kone.
> 
> 
> Bugs: MESOS-3335
> https://issues.apache.org/jira/browse/MESOS-3335
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fully-typed all FlagsBase::add overloads.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/flags/flags.hpp 
> dd9362772d1fbd32638fc7e70126fd49d4a03c68 
>   3rdparty/stout/tests/flags_tests.cpp 
> 77f3a6af110da1ffcdf2b7ab2b66431a6b5c91d3 
>   3rdparty/stout/tests/subcommand_tests.cpp 
> 9213d6b9faec30b5be320ab37ca29c2406c964ac 
> 
> Diff: https://reviews.apache.org/r/46825/diff/
> 
> 
> Testing
> ---
> 
> make check (OS X clang-trunk w/o optimizations)
> 
> The mesos tests suite do not execute at all with an optimizing clang-trunk 
> since copying of the `map` inside `FlagsBase` reference random memory leading 
> to `SEGFAULTs`. With these patches all of `stout-tests` and 
> `libprocess-tests` can be executed, but some remaining failures persist in 
> `mesos-tests` (their number is reduced though).
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 46825: Fully-typed all FlagsBase::add overloads.

2016-07-03 Thread Benjamin Bannier 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46825/
---

(Updated July 3, 2016, 5:22 p.m.)


Review request for mesos, Alexander Rukletsov and Vinod Kone.


Changes
---

Rebased.


Bugs: MESOS-3335
https://issues.apache.org/jira/browse/MESOS-3335


Repository: mesos


Description
---

Fully-typed all FlagsBase::add overloads.


Diffs (updated)
-

  3rdparty/stout/include/stout/flags/flags.hpp 
dd9362772d1fbd32638fc7e70126fd49d4a03c68 
  3rdparty/stout/tests/flags_tests.cpp 77f3a6af110da1ffcdf2b7ab2b66431a6b5c91d3 
  3rdparty/stout/tests/subcommand_tests.cpp 
9213d6b9faec30b5be320ab37ca29c2406c964ac 

Diff: https://reviews.apache.org/r/46825/diff/


Testing
---

make check (OS X clang-trunk w/o optimizations)

The mesos tests suite do not execute at all with an optimizing clang-trunk 
since copying of the `map` inside `FlagsBase` reference random memory leading 
to `SEGFAULTs`. With these patches all of `stout-tests` and `libprocess-tests` 
can be executed, but some remaining failures persist in `mesos-tests` (their 
number is reduced though).


Thanks,

Benjamin Bannier

Re: Review Request 46825: Fully-typed all FlagsBase::add overloads.

2016-05-11 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46825/#review132753
---




3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp (line 146)


i see that you made all `add`s protected here.



3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp (lines 147 - 
179)


do we even need these overloads anymore? can't we just use the below 
overloads that use 'Flags' as a template parameter?



3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp (lines 181 - 
188)


why did you move this overload? makes is really hard to understand what 
changed. :(



3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp (lines 286 - 
287)


this comment needs to be updated.


- Vinod Kone


On April 29, 2016, 9:37 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46825/
> ---
> 
> (Updated April 29, 2016, 9:37 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Vinod Kone.
> 
> 
> Bugs: MESOS-3335
> https://issues.apache.org/jira/browse/MESOS-3335
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fully-typed all FlagsBase::add overloads.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 
> c3cbcdb781e1c282d381de1ad2bf4f386ee1db21 
>   3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp 
> 66e16abe914e2a1ee7599bab857ff478b7ec20dc 
>   3rdparty/libprocess/3rdparty/stout/tests/subcommand_tests.cpp 
> 9213d6b9faec30b5be320ab37ca29c2406c964ac 
> 
> Diff: https://reviews.apache.org/r/46825/diff/
> 
> 
> Testing
> ---
> 
> make check (OS X clang-trunk w/o optimizations)
> 
> The mesos tests suite do not execute at all with an optimizing clang-trunk 
> since copying of the `map` inside `FlagsBase` reference random memory leading 
> to `SEGFAULTs`. With these patches all of `stout-tests` and 
> `libprocess-tests` can be executed, but some remaining failures persist in 
> `mesos-tests` (their number is reduced though).
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 46825: Fully-typed all FlagsBase::add overloads.

2016-04-29 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46825/#review131093
---



Patch looks great!

Reviews applied: [46821, 46822, 46823, 46824, 46825]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 29, 2016, 9:37 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46825/
> ---
> 
> (Updated April 29, 2016, 9:37 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Vinod Kone.
> 
> 
> Bugs: MESOS-3335
> https://issues.apache.org/jira/browse/MESOS-3335
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fully-typed all FlagsBase::add overloads.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 
> c3cbcdb781e1c282d381de1ad2bf4f386ee1db21 
>   3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp 
> 66e16abe914e2a1ee7599bab857ff478b7ec20dc 
>   3rdparty/libprocess/3rdparty/stout/tests/subcommand_tests.cpp 
> 9213d6b9faec30b5be320ab37ca29c2406c964ac 
> 
> Diff: https://reviews.apache.org/r/46825/diff/
> 
> 
> Testing
> ---
> 
> make check (OS X clang-trunk w/o optimizations)
> 
> The mesos tests suite do not execute at all with an optimizing clang-trunk 
> since copying of the `map` inside `FlagsBase` reference random memory leading 
> to `SEGFAULTs`. With these patches all of `stout-tests` and 
> `libprocess-tests` can be executed, but some remaining failures persist in 
> `mesos-tests` (their number is reduced though).
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Review Request 46825: Fully-typed all FlagsBase::add overloads.

2016-04-29 Thread Benjamin Bannier 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46825/
---

Review request for mesos, Alexander Rukletsov and Vinod Kone.


Bugs: MESOS-3335
https://issues.apache.org/jira/browse/MESOS-3335


Repository: mesos


Description
---

Fully-typed all FlagsBase::add overloads.


Diffs
-

  3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 
c3cbcdb781e1c282d381de1ad2bf4f386ee1db21 
  3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp 
66e16abe914e2a1ee7599bab857ff478b7ec20dc 
  3rdparty/libprocess/3rdparty/stout/tests/subcommand_tests.cpp 
9213d6b9faec30b5be320ab37ca29c2406c964ac 

Diff: https://reviews.apache.org/r/46825/diff/


Testing
---

make check (OS X clang-trunk w/o optimizations)

The mesos tests suite do not execute at all with an optimizing clang-trunk 
since copying of the `map` inside `FlagsBase` reference random memory leading 
to `SEGFAULTs`. With these patches all of `stout-tests` and `libprocess-tests` 
can be executed, but some remaining failures persist in `mesos-tests` (their 
number is reduced though).


Thanks,

Benjamin Bannier