Re: Review Request 69082: Correctly propagated `close` failures in some instances.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69082/#review212377 --- PASS: Mesos patch 69082 was successfully built and tested. Review

Re: Review Request 69082: Correctly propagated `close` failures in some instances.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69082/ --- (Updated Jan. 28, 2019, 12:30 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 69082: Correctly propagated `close` failures in some instances.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69082/#review212375 --- FAIL: Some of the unit tests failed. Please check the relevant log

Re: Review Request 69082: Correctly propagated `close` failures in some instances.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69082/ --- (Updated Jan. 28, 2019, 11:39 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 69082: Correctly propagated `close` failures in some instances.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69082/#review212373 --- Patch looks great! Reviews applied: [69082] Passed command: expo

Re: Review Request 69082: Correctly propagated `close` failures in some instances.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69082/#review212309 --- Fix it, then Ship it! Thanks for putting this up and also thank

Re: Review Request 69082: Correctly propagated `close` failures in some instances.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69082/#review212269 --- FAIL: Some of the unit tests failed. Please check the relevant log

Re: Review Request 69082: Correctly propagated `close` failures in some instances.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69082/ --- (Updated Jan. 24, 2019, 11:30 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 69082: Correctly propagated `close` failures in some instances.

> On Jan. 18, 2019, 6:59 p.m., Benjamin Mahler wrote: > > 3rdparty/stout/include/stout/os/posix/mktemp.hpp > > Line 43 (original), 43 (patched) > > > > > > s/path/template/ and s/string/path/ would be clearer? I beli

Re: Review Request 69082: Correctly propagated `close` failures in some instances.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69082/#review212146 --- Fix it, then Ship it! 3rdparty/stout/include/stout/os/posix/mk

Re: Review Request 69082: Correctly propagated `close` failures in some instances.

> On Jan. 15, 2019, 6:22 p.m., Benjamin Mahler wrote: > > Should we be surfacing a close EINTR as an error or let that be silent? > > I think these errors need some message pre-fixing? E.g. > > > > ``` > > Failed to close '3': Bad file number > > ``` > > > > As it stands the error messages will

Re: Review Request 69082: Correctly propagated `close` failures in some instances.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69082/#review212141 --- Patch looks great! Reviews applied: [69082] Passed command: expo

Re: Review Request 69082: Correctly propagated `close` failures in some instances.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69082/#review212065 --- FAIL: Some of the unit tests failed. Please check the relevant log

Re: Review Request 69082: Correctly propagated `close` failures in some instances.

> On Jan. 15, 2019, 7:22 p.m., Benjamin Mahler wrote: > > Should we be surfacing a close EINTR as an error or let that be silent? > > I think these errors need some message pre-fixing? E.g. > > > > ``` > > Failed to close '3': Bad file number > > ``` > > > > As it stands the error messages will

Re: Review Request 69082: Correctly propagated `close` failures in some instances.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69082/ --- (Updated Jan. 16, 2019, 2:06 p.m.) Review request for mesos, Benjamin Mahler, C

Re: Review Request 69082: Correctly propagated `close` failures in some instances.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69082/#review212026 --- Should we be surfacing a close EINTR as an error or let that be si

Re: Review Request 69082: Correctly propagated `close` failures in some instances.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69082/#review211369 --- Patch looks great! Reviews applied: [69082] Passed command: expo

Re: Review Request 69082: Correctly propagated `close` failures in some instances.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69082/#review211357 --- PASS: Mesos patch 69082 was successfully built and tested. Review

Re: Review Request 69082: Correctly propagated `close` failures in some instances.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69082/ --- (Updated Dec. 17, 2018, 11:54 a.m.) Review request for mesos, Chun-Hung Hsiao a

Re: Review Request 69082: Correctly propagated `close` failures in some instances.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69082/#review209994 --- PASS: Mesos patch 69082 was successfully built and tested. Review

Review Request 69082: Correctly propagated `close` failures in some instances.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69082/ --- Review request for mesos, Chun-Hung Hsiao and Alex Clemmer. Repository: mesos