[GitHub] spark pull request: [SPARK-12439][SQL] Fix toCatalystArray and Map...

2016-01-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/10391 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-12439][SQL] Fix toCatalystArray and Map...

2016-01-05 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/10391#issuecomment-169124211 Thanks, merging to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not hav

[GitHub] spark pull request: [SPARK-12593][SQL][WIP] Converts resolved logi...

2016-01-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10541#issuecomment-169122807 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-12593][SQL][WIP] Converts resolved logi...

2016-01-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10541#issuecomment-169122812 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-12573][SPARK-12574][SQL] Move SQL Parse...

2016-01-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10583#issuecomment-169122642 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-12573][SPARK-12574][SQL] Move SQL Parse...

2016-01-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10583#issuecomment-169122639 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-12593][SQL][WIP] Converts resolved logi...

2016-01-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10541#issuecomment-169122517 **[Test build #48781 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48781/consoleFull)** for PR 10541 at commit [`a8805dd`](https://g

[GitHub] spark pull request: [SPARK-12573][SPARK-12574][SQL] Move SQL Parse...

2016-01-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10583#issuecomment-169122427 **[Test build #48780 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48780/consoleFull)** for PR 10583 at commit [`157d178`](https://g

[GitHub] spark pull request: [SPARK-12295] [SQL] external spilling for wind...

2016-01-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10605#issuecomment-169121426 **[Test build #48787 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48787/consoleFull)** for PR 10605 at commit [`6b98593`](https://gi

[GitHub] spark pull request: [SPARK-12295] [SQL] external spilling for wind...

2016-01-05 Thread davies
GitHub user davies opened a pull request: https://github.com/apache/spark/pull/10605 [SPARK-12295] [SQL] external spilling for window functions This PR manage the memory used by window functions (buffered rows), also enable external spilling. After this PR, we can run windo

[GitHub] spark pull request: [SPARK-529] [core] [yarn] Add type-safe config...

2016-01-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10205#issuecomment-169119625 **[Test build #48785 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48785/consoleFull)** for PR 10205 at commit [`d378ced`](https://g

[GitHub] spark pull request: [SPARK-529] [core] [yarn] Add type-safe config...

2016-01-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10205#issuecomment-169119685 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-529] [core] [yarn] Add type-safe config...

2016-01-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10205#issuecomment-169119691 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-12149] [Web UI] Executor UI improvement...

2016-01-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10154#issuecomment-169115892 **[Test build #48786 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48786/consoleFull)** for PR 10154 at commit [`5e27bf0`](https://gi

[GitHub] spark pull request: [SPARK-12539][SQL] support writing bucketed ta...

2016-01-05 Thread nongli
Github user nongli commented on a diff in the pull request: https://github.com/apache/spark/pull/10498#discussion_r48889876 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/bucket.scala --- @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache Softwar

[GitHub] spark pull request: [SPARK-529] [core] [yarn] Add type-safe config...

2016-01-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10205#issuecomment-169114961 **[Test build #48785 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48785/consoleFull)** for PR 10205 at commit [`d378ced`](https://gi

[GitHub] spark pull request: [SPARK-12539][SQL] support writing bucketed ta...

2016-01-05 Thread nongli
Github user nongli commented on a diff in the pull request: https://github.com/apache/spark/pull/10498#discussion_r48889504 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/WriterContainer.scala --- @@ -451,3 +457,147 @@ private[sql] class DynamicPartit

[GitHub] spark pull request: [SPARK-7128][ML] Bagging (bootstrap aggregatin...

2016-01-05 Thread feynmanliang
Github user feynmanliang closed the pull request at: https://github.com/apache/spark/pull/8618 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] spark pull request: [SPARK-12539][SQL] support writing bucketed ta...

2016-01-05 Thread nongli
Github user nongli commented on a diff in the pull request: https://github.com/apache/spark/pull/10498#discussion_r48889469 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/WriterContainer.scala --- @@ -451,3 +457,147 @@ private[sql] class DynamicPartit

[GitHub] spark pull request: [SPARK-11696] [ML, MLlib] Optimization: Extend...

2016-01-05 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/9667#issuecomment-169114349 @NarineK Apologies for the lack of response here! We've had limited review bandwidth. I like providing this information to users. However, we have some of it provid

[GitHub] spark pull request: [SPARK-3873] [tests] Import ordering fixes.

2016-01-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10582#issuecomment-169112937 **[Test build #48784 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48784/consoleFull)** for PR 10582 at commit [`69116b2`](https://gi

[GitHub] spark pull request: [SPARK-12647][SQL] Fix o.a.s.sqlexecution.Exch...

2016-01-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10599#issuecomment-169112038 **[Test build #2327 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2327/consoleFull)** for PR 10599 at commit [`841eed9`](https://

[GitHub] spark pull request: [SPARK-10989] [MLLIB] Added the dot and hadama...

2016-01-05 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/9020#issuecomment-169112070 @da-steve101 I do think this should be put on hold, but I hope we can revisit SPARK-6442 soon. Could you please keep your branch, but close this issue for now? Thank

[GitHub] spark pull request: [SPARK-12539][SQL] support writing bucketed ta...

2016-01-05 Thread nongli
Github user nongli commented on a diff in the pull request: https://github.com/apache/spark/pull/10498#discussion_r4699 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/WriterContainer.scala --- @@ -451,3 +457,147 @@ private[sql] class DynamicPartit

[GitHub] spark pull request: [SPARK-7128][ML] Bagging (bootstrap aggregatin...

2016-01-05 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/8618#issuecomment-169111257 @feynmanliang I don't think we'll be able to get this merged soon b/c of limited review bandwidth, but please don't delete the branch since it's something we'd eventua

[GitHub] spark pull request: [SPARK-11579] [ML] avoid creating new optimize...

2016-01-05 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/9614#issuecomment-169110930 @avulanov Thanks that makes sense. @hhbyyh I'd agree with not creating a new optimizer every time, if this were a public API. Is there a real need for it to b

[GitHub] spark pull request: [SPARK-12630][DOC] Update param descriptions

2016-01-05 Thread BryanCutler
Github user BryanCutler commented on the pull request: https://github.com/apache/spark/pull/10598#issuecomment-169110387 thanks @vijaykiran! I marked a few things for correction and I think in general we should extend the comments to the 100 character limit where applicable. --- If

[GitHub] spark pull request: [SPARK-12539][SQL] support writing bucketed ta...

2016-01-05 Thread nongli
Github user nongli commented on a diff in the pull request: https://github.com/apache/spark/pull/10498#discussion_r4112 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala --- @@ -130,6 +130,34 @@ final class DataFrameWriter private[sql](df: DataFrame)

[GitHub] spark pull request: [SPARK-12539][SQL] support writing bucketed ta...

2016-01-05 Thread nongli
Github user nongli commented on a diff in the pull request: https://github.com/apache/spark/pull/10498#discussion_r48887994 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala --- @@ -130,6 +130,34 @@ final class DataFrameWriter private[sql](df: DataFrame)

[GitHub] spark pull request: [SPARK-12149] [Web UI] Executor UI improvement...

2016-01-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10154#issuecomment-169109703 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-12149] [Web UI] Executor UI improvement...

2016-01-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10154#issuecomment-169109699 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-12149] [Web UI] Executor UI improvement...

2016-01-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10154#issuecomment-169109402 **[Test build #48776 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48776/consoleFull)** for PR 10154 at commit [`34435a5`](https://g

[GitHub] spark pull request: [SPARK-12630][DOC] Update param descriptions

2016-01-05 Thread BryanCutler
Github user BryanCutler commented on a diff in the pull request: https://github.com/apache/spark/pull/10598#discussion_r48887470 --- Diff: python/pyspark/mllib/classification.py --- @@ -323,38 +330,45 @@ def train(cls, data, iterations=100, initialWeights=None, regParam=0.01, regTy

[GitHub] spark pull request: [SPARK-12630][DOC] Update param descriptions

2016-01-05 Thread BryanCutler
Github user BryanCutler commented on a diff in the pull request: https://github.com/apache/spark/pull/10598#discussion_r48887425 --- Diff: python/pyspark/mllib/classification.py --- @@ -323,38 +330,45 @@ def train(cls, data, iterations=100, initialWeights=None, regParam=0.01, regTy

[GitHub] spark pull request: [SPARK-3873] [tests] Import ordering fixes.

2016-01-05 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/10582#issuecomment-169108769 Another mysterious failure with no failure (although this change should not affect any test code - if it compiles, it's good). retest this please --- If your project is

[GitHub] spark pull request: [SPARK-2344] [MLlib] Add fuzzifier (m) paramet...

2016-01-05 Thread acflorea
Github user acflorea closed the pull request at: https://github.com/apache/spark/pull/9699 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is en

[GitHub] spark pull request: [SPARK-2344] [MLlib] Add fuzzifier (m) paramet...

2016-01-05 Thread acflorea
Github user acflorea commented on the pull request: https://github.com/apache/spark/pull/9699#issuecomment-169108392 @jkbradley Thank you for your comment! I understand, I will close the issue. --- If your project is set up for it, you can reply to this email and have your reply appea

[GitHub] spark pull request: [SPARK-3873] [tests] Import ordering fixes.

2016-01-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10582#issuecomment-169108174 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-3873] [tests] Import ordering fixes.

2016-01-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10582#issuecomment-169108178 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-3873] [core] Import ordering fixes.

2016-01-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10578#issuecomment-169108099 **[Test build #48782 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48782/consoleFull)** for PR 10578 at commit [`c7bee0a`](https://gi

[GitHub] spark pull request: [SPARK-3873] [tests] Import ordering fixes.

2016-01-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10582#issuecomment-169107961 **[Test build #48774 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48774/consoleFull)** for PR 10582 at commit [`69116b2`](https://g

[GitHub] spark pull request: [SPARK-12630][DOC] Update param descriptions

2016-01-05 Thread BryanCutler
Github user BryanCutler commented on a diff in the pull request: https://github.com/apache/spark/pull/10598#discussion_r48886805 --- Diff: python/pyspark/mllib/classification.py --- @@ -272,37 +274,42 @@ def train(cls, data, iterations=100, step=1.0, miniBatchFraction=1.0,

[GitHub] spark pull request: [SPARK-529] [core] [yarn] Add type-safe config...

2016-01-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10205#issuecomment-169107434 **[Test build #48783 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48783/consoleFull)** for PR 10205 at commit [`86296fd`](https://gi

[GitHub] spark pull request: [SPARK-12340][SQL]fix Int overflow in the Spar...

2016-01-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10562#issuecomment-169106952 **[Test build #2326 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2326/consoleFull)** for PR 10562 at commit [`e7577ee`](https://

[GitHub] spark pull request: [SPARK-2344] [MLlib] Add fuzzifier (m) paramet...

2016-01-05 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/9699#issuecomment-169106888 @acflorea I just commented on the JIRA about this: Thanks for the PR, but we'll need to postpone work on this because of limited review bandwidth. Could you please cl

[GitHub] spark pull request: [SPARK-12630][DOC] Update param descriptions

2016-01-05 Thread BryanCutler
Github user BryanCutler commented on a diff in the pull request: https://github.com/apache/spark/pull/10598#discussion_r48886211 --- Diff: python/pyspark/mllib/classification.py --- @@ -490,37 +506,45 @@ def train(cls, data, iterations=100, step=1.0, regParam=0.01, """

[GitHub] spark pull request: [SPARK-12578][SQL] Distinct should not be sile...

2016-01-05 Thread hvanhovell
Github user hvanhovell commented on the pull request: https://github.com/apache/spark/pull/10557#issuecomment-169106215 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabl

[GitHub] spark pull request: [SPARK-12630][DOC] Update param descriptions

2016-01-05 Thread BryanCutler
Github user BryanCutler commented on a diff in the pull request: https://github.com/apache/spark/pull/10598#discussion_r48886110 --- Diff: python/pyspark/mllib/classification.py --- @@ -323,38 +330,45 @@ def train(cls, data, iterations=100, initialWeights=None, regParam=0.01, regTy

[GitHub] spark pull request: [SPARK-12098] Cross validator with multi-arm b...

2016-01-05 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/10105#issuecomment-169104918 @yinxusen I just commented on the JIRA about this, but could we please close this issue for now? I'd like to postpone this feature due to limited review bandwidth.

[GitHub] spark pull request: [SPARK-2750][WEB UI] Add https support to the ...

2016-01-05 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/10238#issuecomment-169104775 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] spark pull request: [SPARK-4036][MLlib]Add Conditional Random Fiel...

2016-01-05 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/9794#issuecomment-169103860 @HuJiayin I just commented on the JIRA about this, but could we please close this issue for now? We won't be able to get it into MLlib soon. However, you should defi

[GitHub] spark pull request: [SPARK-12615] Remove some deprecated APIs in R...

2016-01-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/10569 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-12615] Remove some deprecated APIs in R...

2016-01-05 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/10569#discussion_r48882543 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveSparkSubmitSuite.scala --- @@ -87,7 +87,7 @@ class HiveSparkSubmitSuite runSparkSubmit(

[GitHub] spark pull request: [SPARK-12615] Remove some deprecated APIs in R...

2016-01-05 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/10569#issuecomment-169099056 LGTM. I'm going to merge this now in order to avoid merge conflicts. Let's file a followup to deal with https://github.com/apache/spark/pull/10569#discussion-diff-488

[GitHub] spark pull request: [SPARK-12615] Remove some deprecated APIs in R...

2016-01-05 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/10569#discussion_r48882230 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveSparkSubmitSuite.scala --- @@ -87,7 +87,7 @@ class HiveSparkSubmitSuite runSparkSu

[GitHub] spark pull request: [SPARK-12615] Remove some deprecated APIs in R...

2016-01-05 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/10569#discussion_r48881942 --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala --- @@ -2364,113 +2258,6 @@ object SparkContext extends Logging { */ privat

[GitHub] spark pull request: [SPARK-12593][SQL][WIP] Converts resolved logi...

2016-01-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10541#issuecomment-169097360 **[Test build #48781 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48781/consoleFull)** for PR 10541 at commit [`a8805dd`](https://gi

[GitHub] spark pull request: [SPARK-12615] Remove some deprecated APIs in R...

2016-01-05 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/10569#discussion_r48881260 --- Diff: core/src/main/scala/org/apache/spark/Aggregator.scala --- @@ -34,10 +34,6 @@ case class Aggregator[K, V, C] ( mergeValue: (C, V) => C,

[GitHub] spark pull request: [SPARK-12006][ML][PYTHON] Fix GMM failure if i...

2016-01-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9986#issuecomment-169096427 **[Test build #2328 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2328/consoleFull)** for PR 9986 at commit [`9fc7010`](https://gi

[GitHub] spark pull request: [SPARK-7675][ML][PYSpark] sparkml params type ...

2016-01-05 Thread holdenk
Github user holdenk commented on the pull request: https://github.com/apache/spark/pull/9581#issuecomment-169095503 I've fixed the _set call ( @davies ) and simplified the branching ( @sethah ). --- If your project is set up for it, you can reply to this email and have your reply app

[GitHub] spark pull request: [SPARK-11944][PYSPARK][MLLIB] python mllib.clu...

2016-01-05 Thread holdenk
Github user holdenk commented on the pull request: https://github.com/apache/spark/pull/10150#issuecomment-169095113 @yanboliang I've added the since annotations. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] spark pull request: [SPARK-12006][ML][PYTHON] Fix GMM failure if i...

2016-01-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9986#issuecomment-169094892 **[Test build #2328 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2328/consoleFull)** for PR 9986 at commit [`9fc7010`](https://git

[GitHub] spark pull request: [SPARK-12363][Mllib] Remove setRun and fix Pow...

2016-01-05 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/10539#issuecomment-169094377 @ankurdave Maybe I should ask you: What does ```Graph.fromEdges``` require of the given edge RDD? Is it just that identical edges need to be in the same partition?

[GitHub] spark pull request: [SPARK-12006][ML][PYTHON] Fix GMM failure if i...

2016-01-05 Thread thunterdb
Github user thunterdb commented on a diff in the pull request: https://github.com/apache/spark/pull/9986#discussion_r48880089 --- Diff: python/pyspark/mllib/clustering.py --- @@ -346,7 +346,7 @@ def train(cls, rdd, k, convergenceTol=1e-3, maxIterations=100, seed=None, initia

[GitHub] spark pull request: [SPARK-12573][SPARK-12574][SQL] Move SQL Parse...

2016-01-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10583#issuecomment-169094038 **[Test build #48780 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48780/consoleFull)** for PR 10583 at commit [`157d178`](https://gi

[GitHub] spark pull request: [SPARK-12125][SQL] pull out nondeterministic e...

2016-01-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10128#issuecomment-169093499 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-12125][SQL] pull out nondeterministic e...

2016-01-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10128#issuecomment-169093483 **[Test build #48778 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48778/consoleFull)** for PR 10128 at commit [`6e16657`](https://g

[GitHub] spark pull request: [SPARK-12125][SQL] pull out nondeterministic e...

2016-01-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10128#issuecomment-169093496 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-12593][SQL][WIP] Converts resolved logi...

2016-01-05 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/10541#discussion_r48879512 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/literals.scala --- @@ -213,6 +215,34 @@ case class Literal protected (valu

[GitHub] spark pull request: [SPARK-12125][SQL] pull out nondeterministic e...

2016-01-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10128#issuecomment-169093176 **[Test build #48778 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48778/consoleFull)** for PR 10128 at commit [`6e16657`](https://gi

[GitHub] spark pull request: [SPARK-12593][SQL][WIP] Converts resolved logi...

2016-01-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10541#issuecomment-169092952 **[Test build #48779 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48779/consoleFull)** for PR 10541 at commit [`1796540`](https://gi

[GitHub] spark pull request: [SPARK-12363][Mllib] Remove setRun and fix Pow...

2016-01-05 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/10539#issuecomment-169091413 @ankurdave Would you mind checking out this issue? It's really weird to me. Here's what's happening: * Background: PowerIterationClustering (PIC) initializes a `

[GitHub] spark pull request: [SPARKR][DOC] minor doc update for version in ...

2016-01-05 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/10574#issuecomment-169090153 We've already pushed the docs, but any committer can update them I think :) --- If your project is set up for it, you can reply to this email and have your reply appea

[GitHub] spark pull request: [SPARK-12618] [CORE] [STREAMING] [SQL] Clean u...

2016-01-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10570#issuecomment-169090190 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-12618] [CORE] [STREAMING] [SQL] Clean u...

2016-01-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10570#issuecomment-169090132 **[Test build #48777 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48777/consoleFull)** for PR 10570 at commit [`e6702c4`](https://g

[GitHub] spark pull request: [SPARK-12618] [CORE] [STREAMING] [SQL] Clean u...

2016-01-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10570#issuecomment-169090188 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-12125][SQL] pull out nondeterministic e...

2016-01-05 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/10128#issuecomment-169089505 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark pull request: [SPARK-12125][SQL] pull out nondeterministic e...

2016-01-05 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/10128#issuecomment-169089482 This seems like a reasonable thing to do, but the implementation seems unnecessarily complex. Why not just: - `transform` the condition, matching on non determini

[GitHub] spark pull request: [SPARK-12647][SQL] Fix o.a.s.sqlexecution.Exch...

2016-01-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10599#issuecomment-169088959 **[Test build #2327 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2327/consoleFull)** for PR 10599 at commit [`841eed9`](https://g

[GitHub] spark pull request: [SPARK-12480][follow-up] use a single column v...

2016-01-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/10588 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-12647][SQL] Fix o.a.s.sqlexecution.Exch...

2016-01-05 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/10599#issuecomment-169088557 Jenkins, test this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have t

[GitHub] spark pull request: [SPARK-12480][follow-up] use a single column v...

2016-01-05 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/10588#issuecomment-169088356 Thanks - I've merged this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have t

[GitHub] spark pull request: [SPARK-12643][Build] Set lib directory for ant...

2016-01-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/10571 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-12643][Build] Set lib directory for ant...

2016-01-05 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/10571#issuecomment-169087913 I've merged this. Thank. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi

[GitHub] spark pull request: [SPARK-9843][SQL] Make catalyst optimizer pass...

2016-01-05 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/10210#discussion_r48875283 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkOptimizer.scala --- @@ -0,0 +1,30 @@ +/* + * Licensed to the Apache Software F

[GitHub] spark pull request: [SPARK-12438][SQL] Add SQLUserDefinedType supp...

2016-01-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/10390 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-12438][SQL] Add SQLUserDefinedType supp...

2016-01-05 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/10390#issuecomment-169087339 Thanks, merging to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not hav

[GitHub] spark pull request: [SPARK-12618] [CORE] [STREAMING] [SQL] Clean u...

2016-01-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10570#issuecomment-169087013 **[Test build #48777 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48777/consoleFull)** for PR 10570 at commit [`e6702c4`](https://gi

[GitHub] spark pull request: [SPARK-12317][SQL]Support configurable value i...

2016-01-05 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/10314#issuecomment-169086076 This seems like a nice convenience for the users. A few comments: - The description / title could be improved. Some think about support units for configuration.

[GitHub] spark pull request: [SPARK-12618] [CORE] [STREAMING] [SQL] Clean u...

2016-01-05 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/10570#issuecomment-169084717 @JoshRosen you might be able to help here. The Spark build passed, but the MiMa failed due to a compilation error. The change that tripped this uses an API call in `comm

[GitHub] spark pull request: [SPARK-12149] [Web UI] Executor UI improvement...

2016-01-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10154#issuecomment-169084460 **[Test build #48776 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48776/consoleFull)** for PR 10154 at commit [`34435a5`](https://gi

[GitHub] spark pull request: [SPARK-12393] [SparkR] Add read.text and write...

2016-01-05 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/10348#discussion_r48875105 --- Diff: R/pkg/R/DataFrame.R --- @@ -661,6 +661,34 @@ setMethod("saveAsParquetFile", write.parquet(x, path) })

[GitHub] spark pull request: [SPARK-3873] [sql] Import ordering fixes.

2016-01-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10573#issuecomment-169083412 **[Test build #48775 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48775/consoleFull)** for PR 10573 at commit [`ff2dbe1`](https://gi

[GitHub] spark pull request: [SPARK-11878][SQL]: Eliminate distribute by in...

2016-01-05 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/9858#discussion_r48874115 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala --- @@ -361,8 +361,15 @@ private[sql] abstract class SparkStrategies e

[GitHub] spark pull request: [SPARK-3873] [tests] Import ordering fixes.

2016-01-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10582#issuecomment-169082252 **[Test build #48774 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48774/consoleFull)** for PR 10582 at commit [`69116b2`](https://gi

[GitHub] spark pull request: [SPARK-11878][SQL]: Eliminate distribute by in...

2016-01-05 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/9858#discussion_r48873698 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala --- @@ -361,8 +361,15 @@ private[sql] abstract class SparkStrategies e

[GitHub] spark pull request: [SPARK-11624][SPARK-11972][SQL]fix commands th...

2016-01-05 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/9589#discussion_r48873452 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/ClientWrapper.scala --- @@ -151,29 +152,34 @@ private[hive] class ClientWrapper(

[GitHub] spark pull request: [SPARK-10810] [SPARK-10902] [SQL] Improve sess...

2016-01-05 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/8909#issuecomment-169077537 @Neuw84 Since 1.6, each SQLContext will have separated session, you should share the same SQLContext in this case (using SQLContext.getOrCreate()). --- If your project i

[GitHub] spark pull request: [SPARK-12616] [SQL] Adding a New Logical Opera...

2016-01-05 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/10577#issuecomment-169077567 > Will add the new Dataframe and Dataset APIs for unionAll, if my understanding is correct. You don't need to add any new APIs, just call the optimizer rule di

[GitHub] spark pull request: [SPARK-12616] [SQL] Adding a New Logical Opera...

2016-01-05 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/10577#discussion_r48872458 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/patterns.scala --- @@ -169,18 +169,3 @@ object ExtractFiltersAndInnerJoins ext

<    1   2   3   4   5   6   7   8   9   >