[GitHub] spark pull request #15975: [SPARK-18538] [SQL] Fix Concurrent Table Fetching...

2016-11-26 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/15975#discussion_r89684437 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala --- @@ -220,22 +228,14 @@ class DataFrameReader private[sql](sparkSession:

[GitHub] spark issue #16003: [SPARK-18482][SQL] make sure Spark can access the table ...

2016-11-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16003 **[Test build #69200 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69200/consoleFull)** for PR 16003 at commit

[GitHub] spark issue #16018: [SPARK-18594] [SQL] Name Validation of Databases/Tables

2016-11-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16018 **[Test build #69199 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69199/consoleFull)** for PR 16018 at commit

[GitHub] spark pull request #16018: [SPARK-18594] [SQL] Name Validation of Databases/...

2016-11-26 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16018#discussion_r89684361 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/rules.scala --- @@ -309,32 +309,17 @@ case class PreWriteCheck(conf:

[GitHub] spark issue #16020: [SPARK-18596][ML] add checking and caching to bisecting ...

2016-11-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16020 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69198/ Test PASSed. ---

[GitHub] spark issue #16020: [SPARK-18596][ML] add checking and caching to bisecting ...

2016-11-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16020 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16020: [SPARK-18596][ML] add checking and caching to bisecting ...

2016-11-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16020 **[Test build #69198 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69198/consoleFull)** for PR 16020 at commit

[GitHub] spark issue #15958: [SPARK-17932][SQL] Support SHOW TABLES EXTENDED LIKE 'id...

2016-11-26 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15958 The `Non-Goals` in the PR description is also confusing. Basically, what this PR does is to explicitly output an unsupported error message if users specify PARTITION. Could you also update that?

[GitHub] spark pull request #15136: [SPARK-17581] [SQL] Invalidate Statistics After S...

2016-11-26 Thread gatorsmile
Github user gatorsmile closed the pull request at: https://github.com/apache/spark/pull/15136 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark issue #15136: [SPARK-17581] [SQL] Invalidate Statistics After Some ALT...

2016-11-26 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15136 The behavior of Hive 2.1 is different from Hive 1.6. Hive 2.1 does not invalidate the stats, but only mark it inaccurate. Thus, this PR can be closed. Thanks! --- If your project is set up for

[GitHub] spark issue #15958: [SPARK-17932][SQL] Support SHOW TABLES EXTENDED LIKE 'id...

2016-11-26 Thread jiangxb1987
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/15958 @gatorsmile I've updated the title, thank you! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #16020: [SPARK-18596][ML] add checking and caching to bisecting ...

2016-11-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16020 **[Test build #69198 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69198/consoleFull)** for PR 16020 at commit

[GitHub] spark pull request #15780: [SPARK-18284][SQL] Make ExpressionEncoder.seriali...

2016-11-26 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/15780#discussion_r89683595 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala --- @@ -574,7 +574,12 @@ object ScalaReflection extends

[GitHub] spark pull request #16020: [SPARK-18596][ML] add checking and caching to bis...

2016-11-26 Thread hhbyyh
GitHub user hhbyyh opened a pull request: https://github.com/apache/spark/pull/16020 [SPARK-18596][ML] add checking and caching to bisecting kmeans ## What changes were proposed in this pull request? jira: https://issues.apache.org/jira/browse/SPARK-18596 This is a follow

[GitHub] spark pull request #15780: [SPARK-18284][SQL] Make ExpressionEncoder.seriali...

2016-11-26 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/15780#discussion_r89683544 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala --- @@ -643,8 +646,14 @@ case class

[GitHub] spark pull request #15780: [SPARK-18284][SQL] Make ExpressionEncoder.seriali...

2016-11-26 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/15780#discussion_r89683532 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala --- @@ -605,7 +608,7 @@ object

[GitHub] spark pull request #15780: [SPARK-18284][SQL] Make ExpressionEncoder.seriali...

2016-11-26 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/15780#discussion_r89683520 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala --- @@ -590,7 +591,11 @@ object ScalaReflection extends

[GitHub] spark pull request #15780: [SPARK-18284][SQL] Make ExpressionEncoder.seriali...

2016-11-26 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/15780#discussion_r89683485 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala --- @@ -590,7 +591,11 @@ object ScalaReflection extends

[GitHub] spark pull request #15975: [SPARK-18538] [SQL] Fix Concurrent Table Fetching...

2016-11-26 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/15975#discussion_r89683214 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala --- @@ -220,22 +228,14 @@ class DataFrameReader private[sql](sparkSession:

[GitHub] spark issue #16018: [SPARK-18594] [SQL] Name Validation of Databases/Tables

2016-11-26 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/16018 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark issue #16019: [SPARK-18595] [SQL] Handling ignoreIfExists in HiveExter...

2016-11-26 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/16019 so the actual difference is, if the table exists and `ignoreIfExists` is true, previously we will still try to create this table, but logically we should do nothing. Since we are

[GitHub] spark issue #15998: [SPARK-18572][SQL] Add a method `listPartitionNames` to ...

2016-11-26 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/15998 where is the speed-up come from? Is it because the hive API `getPartitionNames` is faster than `getPartitions`? Or is it because we generate the partition string(`a=1/b=2/c=3`) at hive side and

[GitHub] spark issue #15255: [SPARK-17680] [SQL] [TEST] Added a Testcase for Verifyin...

2016-11-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15255 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69197/ Test PASSed. ---

[GitHub] spark issue #15255: [SPARK-17680] [SQL] [TEST] Added a Testcase for Verifyin...

2016-11-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15255 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15255: [SPARK-17680] [SQL] [TEST] Added a Testcase for Verifyin...

2016-11-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15255 **[Test build #69197 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69197/consoleFull)** for PR 15255 at commit

[GitHub] spark issue #15998: [SPARK-18572][SQL] Add a method `listPartitionNames` to ...

2016-11-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15998 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69195/ Test PASSed. ---

[GitHub] spark issue #15998: [SPARK-18572][SQL] Add a method `listPartitionNames` to ...

2016-11-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15998 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15998: [SPARK-18572][SQL] Add a method `listPartitionNames` to ...

2016-11-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15998 **[Test build #69195 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69195/consoleFull)** for PR 15998 at commit

[GitHub] spark pull request #15998: [SPARK-18572][SQL] Add a method `listPartitionNam...

2016-11-26 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/15998#discussion_r89681535 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -730,6 +730,23 @@ class SessionCatalog( }

[GitHub] spark issue #16019: [SPARK-18595] [SQL] Handling ignoreIfExists in HiveExter...

2016-11-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16019 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69196/ Test PASSed. ---

[GitHub] spark issue #16019: [SPARK-18595] [SQL] Handling ignoreIfExists in HiveExter...

2016-11-26 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/16019 cc @cloud-fan @hvanhovell --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #16019: [SPARK-18595] [SQL] Handling ignoreIfExists in HiveExter...

2016-11-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16019 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16019: [SPARK-18595] [SQL] Handling ignoreIfExists in HiveExter...

2016-11-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16019 **[Test build #69196 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69196/consoleFull)** for PR 16019 at commit

[GitHub] spark issue #16018: [SPARK-18594] [SQL] Name Validation of Databases/Tables

2016-11-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16018 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69194/ Test PASSed. ---

[GitHub] spark issue #16018: [SPARK-18594] [SQL] Name Validation of Databases/Tables

2016-11-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16018 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16018: [SPARK-18594] [SQL] Name Validation of Databases/Tables

2016-11-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16018 **[Test build #69194 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69194/consoleFull)** for PR 16018 at commit

[GitHub] spark issue #15255: [SPARK-17680] [SQL] [TEST] Added a Testcase for Verifyin...

2016-11-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15255 **[Test build #69197 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69197/consoleFull)** for PR 15255 at commit

[GitHub] spark issue #15255: [SPARK-17680] [SQL] [TEST] Added a Testcase for Verifyin...

2016-11-26 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15255 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #15958: [SPARK-17932][SQL] Failed to run SQL "show table extende...

2016-11-26 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15958 Could you update the PR title? The current one is confusing. This PR is not a bug fix. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request #15998: [SPARK-18572][SQL] Add a method `listPartitionNam...

2016-11-26 Thread mallman
Github user mallman commented on a diff in the pull request: https://github.com/apache/spark/pull/15998#discussion_r89680470 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala --- @@ -922,6 +923,29 @@ private[spark] class

[GitHub] spark issue #16019: [SPARK-18595] [SQL] Handling ignoreIfExists in HiveExter...

2016-11-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16019 **[Test build #69196 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69196/consoleFull)** for PR 16019 at commit

[GitHub] spark pull request #16019: [SPARK-18595] [SQL] Handling ignoreIfExists in Hi...

2016-11-26 Thread gatorsmile
GitHub user gatorsmile opened a pull request: https://github.com/apache/spark/pull/16019 [SPARK-18595] [SQL] Handling ignoreIfExists in HiveExternalCatalog createTable API ### What changes were proposed in this pull request? Currently, `HiveExternalCatalog`'s `createTable`

[GitHub] spark issue #16015: [SPARK-17251][SQL] Improve `OuterReference` to be `Named...

2016-11-26 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/16015 Thank you for merging, @hvanhovell ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #15998: [SPARK-18572][SQL] Add a method `listPartitionNam...

2016-11-26 Thread mallman
Github user mallman commented on a diff in the pull request: https://github.com/apache/spark/pull/15998#discussion_r89679682 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala --- @@ -922,6 +923,29 @@ private[spark] class

[GitHub] spark pull request #16015: [SPARK-17251][SQL] Improve `OuterReference` to be...

2016-11-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/16015 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #16015: [SPARK-17251][SQL] Improve `OuterReference` to be `Named...

2016-11-26 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/16015 Merging to master/2.1/2.0. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #14801: [SPARK-17234] [SQL] Table Existence Checking when...

2016-11-26 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/14801#discussion_r89679622 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala --- @@ -171,9 +172,13 @@ private[spark] class

[GitHub] spark pull request #15998: [SPARK-18572][SQL] Add a method `listPartitionNam...

2016-11-26 Thread mallman
Github user mallman commented on a diff in the pull request: https://github.com/apache/spark/pull/15998#discussion_r89679527 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala --- @@ -922,6 +923,29 @@ private[spark] class

[GitHub] spark pull request #15998: [SPARK-18572][SQL] Add a method `listPartitionNam...

2016-11-26 Thread mallman
Github user mallman commented on a diff in the pull request: https://github.com/apache/spark/pull/15998#discussion_r89679485 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala --- @@ -922,6 +923,29 @@ private[spark] class

[GitHub] spark issue #15998: [SPARK-18572][SQL] Add a method `listPartitionNames` to ...

2016-11-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15998 **[Test build #69195 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69195/consoleFull)** for PR 15998 at commit

[GitHub] spark pull request #15998: [SPARK-18572][SQL] Add a method `listPartitionNam...

2016-11-26 Thread mallman
Github user mallman commented on a diff in the pull request: https://github.com/apache/spark/pull/15998#discussion_r89679477 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalog.scala --- @@ -189,6 +189,21 @@ abstract class ExternalCatalog {

[GitHub] spark issue #15975: [SPARK-18538] [SQL] Fix Concurrent Table Fetching Using ...

2016-11-26 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15975 Any more comment? : ) Also cc @cloud-fan @hvanhovell --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark issue #16018: [SPARK-18594] [SQL] Name Validation of Databases/Tables

2016-11-26 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/16018 cc @cloud-fan @yhuai --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #16018: [SPARK-18594] [SQL] Name Validation of Databases/Tables

2016-11-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16018 **[Test build #69194 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69194/consoleFull)** for PR 16018 at commit

[GitHub] spark pull request #16018: [SPARK-18594] [SQL] Name Validation of Databases/...

2016-11-26 Thread gatorsmile
GitHub user gatorsmile opened a pull request: https://github.com/apache/spark/pull/16018 [SPARK-18594] [SQL] Name Validation of Databases/Tables ### What changes were proposed in this pull request? Currently, the name validation checks are limited to table creation. It is

[GitHub] spark issue #16013: [SPARK-3359][DOCS] Make javadoc8 working for unidoc/genj...

2016-11-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16013 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69193/ Test PASSed. ---

[GitHub] spark issue #16013: [SPARK-3359][DOCS] Make javadoc8 working for unidoc/genj...

2016-11-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16013 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16013: [SPARK-3359][DOCS] Make javadoc8 working for unidoc/genj...

2016-11-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16013 **[Test build #69193 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69193/consoleFull)** for PR 16013 at commit

[GitHub] spark issue #16015: [SPARK-17251][SQL] Improve `OuterReference` to be `Named...

2016-11-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16015 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16015: [SPARK-17251][SQL] Improve `OuterReference` to be `Named...

2016-11-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16015 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69192/ Test PASSed. ---

[GitHub] spark issue #16015: [SPARK-17251][SQL] Improve `OuterReference` to be `Named...

2016-11-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16015 **[Test build #69192 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69192/consoleFull)** for PR 16015 at commit

[GitHub] spark pull request #15998: [SPARK-18572][SQL] Add a method `listPartitionNam...

2016-11-26 Thread mallman
Github user mallman commented on a diff in the pull request: https://github.com/apache/spark/pull/15998#discussion_r89678628 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/InMemoryCatalog.scala --- @@ -482,6 +482,19 @@ class InMemoryCatalog(

[GitHub] spark issue #16013: [SPARK-3359][DOCS] Make javadoc8 working for unidoc/genj...

2016-11-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16013 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69191/ Test PASSed. ---

[GitHub] spark issue #16013: [SPARK-3359][DOCS] Make javadoc8 working for unidoc/genj...

2016-11-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16013 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16013: [SPARK-3359][DOCS] Make javadoc8 working for unidoc/genj...

2016-11-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16013 **[Test build #69191 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69191/consoleFull)** for PR 16013 at commit

[GitHub] spark pull request #15998: [SPARK-18572][SQL] Add a method `listPartitionNam...

2016-11-26 Thread mallman
Github user mallman commented on a diff in the pull request: https://github.com/apache/spark/pull/15998#discussion_r89678259 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala --- @@ -922,6 +923,29 @@ private[spark] class

[GitHub] spark pull request #15998: [SPARK-18572][SQL] Add a method `listPartitionNam...

2016-11-26 Thread mallman
Github user mallman commented on a diff in the pull request: https://github.com/apache/spark/pull/15998#discussion_r89678233 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/InMemoryCatalog.scala --- @@ -482,6 +482,19 @@ class InMemoryCatalog(

[GitHub] spark issue #16015: [SPARK-17251][SQL] Improve `OuterReference` to be `Named...

2016-11-26 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/16015 Thank you, @hvanhovell ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #16015: [SPARK-17251][SQL] Improve `OuterReference` to be `Named...

2016-11-26 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/16015 LGTM pending jenkins. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #16013: [SPARK-3359][DOCS] Make javadoc8 working for unidoc/genj...

2016-11-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16013 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69190/ Test PASSed. ---

[GitHub] spark issue #16013: [SPARK-3359][DOCS] Make javadoc8 working for unidoc/genj...

2016-11-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16013 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16013: [SPARK-3359][DOCS] Make javadoc8 working for unidoc/genj...

2016-11-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16013 **[Test build #69190 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69190/consoleFull)** for PR 16013 at commit

[GitHub] spark issue #16013: [SPARK-3359][DOCS] Make javadoc8 working for unidoc/genj...

2016-11-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16013 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69189/ Test PASSed. ---

[GitHub] spark issue #16013: [SPARK-3359][DOCS] Make javadoc8 working for unidoc/genj...

2016-11-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16013 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16013: [SPARK-3359][DOCS] Make javadoc8 working for unidoc/genj...

2016-11-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16013 **[Test build #69189 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69189/consoleFull)** for PR 16013 at commit

[GitHub] spark issue #16013: [SPARK-3359][DOCS] Make javadoc8 working for unidoc/genj...

2016-11-26 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/16013 @srowen, this PR become unintentionally bigger than I thought. I am happy to split this into multiple ones if you think so. I left some comments on the changes where the output images might be

[GitHub] spark pull request #16013: [SPARK-3359][DOCS] Make javadoc8 working for unid...

2016-11-26 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/16013#discussion_r89677052 --- Diff: core/src/main/scala/org/apache/spark/rdd/JdbcRDD.scala --- @@ -191,7 +197,10 @@ object JdbcRDD { * The RDD takes care of closing the

[GitHub] spark pull request #16014: [SPARK-18590][SPARKR] build R source package when...

2016-11-26 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/16014#discussion_r89677001 --- Diff: dev/create-release/release-build.sh --- @@ -189,6 +189,9 @@ if [[ "$1" == "package" ]]; then SHA512 $PYTHON_DIST_NAME > \

[GitHub] spark issue #16013: [SPARK-3359][DOCS] Make javadoc8 working for unidoc/genj...

2016-11-26 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/16013 @srowen, this PR become unintentionally bigger than I thought. I am happy to split this into multiple ones if you think so. I left some comments on the changes where the output images might be

[GitHub] spark issue #16013: [SPARK-3359][DOCS] Make javadoc8 working for unidoc/genj...

2016-11-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16013 **[Test build #69193 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69193/consoleFull)** for PR 16013 at commit

[GitHub] spark issue #16015: [SPARK-17251][SQL] Improve `OuterReference` to be `Named...

2016-11-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16015 **[Test build #69192 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69192/consoleFull)** for PR 16015 at commit

[GitHub] spark pull request #16013: [WIP][SPARK-3359][DOCS] Make javadoc8 working for...

2016-11-26 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/16013#discussion_r89676820 --- Diff: mllib/src/main/scala/org/apache/spark/ml/param/params.scala --- @@ -165,32 +165,56 @@ object ParamValidators { s" of unexpected

[GitHub] spark pull request #16013: [WIP][SPARK-3359][DOCS] Make javadoc8 working for...

2016-11-26 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/16013#discussion_r89676784 --- Diff: core/src/main/scala/org/apache/spark/util/random/SamplingUtils.scala --- @@ -67,20 +67,23 @@ private[spark] object SamplingUtils { }

[GitHub] spark issue #15941: [WIP][SQL][DOC] Fix incorrect `code` tag

2016-11-26 Thread weiqingy
Github user weiqingy commented on the issue: https://github.com/apache/spark/pull/15941 Thanks for review this, @srowen --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request #16013: [WIP][SPARK-3359][DOCS] Make javadoc8 working for...

2016-11-26 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/16013#discussion_r89676738 --- Diff: core/src/main/scala/org/apache/spark/rdd/JdbcRDD.scala --- @@ -191,7 +197,10 @@ object JdbcRDD { * The RDD takes care of closing the

[GitHub] spark pull request #16013: [WIP][SPARK-3359][DOCS] Make javadoc8 working for...

2016-11-26 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/16013#discussion_r89676728 --- Diff: core/src/main/scala/org/apache/spark/rdd/JdbcRDD.scala --- @@ -151,7 +154,10 @@ object JdbcRDD { * The RDD takes care of closing the

[GitHub] spark pull request #16013: [WIP][SPARK-3359][DOCS] Make javadoc8 working for...

2016-11-26 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/16013#discussion_r89676716 --- Diff: core/src/main/scala/org/apache/spark/rdd/JdbcRDD.scala --- @@ -41,7 +41,10 @@ private[spark] class JdbcPartition(idx: Int, val lower: Long,

[GitHub] spark pull request #15960: [SPARK-18521] Add `NoRedundantStringInterpolator`...

2016-11-26 Thread weiqingy
Github user weiqingy closed the pull request at: https://github.com/apache/spark/pull/15960 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #15960: [SPARK-18521] Add `NoRedundantStringInterpolator` Scala ...

2016-11-26 Thread weiqingy
Github user weiqingy commented on the issue: https://github.com/apache/spark/pull/15960 Thanks @rxin @srowen @holdenk. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request #16013: [WIP][SPARK-3359][DOCS] Make javadoc8 working for...

2016-11-26 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/16013#discussion_r89676519 --- Diff: core/src/main/scala/org/apache/spark/util/random/StratifiedSamplingUtils.scala --- @@ -160,12 +161,20 @@ private[spark] object

[GitHub] spark pull request #16013: [WIP][SPARK-3359][DOCS] Make javadoc8 working for...

2016-11-26 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/16013#discussion_r89676506 --- Diff: core/src/main/scala/org/apache/spark/rdd/RDD.scala --- @@ -1184,8 +1187,13 @@ abstract class RDD[T: ClassTag]( * * @note This

[GitHub] spark issue #16013: [WIP][SPARK-3359][DOCS] Make javadoc8 working for unidoc...

2016-11-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16013 **[Test build #69191 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69191/consoleFull)** for PR 16013 at commit

[GitHub] spark pull request #16013: [WIP][SPARK-3359][DOCS] Make javadoc8 working for...

2016-11-26 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/16013#discussion_r89676461 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/InsertIntoHiveTable.scala --- @@ -57,9 +57,17 @@ import

[GitHub] spark pull request #16013: [WIP][SPARK-3359][DOCS] Make javadoc8 working for...

2016-11-26 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/16013#discussion_r89676437 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/sources/interfaces.scala --- @@ -216,10 +216,13 @@ abstract class BaseRelation { /**

[GitHub] spark pull request #16013: [WIP][SPARK-3359][DOCS] Make javadoc8 working for...

2016-11-26 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/16013#discussion_r89676433 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/sources/interfaces.scala --- @@ -216,10 +216,13 @@ abstract class BaseRelation { /**

[GitHub] spark pull request #16013: [WIP][SPARK-3359][DOCS] Make javadoc8 working for...

2016-11-26 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/16013#discussion_r89676419 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala --- @@ -40,9 +40,14 @@ case class JdbcType(databaseTypeDefinition :

[GitHub] spark pull request #16013: [WIP][SPARK-3359][DOCS] Make javadoc8 working for...

2016-11-26 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/16013#discussion_r89676409 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -1066,9 +1073,12 @@ object functions { * within each partition in

[GitHub] spark pull request #16013: [WIP][SPARK-3359][DOCS] Make javadoc8 working for...

2016-11-26 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/16013#discussion_r89676398 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -1048,9 +1052,12 @@ object functions { * within each partition in

[GitHub] spark pull request #16013: [WIP][SPARK-3359][DOCS] Make javadoc8 working for...

2016-11-26 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/16013#discussion_r89676381 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -474,7 +474,9 @@ object functions { /** * Aggregate

[GitHub] spark pull request #16013: [WIP][SPARK-3359][DOCS] Make javadoc8 working for...

2016-11-26 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/16013#discussion_r89676335 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameStatFunctions.scala --- @@ -44,7 +44,9 @@ final class DataFrameStatFunctions

  1   2   >