Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/16715#discussion_r100422395
--- Diff:
examples/src/main/python/ml/bucketed_random_projection_lsh_example.py ---
@@ -0,0 +1,86 @@
+#
+# Licensed to the Apache Software
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/16715#discussion_r100427531
--- Diff: python/pyspark/ml/feature.py ---
@@ -120,6 +122,196 @@ def getThreshold(self):
return self.getOrDefault(self.threshold)
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/16715#discussion_r100427045
--- Diff: examples/src/main/python/ml/min_hash_lsh_example.py ---
@@ -0,0 +1,85 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/16715#discussion_r100421903
--- Diff:
examples/src/main/python/ml/bucketed_random_projection_lsh_example.py ---
@@ -0,0 +1,86 @@
+#
+# Licensed to the Apache Software
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/16715#discussion_r100426756
--- Diff:
examples/src/main/java/org/apache/spark/examples/ml/JavaMinHashLSHExample.java
---
@@ -44,25 +45,67 @@ public static void main(String[] args) {
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/16715#discussion_r100426237
--- Diff:
examples/src/main/java/org/apache/spark/examples/ml/JavaBucketedRandomProjectionLSHExample.java
---
@@ -71,25 +71,32 @@ public static void
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/16715#discussion_r100427633
--- Diff: python/pyspark/ml/feature.py ---
@@ -755,6 +947,101 @@ def maxAbs(self):
@inherit_doc
+class MinHashLSH(JavaEstimator,
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/16715#discussion_r100426683
--- Diff:
examples/src/main/java/org/apache/spark/examples/ml/JavaMinHashLSHExample.java
---
@@ -44,25 +45,67 @@ public static void main(String[] args) {
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/16715#discussion_r100428492
--- Diff:
examples/src/main/java/org/apache/spark/examples/ml/JavaMinHashLSHExample.java
---
@@ -44,25 +45,67 @@ public static void main(String[] args) {
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/16715#discussion_r100420489
--- Diff:
examples/src/main/python/ml/bucketed_random_projection_lsh_example.py ---
@@ -0,0 +1,86 @@
+#
+# Licensed to the Apache Software
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/16715#discussion_r100426020
--- Diff:
examples/src/main/java/org/apache/spark/examples/ml/JavaBucketedRandomProjectionLSHExample.java
---
@@ -71,25 +71,32 @@ public static void
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16610
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16610
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72659/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16610
**[Test build #72659 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72659/testReport)**
for PR 16610 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16875
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72658/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16875
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16875
**[Test build #72658 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72658/testReport)**
for PR 16875 at commit
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16868#discussion_r100424167
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -926,38 +1006,63 @@ class HiveDDLSuite
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16868#discussion_r100424068
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -926,38 +1006,63 @@ class HiveDDLSuite
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/16865#discussion_r100423521
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -1004,7 +1016,8 @@ object
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16868#discussion_r100423391
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -682,8 +682,8 @@ class HiveDDLSuite
))
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16868
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16868
OK to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/16865#discussion_r100422867
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -1004,7 +1016,8 @@ object
Github user erenavsarogullari commented on a diff in the pull request:
https://github.com/apache/spark/pull/16813#discussion_r100422328
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/SchedulableBuilder.scala ---
@@ -83,15 +83,19 @@ private[spark] class
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16744
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16744
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72656/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16744
**[Test build #72656 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72656/testReport)**
for PR 16744 at commit
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/16813#discussion_r100420228
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/SchedulableBuilder.scala ---
@@ -83,15 +83,19 @@ private[spark] class
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/16857
retest this please.
@vitillo This is just a transient error. It's public so you should be able
to view the build results.
---
If your project is set up for it, you can reply to this
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/16862#discussion_r100414780
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -758,9 +761,33 @@ private[spark] class BlockManager(
blockId:
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/16639#discussion_r100413021
--- Diff: core/src/test/scala/org/apache/spark/executor/ExecutorSuite.scala
---
@@ -133,6 +123,153 @@ class ExecutorSuite extends SparkFunSuite {
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/16639#discussion_r100409667
--- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala ---
@@ -340,6 +342,14 @@ private[spark] class Executor(
}
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/16639#discussion_r100409974
--- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala ---
@@ -405,6 +415,13 @@ private[spark] class Executor(
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/16639#discussion_r100413764
--- Diff: core/src/test/scala/org/apache/spark/executor/ExecutorSuite.scala
---
@@ -133,6 +123,153 @@ class ExecutorSuite extends SparkFunSuite {
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/16639#discussion_r100413614
--- Diff: core/src/test/scala/org/apache/spark/executor/ExecutorSuite.scala
---
@@ -133,6 +123,153 @@ class ExecutorSuite extends SparkFunSuite {
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/16639#discussion_r100414154
--- Diff: core/src/test/scala/org/apache/spark/executor/ExecutorSuite.scala
---
@@ -133,6 +123,153 @@ class ExecutorSuite extends SparkFunSuite {
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/16639#discussion_r100413863
--- Diff: core/src/test/scala/org/apache/spark/executor/ExecutorSuite.scala
---
@@ -133,6 +123,153 @@ class ExecutorSuite extends SparkFunSuite {
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/16639#discussion_r100412522
--- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala ---
@@ -405,6 +415,13 @@ private[spark] class Executor(
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/16859#discussion_r100412047
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/protocol/MessageDecoder.java
---
@@ -35,6 +35,12 @@
private static
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16859
**[Test build #72660 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72660/testReport)**
for PR 16859 at commit
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/16859
I'm going to change the default value back since ReplSuite passed in `Test
build #72655 has finished for PR 16859 at commit 1c88474.`.
---
If your project is set up for it, you can reply to
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/16859
> Test build #3570 has finished for PR 16859 at commit 1c88474.
This is the known OOM issue.
> Test build #72655 has finished for PR 16859 at commit 1c88474.
The only
Github user erenavsarogullari commented on a diff in the pull request:
https://github.com/apache/spark/pull/16813#discussion_r100409787
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/SchedulableBuilder.scala ---
@@ -69,19 +70,31 @@ private[spark] class
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/16639
Ok I'm convinced re: not walking up the cause tree. I didn't think about
that finally case. I'll do another review now.
Re: larger integration test, I didn't have a particular thing
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16862
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72654/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16862
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16862
**[Test build #72654 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72654/testReport)**
for PR 16862 at commit
Github user shivaram commented on the issue:
https://github.com/apache/spark/pull/16689
Ok - I think this sounds good then ! @felixcheung Let me know if you want
me to take a look at the code as well or if not feel free to merge when you
think its ready
---
If your project is set
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/16855#discussion_r100405998
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/TaskSetManagerSuite.scala ---
@@ -664,6 +665,55 @@ class TaskSetManagerSuite extends
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/16813#discussion_r100405459
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/SchedulableBuilder.scala ---
@@ -69,19 +70,31 @@ private[spark] class
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16859
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16859
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72655/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16859
**[Test build #72655 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72655/testReport)**
for PR 16859 at commit
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/16844#discussion_r100404374
--- Diff:
core/src/main/java/org/apache/spark/unsafe/map/BytesToBytesMap.java ---
@@ -695,11 +690,16 @@ public boolean append(Object kbase, long koff, int
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/16872#discussion_r100399822
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameRangeSuite.scala ---
@@ -127,4 +133,28 @@ class DataFrameRangeSuite extends QueryTest with
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/16875
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/16610#discussion_r100398880
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/literals.scala
---
@@ -153,6 +154,12 @@ object Literal {
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/16874
@stanzhai I have merged my PR, and assigned the PR to your name. Could you
close this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user budde commented on the issue:
https://github.com/apache/spark/pull/16797
@mallman The Parquet schema merging methods take me back to #5214 :)
I haven't been following changes here very closely but I would guess use of
this method was replaced to the
Github user hvanhovell closed the pull request at:
https://github.com/apache/spark/pull/16873
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user erenavsarogullari commented on a diff in the pull request:
https://github.com/apache/spark/pull/16813#discussion_r100398573
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/SchedulableBuilder.scala ---
@@ -69,19 +70,31 @@ private[spark] class
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/16873
I am merging this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16873
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72653/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16873
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16674#discussion_r100397916
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveSQLViewSuite.scala
---
@@ -0,0 +1,190 @@
+/*
+ * Licensed to the
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16873
**[Test build #72653 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72653/testReport)**
for PR 16873 at commit
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16610#discussion_r100397761
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/literals.scala
---
@@ -153,6 +154,12 @@ object Literal {
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16610#discussion_r100397651
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/literals.scala
---
@@ -153,6 +154,12 @@ object Literal {
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16610
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72652/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16610
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16610
**[Test build #72652 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72652/testReport)**
for PR 16610 at commit
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/16610#discussion_r100395948
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/literals.scala
---
@@ -153,6 +154,12 @@ object Literal {
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16872#discussion_r100396033
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameRangeSuite.scala ---
@@ -127,4 +133,28 @@ class DataFrameRangeSuite extends QueryTest with
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16610
**[Test build #72659 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72659/testReport)**
for PR 16610 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15505
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72651/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15505
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15505
**[Test build #72651 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72651/testReport)**
for PR 15505 at commit
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/16866
I prefer to just view these APIs as private since they are not in the
public docs. We have some similar APIs in SQL, such as classes in
`org.apache.spark.sql.execution`.
---
If your project is
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16875
**[Test build #72658 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72658/testReport)**
for PR 16875 at commit
GitHub user bogdanrdc opened a pull request:
https://github.com/apache/spark/pull/16875
[BACKPORT-2.1][SPARK-19512][SQL] codegen for compare structs fails #16852
## What changes were proposed in this pull request?
Set currentVars to null in GenerateOrdering.genComparisons
Github user mallman commented on the issue:
https://github.com/apache/spark/pull/16797
BTW @budde, given that this represents a regression in behavior from
previous versions of Spark, I think it is too generous of you to label the Jira
issue as an "improvement" instead of a "bug". I
Github user JoshRosen commented on the issue:
https://github.com/apache/spark/pull/16866
In terms of API compatibility, I believe that the classes in
`network-common` are public simply due to being implemented in Java. However,
for the sake of argument let's say that someone _did_
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/16866
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/16866
> Actually, to clarify: @zsxwing, are you suggesting to check
currentThread().isInterrupted() in RetryingBlockFetcher?
In a second thought, I think your current approach is better, since we
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16872#discussion_r100389578
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameRangeSuite.scala ---
@@ -127,4 +133,28 @@ class DataFrameRangeSuite extends QueryTest
Github user JoshRosen commented on the issue:
https://github.com/apache/spark/pull/16866
Actually, to clarify: @zsxwing, are you suggesting to check
`currentThread().isInterrupted()` in `RetryingBlockFetcher`?
---
If your project is set up for it, you can reply to this email and
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15666
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/16825
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15666
**[Test build #72657 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72657/testReport)**
for PR 15666 at commit
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/16844#discussion_r100387863
--- Diff:
core/src/main/java/org/apache/spark/unsafe/map/BytesToBytesMap.java ---
@@ -695,11 +690,16 @@ public boolean append(Object kbase, long koff, int
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15666
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72657/
Test FAILed.
---
Github user JoshRosen commented on the issue:
https://github.com/apache/spark/pull/16866
@zsxwing, as described in the PR description, if we throw an `IOException`
subclass from this then we need to modify `RetryingBlockFetcher` to have
special-case handling of
Github user mallman commented on the issue:
https://github.com/apache/spark/pull/16797
>> Like you said, users can still create a hive table with
mixed-case-schema parquet/orc files, by hive or other systems like presto. This
table is readable for hive, and for Spark prior to 2.1,
Github user davies commented on the issue:
https://github.com/apache/spark/pull/16825
lgtm, merging this into master and 2.1 branch, thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15666
**[Test build #72657 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72657/testReport)**
for PR 15666 at commit
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/16872#discussion_r100386073
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameRangeSuite.scala ---
@@ -127,4 +133,28 @@ class DataFrameRangeSuite extends QueryTest with
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/16844#discussion_r100385423
--- Diff:
core/src/main/java/org/apache/spark/unsafe/map/BytesToBytesMap.java ---
@@ -695,11 +690,16 @@ public boolean append(Object kbase, long koff, int
Github user Bcpoole commented on a diff in the pull request:
https://github.com/apache/spark/pull/16864#discussion_r100385258
--- Diff:
common/sketch/src/main/java/org/apache/spark/util/sketch/BloomFilter.java ---
@@ -81,6 +81,11 @@ int getVersionNumber() {
public abstract
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/16866
How about throwing InterruptedIOException and also setting the interrupted
state? E.g.,
```java
try {
cf.await();
} catch (InterruptedException e) {
201 - 300 of 562 matches
Mail list logo
