Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19811#discussion_r156925915
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CodeGenerationSuite.scala
---
@@ -401,4 +401,26 @@ class
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14151
**[Test build #84905 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84905/testReport)**
for PR 14151 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19978
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19811#discussion_r156925749
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CodeGenerationSuite.scala
---
@@ -401,4 +401,26 @@ class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19811#discussion_r156925450
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -1205,14 +1203,14 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19811#discussion_r156925357
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -1159,14 +1158,14 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19811#discussion_r156925475
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -1205,14 +1203,14 @@ case class
GitHub user MikhailErofeev opened a pull request:
https://github.com/apache/spark/pull/19978
[SPARK-22784][CORE] Configure reading buffer size in Spark History Server
## What changes were proposed in this pull request?
Added debug logging of spent time and line size for each
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19811#discussion_r156924217
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -484,18 +484,17 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19811#discussion_r156923234
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateMutableProjection.scala
---
@@ -57,41 +57,35 @@ object
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19811#discussion_r156922972
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -189,15 +255,37 @@ class
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19811
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84908/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19811
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19811
**[Test build #84908 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84908/testReport)**
for PR 19811 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19751
**[Test build #84909 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84909/testReport)**
for PR 19751 at commit
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19811#discussion_r156922110
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -163,11 +192,49 @@ class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19811#discussion_r156921749
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -138,21 +138,50 @@ class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19811#discussion_r156921623
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -138,21 +138,50 @@ class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19861#discussion_r156921078
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2ConfigSupport.scala
---
@@ -0,0 +1,57 @@
+/*
+ *
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19977
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19970
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19971#discussion_r156920893
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/TPCDSQuerySuite.scala ---
@@ -348,13 +351,37 @@ class TPCDSQuerySuite extends QueryTest with
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19977
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84904/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19977
**[Test build #84904 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84904/testReport)**
for PR 19977 at commit
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19971#discussion_r156920692
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/TPCDSQuerySuite.scala ---
@@ -348,13 +351,37 @@ class TPCDSQuerySuite extends QueryTest with
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19970
thanks, merging to master!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19811#discussion_r156919894
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -189,15 +255,37 @@ class
Github user mridulm commented on the issue:
https://github.com/apache/spark/pull/19848
@squito Is there a requirement that it should be globally unique ? I am not
sure whether (some?) committers make this assumption : and the few I did take a
look at did not seem to care.
If
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19970
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19970
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84903/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19970
**[Test build #84903 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84903/testReport)**
for PR 19970 at commit
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/19971#discussion_r156914630
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/TPCDSQuerySuite.scala ---
@@ -348,13 +351,37 @@ class TPCDSQuerySuite extends QueryTest with
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19811
**[Test build #84908 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84908/testReport)**
for PR 19811 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19975
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84901/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19975
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19975
**[Test build #84901 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84901/testReport)**
for PR 19975 at commit
Github user attilapiros commented on a diff in the pull request:
https://github.com/apache/spark/pull/19599#discussion_r156913602
--- Diff: mllib/src/main/scala/org/apache/spark/ml/param/params.scala ---
@@ -435,6 +435,43 @@ class BooleanParam(parent: String, name: String, doc:
Github user wobuxiangtong commented on the issue:
https://github.com/apache/spark/pull/16374
Excuse meï¼
I am using mapwithstate to storage data in sparkstreamingãWhat
confused me is that rememberDuration must more than checkpointDurationãI read
the code of
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19971#discussion_r156913421
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/TPCDSQuerySuite.scala ---
@@ -348,13 +351,37 @@ class TPCDSQuerySuite extends QueryTest with
Github user wobuxiangtong commented on the issue:
https://github.com/apache/spark/pull/16850
Excuse meï¼
I am using mapwithstate to storage data in sparkstreamingãWhat
confused me is that rememberDuration must more than checkpointDurationãI read
the code of
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/19971#discussion_r156910288
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/TPCDSQuerySuite.scala ---
@@ -348,13 +351,37 @@ class TPCDSQuerySuite extends QueryTest with
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19893
**[Test build #84907 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84907/testReport)**
for PR 19893 at commit
Github user gaborgsomogyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/19893#discussion_r156902396
--- Diff: core/src/test/scala/org/apache/spark/ThreadAudit.scala ---
@@ -0,0 +1,129 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user gaborgsomogyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/19893#discussion_r156902350
--- Diff: core/src/test/scala/org/apache/spark/ThreadAudit.scala ---
@@ -0,0 +1,129 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19971
**[Test build #84906 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84906/testReport)**
for PR 19971 at commit
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19811#discussion_r156892758
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateUnsafeProjection.scala
---
@@ -318,13 +316,12 @@ object
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/19865#discussion_r156889936
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -217,6 +217,18 @@ class CodegenContext {
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14151
**[Test build #84905 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84905/testReport)**
for PR 14151 at commit
Github user ScrapCodes commented on the issue:
https://github.com/apache/spark/pull/14151
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19861#discussion_r156886333
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2ConfigSupport.scala
---
@@ -0,0 +1,57 @@
+/*
+ *
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19811#discussion_r156885639
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateUnsafeProjection.scala
---
@@ -318,13 +316,12 @@ object
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19861#discussion_r156884555
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/sources/v2/DataSourceV2Suite.scala
---
@@ -43,6 +47,23 @@ class DataSourceV2Suite extends
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19861
we should also do it for write path
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19861#discussion_r156883554
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/sources/v2/DataSourceV2Suite.scala
---
@@ -32,6 +34,8 @@ import
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19861#discussion_r156883149
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/Utils.scala
---
@@ -0,0 +1,54 @@
+/*
+ * Licensed to the Apache
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19977
**[Test build #84904 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84904/testReport)**
for PR 19977 at commit
GitHub user maropu opened a pull request:
https://github.com/apache/spark/pull/19977
[SPARK-22771][SQL] Concatenate binary inputs into a binary output
## What changes were proposed in this pull request?
This pr modified `concat` to concat binary inputs into a single binary
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19861#discussion_r156881519
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala ---
@@ -184,9 +187,16 @@ class DataFrameReader private[sql](sparkSession:
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19861#discussion_r156881214
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/sources/v2/SessionConfigSupport.java
---
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19811#discussion_r156880726
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateUnsafeProjection.scala
---
@@ -318,13 +316,12 @@ object
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19811#discussion_r156880398
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/generators.scala
---
@@ -212,12 +212,13 @@ case class Stack(children:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19970
**[Test build #84903 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84903/testReport)**
for PR 19970 at commit
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19811#discussion_r156879619
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -484,14 +484,13 @@ case class
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19811#discussion_r156879324
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateUnsafeProjection.scala
---
@@ -73,9 +73,8 @@ object
Github user zhengruifeng commented on the issue:
https://github.com/apache/spark/pull/19892
ping @holdenk , can you help reviewing this?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19811#discussion_r156878854
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -163,11 +201,52 @@ class
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19892
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19892
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84900/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19861
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84902/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19892
**[Test build #84900 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84900/testReport)**
for PR 19892 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19861
**[Test build #84902 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84902/testReport)**
for PR 19861 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19861
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19811#discussion_r156878552
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -1159,14 +1156,14 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19811#discussion_r156878390
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/generators.scala
---
@@ -212,12 +212,13 @@ case class Stack(children:
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19811#discussion_r156878147
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -1014,12 +1013,12 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19811#discussion_r156878094
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -484,14 +484,13 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19811#discussion_r156878161
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -1014,12 +1013,12 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19811#discussion_r156878035
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -484,14 +484,13 @@ case class
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19861
**[Test build #84902 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84902/testReport)**
for PR 19861 at commit
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19811#discussion_r156877473
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateUnsafeProjection.scala
---
@@ -318,13 +316,12 @@ object
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19811#discussion_r156877455
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateUnsafeProjection.scala
---
@@ -318,13 +316,12 @@ object
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19811#discussion_r156877035
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateUnsafeProjection.scala
---
@@ -318,13 +316,12 @@ object
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19811#discussion_r156877009
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateUnsafeProjection.scala
---
@@ -318,13 +316,12 @@ object
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19976
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19811#discussion_r156876931
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateUnsafeProjection.scala
---
@@ -73,9 +73,8 @@ object
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19975
**[Test build #84901 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84901/testReport)**
for PR 19975 at commit
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/19861
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
GitHub user kellyzly opened a pull request:
https://github.com/apache/spark/pull/19976
[SPARK-22660][BUILD] Use position() and limit() to fix ambiguity issue in
scala-2.12
## What changes were proposed in this pull request?
Missing some changes about limit in
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19972#discussion_r156876310
--- Diff:
resource-managers/kubernetes/core/src/main/resources/META-INF/services/org.apache.spark.scheduler.ExternalClusterManager
---
@@ -0,0 +1 @@
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19811#discussion_r156876067
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateMutableProjection.scala
---
@@ -60,38 +60,32 @@ object
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19972#discussion_r156875950
--- Diff:
resource-managers/kubernetes/core/src/main/resources/META-INF/services/org.apache.spark.scheduler.ExternalClusterManager
---
@@ -0,0 +1 @@
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19811#discussion_r156875814
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateMutableProjection.scala
---
@@ -60,38 +60,32 @@ object
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19811#discussion_r156875768
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -163,11 +201,52 @@ class CodegenContext {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19811#discussion_r156875671
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateMutableProjection.scala
---
@@ -60,38 +60,32 @@ object
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19892
**[Test build #84900 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84900/testReport)**
for PR 19892 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19861
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19861
**[Test build #84899 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84899/testReport)**
for PR 19861 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19861
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84899/
Test FAILed.
---
Github user zhengruifeng commented on the issue:
https://github.com/apache/spark/pull/19892
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19811#discussion_r156875506
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -154,6 +154,44 @@ class CodegenContext {
601 - 700 of 722 matches
Mail list logo