[GitHub] [spark] ScrapCodes commented on a change in pull request #19096: [SPARK-21869][SS] A cached Kafka producer should not be closed if any task is using it - adds inuse tracking.

2019-03-11 Thread GitBox
ScrapCodes commented on a change in pull request #19096: [SPARK-21869][SS] A cached Kafka producer should not be closed if any task is using it - adds inuse tracking. URL: https://github.com/apache/spark/pull/19096#discussion_r264526266 ## File path:

[GitHub] [spark] LantaoJin commented on a change in pull request #23951: [SPARK-27038][CORE][YARN] Re-implement RackResolver to reduce resolving time

2019-03-11 Thread GitBox
LantaoJin commented on a change in pull request #23951: [SPARK-27038][CORE][YARN] Re-implement RackResolver to reduce resolving time URL: https://github.com/apache/spark/pull/23951#discussion_r264524925 ## File path:

[GitHub] [spark] dongjoon-hyun commented on issue #24062: [SPARK-26594][SQL] DataSourceOptions.asMap should return CaseInsensitiveMap

2019-03-11 Thread GitBox
dongjoon-hyun commented on issue #24062: [SPARK-26594][SQL] DataSourceOptions.asMap should return CaseInsensitiveMap URL: https://github.com/apache/spark/pull/24062#issuecomment-471861208 Ya. Let's proceed #24025 first. This

[GitHub] [spark] ScrapCodes commented on a change in pull request #19096: [SPARK-21869][SS] A cached Kafka producer should not be closed if any task is using it - adds inuse tracking.

2019-03-11 Thread GitBox
ScrapCodes commented on a change in pull request #19096: [SPARK-21869][SS] A cached Kafka producer should not be closed if any task is using it - adds inuse tracking. URL: https://github.com/apache/spark/pull/19096#discussion_r264524768 ## File path:

[GitHub] [spark] LantaoJin commented on a change in pull request #23951: [SPARK-27038][CORE][YARN] Re-implement RackResolver to reduce resolving time

2019-03-11 Thread GitBox
LantaoJin commented on a change in pull request #23951: [SPARK-27038][CORE][YARN] Re-implement RackResolver to reduce resolving time URL: https://github.com/apache/spark/pull/23951#discussion_r264524387 ## File path:

[GitHub] [spark] ScrapCodes commented on a change in pull request #19096: [SPARK-21869][SS] A cached Kafka producer should not be closed if any task is using it - adds inuse tracking.

2019-03-11 Thread GitBox
ScrapCodes commented on a change in pull request #19096: [SPARK-21869][SS] A cached Kafka producer should not be closed if any task is using it - adds inuse tracking. URL: https://github.com/apache/spark/pull/19096#discussion_r264524196 ## File path:

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #24047: [SPARK-25196][SQL] Extends Analyze commands for cached tables

2019-03-11 Thread GitBox
dongjoon-hyun commented on a change in pull request #24047: [SPARK-25196][SQL] Extends Analyze commands for cached tables URL: https://github.com/apache/spark/pull/24047#discussion_r264523890 ## File path:

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #24047: [SPARK-25196][SQL] Extends Analyze commands for cached tables

2019-03-11 Thread GitBox
dongjoon-hyun commented on a change in pull request #24047: [SPARK-25196][SQL] Extends Analyze commands for cached tables URL: https://github.com/apache/spark/pull/24047#discussion_r264524078 ## File path:

[GitHub] [spark] ajithme commented on a change in pull request #23958: [SPARK-27045] SQL tab in UI shows actual SQL instead of callsite

2019-03-11 Thread GitBox
ajithme commented on a change in pull request #23958: [SPARK-27045] SQL tab in UI shows actual SQL instead of callsite URL: https://github.com/apache/spark/pull/23958#discussion_r264523868 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/SQLExecution.scala

[GitHub] [spark] ScrapCodes commented on a change in pull request #19096: [SPARK-21869][SS] A cached Kafka producer should not be closed if any task is using it - adds inuse tracking.

2019-03-11 Thread GitBox
ScrapCodes commented on a change in pull request #19096: [SPARK-21869][SS] A cached Kafka producer should not be closed if any task is using it - adds inuse tracking. URL: https://github.com/apache/spark/pull/19096#discussion_r264523961 ## File path:

[GitHub] [spark] SparkQA removed a comment on issue #24024: [MINOR][CORE]spark.diskStore.subDirectories <= 0 should throw Exception

2019-03-11 Thread GitBox
SparkQA removed a comment on issue #24024: [MINOR][CORE]spark.diskStore.subDirectories <= 0 should throw Exception URL: https://github.com/apache/spark/pull/24024#issuecomment-471802651 **[Test build #4611 has

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #24047: [SPARK-25196][SQL] Extends Analyze commands for cached tables

2019-03-11 Thread GitBox
dongjoon-hyun commented on a change in pull request #24047: [SPARK-25196][SQL] Extends Analyze commands for cached tables URL: https://github.com/apache/spark/pull/24047#discussion_r264523890 ## File path:

[GitHub] [spark] ScrapCodes commented on a change in pull request #19096: [SPARK-21869][SS] A cached Kafka producer should not be closed if any task is using it - adds inuse tracking.

2019-03-11 Thread GitBox
ScrapCodes commented on a change in pull request #19096: [SPARK-21869][SS] A cached Kafka producer should not be closed if any task is using it - adds inuse tracking. URL: https://github.com/apache/spark/pull/19096#discussion_r264523733 ## File path:

[GitHub] [spark] SparkQA commented on issue #24024: [MINOR][CORE]spark.diskStore.subDirectories <= 0 should throw Exception

2019-03-11 Thread GitBox
SparkQA commented on issue #24024: [MINOR][CORE]spark.diskStore.subDirectories <= 0 should throw Exception URL: https://github.com/apache/spark/pull/24024#issuecomment-471859932 **[Test build #4611 has

[GitHub] [spark] ScrapCodes commented on a change in pull request #19096: [SPARK-21869][SS] A cached Kafka producer should not be closed if any task is using it - adds inuse tracking.

2019-03-11 Thread GitBox
ScrapCodes commented on a change in pull request #19096: [SPARK-21869][SS] A cached Kafka producer should not be closed if any task is using it - adds inuse tracking. URL: https://github.com/apache/spark/pull/19096#discussion_r264523479 ## File path:

[GitHub] [spark] ScrapCodes commented on a change in pull request #19096: [SPARK-21869][SS] A cached Kafka producer should not be closed if any task is using it - adds inuse tracking.

2019-03-11 Thread GitBox
ScrapCodes commented on a change in pull request #19096: [SPARK-21869][SS] A cached Kafka producer should not be closed if any task is using it - adds inuse tracking. URL: https://github.com/apache/spark/pull/19096#discussion_r264523558 ## File path:

[GitHub] [spark] ScrapCodes commented on a change in pull request #19096: [SPARK-21869][SS] A cached Kafka producer should not be closed if any task is using it - adds inuse tracking.

2019-03-11 Thread GitBox
ScrapCodes commented on a change in pull request #19096: [SPARK-21869][SS] A cached Kafka producer should not be closed if any task is using it - adds inuse tracking. URL: https://github.com/apache/spark/pull/19096#discussion_r264523364 ## File path:

[GitHub] [spark] Jeffwan commented on issue #24002: [SPARK-26742][K8S] Update Kubernetes-Client version to 4.1.2

2019-03-11 Thread GitBox
Jeffwan commented on issue #24002: [SPARK-26742][K8S] Update Kubernetes-Client version to 4.1.2 URL: https://github.com/apache/spark/pull/24002#issuecomment-471858571 @shaneknapp @vanzin Thanks for explanation. Now I get it.

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #24047: [SPARK-25196][SQL] Extends Analyze commands for cached tables

2019-03-11 Thread GitBox
dongjoon-hyun commented on a change in pull request #24047: [SPARK-25196][SQL] Extends Analyze commands for cached tables URL: https://github.com/apache/spark/pull/24047#discussion_r264522562 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/CacheManager.scala

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #24047: [SPARK-25196][SQL] Extends Analyze commands for cached tables

2019-03-11 Thread GitBox
dongjoon-hyun commented on a change in pull request #24047: [SPARK-25196][SQL] Extends Analyze commands for cached tables URL: https://github.com/apache/spark/pull/24047#discussion_r264522494 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/CacheManager.scala

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #24047: [SPARK-25196][SQL] Extends Analyze commands for cached tables

2019-03-11 Thread GitBox
dongjoon-hyun commented on a change in pull request #24047: [SPARK-25196][SQL] Extends Analyze commands for cached tables URL: https://github.com/apache/spark/pull/24047#discussion_r264522494 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/CacheManager.scala

[GitHub] [spark] dilipbiswal commented on issue #24060: [SPARK-27016][SQL][BUILD][FOLLOW-UP] Treat all antlr warnings as errors while generating the parser.

2019-03-11 Thread GitBox
dilipbiswal commented on issue #24060: [SPARK-27016][SQL][BUILD][FOLLOW-UP] Treat all antlr warnings as errors while generating the parser. URL: https://github.com/apache/spark/pull/24060#issuecomment-471857382 Thanks a LOT @dongjoon-hyun @HyukjinKwon

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #24047: [SPARK-25196][SQL] Extends Analyze commands for cached tables

2019-03-11 Thread GitBox
dongjoon-hyun commented on a change in pull request #24047: [SPARK-25196][SQL] Extends Analyze commands for cached tables URL: https://github.com/apache/spark/pull/24047#discussion_r264521442 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/CacheManager.scala

[GitHub] [spark] ajithme commented on a change in pull request #23958: [SPARK-27045] SQL tab in UI shows actual SQL instead of callsite

2019-03-11 Thread GitBox
ajithme commented on a change in pull request #23958: [SPARK-27045] SQL tab in UI shows actual SQL instead of callsite URL: https://github.com/apache/spark/pull/23958#discussion_r264520823 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/SQLExecution.scala

[GitHub] [spark] SparkQA commented on issue #24025: [SPARK-27106][SQL] merge CaseInsensitiveStringMap and DataSourceOptions

2019-03-11 Thread GitBox
SparkQA commented on issue #24025: [SPARK-27106][SQL] merge CaseInsensitiveStringMap and DataSourceOptions URL: https://github.com/apache/spark/pull/24025#issuecomment-471855851 **[Test build #103359 has

[GitHub] [spark] cloud-fan commented on a change in pull request #23958: [SPARK-27045] SQL tab in UI shows actual SQL instead of callsite

2019-03-11 Thread GitBox
cloud-fan commented on a change in pull request #23958: [SPARK-27045] SQL tab in UI shows actual SQL instead of callsite URL: https://github.com/apache/spark/pull/23958#discussion_r264520191 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/SQLExecution.scala

[GitHub] [spark] AmplabJenkins removed a comment on issue #24025: [SPARK-27106][SQL] merge CaseInsensitiveStringMap and DataSourceOptions

2019-03-11 Thread GitBox
AmplabJenkins removed a comment on issue #24025: [SPARK-27106][SQL] merge CaseInsensitiveStringMap and DataSourceOptions URL: https://github.com/apache/spark/pull/24025#issuecomment-47189 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #24025: [SPARK-27106][SQL] merge CaseInsensitiveStringMap and DataSourceOptions

2019-03-11 Thread GitBox
AmplabJenkins commented on issue #24025: [SPARK-27106][SQL] merge CaseInsensitiveStringMap and DataSourceOptions URL: https://github.com/apache/spark/pull/24025#issuecomment-47187 Merged build finished. Test PASSed. This

[GitHub] [spark] AmplabJenkins removed a comment on issue #24025: [SPARK-27106][SQL] merge CaseInsensitiveStringMap and DataSourceOptions

2019-03-11 Thread GitBox
AmplabJenkins removed a comment on issue #24025: [SPARK-27106][SQL] merge CaseInsensitiveStringMap and DataSourceOptions URL: https://github.com/apache/spark/pull/24025#issuecomment-47187 Merged build finished. Test PASSed.

[GitHub] [spark] cloud-fan commented on a change in pull request #23958: [SPARK-27045] SQL tab in UI shows actual SQL instead of callsite

2019-03-11 Thread GitBox
cloud-fan commented on a change in pull request #23958: [SPARK-27045] SQL tab in UI shows actual SQL instead of callsite URL: https://github.com/apache/spark/pull/23958#discussion_r264520176 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/SQLExecution.scala

[GitHub] [spark] cloud-fan commented on issue #24062: [SPARK-26594][SQL] DataSourceOptions.asMap should return CaseInsensitiveMap

2019-03-11 Thread GitBox
cloud-fan commented on issue #24062: [SPARK-26594][SQL] DataSourceOptions.asMap should return CaseInsensitiveMap URL: https://github.com/apache/spark/pull/24062#issuecomment-471855427 Can we wait for https://github.com/apache/spark/pull/24025 ?

[GitHub] [spark] AmplabJenkins commented on issue #24025: [SPARK-27106][SQL] merge CaseInsensitiveStringMap and DataSourceOptions

2019-03-11 Thread GitBox
AmplabJenkins commented on issue #24025: [SPARK-27106][SQL] merge CaseInsensitiveStringMap and DataSourceOptions URL: https://github.com/apache/spark/pull/24025#issuecomment-47189 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #24047: [SPARK-25196][SQL] Extends Analyze commands for cached tables

2019-03-11 Thread GitBox
dongjoon-hyun commented on a change in pull request #24047: [SPARK-25196][SQL] Extends Analyze commands for cached tables URL: https://github.com/apache/spark/pull/24047#discussion_r264519111 ## File path:

[GitHub] [spark] dongjoon-hyun closed pull request #24060: [SPARK-27016][SQL][BUILD][FOLLOW-UP] Treat all antlr warnings as errors while generating the parser.

2019-03-11 Thread GitBox
dongjoon-hyun closed pull request #24060: [SPARK-27016][SQL][BUILD][FOLLOW-UP] Treat all antlr warnings as errors while generating the parser. URL: https://github.com/apache/spark/pull/24060 This is an automated message

[GitHub] [spark] dongjoon-hyun commented on issue #24060: [SPARK-27016][SQL][BUILD][FOLLOW-UP] Treat all antlr warnings as errors while generating the parser.

2019-03-11 Thread GitBox
dongjoon-hyun commented on issue #24060: [SPARK-27016][SQL][BUILD][FOLLOW-UP] Treat all antlr warnings as errors while generating the parser. URL: https://github.com/apache/spark/pull/24060#issuecomment-471852595 Thank you, @dilipbiswal and @HyukjinKwon . Merged to master.

[GitHub] [spark] ajithme commented on a change in pull request #23958: [SPARK-27045] SQL tab in UI shows actual SQL instead of callsite

2019-03-11 Thread GitBox
ajithme commented on a change in pull request #23958: [SPARK-27045] SQL tab in UI shows actual SQL instead of callsite URL: https://github.com/apache/spark/pull/23958#discussion_r264516510 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/SQLExecution.scala

[GitHub] [spark] AmplabJenkins removed a comment on issue #24049: [SPARK-27123][SQL] Improve CollapseProject to handle projects cross limit/repartition/sample

2019-03-11 Thread GitBox
AmplabJenkins removed a comment on issue #24049: [SPARK-27123][SQL] Improve CollapseProject to handle projects cross limit/repartition/sample URL: https://github.com/apache/spark/pull/24049#issuecomment-471850544 Test PASSed. Refer to this link for build results (access rights to CI

[GitHub] [spark] AmplabJenkins removed a comment on issue #24049: [SPARK-27123][SQL] Improve CollapseProject to handle projects cross limit/repartition/sample

2019-03-11 Thread GitBox
AmplabJenkins removed a comment on issue #24049: [SPARK-27123][SQL] Improve CollapseProject to handle projects cross limit/repartition/sample URL: https://github.com/apache/spark/pull/24049#issuecomment-471850540 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #24049: [SPARK-27123][SQL] Improve CollapseProject to handle projects cross limit/repartition/sample

2019-03-11 Thread GitBox
AmplabJenkins commented on issue #24049: [SPARK-27123][SQL] Improve CollapseProject to handle projects cross limit/repartition/sample URL: https://github.com/apache/spark/pull/24049#issuecomment-471850540 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #24049: [SPARK-27123][SQL] Improve CollapseProject to handle projects cross limit/repartition/sample

2019-03-11 Thread GitBox
AmplabJenkins commented on issue #24049: [SPARK-27123][SQL] Improve CollapseProject to handle projects cross limit/repartition/sample URL: https://github.com/apache/spark/pull/24049#issuecomment-471850544 Test PASSed. Refer to this link for build results (access rights to CI server

[GitHub] [spark] HyukjinKwon closed pull request #24063: Branch 2.4

2019-03-11 Thread GitBox
HyukjinKwon closed pull request #24063: Branch 2.4 URL: https://github.com/apache/spark/pull/24063 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [spark] SparkQA removed a comment on issue #24049: [SPARK-27123][SQL] Improve CollapseProject to handle projects cross limit/repartition/sample

2019-03-11 Thread GitBox
SparkQA removed a comment on issue #24049: [SPARK-27123][SQL] Improve CollapseProject to handle projects cross limit/repartition/sample URL: https://github.com/apache/spark/pull/24049#issuecomment-471790594 **[Test build #103354 has

[GitHub] [spark] SparkQA commented on issue #24049: [SPARK-27123][SQL] Improve CollapseProject to handle projects cross limit/repartition/sample

2019-03-11 Thread GitBox
SparkQA commented on issue #24049: [SPARK-27123][SQL] Improve CollapseProject to handle projects cross limit/repartition/sample URL: https://github.com/apache/spark/pull/24049#issuecomment-471850197 **[Test build #103354 has

[GitHub] [spark] cloud-fan commented on a change in pull request #23958: [SPARK-27045] SQL tab in UI shows actual SQL instead of callsite

2019-03-11 Thread GitBox
cloud-fan commented on a change in pull request #23958: [SPARK-27045] SQL tab in UI shows actual SQL instead of callsite URL: https://github.com/apache/spark/pull/23958#discussion_r264515528 ## File path:

[GitHub] [spark] cloud-fan commented on a change in pull request #23958: [SPARK-27045] SQL tab in UI shows actual SQL instead of callsite

2019-03-11 Thread GitBox
cloud-fan commented on a change in pull request #23958: [SPARK-27045] SQL tab in UI shows actual SQL instead of callsite URL: https://github.com/apache/spark/pull/23958#discussion_r264515459 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/SQLExecution.scala

[GitHub] [spark] HyukjinKwon commented on a change in pull request #24062: [SPARK-26594][SQL] DataSourceOptions.asMap should return CaseInsensitiveMap

2019-03-11 Thread GitBox
HyukjinKwon commented on a change in pull request #24062: [SPARK-26594][SQL] DataSourceOptions.asMap should return CaseInsensitiveMap URL: https://github.com/apache/spark/pull/24062#discussion_r264515398 ## File path:

[GitHub] [spark] cloud-fan commented on a change in pull request #23958: [SPARK-27045] SQL tab in UI shows actual SQL instead of callsite

2019-03-11 Thread GitBox
cloud-fan commented on a change in pull request #23958: [SPARK-27045] SQL tab in UI shows actual SQL instead of callsite URL: https://github.com/apache/spark/pull/23958#discussion_r264515459 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/SQLExecution.scala

[GitHub] [spark] cloud-fan commented on issue #24014: [SPARK-27092][SQL] Apply refactored pattern in ScalaReflection and JavaTypeInference to RowEncoder

2019-03-11 Thread GitBox
cloud-fan commented on issue #24014: [SPARK-27092][SQL] Apply refactored pattern in ScalaReflection and JavaTypeInference to RowEncoder URL: https://github.com/apache/spark/pull/24014#issuecomment-471849340 > I can remove added methods and just let RowEncoder reuse available methods

[GitHub] [spark] cloud-fan commented on a change in pull request #23848: [SPARK-26946][SQL] Identifiers for multi-catalog

2019-03-11 Thread GitBox
cloud-fan commented on a change in pull request #23848: [SPARK-26946][SQL] Identifiers for multi-catalog URL: https://github.com/apache/spark/pull/23848#discussion_r264514720 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/identifiers.scala ## @@

[GitHub] [spark] AmplabJenkins removed a comment on issue #24062: [SPARK-26594][SQL] DataSourceOptions.asMap should return CaseInsensitiveMap

2019-03-11 Thread GitBox
AmplabJenkins removed a comment on issue #24062: [SPARK-26594][SQL] DataSourceOptions.asMap should return CaseInsensitiveMap URL: https://github.com/apache/spark/pull/24062#issuecomment-471848758 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #24062: [SPARK-26594][SQL] DataSourceOptions.asMap should return CaseInsensitiveMap

2019-03-11 Thread GitBox
AmplabJenkins commented on issue #24062: [SPARK-26594][SQL] DataSourceOptions.asMap should return CaseInsensitiveMap URL: https://github.com/apache/spark/pull/24062#issuecomment-471848750 Merged build finished. Test PASSed.

[GitHub] [spark] cloud-fan commented on a change in pull request #23848: [SPARK-26946][SQL] Identifiers for multi-catalog

2019-03-11 Thread GitBox
cloud-fan commented on a change in pull request #23848: [SPARK-26946][SQL] Identifiers for multi-catalog URL: https://github.com/apache/spark/pull/23848#discussion_r264514564 ## File path: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ## @@

[GitHub] [spark] AmplabJenkins removed a comment on issue #24062: [SPARK-26594][SQL] DataSourceOptions.asMap should return CaseInsensitiveMap

2019-03-11 Thread GitBox
AmplabJenkins removed a comment on issue #24062: [SPARK-26594][SQL] DataSourceOptions.asMap should return CaseInsensitiveMap URL: https://github.com/apache/spark/pull/24062#issuecomment-471848750 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #24062: [SPARK-26594][SQL] DataSourceOptions.asMap should return CaseInsensitiveMap

2019-03-11 Thread GitBox
AmplabJenkins commented on issue #24062: [SPARK-26594][SQL] DataSourceOptions.asMap should return CaseInsensitiveMap URL: https://github.com/apache/spark/pull/24062#issuecomment-471848758 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] ajithme commented on a change in pull request #23958: [SPARK-27045] SQL tab in UI shows actual SQL instead of callsite

2019-03-11 Thread GitBox
ajithme commented on a change in pull request #23958: [SPARK-27045] SQL tab in UI shows actual SQL instead of callsite URL: https://github.com/apache/spark/pull/23958#discussion_r264513707 ## File path:

[GitHub] [spark] ajithme commented on a change in pull request #23958: [SPARK-27045] SQL tab in UI shows actual SQL instead of callsite

2019-03-11 Thread GitBox
ajithme commented on a change in pull request #23958: [SPARK-27045] SQL tab in UI shows actual SQL instead of callsite URL: https://github.com/apache/spark/pull/23958#discussion_r264513581 ## File path:

[GitHub] [spark] SparkQA commented on issue #24062: [SPARK-26594][SQL] DataSourceOptions.asMap should return CaseInsensitiveMap

2019-03-11 Thread GitBox
SparkQA commented on issue #24062: [SPARK-26594][SQL] DataSourceOptions.asMap should return CaseInsensitiveMap URL: https://github.com/apache/spark/pull/24062#issuecomment-471847644 **[Test build #103358 has

[GitHub] [spark] cloud-fan commented on a change in pull request #24029: SPARK-27108: Add parsed SQL plans for create, CTAS.

2019-03-11 Thread GitBox
cloud-fan commented on a change in pull request #24029: SPARK-27108: Add parsed SQL plans for create, CTAS. URL: https://github.com/apache/spark/pull/24029#discussion_r264513412 ## File path:

[GitHub] [spark] ajithme commented on issue #24056: [SPARK-26152] Synchronize Worker Cleanup with Worker Shutdown

2019-03-11 Thread GitBox
ajithme commented on issue #24056: [SPARK-26152] Synchronize Worker Cleanup with Worker Shutdown URL: https://github.com/apache/spark/pull/24056#issuecomment-471846545 @srowen I see your point. 1. I agree with your suggestion of combining them into one single future. 2. We can

[GitHub] [spark] cloud-fan commented on a change in pull request #24029: SPARK-27108: Add parsed SQL plans for create, CTAS.

2019-03-11 Thread GitBox
cloud-fan commented on a change in pull request #24029: SPARK-27108: Add parsed SQL plans for create, CTAS. URL: https://github.com/apache/spark/pull/24029#discussion_r264512238 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala

[GitHub] [spark] cloud-fan commented on a change in pull request #24029: SPARK-27108: Add parsed SQL plans for create, CTAS.

2019-03-11 Thread GitBox
cloud-fan commented on a change in pull request #24029: SPARK-27108: Add parsed SQL plans for create, CTAS. URL: https://github.com/apache/spark/pull/24029#discussion_r264512106 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ##

[GitHub] [spark] LantaoJin commented on a change in pull request #23951: [SPARK-27038][CORE][YARN] Re-implement RackResolver to reduce resolving time

2019-03-11 Thread GitBox
LantaoJin commented on a change in pull request #23951: [SPARK-27038][CORE][YARN] Re-implement RackResolver to reduce resolving time URL: https://github.com/apache/spark/pull/23951#discussion_r264509561 ## File path:

[GitHub] [spark] cloud-fan commented on a change in pull request #23958: [SPARK-27045] SQL tab in UI shows actual SQL instead of callsite

2019-03-11 Thread GitBox
cloud-fan commented on a change in pull request #23958: [SPARK-27045] SQL tab in UI shows actual SQL instead of callsite URL: https://github.com/apache/spark/pull/23958#discussion_r264511574 ## File path:

[GitHub] [spark] ajithme commented on a change in pull request #23958: [SPARK-27045] SQL tab in UI shows actual SQL instead of callsite

2019-03-11 Thread GitBox
ajithme commented on a change in pull request #23958: [SPARK-27045] SQL tab in UI shows actual SQL instead of callsite URL: https://github.com/apache/spark/pull/23958#discussion_r264510596 ## File path:

[GitHub] [spark] AmplabJenkins removed a comment on issue #24063: Branch 2.4

2019-03-11 Thread GitBox
AmplabJenkins removed a comment on issue #24063: Branch 2.4 URL: https://github.com/apache/spark/pull/24063#issuecomment-471841563 Can one of the admins verify this patch? This is an automated message from the Apache Git

[GitHub] [spark] LantaoJin commented on a change in pull request #23951: [SPARK-27038][CORE][YARN] Re-implement RackResolver to reduce resolving time

2019-03-11 Thread GitBox
LantaoJin commented on a change in pull request #23951: [SPARK-27038][CORE][YARN] Re-implement RackResolver to reduce resolving time URL: https://github.com/apache/spark/pull/23951#discussion_r264509561 ## File path:

[GitHub] [spark] AmplabJenkins commented on issue #24063: Branch 2.4

2019-03-11 Thread GitBox
AmplabJenkins commented on issue #24063: Branch 2.4 URL: https://github.com/apache/spark/pull/24063#issuecomment-471842077 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins removed a comment on issue #24063: Branch 2.4

2019-03-11 Thread GitBox
AmplabJenkins removed a comment on issue #24063: Branch 2.4 URL: https://github.com/apache/spark/pull/24063#issuecomment-471841445 Can one of the admins verify this patch? This is an automated message from the Apache Git

[GitHub] [spark] AmplabJenkins commented on issue #24063: Branch 2.4

2019-03-11 Thread GitBox
AmplabJenkins commented on issue #24063: Branch 2.4 URL: https://github.com/apache/spark/pull/24063#issuecomment-471841563 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on issue #24063: Branch 2.4

2019-03-11 Thread GitBox
AmplabJenkins commented on issue #24063: Branch 2.4 URL: https://github.com/apache/spark/pull/24063#issuecomment-471841445 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To

[GitHub] [spark] JinyLeeChina opened a new pull request #24063: Branch 2.4

2019-03-11 Thread GitBox
JinyLeeChina opened a new pull request #24063: Branch 2.4 URL: https://github.com/apache/spark/pull/24063 ## What changes were proposed in this pull request? (Please fill in changes proposed in this fix) ## How was this patch tested? (Please explain how this patch was

[GitHub] [spark] LantaoJin commented on a change in pull request #23951: [SPARK-27038][CORE][YARN] Re-implement RackResolver to reduce resolving time

2019-03-11 Thread GitBox
LantaoJin commented on a change in pull request #23951: [SPARK-27038][CORE][YARN] Re-implement RackResolver to reduce resolving time URL: https://github.com/apache/spark/pull/23951#discussion_r264509561 ## File path:

[GitHub] [spark] LantaoJin commented on a change in pull request #23951: [SPARK-27038][CORE][YARN] Re-implement RackResolver to reduce resolving time

2019-03-11 Thread GitBox
LantaoJin commented on a change in pull request #23951: [SPARK-27038][CORE][YARN] Re-implement RackResolver to reduce resolving time URL: https://github.com/apache/spark/pull/23951#discussion_r264509561 ## File path:

[GitHub] [spark] zjf2012 edited a comment on issue #23560: [SPARK-26632][Core] Separate Thread Configurations of Driver and Executor

2019-03-11 Thread GitBox
zjf2012 edited a comment on issue #23560: [SPARK-26632][Core] Separate Thread Configurations of Driver and Executor URL: https://github.com/apache/spark/pull/23560#issuecomment-471834412 @attilapiros , We tuned a lot to get optimized result with 8 threads on old code. For your case, I

[GitHub] [spark] cloud-fan closed pull request #23918: [SPARK-27011][SQL] reset command fails with cache

2019-03-11 Thread GitBox
cloud-fan closed pull request #23918: [SPARK-27011][SQL] reset command fails with cache URL: https://github.com/apache/spark/pull/23918 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] cloud-fan commented on issue #23918: [SPARK-27011][SQL] reset command fails with cache

2019-03-11 Thread GitBox
cloud-fan commented on issue #23918: [SPARK-27011][SQL] reset command fails with cache URL: https://github.com/apache/spark/pull/23918#issuecomment-471834452 thanks, merging to master! This is an automated message from the

[GitHub] [spark] zjf2012 commented on issue #23560: [SPARK-26632][Core] Separate Thread Configurations of Driver and Executor

2019-03-11 Thread GitBox
zjf2012 commented on issue #23560: [SPARK-26632][Core] Separate Thread Configurations of Driver and Executor URL: https://github.com/apache/spark/pull/23560#issuecomment-471834412 @attilapiros , We tuned a lot to get optimized result with 8 threads on old code. For your case, I just ran

[GitHub] [spark] cloud-fan commented on a change in pull request #24028: [SPARK-26917][SQL] Further reduce locks in CacheManager

2019-03-11 Thread GitBox
cloud-fan commented on a change in pull request #24028: [SPARK-26917][SQL] Further reduce locks in CacheManager URL: https://github.com/apache/spark/pull/24028#discussion_r264503558 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/CacheManager.scala ##

[GitHub] [spark] VaibhavDesai commented on issue #24059: [SPARK-27129][Minor]Add JSON event serialization methods in JSONUtils for blacklist events

2019-03-11 Thread GitBox
VaibhavDesai commented on issue #24059: [SPARK-27129][Minor]Add JSON event serialization methods in JSONUtils for blacklist events URL: https://github.com/apache/spark/pull/24059#issuecomment-471831385 **[Test build Jenkins build has

[GitHub] [spark] VaibhavDesai commented on issue #24059: [SPARK-27129][Minor]Add JSON event serialization methods in JSONUtils for blacklist events

2019-03-11 Thread GitBox
VaibhavDesai commented on issue #24059: [SPARK-27129][Minor]Add JSON event serialization methods in JSONUtils for blacklist events URL: https://github.com/apache/spark/pull/24059#issuecomment-471830862 **[Test build Jenkins build has

[GitHub] [spark] VaibhavDesai commented on issue #24059: [SPARK-27129][Minor]Add JSON event serialization methods in JSONUtils for blacklist events

2019-03-11 Thread GitBox
VaibhavDesai commented on issue #24059: [SPARK-27129][Minor]Add JSON event serialization methods in JSONUtils for blacklist events URL: https://github.com/apache/spark/pull/24059#issuecomment-471830557 **[Test build Jenkins build has

[GitHub] [spark] hddong commented on issue #24048: [MINOR][Core] Use variable instead of function to keep the format uniform

2019-03-11 Thread GitBox
hddong commented on issue #24048: [MINOR][Core] Use variable instead of function to keep the format uniform URL: https://github.com/apache/spark/pull/24048#issuecomment-471830167 > Merged to master. In the future please format the PR title/description per

[GitHub] [spark] cloud-fan commented on a change in pull request #23958: [SPARK-27045] SQL tab in UI shows actual SQL instead of callsite

2019-03-11 Thread GitBox
cloud-fan commented on a change in pull request #23958: [SPARK-27045] SQL tab in UI shows actual SQL instead of callsite URL: https://github.com/apache/spark/pull/23958#discussion_r264502752 ## File path:

[GitHub] [spark] hddong commented on issue #24048: [MINOR][Core] Use variable instead of function to keep the format uniform

2019-03-11 Thread GitBox
hddong commented on issue #24048: [MINOR][Core] Use variable instead of function to keep the format uniform URL: https://github.com/apache/spark/pull/24048#issuecomment-471829959 > As I see this is really a minor thing where separate Jira is not needed still the PR title must follow the

[GitHub] [spark] AmplabJenkins removed a comment on issue #24060: [SPARK-27016][SQL][BUILD][FOLLOW-UP] Treat all antlr warnings as errors while generating the parser.

2019-03-11 Thread GitBox
AmplabJenkins removed a comment on issue #24060: [SPARK-27016][SQL][BUILD][FOLLOW-UP] Treat all antlr warnings as errors while generating the parser. URL: https://github.com/apache/spark/pull/24060#issuecomment-471827744 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #24060: [SPARK-27016][SQL][BUILD][FOLLOW-UP] Treat all antlr warnings as errors while generating the parser.

2019-03-11 Thread GitBox
AmplabJenkins commented on issue #24060: [SPARK-27016][SQL][BUILD][FOLLOW-UP] Treat all antlr warnings as errors while generating the parser. URL: https://github.com/apache/spark/pull/24060#issuecomment-471827748 Test PASSed. Refer to this link for build results (access rights to CI

[GitHub] [spark] AmplabJenkins removed a comment on issue #24060: [SPARK-27016][SQL][BUILD][FOLLOW-UP] Treat all antlr warnings as errors while generating the parser.

2019-03-11 Thread GitBox
AmplabJenkins removed a comment on issue #24060: [SPARK-27016][SQL][BUILD][FOLLOW-UP] Treat all antlr warnings as errors while generating the parser. URL: https://github.com/apache/spark/pull/24060#issuecomment-471827748 Test PASSed. Refer to this link for build results (access rights

[GitHub] [spark] AmplabJenkins commented on issue #24060: [SPARK-27016][SQL][BUILD][FOLLOW-UP] Treat all antlr warnings as errors while generating the parser.

2019-03-11 Thread GitBox
AmplabJenkins commented on issue #24060: [SPARK-27016][SQL][BUILD][FOLLOW-UP] Treat all antlr warnings as errors while generating the parser. URL: https://github.com/apache/spark/pull/24060#issuecomment-471827744 Merged build finished. Test PASSed.

[GitHub] [spark] SparkQA removed a comment on issue #24060: [SPARK-27016][SQL][BUILD][FOLLOW-UP] Treat all antlr warnings as errors while generating the parser.

2019-03-11 Thread GitBox
SparkQA removed a comment on issue #24060: [SPARK-27016][SQL][BUILD][FOLLOW-UP] Treat all antlr warnings as errors while generating the parser. URL: https://github.com/apache/spark/pull/24060#issuecomment-471755507 **[Test build #103351 has

[GitHub] [spark] SparkQA commented on issue #24060: [SPARK-27016][SQL][BUILD][FOLLOW-UP] Treat all antlr warnings as errors while generating the parser.

2019-03-11 Thread GitBox
SparkQA commented on issue #24060: [SPARK-27016][SQL][BUILD][FOLLOW-UP] Treat all antlr warnings as errors while generating the parser. URL: https://github.com/apache/spark/pull/24060#issuecomment-471827229 **[Test build #103351 has

[GitHub] [spark] xuanyuanking commented on a change in pull request #24062: [SPARK-26594][SQL] DataSourceOptions.asMap should return CaseInsensitiveMap

2019-03-11 Thread GitBox
xuanyuanking commented on a change in pull request #24062: [SPARK-26594][SQL] DataSourceOptions.asMap should return CaseInsensitiveMap URL: https://github.com/apache/spark/pull/24062#discussion_r264499964 ## File path:

[GitHub] [spark] AmplabJenkins removed a comment on issue #23954: [SPARK-27041][PySpark] Use imap() for python 2.x to resolve oom issue

2019-03-11 Thread GitBox
AmplabJenkins removed a comment on issue #23954: [SPARK-27041][PySpark] Use imap() for python 2.x to resolve oom issue URL: https://github.com/apache/spark/pull/23954#issuecomment-471824475 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #23954: [SPARK-27041][PySpark] Use imap() for python 2.x to resolve oom issue

2019-03-11 Thread GitBox
AmplabJenkins removed a comment on issue #23954: [SPARK-27041][PySpark] Use imap() for python 2.x to resolve oom issue URL: https://github.com/apache/spark/pull/23954#issuecomment-471824496 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #23954: [SPARK-27041][PySpark] Use imap() for python 2.x to resolve oom issue

2019-03-11 Thread GitBox
AmplabJenkins commented on issue #23954: [SPARK-27041][PySpark] Use imap() for python 2.x to resolve oom issue URL: https://github.com/apache/spark/pull/23954#issuecomment-471824475 Merged build finished. Test PASSed. This

[GitHub] [spark] AmplabJenkins commented on issue #23954: [SPARK-27041][PySpark] Use imap() for python 2.x to resolve oom issue

2019-03-11 Thread GitBox
AmplabJenkins commented on issue #23954: [SPARK-27041][PySpark] Use imap() for python 2.x to resolve oom issue URL: https://github.com/apache/spark/pull/23954#issuecomment-471824496 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA commented on issue #23954: [SPARK-27041][PySpark] Use imap() for python 2.x to resolve oom issue

2019-03-11 Thread GitBox
SparkQA commented on issue #23954: [SPARK-27041][PySpark] Use imap() for python 2.x to resolve oom issue URL: https://github.com/apache/spark/pull/23954#issuecomment-471824156 **[Test build #103356 has

[GitHub] [spark] SparkQA removed a comment on issue #23954: [SPARK-27041][PySpark] Use imap() for python 2.x to resolve oom issue

2019-03-11 Thread GitBox
SparkQA removed a comment on issue #23954: [SPARK-27041][PySpark] Use imap() for python 2.x to resolve oom issue URL: https://github.com/apache/spark/pull/23954#issuecomment-471815212 **[Test build #103356 has

[GitHub] [spark] zuotingbing edited a comment on issue #23917: [SPARK-27010][SQL] Find out the actual port number when hive.server2.thrift.port=0

2019-03-11 Thread GitBox
zuotingbing edited a comment on issue #23917: [SPARK-27010][SQL] Find out the actual port number when hive.server2.thrift.port=0 URL: https://github.com/apache/spark/pull/23917#issuecomment-468569583 I checked this in Hive, seems not fixed. In hive log : 2019-03-01

[GitHub] [spark] AmplabJenkins removed a comment on issue #24016: [MINOR][SQL] Deduplicate huge if statements in get between specialized getters

2019-03-11 Thread GitBox
AmplabJenkins removed a comment on issue #24016: [MINOR][SQL] Deduplicate huge if statements in get between specialized getters URL: https://github.com/apache/spark/pull/24016#issuecomment-471821568 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #24016: [MINOR][SQL] Deduplicate huge if statements in get between specialized getters

2019-03-11 Thread GitBox
AmplabJenkins commented on issue #24016: [MINOR][SQL] Deduplicate huge if statements in get between specialized getters URL: https://github.com/apache/spark/pull/24016#issuecomment-471821568 Merged build finished. Test PASSed.

  1   2   3   4   5   6   7   8   9   10   >