[GitHub] [spark] HeartSaVioR commented on issue #27064: [SPARK-30246]OneForOneStreamManager might leak memory in connectionTerminated

2020-01-09 Thread GitBox
HeartSaVioR commented on issue #27064: [SPARK-30246]OneForOneStreamManager might leak memory in connectionTerminated URL: https://github.com/apache/spark/pull/27064#issuecomment-572804389 Oh wait I'm seeing failure "after" installing "resource", but the test fails elsewhere which is odd.

[GitHub] [spark] shaneknapp closed pull request #27156: [MINOR][SQL][test-hive1.2] Fix scalastyle error due to length line in hive-1.2 profile

2020-01-09 Thread GitBox
shaneknapp closed pull request #27156: [MINOR][SQL][test-hive1.2] Fix scalastyle error due to length line in hive-1.2 profile URL: https://github.com/apache/spark/pull/27156 This is an automated message from the Apache Git

[GitHub] [spark] gengliangwang commented on a change in pull request #27157: [SPARK-30428][SQL][FOLLOWUP] File source V2: Push data filters for file listing

2020-01-09 Thread GitBox
gengliangwang commented on a change in pull request #27157: [SPARK-30428][SQL][FOLLOWUP] File source V2: Push data filters for file listing URL: https://github.com/apache/spark/pull/27157#discussion_r365010090 ## File path:

[GitHub] [spark] dongjoon-hyun commented on issue #27156: [MINOR][SQL][test-hive1.2] Fix scalastyle error due to length line in hive-1.2 profile

2020-01-09 Thread GitBox
dongjoon-hyun commented on issue #27156: [MINOR][SQL][test-hive1.2] Fix scalastyle error due to length line in hive-1.2 profile URL: https://github.com/apache/spark/pull/27156#issuecomment-572804081 It's passed with `hive-1.2`. You can merge this~ ```scala

[GitHub] [spark] shaneknapp commented on issue #27156: [MINOR][SQL][test-hive1.2] Fix scalastyle error due to length line in hive-1.2 profile

2020-01-09 Thread GitBox
shaneknapp commented on issue #27156: [MINOR][SQL][test-hive1.2] Fix scalastyle error due to length line in hive-1.2 profile URL: https://github.com/apache/spark/pull/27156#issuecomment-572804011 okie dokie, gonna merge this now... ```

[GitHub] [spark] dongjoon-hyun commented on issue #27156: [MINOR][SQL][test-hive1.2] Fix scalastyle error due to length line in hive-1.2 profile

2020-01-09 Thread GitBox
dongjoon-hyun commented on issue #27156: [MINOR][SQL][test-hive1.2] Fix scalastyle error due to length line in hive-1.2 profile URL: https://github.com/apache/spark/pull/27156#issuecomment-572804143 Thank you so much! This

[GitHub] [spark] AmplabJenkins removed a comment on issue #27157: [SPARK-30428][SQL][FOLLOWUP] File source V2: Push data filters for file listing

2020-01-09 Thread GitBox
AmplabJenkins removed a comment on issue #27157: [SPARK-30428][SQL][FOLLOWUP] File source V2: Push data filters for file listing URL: https://github.com/apache/spark/pull/27157#issuecomment-572803621 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #27157: [SPARK-30428][SQL][FOLLOWUP] File source V2: Push data filters for file listing

2020-01-09 Thread GitBox
AmplabJenkins removed a comment on issue #27157: [SPARK-30428][SQL][FOLLOWUP] File source V2: Push data filters for file listing URL: https://github.com/apache/spark/pull/27157#issuecomment-572803615 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #27156: [MINOR][SQL][test-hive1.2] Fix scalastyle error due to length line in hive-1.2 profile

2020-01-09 Thread GitBox
AmplabJenkins removed a comment on issue #27156: [MINOR][SQL][test-hive1.2] Fix scalastyle error due to length line in hive-1.2 profile URL: https://github.com/apache/spark/pull/27156#issuecomment-572803629 Test PASSed. Refer to this link for build results (access rights to CI server

[GitHub] [spark] AmplabJenkins removed a comment on issue #27156: [MINOR][SQL][test-hive1.2] Fix scalastyle error due to length line in hive-1.2 profile

2020-01-09 Thread GitBox
AmplabJenkins removed a comment on issue #27156: [MINOR][SQL][test-hive1.2] Fix scalastyle error due to length line in hive-1.2 profile URL: https://github.com/apache/spark/pull/27156#issuecomment-572803622 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #27157: [SPARK-30428][SQL][FOLLOWUP] File source V2: Push data filters for file listing

2020-01-09 Thread GitBox
AmplabJenkins commented on issue #27157: [SPARK-30428][SQL][FOLLOWUP] File source V2: Push data filters for file listing URL: https://github.com/apache/spark/pull/27157#issuecomment-572803621 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #27157: [SPARK-30428][SQL][FOLLOWUP] File source V2: Push data filters for file listing

2020-01-09 Thread GitBox
AmplabJenkins commented on issue #27157: [SPARK-30428][SQL][FOLLOWUP] File source V2: Push data filters for file listing URL: https://github.com/apache/spark/pull/27157#issuecomment-572803615 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #27156: [MINOR][SQL][test-hive1.2] Fix scalastyle error due to length line in hive-1.2 profile

2020-01-09 Thread GitBox
AmplabJenkins commented on issue #27156: [MINOR][SQL][test-hive1.2] Fix scalastyle error due to length line in hive-1.2 profile URL: https://github.com/apache/spark/pull/27156#issuecomment-572803622 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #27156: [MINOR][SQL][test-hive1.2] Fix scalastyle error due to length line in hive-1.2 profile

2020-01-09 Thread GitBox
AmplabJenkins commented on issue #27156: [MINOR][SQL][test-hive1.2] Fix scalastyle error due to length line in hive-1.2 profile URL: https://github.com/apache/spark/pull/27156#issuecomment-572803629 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #26956: [SPARK-30312][SQL] Preserve path permission and acl when truncate table

2020-01-09 Thread GitBox
AmplabJenkins removed a comment on issue #26956: [SPARK-30312][SQL] Preserve path permission and acl when truncate table URL: https://github.com/apache/spark/pull/26956#issuecomment-572803232 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #26956: [SPARK-30312][SQL] Preserve path permission and acl when truncate table

2020-01-09 Thread GitBox
AmplabJenkins removed a comment on issue #26956: [SPARK-30312][SQL] Preserve path permission and acl when truncate table URL: https://github.com/apache/spark/pull/26956#issuecomment-572803234 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA commented on issue #27157: [SPARK-30428][SQL][FOLLOWUP] File source V2: Push data filters for file listing

2020-01-09 Thread GitBox
SparkQA commented on issue #27157: [SPARK-30428][SQL][FOLLOWUP] File source V2: Push data filters for file listing URL: https://github.com/apache/spark/pull/27157#issuecomment-572803204 **[Test build #116427 has

[GitHub] [spark] SparkQA commented on issue #27156: [MINOR][SQL][test-hive1.2] Fix scalastyle error due to length line in hive-1.2 profile

2020-01-09 Thread GitBox
SparkQA commented on issue #27156: [MINOR][SQL][test-hive1.2] Fix scalastyle error due to length line in hive-1.2 profile URL: https://github.com/apache/spark/pull/27156#issuecomment-572803238 **[Test build #116428 has

[GitHub] [spark] HeartSaVioR edited a comment on issue #27064: [SPARK-30246]OneForOneStreamManager might leak memory in connectionTerminated

2020-01-09 Thread GitBox
HeartSaVioR edited a comment on issue #27064: [SPARK-30246]OneForOneStreamManager might leak memory in connectionTerminated URL: https://github.com/apache/spark/pull/27064#issuecomment-572802645 Yeah same for me as well, but I don't have pypy. Installing now. EDIT: and no luck. It

[GitHub] [spark] AmplabJenkins commented on issue #26956: [SPARK-30312][SQL] Preserve path permission and acl when truncate table

2020-01-09 Thread GitBox
AmplabJenkins commented on issue #26956: [SPARK-30312][SQL] Preserve path permission and acl when truncate table URL: https://github.com/apache/spark/pull/26956#issuecomment-572803234 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #26956: [SPARK-30312][SQL] Preserve path permission and acl when truncate table

2020-01-09 Thread GitBox
AmplabJenkins commented on issue #26956: [SPARK-30312][SQL] Preserve path permission and acl when truncate table URL: https://github.com/apache/spark/pull/26956#issuecomment-572803232 Merged build finished. Test PASSed. This

[GitHub] [spark] SparkQA removed a comment on issue #26956: [SPARK-30312][SQL] Preserve path permission and acl when truncate table

2020-01-09 Thread GitBox
SparkQA removed a comment on issue #26956: [SPARK-30312][SQL] Preserve path permission and acl when truncate table URL: https://github.com/apache/spark/pull/26956#issuecomment-572709728 **[Test build #116413 has

[GitHub] [spark] SparkQA commented on issue #26956: [SPARK-30312][SQL] Preserve path permission and acl when truncate table

2020-01-09 Thread GitBox
SparkQA commented on issue #26956: [SPARK-30312][SQL] Preserve path permission and acl when truncate table URL: https://github.com/apache/spark/pull/26956#issuecomment-572802582 **[Test build #116413 has

[GitHub] [spark] HeartSaVioR commented on issue #27064: [SPARK-30246]OneForOneStreamManager might leak memory in connectionTerminated

2020-01-09 Thread GitBox
HeartSaVioR commented on issue #27064: [SPARK-30246]OneForOneStreamManager might leak memory in connectionTerminated URL: https://github.com/apache/spark/pull/27064#issuecomment-572802645 Yeah same for me as well, but I don't have pypy. Installing now.

[GitHub] [spark] shaneknapp edited a comment on issue #27156: [MINOR][SQL][test-hive1.2] Fix scalastyle error due to length line in hive-1.2 profile

2020-01-09 Thread GitBox
shaneknapp edited a comment on issue #27156: [MINOR][SQL][test-hive1.2] Fix scalastyle error due to length line in hive-1.2 profile URL: https://github.com/apache/spark/pull/27156#issuecomment-572801887 it just passed! ```

[GitHub] [spark] shaneknapp commented on issue #27156: [MINOR][SQL][test-hive1.2] Fix scalastyle error due to length line in hive-1.2 profile

2020-01-09 Thread GitBox
shaneknapp commented on issue #27156: [MINOR][SQL][test-hive1.2] Fix scalastyle error due to length line in hive-1.2 profile URL: https://github.com/apache/spark/pull/27156#issuecomment-572801887 it just passed!

[GitHub] [spark] AmplabJenkins removed a comment on issue #27157: [SPARK-30428][SQL][FOLLOWUP] File source V2: Push data filters for file listing

2020-01-09 Thread GitBox
AmplabJenkins removed a comment on issue #27157: [SPARK-30428][SQL][FOLLOWUP] File source V2: Push data filters for file listing URL: https://github.com/apache/spark/pull/27157#issuecomment-572798754 Can one of the admins verify this patch?

[GitHub] [spark] gengliangwang commented on issue #27157: [SPARK-30428][SQL][FOLLOWUP] File source V2: Push data filters for file listing

2020-01-09 Thread GitBox
gengliangwang commented on issue #27157: [SPARK-30428][SQL][FOLLOWUP] File source V2: Push data filters for file listing URL: https://github.com/apache/spark/pull/27157#issuecomment-572802093 Jenkins, test this please. This

[GitHub] [spark] viirya commented on issue #27064: [SPARK-30246]OneForOneStreamManager might leak memory in connectionTerminated

2020-01-09 Thread GitBox
viirya commented on issue #27064: [SPARK-30246]OneForOneStreamManager might leak memory in connectionTerminated URL: https://github.com/apache/spark/pull/27064#issuecomment-572801763 @HeartSaVioR hmm, I just ran the test locally and it passed.

[GitHub] [spark] dongjoon-hyun commented on issue #27156: [MINOR][SQL][test-hive1.2] Fix scalastyle error due to length line in hive-1.2 profile

2020-01-09 Thread GitBox
dongjoon-hyun commented on issue #27156: [MINOR][SQL][test-hive1.2] Fix scalastyle error due to length line in hive-1.2 profile URL: https://github.com/apache/spark/pull/27156#issuecomment-572801823 Sure~ We only need scalastyle check in this PR. I retriggered Jenkins with

[GitHub] [spark] dongjoon-hyun commented on issue #27156: [MINOR][SQL][test-hive1.2] Fix scalastyle error due to length line in hive-1.2 profile

2020-01-09 Thread GitBox
dongjoon-hyun commented on issue #27156: [MINOR][SQL][test-hive1.2] Fix scalastyle error due to length line in hive-1.2 profile URL: https://github.com/apache/spark/pull/27156#issuecomment-572801608 Retest this please. This

[GitHub] [spark] AmplabJenkins removed a comment on issue #27156: [MINOR][SQL] Fix scalastyle error due to length line in hive-1.2 profile

2020-01-09 Thread GitBox
AmplabJenkins removed a comment on issue #27156: [MINOR][SQL] Fix scalastyle error due to length line in hive-1.2 profile URL: https://github.com/apache/spark/pull/27156#issuecomment-572801260 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #27156: [MINOR][SQL] Fix scalastyle error due to length line in hive-1.2 profile

2020-01-09 Thread GitBox
AmplabJenkins removed a comment on issue #27156: [MINOR][SQL] Fix scalastyle error due to length line in hive-1.2 profile URL: https://github.com/apache/spark/pull/27156#issuecomment-572801253 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #27156: [MINOR][SQL] Fix scalastyle error due to length line in hive-1.2 profile

2020-01-09 Thread GitBox
AmplabJenkins commented on issue #27156: [MINOR][SQL] Fix scalastyle error due to length line in hive-1.2 profile URL: https://github.com/apache/spark/pull/27156#issuecomment-572801260 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #27156: [MINOR][SQL] Fix scalastyle error due to length line in hive-1.2 profile

2020-01-09 Thread GitBox
AmplabJenkins commented on issue #27156: [MINOR][SQL] Fix scalastyle error due to length line in hive-1.2 profile URL: https://github.com/apache/spark/pull/27156#issuecomment-572801253 Merged build finished. Test PASSed.

[GitHub] [spark] shaneknapp commented on issue #27156: [MINOR][SQL] Fix scalastyle error due to length line in hive-1.2 profile

2020-01-09 Thread GitBox
shaneknapp commented on issue #27156: [MINOR][SQL] Fix scalastyle error due to length line in hive-1.2 profile URL: https://github.com/apache/spark/pull/27156#issuecomment-572800725 i'll wait until the 2nd build passes scala style and then merge. no need to run the complete test suite

[GitHub] [spark] SparkQA commented on issue #27156: [MINOR][SQL] Fix scalastyle error due to length line in hive-1.2 profile

2020-01-09 Thread GitBox
SparkQA commented on issue #27156: [MINOR][SQL] Fix scalastyle error due to length line in hive-1.2 profile URL: https://github.com/apache/spark/pull/27156#issuecomment-572800859 **[Test build #116426 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #26805: [SPARK-15616][SQL] Add optimizer rule PruneHiveTablePartitions

2020-01-09 Thread GitBox
AmplabJenkins removed a comment on issue #26805: [SPARK-15616][SQL] Add optimizer rule PruneHiveTablePartitions URL: https://github.com/apache/spark/pull/26805#issuecomment-572798924 Merged build finished. Test PASSed. This

[GitHub] [spark] AmplabJenkins removed a comment on issue #26805: [SPARK-15616][SQL] Add optimizer rule PruneHiveTablePartitions

2020-01-09 Thread GitBox
AmplabJenkins removed a comment on issue #26805: [SPARK-15616][SQL] Add optimizer rule PruneHiveTablePartitions URL: https://github.com/apache/spark/pull/26805#issuecomment-572798931 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #27157: [SPARK-30428][SQL][FOLLOWUP] File source V2: Push data filters for file listing

2020-01-09 Thread GitBox
AmplabJenkins removed a comment on issue #27157: [SPARK-30428][SQL][FOLLOWUP] File source V2: Push data filters for file listing URL: https://github.com/apache/spark/pull/27157#issuecomment-572798333 Can one of the admins verify this patch?

[GitHub] [spark] AmplabJenkins commented on issue #26805: [SPARK-15616][SQL] Add optimizer rule PruneHiveTablePartitions

2020-01-09 Thread GitBox
AmplabJenkins commented on issue #26805: [SPARK-15616][SQL] Add optimizer rule PruneHiveTablePartitions URL: https://github.com/apache/spark/pull/26805#issuecomment-572798931 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #26805: [SPARK-15616][SQL] Add optimizer rule PruneHiveTablePartitions

2020-01-09 Thread GitBox
AmplabJenkins commented on issue #26805: [SPARK-15616][SQL] Add optimizer rule PruneHiveTablePartitions URL: https://github.com/apache/spark/pull/26805#issuecomment-572798924 Merged build finished. Test PASSed. This is an

[GitHub] [spark] guykhazma commented on a change in pull request #27112: [SPARK-30428][SQL] File source V2: support partition pruning

2020-01-09 Thread GitBox
guykhazma commented on a change in pull request #27112: [SPARK-30428][SQL] File source V2: support partition pruning URL: https://github.com/apache/spark/pull/27112#discussion_r365004736 ## File path:

[GitHub] [spark] AmplabJenkins commented on issue #27157: [SPARK-30428][SQL][FOLLOWUP] File source V2: Push data filters for file listing

2020-01-09 Thread GitBox
AmplabJenkins commented on issue #27157: [SPARK-30428][SQL][FOLLOWUP] File source V2: Push data filters for file listing URL: https://github.com/apache/spark/pull/27157#issuecomment-572798754 Can one of the admins verify this patch?

[GitHub] [spark] shaneknapp commented on a change in pull request #27156: [MINOR][SQL] Fix scalastyle error due to length line in hive-1.2 profile

2020-01-09 Thread GitBox
shaneknapp commented on a change in pull request #27156: [MINOR][SQL] Fix scalastyle error due to length line in hive-1.2 profile URL: https://github.com/apache/spark/pull/27156#discussion_r365004362 ## File path:

[GitHub] [spark] SparkQA commented on issue #26805: [SPARK-15616][SQL] Add optimizer rule PruneHiveTablePartitions

2020-01-09 Thread GitBox
SparkQA commented on issue #26805: [SPARK-15616][SQL] Add optimizer rule PruneHiveTablePartitions URL: https://github.com/apache/spark/pull/26805#issuecomment-572798436 **[Test build #116424 has

[GitHub] [spark] SparkQA commented on issue #26440: [SPARK-20628][CORE][K8S] Start to improve Spark decommissioning & preemption support

2020-01-09 Thread GitBox
SparkQA commented on issue #26440: [SPARK-20628][CORE][K8S] Start to improve Spark decommissioning & preemption support URL: https://github.com/apache/spark/pull/26440#issuecomment-572798467 **[Test build #116425 has

[GitHub] [spark] AmplabJenkins commented on issue #27157: [SPARK-30428][SQL][FOLLOWUP] File source V2: Push data filters for file listing

2020-01-09 Thread GitBox
AmplabJenkins commented on issue #27157: [SPARK-30428][SQL][FOLLOWUP] File source V2: Push data filters for file listing URL: https://github.com/apache/spark/pull/27157#issuecomment-572798333 Can one of the admins verify this patch?

[GitHub] [spark] guykhazma opened a new pull request #27157: [SPARK-30428][SQL][FOLLOWUP] File source V2: Push data filters for file listing

2020-01-09 Thread GitBox
guykhazma opened a new pull request #27157: [SPARK-30428][SQL][FOLLOWUP] File source V2: Push data filters for file listing URL: https://github.com/apache/spark/pull/27157 ### What changes were proposed in this pull request? Follow up on

[GitHub] [spark] fuwhu commented on issue #26805: [SPARK-15616][SQL] Add optimizer rule PruneHiveTablePartitions

2020-01-09 Thread GitBox
fuwhu commented on issue #26805: [SPARK-15616][SQL] Add optimizer rule PruneHiveTablePartitions URL: https://github.com/apache/spark/pull/26805#issuecomment-572797992 retest this please This is an automated message from the

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #27156: [MINOR][SQL] Fix scalastyle error due to length line in hive-1.2 profile

2020-01-09 Thread GitBox
dongjoon-hyun commented on a change in pull request #27156: [MINOR][SQL] Fix scalastyle error due to length line in hive-1.2 profile URL: https://github.com/apache/spark/pull/27156#discussion_r365003172 ## File path:

[GitHub] [spark] dongjoon-hyun commented on issue #27156: [MINOR][SQL] Fix scalastyle error due to length line in hive-1.2 profile

2020-01-09 Thread GitBox
dongjoon-hyun commented on issue #27156: [MINOR][SQL] Fix scalastyle error due to length line in hive-1.2 profile URL: https://github.com/apache/spark/pull/27156#issuecomment-572797026 The code path `sql/core/v1.2/...` is compiled at `-Phive1.2` only. It's weird. We do the build test on

[GitHub] [spark] AmplabJenkins removed a comment on issue #26955: [SPARK-30310] [Core] Resolve missing match case in SparkUncaughtExceptionHandler and added tests

2020-01-09 Thread GitBox
AmplabJenkins removed a comment on issue #26955: [SPARK-30310] [Core] Resolve missing match case in SparkUncaughtExceptionHandler and added tests URL: https://github.com/apache/spark/pull/26955#issuecomment-572796563 Test PASSed. Refer to this link for build results (access rights to CI

[GitHub] [spark] AmplabJenkins removed a comment on issue #26955: [SPARK-30310] [Core] Resolve missing match case in SparkUncaughtExceptionHandler and added tests

2020-01-09 Thread GitBox
AmplabJenkins removed a comment on issue #26955: [SPARK-30310] [Core] Resolve missing match case in SparkUncaughtExceptionHandler and added tests URL: https://github.com/apache/spark/pull/26955#issuecomment-572796551 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #26955: [SPARK-30310] [Core] Resolve missing match case in SparkUncaughtExceptionHandler and added tests

2020-01-09 Thread GitBox
AmplabJenkins commented on issue #26955: [SPARK-30310] [Core] Resolve missing match case in SparkUncaughtExceptionHandler and added tests URL: https://github.com/apache/spark/pull/26955#issuecomment-572796563 Test PASSed. Refer to this link for build results (access rights to CI server

[GitHub] [spark] AmplabJenkins commented on issue #26955: [SPARK-30310] [Core] Resolve missing match case in SparkUncaughtExceptionHandler and added tests

2020-01-09 Thread GitBox
AmplabJenkins commented on issue #26955: [SPARK-30310] [Core] Resolve missing match case in SparkUncaughtExceptionHandler and added tests URL: https://github.com/apache/spark/pull/26955#issuecomment-572796551 Merged build finished. Test PASSed.

[GitHub] [spark] SparkQA commented on issue #26440: [SPARK-20628][CORE][K8S] Start to improve Spark decommissioning & preemption support

2020-01-09 Thread GitBox
SparkQA commented on issue #26440: [SPARK-20628][CORE][K8S] Start to improve Spark decommissioning & preemption support URL: https://github.com/apache/spark/pull/26440#issuecomment-572796136 **[Test build #116423 has

[GitHub] [spark] SparkQA commented on issue #26955: [SPARK-30310] [Core] Resolve missing match case in SparkUncaughtExceptionHandler and added tests

2020-01-09 Thread GitBox
SparkQA commented on issue #26955: [SPARK-30310] [Core] Resolve missing match case in SparkUncaughtExceptionHandler and added tests URL: https://github.com/apache/spark/pull/26955#issuecomment-572796117 **[Test build #116422 has

[GitHub] [spark] holdenk commented on a change in pull request #26440: [SPARK-20628][CORE][K8S] Start to improve Spark decommissioning & preemption support

2020-01-09 Thread GitBox
holdenk commented on a change in pull request #26440: [SPARK-20628][CORE][K8S] Start to improve Spark decommissioning & preemption support URL: https://github.com/apache/spark/pull/26440#discussion_r365001624 ## File path:

[GitHub] [spark] srowen commented on issue #26955: [SPARK-30310] [Core] Resolve missing match case in SparkUncaughtExceptionHandler and added tests

2020-01-09 Thread GitBox
srowen commented on issue #26955: [SPARK-30310] [Core] Resolve missing match case in SparkUncaughtExceptionHandler and added tests URL: https://github.com/apache/spark/pull/26955#issuecomment-572795652 Jenkins, test this please

[GitHub] [spark] maropu commented on a change in pull request #27119: [SPARK-30447][SQL] Constant propagation nullability issue

2020-01-09 Thread GitBox
maropu commented on a change in pull request #27119: [SPARK-30447][SQL] Constant propagation nullability issue URL: https://github.com/apache/spark/pull/27119#discussion_r365000866 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala

[GitHub] [spark] shaneknapp commented on issue #27156: [MINOR][SQL] Fix scalastyle error due to length line in hive-1.2 profile

2020-01-09 Thread GitBox
shaneknapp commented on issue #27156: [MINOR][SQL] Fix scalastyle error due to length line in hive-1.2 profile URL: https://github.com/apache/spark/pull/27156#issuecomment-572795393 also, dare i ask why this wasn't caught in the hive-2.3 profile build? no, i shouldn't ask. let's

[GitHub] [spark] shaneknapp commented on issue #27156: [MINOR][SQL] Fix scalastyle error due to length line in hive-1.2 profile

2020-01-09 Thread GitBox
shaneknapp commented on issue #27156: [MINOR][SQL] Fix scalastyle error due to length line in hive-1.2 profile URL: https://github.com/apache/spark/pull/27156#issuecomment-572795080 lol thanks @dongjoon-hyun :) This is an

[GitHub] [spark] HeartSaVioR commented on issue #27064: [SPARK-30246]OneForOneStreamManager might leak memory in connectionTerminated

2020-01-09 Thread GitBox
HeartSaVioR commented on issue #27064: [SPARK-30246]OneForOneStreamManager might leak memory in connectionTerminated URL: https://github.com/apache/spark/pull/27064#issuecomment-572795083 @viirya The test fails from other PRs as well - please refer

[GitHub] [spark] HeartSaVioR commented on issue #26955: [SPARK-30310] [Core] Resolve missing match case in SparkUncaughtExceptionHandler and added tests

2020-01-09 Thread GitBox
HeartSaVioR commented on issue #26955: [SPARK-30310] [Core] Resolve missing match case in SparkUncaughtExceptionHandler and added tests URL: https://github.com/apache/spark/pull/26955#issuecomment-572794484 @srowen Would you mind if I ask about revisiting this? Maybe with "ok to test".

[GitHub] [spark] SparkQA commented on issue #27130: [SPARK-25993][SQL][TESTS] Add test cases for CREATE EXTERNAL TABLE with subdirectories

2020-01-09 Thread GitBox
SparkQA commented on issue #27130: [SPARK-25993][SQL][TESTS] Add test cases for CREATE EXTERNAL TABLE with subdirectories URL: https://github.com/apache/spark/pull/27130#issuecomment-572793707 **[Test build #116421 has

[GitHub] [spark] gatorsmile edited a comment on issue #26843: [SPARK-30209][SQL][WEB-UI] Display stageId, attemptId and taskId for max metrics in Spark UI.

2020-01-09 Thread GitBox
gatorsmile edited a comment on issue #26843: [SPARK-30209][SQL][WEB-UI] Display stageId, attemptId and taskId for max metrics in Spark UI. URL: https://github.com/apache/spark/pull/26843#issuecomment-572792448 @tgravescs This is really hard to read, to be honest. For most SQL users, they

[GitHub] [spark] gatorsmile commented on issue #26843: [SPARK-30209][SQL][WEB-UI] Display stageId, attemptId and taskId for max metrics in Spark UI.

2020-01-09 Thread GitBox
gatorsmile commented on issue #26843: [SPARK-30209][SQL][WEB-UI] Display stageId, attemptId and taskId for max metrics in Spark UI. URL: https://github.com/apache/spark/pull/26843#issuecomment-572792448 @tgravescs This is really hard to read, to be honest.

[GitHub] [spark] holdenk commented on a change in pull request #26440: [WIP][SPARK-20628][CORE][K8S] Start to improve Spark decommissioning & preemption support

2020-01-09 Thread GitBox
holdenk commented on a change in pull request #26440: [WIP][SPARK-20628][CORE][K8S] Start to improve Spark decommissioning & preemption support URL: https://github.com/apache/spark/pull/26440#discussion_r364997379 ## File path:

[GitHub] [spark] gengliangwang commented on issue #26843: [SPARK-30209][SQL][WEB-UI] Display stageId, attemptId and taskId for max metrics in Spark UI.

2020-01-09 Thread GitBox
gengliangwang commented on issue #26843: [SPARK-30209][SQL][WEB-UI] Display stageId, attemptId and taskId for max metrics in Spark UI. URL: https://github.com/apache/spark/pull/26843#issuecomment-572791878 @nartal1 @tgravescs Sorry but I think this PR makes it hard to read the metrics.

[GitHub] [spark] vanzin commented on issue #27085: [SPARK-29779][CORE] Compact old event log files and cleanup

2020-01-09 Thread GitBox
vanzin commented on issue #27085: [SPARK-29779][CORE] Compact old event log files and cleanup URL: https://github.com/apache/spark/pull/27085#issuecomment-572792067 I don't think I have more comments; will leave this here a little bit to see if anyone shows up. Only thing that

[GitHub] [spark] AmplabJenkins removed a comment on issue #27130: [SPARK-25993][SQL][TESTS] Add test cases for CREATE EXTERNAL TABLE with subdirectories

2020-01-09 Thread GitBox
AmplabJenkins removed a comment on issue #27130: [SPARK-25993][SQL][TESTS] Add test cases for CREATE EXTERNAL TABLE with subdirectories URL: https://github.com/apache/spark/pull/27130#issuecomment-572791738 Test PASSed. Refer to this link for build results (access rights to CI server

[GitHub] [spark] AmplabJenkins removed a comment on issue #27130: [SPARK-25993][SQL][TESTS] Add test cases for CREATE EXTERNAL TABLE with subdirectories

2020-01-09 Thread GitBox
AmplabJenkins removed a comment on issue #27130: [SPARK-25993][SQL][TESTS] Add test cases for CREATE EXTERNAL TABLE with subdirectories URL: https://github.com/apache/spark/pull/27130#issuecomment-572791730 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #27030: [SPARK-30244][SQL] Emit pre/post events for "Partition" methods in ExternalCatalogWithListener

2020-01-09 Thread GitBox
AmplabJenkins removed a comment on issue #27030: [SPARK-30244][SQL] Emit pre/post events for "Partition" methods in ExternalCatalogWithListener URL: https://github.com/apache/spark/pull/27030#issuecomment-572791530 Test PASSed. Refer to this link for build results (access rights to CI

[GitHub] [spark] AmplabJenkins commented on issue #27130: [SPARK-25993][SQL][TESTS] Add test cases for CREATE EXTERNAL TABLE with subdirectories

2020-01-09 Thread GitBox
AmplabJenkins commented on issue #27130: [SPARK-25993][SQL][TESTS] Add test cases for CREATE EXTERNAL TABLE with subdirectories URL: https://github.com/apache/spark/pull/27130#issuecomment-572791738 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #27030: [SPARK-30244][SQL] Emit pre/post events for "Partition" methods in ExternalCatalogWithListener

2020-01-09 Thread GitBox
AmplabJenkins removed a comment on issue #27030: [SPARK-30244][SQL] Emit pre/post events for "Partition" methods in ExternalCatalogWithListener URL: https://github.com/apache/spark/pull/27030#issuecomment-572791525 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #27030: [SPARK-30244][SQL] Emit pre/post events for "Partition" methods in ExternalCatalogWithListener

2020-01-09 Thread GitBox
AmplabJenkins commented on issue #27030: [SPARK-30244][SQL] Emit pre/post events for "Partition" methods in ExternalCatalogWithListener URL: https://github.com/apache/spark/pull/27030#issuecomment-572791530 Test PASSed. Refer to this link for build results (access rights to CI server

[GitHub] [spark] AmplabJenkins commented on issue #27130: [SPARK-25993][SQL][TESTS] Add test cases for CREATE EXTERNAL TABLE with subdirectories

2020-01-09 Thread GitBox
AmplabJenkins commented on issue #27130: [SPARK-25993][SQL][TESTS] Add test cases for CREATE EXTERNAL TABLE with subdirectories URL: https://github.com/apache/spark/pull/27130#issuecomment-572791730 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #27030: [SPARK-30244][SQL] Emit pre/post events for "Partition" methods in ExternalCatalogWithListener

2020-01-09 Thread GitBox
AmplabJenkins commented on issue #27030: [SPARK-30244][SQL] Emit pre/post events for "Partition" methods in ExternalCatalogWithListener URL: https://github.com/apache/spark/pull/27030#issuecomment-572791525 Merged build finished. Test PASSed.

[GitHub] [spark] SparkQA removed a comment on issue #27030: [SPARK-30244][SQL] Emit pre/post events for "Partition" methods in ExternalCatalogWithListener

2020-01-09 Thread GitBox
SparkQA removed a comment on issue #27030: [SPARK-30244][SQL] Emit pre/post events for "Partition" methods in ExternalCatalogWithListener URL: https://github.com/apache/spark/pull/27030#issuecomment-572691990 **[Test build #116410 has

[GitHub] [spark] SparkQA commented on issue #27030: [SPARK-30244][SQL] Emit pre/post events for "Partition" methods in ExternalCatalogWithListener

2020-01-09 Thread GitBox
SparkQA commented on issue #27030: [SPARK-30244][SQL] Emit pre/post events for "Partition" methods in ExternalCatalogWithListener URL: https://github.com/apache/spark/pull/27030#issuecomment-572790938 **[Test build #116410 has

[GitHub] [spark] holdenk commented on a change in pull request #26440: [WIP][SPARK-20628][CORE][K8S] Start to improve Spark decommissioning & preemption support

2020-01-09 Thread GitBox
holdenk commented on a change in pull request #26440: [WIP][SPARK-20628][CORE][K8S] Start to improve Spark decommissioning & preemption support URL: https://github.com/apache/spark/pull/26440#discussion_r364996340 ## File path:

[GitHub] [spark] holdenk commented on a change in pull request #26440: [WIP][SPARK-20628][CORE][K8S] Start to improve Spark decommissioning & preemption support

2020-01-09 Thread GitBox
holdenk commented on a change in pull request #26440: [WIP][SPARK-20628][CORE][K8S] Start to improve Spark decommissioning & preemption support URL: https://github.com/apache/spark/pull/26440#discussion_r364996340 ## File path:

[GitHub] [spark] holdenk commented on a change in pull request #26440: [WIP][SPARK-20628][CORE][K8S] Start to improve Spark decommissioning & preemption support

2020-01-09 Thread GitBox
holdenk commented on a change in pull request #26440: [WIP][SPARK-20628][CORE][K8S] Start to improve Spark decommissioning & preemption support URL: https://github.com/apache/spark/pull/26440#discussion_r364995493 ## File path:

[GitHub] [spark] viirya commented on issue #26956: [SPARK-30312][SQL] Preserve path permission and acl when truncate table

2020-01-09 Thread GitBox
viirya commented on issue #26956: [SPARK-30312][SQL] Preserve path permission and acl when truncate table URL: https://github.com/apache/spark/pull/26956#issuecomment-572789610 @dongjoon-hyun Ok. Then I think adding a fallback configuration here too can make back-porting easier?

[GitHub] [spark] vanzin commented on a change in pull request #26440: [WIP][SPARK-20628][CORE][K8S] Start to improve Spark decommissioning & preemption support

2020-01-09 Thread GitBox
vanzin commented on a change in pull request #26440: [WIP][SPARK-20628][CORE][K8S] Start to improve Spark decommissioning & preemption support URL: https://github.com/apache/spark/pull/26440#discussion_r364994867 ## File path:

[GitHub] [spark] AmplabJenkins removed a comment on issue #27156: [SQL] fix 101 length line

2020-01-09 Thread GitBox
AmplabJenkins removed a comment on issue #27156: [SQL] fix 101 length line URL: https://github.com/apache/spark/pull/27156#issuecomment-572789161 Merged build finished. Test PASSed. This is an automated message from the

[GitHub] [spark] vanzin commented on a change in pull request #26440: [WIP][SPARK-20628][CORE][K8S] Start to improve Spark decommissioning & preemption support

2020-01-09 Thread GitBox
vanzin commented on a change in pull request #26440: [WIP][SPARK-20628][CORE][K8S] Start to improve Spark decommissioning & preemption support URL: https://github.com/apache/spark/pull/26440#discussion_r364994738 ## File path:

[GitHub] [spark] kevinyu98 commented on a change in pull request #27130: [SPARK-25993][SQL][TESTS] Add test cases for CREATE EXTERNAL TABLE with subdirectories

2020-01-09 Thread GitBox
kevinyu98 commented on a change in pull request #27130: [SPARK-25993][SQL][TESTS] Add test cases for CREATE EXTERNAL TABLE with subdirectories URL: https://github.com/apache/spark/pull/27130#discussion_r364994517 ## File path:

[GitHub] [spark] AmplabJenkins removed a comment on issue #27156: [SQL] fix 101 length line

2020-01-09 Thread GitBox
AmplabJenkins removed a comment on issue #27156: [SQL] fix 101 length line URL: https://github.com/apache/spark/pull/27156#issuecomment-572789165 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] kevinyu98 commented on a change in pull request #27130: [SPARK-25993][SQL][TESTS] Add test cases for CREATE EXTERNAL TABLE with subdirectories

2020-01-09 Thread GitBox
kevinyu98 commented on a change in pull request #27130: [SPARK-25993][SQL][TESTS] Add test cases for CREATE EXTERNAL TABLE with subdirectories URL: https://github.com/apache/spark/pull/27130#discussion_r364994378 ## File path:

[GitHub] [spark] AmplabJenkins commented on issue #27156: [SQL] fix 101 length line

2020-01-09 Thread GitBox
AmplabJenkins commented on issue #27156: [SQL] fix 101 length line URL: https://github.com/apache/spark/pull/27156#issuecomment-572789165 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] kevinyu98 commented on a change in pull request #27130: [SPARK-25993][SQL][TESTS] Add test cases for CREATE EXTERNAL TABLE with subdirectories

2020-01-09 Thread GitBox
kevinyu98 commented on a change in pull request #27130: [SPARK-25993][SQL][TESTS] Add test cases for CREATE EXTERNAL TABLE with subdirectories URL: https://github.com/apache/spark/pull/27130#discussion_r364994450 ## File path:

[GitHub] [spark] AmplabJenkins commented on issue #27156: [SQL] fix 101 length line

2020-01-09 Thread GitBox
AmplabJenkins commented on issue #27156: [SQL] fix 101 length line URL: https://github.com/apache/spark/pull/27156#issuecomment-572789161 Merged build finished. Test PASSed. This is an automated message from the Apache Git

[GitHub] [spark] SparkQA commented on issue #27156: [SQL] fix 101 length line

2020-01-09 Thread GitBox
SparkQA commented on issue #27156: [SQL] fix 101 length line URL: https://github.com/apache/spark/pull/27156#issuecomment-572788698 **[Test build #116420 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/116420/testReport)** for PR 27156 at commit

[GitHub] [spark] kevinyu98 commented on a change in pull request #27130: [SPARK-25993][SQL][TESTS] Add test cases for CREATE EXTERNAL TABLE with subdirectories

2020-01-09 Thread GitBox
kevinyu98 commented on a change in pull request #27130: [SPARK-25993][SQL][TESTS] Add test cases for CREATE EXTERNAL TABLE with subdirectories URL: https://github.com/apache/spark/pull/27130#discussion_r364993517 ## File path:

[GitHub] [spark] shaneknapp opened a new pull request #27156: [SQL] fix 101 length line

2020-01-09 Thread GitBox
shaneknapp opened a new pull request #27156: [SQL] fix 101 length line URL: https://github.com/apache/spark/pull/27156 ### What changes were proposed in this pull request? fixing a broken build:

[GitHub] [spark] holdenk commented on a change in pull request #26440: [WIP][SPARK-20628][CORE][K8S] Start to improve Spark decommissioning & preemption support

2020-01-09 Thread GitBox
holdenk commented on a change in pull request #26440: [WIP][SPARK-20628][CORE][K8S] Start to improve Spark decommissioning & preemption support URL: https://github.com/apache/spark/pull/26440#discussion_r364991200 ## File path:

[GitHub] [spark] holdenk commented on a change in pull request #26440: [WIP][SPARK-20628][CORE][K8S] Start to improve Spark decommissioning & preemption support

2020-01-09 Thread GitBox
holdenk commented on a change in pull request #26440: [WIP][SPARK-20628][CORE][K8S] Start to improve Spark decommissioning & preemption support URL: https://github.com/apache/spark/pull/26440#discussion_r364990209 ## File path:

[GitHub] [spark] holdenk commented on a change in pull request #26440: [WIP][SPARK-20628][CORE][K8S] Start to improve Spark decommissioning & preemption support

2020-01-09 Thread GitBox
holdenk commented on a change in pull request #26440: [WIP][SPARK-20628][CORE][K8S] Start to improve Spark decommissioning & preemption support URL: https://github.com/apache/spark/pull/26440#discussion_r364989417 ## File path:

<    2   3   4   5   6   7   8   9   10   11   >