[GitHub] [spark] AmplabJenkins commented on pull request #28360: [SPARK-31569][SQL][DOCS] Add links to subsections in SQL Reference main page

2020-04-26 Thread GitBox
AmplabJenkins commented on pull request #28360: URL: https://github.com/apache/spark/pull/28360#issuecomment-619742496 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28360: [SPARK-31569][SQL][DOCS] Add links to subsections in SQL Reference main page

2020-04-26 Thread GitBox
AmplabJenkins removed a comment on pull request #28360: URL: https://github.com/apache/spark/pull/28360#issuecomment-619742496 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #28360: [SPARK-31569][SQL][DOCS] Add links to subsections in SQL Reference main page

2020-04-26 Thread GitBox
SparkQA commented on pull request #28360: URL: https://github.com/apache/spark/pull/28360#issuecomment-619741862 **[Test build #121876 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121876/testReport)** for PR 28360 at commit

[GitHub] [spark] huaxingao opened a new pull request #28360: [SPARK-31569][SQL][DOCS] Add links to subsections in SQL Reference main page

2020-04-26 Thread GitBox
huaxingao opened a new pull request #28360: URL: https://github.com/apache/spark/pull/28360 ### What changes were proposed in this pull request? Add links to subsections in SQL Reference main page ### Why are the changes needed? Make SQL Reference complete

[GitHub] [spark] yaooqinn commented on pull request #28055: [SPARK-31289][TEST][test-hive1.2] Eliminate org.apache.spark.sql.hive.thriftserver.CliSuite flakiness

2020-04-26 Thread GitBox
yaooqinn commented on pull request #28055: URL: https://github.com/apache/spark/pull/28055#issuecomment-619740866 I will run some tests blindly to see whether it introduce a significant delay, since I am not sure how to mock an ungrateful shutdown at the end of each test.

[GitHub] [spark] MichaelChirico edited a comment on pull request #28350: [SPARK-31568][R][DOCS] Add detail about func/key in gapply to documentation

2020-04-26 Thread GitBox
MichaelChirico edited a comment on pull request #28350: URL: https://github.com/apache/spark/pull/28350#issuecomment-619740538 really opened a can of worms here huh. To me, it makes sense to leave the PR as is, then do the `dapply`/`dapplyCollect` centralization in another PR.

[GitHub] [spark] MichaelChirico commented on pull request #28350: [SPARK-31568][R][DOCS] Add detail about func/key in gapply to documentation

2020-04-26 Thread GitBox
MichaelChirico commented on pull request #28350: URL: https://github.com/apache/spark/pull/28350#issuecomment-619740538 really opened a can of worms here huh. To me, it makes sense to leave the PR as is, then do the `dapply`/`dapplyCollect` centralization in another PR. Have

[GitHub] [spark] HyukjinKwon commented on pull request #28327: [SPARK-29664][PYTHON][SQL][FOLLOW-UP] Add deprecation warnings for getItem instead

2020-04-26 Thread GitBox
HyukjinKwon commented on pull request #28327: URL: https://github.com/apache/spark/pull/28327#issuecomment-619738372 Merged to master and branch-3.0. This is an automated message from the Apache Git Service. To respond to

[GitHub] [spark] dongjoon-hyun commented on pull request #28359: [SPARK-31534][WEBUI][3.0] Text for tooltip should be escaped

2020-04-26 Thread GitBox
dongjoon-hyun commented on pull request #28359: URL: https://github.com/apache/spark/pull/28359#issuecomment-619738381 Thank you, @sarutak . This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] maropu commented on a change in pull request #28215: [SPARK-31272][SQL] Support DB2 Kerberos login in JDBC connector

2020-04-26 Thread GitBox
maropu commented on a change in pull request #28215: URL: https://github.com/apache/spark/pull/28215#discussion_r415526378 ## File path: external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/DB2KrbIntegrationSuite.scala ## @@ -0,0 +1,89 @@ +/* + *

[GitHub] [spark] maropu commented on a change in pull request #28215: [SPARK-31272][SQL] Support DB2 Kerberos login in JDBC connector

2020-04-26 Thread GitBox
maropu commented on a change in pull request #28215: URL: https://github.com/apache/spark/pull/28215#discussion_r415526378 ## File path: external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/DB2KrbIntegrationSuite.scala ## @@ -0,0 +1,89 @@ +/* + *

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28356: [SPARK-31485][CORE][3.0] Avoid application hang if only partial barrier tasks launched

2020-04-26 Thread GitBox
AmplabJenkins removed a comment on pull request #28356: URL: https://github.com/apache/spark/pull/28356#issuecomment-619735958 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28350: [SPARK-31568][R][DOCS] Add detail about func/key in gapply to documentation

2020-04-26 Thread GitBox
AmplabJenkins commented on pull request #28350: URL: https://github.com/apache/spark/pull/28350#issuecomment-619736195 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] MaxGekk commented on a change in pull request #28328: [SPARK-31553][SQL] Fix isInCollection for collection sizes above the optimisation threshold

2020-04-26 Thread GitBox
MaxGekk commented on a change in pull request #28328: URL: https://github.com/apache/spark/pull/28328#discussion_r415525400 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala ## @@ -426,7 +426,10 @@ case class In(value:

[GitHub] [spark] SparkQA commented on pull request #28350: [SPARK-31568][R][DOCS] Add detail about func/key in gapply to documentation

2020-04-26 Thread GitBox
SparkQA commented on pull request #28350: URL: https://github.com/apache/spark/pull/28350#issuecomment-619736026 **[Test build #121874 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121874/testReport)** for PR 28350 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #28350: [SPARK-31568][R][DOCS] Add detail about func/key in gapply to documentation

2020-04-26 Thread GitBox
SparkQA removed a comment on pull request #28350: URL: https://github.com/apache/spark/pull/28350#issuecomment-619717524 **[Test build #121874 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121874/testReport)** for PR 28350 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28350: [SPARK-31568][R][DOCS] Add detail about func/key in gapply to documentation

2020-04-26 Thread GitBox
AmplabJenkins removed a comment on pull request #28350: URL: https://github.com/apache/spark/pull/28350#issuecomment-619736195 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28356: [SPARK-31485][CORE][3.0] Avoid application hang if only partial barrier tasks launched

2020-04-26 Thread GitBox
AmplabJenkins commented on pull request #28356: URL: https://github.com/apache/spark/pull/28356#issuecomment-619735958 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28356: [SPARK-31485][CORE][3.0] Avoid application hang if only partial barrier tasks launched

2020-04-26 Thread GitBox
SparkQA commented on pull request #28356: URL: https://github.com/apache/spark/pull/28356#issuecomment-619735451 **[Test build #121875 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121875/testReport)** for PR 28356 at commit

[GitHub] [spark] cloud-fan commented on pull request #28326: [SPARK-27340][SS] Alias on TimeWindow expression cause watermark metadata lost

2020-04-26 Thread GitBox
cloud-fan commented on pull request #28326: URL: https://github.com/apache/spark/pull/28326#issuecomment-619735441 > I'm wondering why Alias has an explicit metadata and hides the actual attribute's metadata Sometimes we have to, for example, `a + b as c`, what should be the

[GitHub] [spark] cloud-fan commented on pull request #28356: [SPARK-31485][CORE][3.0] Avoid application hang if only partial barrier tasks launched

2020-04-26 Thread GitBox
cloud-fan commented on pull request #28356: URL: https://github.com/apache/spark/pull/28356#issuecomment-619733515 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] cloud-fan commented on pull request #28055: [SPARK-31289][TEST][test-hive1.2] Eliminate org.apache.spark.sql.hive.thriftserver.CliSuite flakiness

2020-04-26 Thread GitBox
cloud-fan commented on pull request #28055: URL: https://github.com/apache/spark/pull/28055#issuecomment-619733134 I'm OK to have this patch to reduce test time, but we may need to update the PR description and do some experiments to prove this does reduce test time.

[GitHub] [spark] yaooqinn commented on pull request #28055: [SPARK-31289][TEST][test-hive1.2] Eliminate org.apache.spark.sql.hive.thriftserver.CliSuite flakiness

2020-04-26 Thread GitBox
yaooqinn commented on pull request #28055: URL: https://github.com/apache/spark/pull/28055#issuecomment-619731713 In the latest master branch, I notice that we will wait for the suite process to be shutdown gracefully for 1 minute, which may reduce the flakiness of CliSuite but introduce

[GitHub] [spark] MaxGekk commented on a change in pull request #28328: [SPARK-31553][SQL] Fix isInCollection for collection sizes above the optimisation threshold

2020-04-26 Thread GitBox
MaxGekk commented on a change in pull request #28328: URL: https://github.com/apache/spark/pull/28328#discussion_r415521493 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala ## @@ -426,7 +426,10 @@ case class In(value:

[GitHub] [spark] cloud-fan commented on pull request #28310: [SPARK-31527][SQL] date add/subtract interval only allow those day precision in ansi mode

2020-04-26 Thread GitBox
cloud-fan commented on pull request #28310: URL: https://github.com/apache/spark/pull/28310#issuecomment-619730253 thanks, merging to master/3.0! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] cloud-fan commented on a change in pull request #28109: [SPARK-31524][SQL][followup] Add metric to the split task number for skew optimization

2020-04-26 Thread GitBox
cloud-fan commented on a change in pull request #28109: URL: https://github.com/apache/spark/pull/28109#discussion_r415519376 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/metric/SQLMetrics.scala ## @@ -87,6 +87,7 @@ object SQLMetrics { private val

[GitHub] [spark] cloud-fan commented on a change in pull request #28109: [SPARK-31524][SQL][followup] Add metric to the split task number for skew optimization

2020-04-26 Thread GitBox
cloud-fan commented on a change in pull request #28109: URL: https://github.com/apache/spark/pull/28109#discussion_r415519482 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/CustomShuffleReaderExec.scala ## @@ -153,7 +170,9 @@ case class

[GitHub] [spark] cloud-fan commented on a change in pull request #28109: [SPARK-31524][SQL][followup] Add metric to the split task number for skew optimization

2020-04-26 Thread GitBox
cloud-fan commented on a change in pull request #28109: URL: https://github.com/apache/spark/pull/28109#discussion_r415519133 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/CustomShuffleReaderExec.scala ## @@ -112,6 +113,16 @@ case class

[GitHub] [spark] yaooqinn edited a comment on pull request #28055: [SPARK-31289][TEST][test-hive1.2] Eliminate org.apache.spark.sql.hive.thriftserver.CliSuite flakiness

2020-04-26 Thread GitBox
yaooqinn edited a comment on pull request #28055: URL: https://github.com/apache/spark/pull/28055#issuecomment-619726953 According to the error stack trace in the failed test, the test failed to instantiate a hive metastore client because of derby requirements. ``` Caused by: ERROR

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28327: [SPARK-29664][PYTHON][SQL][FOLLOW-UP] Add deprecation warnings for getItem instead

2020-04-26 Thread GitBox
AmplabJenkins removed a comment on pull request #28327: URL: https://github.com/apache/spark/pull/28327#issuecomment-619726343 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] cloud-fan commented on a change in pull request #28328: [SPARK-31553][SQL] Fix isInCollection for collection sizes above the optimisation threshold

2020-04-26 Thread GitBox
cloud-fan commented on a change in pull request #28328: URL: https://github.com/apache/spark/pull/28328#discussion_r415517516 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala ## @@ -426,7 +426,10 @@ case class In(value:

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28356: [SPARK-31485][CORE][3.0] Avoid application hang if only partial barrier tasks launched

2020-04-26 Thread GitBox
AmplabJenkins removed a comment on pull request #28356: URL: https://github.com/apache/spark/pull/28356#issuecomment-619725756 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] cloud-fan commented on pull request #26624: [SPARK-8981][core] Add MDC support in Executor

2020-04-26 Thread GitBox
cloud-fan commented on pull request #26624: URL: https://github.com/apache/spark/pull/26624#issuecomment-619727014 cc @Ngone51 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [spark] yaooqinn commented on pull request #28055: [SPARK-31289][TEST][test-hive1.2] Eliminate org.apache.spark.sql.hive.thriftserver.CliSuite flakiness

2020-04-26 Thread GitBox
yaooqinn commented on pull request #28055: URL: https://github.com/apache/spark/pull/28055#issuecomment-619726953 According to the error stack trace in the failed test, the test failed to instantiate a hive metastore client because of derby requirements. ``` Caused by: ERROR XBM0A:

[GitHub] [spark] AmplabJenkins commented on pull request #28327: [SPARK-29664][PYTHON][SQL][FOLLOW-UP] Add deprecation warnings for getItem instead

2020-04-26 Thread GitBox
AmplabJenkins commented on pull request #28327: URL: https://github.com/apache/spark/pull/28327#issuecomment-619726343 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28356: [SPARK-31485][CORE][3.0] Avoid application hang if only partial barrier tasks launched

2020-04-26 Thread GitBox
AmplabJenkins removed a comment on pull request #28356: URL: https://github.com/apache/spark/pull/28356#issuecomment-619725747 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA removed a comment on pull request #28327: [SPARK-29664][PYTHON][SQL][FOLLOW-UP] Add deprecation warnings for getItem instead

2020-04-26 Thread GitBox
SparkQA removed a comment on pull request #28327: URL: https://github.com/apache/spark/pull/28327#issuecomment-619709672 **[Test build #121872 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121872/testReport)** for PR 28327 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28356: [SPARK-31485][CORE][3.0] Avoid application hang if only partial barrier tasks launched

2020-04-26 Thread GitBox
AmplabJenkins commented on pull request #28356: URL: https://github.com/apache/spark/pull/28356#issuecomment-619725747 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28327: [SPARK-29664][PYTHON][SQL][FOLLOW-UP] Add deprecation warnings for getItem instead

2020-04-26 Thread GitBox
SparkQA commented on pull request #28327: URL: https://github.com/apache/spark/pull/28327#issuecomment-619725648 **[Test build #121872 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121872/testReport)** for PR 28327 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #28356: [SPARK-31485][CORE][3.0] Avoid application hang if only partial barrier tasks launched

2020-04-26 Thread GitBox
SparkQA removed a comment on pull request #28356: URL: https://github.com/apache/spark/pull/28356#issuecomment-619678050 **[Test build #121862 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121862/testReport)** for PR 28356 at commit

[GitHub] [spark] SparkQA commented on pull request #28356: [SPARK-31485][CORE][3.0] Avoid application hang if only partial barrier tasks launched

2020-04-26 Thread GitBox
SparkQA commented on pull request #28356: URL: https://github.com/apache/spark/pull/28356#issuecomment-619725253 **[Test build #121862 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121862/testReport)** for PR 28356 at commit

[GitHub] [spark] HeartSaVioR commented on pull request #28326: [SPARK-27340][SS] Alias on TimeWindow expression cause watermark metadata lost

2020-04-26 Thread GitBox
HeartSaVioR commented on pull request #28326: URL: https://github.com/apache/spark/pull/28326#issuecomment-619722391 (Please consider that I'm not an expert of SQL area.) I've read through the code around Alias and played with the reproducer (test), and feel #24457 is the fix

[GitHub] [spark] dongjoon-hyun edited a comment on pull request #28358: [WIP][SPARK-31567][R][TESTS] Update AppVeyor R version to 4.0.0

2020-04-26 Thread GitBox
dongjoon-hyun edited a comment on pull request #28358: URL: https://github.com/apache/spark/pull/28358#issuecomment-619711936 AppVeyor seems to complain at `SparkR` installation. However, on Mac, installation is okay and JVM call is okay and some SQL queries (CREATE/INSERT/SELECT)

[GitHub] [spark] dongjoon-hyun edited a comment on pull request #28358: [WIP][SPARK-31567][R][TESTS] Update AppVeyor R version to 4.0.0

2020-04-26 Thread GitBox
dongjoon-hyun edited a comment on pull request #28358: URL: https://github.com/apache/spark/pull/28358#issuecomment-619711936 AppVeyor seems to complain at `SparkR` installation. However, on Mac, installation is okay and JVM call is okay and some SQL queries (CREATE/INSERT/SELECT)

[GitHub] [spark] cloud-fan commented on pull request #28345: [SPARK-31557][SQL] Legacy time parser should return Gregorian days rather than Julian days

2020-04-26 Thread GitBox
cloud-fan commented on pull request #28345: URL: https://github.com/apache/spark/pull/28345#issuecomment-619721051 @MaxGekk can you help to fix the timestamp part as well? This is an automated message from the Apache Git

[GitHub] [spark] cloud-fan commented on pull request #28345: [SPARK-31557][SQL] Legacy time parser should return Gregorian days rather than Julian days

2020-04-26 Thread GitBox
cloud-fan commented on pull request #28345: URL: https://github.com/apache/spark/pull/28345#issuecomment-619719490 thanks, merging to master/3.0! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] AmplabJenkins commented on pull request #28350: [SPARK-31568][R][DOCS] Add detail about func/key in gapply to documentation

2020-04-26 Thread GitBox
AmplabJenkins commented on pull request #28350: URL: https://github.com/apache/spark/pull/28350#issuecomment-619718080 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28350: [SPARK-31568][R][DOCS] Add detail about func/key in gapply to documentation

2020-04-26 Thread GitBox
AmplabJenkins removed a comment on pull request #28350: URL: https://github.com/apache/spark/pull/28350#issuecomment-619716830 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA removed a comment on pull request #28350: [SPARK-31568][R][DOCS] Add detail about func/key in gapply to documentation

2020-04-26 Thread GitBox
SparkQA removed a comment on pull request #28350: URL: https://github.com/apache/spark/pull/28350#issuecomment-619712257 **[Test build #121873 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121873/testReport)** for PR 28350 at commit

[GitHub] [spark] SparkQA commented on pull request #28350: [SPARK-31568][R][DOCS] Add detail about func/key in gapply to documentation

2020-04-26 Thread GitBox
SparkQA commented on pull request #28350: URL: https://github.com/apache/spark/pull/28350#issuecomment-619717524 **[Test build #121874 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121874/testReport)** for PR 28350 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28350: [SPARK-31568][R][DOCS] Add detail about func/key in gapply to documentation

2020-04-26 Thread GitBox
AmplabJenkins commented on pull request #28350: URL: https://github.com/apache/spark/pull/28350#issuecomment-619716830 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28350: [SPARK-31568][R][DOCS] Add detail about func/key in gapply to documentation

2020-04-26 Thread GitBox
SparkQA commented on pull request #28350: URL: https://github.com/apache/spark/pull/28350#issuecomment-619716814 **[Test build #121873 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121873/testReport)** for PR 28350 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #26339: [SPARK-27194][SPARK-29302][SQL] Fix the issue that for dynamic partition overwrite a task would conflict with its speculative t

2020-04-26 Thread GitBox
AmplabJenkins removed a comment on pull request #26339: URL: https://github.com/apache/spark/pull/26339#issuecomment-619712667 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28350: [SPARK-31568][R][DOCS] Add detail about func/key in gapply to documentation

2020-04-26 Thread GitBox
AmplabJenkins removed a comment on pull request #28350: URL: https://github.com/apache/spark/pull/28350#issuecomment-619712716 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #26339: [SPARK-27194][SPARK-29302][SQL] Fix the issue that for dynamic partition overwrite a task would conflict with its speculative task

2020-04-26 Thread GitBox
AmplabJenkins commented on pull request #26339: URL: https://github.com/apache/spark/pull/26339#issuecomment-619712667 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #28350: [SPARK-31568][R][DOCS] Add detail about func/key in gapply to documentation

2020-04-26 Thread GitBox
AmplabJenkins commented on pull request #28350: URL: https://github.com/apache/spark/pull/28350#issuecomment-619712716 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28350: [SPARK-31568][R][DOCS] Add detail about func/key in gapply to documentation

2020-04-26 Thread GitBox
SparkQA commented on pull request #28350: URL: https://github.com/apache/spark/pull/28350#issuecomment-619712257 **[Test build #121873 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121873/testReport)** for PR 28350 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #26339: [SPARK-27194][SPARK-29302][SQL] Fix the issue that for dynamic partition overwrite a task would conflict with its speculative task

2020-04-26 Thread GitBox
SparkQA removed a comment on pull request #26339: URL: https://github.com/apache/spark/pull/26339#issuecomment-619657326 **[Test build #121859 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121859/testReport)** for PR 26339 at commit

[GitHub] [spark] dongjoon-hyun commented on pull request #28358: [WIP][SPARK-31567][R][TESTS] Update AppVeyor R version to 4.0.0

2020-04-26 Thread GitBox
dongjoon-hyun commented on pull request #28358: URL: https://github.com/apache/spark/pull/28358#issuecomment-619711936 AppVeyor seems to complain at `SparkR` installation. However, on Mac, installation is okay and some SQL queries (CREATE/INSERT/SELECT) works. The real situation

[GitHub] [spark] SparkQA commented on pull request #26339: [SPARK-27194][SPARK-29302][SQL] Fix the issue that for dynamic partition overwrite a task would conflict with its speculative task

2020-04-26 Thread GitBox
SparkQA commented on pull request #26339: URL: https://github.com/apache/spark/pull/26339#issuecomment-619711667 **[Test build #121859 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121859/testReport)** for PR 26339 at commit

[GitHub] [spark] MichaelChirico commented on pull request #28350: [SPARK-31568][R][DOCS] Add detail about func/key in gapply to documentation

2020-04-26 Thread GitBox
MichaelChirico commented on pull request #28350: URL: https://github.com/apache/spark/pull/28350#issuecomment-619711106 @HyukjinKwon finished merging the Rds. Checked the output of `roxygen2::roxygenize('.')` & looks OK. Thanks for pushing in a better direction.

[GitHub] [spark] MichaelChirico commented on a change in pull request #28350: [SPARK-31568][R][DOCS] Add detail about func/key in gapply to documentation

2020-04-26 Thread GitBox
MichaelChirico commented on a change in pull request #28350: URL: https://github.com/apache/spark/pull/28350#discussion_r415503595 ## File path: R/pkg/R/functions.R ## @@ -3951,7 +3951,6 @@ setMethod("map_values", #' @rdname column_collection_functions #' @aliases

[GitHub] [spark] AmplabJenkins commented on pull request #28327: [SPARK-29664][PYTHON][SQL][FOLLOW-UP] Add deprecation warnings for getItem instead

2020-04-26 Thread GitBox
AmplabJenkins commented on pull request #28327: URL: https://github.com/apache/spark/pull/28327#issuecomment-619710075 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28327: [SPARK-29664][PYTHON][SQL][FOLLOW-UP] Add deprecation warnings for getItem instead

2020-04-26 Thread GitBox
AmplabJenkins removed a comment on pull request #28327: URL: https://github.com/apache/spark/pull/28327#issuecomment-619710075 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #28327: [SPARK-29664][PYTHON][SQL][FOLLOW-UP] Add deprecation warnings for getItem instead

2020-04-26 Thread GitBox
SparkQA commented on pull request #28327: URL: https://github.com/apache/spark/pull/28327#issuecomment-619709672 **[Test build #121872 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121872/testReport)** for PR 28327 at commit

[GitHub] [spark] cloud-fan commented on pull request #28156: [SPARK-31388][SQL][TESTS] org.apache.spark.sql.hive.thriftserver.CliSuite doesn't match results correctly

2020-04-26 Thread GitBox
cloud-fan commented on pull request #28156: URL: https://github.com/apache/spark/pull/28156#issuecomment-619708264 thanks, merging to master/3.0! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] cloud-fan commented on pull request #28055: [SPARK-31289][TEST][test-hive1.2] Eliminate org.apache.spark.sql.hive.thriftserver.CliSuite flakiness

2020-04-26 Thread GitBox
cloud-fan commented on pull request #28055: URL: https://github.com/apache/spark/pull/28055#issuecomment-619707782 > CliSuite seems to be flaky while using metastoreDir per test Do you know the reason? This is an

[GitHub] [spark] HyukjinKwon commented on pull request #28327: [SPARK-29664][PYTHON][SQL][FOLLOW-UP] Add deprecation warnings for getItem instead

2020-04-26 Thread GitBox
HyukjinKwon commented on pull request #28327: URL: https://github.com/apache/spark/pull/28327#issuecomment-619707526 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28327: [SPARK-29664][PYTHON][SQL][FOLLOW-UP] Add deprecation warnings for getItem instead

2020-04-26 Thread GitBox
AmplabJenkins removed a comment on pull request #28327: URL: https://github.com/apache/spark/pull/28327#issuecomment-619707013 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on pull request #28327: [SPARK-29664][PYTHON][SQL][FOLLOW-UP] Add deprecation warnings for getItem instead

2020-04-26 Thread GitBox
AmplabJenkins commented on pull request #28327: URL: https://github.com/apache/spark/pull/28327#issuecomment-619707004 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28327: [SPARK-29664][PYTHON][SQL][FOLLOW-UP] Add deprecation warnings for getItem instead

2020-04-26 Thread GitBox
SparkQA removed a comment on pull request #28327: URL: https://github.com/apache/spark/pull/28327#issuecomment-619698750 **[Test build #121868 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121868/testReport)** for PR 28327 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28327: [SPARK-29664][PYTHON][SQL][FOLLOW-UP] Add deprecation warnings for getItem instead

2020-04-26 Thread GitBox
AmplabJenkins removed a comment on pull request #28327: URL: https://github.com/apache/spark/pull/28327#issuecomment-619707004 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA commented on pull request #28327: [SPARK-29664][PYTHON][SQL][FOLLOW-UP] Add deprecation warnings for getItem instead

2020-04-26 Thread GitBox
SparkQA commented on pull request #28327: URL: https://github.com/apache/spark/pull/28327#issuecomment-619706792 **[Test build #121868 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121868/testReport)** for PR 28327 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28353: [WIP] Use R 4.0.0 in AppVeyor for Apache Spark 3.1.0

2020-04-26 Thread GitBox
AmplabJenkins removed a comment on pull request #28353: URL: https://github.com/apache/spark/pull/28353#issuecomment-619705683 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28354: [SPARK-31566][SQL][DOCS] Add SQL Rest API Documentation

2020-04-26 Thread GitBox
AmplabJenkins commented on pull request #28354: URL: https://github.com/apache/spark/pull/28354#issuecomment-619705453 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28354: [SPARK-31566][SQL][DOCS] Add SQL Rest API Documentation

2020-04-26 Thread GitBox
SparkQA removed a comment on pull request #28354: URL: https://github.com/apache/spark/pull/28354#issuecomment-619700668 **[Test build #121869 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121869/testReport)** for PR 28354 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28353: [WIP] Use R 4.0.0 in AppVeyor for Apache Spark 3.1.0

2020-04-26 Thread GitBox
AmplabJenkins commented on pull request #28353: URL: https://github.com/apache/spark/pull/28353#issuecomment-619705683 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28354: [SPARK-31566][SQL][DOCS] Add SQL Rest API Documentation

2020-04-26 Thread GitBox
AmplabJenkins removed a comment on pull request #28354: URL: https://github.com/apache/spark/pull/28354#issuecomment-619705453 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #28354: [SPARK-31566][SQL][DOCS] Add SQL Rest API Documentation

2020-04-26 Thread GitBox
SparkQA commented on pull request #28354: URL: https://github.com/apache/spark/pull/28354#issuecomment-619705351 **[Test build #121869 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121869/testReport)** for PR 28354 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #28353: [WIP] Use R 4.0.0 in AppVeyor for Apache Spark 3.1.0

2020-04-26 Thread GitBox
SparkQA removed a comment on pull request #28353: URL: https://github.com/apache/spark/pull/28353#issuecomment-619654357 **[Test build #121856 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121856/testReport)** for PR 28353 at commit

[GitHub] [spark] SparkQA commented on pull request #28353: [WIP] Use R 4.0.0 in AppVeyor for Apache Spark 3.1.0

2020-04-26 Thread GitBox
SparkQA commented on pull request #28353: URL: https://github.com/apache/spark/pull/28353#issuecomment-619704843 **[Test build #121856 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121856/testReport)** for PR 28353 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28350: [SPARK-31568][R][DOCS] Add detail about func/key in gapply to documentation

2020-04-26 Thread GitBox
AmplabJenkins removed a comment on pull request #28350: URL: https://github.com/apache/spark/pull/28350#issuecomment-619704025 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28350: [SPARK-31568][R][DOCS] Add detail about func/key in gapply to documentation

2020-04-26 Thread GitBox
AmplabJenkins commented on pull request #28350: URL: https://github.com/apache/spark/pull/28350#issuecomment-619704025 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28350: [SPARK-31568][R][DOCS] Add detail about func/key in gapply to documentation

2020-04-26 Thread GitBox
SparkQA removed a comment on pull request #28350: URL: https://github.com/apache/spark/pull/28350#issuecomment-619692020 **[Test build #121866 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121866/testReport)** for PR 28350 at commit

[GitHub] [spark] HyukjinKwon commented on pull request #28354: [SPARK-31566][SQL][DOCS] Add SQL Rest API Documentation

2020-04-26 Thread GitBox
HyukjinKwon commented on pull request #28354: URL: https://github.com/apache/spark/pull/28354#issuecomment-619704133 cc @gengliangwang FYI This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] SparkQA commented on pull request #28350: [SPARK-31568][R][DOCS] Add detail about func/key in gapply to documentation

2020-04-26 Thread GitBox
SparkQA commented on pull request #28350: URL: https://github.com/apache/spark/pull/28350#issuecomment-619703834 **[Test build #121866 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121866/testReport)** for PR 28350 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28359: [SPARK-31534][WEBUI][3.0] Text for tooltip should be escaped

2020-04-26 Thread GitBox
AmplabJenkins removed a comment on pull request #28359: URL: https://github.com/apache/spark/pull/28359#issuecomment-619702942 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28359: [SPARK-31534][WEBUI][3.0] Text for tooltip should be escaped

2020-04-26 Thread GitBox
AmplabJenkins commented on pull request #28359: URL: https://github.com/apache/spark/pull/28359#issuecomment-619702942 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] sarutak commented on pull request #28359: [SPARK-31534][WEBUI][3.0] Text for tooltip should be escaped

2020-04-26 Thread GitBox
sarutak commented on pull request #28359: URL: https://github.com/apache/spark/pull/28359#issuecomment-619702971 The error message mentioned [here](https://github.com/apache/spark/pull/28317#issuecomment-619438678) is not shown in this branch. I found it's because the version of

[GitHub] [spark] sarutak opened a new pull request #28359: [SPARK-31534][WEBUI][3.0] Text for tooltip should be escaped

2020-04-26 Thread GitBox
sarutak opened a new pull request #28359: URL: https://github.com/apache/spark/pull/28359 ### What changes were proposed in this pull request? This PR backports #28317 which escapes text for tooltip for DAG Viz and Timeline View. ### Why are the changes needed? This is a

[GitHub] [spark] SparkQA commented on pull request #28359: [SPARK-31534][WEBUI][3.0] Text for tooltip should be escaped

2020-04-26 Thread GitBox
SparkQA commented on pull request #28359: URL: https://github.com/apache/spark/pull/28359#issuecomment-619702598 **[Test build #121871 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121871/testReport)** for PR 28359 at commit

[GitHub] [spark] erenavsarogullari commented on pull request #28354: [SPARK-31566][SQL][DOCS] Add SQL Rest API Documentation

2020-04-26 Thread GitBox
erenavsarogullari commented on pull request #28354: URL: https://github.com/apache/spark/pull/28354#issuecomment-619701829 Hi @HyukjinKwon, Thanks for the review. I removed the dependency so current documentation just points the existing functionality on `SqlResource`. So, this can go

[GitHub] [spark] huaxingao commented on pull request #28348: [MINOR][SQL][DOCS] Remove two leading spaces from sql tables

2020-04-26 Thread GitBox
huaxingao commented on pull request #28348: URL: https://github.com/apache/spark/pull/28348#issuecomment-619701454 @gatorsmile We actually highlight SQL keywords. We have ``` {% highlight sql %} .. -- Correlated Subquery in `WHERE` clause. SELECT * FROM person AS

[GitHub] [spark] mengxr commented on pull request #28279: [SPARK-31497][ML][PYSPARK] Fix Pyspark CrossValidator/TrainValidationSplit with pipeline estimator cannot save and load model

2020-04-26 Thread GitBox
mengxr commented on pull request #28279: URL: https://github.com/apache/spark/pull/28279#issuecomment-619701317 LGTM. Merging into master and spark-3.0. This is an automated message from the Apache Git Service. To respond to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28354: [SPARK-31566][SQL][DOCS] Add SQL Rest API Documentation

2020-04-26 Thread GitBox
AmplabJenkins removed a comment on pull request #28354: URL: https://github.com/apache/spark/pull/28354#issuecomment-619700962 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28354: [SPARK-31566][SQL][DOCS] Add SQL Rest API Documentation

2020-04-26 Thread GitBox
AmplabJenkins commented on pull request #28354: URL: https://github.com/apache/spark/pull/28354#issuecomment-619700962 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #27006: [SPARK-30352][SQL] DataSourceV2: Add CURRENT_CATALOG function

2020-04-26 Thread GitBox
SparkQA commented on pull request #27006: URL: https://github.com/apache/spark/pull/27006#issuecomment-619700713 **[Test build #121870 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121870/testReport)** for PR 27006 at commit

[GitHub] [spark] SparkQA commented on pull request #28354: [SPARK-31566][SQL][DOCS] Add SQL Rest API Documentation

2020-04-26 Thread GitBox
SparkQA commented on pull request #28354: URL: https://github.com/apache/spark/pull/28354#issuecomment-619700668 **[Test build #121869 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121869/testReport)** for PR 28354 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28353: [WIP] Use R 4.0.0 in AppVeyor for Apache Spark 3.1.0

2020-04-26 Thread GitBox
AmplabJenkins commented on pull request #28353: URL: https://github.com/apache/spark/pull/28353#issuecomment-619699789 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28353: [WIP] Use R 4.0.0 in AppVeyor for Apache Spark 3.1.0

2020-04-26 Thread GitBox
AmplabJenkins removed a comment on pull request #28353: URL: https://github.com/apache/spark/pull/28353#issuecomment-619699789 This is an automated message from the Apache Git Service. To respond to the message, please log on

  1   2   3   4   5   >