[GitHub] [spark] huaxingao commented on a change in pull request #30154: [SPARK-32405][SQL] Apply table options while creating tables in JDBC Table Catalog

2020-11-03 Thread GitBox
huaxingao commented on a change in pull request #30154: URL: https://github.com/apache/spark/pull/30154#discussion_r517154290 ## File path: sql/core/src/main/scala/org/apache/spark/sql/jdbc/DerbyDialect.scala ## @@ -50,4 +50,17 @@ private object DerbyDialect extends

[GitHub] [spark] otterc commented on pull request #30062: [SPARK-32916][SHUFFLE] Implementation of shuffle service that leverages push-based shuffle in YARN deployment mode

2020-11-03 Thread GitBox
otterc commented on pull request #30062: URL: https://github.com/apache/spark/pull/30062#issuecomment-721567210 I ran an end-to-end test. One of the bugs was: ``` Caused by: java.lang.IndexOutOfBoundsException at java.nio.ByteBuffer.wrap(ByteBuffer.java:375) at

[GitHub] [spark] SparkQA commented on pull request #30062: [SPARK-32916][SHUFFLE] Implementation of shuffle service that leverages push-based shuffle in YARN deployment mode

2020-11-03 Thread GitBox
SparkQA commented on pull request #30062: URL: https://github.com/apache/spark/pull/30062#issuecomment-721566228 **[Test build #130595 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130595/testReport)** for PR 30062 at commit

[GitHub] [spark] HeartSaVioR commented on a change in pull request #30203: [SPARK-33303][SQL] Deduplicate deterministic PythonUDF calls

2020-11-03 Thread GitBox
HeartSaVioR commented on a change in pull request #30203: URL: https://github.com/apache/spark/pull/30203#discussion_r517144041 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/python/ExtractPythonUDFs.scala ## @@ -218,13 +218,22 @@ object

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30242: [SPARK-33277][PYSPARK][SQL][FOLLOW-UP] Block TaskCompletion event until the thread ends.

2020-11-03 Thread GitBox
AmplabJenkins removed a comment on pull request #30242: URL: https://github.com/apache/spark/pull/30242#issuecomment-721562547 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #30243: [SPARK-33335][SQL] Support `array_contains_array` func

2020-11-03 Thread GitBox
SparkQA commented on pull request #30243: URL: https://github.com/apache/spark/pull/30243#issuecomment-721563148 **[Test build #130594 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130594/testReport)** for PR 30243 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #30242: [SPARK-33277][PYSPARK][SQL][FOLLOW-UP] Block TaskCompletion event until the thread ends.

2020-11-03 Thread GitBox
AmplabJenkins commented on pull request #30242: URL: https://github.com/apache/spark/pull/30242#issuecomment-721562547 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #30242: [SPARK-33277][PYSPARK][SQL][FOLLOW-UP] Block TaskCompletion event until the thread ends.

2020-11-03 Thread GitBox
SparkQA commented on pull request #30242: URL: https://github.com/apache/spark/pull/30242#issuecomment-721561669 **[Test build #130586 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130586/testReport)** for PR 30242 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #30242: [SPARK-33277][PYSPARK][SQL][FOLLOW-UP] Block TaskCompletion event until the thread ends.

2020-11-03 Thread GitBox
SparkQA removed a comment on pull request #30242: URL: https://github.com/apache/spark/pull/30242#issuecomment-721486742 **[Test build #130586 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130586/testReport)** for PR 30242 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30245: [WIP][SPARK-33337][SQL] Support subexpression elimination in branches of conditional expressions

2020-11-03 Thread GitBox
AmplabJenkins removed a comment on pull request #30245: URL: https://github.com/apache/spark/pull/30245#issuecomment-721561406 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #30245: [WIP][SPARK-33337][SQL] Support subexpression elimination in branches of conditional expressions

2020-11-03 Thread GitBox
SparkQA commented on pull request #30245: URL: https://github.com/apache/spark/pull/30245#issuecomment-721561387 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35193/

[GitHub] [spark] AmplabJenkins commented on pull request #30245: [WIP][SPARK-33337][SQL] Support subexpression elimination in branches of conditional expressions

2020-11-03 Thread GitBox
AmplabJenkins commented on pull request #30245: URL: https://github.com/apache/spark/pull/30245#issuecomment-721561406 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #30245: [WIP][SPARK-33337][SQL] Support subexpression elimination in branches of conditional expressions

2020-11-03 Thread GitBox
SparkQA commented on pull request #30245: URL: https://github.com/apache/spark/pull/30245#issuecomment-721557561 **[Test build #130593 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130593/testReport)** for PR 30245 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30243: [SPARK-33335][SQL] Support `array_contains_array` func

2020-11-03 Thread GitBox
AmplabJenkins removed a comment on pull request #30243: URL: https://github.com/apache/spark/pull/30243#issuecomment-721555499 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30243: [SPARK-33335][SQL] Support `array_contains_array` func

2020-11-03 Thread GitBox
AmplabJenkins removed a comment on pull request #30243: URL: https://github.com/apache/spark/pull/30243#issuecomment-721555493 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA removed a comment on pull request #30243: [SPARK-33335][SQL] Support `array_contains_array` func

2020-11-03 Thread GitBox
SparkQA removed a comment on pull request #30243: URL: https://github.com/apache/spark/pull/30243#issuecomment-721500664 **[Test build #130590 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130590/testReport)** for PR 30243 at commit

[GitHub] [spark] cloud-fan commented on a change in pull request #30154: [SPARK-32405][SQL] Apply table options while creating tables in JDBC Table Catalog

2020-11-03 Thread GitBox
cloud-fan commented on a change in pull request #30154: URL: https://github.com/apache/spark/pull/30154#discussion_r517135283 ## File path: sql/core/src/main/scala/org/apache/spark/sql/jdbc/DerbyDialect.scala ## @@ -50,4 +50,17 @@ private object DerbyDialect extends

[GitHub] [spark] cloud-fan commented on a change in pull request #30154: [SPARK-32405][SQL] Apply table options while creating tables in JDBC Table Catalog

2020-11-03 Thread GitBox
cloud-fan commented on a change in pull request #30154: URL: https://github.com/apache/spark/pull/30154#discussion_r517135401 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/jdbc/JDBCTableCatalog.scala ## @@ -117,14 +117,33 @@ class

[GitHub] [spark] AmplabJenkins commented on pull request #30243: [SPARK-33335][SQL] Support `array_contains_array` func

2020-11-03 Thread GitBox
AmplabJenkins commented on pull request #30243: URL: https://github.com/apache/spark/pull/30243#issuecomment-721555493 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #30243: [SPARK-33335][SQL] Support `array_contains_array` func

2020-11-03 Thread GitBox
SparkQA commented on pull request #30243: URL: https://github.com/apache/spark/pull/30243#issuecomment-721555042 **[Test build #130590 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130590/testReport)** for PR 30243 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30245: [WIP][SPARK-33337][SQL] Support subexpression elimination in branches of conditional expressions

2020-11-03 Thread GitBox
AmplabJenkins removed a comment on pull request #30245: URL: https://github.com/apache/spark/pull/30245#issuecomment-721553355 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA removed a comment on pull request #30245: [WIP][SPARK-33337][SQL] Support subexpression elimination in branches of conditional expressions

2020-11-03 Thread GitBox
SparkQA removed a comment on pull request #30245: URL: https://github.com/apache/spark/pull/30245#issuecomment-721537711 **[Test build #130592 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130592/testReport)** for PR 30245 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #30245: [WIP][SPARK-33337][SQL] Support subexpression elimination in branches of conditional expressions

2020-11-03 Thread GitBox
AmplabJenkins commented on pull request #30245: URL: https://github.com/apache/spark/pull/30245#issuecomment-721553348 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #30245: [WIP][SPARK-33337][SQL] Support subexpression elimination in branches of conditional expressions

2020-11-03 Thread GitBox
SparkQA commented on pull request #30245: URL: https://github.com/apache/spark/pull/30245#issuecomment-721553472 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35193/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30245: [WIP][SPARK-33337][SQL] Support subexpression elimination in branches of conditional expressions

2020-11-03 Thread GitBox
AmplabJenkins removed a comment on pull request #30245: URL: https://github.com/apache/spark/pull/30245#issuecomment-721553348 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA commented on pull request #30245: [WIP][SPARK-33337][SQL] Support subexpression elimination in branches of conditional expressions

2020-11-03 Thread GitBox
SparkQA commented on pull request #30245: URL: https://github.com/apache/spark/pull/30245#issuecomment-721553230 **[Test build #130592 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130592/testReport)** for PR 30245 at commit

[GitHub] [spark] cloud-fan commented on a change in pull request #29837: [SPARK-32463][SQL][DOCS] Add "Type Conversion" section in "Supported Data Types" of SQL docs

2020-11-03 Thread GitBox
cloud-fan commented on a change in pull request #29837: URL: https://github.com/apache/spark/pull/29837#discussion_r517131842 ## File path: docs/sql-ref-datatypes.md ## @@ -314,3 +314,206 @@ SELECT COUNT(*), c2 FROM test GROUP BY c2; |3| Infinity|

[GitHub] [spark] huaxingao commented on pull request #30154: [SPARK-32405][SQL] Apply table options while creating tables in JDBC Table Catalog

2020-11-03 Thread GitBox
huaxingao commented on pull request #30154: URL: https://github.com/apache/spark/pull/30154#issuecomment-721550399 > Does it conflict with the dialect API to generate CREATE TABLE statement? No, it doesn't conflict with the dialect API to generate CREATE TABLE statement. The table

[GitHub] [spark] dongjoon-hyun commented on pull request #30240: [SPARK-33333][BUILD][3.0] Upgrade Jetty to 9.4.28.v20200408

2020-11-03 Thread GitBox
dongjoon-hyun commented on pull request #30240: URL: https://github.com/apache/spark/pull/30240#issuecomment-721548555 Thank you so much, @viirya ! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] cloud-fan closed pull request #30122: [SPARK-33214][TEST][HIVE] Stop HiveExternalCatalogVersionsSuite from using a hard-coded location to store localized Spark binaries.

2020-11-03 Thread GitBox
cloud-fan closed pull request #30122: URL: https://github.com/apache/spark/pull/30122 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [spark] cloud-fan closed pull request #30229: [SPARK-33321][SQL] Migrate ANALYZE TABLE commands to use UnresolvedTableOrView to resolve the identifier

2020-11-03 Thread GitBox
cloud-fan closed pull request #30229: URL: https://github.com/apache/spark/pull/30229 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [spark] cloud-fan commented on pull request #30122: [SPARK-33214][TEST][HIVE] Stop HiveExternalCatalogVersionsSuite from using a hard-coded location to store localized Spark binaries.

2020-11-03 Thread GitBox
cloud-fan commented on pull request #30122: URL: https://github.com/apache/spark/pull/30122#issuecomment-721546906 thanks, merging to master! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] cloud-fan commented on pull request #30229: [SPARK-33321][SQL] Migrate ANALYZE TABLE commands to use UnresolvedTableOrView to resolve the identifier

2020-11-03 Thread GitBox
cloud-fan commented on pull request #30229: URL: https://github.com/apache/spark/pull/30229#issuecomment-721546392 thanks, merging to master! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] cloud-fan commented on a change in pull request #30229: [SPARK-33321][SQL] Migrate ANALYZE TABLE commands to use UnresolvedTableOrView to resolve the identifier

2020-11-03 Thread GitBox
cloud-fan commented on a change in pull request #30229: URL: https://github.com/apache/spark/pull/30229#discussion_r517127493 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala ## @@ -3249,18 +3249,23 @@ class AstBuilder(conf:

[GitHub] [spark] cloud-fan commented on pull request #30154: [SPARK-32405][SQL] Apply table options while creating tables in JDBC Table Catalog

2020-11-03 Thread GitBox
cloud-fan commented on pull request #30154: URL: https://github.com/apache/spark/pull/30154#issuecomment-721545793 > ... send properties to underlying databases and let databases decide whether to fail the CREATE TALBE or not This works. Does it conflict with the dialect API to

[GitHub] [spark] cloud-fan commented on a change in pull request #29837: [SPARK-32463][SQL][DOCS] Add "Type Conversion" section in "Supported Data Types" of SQL docs

2020-11-03 Thread GitBox
cloud-fan commented on a change in pull request #29837: URL: https://github.com/apache/spark/pull/29837#discussion_r517125806 ## File path: docs/sql-ref-datatypes.md ## @@ -314,3 +314,206 @@ SELECT COUNT(*), c2 FROM test GROUP BY c2; |3| Infinity|

[GitHub] [spark] huaxingao commented on pull request #30154: [SPARK-32405][SQL] Apply table options while creating tables in JDBC Table Catalog

2020-11-03 Thread GitBox
huaxingao commented on pull request #30154: URL: https://github.com/apache/spark/pull/30154#issuecomment-721542287 > when users specify some table properties, JDBC V2 should fail if the underlying database can't support the properties. I agree JDBC V2 should fail if the underlying

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30244: [WIP][SPARK-33282] Migrate from dead probot autolabeler to GitHub labeler action

2020-11-03 Thread GitBox
AmplabJenkins removed a comment on pull request #30244: URL: https://github.com/apache/spark/pull/30244#issuecomment-721542255 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #30244: [WIP][SPARK-33282] Migrate from dead probot autolabeler to GitHub labeler action

2020-11-03 Thread GitBox
AmplabJenkins commented on pull request #30244: URL: https://github.com/apache/spark/pull/30244#issuecomment-721542255 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #30244: [WIP][SPARK-33282] Migrate from dead probot autolabeler to GitHub labeler action

2020-11-03 Thread GitBox
SparkQA commented on pull request #30244: URL: https://github.com/apache/spark/pull/30244#issuecomment-721542243 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35192/

[GitHub] [spark] viirya closed pull request #30240: [SPARK-33333][BUILD][3.0] Upgrade Jetty to 9.4.28.v20200408

2020-11-03 Thread GitBox
viirya closed pull request #30240: URL: https://github.com/apache/spark/pull/30240 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30242: [SPARK-33277][PYSPARK][SQL][FOLLOW-UP] Block TaskCompletion event until the thread ends.

2020-11-03 Thread GitBox
AmplabJenkins removed a comment on pull request #30242: URL: https://github.com/apache/spark/pull/30242#issuecomment-721539621 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #30242: [SPARK-33277][PYSPARK][SQL][FOLLOW-UP] Block TaskCompletion event until the thread ends.

2020-11-03 Thread GitBox
AmplabJenkins commented on pull request #30242: URL: https://github.com/apache/spark/pull/30242#issuecomment-721539621 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #30242: [SPARK-33277][PYSPARK][SQL][FOLLOW-UP] Block TaskCompletion event until the thread ends.

2020-11-03 Thread GitBox
SparkQA commented on pull request #30242: URL: https://github.com/apache/spark/pull/30242#issuecomment-721539609 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35191/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30242: [SPARK-33277][PYSPARK][SQL][FOLLOW-UP] Block TaskCompletion event until the thread ends.

2020-11-03 Thread GitBox
AmplabJenkins removed a comment on pull request #30242: URL: https://github.com/apache/spark/pull/30242#issuecomment-721538733 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #30242: [SPARK-33277][PYSPARK][SQL][FOLLOW-UP] Block TaskCompletion event until the thread ends.

2020-11-03 Thread GitBox
AmplabJenkins commented on pull request #30242: URL: https://github.com/apache/spark/pull/30242#issuecomment-721538733 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] viirya commented on pull request #30240: [SPARK-33333][BUILD][3.0] Upgrade Jetty to 9.4.28.v20200408

2020-11-03 Thread GitBox
viirya commented on pull request #30240: URL: https://github.com/apache/spark/pull/30240#issuecomment-721538642 Thanks. Merging to branch-3.0. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] SparkQA removed a comment on pull request #30242: [SPARK-33277][PYSPARK][SQL][FOLLOW-UP] Block TaskCompletion event until the thread ends.

2020-11-03 Thread GitBox
SparkQA removed a comment on pull request #30242: URL: https://github.com/apache/spark/pull/30242#issuecomment-721472000 **[Test build #130584 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130584/testReport)** for PR 30242 at commit

[GitHub] [spark] SparkQA commented on pull request #30242: [SPARK-33277][PYSPARK][SQL][FOLLOW-UP] Block TaskCompletion event until the thread ends.

2020-11-03 Thread GitBox
SparkQA commented on pull request #30242: URL: https://github.com/apache/spark/pull/30242#issuecomment-721537988 **[Test build #130584 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130584/testReport)** for PR 30242 at commit

[GitHub] [spark] SparkQA commented on pull request #30245: [WIP][SPARK-33337][SQL] Support subexpression elimination in branches of conditional expressions

2020-11-03 Thread GitBox
SparkQA commented on pull request #30245: URL: https://github.com/apache/spark/pull/30245#issuecomment-721537711 **[Test build #130592 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130592/testReport)** for PR 30245 at commit

[GitHub] [spark] LuciferYang edited a comment on pull request #30234: [SPARK-33285][CORE][SQL] Fix deprecated compilation warnings of "Auto-application to () is deprecated" in Scala 2.13

2020-11-03 Thread GitBox
LuciferYang edited a comment on pull request #30234: URL: https://github.com/apache/spark/pull/30234#issuecomment-721533492 > After this PR, do we have a way to prevent this compilation warnings? Let me take a look at this problem. Maybe we can change the alarm level of the compiler

[GitHub] [spark] viirya commented on a change in pull request #30245: [WIP][SPARK-33337][SQL] Support subexpression elimination in branches of conditional expressions

2020-11-03 Thread GitBox
viirya commented on a change in pull request #30245: URL: https://github.com/apache/spark/pull/30245#discussion_r517120205 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/SubexpressionEliminationSuite.scala ## @@ -149,17 +149,43 @@ class

[GitHub] [spark] LuciferYang edited a comment on pull request #30234: [SPARK-33285][CORE][SQL] Fix deprecated compilation warnings of "Auto-application to () is deprecated" in Scala 2.13

2020-11-03 Thread GitBox
LuciferYang edited a comment on pull request #30234: URL: https://github.com/apache/spark/pull/30234#issuecomment-721533492 > After this PR, do we have a way to prevent this compilation warnings? Let me take a look at this problem. Maybe we can change the alarm level of the compiler

[GitHub] [spark] viirya commented on a change in pull request #30245: [WIP][SPARK-33337][SQL] Support subexpression elimination in branches of conditional expressions

2020-11-03 Thread GitBox
viirya commented on a change in pull request #30245: URL: https://github.com/apache/spark/pull/30245#discussion_r517120205 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/SubexpressionEliminationSuite.scala ## @@ -149,17 +149,43 @@ class

[GitHub] [spark] viirya opened a new pull request #30245: [WIP][SPARK-33337][SQL] Support subexpression elimination in branches of conditional expressions

2020-11-03 Thread GitBox
viirya opened a new pull request #30245: URL: https://github.com/apache/spark/pull/30245 ### What changes were proposed in this pull request? Currently we skip subexpression elimination in branches of conditional expressions including `If`, `CaseWhen`, and

[GitHub] [spark] ahshahid commented on pull request #30185: [SPARK-33152][SQL] This PR proposes a new logic to maintain & track constraints which solves the OOM or performance issues in query compilat

2020-11-03 Thread GitBox
ahshahid commented on pull request #30185: URL: https://github.com/apache/spark/pull/30185#issuecomment-721536710 i will fix the scala 2.13 issue This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30244: [WIP][SPARK-33282] Migrate from dead probot autolabeler to GitHub labeler action

2020-11-03 Thread GitBox
AmplabJenkins removed a comment on pull request #30244: URL: https://github.com/apache/spark/pull/30244#issuecomment-721521860 Can one of the admins verify this patch? This is an automated message from the Apache Git

[GitHub] [spark] SparkQA commented on pull request #30244: [WIP][SPARK-33282] Migrate from dead probot autolabeler to GitHub labeler action

2020-11-03 Thread GitBox
SparkQA commented on pull request #30244: URL: https://github.com/apache/spark/pull/30244#issuecomment-721534664 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35192/

[GitHub] [spark] LuciferYang commented on pull request #30234: [SPARK-33285][CORE][SQL] Fix deprecated compilation warnings of "Auto-application to () is deprecated" in Scala 2.13

2020-11-03 Thread GitBox
LuciferYang commented on pull request #30234: URL: https://github.com/apache/spark/pull/30234#issuecomment-721533492 > After this PR, do we have a way to prevent this compilation warnings? Let me take a look at it. Maybe we can change the alarm level of the compiler or check-style

[GitHub] [spark] AmplabJenkins commented on pull request #30166: [SPARK-33265][TEST] Rename classOf[Seq] to classOf[scala.collection.Seq] in PostgresIntegrationSuite for Scala 2.13

2020-11-03 Thread GitBox
AmplabJenkins commented on pull request #30166: URL: https://github.com/apache/spark/pull/30166#issuecomment-721531572 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30166: [SPARK-33265][TEST] Rename classOf[Seq] to classOf[scala.collection.Seq] in PostgresIntegrationSuite for Scala 2.13

2020-11-03 Thread GitBox
AmplabJenkins removed a comment on pull request #30166: URL: https://github.com/apache/spark/pull/30166#issuecomment-721531572 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #30242: [SPARK-33277][PYSPARK][SQL][FOLLOW-UP] Block TaskCompletion event until the thread ends.

2020-11-03 Thread GitBox
SparkQA commented on pull request #30242: URL: https://github.com/apache/spark/pull/30242#issuecomment-721531130 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35191/

[GitHub] [spark] SparkQA commented on pull request #30166: [SPARK-33265][TEST] Rename classOf[Seq] to classOf[scala.collection.Seq] in PostgresIntegrationSuite for Scala 2.13

2020-11-03 Thread GitBox
SparkQA commented on pull request #30166: URL: https://github.com/apache/spark/pull/30166#issuecomment-721530641 **[Test build #130587 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130587/testReport)** for PR 30166 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #30166: [SPARK-33265][TEST] Rename classOf[Seq] to classOf[scala.collection.Seq] in PostgresIntegrationSuite for Scala 2.13

2020-11-03 Thread GitBox
SparkQA removed a comment on pull request #30166: URL: https://github.com/apache/spark/pull/30166#issuecomment-721488609 **[Test build #130587 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130587/testReport)** for PR 30166 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30122: [SPARK-33214][TEST][HIVE] Stop HiveExternalCatalogVersionsSuite from using a hard-coded location to store localized Spark binar

2020-11-03 Thread GitBox
AmplabJenkins removed a comment on pull request #30122: URL: https://github.com/apache/spark/pull/30122#issuecomment-721521859 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #30122: [SPARK-33214][TEST][HIVE] Stop HiveExternalCatalogVersionsSuite from using a hard-coded location to store localized Spark binaries.

2020-11-03 Thread GitBox
AmplabJenkins commented on pull request #30122: URL: https://github.com/apache/spark/pull/30122#issuecomment-721521859 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #30244: [SPARK-33282] Migrate from dead probot autolabeler to GitHub labeler action

2020-11-03 Thread GitBox
AmplabJenkins commented on pull request #30244: URL: https://github.com/apache/spark/pull/30244#issuecomment-721521860 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To

[GitHub] [spark] HyukjinKwon commented on pull request #30244: [SPARK-33282] Migrate from dead probot autolabeler to GitHub labeler action

2020-11-03 Thread GitBox
HyukjinKwon commented on pull request #30244: URL: https://github.com/apache/spark/pull/30244#issuecomment-721521439 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30244: [SPARK-33282] Migrate from dead probot autolabeler to GitHub labeler action

2020-11-03 Thread GitBox
AmplabJenkins removed a comment on pull request #30244: URL: https://github.com/apache/spark/pull/30244#issuecomment-721520106 Can one of the admins verify this patch? This is an automated message from the Apache Git

[GitHub] [spark] SparkQA removed a comment on pull request #30122: [SPARK-33214][TEST][HIVE] Stop HiveExternalCatalogVersionsSuite from using a hard-coded location to store localized Spark binaries.

2020-11-03 Thread GitBox
SparkQA removed a comment on pull request #30122: URL: https://github.com/apache/spark/pull/30122#issuecomment-721493878 **[Test build #130588 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130588/testReport)** for PR 30122 at commit

[GitHub] [spark] SparkQA commented on pull request #30122: [SPARK-33214][TEST][HIVE] Stop HiveExternalCatalogVersionsSuite from using a hard-coded location to store localized Spark binaries.

2020-11-03 Thread GitBox
SparkQA commented on pull request #30122: URL: https://github.com/apache/spark/pull/30122#issuecomment-721521320 **[Test build #130588 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130588/testReport)** for PR 30122 at commit

[GitHub] [spark] imback82 commented on a change in pull request #30229: [SPARK-33321][SQL] Migrate ANALYZE TABLE commands to use UnresolvedTableOrView to resolve the identifier

2020-11-03 Thread GitBox
imback82 commented on a change in pull request #30229: URL: https://github.com/apache/spark/pull/30229#discussion_r517105993 ## File path: sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2SQLSuite.scala ## @@ -2606,6 +2606,13 @@ class DataSourceV2SQLSuite

[GitHub] [spark] AmplabJenkins commented on pull request #30244: [SPARK-33282] Migrate from dead probot autolabeler to GitHub labeler action

2020-11-03 Thread GitBox
AmplabJenkins commented on pull request #30244: URL: https://github.com/apache/spark/pull/30244#issuecomment-721520106 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To

[GitHub] [spark] kbendick opened a new pull request #30244: [SPARK-33282] Migrate from dead probot autolabeler to GitHub labeler action

2020-11-03 Thread GitBox
kbendick opened a new pull request #30244: URL: https://github.com/apache/spark/pull/30244 ### What changes were proposed in this pull request? This PR removes the old Probot Autolabeler labeling configuration, as the probot autolabeler has been deprecated. I've updated the

[GitHub] [spark] cloud-fan commented on pull request #30154: [SPARK-32405][SQL] Apply table options while creating tables in JDBC Table Catalog

2020-11-03 Thread GitBox
cloud-fan commented on pull request #30154: URL: https://github.com/apache/spark/pull/30154#issuecomment-721519171 I think the principle is: when users specify some table properties, JDBC V2 should fail if the underlying database can't support the properties. I prefer a dialect API

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30243: [SPARK-33335][SQL] Support `array_contains_array` func

2020-11-03 Thread GitBox
AmplabJenkins removed a comment on pull request #30243: URL: https://github.com/apache/spark/pull/30243#issuecomment-721517967 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30243: [SPARK-33335][SQL] Support `array_contains_array` func

2020-11-03 Thread GitBox
AmplabJenkins removed a comment on pull request #30243: URL: https://github.com/apache/spark/pull/30243#issuecomment-721517959 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA commented on pull request #30242: [SPARK-33277][PYSPARK][SQL][FOLLOW-UP] Block TaskCompletion event until the thread ends.

2020-11-03 Thread GitBox
SparkQA commented on pull request #30242: URL: https://github.com/apache/spark/pull/30242#issuecomment-721517981 **[Test build #130591 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130591/testReport)** for PR 30242 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #30243: [SPARK-33335][SQL] Support `array_contains_array` func

2020-11-03 Thread GitBox
AmplabJenkins commented on pull request #30243: URL: https://github.com/apache/spark/pull/30243#issuecomment-721517959 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #30243: [SPARK-33335][SQL] Support `array_contains_array` func

2020-11-03 Thread GitBox
SparkQA commented on pull request #30243: URL: https://github.com/apache/spark/pull/30243#issuecomment-721517941 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35190/

[GitHub] [spark] SparkQA removed a comment on pull request #30242: [SPARK-33277][PYSPARK][SQL][FOLLOW-UP] Block TaskCompletion event until the thread ends.

2020-11-03 Thread GitBox
SparkQA removed a comment on pull request #30242: URL: https://github.com/apache/spark/pull/30242#issuecomment-721452935 **[Test build #130582 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130582/testReport)** for PR 30242 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30242: [SPARK-33277][PYSPARK][SQL][FOLLOW-UP] Block TaskCompletion event until the thread ends.

2020-11-03 Thread GitBox
AmplabJenkins removed a comment on pull request #30242: URL: https://github.com/apache/spark/pull/30242#issuecomment-721515943 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] cloud-fan commented on a change in pull request #30229: [SPARK-33321][SQL] Migrate ANALYZE TABLE commands to use UnresolvedTableOrView to resolve the identifier

2020-11-03 Thread GitBox
cloud-fan commented on a change in pull request #30229: URL: https://github.com/apache/spark/pull/30229#discussion_r517101470 ## File path: sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2SQLSuite.scala ## @@ -2606,6 +2606,13 @@ class DataSourceV2SQLSuite

[GitHub] [spark] AmplabJenkins commented on pull request #30242: [SPARK-33277][PYSPARK][SQL][FOLLOW-UP] Block TaskCompletion event until the thread ends.

2020-11-03 Thread GitBox
AmplabJenkins commented on pull request #30242: URL: https://github.com/apache/spark/pull/30242#issuecomment-721515943 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #30242: [SPARK-33277][PYSPARK][SQL][FOLLOW-UP] Block TaskCompletion event until the thread ends.

2020-11-03 Thread GitBox
SparkQA commented on pull request #30242: URL: https://github.com/apache/spark/pull/30242#issuecomment-721515404 **[Test build #130582 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130582/testReport)** for PR 30242 at commit

[GitHub] [spark] cloud-fan commented on a change in pull request #30229: [SPARK-33321][SQL] Migrate ANALYZE TABLE commands to use UnresolvedTableOrView to resolve the identifier

2020-11-03 Thread GitBox
cloud-fan commented on a change in pull request #30229: URL: https://github.com/apache/spark/pull/30229#discussion_r517100450 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala ## @@ -3249,18 +3249,23 @@ class AstBuilder(conf:

[GitHub] [spark] cloud-fan commented on a change in pull request #30203: [SPARK-33303][SQL] Deduplicate deterministic PythonUDF calls

2020-11-03 Thread GitBox
cloud-fan commented on a change in pull request #30203: URL: https://github.com/apache/spark/pull/30203#discussion_r517099242 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/python/ExtractPythonUDFs.scala ## @@ -218,13 +218,22 @@ object ExtractPythonUDFs

[GitHub] [spark] cloud-fan closed pull request #30230: [SPARK-33323][SQL] Add query resolved check before convert hive relation

2020-11-03 Thread GitBox
cloud-fan closed pull request #30230: URL: https://github.com/apache/spark/pull/30230 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [spark] cloud-fan commented on pull request #30230: [SPARK-33323][SQL] Add query resolved check before convert hive relation

2020-11-03 Thread GitBox
cloud-fan commented on pull request #30230: URL: https://github.com/apache/spark/pull/30230#issuecomment-721512840 thanks, merging to master! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30242: [SPARK-33277][PYSPARK][SQL][FOLLOW-UP] Block TaskCompletion event until the thread ends.

2020-11-03 Thread GitBox
AmplabJenkins removed a comment on pull request #30242: URL: https://github.com/apache/spark/pull/30242#issuecomment-721510623 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA commented on pull request #30242: [SPARK-33277][PYSPARK][SQL][FOLLOW-UP] Block TaskCompletion event until the thread ends.

2020-11-03 Thread GitBox
SparkQA commented on pull request #30242: URL: https://github.com/apache/spark/pull/30242#issuecomment-721510610 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35189/

[GitHub] [spark] AmplabJenkins commented on pull request #30242: [SPARK-33277][PYSPARK][SQL][FOLLOW-UP] Block TaskCompletion event until the thread ends.

2020-11-03 Thread GitBox
AmplabJenkins commented on pull request #30242: URL: https://github.com/apache/spark/pull/30242#issuecomment-721510614 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30242: [SPARK-33277][PYSPARK][SQL][FOLLOW-UP] Block TaskCompletion event until the thread ends.

2020-11-03 Thread GitBox
AmplabJenkins removed a comment on pull request #30242: URL: https://github.com/apache/spark/pull/30242#issuecomment-721510614 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30122: [SPARK-33214][TEST][HIVE] Stop HiveExternalCatalogVersionsSuite from using a hard-coded location to store localized Spark binar

2020-11-03 Thread GitBox
AmplabJenkins removed a comment on pull request #30122: URL: https://github.com/apache/spark/pull/30122#issuecomment-721509935 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA commented on pull request #30243: [SPARK-33335][SQL] Support `array_contains_array` func

2020-11-03 Thread GitBox
SparkQA commented on pull request #30243: URL: https://github.com/apache/spark/pull/30243#issuecomment-721510264 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35190/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30122: [SPARK-33214][TEST][HIVE] Stop HiveExternalCatalogVersionsSuite from using a hard-coded location to store localized Spark binar

2020-11-03 Thread GitBox
AmplabJenkins removed a comment on pull request #30122: URL: https://github.com/apache/spark/pull/30122#issuecomment-721509927 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA commented on pull request #30122: [SPARK-33214][TEST][HIVE] Stop HiveExternalCatalogVersionsSuite from using a hard-coded location to store localized Spark binaries.

2020-11-03 Thread GitBox
SparkQA commented on pull request #30122: URL: https://github.com/apache/spark/pull/30122#issuecomment-721509917 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35188/

[GitHub] [spark] AmplabJenkins commented on pull request #30122: [SPARK-33214][TEST][HIVE] Stop HiveExternalCatalogVersionsSuite from using a hard-coded location to store localized Spark binaries.

2020-11-03 Thread GitBox
AmplabJenkins commented on pull request #30122: URL: https://github.com/apache/spark/pull/30122#issuecomment-721509927 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] cloud-fan commented on a change in pull request #30229: [SPARK-33321][SQL] Migrate ANALYZE TABLE commands to use UnresolvedTableOrView to resolve the identifier

2020-11-03 Thread GitBox
cloud-fan commented on a change in pull request #30229: URL: https://github.com/apache/spark/pull/30229#discussion_r517095433 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Strategy.scala ## @@ -280,6 +280,9 @@ class

[GitHub] [spark] cloud-fan commented on a change in pull request #30222: [SPARK-33315][SQL] Simplify CaseWhen with EqualTo

2020-11-03 Thread GitBox
cloud-fan commented on a change in pull request #30222: URL: https://github.com/apache/spark/pull/30222#discussion_r517095107 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala ## @@ -510,6 +510,10 @@ object

  1   2   3   4   5   6   7   >