huaxingao commented on a change in pull request #30154:
URL: https://github.com/apache/spark/pull/30154#discussion_r517154290
##
File path: sql/core/src/main/scala/org/apache/spark/sql/jdbc/DerbyDialect.scala
##
@@ -50,4 +50,17 @@ private object DerbyDialect extends
otterc commented on pull request #30062:
URL: https://github.com/apache/spark/pull/30062#issuecomment-721567210
I ran an end-to-end test. One of the bugs was:
```
Caused by: java.lang.IndexOutOfBoundsException
at java.nio.ByteBuffer.wrap(ByteBuffer.java:375)
at
SparkQA commented on pull request #30062:
URL: https://github.com/apache/spark/pull/30062#issuecomment-721566228
**[Test build #130595 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130595/testReport)**
for PR 30062 at commit
HeartSaVioR commented on a change in pull request #30203:
URL: https://github.com/apache/spark/pull/30203#discussion_r517144041
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/python/ExtractPythonUDFs.scala
##
@@ -218,13 +218,22 @@ object
AmplabJenkins removed a comment on pull request #30242:
URL: https://github.com/apache/spark/pull/30242#issuecomment-721562547
This is an automated message from the Apache Git Service.
To respond to the message, please log on
SparkQA commented on pull request #30243:
URL: https://github.com/apache/spark/pull/30243#issuecomment-721563148
**[Test build #130594 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130594/testReport)**
for PR 30243 at commit
AmplabJenkins commented on pull request #30242:
URL: https://github.com/apache/spark/pull/30242#issuecomment-721562547
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #30242:
URL: https://github.com/apache/spark/pull/30242#issuecomment-721561669
**[Test build #130586 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130586/testReport)**
for PR 30242 at commit
SparkQA removed a comment on pull request #30242:
URL: https://github.com/apache/spark/pull/30242#issuecomment-721486742
**[Test build #130586 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130586/testReport)**
for PR 30242 at commit
AmplabJenkins removed a comment on pull request #30245:
URL: https://github.com/apache/spark/pull/30245#issuecomment-721561406
This is an automated message from the Apache Git Service.
To respond to the message, please log on
SparkQA commented on pull request #30245:
URL: https://github.com/apache/spark/pull/30245#issuecomment-721561387
Kubernetes integration test status success
URL:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35193/
AmplabJenkins commented on pull request #30245:
URL: https://github.com/apache/spark/pull/30245#issuecomment-721561406
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #30245:
URL: https://github.com/apache/spark/pull/30245#issuecomment-721557561
**[Test build #130593 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130593/testReport)**
for PR 30245 at commit
AmplabJenkins removed a comment on pull request #30243:
URL: https://github.com/apache/spark/pull/30243#issuecomment-721555499
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
AmplabJenkins removed a comment on pull request #30243:
URL: https://github.com/apache/spark/pull/30243#issuecomment-721555493
Merged build finished. Test FAILed.
This is an automated message from the Apache Git Service.
To
SparkQA removed a comment on pull request #30243:
URL: https://github.com/apache/spark/pull/30243#issuecomment-721500664
**[Test build #130590 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130590/testReport)**
for PR 30243 at commit
cloud-fan commented on a change in pull request #30154:
URL: https://github.com/apache/spark/pull/30154#discussion_r517135283
##
File path: sql/core/src/main/scala/org/apache/spark/sql/jdbc/DerbyDialect.scala
##
@@ -50,4 +50,17 @@ private object DerbyDialect extends
cloud-fan commented on a change in pull request #30154:
URL: https://github.com/apache/spark/pull/30154#discussion_r517135401
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/jdbc/JDBCTableCatalog.scala
##
@@ -117,14 +117,33 @@ class
AmplabJenkins commented on pull request #30243:
URL: https://github.com/apache/spark/pull/30243#issuecomment-721555493
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #30243:
URL: https://github.com/apache/spark/pull/30243#issuecomment-721555042
**[Test build #130590 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130590/testReport)**
for PR 30243 at commit
AmplabJenkins removed a comment on pull request #30245:
URL: https://github.com/apache/spark/pull/30245#issuecomment-721553355
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
SparkQA removed a comment on pull request #30245:
URL: https://github.com/apache/spark/pull/30245#issuecomment-721537711
**[Test build #130592 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130592/testReport)**
for PR 30245 at commit
AmplabJenkins commented on pull request #30245:
URL: https://github.com/apache/spark/pull/30245#issuecomment-721553348
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #30245:
URL: https://github.com/apache/spark/pull/30245#issuecomment-721553472
Kubernetes integration test starting
URL:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35193/
AmplabJenkins removed a comment on pull request #30245:
URL: https://github.com/apache/spark/pull/30245#issuecomment-721553348
Merged build finished. Test FAILed.
This is an automated message from the Apache Git Service.
To
SparkQA commented on pull request #30245:
URL: https://github.com/apache/spark/pull/30245#issuecomment-721553230
**[Test build #130592 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130592/testReport)**
for PR 30245 at commit
cloud-fan commented on a change in pull request #29837:
URL: https://github.com/apache/spark/pull/29837#discussion_r517131842
##
File path: docs/sql-ref-datatypes.md
##
@@ -314,3 +314,206 @@ SELECT COUNT(*), c2 FROM test GROUP BY c2;
|3| Infinity|
huaxingao commented on pull request #30154:
URL: https://github.com/apache/spark/pull/30154#issuecomment-721550399
> Does it conflict with the dialect API to generate CREATE TABLE statement?
No, it doesn't conflict with the dialect API to generate CREATE TABLE
statement. The table
dongjoon-hyun commented on pull request #30240:
URL: https://github.com/apache/spark/pull/30240#issuecomment-721548555
Thank you so much, @viirya !
This is an automated message from the Apache Git Service.
To respond to the
cloud-fan closed pull request #30122:
URL: https://github.com/apache/spark/pull/30122
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
cloud-fan closed pull request #30229:
URL: https://github.com/apache/spark/pull/30229
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
cloud-fan commented on pull request #30122:
URL: https://github.com/apache/spark/pull/30122#issuecomment-721546906
thanks, merging to master!
This is an automated message from the Apache Git Service.
To respond to the
cloud-fan commented on pull request #30229:
URL: https://github.com/apache/spark/pull/30229#issuecomment-721546392
thanks, merging to master!
This is an automated message from the Apache Git Service.
To respond to the
cloud-fan commented on a change in pull request #30229:
URL: https://github.com/apache/spark/pull/30229#discussion_r517127493
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
##
@@ -3249,18 +3249,23 @@ class AstBuilder(conf:
cloud-fan commented on pull request #30154:
URL: https://github.com/apache/spark/pull/30154#issuecomment-721545793
> ... send properties to underlying databases and let databases decide
whether to fail the CREATE TALBE or not
This works. Does it conflict with the dialect API to
cloud-fan commented on a change in pull request #29837:
URL: https://github.com/apache/spark/pull/29837#discussion_r517125806
##
File path: docs/sql-ref-datatypes.md
##
@@ -314,3 +314,206 @@ SELECT COUNT(*), c2 FROM test GROUP BY c2;
|3| Infinity|
huaxingao commented on pull request #30154:
URL: https://github.com/apache/spark/pull/30154#issuecomment-721542287
> when users specify some table properties, JDBC V2 should fail if the
underlying database can't support the properties.
I agree JDBC V2 should fail if the underlying
AmplabJenkins removed a comment on pull request #30244:
URL: https://github.com/apache/spark/pull/30244#issuecomment-721542255
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #30244:
URL: https://github.com/apache/spark/pull/30244#issuecomment-721542255
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #30244:
URL: https://github.com/apache/spark/pull/30244#issuecomment-721542243
Kubernetes integration test status success
URL:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35192/
viirya closed pull request #30240:
URL: https://github.com/apache/spark/pull/30240
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
AmplabJenkins removed a comment on pull request #30242:
URL: https://github.com/apache/spark/pull/30242#issuecomment-721539621
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #30242:
URL: https://github.com/apache/spark/pull/30242#issuecomment-721539621
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #30242:
URL: https://github.com/apache/spark/pull/30242#issuecomment-721539609
Kubernetes integration test status success
URL:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35191/
AmplabJenkins removed a comment on pull request #30242:
URL: https://github.com/apache/spark/pull/30242#issuecomment-721538733
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #30242:
URL: https://github.com/apache/spark/pull/30242#issuecomment-721538733
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
viirya commented on pull request #30240:
URL: https://github.com/apache/spark/pull/30240#issuecomment-721538642
Thanks. Merging to branch-3.0.
This is an automated message from the Apache Git Service.
To respond to the
SparkQA removed a comment on pull request #30242:
URL: https://github.com/apache/spark/pull/30242#issuecomment-721472000
**[Test build #130584 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130584/testReport)**
for PR 30242 at commit
SparkQA commented on pull request #30242:
URL: https://github.com/apache/spark/pull/30242#issuecomment-721537988
**[Test build #130584 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130584/testReport)**
for PR 30242 at commit
SparkQA commented on pull request #30245:
URL: https://github.com/apache/spark/pull/30245#issuecomment-721537711
**[Test build #130592 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130592/testReport)**
for PR 30245 at commit
LuciferYang edited a comment on pull request #30234:
URL: https://github.com/apache/spark/pull/30234#issuecomment-721533492
> After this PR, do we have a way to prevent this compilation warnings?
Let me take a look at this problem. Maybe we can change the alarm level of
the compiler
viirya commented on a change in pull request #30245:
URL: https://github.com/apache/spark/pull/30245#discussion_r517120205
##
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/SubexpressionEliminationSuite.scala
##
@@ -149,17 +149,43 @@ class
LuciferYang edited a comment on pull request #30234:
URL: https://github.com/apache/spark/pull/30234#issuecomment-721533492
> After this PR, do we have a way to prevent this compilation warnings?
Let me take a look at this problem. Maybe we can change the alarm level of
the compiler
viirya commented on a change in pull request #30245:
URL: https://github.com/apache/spark/pull/30245#discussion_r517120205
##
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/SubexpressionEliminationSuite.scala
##
@@ -149,17 +149,43 @@ class
viirya opened a new pull request #30245:
URL: https://github.com/apache/spark/pull/30245
### What changes were proposed in this pull request?
Currently we skip subexpression elimination in branches of conditional
expressions including `If`, `CaseWhen`, and
ahshahid commented on pull request #30185:
URL: https://github.com/apache/spark/pull/30185#issuecomment-721536710
i will fix the scala 2.13 issue
This is an automated message from the Apache Git Service.
To respond to the
AmplabJenkins removed a comment on pull request #30244:
URL: https://github.com/apache/spark/pull/30244#issuecomment-721521860
Can one of the admins verify this patch?
This is an automated message from the Apache Git
SparkQA commented on pull request #30244:
URL: https://github.com/apache/spark/pull/30244#issuecomment-721534664
Kubernetes integration test starting
URL:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35192/
LuciferYang commented on pull request #30234:
URL: https://github.com/apache/spark/pull/30234#issuecomment-721533492
> After this PR, do we have a way to prevent this compilation warnings?
Let me take a look at it. Maybe we can change the alarm level of the
compiler or check-style
AmplabJenkins commented on pull request #30166:
URL: https://github.com/apache/spark/pull/30166#issuecomment-721531572
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #30166:
URL: https://github.com/apache/spark/pull/30166#issuecomment-721531572
This is an automated message from the Apache Git Service.
To respond to the message, please log on
SparkQA commented on pull request #30242:
URL: https://github.com/apache/spark/pull/30242#issuecomment-721531130
Kubernetes integration test starting
URL:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35191/
SparkQA commented on pull request #30166:
URL: https://github.com/apache/spark/pull/30166#issuecomment-721530641
**[Test build #130587 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130587/testReport)**
for PR 30166 at commit
SparkQA removed a comment on pull request #30166:
URL: https://github.com/apache/spark/pull/30166#issuecomment-721488609
**[Test build #130587 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130587/testReport)**
for PR 30166 at commit
AmplabJenkins removed a comment on pull request #30122:
URL: https://github.com/apache/spark/pull/30122#issuecomment-721521859
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #30122:
URL: https://github.com/apache/spark/pull/30122#issuecomment-721521859
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins commented on pull request #30244:
URL: https://github.com/apache/spark/pull/30244#issuecomment-721521860
Can one of the admins verify this patch?
This is an automated message from the Apache Git Service.
To
HyukjinKwon commented on pull request #30244:
URL: https://github.com/apache/spark/pull/30244#issuecomment-721521439
ok to test
This is an automated message from the Apache Git Service.
To respond to the message, please log
AmplabJenkins removed a comment on pull request #30244:
URL: https://github.com/apache/spark/pull/30244#issuecomment-721520106
Can one of the admins verify this patch?
This is an automated message from the Apache Git
SparkQA removed a comment on pull request #30122:
URL: https://github.com/apache/spark/pull/30122#issuecomment-721493878
**[Test build #130588 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130588/testReport)**
for PR 30122 at commit
SparkQA commented on pull request #30122:
URL: https://github.com/apache/spark/pull/30122#issuecomment-721521320
**[Test build #130588 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130588/testReport)**
for PR 30122 at commit
imback82 commented on a change in pull request #30229:
URL: https://github.com/apache/spark/pull/30229#discussion_r517105993
##
File path:
sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2SQLSuite.scala
##
@@ -2606,6 +2606,13 @@ class DataSourceV2SQLSuite
AmplabJenkins commented on pull request #30244:
URL: https://github.com/apache/spark/pull/30244#issuecomment-721520106
Can one of the admins verify this patch?
This is an automated message from the Apache Git Service.
To
kbendick opened a new pull request #30244:
URL: https://github.com/apache/spark/pull/30244
### What changes were proposed in this pull request?
This PR removes the old Probot Autolabeler labeling configuration, as the
probot autolabeler has been deprecated. I've updated the
cloud-fan commented on pull request #30154:
URL: https://github.com/apache/spark/pull/30154#issuecomment-721519171
I think the principle is: when users specify some table properties, JDBC V2
should fail if the underlying database can't support the properties.
I prefer a dialect API
AmplabJenkins removed a comment on pull request #30243:
URL: https://github.com/apache/spark/pull/30243#issuecomment-721517967
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
AmplabJenkins removed a comment on pull request #30243:
URL: https://github.com/apache/spark/pull/30243#issuecomment-721517959
Merged build finished. Test FAILed.
This is an automated message from the Apache Git Service.
To
SparkQA commented on pull request #30242:
URL: https://github.com/apache/spark/pull/30242#issuecomment-721517981
**[Test build #130591 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130591/testReport)**
for PR 30242 at commit
AmplabJenkins commented on pull request #30243:
URL: https://github.com/apache/spark/pull/30243#issuecomment-721517959
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #30243:
URL: https://github.com/apache/spark/pull/30243#issuecomment-721517941
Kubernetes integration test status failure
URL:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35190/
SparkQA removed a comment on pull request #30242:
URL: https://github.com/apache/spark/pull/30242#issuecomment-721452935
**[Test build #130582 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130582/testReport)**
for PR 30242 at commit
AmplabJenkins removed a comment on pull request #30242:
URL: https://github.com/apache/spark/pull/30242#issuecomment-721515943
This is an automated message from the Apache Git Service.
To respond to the message, please log on
cloud-fan commented on a change in pull request #30229:
URL: https://github.com/apache/spark/pull/30229#discussion_r517101470
##
File path:
sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2SQLSuite.scala
##
@@ -2606,6 +2606,13 @@ class DataSourceV2SQLSuite
AmplabJenkins commented on pull request #30242:
URL: https://github.com/apache/spark/pull/30242#issuecomment-721515943
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #30242:
URL: https://github.com/apache/spark/pull/30242#issuecomment-721515404
**[Test build #130582 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130582/testReport)**
for PR 30242 at commit
cloud-fan commented on a change in pull request #30229:
URL: https://github.com/apache/spark/pull/30229#discussion_r517100450
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
##
@@ -3249,18 +3249,23 @@ class AstBuilder(conf:
cloud-fan commented on a change in pull request #30203:
URL: https://github.com/apache/spark/pull/30203#discussion_r517099242
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/python/ExtractPythonUDFs.scala
##
@@ -218,13 +218,22 @@ object ExtractPythonUDFs
cloud-fan closed pull request #30230:
URL: https://github.com/apache/spark/pull/30230
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
cloud-fan commented on pull request #30230:
URL: https://github.com/apache/spark/pull/30230#issuecomment-721512840
thanks, merging to master!
This is an automated message from the Apache Git Service.
To respond to the
AmplabJenkins removed a comment on pull request #30242:
URL: https://github.com/apache/spark/pull/30242#issuecomment-721510623
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
SparkQA commented on pull request #30242:
URL: https://github.com/apache/spark/pull/30242#issuecomment-721510610
Kubernetes integration test status failure
URL:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35189/
AmplabJenkins commented on pull request #30242:
URL: https://github.com/apache/spark/pull/30242#issuecomment-721510614
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #30242:
URL: https://github.com/apache/spark/pull/30242#issuecomment-721510614
Merged build finished. Test FAILed.
This is an automated message from the Apache Git Service.
To
AmplabJenkins removed a comment on pull request #30122:
URL: https://github.com/apache/spark/pull/30122#issuecomment-721509935
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
SparkQA commented on pull request #30243:
URL: https://github.com/apache/spark/pull/30243#issuecomment-721510264
Kubernetes integration test starting
URL:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35190/
AmplabJenkins removed a comment on pull request #30122:
URL: https://github.com/apache/spark/pull/30122#issuecomment-721509927
Merged build finished. Test FAILed.
This is an automated message from the Apache Git Service.
To
SparkQA commented on pull request #30122:
URL: https://github.com/apache/spark/pull/30122#issuecomment-721509917
Kubernetes integration test status failure
URL:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35188/
AmplabJenkins commented on pull request #30122:
URL: https://github.com/apache/spark/pull/30122#issuecomment-721509927
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
cloud-fan commented on a change in pull request #30229:
URL: https://github.com/apache/spark/pull/30229#discussion_r517095433
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Strategy.scala
##
@@ -280,6 +280,9 @@ class
cloud-fan commented on a change in pull request #30222:
URL: https://github.com/apache/spark/pull/30222#discussion_r517095107
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
##
@@ -510,6 +510,10 @@ object
1 - 100 of 680 matches
Mail list logo