[GitHub] spark pull request: [SPARK-8199][SPARK-8184][SPARK-8183][SPARK-818...

2015-07-18 Thread jendap
Github user jendap commented on the pull request: https://github.com/apache/spark/pull/6981#issuecomment-122597354 How about leap seconds? Are those overlooked or intentionally ignored? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-9015] [BUILD] Clean project import in s...

2015-07-16 Thread jendap
Github user jendap commented on the pull request: https://github.com/apache/spark/pull/7375#issuecomment-122036687 thanks @srowen --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-9015] [BUILD] Clean project import in s...

2015-07-15 Thread jendap
Github user jendap commented on the pull request: https://github.com/apache/spark/pull/7375#issuecomment-121709635 Sure! Whitespaces are fixed now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-9015] [BUILD] Clean project import in s...

2015-07-14 Thread jendap
Github user jendap commented on the pull request: https://github.com/apache/spark/pull/7375#issuecomment-121159798 It does work without lifecycle-mapping but it shows errors. Not just after import but all the way until you resolve them. It is not needed. On the other hand

[GitHub] spark pull request: [SPARK-9015] [BUILD] Clean project import in s...

2015-07-14 Thread jendap
Github user jendap commented on the pull request: https://github.com/apache/spark/pull/7375#issuecomment-121165242 I can see you do not want to add any extra line to the pom file :-) I think the build should primary work. Batteries included. For that reason we should merge

[GitHub] spark pull request: [SPARK-9015] [BUILD] Clean project import in s...

2015-07-14 Thread jendap
Github user jendap commented on the pull request: https://github.com/apache/spark/pull/7375#issuecomment-121170538 None of those are part of this PR. We should take that discussion elsewhere. BTW: I have a prototype solving the artifactId conventions inside maven

[GitHub] spark pull request: [SPARK-9015] [BUILD] Clean project import in s...

2015-07-14 Thread jendap
Github user jendap commented on the pull request: https://github.com/apache/spark/pull/7375#issuecomment-121340118 @srowen do you understand what is going on with the builds? 3 failed builds is pretty convincing argument something is not ok. But looking at their output - 3 build 3

[GitHub] spark pull request: [SPARK-9015] [BUILD] Clean project import in s...

2015-07-13 Thread jendap
GitHub user jendap opened a pull request: https://github.com/apache/spark/pull/7375 [SPARK-9015] [BUILD] Clean project import in scala ide Cleanup maven for a clean import in scala-ide / eclipse. * remove groovy plugin which is really not needed at all * add-source from

[GitHub] spark pull request: [SPARK-9015] [BUILD] Clean project import in s...

2015-07-13 Thread jendap
Github user jendap commented on a diff in the pull request: https://github.com/apache/spark/pull/7375#discussion_r34496993 --- Diff: core/src/test/java/org/apache/spark/JavaAPISuite.java --- @@ -63,6 +63,7 @@ // The test suite itself is Serializable so that anonymous Function

[GitHub] spark pull request: [SPARK-9015] [BUILD] Clean project import in s...

2015-07-13 Thread jendap
Github user jendap commented on a diff in the pull request: https://github.com/apache/spark/pull/7375#discussion_r34496608 --- Diff: pom.xml --- @@ -1406,6 +1382,59 @@ artifactIdmaven-deploy-plugin/artifactId version2.8.2/version /plugin

[GitHub] spark pull request: [SPARK-9015] [BUILD] Clean project import in s...

2015-07-13 Thread jendap
Github user jendap commented on the pull request: https://github.com/apache/spark/pull/7375#issuecomment-121022250 I have double checked all this with mvn install. It generates exactly the same output in local repo - bit by bit - with exception of the pom xml and property files

[GitHub] spark pull request: [SPARK-9015] [BUILD] Clean project import in s...

2015-07-13 Thread jendap
Github user jendap commented on a diff in the pull request: https://github.com/apache/spark/pull/7375#discussion_r34502106 --- Diff: core/src/test/java/org/apache/spark/JavaAPISuite.java --- @@ -63,6 +63,7 @@ // The test suite itself is Serializable so that anonymous Function

[GitHub] spark pull request: [SPARK-9015] [BUILD] Clean project import in s...

2015-07-13 Thread jendap
Github user jendap commented on a diff in the pull request: https://github.com/apache/spark/pull/7375#discussion_r34498770 --- Diff: core/src/test/java/org/apache/spark/JavaAPISuite.java --- @@ -63,6 +63,7 @@ // The test suite itself is Serializable so that anonymous Function

[GitHub] spark pull request: [SPARK-9015] [BUILD] Clean project import in s...

2015-07-13 Thread jendap
Github user jendap commented on a diff in the pull request: https://github.com/apache/spark/pull/7375#discussion_r34500353 --- Diff: sql/hive/pom.xml --- @@ -133,7 +133,6 @@ /goals configuration sources

[GitHub] spark pull request: [SPARK-9015] [BUILD] Clean project import in s...

2015-07-13 Thread jendap
Github user jendap commented on a diff in the pull request: https://github.com/apache/spark/pull/7375#discussion_r34492757 --- Diff: core/src/test/java/org/apache/spark/JavaAPISuite.java --- @@ -63,6 +63,7 @@ // The test suite itself is Serializable so that anonymous Function

[GitHub] spark pull request: [SPARK-9015] [BUILD] Clean project import in s...

2015-07-13 Thread jendap
Github user jendap commented on a diff in the pull request: https://github.com/apache/spark/pull/7375#discussion_r34493238 --- Diff: pom.xml --- @@ -1406,6 +1382,59 @@ artifactIdmaven-deploy-plugin/artifactId version2.8.2/version /plugin

[GitHub] spark pull request: [SPARK-9015] [BUILD] Clean project import in s...

2015-07-13 Thread jendap
Github user jendap commented on a diff in the pull request: https://github.com/apache/spark/pull/7375#discussion_r34493745 --- Diff: pom.xml --- @@ -1423,34 +1452,12 @@ /goals configuration includeScopetest/includeScope

[GitHub] spark pull request: [SPARK-9015] [BUILD] Clean project import in s...

2015-07-13 Thread jendap
Github user jendap commented on a diff in the pull request: https://github.com/apache/spark/pull/7375#discussion_r34494500 --- Diff: pom.xml --- @@ -1518,36 +1525,6 @@ artifactIdmaven-enforcer-plugin/artifactId /plugin plugin