[GitHub] spark issue #20884: [SPARK-23773][SQL] JacksonGenerator does not include key...

2018-06-29 Thread sameeragarwal
Github user sameeragarwal commented on the issue: https://github.com/apache/spark/pull/20884 @HyukjinKwon I think it should be okay to close this at least for now. Just to add a little context behind this change, Facebook relies on the `toJSON` method for cross engine (hive/presto

[GitHub] spark issue #21342: [SPARK-24294] Throw SparkException when OOM in Broadcast...

2018-05-16 Thread sameeragarwal
Github user sameeragarwal commented on the issue: https://github.com/apache/spark/pull/21342 LGTM, Thanks! I've seen variations of this bug in the past as well and am not aware of a better way to fix this issue. ```scala scala> Await.result(Future(throw

[GitHub] spark pull request #20884: [SPARK-23773][SQL] JacksonGenerator does not incl...

2018-03-23 Thread sameeragarwal
Github user sameeragarwal commented on a diff in the pull request: https://github.com/apache/spark/pull/20884#discussion_r176796998 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/json/JacksonGeneratorSuite.scala --- @@ -56,7 +56,7 @@ class

[GitHub] spark issue #20884: [SPARK-23773][SQL] JacksonGenerator does not include key...

2018-03-22 Thread sameeragarwal
Github user sameeragarwal commented on the issue: https://github.com/apache/spark/pull/20884 ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark issue #20644: [SPARK-23470][ui] Use first attempt of last stage to def...

2018-02-20 Thread sameeragarwal
Github user sameeragarwal commented on the issue: https://github.com/apache/spark/pull/20644 merging this to master/2.3. Thanks! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20568: [SPARK-23381][CORE] Murmur3 hash generates a different v...

2018-02-16 Thread sameeragarwal
Github user sameeragarwal commented on the issue: https://github.com/apache/spark/pull/20568 @hvanhovell just to make sure, given the dependency on `FeatureHasher`, should this block RC4? --- - To unsubscribe, e

[GitHub] spark issue #20584: [SPARK-23390][SQL] Flaky Test Suite: FileBasedDataSource...

2018-02-11 Thread sameeragarwal
Github user sameeragarwal commented on the issue: https://github.com/apache/spark/pull/20584 merging this to master/2.3. Thanks! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20584: [SPARK-23390][SQL] Flaky Test Suite: FileBasedDataSource...

2018-02-11 Thread sameeragarwal
Github user sameeragarwal commented on the issue: https://github.com/apache/spark/pull/20584 LGTM, seems plausible! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark issue #20492: [SPARK-23310][CORE] Turn off read ahead input stream for...

2018-02-05 Thread sameeragarwal
Github user sameeragarwal commented on the issue: https://github.com/apache/spark/pull/20492 merging this to master/2.3 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e

[GitHub] spark issue #20492: [SPARK-23310][CORE] Turn off read ahead input stream for...

2018-02-02 Thread sameeragarwal
Github user sameeragarwal commented on the issue: https://github.com/apache/spark/pull/20492 Just a minor comment, LGTM. Thanks! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #20492: [SPARK-23310][CORE] Turn off read ahead input str...

2018-02-02 Thread sameeragarwal
Github user sameeragarwal commented on a diff in the pull request: https://github.com/apache/spark/pull/20492#discussion_r165804011 --- Diff: core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeSorterSpillReader.java --- @@ -77,7 +77,7 @@ public

[GitHub] spark pull request #20231: [SPARK-23000][TEST-HADOOP2.6] Fix Flaky test suit...

2018-01-30 Thread sameeragarwal
Github user sameeragarwal closed the pull request at: https://github.com/apache/spark/pull/20231 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark issue #20427: [SPARK-23260][SPARK-23262][SQL] several data source v2 n...

2018-01-30 Thread sameeragarwal
Github user sameeragarwal commented on the issue: https://github.com/apache/spark/pull/20427 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark issue #20434: [SPARK-23267] [SQL] Increase spark.sql.codegen.hugeMetho...

2018-01-30 Thread sameeragarwal
Github user sameeragarwal commented on the issue: https://github.com/apache/spark/pull/20434 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark pull request #20434: [SPARK-23267] [SQL] Increase spark.sql.codegen.hu...

2018-01-30 Thread sameeragarwal
Github user sameeragarwal commented on a diff in the pull request: https://github.com/apache/spark/pull/20434#discussion_r164676771 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -660,12 +660,10 @@ object SQLConf { val

[GitHub] spark issue #20428: [SPARK-23261] [PySpark] Rename Pandas UDFs

2018-01-29 Thread sameeragarwal
Github user sameeragarwal commented on the issue: https://github.com/apache/spark/pull/20428 +1 on `GROUPED AGG` as well --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e

[GitHub] spark issue #20414: [SPARK-23243][SQL] Shuffle+Repartition on an RDD could l...

2018-01-29 Thread sameeragarwal
Github user sameeragarwal commented on the issue: https://github.com/apache/spark/pull/20414 Thanks @mridulm, all great points! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20399: [SPARK-23209][core] Allow credential manager to work whe...

2018-01-29 Thread sameeragarwal
Github user sameeragarwal commented on the issue: https://github.com/apache/spark/pull/20399 test this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark issue #20399: [SPARK-23209][core] Allow credential manager to work whe...

2018-01-29 Thread sameeragarwal
Github user sameeragarwal commented on the issue: https://github.com/apache/spark/pull/20399 @vanzin and reviewers -- is this ready to go? We're waiting on RC3 for this. Thanks! --- - To unsubscribe, e-mail

[GitHub] spark issue #20393: [SPARK-23207][SQL] Shuffle+Repartition on a DataFrame co...

2018-01-29 Thread sameeragarwal
Github user sameeragarwal commented on the issue: https://github.com/apache/spark/pull/20393 @mridulm one approach that Xingbo is looking into (independently of https://github.com/apache/spark/pull/20414) is to have the `ShuffleBlockFetcherIterator` remember the order of blocks

[GitHub] spark issue #20393: [SPARK-23207][SQL] Shuffle+Repartition on a DataFrame co...

2018-01-26 Thread sameeragarwal
Github user sameeragarwal commented on the issue: https://github.com/apache/spark/pull/20393 LGTM but we should get a broader consensus on this. In the meantime, I'm merging this patch to master/2.3

[GitHub] spark issue #20393: [SPARK-23207][SQL] Shuffle+Repartition on a DataFrame co...

2018-01-26 Thread sameeragarwal
Github user sameeragarwal commented on the issue: https://github.com/apache/spark/pull/20393 Another (possibly cleaner) approach here would be to make the shuffle block fetch order deterministic but I agree that it might not be safe to include it in 2.3 this late

[GitHub] spark issue #20393: [SPARK-23207][SQL] Shuffle+Repartition on an RDD/DataFra...

2018-01-25 Thread sameeragarwal
Github user sameeragarwal commented on the issue: https://github.com/apache/spark/pull/20393 LGTM, thanks! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews

[GitHub] spark issue #20393: [SPARK-23207][SQL] Shuffle+Repartition on an RDD/DataFra...

2018-01-25 Thread sameeragarwal
Github user sameeragarwal commented on the issue: https://github.com/apache/spark/pull/20393 Yes, this bug also applies to RDD repartition but the current fix doesn't cover this (the local sort approach would be quite similar but it'll be a completely different codepath

[GitHub] spark issue #20371: [SPARK-23197][DStreams] Increased timeouts to resolve fl...

2018-01-23 Thread sameeragarwal
Github user sameeragarwal commented on the issue: https://github.com/apache/spark/pull/20371 LGTM, pending jenkins. Thanks! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands

[GitHub] spark pull request #20371: [SPARK-23197][DStreams] Increased timeouts to res...

2018-01-23 Thread sameeragarwal
Github user sameeragarwal commented on a diff in the pull request: https://github.com/apache/spark/pull/20371#discussion_r163412164 --- Diff: streaming/src/test/scala/org/apache/spark/streaming/ReceiverSuite.scala --- @@ -105,13 +105,13 @@ class ReceiverSuite extends TestSuiteBase

[GitHub] spark issue #20368: [SPARK-23195] [SQL] Keep the Hint of Cached Data

2018-01-23 Thread sameeragarwal
Github user sameeragarwal commented on the issue: https://github.com/apache/spark/pull/20368 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark issue #20365: [SPARK-23192] [SQL] Keep the Hint after Using Cached Dat...

2018-01-23 Thread sameeragarwal
Github user sameeragarwal commented on the issue: https://github.com/apache/spark/pull/20365 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark issue #20299: [SPARK-23135][ui] Fix rendering of accumulators in the s...

2018-01-19 Thread sameeragarwal
Github user sameeragarwal commented on the issue: https://github.com/apache/spark/pull/20299 LGTM. Merging this to master/2.3. Thanks! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

[GitHub] spark issue #20297: [SPARK-23020][CORE] Fix races in launcher code, test.

2018-01-19 Thread sameeragarwal
Github user sameeragarwal commented on the issue: https://github.com/apache/spark/pull/20297 I've kicked a bunch of test builds in parallel to further rule out any flakiness on jenkins. Thanks! --- - To unsubscribe

[GitHub] spark issue #20323: [BUILD][MINOR] Fix java style check issues

2018-01-19 Thread sameeragarwal
Github user sameeragarwal commented on the issue: https://github.com/apache/spark/pull/20323 merging this to master/2.3. Thanks! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20323: [BUILD][MINOR] Fix java style check issues

2018-01-19 Thread sameeragarwal
Github user sameeragarwal commented on the issue: https://github.com/apache/spark/pull/20323 @dongjoon-hyun while I'm not opposed to adding another builder, my concern is that it's hard to justify spending 30+ mins for a simple java style check for every pull request (i.e., if we run

[GitHub] spark pull request #20323: [BUILD][MINOR] Fix java style check issues

2018-01-18 Thread sameeragarwal
GitHub user sameeragarwal opened a pull request: https://github.com/apache/spark/pull/20323 [BUILD][MINOR] Fix java style check issues ## What changes were proposed in this pull request? This patch fixes a few recently introduced java style check errors in master

[GitHub] spark issue #20291: [SPARK-23020] Ignore Flaky Test: SparkLauncherSuite.test...

2018-01-17 Thread sameeragarwal
Github user sameeragarwal commented on the issue: https://github.com/apache/spark/pull/20291 merging this to master/2.3 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e

[GitHub] spark pull request #20291: Ignore Flaky Test: SparkLauncherSuite.testInProce...

2018-01-17 Thread sameeragarwal
GitHub user sameeragarwal opened a pull request: https://github.com/apache/spark/pull/20291 Ignore Flaky Test: SparkLauncherSuite.testInProcessLauncher ## What changes were proposed in this pull request? Temporarily ignoring flaky test

[GitHub] spark issue #20223: [SPARK-23020][core] Fix races in launcher code, test.

2018-01-16 Thread sameeragarwal
Github user sameeragarwal commented on the issue: https://github.com/apache/spark/pull/20223 This patch unfortunately broke [`YarnClusterSuite.timeout to get SparkContext in cluster mode triggers failure`](https://amplab.cs.berkeley.edu/jenkins/view/Spark%20QA%20Test%20(Dashboard

[GitHub] spark issue #20223: [SPARK-23020][core] Fix races in launcher code, test.

2018-01-15 Thread sameeragarwal
Github user sameeragarwal commented on the issue: https://github.com/apache/spark/pull/20223 merging to master/2.3. Thanks! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands

[GitHub] spark issue #20273: [SPARK-23000] Use fully qualified table names in HiveMet...

2018-01-15 Thread sameeragarwal
Github user sameeragarwal commented on the issue: https://github.com/apache/spark/pull/20273 cc @gatorsmile --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark pull request #20273: [SPARK-23000] Use fully qualified table names in ...

2018-01-15 Thread sameeragarwal
GitHub user sameeragarwal opened a pull request: https://github.com/apache/spark/pull/20273 [SPARK-23000] Use fully qualified table names in HiveMetastoreCatalogSuite ## What changes were proposed in this pull request? In another attempt to fix

[GitHub] spark issue #20085: [SPARK-22739][Catalyst][WIP] Additional Expression Suppo...

2018-01-13 Thread sameeragarwal
Github user sameeragarwal commented on the issue: https://github.com/apache/spark/pull/20085 @bdrillard @viirya @cloud-fan are we still targeting this for 2.3? --- - To unsubscribe, e-mail: reviews-unsubscr

[GitHub] spark issue #20256: [SPARK-23063][K8S] K8s changes for publishing scripts (a...

2018-01-13 Thread sameeragarwal
Github user sameeragarwal commented on the issue: https://github.com/apache/spark/pull/20256 verified changes to the release scripts and a did simple grep check -- both LGTM. Thanks! --- - To unsubscribe, e-mail

[GitHub] spark issue #20242: [MINOR][BUILD] Fix Java linter errors

2018-01-12 Thread sameeragarwal
Github user sameeragarwal commented on the issue: https://github.com/apache/spark/pull/20242 I've also updated the relevant jenkins job configs to automatically check for this in future (e.g., see https://amplab.cs.berkeley.edu/jenkins/job/spark-branch-2.3-lint/113/console). Thanks

[GitHub] spark issue #20096: [SPARK-22908] Add kafka source and sink for continuous p...

2018-01-12 Thread sameeragarwal
Github user sameeragarwal commented on the issue: https://github.com/apache/spark/pull/20096 @jose-torres @zsxwing @tdas as discussed, this is causing a number of build timeouts. I'm going to revert this for now to de-flake the builds and we can add it back once it's fixed

[GitHub] spark issue #20242: [MINOR][BUILD] Fix Java linter errors

2018-01-12 Thread sameeragarwal
Github user sameeragarwal commented on the issue: https://github.com/apache/spark/pull/20242 merging to master/2.3. Thanks! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands

[GitHub] spark issue #20242: [MINOR][BUILD] Fix Java linter errors

2018-01-11 Thread sameeragarwal
Github user sameeragarwal commented on the issue: https://github.com/apache/spark/pull/20242 Thanks @dongwang218, LGTM It seems like the java linter checks are not included in https://amplab.cs.berkeley.edu/jenkins/job/spark-branch-2.3-lint/. I'll update the scripts so

[GitHub] spark issue #20231: [SPARK-23000][TEST-HADOOP2.6] Fix Flaky test suite DataS...

2018-01-11 Thread sameeragarwal
Github user sameeragarwal commented on the issue: https://github.com/apache/spark/pull/20231 test this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark pull request #20231: [SPARK-23000][TEST-HADOOP2.6] Fix Flaky test suit...

2018-01-11 Thread sameeragarwal
GitHub user sameeragarwal opened a pull request: https://github.com/apache/spark/pull/20231 [SPARK-23000][TEST-HADOOP2.6] Fix Flaky test suite DataSourceWithHiveMetastoreCatalogSuite in Spark 2.3 [WIP] ## What changes were proposed in this pull request? Another attempt

[GitHub] spark pull request #20218: [SPARK-23000] [TEST-HADOOP2.6] Fix Flaky test sui...

2018-01-10 Thread sameeragarwal
Github user sameeragarwal commented on a diff in the pull request: https://github.com/apache/spark/pull/20218#discussion_r160840909 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveMetastoreCatalogSuite.scala --- @@ -148,6 +148,7 @@ class

[GitHub] spark pull request #20218: [SPARK-23000] [TEST-HADOOP2.6] Fix Flaky test sui...

2018-01-10 Thread sameeragarwal
Github user sameeragarwal commented on a diff in the pull request: https://github.com/apache/spark/pull/20218#discussion_r160816667 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveMetastoreCatalogSuite.scala --- @@ -148,6 +148,7 @@ class

[GitHub] spark issue #20196: [SPARK-23000] Fix Flaky test suite DataSourceWithHiveMet...

2018-01-09 Thread sameeragarwal
Github user sameeragarwal commented on the issue: https://github.com/apache/spark/pull/20196 @gatorsmile unfortunately, this is still failing: https://amplab.cs.berkeley.edu/jenkins/job/spark-branch-2.3-test-sbt-hadoop-2.6

[GitHub] spark issue #20013: [SPARK-20657][core] Speed up rendering of the stages pag...

2018-01-08 Thread sameeragarwal
Github user sameeragarwal commented on the issue: https://github.com/apache/spark/pull/20013 @vanzin Thanks for the great work! Given this is a sizable change, I'll like get this in before cutting RC1

[GitHub] spark issue #19080: [SPARK-21865][SQL] simplify the distribution semantic of...

2018-01-07 Thread sameeragarwal
Github user sameeragarwal commented on the issue: https://github.com/apache/spark/pull/19080 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark pull request #19080: [SPARK-21865][SQL] simplify the distribution sema...

2018-01-07 Thread sameeragarwal
Github user sameeragarwal commented on a diff in the pull request: https://github.com/apache/spark/pull/19080#discussion_r160080116 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/physical/partitioning.scala --- @@ -51,12 +76,41 @@ case object AllTuples

[GitHub] spark pull request #19080: [SPARK-21865][SQL] simplify the distribution sema...

2018-01-05 Thread sameeragarwal
Github user sameeragarwal commented on a diff in the pull request: https://github.com/apache/spark/pull/19080#discussion_r160017940 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/physical/partitioning.scala --- @@ -73,46 +127,31 @@ case class

[GitHub] spark pull request #19080: [SPARK-21865][SQL] simplify the distribution sema...

2018-01-05 Thread sameeragarwal
Github user sameeragarwal commented on a diff in the pull request: https://github.com/apache/spark/pull/19080#discussion_r160017879 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/physical/partitioning.scala --- @@ -51,12 +76,41 @@ case object AllTuples

[GitHub] spark pull request #19080: [SPARK-21865][SQL] simplify the distribution sema...

2018-01-05 Thread sameeragarwal
Github user sameeragarwal commented on a diff in the pull request: https://github.com/apache/spark/pull/19080#discussion_r160018028 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/physical/partitioning.scala --- @@ -73,46 +127,31 @@ case class

[GitHub] spark issue #20085: [SPARK-22739][Catalyst][WIP] Additional Expression Suppo...

2018-01-03 Thread sameeragarwal
Github user sameeragarwal commented on the issue: https://github.com/apache/spark/pull/20085 jenkins add to whitelist --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e

[GitHub] spark issue #20005: [DO-NOT-MERGE] Investigating SparkR test failure

2017-12-18 Thread sameeragarwal
Github user sameeragarwal commented on the issue: https://github.com/apache/spark/pull/20005 Thanks @viirya! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark pull request #19939: [SPARK-20557] [SQL] Only support TIMESTAMP WITH T...

2017-12-11 Thread sameeragarwal
Github user sameeragarwal commented on a diff in the pull request: https://github.com/apache/spark/pull/19939#discussion_r156205533 --- Diff: external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/PostgresIntegrationSuite.scala --- @@ -151,6 +151,8 @@ class

[GitHub] spark issue #19069: [MINOR][SQL][TEST]Test shuffle hash join while is not ex...

2017-08-29 Thread sameeragarwal
Github user sameeragarwal commented on the issue: https://github.com/apache/spark/pull/19069 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] spark pull request #19080: [SPARK-21865][SQL] remove Partitioning.compatible...

2017-08-29 Thread sameeragarwal
Github user sameeragarwal commented on a diff in the pull request: https://github.com/apache/spark/pull/19080#discussion_r135941833 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/physical/partitioning.scala --- @@ -30,18 +30,32 @@ import

[GitHub] spark pull request #19062: [SPARK-21845] [SQL] Make codegen fallback of expr...

2017-08-29 Thread sameeragarwal
Github user sameeragarwal commented on a diff in the pull request: https://github.com/apache/spark/pull/19062#discussion_r135938925 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkPlan.scala --- @@ -370,8 +373,7 @@ abstract class SparkPlan extends QueryPlan

[GitHub] spark pull request #19069: [MINOR][SQL][TEST]Test shuffle hash join while is...

2017-08-28 Thread sameeragarwal
Github user sameeragarwal commented on a diff in the pull request: https://github.com/apache/spark/pull/19069#discussion_r135645027 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/JoinBenchmark.scala --- @@ -212,18 +212,17 @@ class JoinBenchmark extends

[GitHub] spark issue #19003: [SPARK-21769] [SQL] Add a table-specific option for alwa...

2017-08-22 Thread sameeragarwal
Github user sameeragarwal commented on the issue: https://github.com/apache/spark/pull/19003 Merging to master, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #19003: [SPARK-21769] [SQL] Add a table-specific option for alwa...

2017-08-22 Thread sameeragarwal
Github user sameeragarwal commented on the issue: https://github.com/apache/spark/pull/19003 LGTM, thanks! Are these table properties documented somewhere? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request #19003: [SPARK-21769] [SQL] Add a table-specific option f...

2017-08-22 Thread sameeragarwal
Github user sameeragarwal commented on a diff in the pull request: https://github.com/apache/spark/pull/19003#discussion_r134557690 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/SourceOptions.scala --- @@ -0,0 +1,50 @@ +/* + * Licensed

[GitHub] spark issue #18977: [SPARK-21767] [TEST] [SQL] Add Decimal Test For Avro in ...

2017-08-17 Thread sameeragarwal
Github user sameeragarwal commented on the issue: https://github.com/apache/spark/pull/18977 Thanks, LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] spark pull request #18977: [SPARK-21767] [TEST] [SQL] Add Decimal Test For A...

2017-08-17 Thread sameeragarwal
Github user sameeragarwal commented on a diff in the pull request: https://github.com/apache/spark/pull/18977#discussion_r133820405 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/client/VersionsSuite.scala --- @@ -697,6 +696,71 @@ class VersionsSuite extends

[GitHub] spark pull request #18977: [SPARK-21767] [TEST] [SQL] Add Decimal Test For A...

2017-08-17 Thread sameeragarwal
Github user sameeragarwal commented on a diff in the pull request: https://github.com/apache/spark/pull/18977#discussion_r133819639 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/client/VersionsSuite.scala --- @@ -697,6 +696,71 @@ class VersionsSuite extends

[GitHub] spark pull request #18955: [SPARK-21743][SQL] top-most limit should not caus...

2017-08-16 Thread sameeragarwal
Github user sameeragarwal commented on a diff in the pull request: https://github.com/apache/spark/pull/18955#discussion_r133596076 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala --- @@ -2658,4 +2658,9 @@ class SQLQuerySuite extends QueryTest

[GitHub] spark pull request #18966: [SPARK-21751][SQL] CodeGeneraor.splitExpressions ...

2017-08-16 Thread sameeragarwal
Github user sameeragarwal commented on a diff in the pull request: https://github.com/apache/spark/pull/18966#discussion_r133594345 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala --- @@ -769,16 +769,19 @@ class

[GitHub] spark issue #18640: [SPARK-21422][BUILD] Depend on Apache ORC 1.4.0

2017-08-10 Thread sameeragarwal
Github user sameeragarwal commented on the issue: https://github.com/apache/spark/pull/18640 LGTM; unless @rxin still has some strong objections? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark issue #18662: [SPARK-21444] Be more defensive when removing broadcasts...

2017-07-17 Thread sameeragarwal
Github user sameeragarwal commented on the issue: https://github.com/apache/spark/pull/18662 cc @jiangxb1987 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #18338: [SPARK-21129] [SQL] Arguments of SQL function call shoul...

2017-06-30 Thread sameeragarwal
Github user sameeragarwal commented on the issue: https://github.com/apache/spark/pull/18338 LGTM pending jenkins --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request #18338: [SPARK-21129] [SQL] Arguments of SQL function cal...

2017-06-30 Thread sameeragarwal
Github user sameeragarwal commented on a diff in the pull request: https://github.com/apache/spark/pull/18338#discussion_r125103335 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/ExpressionParserSuite.scala --- @@ -231,7 +231,6 @@ class

[GitHub] spark issue #18338: [SPARK-21129] [SQL] Arguments of SQL function call shoul...

2017-06-30 Thread sameeragarwal
Github user sameeragarwal commented on the issue: https://github.com/apache/spark/pull/18338 test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #18377: [SPARK-18016][SQL][CATALYST][BRANCH-2.2] Code Generation...

2017-06-23 Thread sameeragarwal
Github user sameeragarwal commented on the issue: https://github.com/apache/spark/pull/18377 Thanks guys! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] spark issue #9518: [SPARK-11574][Core] Add metrics StatsD sink

2017-06-22 Thread sameeragarwal
Github user sameeragarwal commented on the issue: https://github.com/apache/spark/pull/9518 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] spark issue #18377: [SPARK-18016][SQL][CATALYST][BRANCH-2.2] Code Generation...

2017-06-22 Thread sameeragarwal
Github user sameeragarwal commented on the issue: https://github.com/apache/spark/pull/18377 @bdrillard @cloud-fan given that this is not a regression and 2.2 is in code-freeze, do you think this is safe to merge it in the 2.2 branch? More specifically, could the new code path affect

[GitHub] spark issue #9518: [SPARK-11574][Core] Add metrics StatsD sink

2017-06-22 Thread sameeragarwal
Github user sameeragarwal commented on the issue: https://github.com/apache/spark/pull/9518 test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #18310: [SPARK-21103][SQL] QueryPlanConstraints should be part o...

2017-06-20 Thread sameeragarwal
Github user sameeragarwal commented on the issue: https://github.com/apache/spark/pull/18310 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] spark issue #14151: [SPARK-16496][SQL] Add wholetext as option for reading t...

2017-06-16 Thread sameeragarwal
Github user sameeragarwal commented on the issue: https://github.com/apache/spark/pull/14151 test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #14431: [SPARK-16258][SparkR] Automatically append the grouping ...

2017-06-16 Thread sameeragarwal
Github user sameeragarwal commented on the issue: https://github.com/apache/spark/pull/14431 @NarineK @shivaram any updates here? Also cc @felixcheung --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark issue #13893: [SPARK-14172][SQL] Hive table partition predicate not pa...

2017-06-16 Thread sameeragarwal
Github user sameeragarwal commented on the issue: https://github.com/apache/spark/pull/13893 ping @jiangxb1987 @cloud-fan --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13028: [SPARK-9860][SQL] Join: Determine the join strategy (bro...

2017-06-16 Thread sameeragarwal
Github user sameeragarwal commented on the issue: https://github.com/apache/spark/pull/13028 @lianhuiwang could this regress performance for existing queries? Can you please share some benchmarks with us (if any)? --- If your project is set up for it, you can reply to this email

[GitHub] spark issue #9202: [SPARK-10857] [SQL] Block SQL injection vulnerabilities u...

2017-06-16 Thread sameeragarwal
Github user sameeragarwal commented on the issue: https://github.com/apache/spark/pull/9202 @rick-ibm would you still have time to bring this up to date? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request #18299: [SPARK-21092][SQL] Wire SQLConf in logical plan a...

2017-06-14 Thread sameeragarwal
Github user sameeragarwal commented on a diff in the pull request: https://github.com/apache/spark/pull/18299#discussion_r122072608 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/QueryPlanConstraints.scala --- @@ -27,18 +27,20 @@ trait

[GitHub] spark issue #18298: [SPARK-21091][SQL] Move constraint code into QueryPlanCo...

2017-06-14 Thread sameeragarwal
Github user sameeragarwal commented on the issue: https://github.com/apache/spark/pull/18298 Thanks for the cleanup! LGTM modulo Xiao's comment. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark issue #18176: [SPARK-20952] Make TaskContext an InheritableTheadLocal

2017-06-08 Thread sameeragarwal
Github user sameeragarwal commented on the issue: https://github.com/apache/spark/pull/18176 cc @JoshRosen who had some concerns with shared threadpool objects --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request #17180: [SPARK-19839][Core]release longArray in BytesToBy...

2017-06-08 Thread sameeragarwal
Github user sameeragarwal commented on a diff in the pull request: https://github.com/apache/spark/pull/17180#discussion_r121019600 --- Diff: core/src/main/java/org/apache/spark/unsafe/map/BytesToBytesMap.java --- @@ -358,10 +358,20 @@ public long spill(long numBytes) throws

[GitHub] spark pull request #17180: [SPARK-19839][Core]release longArray in BytesToBy...

2017-06-08 Thread sameeragarwal
Github user sameeragarwal commented on a diff in the pull request: https://github.com/apache/spark/pull/17180#discussion_r121019571 --- Diff: core/src/main/java/org/apache/spark/unsafe/map/BytesToBytesMap.java --- @@ -358,10 +358,20 @@ public long spill(long numBytes) throws

[GitHub] spark issue #18219: tests for JoinTypes

2017-06-08 Thread sameeragarwal
Github user sameeragarwal commented on the issue: https://github.com/apache/spark/pull/18219 @BartekH can you please close this now? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark issue #18228: [SPARK-21007][SQL]Add SQL function - RIGHT && LEFT

2017-06-08 Thread sameeragarwal
Github user sameeragarwal commented on the issue: https://github.com/apache/spark/pull/18228 jenkins add to whitelist --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #18228: [SPARK-21007][SQL]Add SQL function - RIGHT && LEFT

2017-06-08 Thread sameeragarwal
Github user sameeragarwal commented on the issue: https://github.com/apache/spark/pull/18228 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] spark pull request #17985: Add "full_outer" name to join types

2017-06-08 Thread sameeragarwal
Github user sameeragarwal commented on a diff in the pull request: https://github.com/apache/spark/pull/17985#discussion_r121014650 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/plans/JoinTypesTest.scala --- @@ -0,0 +1,62 @@ +/* + * Licensed

[GitHub] spark issue #17985: Add "full_outer" name to join types

2017-06-08 Thread sameeragarwal
Github user sameeragarwal commented on the issue: https://github.com/apache/spark/pull/17985 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] spark issue #18184: [MINOR] [SQL] Update the description of spark.sql.files....

2017-06-02 Thread sameeragarwal
Github user sameeragarwal commented on the issue: https://github.com/apache/spark/pull/18184 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] spark pull request #17343: [SPARK-20014] Optimize mergeSpillsWithFileStream ...

2017-05-25 Thread sameeragarwal
Github user sameeragarwal commented on a diff in the pull request: https://github.com/apache/spark/pull/17343#discussion_r118615705 --- Diff: core/src/main/java/org/apache/spark/shuffle/sort/UnsafeShuffleWriter.java --- @@ -339,23 +355,26 @@ void forceSorterToSpill() throws

[GitHub] spark issue #17343: [SPARK-20014] Optimize mergeSpillsWithFileStream method

2017-05-25 Thread sameeragarwal
Github user sameeragarwal commented on the issue: https://github.com/apache/spark/pull/17343 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] spark issue #17471: [SPARK-3577] Report Spill size on disk for UnsafeExterna...

2017-05-25 Thread sameeragarwal
Github user sameeragarwal commented on the issue: https://github.com/apache/spark/pull/17471 @sitalkedia any updates here? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

  1   2   3   4   5   6   7   >