Github user skonto commented on the issue:
https://github.com/apache/spark/pull/18528
@srowen could I get a merge pls?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/18630
@srowen or @vanzin can I get a merge pls?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/18837
Btw a lot of secrets are defined in the code base:
spark.secret.mesos,spark.mesos.driver.secret.name,
spark.authenticate.secret
(https://spark.apache.org/docs/latest/security.html) do you
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/18837#discussion_r131354746
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala
---
@@ -529,18 +560,54 @@ private
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/18837#discussion_r131351705
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala
---
@@ -510,12 +510,20 @@ trait
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/18837#discussion_r131350894
--- Diff: docs/running-on-mesos.md ---
@@ -479,6 +479,35 @@ See the [configuration page](configuration.html) for
information on Spark config
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/18837#discussion_r131348687
--- Diff: resource-managers/mesos/pom.xml ---
@@ -29,7 +29,7 @@
Spark Project Mesos
mesos
-1.0.0
+1.3.0-rc1
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/18630
@vanzin fixed the issues. Please give it another try or merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/18528
@srowen fixed, ready for merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/18528#discussion_r130912865
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/deploy/mesos/ui/MesosClusterPage.scala
---
@@ -76,6 +77,17 @@ private[mesos] class
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/18528#discussion_r130912963
--- Diff: docs/running-on-mesos.md ---
@@ -153,6 +153,8 @@ can find the results of the driver from the Mesos Web
UI.
To use cluster mode, you must
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/18528#discussion_r130912751
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/deploy/mesos/ui/MesosClusterPage.scala
---
@@ -76,6 +77,17 @@ private[mesos] class
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/18528
thnx @srowen will fix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/18630#discussion_r130911557
--- Diff:
core/src/main/scala/org/apache/spark/deploy/worker/DriverWrapper.scala ---
@@ -66,4 +70,16 @@ object DriverWrapper {
System.exit(-1
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/18630#discussion_r130909789
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -1315,6 +1294,80 @@ private[spark] object SparkSubmitUtils
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/18630#discussion_r130908799
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -1315,6 +1294,80 @@ private[spark] object SparkSubmitUtils
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/18630#discussion_r130908694
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -1315,6 +1294,80 @@ private[spark] object SparkSubmitUtils
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/18630#discussion_r130908550
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -1315,6 +1294,80 @@ private[spark] object SparkSubmitUtils
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/18528
@srowen Could you pls have a look and merge?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/18784
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/18784
@srowen this test
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80079/
seems flaky, I run the suite locally and works fine (13 tests finished
successfully).
---
If your
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/18784
@srowen I made a new commit but didn't get a new build...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project doe
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/18784
Jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/18784#discussion_r130383697
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/TaskSchedulerImplSuite.scala ---
@@ -784,42 +784,6 @@ class TaskSchedulerImplSuite extends
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/18784
Fixed the test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/18784
@srowen ok, yes. I have discussed this with Art and Suzan from Mesosphere
and we made the decision to remove it as it is deprecated for so long. I am
waiting for their comments here.
In the
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/18784
@ArtRand @susanxhuynh pls review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user skonto opened a pull request:
https://github.com/apache/spark/pull/18784
[SPARK-21559][Mesos] remove mesos fine-grained mode
## What changes were proposed in this pull request?
Removes mesos fine-grained mode. Specifically:
- Updates docs.
- Renames
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/13143
@ArtRand @susanxhuynh could please review this before we call for a merge?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/18528
@vanzin Could we get a merge please and/or a review?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/18528
@ArtRand I tested the PR on 1.4 have a look pls.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/18098#discussion_r129176526
--- Diff:
core/src/main/scala/org/apache/spark/internal/config/package.scala ---
@@ -72,6 +72,10 @@ package object config {
private[spark] val
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/18630
@vanzin I did the required refactoring, addressing the issues you mentioned
and added to the description a better message so its available in git log when
this PR is merged.
---
If your project is
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/18705
@vanzin thnx for the review. I updated the PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/18630#discussion_r128920834
--- Diff:
core/src/main/scala/org/apache/spark/deploy/worker/DriverWrapper.scala ---
@@ -18,8 +18,17 @@
package org.apache.spark.deploy.worker
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/18630#discussion_r128835800
--- Diff:
core/src/main/scala/org/apache/spark/deploy/worker/DriverWrapper.scala ---
@@ -43,7 +52,7 @@ object DriverWrapper
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/18630#discussion_r128835610
--- Diff:
core/src/main/scala/org/apache/spark/deploy/worker/DriverWrapper.scala ---
@@ -66,4 +77,68 @@ object DriverWrapper {
System.exit(-1
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/18630#discussion_r128835523
--- Diff:
core/src/main/scala/org/apache/spark/deploy/worker/DriverWrapper.scala ---
@@ -66,4 +77,68 @@ object DriverWrapper {
System.exit(-1
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/18630#discussion_r128834993
--- Diff:
core/src/main/scala/org/apache/spark/deploy/worker/DriverWrapper.scala ---
@@ -66,4 +77,68 @@ object DriverWrapper {
System.exit(-1
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/18630#discussion_r128834674
--- Diff:
core/src/main/scala/org/apache/spark/deploy/worker/DriverWrapper.scala ---
@@ -66,4 +77,68 @@ object DriverWrapper {
System.exit(-1
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/18705
@susanxhuynh @ArtRand pls review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user skonto opened a pull request:
https://github.com/apache/spark/pull/18705
[SPARK-21502][Mesos] fix --supervise for mesos in cluster mode
## What changes were proposed in this pull request?
With supervise enabled for a driver so far re-launching it was failing
because
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/18674
@susanxhuynh no its fine. @vanzin @srowen could we have a merge pls or if
you want to go through it first?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/18674
I saw this issue: https://issues.apache.org/jira/browse/SPARK-21458
refering to supervision.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/18674
So the task updates will not have any effect cool, and the framework tear
down will come later on if the timer expires.
while checking the docs since this is obviously useful for the
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/18674
@susanxhuynh what are the implications for the dispatcher? The driver runs
as a task so the dispatcher will get an task status update earlier if the task
has failed correct?
---
If your project is
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/18674#discussion_r128257884
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/deploy/mesos/config.scala
---
@@ -58,9 +58,16 @@ package object config
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/18098#discussion_r128243453
--- Diff:
core/src/main/scala/org/apache/spark/internal/config/package.scala ---
@@ -72,6 +72,10 @@ package object config {
private[spark] val
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/18098#discussion_r128235076
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackend.scala
---
@@ -502,6 +526,25
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/18630
@vanzin thnx done, I changed the title. I am willing to work on the
distributed cache but needs time for sure.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/18630
I agree that's why I didnt try to do the refactoring... I thought it would
take a long time... As for the cluster mode some people use it due to the
supervise feature, guess not too many, but
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/18630
@jerryshao I agree I had shared this thought with @vanzin for utilizing the
distributed cache or whatever is available there in the other PR for mesos. For
mesos I am also going to discuss this with
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/18630
@jerryshao @vanzin I updated the PR, pls review. In standalone cluster
mode with this new update I can resolve jars paths of the form:
/tmp/tmp7255787727862122372/jarname.jar,
file:///home
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/18630
One thing I noticed is that if you use https you need to set : --conf
spark.ssl.enabled=true --conf spark.ssl.protocol=TLS but this does nto apply to
the user jar. I think that is an issue.
---
If
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/18630
@jerryshao
>
Are you trying to support --packages in standalone cluster?
Yes that is my intention as stated in the description. I will proceed with
the changes thnx
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/18630#discussion_r127614213
--- Diff:
core/src/main/scala/org/apache/spark/deploy/worker/DriverWrapper.scala ---
@@ -66,4 +75,50 @@ object DriverWrapper {
System.exit(-1
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/18630#discussion_r127614182
--- Diff:
core/src/main/scala/org/apache/spark/deploy/worker/DriverWrapper.scala ---
@@ -66,4 +75,50 @@ object DriverWrapper {
System.exit(-1
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/18630#discussion_r127613972
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -473,6 +474,12 @@ object SparkSubmit extends CommandLineUtils
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/18630
@vanzin pls review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user skonto opened a pull request:
https://github.com/apache/spark/pull/18630
[SPARK-12559][SPARK SUBMIT] fix --packages for standalone
## What changes were proposed in this pull request?
Fixes --packages flag for the standalone mode.
## How was this patch
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/18587
thnx @vanzin I am working on some code for the standalone case.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/18587
@vanzin
> args.jars = mergeFileLists(args.jars, resolvedMavenCoordinates)
My understanding:
Files intended for the appmaster are handled by copying to hdfs:
https://github.
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/18587#discussion_r126382374
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -269,6 +269,25 @@ object SparkSubmit extends CommandLineUtils
GitHub user skonto opened a pull request:
https://github.com/apache/spark/pull/18587
[SPARK-12559][mesos] fix --packages for mesos
## What changes were proposed in this pull request?
Fixes --packages flag for mesos in cluster mode. Probably I will handle
standalone and Yarn in
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/18528
@mgummelt @HyukjinKwon pls review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user skonto opened a pull request:
https://github.com/apache/spark/pull/18528
[SPARK-13041][Mesos] Adds sandbox uri to spark dispatcher ui
## What changes were proposed in this pull request?
Adds a sandbox link per driver in the dispatcher ui with minimal changes
after a
Github user skonto closed the pull request at:
https://github.com/apache/spark/pull/11887
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/11887
@HyukjinKwon I will close this one and start fresh.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/11887
Great thnx @haosdent :)I will proceed with updating the PR. Thnx a lot!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/11887
@HyukjinKwon I will have a look and let you know, please don't close it for
now. There was finally progress at the mesos side:
https://reviews.apache.org/r/58872/
---
If your proje
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/17109#discussion_r111045370
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerBackendUtil.scala
---
@@ -99,6 +99,26 @@ private
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/17031
@mgummelt do we wan to keep the suppress/revive technique?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/17031
@srown There are parts for refactoring only purposes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/17031
@mgummelt LGTM. Thanks fo rthe clarifications. @srowen can we get a merge?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/17031
But this time is the refuse time correct? As stated here:
https://issues.apache.org/jira/browse/MESOS-3202 I have 30 seconds for osme
other framework to accept resources in the list otherwise the
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/17045
LGTM run it locally works fine.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/17045#discussion_r103411216
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackend.scala
---
@@ -256,7 +259,7
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/17031
Ok I see. LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/17031
Ok like the Cassandra case you mean right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/17031#discussion_r103287098
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosFineGrainedSchedulerBackend.scala
---
@@ -24,6 +24,7
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/17031#discussion_r103281854
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala
---
@@ -582,141 +688,33 @@ private
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/17031#discussion_r103281366
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala
---
@@ -737,13 +735,75 @@ private
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/17031#discussion_r103280797
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala
---
@@ -737,13 +735,75 @@ private
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/17031#discussion_r103280133
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/deploy/mesos/ui/MesosClusterPage.scala
---
@@ -32,7 +32,7 @@ private[mesos] class
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/17031
"The only way to fix this generally is to implement some periodic timer
that calls reviveOffers() if there are queued/pending drivers to be scheduled.
This can be chatty and complicates the cod
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/17031#discussion_r103261951
--- Diff:
resource-managers/mesos/src/test/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterSchedulerSuite.scala
---
@@ -48,45 +48,50 @@ class
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/17031
@mgummelt Yes they should look at the logs but how do they know this is
something that requires action from their side and not a cluster issue or
anything else. It should be documented since it is
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/17031
How the operator should know about starvation?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/17031#discussion_r102707406
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosFineGrainedSchedulerBackend.scala
---
@@ -24,6 +24,7
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/13072
Ideally all processes we have should handle thread termination correctly,
same applies to MesosClusterDispatcher. Btw I think the call in Executor.scala
should be done in static code, for example in
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/13072
@devaraj-kavali Which threads/Executor you are referring to in
MesosClusterDispatcher?
Could you provide some pointers?
---
If your project is set up for it, you can reply to this email and
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/16755
Please fix the title for the PR and include the related jira issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/11887
@HyukjinKwon probably. Let me ask Michael. @mgummelt what do you think?
what options do we have?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/13072
@mgummelt @srowen should we get a merge?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/14650
@vanzin if there is anything to fix I can do it if you want I can do
another parse to check it against the style guide. For all the style nit stuff
I guess sometimes is a matter of taste...
---
If
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/14650
@rxin @srowen could I get merge pls if there are no other issues?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/14650
@vanzin I updated the PR. Thank you for the review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/14650#discussion_r88572655
--- Diff: core/src/main/scala/org/apache/spark/util/CommandLineUtils.scala
---
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/14650#discussion_r88570905
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -1962,6 +1962,21 @@ private[spark] object Utils extends Logging {
path
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/14650#discussion_r88570567
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -412,10 +412,8 @@ private[deploy] class SparkSubmitArguments(args
501 - 600 of 913 matches
Mail list logo
