[GitHub] [spark] cloud-fan commented on a change in pull request #28600: [SPARK-31761][SQL] cast integer to Long to avoid IntegerOverflow for IntegralDivide operator

2020-05-22 Thread GitBox
cloud-fan commented on a change in pull request #28600: URL: https://github.com/apache/spark/pull/28600#discussion_r429105908 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala ## @@ -684,6 +685,24 @@ object TypeCoercion {

[GitHub] [spark] cloud-fan commented on a change in pull request #28600: [SPARK-31761][SQL] cast integer to Long to avoid IntegerOverflow for IntegralDivide operator

2020-05-22 Thread GitBox
cloud-fan commented on a change in pull request #28600: URL: https://github.com/apache/spark/pull/28600#discussion_r429089026 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala ## @@ -684,6 +685,24 @@ object TypeCoercion {

[GitHub] [spark] cloud-fan commented on a change in pull request #28600: [SPARK-31761][SQL] cast integer to Long to avoid IntegerOverflow for IntegralDivide operator

2020-05-22 Thread GitBox
cloud-fan commented on a change in pull request #28600: URL: https://github.com/apache/spark/pull/28600#discussion_r429088295 ## File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala ## @@ -3495,6 +3495,13 @@ class SQLQuerySuite extends QueryTest with

[GitHub] [spark] cloud-fan commented on a change in pull request #28600: [SPARK-31761][SQL] cast integer to Long to avoid IntegerOverflow for IntegralDivide operator

2020-05-22 Thread GitBox
cloud-fan commented on a change in pull request #28600: URL: https://github.com/apache/spark/pull/28600#discussion_r429082736 ## File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala ## @@ -3495,6 +3495,13 @@ class SQLQuerySuite extends QueryTest with

[GitHub] [spark] cloud-fan commented on a change in pull request #28600: [SPARK-31761][SQL] cast integer to Long to avoid IntegerOverflow for IntegralDivide operator

2020-05-22 Thread GitBox
cloud-fan commented on a change in pull request #28600: URL: https://github.com/apache/spark/pull/28600#discussion_r429082915 ## File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala ## @@ -3495,6 +3495,13 @@ class SQLQuerySuite extends QueryTest with

[GitHub] [spark] cloud-fan commented on a change in pull request #28600: [SPARK-31761][SQL] cast integer to Long to avoid IntegerOverflow for IntegralDivide operator

2020-05-22 Thread GitBox
cloud-fan commented on a change in pull request #28600: URL: https://github.com/apache/spark/pull/28600#discussion_r429082030 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala ## @@ -684,6 +685,24 @@ object TypeCoercion {

[GitHub] [spark] cloud-fan commented on a change in pull request #28600: [SPARK-31761][SQL] cast integer to Long to avoid IntegerOverflow for IntegralDivide operator

2020-05-22 Thread GitBox
cloud-fan commented on a change in pull request #28600: URL: https://github.com/apache/spark/pull/28600#discussion_r429081944 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala ## @@ -684,6 +685,24 @@ object TypeCoercion {

[GitHub] [spark] cloud-fan commented on a change in pull request #28600: [SPARK-31761][SQL] cast integer to Long to avoid IntegerOverflow for IntegralDivide operator

2020-05-21 Thread GitBox
cloud-fan commented on a change in pull request #28600: URL: https://github.com/apache/spark/pull/28600#discussion_r429039911 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala ## @@ -423,13 +434,21 @@ case class