[GitHub] [spark] cloud-fan commented on a change in pull request #34060: [SPARK-36850][SQL] Migrate CreateTableStatement to v2 command framework

2021-12-09 Thread GitBox
cloud-fan commented on a change in pull request #34060: URL: https://github.com/apache/spark/pull/34060#discussion_r765992537 ## File path: sql/core/src/main/scala/org/apache/spark/sql/streaming/DataStreamWriter.scala ## @@ -288,19 +289,23 @@ final class DataStreamWriter[T]

[GitHub] [spark] cloud-fan commented on a change in pull request #34060: [SPARK-36850][SQL] Migrate CreateTableStatement to v2 command framework

2021-11-29 Thread GitBox
cloud-fan commented on a change in pull request #34060: URL: https://github.com/apache/spark/pull/34060#discussion_r758286195 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/command/PlanResolutionSuite.scala ## @@ -26,12 +26,12 @@ import

[GitHub] [spark] cloud-fan commented on a change in pull request #34060: [SPARK-36850][SQL] Migrate CreateTableStatement to v2 command framework

2021-11-29 Thread GitBox
cloud-fan commented on a change in pull request #34060: URL: https://github.com/apache/spark/pull/34060#discussion_r758283132 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala ## @@ -819,6 +820,9 @@ abstract class TreeNode[BaseType

[GitHub] [spark] cloud-fan commented on a change in pull request #34060: [SPARK-36850][SQL] Migrate CreateTableStatement to v2 command framework

2021-11-25 Thread GitBox
cloud-fan commented on a change in pull request #34060: URL: https://github.com/apache/spark/pull/34060#discussion_r756898767 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/command/PlanResolutionSuite.scala ## @@ -481,19 +481,26 @@ class

[GitHub] [spark] cloud-fan commented on a change in pull request #34060: [SPARK-36850][SQL] Migrate CreateTableStatement to v2 command framework

2021-11-25 Thread GitBox
cloud-fan commented on a change in pull request #34060: URL: https://github.com/apache/spark/pull/34060#discussion_r756898209 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/command/PlanResolutionSuite.scala ## @@ -481,19 +481,26 @@ class

[GitHub] [spark] cloud-fan commented on a change in pull request #34060: [SPARK-36850][SQL] Migrate CreateTableStatement to v2 command framework

2021-11-25 Thread GitBox
cloud-fan commented on a change in pull request #34060: URL: https://github.com/apache/spark/pull/34060#discussion_r756896465 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/CreateTableExec.scala ## @@ -32,10 +33,16 @@ case class

[GitHub] [spark] cloud-fan commented on a change in pull request #34060: [SPARK-36850][SQL] Migrate CreateTableStatement to v2 command framework

2021-11-25 Thread GitBox
cloud-fan commented on a change in pull request #34060: URL: https://github.com/apache/spark/pull/34060#discussion_r756892666 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala ## @@ -3402,7 +3402,7 @@ class AstBuilder extends

[GitHub] [spark] cloud-fan commented on a change in pull request #34060: [SPARK-36850][SQL] Migrate CreateTableStatement to v2 command framework

2021-11-25 Thread GitBox
cloud-fan commented on a change in pull request #34060: URL: https://github.com/apache/spark/pull/34060#discussion_r756891808 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala ## @@ -3469,9 +3469,14 @@ class AstBuilder extends

[GitHub] [spark] cloud-fan commented on a change in pull request #34060: [SPARK-36850][SQL] Migrate CreateTableStatement to v2 command framework

2021-11-24 Thread GitBox
cloud-fan commented on a change in pull request #34060: URL: https://github.com/apache/spark/pull/34060#discussion_r755786855 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/v2Commands.scala ## @@ -189,17 +190,35 @@ trait

[GitHub] [spark] cloud-fan commented on a change in pull request #34060: [SPARK-36850][SQL] Migrate CreateTableStatement to v2 command framework

2021-11-24 Thread GitBox
cloud-fan commented on a change in pull request #34060: URL: https://github.com/apache/spark/pull/34060#discussion_r755784540 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Strategy.scala ## @@ -156,9 +156,16 @@ class

[GitHub] [spark] cloud-fan commented on a change in pull request #34060: [SPARK-36850][SQL] Migrate CreateTableStatement to v2 command framework

2021-11-23 Thread GitBox
cloud-fan commented on a change in pull request #34060: URL: https://github.com/apache/spark/pull/34060#discussion_r755773462 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/rules.scala ## @@ -263,6 +265,51 @@ case class

[GitHub] [spark] cloud-fan commented on a change in pull request #34060: [SPARK-36850][SQL] Migrate CreateTableStatement to v2 command framework

2021-11-23 Thread GitBox
cloud-fan commented on a change in pull request #34060: URL: https://github.com/apache/spark/pull/34060#discussion_r755772048 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/rules.scala ## @@ -25,9 +25,11 @@ import

[GitHub] [spark] cloud-fan commented on a change in pull request #34060: [SPARK-36850][SQL] Migrate CreateTableStatement to v2 command framework

2021-11-23 Thread GitBox
cloud-fan commented on a change in pull request #34060: URL: https://github.com/apache/spark/pull/34060#discussion_r755770346 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala ## @@ -819,6 +820,8 @@ abstract class TreeNode[BaseType

[GitHub] [spark] cloud-fan commented on a change in pull request #34060: [SPARK-36850][SQL] Migrate CreateTableStatement to v2 command framework

2021-11-23 Thread GitBox
cloud-fan commented on a change in pull request #34060: URL: https://github.com/apache/spark/pull/34060#discussion_r755769160 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/v2Commands.scala ## @@ -190,17 +191,32 @@ trait

[GitHub] [spark] cloud-fan commented on a change in pull request #34060: [SPARK-36850][SQL] Migrate CreateTableStatement to v2 command framework

2021-11-23 Thread GitBox
cloud-fan commented on a change in pull request #34060: URL: https://github.com/apache/spark/pull/34060#discussion_r755708588 ## File path: sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveSessionCatalog.scala ## @@ -143,25 +143,25 @@ class

[GitHub] [spark] cloud-fan commented on a change in pull request #34060: [SPARK-36850][SQL] Migrate CreateTableStatement to v2 command framework

2021-11-23 Thread GitBox
cloud-fan commented on a change in pull request #34060: URL: https://github.com/apache/spark/pull/34060#discussion_r755707836 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/v2Commands.scala ## @@ -1090,3 +1106,12 @@ case class DropIndex(

[GitHub] [spark] cloud-fan commented on a change in pull request #34060: [SPARK-36850][SQL] Migrate CreateTableStatement to v2 command framework

2021-11-23 Thread GitBox
cloud-fan commented on a change in pull request #34060: URL: https://github.com/apache/spark/pull/34060#discussion_r755707733 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala ## @@ -3469,9 +3469,14 @@ class AstBuilder extends