Github user shivaram commented on the pull request:
https://github.com/apache/spark/pull/8920#issuecomment-146620104
Thanks @NarineK for the PR and @sun-rui for reviewing this.
LGTM and merging this
---
If your project is set up for it, you can reply to this email and have
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/8920
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8920#issuecomment-146094144
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8920#issuecomment-146094148
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8920#issuecomment-146090399
[Test build #43322 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43322/consoleFull)
for PR 8920 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8920#issuecomment-146093947
[Test build #43322 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43322/console)
for PR 8920 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8920#issuecomment-146089823
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8920#issuecomment-146089844
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user sun-rui commented on the pull request:
https://github.com/apache/spark/pull/8920#issuecomment-146425321
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user NarineK commented on the pull request:
https://github.com/apache/spark/pull/8920#issuecomment-146268817
any more comments ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user NarineK commented on the pull request:
https://github.com/apache/spark/pull/8920#issuecomment-146042798
Hi Felix,
so do you suggest to change the comment with smth like:
#' @param decreasing A logical argument indicating sorting order for
columns when a
Github user NarineK commented on the pull request:
https://github.com/apache/spark/pull/8920#issuecomment-146043419
and I can leave only:
@param col A character or Column object vector indicating the fields to
sort on
for col
---
If your project is set up for it, you
Github user felixcheung commented on the pull request:
https://github.com/apache/spark/pull/8920#issuecomment-146047500
yes, that sounds good, thanks @NarineK
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user NarineK commented on the pull request:
https://github.com/apache/spark/pull/8920#issuecomment-146034183
Hi @felixcheung ,
I try to say it at param description:
@param decreasing A logical argument indicating sorting order for columns
which are specified
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/8920#discussion_r41336150
--- Diff: R/pkg/R/DataFrame.R ---
@@ -1290,8 +1290,10 @@ setClassUnion("characterOrColumn", c("character",
"Column"))
#' Sort a DataFrame by the
Github user felixcheung commented on the pull request:
https://github.com/apache/spark/pull/8920#issuecomment-146033787
looks good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user felixcheung commented on the pull request:
https://github.com/apache/spark/pull/8920#issuecomment-146036999
Hi Narine - it looks like the `decreasing` param is only supported with
`col` is a character vector right? it might help to point that out if an user
is trying pass
Github user felixcheung commented on the pull request:
https://github.com/apache/spark/pull/8920#issuecomment-146037178
This is in reference to the previous doc line which says:
```
#' @param col A character or Column object vector indicating the fields to
sort on
```
Github user sun-rui commented on the pull request:
https://github.com/apache/spark/pull/8920#issuecomment-145861929
@NarineK, thanks for your follow up. Now basically looks good. I'd like to
wait to see other's comments.
As for orderBy, maybe we can keep it as is?
---
If
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8920#issuecomment-145613690
[Test build #43244 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43244/consoleFull)
for PR 8920 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8920#issuecomment-145610834
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8920#issuecomment-145610772
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8920#issuecomment-145619261
[Test build #43244 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43244/console)
for PR 8920 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8920#issuecomment-145619405
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8920#issuecomment-145619402
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user NarineK commented on the pull request:
https://github.com/apache/spark/pull/8920#issuecomment-145657747
@sun-rui Thanks!
Done the changes, please check it out.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user sun-rui commented on a diff in the pull request:
https://github.com/apache/spark/pull/8920#discussion_r41112866
--- Diff: R/pkg/R/DataFrame.R ---
@@ -1304,24 +1306,62 @@ setClassUnion("characterOrColumn", c("character",
"Column"))
#' path <- "path/to/file.json"
Github user sun-rui commented on a diff in the pull request:
https://github.com/apache/spark/pull/8920#discussion_r41112848
--- Diff: R/pkg/R/DataFrame.R ---
@@ -1304,24 +1306,62 @@ setClassUnion("characterOrColumn", c("character",
"Column"))
#' path <- "path/to/file.json"
Github user sun-rui commented on a diff in the pull request:
https://github.com/apache/spark/pull/8920#discussion_r41112869
--- Diff: R/pkg/R/DataFrame.R ---
@@ -1304,24 +1306,62 @@ setClassUnion("characterOrColumn", c("character",
"Column"))
#' path <- "path/to/file.json"
Github user sun-rui commented on a diff in the pull request:
https://github.com/apache/spark/pull/8920#discussion_r41112888
--- Diff: R/pkg/R/DataFrame.R ---
@@ -1304,24 +1306,62 @@ setClassUnion("characterOrColumn", c("character",
"Column"))
#' path <- "path/to/file.json"
Github user sun-rui commented on a diff in the pull request:
https://github.com/apache/spark/pull/8920#discussion_r41112934
--- Diff: R/pkg/R/DataFrame.R ---
@@ -1304,24 +1306,62 @@ setClassUnion("characterOrColumn", c("character",
"Column"))
#' path <- "path/to/file.json"
Github user sun-rui commented on a diff in the pull request:
https://github.com/apache/spark/pull/8920#discussion_r41112920
--- Diff: R/pkg/R/DataFrame.R ---
@@ -1304,24 +1306,62 @@ setClassUnion("characterOrColumn", c("character",
"Column"))
#' path <- "path/to/file.json"
Github user sun-rui commented on a diff in the pull request:
https://github.com/apache/spark/pull/8920#discussion_r41112880
--- Diff: R/pkg/R/DataFrame.R ---
@@ -1304,24 +1306,62 @@ setClassUnion("characterOrColumn", c("character",
"Column"))
#' path <- "path/to/file.json"
Github user sun-rui commented on a diff in the pull request:
https://github.com/apache/spark/pull/8920#discussion_r41112991
--- Diff: R/pkg/inst/tests/test_sparkSQL.R ---
@@ -992,6 +992,15 @@ test_that("arrange() and orderBy() on a DataFrame", {
sorted4 <- orderBy(df,
Github user sun-rui commented on a diff in the pull request:
https://github.com/apache/spark/pull/8920#discussion_r41112983
--- Diff: R/pkg/inst/tests/test_sparkSQL.R ---
@@ -992,6 +992,15 @@ test_that("arrange() and orderBy() on a DataFrame", {
sorted4 <- orderBy(df,
Github user sun-rui commented on a diff in the pull request:
https://github.com/apache/spark/pull/8920#discussion_r41112965
--- Diff: R/pkg/R/generics.R ---
@@ -393,7 +393,7 @@ setGeneric("agg", function (x, ...) {
standardGeneric("agg") })
#' @rdname arrange
#'
Github user sun-rui commented on a diff in the pull request:
https://github.com/apache/spark/pull/8920#discussion_r41112944
--- Diff: R/pkg/R/DataFrame.R ---
@@ -1304,24 +1306,62 @@ setClassUnion("characterOrColumn", c("character",
"Column"))
#' path <- "path/to/file.json"
Github user NarineK commented on the pull request:
https://github.com/apache/spark/pull/8920#issuecomment-145676948
also, I hope you won't mind if I change col type in orderBy from
characterOrColumn to only Column.
This will make more sense
---
If your project is set up for
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8920#issuecomment-145418831
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8920#issuecomment-145418844
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8920#issuecomment-145423172
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8920#issuecomment-145423162
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8920#issuecomment-145424739
[Test build #43233 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43233/consoleFull)
for PR 8920 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8920#issuecomment-145419045
[Test build #43231 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43231/consoleFull)
for PR 8920 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8920#issuecomment-145419978
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8920#issuecomment-145419943
[Test build #43231 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43231/console)
for PR 8920 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8920#issuecomment-145419979
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8920#issuecomment-145430083
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8920#issuecomment-145430081
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8920#issuecomment-145430069
[Test build #43233 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43233/console)
for PR 8920 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8920#issuecomment-145279302
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8920#issuecomment-145279301
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8920#issuecomment-145276500
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8920#issuecomment-145276521
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8920#issuecomment-145279274
[Test build #43217 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43217/console)
for PR 8920 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8920#issuecomment-145277233
[Test build #43217 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43217/consoleFull)
for PR 8920 at commit
Github user NarineK commented on the pull request:
https://github.com/apache/spark/pull/8920#issuecomment-145278471
Hi guys,
I have been playing with different options of implementing this.
1. The first thing I tried is to override arrange twice. Smth like this:
Github user NarineK commented on the pull request:
https://github.com/apache/spark/pull/8920#issuecomment-145313727
@sun-rui the problem is in the following:
when we generate the documentation we also should be able to find it
through help.
For example when we do
Github user sun-rui commented on the pull request:
https://github.com/apache/spark/pull/8920#issuecomment-145315619
Could you take the select function of DataFrame as example? For an S4
generic function, we can have multiple S4 methods for it, and the documentation
for them can be
Github user sun-rui commented on the pull request:
https://github.com/apache/spark/pull/8920#issuecomment-145311152
@NarineK, I like your first option:
arrange(x, col="Column", )
arrange(x, col="character", ..., decreasing=FALSE)
I don't understand your issues
Github user olarayej commented on the pull request:
https://github.com/apache/spark/pull/8920#issuecomment-144809819
@shivaram @felixcheung @sun-rui Thanks for your feedback!
I totally see your point with the naming (sort vs. arrange), but @NarineK's
implementation has two
Github user NarineK commented on the pull request:
https://github.com/apache/spark/pull/8920#issuecomment-144632133
And we did support that sort function for dataframe because we couldn't
have it for columns. I cannot add it to SparkR columns either ...
---
If your project is set
Github user NarineK commented on the pull request:
https://github.com/apache/spark/pull/8920#issuecomment-144629036
okay, our customers had that sort for dataframes too but it seems that R
doesn't have it for dataframe.
Now let's decide what do we want to do.
we can have
Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/8920#discussion_r40991013
--- Diff: R/pkg/R/DataFrame.R ---
@@ -1848,3 +1848,57 @@ setMethod("crosstab",
sct <- callJMethod(statFunctions, "crosstab", col1, col2)
Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/8920#discussion_r40991002
--- Diff: R/pkg/R/DataFrame.R ---
@@ -1848,3 +1848,57 @@ setMethod("crosstab",
sct <- callJMethod(statFunctions, "crosstab", col1, col2)
Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/8920#discussion_r40990993
--- Diff: R/pkg/R/DataFrame.R ---
@@ -1848,3 +1848,57 @@ setMethod("crosstab",
sct <- callJMethod(statFunctions, "crosstab", col1, col2)
Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/8920#discussion_r40990962
--- Diff: R/pkg/R/DataFrame.R ---
@@ -1848,3 +1848,57 @@ setMethod("crosstab",
sct <- callJMethod(statFunctions, "crosstab", col1, col2)
Github user shivaram commented on the pull request:
https://github.com/apache/spark/pull/8920#issuecomment-144915941
Thanks @olarayej for summarizing the points. I am actually fine with having
two verbs `arrange` and `sort` for the same functionality. But thing that I'd
like to avoid
Github user felixcheung commented on the pull request:
https://github.com/apache/spark/pull/8920#issuecomment-144497624
looks good!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user NarineK commented on the pull request:
https://github.com/apache/spark/pull/8920#issuecomment-144525188
Thanks! Would you mind, please, assigning the corresponding jira to me and
resolving it ?
---
If your project is set up for it, you can reply to this email and have
Github user shivaram commented on the pull request:
https://github.com/apache/spark/pull/8920#issuecomment-144543047
@sun-rui Could you take one more look ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user sun-rui commented on the pull request:
https://github.com/apache/spark/pull/8920#issuecomment-144615116
My concern is still the name. Maybe we can make it combine with arrange().
@NarineK, could you update the function description more accurate (param),
also
Github user NarineK commented on the pull request:
https://github.com/apache/spark/pull/8920#issuecomment-144619340
Hi sun-rui,
I'll do the correction with param. I'm not sure what do you mean with
coding style issues for dontrun {}.
I did it exactly as arrange and added
Github user felixcheung commented on the pull request:
https://github.com/apache/spark/pull/8920#issuecomment-144621929
I think @sun-rui does have a point here. Generally in R, `sort` is for list
& vector
https://stat.ethz.ch/R-manual/R-devel/library/base/html/sort.html
Github user felixcheung commented on the pull request:
https://github.com/apache/spark/pull/8920#issuecomment-144626919
I think `arrange` does work with both column name strings or Column:
```
setMethod("arrange",
signature(x = "DataFrame", col =
Github user NarineK commented on the pull request:
https://github.com/apache/spark/pull/8920#issuecomment-144623226
okay, I see. For columns we probably cannot add sort right now because the
dataframe api doesn't have it.
For my understanding arrange isn't doing sorting for
Github user NarineK commented on the pull request:
https://github.com/apache/spark/pull/8920#issuecomment-144627088
order is for vectors:
http://www.inside-r.org/r-doc/base/order
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user NarineK commented on the pull request:
https://github.com/apache/spark/pull/8920#issuecomment-144627139
I cannot understand one thing why are we supporting string column types
here:
setMethod("arrange",
signature(x = "DataFrame", col =
Github user sun-rui commented on the pull request:
https://github.com/apache/spark/pull/8920#issuecomment-143981017
Originally, we implemented a "sortDF" function in SparkR DataFrame
corresponds to the "sort" function of the Scala DataFrame. Later, "sortDF" was
renamed to "arrange"
Github user sun-rui commented on a diff in the pull request:
https://github.com/apache/spark/pull/8920#discussion_r40646379
--- Diff: R/pkg/R/DataFrame.R ---
@@ -1848,3 +1848,78 @@ setMethod("crosstab",
sct <- callJMethod(statFunctions, "crosstab", col1, col2)
Github user sun-rui commented on a diff in the pull request:
https://github.com/apache/spark/pull/8920#discussion_r40645685
--- Diff: R/pkg/R/DataFrame.R ---
@@ -1848,3 +1848,78 @@ setMethod("crosstab",
sct <- callJMethod(statFunctions, "crosstab", col1, col2)
Github user NarineK commented on a diff in the pull request:
https://github.com/apache/spark/pull/8920#discussion_r40639413
--- Diff: R/pkg/R/DataFrame.R ---
@@ -1848,3 +1848,67 @@ setMethod("crosstab",
sct <- callJMethod(statFunctions, "crosstab", col1, col2)
Github user sun-rui commented on a diff in the pull request:
https://github.com/apache/spark/pull/8920#discussion_r40645086
--- Diff: R/pkg/R/DataFrame.R ---
@@ -1848,3 +1848,78 @@ setMethod("crosstab",
sct <- callJMethod(statFunctions, "crosstab", col1, col2)
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8920#issuecomment-144103039
[Test build #43085 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43085/console)
for PR 8920 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8920#issuecomment-144101872
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8920#issuecomment-144101906
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8920#issuecomment-144102608
[Test build #43085 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43085/consoleFull)
for PR 8920 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8920#issuecomment-144103047
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8920#issuecomment-144103048
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user NarineK commented on a diff in the pull request:
https://github.com/apache/spark/pull/8920#discussion_r40693133
--- Diff: R/pkg/R/DataFrame.R ---
@@ -1848,3 +1848,78 @@ setMethod("crosstab",
sct <- callJMethod(statFunctions, "crosstab", col1, col2)
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8920#issuecomment-144193976
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8920#issuecomment-144193952
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8920#issuecomment-144195936
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8920#issuecomment-144195639
[Test build #43102 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43102/consoleFull)
for PR 8920 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8920#issuecomment-144197429
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8920#issuecomment-144202901
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user sun-rui commented on a diff in the pull request:
https://github.com/apache/spark/pull/8920#discussion_r40746150
--- Diff: R/pkg/R/DataFrame.R ---
@@ -1848,3 +1848,62 @@ setMethod("crosstab",
sct <- callJMethod(statFunctions, "crosstab", col1, col2)
Github user NarineK commented on a diff in the pull request:
https://github.com/apache/spark/pull/8920#discussion_r40732314
--- Diff: R/pkg/R/DataFrame.R ---
@@ -1848,3 +1848,78 @@ setMethod("crosstab",
sct <- callJMethod(statFunctions, "crosstab", col1, col2)
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8920#issuecomment-144195933
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8920#issuecomment-144199211
[Test build #43103 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43103/consoleFull)
for PR 8920 at commit
1 - 100 of 131 matches
Mail list logo
