Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/10384#issuecomment-168979726
Merged to master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/10384
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10384#issuecomment-168778083
**[Test build #48680 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48680/consoleFull)**
for PR 10384 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10384#issuecomment-168791849
**[Test build #48680 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48680/consoleFull)**
for PR 10384 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10384#issuecomment-168792027
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10384#issuecomment-168792025
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10384#discussion_r48692216
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/evaluation/RegressionMetrics.scala
---
@@ -27,11 +27,17 @@ import org.apache.spark.sql.DataFrame
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/10384#issuecomment-168523352
LGTM except minor issues pointed out by @srowen Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10384#issuecomment-16805
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10384#issuecomment-16803
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10384#issuecomment-168022137
**[Test build #48487 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48487/consoleFull)**
for PR 10384 at commit
Github user iyounus commented on the pull request:
https://github.com/apache/spark/pull/10384#issuecomment-168013749
Just made the changed as suggested by @dbtsai. Sorry for the delay.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/10384#issuecomment-168014617
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10384#issuecomment-168014813
**[Test build #2267 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2267/consoleFull)**
for PR 10384 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10384#issuecomment-168015796
**[Test build #48487 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48487/consoleFull)**
for PR 10384 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10384#issuecomment-168020269
**[Test build #2267 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2267/consoleFull)**
for PR 10384 at commit
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/10384#issuecomment-167774912
@iyounus are you still working on this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/10384#discussion_r48355484
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/evaluation/RegressionMetrics.scala
---
@@ -23,15 +23,23 @@ import org.apache.spark.Logging
import
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/10384#discussion_r48390400
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/evaluation/RegressionMetrics.scala
---
@@ -53,6 +58,7 @@ class RegressionMetrics @Since("1.2.0") (
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/10384#discussion_r48390399
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/evaluation/RegressionMetrics.scala
---
@@ -61,7 +67,6 @@ class RegressionMetrics @Since("1.2.0") (
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/10384#discussion_r48390247
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/evaluation/RegressionMetrics.scala
---
@@ -23,15 +23,23 @@ import org.apache.spark.Logging
import
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/10384#issuecomment-167017269
LGTM except minor issues. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user iyounus commented on a diff in the pull request:
https://github.com/apache/spark/pull/10384#discussion_r48287387
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/evaluation/RegressionMetrics.scala
---
@@ -23,15 +23,23 @@ import org.apache.spark.Logging
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10384#issuecomment-166725659
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10384#issuecomment-166725661
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10384#issuecomment-166725501
**[Test build #48210 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48210/consoleFull)**
for PR 10384 at commit
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/10384#discussion_r48239336
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/evaluation/RegressionMetrics.scala
---
@@ -23,15 +23,23 @@ import org.apache.spark.Logging
import
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/10384#discussion_r48239041
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/evaluation/RegressionMetrics.scala
---
@@ -23,15 +23,23 @@ import org.apache.spark.Logging
import
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/10384#discussion_r48239605
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/evaluation/RegressionMetrics.scala
---
@@ -23,15 +23,23 @@ import org.apache.spark.Logging
import
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/10384#discussion_r48239945
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/evaluation/RegressionMetricsSuite.scala
---
@@ -22,91 +22,115 @@ import
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/10384#issuecomment-166558267
That LGTM; let me wait for comments
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10384#discussion_r48252529
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/evaluation/RegressionMetricsSuite.scala
---
@@ -22,91 +22,115 @@ import
Github user iyounus commented on a diff in the pull request:
https://github.com/apache/spark/pull/10384#discussion_r48288460
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/evaluation/RegressionMetricsSuite.scala
---
@@ -22,91 +22,115 @@ import
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10384#issuecomment-166715954
**[Test build #48210 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48210/consoleFull)**
for PR 10384 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10384#issuecomment-166400018
**[Test build #48122 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48122/consoleFull)**
for PR 10384 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10384#issuecomment-166400134
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/10384#issuecomment-166388345
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10384#issuecomment-166400137
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/10384#discussion_r48178585
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/evaluation/RegressionMetrics.scala
---
@@ -105,6 +112,14 @@ class RegressionMetrics @Since("1.2.0") (
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10384#issuecomment-166389342
**[Test build #48122 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48122/consoleFull)**
for PR 10384 at commit
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10384#discussion_r48200071
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/evaluation/RegressionMetrics.scala
---
@@ -23,21 +23,28 @@ import org.apache.spark.Logging
import
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10384#discussion_r48200030
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/evaluation/RegressionMetrics.scala
---
@@ -23,21 +23,28 @@ import org.apache.spark.Logging
import
Github user iyounus commented on a diff in the pull request:
https://github.com/apache/spark/pull/10384#discussion_r4829
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/evaluation/RegressionMetrics.scala
---
@@ -105,6 +112,14 @@ class RegressionMetrics @Since("1.2.0") (
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10384#issuecomment-166469828
**[Test build #48144 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48144/consoleFull)**
for PR 10384 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10384#issuecomment-166470324
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10384#issuecomment-166470316
**[Test build #48144 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48144/consoleFull)**
for PR 10384 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10384#issuecomment-166470322
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user iyounus commented on a diff in the pull request:
https://github.com/apache/spark/pull/10384#discussion_r48199690
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/evaluation/RegressionMetrics.scala
---
@@ -31,13 +30,17 @@ import org.apache.spark.sql.DataFrame
Github user iyounus commented on a diff in the pull request:
https://github.com/apache/spark/pull/10384#discussion_r48209708
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/evaluation/RegressionMetrics.scala
---
@@ -105,6 +112,14 @@ class RegressionMetrics @Since("1.2.0") (
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10384#discussion_r48200114
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/evaluation/RegressionMetrics.scala
---
@@ -31,13 +30,17 @@ import org.apache.spark.sql.DataFrame
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10384#issuecomment-166472716
**[Test build #48146 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48146/consoleFull)**
for PR 10384 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10384#issuecomment-166478969
**[Test build #48146 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48146/consoleFull)**
for PR 10384 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10384#issuecomment-166479111
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10384#issuecomment-166479115
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/10384#discussion_r48164151
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/evaluation/RegressionMetrics.scala
---
@@ -31,13 +30,17 @@ import org.apache.spark.sql.DataFrame
Github user iyounus commented on a diff in the pull request:
https://github.com/apache/spark/pull/10384#discussion_r48072262
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/evaluation/RegressionMetricsSuite.scala
---
@@ -22,91 +22,111 @@ import
56 matches
Mail list logo
