Github user BryanCutler commented on the pull request:
https://github.com/apache/spark/pull/11746#issuecomment-218596801
ping @zsxwing , is this change something you would still consider for 2.0?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user BryanCutler commented on the pull request:
https://github.com/apache/spark/pull/11746#issuecomment-215216360
ping @zsxwing , would you mind taking another look?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user BryanCutler commented on the pull request:
https://github.com/apache/spark/pull/11746#issuecomment-212652411
@zsxwing I reverted back to the original thread logic, which was actually
fine and thread-safe - I just needed to move the `killed` flag to be set just
before
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11746#issuecomment-212102206
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11746#issuecomment-212102210
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11746#issuecomment-212101582
**[Test build #56241 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56241/consoleFull)**
for PR 11746 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11746#issuecomment-212043059
**[Test build #56241 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56241/consoleFull)**
for PR 11746 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11746#issuecomment-210702183
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11746#issuecomment-210702185
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11746#issuecomment-210702083
**[Test build #55974 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55974/consoleFull)**
for PR 11746 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11746#issuecomment-210676478
**[Test build #55974 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55974/consoleFull)**
for PR 11746 at commit
Github user BryanCutler commented on the pull request:
https://github.com/apache/spark/pull/11746#issuecomment-210676131
jenkins retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11746#issuecomment-210645428
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11746#issuecomment-210645426
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11746#issuecomment-210645244
**[Test build #55946 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55946/consoleFull)**
for PR 11746 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11746#issuecomment-210604288
**[Test build #55946 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55946/consoleFull)**
for PR 11746 at commit
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/11746#discussion_r59799161
--- Diff:
core/src/main/scala/org/apache/spark/deploy/worker/DriverRunner.scala ---
@@ -68,56 +70,72 @@ private[deploy] class DriverRunner(
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/11746#discussion_r59657799
--- Diff:
core/src/main/scala/org/apache/spark/deploy/worker/DriverRunner.scala ---
@@ -68,56 +70,72 @@ private[deploy] class DriverRunner(
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/11746#discussion_r59657657
--- Diff:
core/src/main/scala/org/apache/spark/deploy/worker/DriverRunner.scala ---
@@ -68,56 +70,72 @@ private[deploy] class DriverRunner(
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/11746#discussion_r59654184
--- Diff:
core/src/main/scala/org/apache/spark/deploy/worker/DriverRunner.scala ---
@@ -68,56 +70,72 @@ private[deploy] class DriverRunner(
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/11746#discussion_r59653957
--- Diff:
core/src/main/scala/org/apache/spark/deploy/worker/DriverRunner.scala ---
@@ -68,56 +70,72 @@ private[deploy] class DriverRunner(
Github user BryanCutler commented on the pull request:
https://github.com/apache/spark/pull/11746#issuecomment-209651058
ping @zsxwing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11746#issuecomment-205504232
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11746#issuecomment-205504236
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11746#issuecomment-205503765
**[Test build #54876 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54876/consoleFull)**
for PR 11746 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11746#issuecomment-205502927
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11746#issuecomment-205502924
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11746#issuecomment-205502622
**[Test build #54874 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54874/consoleFull)**
for PR 11746 at commit
Github user BryanCutler commented on the pull request:
https://github.com/apache/spark/pull/11746#issuecomment-205451978
Hi @zsxwing , thanks for checking this out! I made a couple changes to fix
the race condition you pointed out. The shutdown hook now calls `kill()` which
will
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11746#issuecomment-205447269
**[Test build #54876 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54876/consoleFull)**
for PR 11746 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11746#issuecomment-205445572
**[Test build #54874 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54874/consoleFull)**
for PR 11746 at commit
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/11746#discussion_r57418729
--- Diff:
core/src/main/scala/org/apache/spark/deploy/worker/DriverRunner.scala ---
@@ -68,56 +71,67 @@ private[deploy] class DriverRunner(
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/11746#discussion_r57398970
--- Diff:
core/src/main/scala/org/apache/spark/deploy/worker/DriverRunner.scala ---
@@ -68,56 +71,67 @@ private[deploy] class DriverRunner(
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/11746#discussion_r57396560
--- Diff:
core/src/main/scala/org/apache/spark/deploy/worker/DriverRunner.scala ---
@@ -181,42 +211,43 @@ private[deploy] class DriverRunner(
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/11746#discussion_r57394811
--- Diff:
core/src/main/scala/org/apache/spark/deploy/worker/DriverRunner.scala ---
@@ -49,13 +49,16 @@ private[deploy] class DriverRunner(
val
Github user BryanCutler commented on the pull request:
https://github.com/apache/spark/pull/11746#issuecomment-200450185
Hi @zsxwing , did you get a chance to look at this yet?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user BryanCutler commented on the pull request:
https://github.com/apache/spark/pull/11746#issuecomment-198019588
It would be good to remove that note in `ExecutorRunner` then, since the
hook is not redundant.
---
If your project is set up for it, you can reply to this email
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11746#issuecomment-198142673
**[Test build #53475 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53475/consoleFull)**
for PR 11746 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11746#issuecomment-198104997
**[Test build #53475 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53475/consoleFull)**
for PR 11746 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11746#issuecomment-198142813
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/11746#issuecomment-197461487
> @zsxwing I was researching the note in ExecutorRunner here and I believe
they are talking about the WorkerWatcher. This seemed to mostly kill the driver
process but
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11746#issuecomment-198142815
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11746#issuecomment-197117903
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11746#issuecomment-197117900
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11746#issuecomment-197117765
**[Test build #53247 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53247/consoleFull)**
for PR 11746 at commit
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/11746#discussion_r56270216
--- Diff:
core/src/main/scala/org/apache/spark/deploy/worker/DriverRunner.scala ---
@@ -67,56 +70,67 @@ private[deploy] class DriverRunner(
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/11746#discussion_r56269865
--- Diff:
core/src/main/scala/org/apache/spark/deploy/worker/DriverRunner.scala ---
@@ -48,13 +48,16 @@ private[deploy] class DriverRunner(
val
Github user BryanCutler commented on the pull request:
https://github.com/apache/spark/pull/11746#issuecomment-197096227
@zsxwing I was researching the note in `ExecutorRunner`
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11746#issuecomment-197082797
**[Test build #53247 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53247/consoleFull)**
for PR 11746 at commit
GitHub user BryanCutler opened a pull request:
https://github.com/apache/spark/pull/11746
[SPARK-13602][CORE] Add shutdown hook to DriverRunner to prevent driver
process leak
## What changes were proposed in this pull request?
Added shutdown hook to DriverRunner to kill
50 matches
Mail list logo
