Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/12081
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12081#issuecomment-217286617
Alright, this is mainly just test changes now. LGTM merging into master 2.0.
---
If your project is set up for it, you can reply to this email and have your
reply ap
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12081#issuecomment-217074209
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12081#issuecomment-217074492
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12081#issuecomment-217074490
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12081#issuecomment-217074394
**[Test build #57831 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57831/consoleFull)**
for PR 12081 at commit
[`b190b86`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12081#issuecomment-217074116
**[Test build #57830 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57830/consoleFull)**
for PR 12081 at commit
[`55cf518`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12081#issuecomment-217074208
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12081#issuecomment-217064204
**[Test build #57831 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57831/consoleFull)**
for PR 12081 at commit
[`b190b86`](https://gi
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12081#issuecomment-217063822
**[Test build #57830 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57830/consoleFull)**
for PR 12081 at commit
[`55cf518`](https://gi
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/12081#discussion_r62143597
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -57,7 +60,7 @@ case class CreateDatabase(
CatalogData
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/12081#discussion_r62106217
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -57,7 +60,7 @@ case class CreateDatabase(
CatalogData
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/12081#discussion_r62105086
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -365,4 +381,113 @@ class HiveDDLSuite extends QueryTest w
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/12081#discussion_r62105072
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -365,4 +381,113 @@ class HiveDDLSuite extends QueryTest w
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/12081#discussion_r62104915
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -20,21 +20,37 @@ package org.apache.spark.sql.hive.execut
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/12081#discussion_r62104748
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
---
@@ -95,49 +95,85 @@ class DDLSuite extends QueryTest with Sha
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/12081#discussion_r62104377
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -148,9 +148,17 @@ class SessionCatalog(
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12081#discussion_r62103858
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -57,7 +60,7 @@ case class CreateDatabase(
CatalogData
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12081#discussion_r62103066
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -148,9 +148,17 @@ class SessionCatalog(
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/12081#issuecomment-216979776
@gatorsmile Thank you for updating this. Can you address my comments? Then,
let's get it in!
---
If your project is set up for it, you can reply to this email and have y
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12081#discussion_r62101534
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -365,4 +381,113 @@ class HiveDDLSuite extends QueryTest with
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12081#discussion_r62101477
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -365,4 +381,113 @@ class HiveDDLSuite extends QueryTest with
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12081#discussion_r62100995
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -20,21 +20,37 @@ package org.apache.spark.sql.hive.execution
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12081#discussion_r62100913
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -57,7 +60,7 @@ case class CreateDatabase(
CatalogDatabase(
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12081#discussion_r62100306
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
---
@@ -95,49 +95,85 @@ class DDLSuite extends QueryTest with SharedSQ
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12081#discussion_r62100086
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -57,7 +60,7 @@ case class CreateDatabase(
CatalogDatabase(
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12081#issuecomment-216967458
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12081#issuecomment-216967453
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12081#issuecomment-216967090
**[Test build #57772 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57772/consoleFull)**
for PR 12081 at commit
[`838eaeb`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12081#issuecomment-216940066
**[Test build #57772 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57772/consoleFull)**
for PR 12081 at commit
[`838eaeb`](https://gi
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/12081#issuecomment-216895583
: ) This one needs to be rebased again. 9 times
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If yo
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12081#issuecomment-216764582
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12081#issuecomment-216764581
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12081#issuecomment-216764411
**[Test build #57722 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57722/consoleFull)**
for PR 12081 at commit
[`b885f7b`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12081#issuecomment-216761773
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12081#issuecomment-216761778
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12081#issuecomment-216761612
**[Test build #57717 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57717/consoleFull)**
for PR 12081 at commit
[`59a9805`](https://g
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/12081#issuecomment-216752333
@andrewor14 I also think about creating directory in implementation of
create database.
Metastore APIs created the directory for us no matter whether the pr
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12081#issuecomment-216751211
**[Test build #57722 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57722/consoleFull)**
for PR 12081 at commit
[`b885f7b`](https://gi
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/12081#discussion_r61991923
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -148,9 +148,17 @@ class SessionCatalog(
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12081#issuecomment-216748843
**[Test build #57717 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57717/consoleFull)**
for PR 12081 at commit
[`59a9805`](https://gi
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/12081#discussion_r61991201
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -348,4 +364,99 @@ class HiveDDLSuite extends QueryTest wi
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/12081#discussion_r61988141
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -348,4 +364,99 @@ class HiveDDLSuite extends QueryTest wit
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/12081#discussion_r61983213
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -148,9 +148,17 @@ class SessionCatalog(
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/12081#issuecomment-216719267
@andrewor14 You know, this PR has many changes since its initial version.
Originally, the focus of this PR is to create a correct warehouse directory.
Later, a few r
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/12081#discussion_r61983027
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -148,9 +148,17 @@ class SessionCatalog(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/12081#discussion_r61982747
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -148,9 +148,17 @@ class SessionCatalog(
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12081#issuecomment-216692119
@gatorsmile I took a quick look and I think the logic can be simpler. There
are a lot of random checks that don't seem necessary to me. Actually I thought
the origin
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12081#discussion_r61971480
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -148,9 +148,17 @@ class SessionCatalog(
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12081#discussion_r61971054
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -148,9 +148,17 @@ class SessionCatalog(
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12081#discussion_r61970888
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -148,9 +148,17 @@ class SessionCatalog(
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/12081#issuecomment-216585702
@cloud-fan Your PR https://github.com/apache/spark/pull/12871 is related to
this. Could you please review this? Thanks!
---
If your project is set up for it, you ca
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/12081#issuecomment-216099984
cc @liancheng @yhuai It is ready for review. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12081#issuecomment-216051049
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12081#issuecomment-216051048
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12081#issuecomment-216050996
**[Test build #57480 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57480/consoleFull)**
for PR 12081 at commit
[`95d9a00`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12081#issuecomment-216044152
**[Test build #57480 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57480/consoleFull)**
for PR 12081 at commit
[`95d9a00`](https://gi
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/12081#discussion_r61283810
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -693,7 +697,6 @@ class SessionCatalog(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/12081#discussion_r61284231
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
---
@@ -118,7 +148,7 @@ class DDLSuite extends QueryTest with Sha
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/12081#discussion_r61284167
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -693,7 +697,6 @@ class SessionCatalog(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/12081#discussion_r61283076
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
---
@@ -118,7 +148,7 @@ class DDLSuite extends QueryTest with Sha
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/12081#discussion_r61282206
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
---
@@ -118,7 +148,7 @@ class DDLSuite extends QueryTest with Shar
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/12081#discussion_r61278961
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -693,7 +697,6 @@ class SessionCatalog(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/12081#discussion_r61279827
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -693,7 +697,6 @@ class SessionCatalog(
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12081#issuecomment-214942151
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12081#issuecomment-214942149
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12081#issuecomment-214941942
**[Test build #57059 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57059/consoleFull)**
for PR 12081 at commit
[`1da261a`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12081#issuecomment-214926445
**[Test build #57059 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57059/consoleFull)**
for PR 12081 at commit
[`1da261a`](https://gi
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/12081#issuecomment-214890715
Many test cases called `SQLConf.clear()` and cleaned all the
configurations. When we reloading the conf, we did not load the Hive-related
configurations.
---
If y
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12081#issuecomment-214823253
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12081#issuecomment-214823248
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12081#issuecomment-214823028
**[Test build #57004 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57004/consoleFull)**
for PR 12081 at commit
[`375b692`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12081#issuecomment-214802017
**[Test build #57004 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57004/consoleFull)**
for PR 12081 at commit
[`375b692`](https://gi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12081#issuecomment-214661567
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12081#issuecomment-214661565
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12081#issuecomment-214661418
**[Test build #56980 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56980/consoleFull)**
for PR 12081 at commit
[`a2d71fd`](https://g
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/12081#issuecomment-214638243
@rxin Thanks for the review!
So far, `DDLSuite` only contains the test cases for `InMemoryCatalog`. To
verify the behaviors of `HiveExternalCatalog`, we add
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12081#issuecomment-214637798
**[Test build #56980 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56980/consoleFull)**
for PR 12081 at commit
[`a2d71fd`](https://gi
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/12081#discussion_r60939762
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -121,8 +123,11 @@ class SessionCatalog(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/12081#discussion_r60939806
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -650,7 +655,12 @@ class SessionCatalog(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/12081#discussion_r60939726
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveSessionCatalog.scala ---
@@ -75,9 +76,22 @@ private[sql] class HiveSessionCatalog(
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12081#discussion_r60866200
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -650,7 +655,12 @@ class SessionCatalog(
drop
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/12081#issuecomment-214139613
Also we should NOT depend on Hive config values.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12081#discussion_r60863754
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -121,8 +123,11 @@ class SessionCatalog(
curren
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12081#discussion_r60863712
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveSessionCatalog.scala ---
@@ -75,9 +76,22 @@ private[sql] class HiveSessionCatalog(
// | M
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/12081#issuecomment-214138038
@gatorsmile the new DDLs shouldn't go to the Hive package. We should put
all the DDLs in the sql/core package.
---
If your project is set up for it, you can reply to thi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12081#issuecomment-214130068
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12081#issuecomment-214130069
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12081#issuecomment-214129992
**[Test build #56872 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56872/consoleFull)**
for PR 12081 at commit
[`44fdf83`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12081#issuecomment-214104242
**[Test build #56872 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56872/consoleFull)**
for PR 12081 at commit
[`44fdf83`](https://gi
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/12081#issuecomment-214103737
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12081#issuecomment-213257176
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12081#issuecomment-213257173
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12081#issuecomment-213257067
**[Test build #56643 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56643/consoleFull)**
for PR 12081 at commit
[`44fdf83`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12081#issuecomment-213229969
**[Test build #56643 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56643/consoleFull)**
for PR 12081 at commit
[`44fdf83`](https://gi
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/12081#issuecomment-213228654
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12081#issuecomment-213224445
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12081#issuecomment-213224442
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12081#issuecomment-213224364
**[Test build #56631 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56631/consoleFull)**
for PR 12081 at commit
[`44fdf83`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12081#issuecomment-213208107
**[Test build #56631 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56631/consoleFull)**
for PR 12081 at commit
[`44fdf83`](https://gi
1 - 100 of 280 matches
Mail list logo
