Github user berngp commented on the pull request:
https://github.com/apache/spark/pull/433#issuecomment-45523729
@tgravescs I fixed the test, squashed the commit and repointed the branch.
The latest commit addresses the test failure you were seeing while running it
for Hadoop 0.23.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/433
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/433#issuecomment-45545343
Looks good. Thanks @berngp
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user berngp commented on a diff in the pull request:
https://github.com/apache/spark/pull/433#discussion_r13499967
--- Diff:
yarn/common/src/test/scala/org/apache/spark/deploy/yarn/ClientBaseSuite.scala
---
@@ -0,0 +1,112 @@
+/*
+ * Licensed to the Apache Software
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/433#discussion_r13456889
--- Diff:
yarn/common/src/test/scala/org/apache/spark/deploy/yarn/ClientBaseSuite.scala
---
@@ -0,0 +1,104 @@
+/*
+ * Licensed to the Apache
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/433#discussion_r13456914
--- Diff:
yarn/common/src/test/scala/org/apache/spark/deploy/yarn/ClientBaseSuite.scala
---
@@ -0,0 +1,104 @@
+/*
+ * Licensed to the Apache
Github user berngp commented on a diff in the pull request:
https://github.com/apache/spark/pull/433#discussion_r13458231
--- Diff:
yarn/common/src/test/scala/org/apache/spark/deploy/yarn/ClientBaseSuite.scala
---
@@ -0,0 +1,104 @@
+/*
+ * Licensed to the Apache Software
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/433#issuecomment-45264422
Mostly looks good. Fix those couple minor test issues for hadoop 0.23 and
I'll commit it.
---
If your project is set up for it, you can reply to this email and have
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/433#issuecomment-45146709
@berngp can you upmerge to the latest master?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user berngp commented on the pull request:
https://github.com/apache/spark/pull/433#issuecomment-45159895
@tgravescs done, thank you again for following this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/433#issuecomment-43892089
There is still a lot going on with spark 1.0. I'm going to wait for that to
setting down and then review this.
---
If your project is set up for it, you can reply to
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/433#issuecomment-43404871
@berngp sorry for the delay I think everyone has been busy with the spark
1.0 release. I think this should still be fixed in spark 1.1. Lets leave this
pr as is and
Github user berngp commented on the pull request:
https://github.com/apache/spark/pull/433#issuecomment-43383729
@tgravescs any thoughts around this, should I just close this pull request?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user berngp commented on the pull request:
https://github.com/apache/spark/pull/433#issuecomment-42254447
Hi all, just checking the state of affairs with this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user berngp commented on the pull request:
https://github.com/apache/spark/pull/433#issuecomment-41725598
So @sryza, @tgravescs and @pwendell should we increase the scope of the
changes or close this one, merge it hopefully, and create a broader ticket to
address testing and
Github user rahulsinghaliitd commented on a diff in the pull request:
https://github.com/apache/spark/pull/433#discussion_r11917001
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ClientBase.scala ---
@@ -354,63 +354,85 @@ trait ClientBase extends Logging {
Github user berngp commented on a diff in the pull request:
https://github.com/apache/spark/pull/433#discussion_r11917358
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ClientBase.scala ---
@@ -354,63 +354,85 @@ trait ClientBase extends Logging {
}
}
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/433#discussion_r11918623
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ClientBase.scala ---
@@ -354,63 +354,85 @@ trait ClientBase extends Logging {
}
}
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/433#discussion_r11918859
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ClientBase.scala ---
@@ -354,63 +354,85 @@ trait ClientBase extends Logging {
}
}
Github user rahulsinghaliitd commented on a diff in the pull request:
https://github.com/apache/spark/pull/433#discussion_r11920472
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ClientBase.scala ---
@@ -354,63 +354,85 @@ trait ClientBase extends Logging {
Github user berngp commented on a diff in the pull request:
https://github.com/apache/spark/pull/433#discussion_r11920584
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ClientBase.scala ---
@@ -354,63 +354,85 @@ trait ClientBase extends Logging {
}
}
Github user berngp commented on a diff in the pull request:
https://github.com/apache/spark/pull/433#discussion_r11920723
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ClientBase.scala ---
@@ -354,63 +354,85 @@ trait ClientBase extends Logging {
}
}
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/433#discussion_r11927317
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ClientBase.scala ---
@@ -354,63 +354,85 @@ trait ClientBase extends Logging {
}
}
Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/433#discussion_r11876372
--- Diff: core/src/main/scala/org/apache/spark/Logging.scala ---
@@ -95,6 +97,15 @@ trait Logging {
if (log.isErrorEnabled) log.error(msg, throwable)
Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/433#discussion_r11876388
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ClientBase.scala ---
@@ -354,63 +354,79 @@ trait ClientBase extends Logging {
}
Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/433#discussion_r11876408
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ClientBase.scala ---
@@ -354,63 +354,79 @@ trait ClientBase extends Logging {
}
Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/433#discussion_r11876544
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ClientBase.scala ---
@@ -354,63 +354,79 @@ trait ClientBase extends Logging {
}
Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/433#discussion_r11876568
--- Diff: core/src/main/scala/org/apache/spark/Logging.scala ---
@@ -95,6 +97,15 @@ trait Logging {
if (log.isErrorEnabled) log.error(msg, throwable)
Github user berngp commented on a diff in the pull request:
https://github.com/apache/spark/pull/433#discussion_r11876560
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ClientBase.scala ---
@@ -354,63 +354,79 @@ trait ClientBase extends Logging {
}
}
Github user berngp commented on a diff in the pull request:
https://github.com/apache/spark/pull/433#discussion_r11876713
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ClientBase.scala ---
@@ -354,63 +354,79 @@ trait ClientBase extends Logging {
}
}
Github user berngp commented on a diff in the pull request:
https://github.com/apache/spark/pull/433#discussion_r11876756
--- Diff: core/src/main/scala/org/apache/spark/Logging.scala ---
@@ -95,6 +97,15 @@ trait Logging {
if (log.isErrorEnabled) log.error(msg, throwable)
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/433#issuecomment-41097662
Hey just a heads up - I've submitted a smaller one-line fix for the
original issue as part of #488 - that's just because I want to pull it into a
release candidate.
Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/433#discussion_r11876879
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ClientBase.scala ---
@@ -354,63 +354,79 @@ trait ClientBase extends Logging {
}
Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/433#discussion_r11876895
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ClientBase.scala ---
@@ -354,63 +354,79 @@ trait ClientBase extends Logging {
}
Github user berngp commented on a diff in the pull request:
https://github.com/apache/spark/pull/433#discussion_r11877368
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ClientBase.scala ---
@@ -354,63 +354,79 @@ trait ClientBase extends Logging {
}
}
Github user berngp commented on the pull request:
https://github.com/apache/spark/pull/433#issuecomment-41124726
@pwendell your one-line fix makes complete sense. Just pushed the changes
you suggested.
---
If your project is set up for it, you can reply to this email and have your
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/433#issuecomment-40808057
Jenkins, test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/433#issuecomment-40808255
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/433#issuecomment-40808261
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/433#issuecomment-40810841
Merged build finished. All automated tests passed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/433#issuecomment-40810842
All automated tests passed.
Refer to this link for build results:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/14236/
---
If your project
Github user berngp commented on the pull request:
https://github.com/apache/spark/pull/433#issuecomment-40833064
Not convinced that build should be failing due _hive/test_ taking too long.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/433#issuecomment-40839991
Don't worry about Travis for now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/433#discussion_r11785222
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ClientBase.scala ---
@@ -361,55 +361,48 @@ object ClientBase {
val
Github user berngp commented on a diff in the pull request:
https://github.com/apache/spark/pull/433#discussion_r11785535
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ClientBase.scala ---
@@ -361,55 +361,48 @@ object ClientBase {
val LOG4J_CONF_ENV_KEY:
Github user berngp commented on a diff in the pull request:
https://github.com/apache/spark/pull/433#discussion_r11785608
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ClientBase.scala ---
@@ -361,55 +361,48 @@ object ClientBase {
val LOG4J_CONF_ENV_KEY:
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/433#discussion_r11785859
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ClientBase.scala ---
@@ -361,55 +361,48 @@ object ClientBase {
val
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/433#discussion_r11785982
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ClientBase.scala ---
@@ -361,55 +361,48 @@ object ClientBase {
val
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/433#issuecomment-40842451
@berngp This is looking good. I will do a quick test of this on a YARN
cluster, and provided that I don't run into anything I think this is good to go.
---
If your
Github user berngp commented on a diff in the pull request:
https://github.com/apache/spark/pull/433#discussion_r11786166
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ClientBase.scala ---
@@ -361,55 +361,48 @@ object ClientBase {
val LOG4J_CONF_ENV_KEY:
Github user berngp commented on the pull request:
https://github.com/apache/spark/pull/433#issuecomment-40842897
Thank you @andrewor14, and again I appreciate very much all the feedback.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/433#discussion_r11786442
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ClientBase.scala ---
@@ -361,55 +361,48 @@ object ClientBase {
val
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/433#discussion_r11786520
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ClientBase.scala ---
@@ -361,55 +361,48 @@ object ClientBase {
val
Github user berngp commented on a diff in the pull request:
https://github.com/apache/spark/pull/433#discussion_r11786824
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ClientBase.scala ---
@@ -361,55 +361,48 @@ object ClientBase {
val LOG4J_CONF_ENV_KEY:
Github user berngp commented on a diff in the pull request:
https://github.com/apache/spark/pull/433#discussion_r11786869
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ClientBase.scala ---
@@ -361,55 +361,48 @@ object ClientBase {
val LOG4J_CONF_ENV_KEY:
Github user berngp commented on a diff in the pull request:
https://github.com/apache/spark/pull/433#discussion_r11786914
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ClientBase.scala ---
@@ -361,55 +361,48 @@ object ClientBase {
val LOG4J_CONF_ENV_KEY:
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/433#discussion_r11786936
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ClientBase.scala ---
@@ -361,55 +361,48 @@ object ClientBase {
val
Github user berngp commented on a diff in the pull request:
https://github.com/apache/spark/pull/433#discussion_r11787690
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ClientBase.scala ---
@@ -361,55 +361,48 @@ object ClientBase {
val LOG4J_CONF_ENV_KEY:
Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/433#discussion_r11788225
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ClientBase.scala ---
@@ -361,55 +361,48 @@ object ClientBase {
val
Github user berngp commented on a diff in the pull request:
https://github.com/apache/spark/pull/433#discussion_r11789723
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ClientBase.scala ---
@@ -361,55 +361,48 @@ object ClientBase {
val LOG4J_CONF_ENV_KEY:
Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/433#discussion_r11789984
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ClientBase.scala ---
@@ -361,55 +361,48 @@ object ClientBase {
val
GitHub user berngp opened a pull request:
https://github.com/apache/spark/pull/433
[SPARK-1522] : YARN ClientBase throws a NPE if there is no YARN applicat...
...ion specific CP
The current implementation of
`ClientBase.getDefaultYarnApplicationClasspath` inspects
the
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/433#issuecomment-40699148
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user berngp commented on a diff in the pull request:
https://github.com/apache/spark/pull/433#discussion_r11726091
--- Diff: project/SparkBuild.scala ---
@@ -52,7 +52,7 @@ object SparkBuild extends Build {
val SCALAC_JVM_VERSION = jvm-1.6
val JAVAC_JVM_VERSION
Github user berngp commented on a diff in the pull request:
https://github.com/apache/spark/pull/433#discussion_r11726156
--- Diff: project/SparkBuild.scala ---
@@ -263,7 +263,7 @@ object SparkBuild extends Build {
org.eclipse.jetty % jetty-util % jettyVersion,
Github user witgo commented on a diff in the pull request:
https://github.com/apache/spark/pull/433#discussion_r11726876
--- Diff: project/SparkBuild.scala ---
@@ -52,7 +52,7 @@ object SparkBuild extends Build {
val SCALAC_JVM_VERSION = jvm-1.6
val JAVAC_JVM_VERSION =
Github user mridulm commented on the pull request:
https://github.com/apache/spark/pull/433#issuecomment-40707049
Most of the changes in the diff look unrelated to what is mentioned in the
summary.
In addition, they introduce additional bugs.
Please cleanup the diffs and
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/433#discussion_r11741951
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ClientBase.scala ---
@@ -378,55 +378,48 @@ object ClientBase {
val APP_JAR: String
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/433#discussion_r11741991
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ClientBase.scala ---
@@ -378,55 +378,48 @@ object ClientBase {
val APP_JAR: String
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/433#discussion_r11745730
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ClientBase.scala ---
@@ -378,55 +378,48 @@ object ClientBase {
val APP_JAR: String
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/433#discussion_r11745870
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ClientBase.scala ---
@@ -378,55 +378,48 @@ object ClientBase {
val APP_JAR: String
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/433#discussion_r11746226
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ClientBase.scala ---
@@ -378,55 +378,48 @@ object ClientBase {
val APP_JAR: String
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/433#discussion_r11746514
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ClientBase.scala ---
@@ -378,55 +378,48 @@ object ClientBase {
val APP_JAR: String
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/433#discussion_r11746787
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ClientBase.scala ---
@@ -378,55 +378,48 @@ object ClientBase {
val APP_JAR: String
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/433#issuecomment-40747230
@berngp Thanks for doing this. I literally ran into this NPE yesterday in
my own YARN cluster. It turns out I forgot to point YARN_CONF_DIR to the proper
place, but
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/433#discussion_r11747100
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ClientBase.scala ---
@@ -378,55 +378,48 @@ object ClientBase {
val APP_JAR: String
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/433#discussion_r11753045
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ClientBase.scala ---
@@ -378,55 +378,48 @@ object ClientBase {
val APP_JAR: String
Github user berngp commented on a diff in the pull request:
https://github.com/apache/spark/pull/433#discussion_r11763040
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ClientBase.scala ---
@@ -378,55 +378,48 @@ object ClientBase {
val APP_JAR: String =
Github user berngp commented on a diff in the pull request:
https://github.com/apache/spark/pull/433#discussion_r11763060
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ClientBase.scala ---
@@ -378,55 +378,48 @@ object ClientBase {
val APP_JAR: String =
Github user berngp commented on a diff in the pull request:
https://github.com/apache/spark/pull/433#discussion_r11763070
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ClientBase.scala ---
@@ -378,55 +378,48 @@ object ClientBase {
val APP_JAR: String =
Github user berngp commented on a diff in the pull request:
https://github.com/apache/spark/pull/433#discussion_r11763107
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ClientBase.scala ---
@@ -378,55 +378,48 @@ object ClientBase {
val APP_JAR: String =
Github user berngp commented on a diff in the pull request:
https://github.com/apache/spark/pull/433#discussion_r11763222
--- Diff:
yarn/common/src/test/scala/org/apache/spark/deploy/yarn/ClientBaseSpec.scala ---
@@ -0,0 +1,97 @@
+/*
+ * Licensed to the Apache Software
82 matches
Mail list logo
