Github user sarutak closed the pull request at:
https://github.com/apache/spark/pull/2019
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2019#issuecomment-53384128
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19203/consoleFull)
for PR 2019 at commit
Github user sarutak commented on the pull request:
https://github.com/apache/spark/pull/2019#issuecomment-53386362
In this PR, I want to resolve following issues.
(1) Race condition between a thread invoking ConnectionManager#stop and a
thread invoking threads invoking
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2019#issuecomment-53388879
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19203/consoleFull)
for PR 2019 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2019#issuecomment-53405037
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19208/consoleFull)
for PR 2019 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2019#issuecomment-53410681
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19208/consoleFull)
for PR 2019 at commit
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2019#discussion_r16726926
--- Diff:
core/src/main/scala/org/apache/spark/network/ConnectionManager.scala ---
@@ -280,42 +280,46 @@ private[spark] class ConnectionManager(
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2019#discussion_r16727606
--- Diff:
core/src/main/scala/org/apache/spark/network/ConnectionManager.scala ---
@@ -280,42 +280,46 @@ private[spark] class ConnectionManager(
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/2019#discussion_r16727729
--- Diff:
core/src/main/scala/org/apache/spark/network/ConnectionManager.scala ---
@@ -280,42 +280,46 @@ private[spark] class ConnectionManager(
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2019#discussion_r16727939
--- Diff:
core/src/main/scala/org/apache/spark/network/ConnectionManager.scala ---
@@ -280,42 +280,46 @@ private[spark] class ConnectionManager(
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/2019#discussion_r16727953
--- Diff:
core/src/main/scala/org/apache/spark/network/ConnectionManager.scala ---
@@ -280,42 +280,46 @@ private[spark] class ConnectionManager(
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2019#discussion_r16728124
--- Diff:
core/src/main/scala/org/apache/spark/network/ConnectionManager.scala ---
@@ -334,17 +338,23 @@ private[spark] class ConnectionManager(
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2019#discussion_r16728263
--- Diff:
core/src/main/scala/org/apache/spark/network/ConnectionManager.scala ---
@@ -368,32 +378,38 @@ private[spark] class ConnectionManager(
Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/2019#discussion_r16728270
--- Diff:
core/src/main/scala/org/apache/spark/network/ConnectionManager.scala ---
@@ -280,42 +280,46 @@ private[spark] class ConnectionManager(
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/2019#discussion_r16728852
--- Diff:
core/src/main/scala/org/apache/spark/network/ConnectionManager.scala ---
@@ -334,17 +338,23 @@ private[spark] class ConnectionManager(
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/2019#discussion_r16730782
--- Diff:
core/src/main/scala/org/apache/spark/network/ConnectionManager.scala ---
@@ -280,42 +280,46 @@ private[spark] class ConnectionManager(
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/2019#discussion_r16730942
--- Diff:
core/src/main/scala/org/apache/spark/network/ConnectionManager.scala ---
@@ -368,32 +378,38 @@ private[spark] class ConnectionManager(
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2019#discussion_r16731252
--- Diff:
core/src/main/scala/org/apache/spark/network/ConnectionManager.scala ---
@@ -280,42 +280,46 @@ private[spark] class ConnectionManager(
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/2019#discussion_r16731303
--- Diff:
core/src/main/scala/org/apache/spark/network/ConnectionManager.scala ---
@@ -280,42 +280,46 @@ private[spark] class ConnectionManager(
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2019#discussion_r16731768
--- Diff:
core/src/main/scala/org/apache/spark/network/ConnectionManager.scala ---
@@ -280,42 +280,46 @@ private[spark] class ConnectionManager(
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2019#discussion_r16732261
--- Diff:
core/src/main/scala/org/apache/spark/network/ConnectionManager.scala ---
@@ -334,17 +338,23 @@ private[spark] class ConnectionManager(
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/2019#discussion_r16732756
--- Diff:
core/src/main/scala/org/apache/spark/network/ConnectionManager.scala ---
@@ -280,42 +280,46 @@ private[spark] class ConnectionManager(
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2019#discussion_r16733264
--- Diff:
core/src/main/scala/org/apache/spark/network/ConnectionManager.scala ---
@@ -280,42 +280,46 @@ private[spark] class ConnectionManager(
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/2019#discussion_r16736248
--- Diff:
core/src/main/scala/org/apache/spark/network/ConnectionManager.scala ---
@@ -334,17 +338,23 @@ private[spark] class ConnectionManager(
Github user sarutak commented on the pull request:
https://github.com/apache/spark/pull/2019#issuecomment-53192139
One of issues I'd like to resolve in this PR is miss-detection when
SedingConnection is closed by corresponding ReceivingConnection in
removeConnection.
If
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2019#issuecomment-53147147
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19100/consoleFull)
for PR 2019 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2019#issuecomment-53148302
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19100/consoleFull)
for PR 2019 at commit
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/2019#discussion_r16630100
--- Diff: core/src/main/scala/org/apache/spark/network/Connection.scala ---
@@ -118,14 +118,33 @@ abstract class Connection(val channel: SocketChannel,
val
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/2019#discussion_r16630105
--- Diff: core/src/main/scala/org/apache/spark/network/Connection.scala ---
@@ -263,14 +282,20 @@ class SendingConnection(val address:
InetSocketAddress,
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/2019#discussion_r16630107
--- Diff: core/src/main/scala/org/apache/spark/network/Connection.scala ---
@@ -263,14 +282,20 @@ class SendingConnection(val address:
InetSocketAddress,
Github user mridulm commented on the pull request:
https://github.com/apache/spark/pull/2019#issuecomment-53149673
handling tcp/ip events is by definition async, particularly when state
changes can happen orthogonal to state within java variables.
so there is only so much you can
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/2019#discussion_r16631095
--- Diff: core/src/main/scala/org/apache/spark/network/Connection.scala ---
@@ -263,14 +282,20 @@ class SendingConnection(val address:
InetSocketAddress,
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/2019#discussion_r16631373
--- Diff: core/src/main/scala/org/apache/spark/network/Connection.scala ---
@@ -118,14 +118,33 @@ abstract class Connection(val channel: SocketChannel,
val
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/2019#discussion_r16631699
--- Diff: core/src/main/scala/org/apache/spark/network/Connection.scala ---
@@ -118,14 +118,33 @@ abstract class Connection(val channel: SocketChannel,
val
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/2019#discussion_r16631703
--- Diff: core/src/main/scala/org/apache/spark/network/Connection.scala ---
@@ -263,14 +282,20 @@ class SendingConnection(val address:
InetSocketAddress,
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/2019#discussion_r16631901
--- Diff: core/src/main/scala/org/apache/spark/network/Connection.scala ---
@@ -263,14 +282,20 @@ class SendingConnection(val address:
InetSocketAddress,
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/2019#discussion_r16631910
--- Diff: core/src/main/scala/org/apache/spark/network/Connection.scala ---
@@ -118,14 +118,33 @@ abstract class Connection(val channel: SocketChannel,
val
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/2019#discussion_r16631998
--- Diff: core/src/main/scala/org/apache/spark/network/Connection.scala ---
@@ -263,14 +282,20 @@ class SendingConnection(val address:
InetSocketAddress,
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/2019#discussion_r16632025
--- Diff: core/src/main/scala/org/apache/spark/network/Connection.scala ---
@@ -118,14 +118,33 @@ abstract class Connection(val channel: SocketChannel,
val
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/2019#discussion_r16632233
--- Diff: core/src/main/scala/org/apache/spark/network/Connection.scala ---
@@ -263,14 +282,20 @@ class SendingConnection(val address:
InetSocketAddress,
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/2019#discussion_r16632326
--- Diff: core/src/main/scala/org/apache/spark/network/Connection.scala ---
@@ -118,14 +118,33 @@ abstract class Connection(val channel: SocketChannel,
val
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/2019#discussion_r16632362
--- Diff: core/src/main/scala/org/apache/spark/network/Connection.scala ---
@@ -263,14 +282,20 @@ class SendingConnection(val address:
InetSocketAddress,
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2019#issuecomment-52934582
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19057/consoleFull)
for PR 2019 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2019#issuecomment-52951855
**Tests timed out** after a configured wait of `120m`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
44 matches
Mail list logo
