Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4214#discussion_r25464696
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -44,8 +48,15 @@ private[history] class
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4214#discussion_r25465389
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -44,8 +48,15 @@ private[history] class
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/4214
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/4214#issuecomment-76276422
LGTM I'm merging this into master and I will file a new issue for the conf
key issue I mentioned. Thanks for your patience @viper-kun!
---
If your project is set up
Github user viper-kun commented on the pull request:
https://github.com/apache/spark/pull/4214#issuecomment-76109919
@andrewor14 thanks for your check. Pls retest it . I can not get test log.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4214#issuecomment-76110309
[Test build #27974 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27974/consoleFull)
for PR 4214 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4214#issuecomment-76115296
[Test build #27974 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27974/consoleFull)
for PR 4214 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4214#issuecomment-76115303
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4214#issuecomment-76128088
[Test build #27988 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27988/consoleFull)
for PR 4214 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4214#issuecomment-76134530
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4214#issuecomment-76134522
[Test build #27988 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27988/consoleFull)
for PR 4214 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4214#issuecomment-75933886
[Test build #27947 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27947/consoleFull)
for PR 4214 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4214#issuecomment-75933991
[Test build #27947 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27947/consoleFull)
for PR 4214 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4214#issuecomment-75933995
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4214#issuecomment-75325198
[Test build #27791 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27791/consoleFull)
for PR 4214 at commit
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4214#discussion_r25109304
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -230,6 +250,45 @@ private[history] class
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4214#discussion_r25109562
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -230,6 +250,45 @@ private[history] class
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4214#discussion_r25109254
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -73,27 +103,15 @@ private[history] class
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4214#discussion_r25109374
--- Diff: docs/monitoring.md ---
@@ -144,6 +144,29 @@ follows:
If disabled, no access control checks are made.
/td
/tr
+
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4214#discussion_r25109930
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -230,6 +250,45 @@ private[history] class
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4214#issuecomment-75336100
[Test build #27791 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27791/consoleFull)
for PR 4214 at commit
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4214#discussion_r25108992
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -43,9 +47,33 @@ private[history] class
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4214#discussion_r25109452
--- Diff: docs/monitoring.md ---
@@ -144,6 +144,29 @@ follows:
If disabled, no access control checks are made.
/td
/tr
+
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4214#discussion_r25109082
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -73,27 +103,15 @@ private[history] class
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4214#discussion_r25109806
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -230,6 +250,45 @@ private[history] class
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4214#discussion_r25109839
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -230,6 +250,45 @@ private[history] class
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/4214#issuecomment-75334552
@viper-kun Thanks for re-opening this, and my apologies for having
neglected the older patch. I left a few comments inline, most of which are
minor ones that have to
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/4214#issuecomment-75324440
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4214#discussion_r25109674
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -230,6 +250,45 @@ private[history] class
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4214#discussion_r25109639
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -230,6 +250,45 @@ private[history] class
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4214#discussion_r25109592
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -230,6 +250,45 @@ private[history] class
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4214#issuecomment-75336108
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4214#discussion_r25106244
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -43,9 +47,33 @@ private[history] class
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4214#discussion_r25109482
--- Diff: docs/monitoring.md ---
@@ -144,6 +144,29 @@ follows:
If disabled, no access control checks are made.
/td
/tr
+
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4214#discussion_r25109543
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -53,8 +81,10 @@ private[history] class
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4214#discussion_r25110141
--- Diff: docs/monitoring.md ---
@@ -85,7 +85,7 @@ follows:
/td
/tr
tr
-tdspark.history.fs.updateInterval/td
+
Github user viper-kun commented on a diff in the pull request:
https://github.com/apache/spark/pull/4214#discussion_r23750085
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -163,9 +179,6 @@ private[history] class
Github user viper-kun commented on a diff in the pull request:
https://github.com/apache/spark/pull/4214#discussion_r23750759
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -113,12 +129,12 @@ private[history] class
Github user viper-kun commented on a diff in the pull request:
https://github.com/apache/spark/pull/4214#discussion_r23750788
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -53,8 +79,10 @@ private[history] class FsHistoryProvider(conf:
Github user viper-kun closed the pull request at:
https://github.com/apache/spark/pull/2471
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/2471#issuecomment-71702876
@viper-kun could you close this one in that case? thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/4214#issuecomment-71743602
LGTM aside from some very minor things.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/4214#discussion_r23649795
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -43,9 +47,31 @@ private[history] class FsHistoryProvider(conf:
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/4214#discussion_r23649826
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -53,8 +79,10 @@ private[history] class FsHistoryProvider(conf:
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/4214#discussion_r23652781
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -113,12 +129,12 @@ private[history] class FsHistoryProvider(conf:
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/4214#discussion_r23649845
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -53,8 +79,10 @@ private[history] class FsHistoryProvider(conf:
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/4214#discussion_r23652649
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -163,9 +179,6 @@ private[history] class FsHistoryProvider(conf:
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/4214#discussion_r23653061
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -163,9 +179,6 @@ private[history] class FsHistoryProvider(conf:
GitHub user viper-kun opened a pull request:
https://github.com/apache/spark/pull/4214
[SPARK-3562]Periodic cleanup event logs
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/viper-kun/spark cleaneventlog
Alternatively you can
Github user viper-kun commented on the pull request:
https://github.com/apache/spark/pull/2471#issuecomment-71575458
I have file a new pr #4214
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4214#issuecomment-71575569
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user suyanNone commented on the pull request:
https://github.com/apache/spark/pull/2471#issuecomment-71309691
@vanzin = =! I got it, sigh~
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/2471#issuecomment-71058558
I'm not a committer so I can't merge the patch. But it has merge conflicts
now, so that at least needs to be fixed.
---
If your project is set up for it, you can reply
Github user suyanNone commented on the pull request:
https://github.com/apache/spark/pull/2471#issuecomment-70964880
Is thi patch ok to merge?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2471#discussion_r20600235
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -46,8 +72,10 @@ private[history] class FsHistoryProvider(conf:
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/2471#issuecomment-63698395
LGTM. Everybody else is kinda busy with releases so I doubt they'll look at
this in the next several days...
---
If your project is set up for it, you can reply to this
Github user viper-kun commented on the pull request:
https://github.com/apache/spark/pull/2471#issuecomment-60541215
@vanzin @andrewor14 @srowen . is it ok to go?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2471#discussion_r19179055
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -210,7 +226,46 @@ private[history] class FsHistoryProvider(conf:
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2471#discussion_r19179121
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -29,14 +31,36 @@ import org.apache.spark.scheduler._
import
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2471#discussion_r19179186
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -29,14 +31,36 @@ import org.apache.spark.scheduler._
import
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/2471#issuecomment-59998653
@viper-kun lgtm, but you'll need to get the attention of a committer. :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user viper-kun commented on the pull request:
https://github.com/apache/spark/pull/2471#issuecomment-60027733
@vanzin @andrewor14. is it ok to go?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user viper-kun commented on the pull request:
https://github.com/apache/spark/pull/2471#issuecomment-59648648
@vanzin. is it ok to go?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user viper-kun commented on the pull request:
https://github.com/apache/spark/pull/2471#issuecomment-59164199
@vanzin , is it ok to go?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mattf commented on the pull request:
https://github.com/apache/spark/pull/2471#issuecomment-59191797
Well, good luck with adding something like that to HDFS... that is not
the responsibility of filesystems.
just so we're on the same page, i'm not advocating
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/2471#issuecomment-59231360
@mattf Always in for a beer but unfortunately I'm not in NY...
Also, you mention rotating a lot. This is not rotating. This is cleaning
up, as in deleting
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/2471#issuecomment-59231417
@viper-kun haven't had a chance to look at the diff again, but it seems
there are merge conflicts now.
---
If your project is set up for it, you can reply to this email
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2471#discussion_r18934400
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -34,9 +36,19 @@ private[history] class FsHistoryProvider(conf:
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2471#discussion_r18934416
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -34,9 +36,19 @@ private[history] class FsHistoryProvider(conf:
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2471#discussion_r18934425
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -46,8 +58,9 @@ private[history] class FsHistoryProvider(conf:
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2471#discussion_r18934463
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -60,29 +73,23 @@ private[history] class FsHistoryProvider(conf:
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2471#discussion_r18934480
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -46,8 +58,9 @@ private[history] class FsHistoryProvider(conf:
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2471#discussion_r18934502
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -60,29 +73,23 @@ private[history] class FsHistoryProvider(conf:
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2471#discussion_r18934514
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -97,9 +104,14 @@ private[history] class FsHistoryProvider(conf:
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2471#discussion_r18934497
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -60,29 +73,23 @@ private[history] class FsHistoryProvider(conf:
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2471#discussion_r18934524
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -210,7 +220,44 @@ private[history] class FsHistoryProvider(conf:
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2471#discussion_r18934542
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -210,7 +220,44 @@ private[history] class FsHistoryProvider(conf:
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/2471#issuecomment-59302984
@viper-kun mostly good, just a few minor things left as far as I'm
concerned.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2471#discussion_r18935441
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -46,8 +58,9 @@ private[history] class FsHistoryProvider(conf:
Github user viper-kun commented on the pull request:
https://github.com/apache/spark/pull/2471#issuecomment-59038886
in my opinion, spark create event log data, and spark delete it. In
hadoop, event log is deleted by JobHistoryServer, not by fileSystem.
---
If your project is set
Github user viper-kun commented on a diff in the pull request:
https://github.com/apache/spark/pull/2471#discussion_r18763243
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -214,6 +224,43 @@ private[history] class
Github user mattf commented on the pull request:
https://github.com/apache/spark/pull/2471#issuecomment-58885115
@mattf I understand what you're trying to say, but think about it in
context. As I said above, the when to poll the file system code is the most
trivial part of this
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/2471#issuecomment-58924618
i think you should implement the ability to sweep/rotate/clean log files
in hdfs
Well, good luck with adding something like that to HDFS... that is not the
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2471#discussion_r18781725
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -214,6 +224,43 @@ private[history] class FsHistoryProvider(conf:
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2471#discussion_r18782185
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -195,22 +241,68 @@ private[history] class FsHistoryProvider(conf:
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2471#discussion_r18782362
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -195,22 +241,68 @@ private[history] class FsHistoryProvider(conf:
Github user aw-altiscale commented on the pull request:
https://github.com/apache/spark/pull/2471#issuecomment-58933013
*appears in a puff of smoke*
Hi. I did a very quick skim. You might be interested in HDFS-6382.
---
If your project is set up for it, you can reply to
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/2471#issuecomment-58934284
inotify is certainly interesting for the HistoryServer, but kinda
orthogonal to this. The other bug is more related to this one, and they're
discussing exactly what I
Github user viper-kun commented on a diff in the pull request:
https://github.com/apache/spark/pull/2471#discussion_r18739911
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -195,22 +241,68 @@ private[history] class
Github user viper-kun commented on a diff in the pull request:
https://github.com/apache/spark/pull/2471#discussion_r18740124
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -195,22 +241,68 @@ private[history] class
Github user viper-kun commented on a diff in the pull request:
https://github.com/apache/spark/pull/2471#discussion_r18740169
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -195,22 +241,68 @@ private[history] class
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/2471#discussion_r18740457
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -195,22 +241,68 @@ private[history] class FsHistoryProvider(conf:
Github user viper-kun commented on a diff in the pull request:
https://github.com/apache/spark/pull/2471#discussion_r18741084
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -195,22 +241,68 @@ private[history] class
Github user viper-kun commented on the pull request:
https://github.com/apache/spark/pull/2471#issuecomment-58624839
@mattf @vanzin is this ok to go ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2471#discussion_r18737207
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -28,15 +28,27 @@ import org.apache.spark.deploy.SparkHadoopUtil
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2471#discussion_r18737213
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -28,15 +28,27 @@ import org.apache.spark.deploy.SparkHadoopUtil
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2471#discussion_r18737263
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -54,35 +66,57 @@ private[history] class FsHistoryProvider(conf:
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2471#discussion_r18737282
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -54,35 +66,57 @@ private[history] class FsHistoryProvider(conf:
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2471#discussion_r18737405
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -195,22 +241,68 @@ private[history] class FsHistoryProvider(conf:
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2471#discussion_r18737439
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -145,43 +186,48 @@ private[history] class FsHistoryProvider(conf:
1 - 100 of 149 matches
Mail list logo
