Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/6263#issuecomment-168112823
I'm going to close this pull request. If this is still relevant and you are
interested in pushing it forward, please open a new pull request. Thanks!
---
If your project
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/6263
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user lianhuiwang commented on the pull request:
https://github.com/apache/spark/pull/6263#issuecomment-160853790
@archit279thakur @CodingCat @squito I created new PR #10058. Can you take a
look at it?Thanks.
---
If your project is set up for it, you can reply to this email
Github user CodingCat commented on the pull request:
https://github.com/apache/spark/pull/6263#issuecomment-159640761
In the current version of patch, we use expiration time to prevent too many
dead executors from appearing on the UI. It brings inconvenient overhead which
makes the
Github user CodingCat commented on the pull request:
https://github.com/apache/spark/pull/6263#issuecomment-159642220
@squito Regarding the page structure, do not trust my sense of aesthetic,
:-)
Personally, I prefer to separate the page into two sections, one for alive
Github user CodingCat commented on a diff in the pull request:
https://github.com/apache/spark/pull/6263#discussion_r45875872
--- Diff:
core/src/main/scala/org/apache/spark/storage/StorageStatusListener.scala ---
@@ -28,15 +35,39 @@ import org.apache.spark.scheduler._
*
Github user CodingCat commented on the pull request:
https://github.com/apache/spark/pull/6263#issuecomment-159635180
@archit279thakur , would you mind just uploading some screenshot, so that
we have more sense on the current page structure?
---
If your project is set up for it, you
Github user squito commented on the pull request:
https://github.com/apache/spark/pull/6263#issuecomment-159409155
Hi @archit279thakur,
good questions about what to do with the time it was killed. The reason I
wanted it included is so the user could put it together with the
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6263#issuecomment-158377704
**[Test build #46417 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46417/consoleFull)**
for PR 6263 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6263#issuecomment-158385311
**[Test build #46418 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46418/consoleFull)**
for PR 6263 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6263#issuecomment-158385324
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6263#issuecomment-158385319
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6263#issuecomment-158425982
**[Test build #46422 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46422/consoleFull)**
for PR 6263 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6263#issuecomment-158425985
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6263#issuecomment-158425439
**[Test build #46422 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46422/consoleFull)**
for PR 6263 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6263#issuecomment-158425988
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6263#issuecomment-158357514
**[Test build #46414 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46414/consoleFull)**
for PR 6263 at commit
Github user archit279thakur commented on the pull request:
https://github.com/apache/spark/pull/6263#issuecomment-158366439
@squito
In reply to:
*@archit279thakur can you also bring this up to date with master, and
include before & after screenshots? I'd like for this to also
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6263#issuecomment-158357990
**[Test build #46414 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46414/consoleFull)**
for PR 6263 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6263#issuecomment-158357994
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6263#issuecomment-158357992
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6263#issuecomment-158369809
**[Test build #46416 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46416/consoleFull)**
for PR 6263 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6263#issuecomment-158369893
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6263#issuecomment-158369890
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6263#issuecomment-158378393
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6263#issuecomment-158378387
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6263#issuecomment-158378375
**[Test build #46417 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46417/consoleFull)**
for PR 6263 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6263#issuecomment-158382654
**[Test build #46418 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46418/consoleFull)**
for PR 6263 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6263#issuecomment-158366325
**[Test build #46416 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46416/consoleFull)**
for PR 6263 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6263#issuecomment-158435009
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6263#issuecomment-158435008
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6263#issuecomment-158430559
**[Test build #46423 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46423/consoleFull)**
for PR 6263 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6263#issuecomment-158434952
**[Test build #46423 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46423/consoleFull)**
for PR 6263 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6263#issuecomment-157310649
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6263#issuecomment-157310644
[Test build #46074 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46074/consoleFull)
for PR 6263 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6263#issuecomment-157310646
Build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6263#issuecomment-157310550
[Test build #46074 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46074/consoleFull)
for PR 6263 at commit
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/6263#discussion_r44960862
--- Diff: core/src/main/scala/org/apache/spark/ui/exec/ExecutorsPage.scala
---
@@ -25,6 +25,7 @@ import scala.xml.Node
import
Github user squito commented on the pull request:
https://github.com/apache/spark/pull/6263#issuecomment-157128907
@archit279thakur yeah don't worry about that test failure ... when you push
updates & bring up to date w/ master the tests will re-run in any case
---
If your project
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/6263#discussion_r44961686
--- Diff:
core/src/main/scala/org/apache/spark/storage/StorageStatusListener.scala ---
@@ -87,6 +113,8 @@ class StorageStatusListener extends SparkListener {
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/6263#discussion_r44961121
--- Diff:
core/src/main/scala/org/apache/spark/storage/StorageStatusListener.scala ---
@@ -28,15 +35,34 @@ import org.apache.spark.scheduler._
*
*
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6263#issuecomment-157298330
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6263#issuecomment-157298326
[Test build #46065 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46065/consoleFull)
for PR 6263 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6263#issuecomment-157298329
Build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user archit279thakur commented on a diff in the pull request:
https://github.com/apache/spark/pull/6263#discussion_r45029094
--- Diff:
core/src/main/scala/org/apache/spark/storage/StorageStatusListener.scala ---
@@ -87,6 +113,8 @@ class StorageStatusListener extends
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6263#issuecomment-157296312
[Test build #46065 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46065/consoleFull)
for PR 6263 at commit
Github user archit279thakur commented on a diff in the pull request:
https://github.com/apache/spark/pull/6263#discussion_r44892842
--- Diff:
core/src/main/scala/org/apache/spark/storage/StorageStatusListener.scala ---
@@ -28,15 +36,33 @@ import org.apache.spark.scheduler._
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6263#issuecomment-156940725
[Test build #45984 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45984/consoleFull)
for PR 6263 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6263#issuecomment-156941079
Build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6263#issuecomment-156941081
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6263#issuecomment-156941074
[Test build #45984 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45984/consoleFull)
for PR 6263 at commit
Github user archit279thakur commented on the pull request:
https://github.com/apache/spark/pull/6263#issuecomment-156940368
jenkins, please test again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user archit279thakur commented on the pull request:
https://github.com/apache/spark/pull/6263#issuecomment-156944200
It says: Error: Invalid or corrupt jarfile build/sbt-launch-0.13.7.jar
Should I bring it up to date with master first?
---
If your project is set up for it,
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/6263#discussion_r44029924
--- Diff:
core/src/test/scala/org/apache/spark/storage/StorageStatusListenerSuite.scala
---
@@ -150,4 +158,12 @@ class StorageStatusListenerSuite extends
Github user archit279thakur commented on a diff in the pull request:
https://github.com/apache/spark/pull/6263#discussion_r44056583
--- Diff:
core/src/main/scala/org/apache/spark/storage/StorageStatusListener.scala ---
@@ -17,26 +17,55 @@
package
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6263#issuecomment-154179943
[Test build #45141 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45141/consoleFull)
for PR 6263 at commit
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/6263#discussion_r44055771
--- Diff:
core/src/test/scala/org/apache/spark/storage/StorageStatusListenerSuite.scala
---
@@ -17,10 +17,16 @@
package org.apache.spark.storage
Github user archit279thakur commented on the pull request:
https://github.com/apache/spark/pull/6263#issuecomment-154167926
@squito Thanks for your comments. Incorporated them all and also gone
through the link.
Please point out if I missed anything.
---
If your project is set
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6263#issuecomment-154179575
Build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/6263#discussion_r44064388
--- Diff:
core/src/main/scala/org/apache/spark/storage/StorageStatusListener.scala ---
@@ -17,26 +17,55 @@
package org.apache.spark.storage
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6263#issuecomment-154180192
[Test build #45141 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45141/consoleFull)
for PR 6263 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6263#issuecomment-154180197
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6263#issuecomment-154180196
Build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/6263#discussion_r44055535
--- Diff:
core/src/main/scala/org/apache/spark/storage/StorageStatusListener.scala ---
@@ -17,26 +17,55 @@
package org.apache.spark.storage
Github user archit279thakur commented on a diff in the pull request:
https://github.com/apache/spark/pull/6263#discussion_r44056239
--- Diff:
core/src/main/scala/org/apache/spark/storage/StorageStatusListener.scala ---
@@ -17,26 +17,55 @@
package
Github user archit279thakur commented on a diff in the pull request:
https://github.com/apache/spark/pull/6263#discussion_r44062329
--- Diff:
core/src/main/scala/org/apache/spark/storage/StorageStatusListener.scala ---
@@ -17,26 +17,55 @@
package
Github user squito commented on the pull request:
https://github.com/apache/spark/pull/6263#issuecomment-154179771
@archit279thakur can you also bring this up to date with master, and
include before & after screenshots?
I'd like for this to also update the json endpoints.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6263#issuecomment-154179598
Build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/6263#discussion_r44055655
--- Diff:
core/src/main/scala/org/apache/spark/storage/StorageStatusListener.scala ---
@@ -17,26 +17,55 @@
package org.apache.spark.storage
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/6263#discussion_r44063735
--- Diff:
core/src/test/scala/org/apache/spark/storage/StorageStatusListenerSuite.scala
---
@@ -150,4 +157,21 @@ class StorageStatusListenerSuite extends
Github user squito commented on the pull request:
https://github.com/apache/spark/pull/6263#issuecomment-154179267
Jenkins, ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/6263#discussion_r44055259
--- Diff:
core/src/main/scala/org/apache/spark/storage/StorageStatusListener.scala ---
@@ -17,26 +17,55 @@
package org.apache.spark.storage
Github user archit279thakur commented on a diff in the pull request:
https://github.com/apache/spark/pull/6263#discussion_r44059314
--- Diff:
core/src/main/scala/org/apache/spark/storage/StorageStatusListener.scala ---
@@ -17,26 +17,55 @@
package
Github user archit279thakur commented on a diff in the pull request:
https://github.com/apache/spark/pull/6263#discussion_r44059300
--- Diff:
core/src/test/scala/org/apache/spark/storage/StorageStatusListenerSuite.scala
---
@@ -17,10 +17,16 @@
package
Github user archit279thakur commented on a diff in the pull request:
https://github.com/apache/spark/pull/6263#discussion_r44059357
--- Diff:
core/src/main/scala/org/apache/spark/storage/StorageStatusListener.scala ---
@@ -17,26 +17,55 @@
package
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/6263#discussion_r44063828
--- Diff:
core/src/test/scala/org/apache/spark/ui/storage/StorageTabSuite.scala ---
@@ -22,6 +22,7 @@ import org.apache.spark.Success
import
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/6263#discussion_r44055138
--- Diff:
core/src/main/scala/org/apache/spark/storage/StorageStatusListener.scala ---
@@ -17,26 +17,55 @@
package org.apache.spark.storage
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/6263#discussion_r44055116
--- Diff:
core/src/main/scala/org/apache/spark/storage/StorageStatusListener.scala ---
@@ -17,26 +17,55 @@
package org.apache.spark.storage
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/6263#discussion_r44064522
--- Diff:
core/src/test/scala/org/apache/spark/storage/StorageStatusListenerSuite.scala
---
@@ -150,4 +157,21 @@ class StorageStatusListenerSuite extends
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/6263#discussion_r44064729
--- Diff:
core/src/main/scala/org/apache/spark/storage/StorageStatusListener.scala ---
@@ -28,15 +36,33 @@ import org.apache.spark.scheduler._
*
*
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/6263#discussion_r44064794
--- Diff:
core/src/main/scala/org/apache/spark/storage/StorageStatusListener.scala ---
@@ -28,15 +36,33 @@ import org.apache.spark.scheduler._
*
*
Github user archit279thakur commented on a diff in the pull request:
https://github.com/apache/spark/pull/6263#discussion_r43982245
--- Diff:
core/src/test/scala/org/apache/spark/storage/StorageStatusListenerSuite.scala
---
@@ -150,4 +158,12 @@ class StorageStatusListenerSuite
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/6263#discussion_r43909655
--- Diff:
core/src/test/scala/org/apache/spark/storage/StorageStatusListenerSuite.scala
---
@@ -21,6 +21,13 @@ import org.scalatest.FunSuite
import
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/6263#discussion_r43909507
--- Diff:
core/src/test/scala/org/apache/spark/storage/StorageStatusListenerSuite.scala
---
@@ -150,4 +158,12 @@ class StorageStatusListenerSuite extends
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/6263#discussion_r43909732
--- Diff:
core/src/main/scala/org/apache/spark/storage/StorageStatusListener.scala ---
@@ -18,9 +18,14 @@
package org.apache.spark.storage
Github user archit279thakur commented on the pull request:
https://github.com/apache/spark/pull/6263#issuecomment-153674563
@suyanNone Can you please review my 2nd commit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user suyanNone commented on the pull request:
https://github.com/apache/spark/pull/6263#issuecomment-153225204
yean, make it configurable looks good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user archit279thakur commented on the pull request:
https://github.com/apache/spark/pull/6263#issuecomment-151574473
Sure, and time for expiration should be configuration based?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user suyanNone commented on the pull request:
https://github.com/apache/spark/pull/6263#issuecomment-151010358
Hi, @archit279thakur would you mind add the logic about adding a time
expire to show lost-Executor log?
---
If your project is set up for it, you can reply to this
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/6263#issuecomment-148821303
It looks like this PR and #6644 duplicate / overlap with each other.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6263#issuecomment-121072677
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user archit279thakur opened a pull request:
https://github.com/apache/spark/pull/6263
SPARK-7729:Executor which has been killed should also be displayed onâ¦
⦠Executors Tab.
You can merge this pull request into a Git repository by running:
$ git pull
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6263#issuecomment-103462304
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
93 matches
Mail list logo
