Github user tigerquoll commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18067818
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -17,155 +17,195 @@
package org.apache.spark.deploy
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18067850
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -406,22 +412,173 @@ private[spark] class SparkSubmitArguments(args:
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18067881
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -406,22 +412,173 @@ private[spark] class SparkSubmitArguments(args:
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18067961
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -406,22 +412,173 @@ private[spark] class SparkSubmitArguments(args:
Github user tigerquoll commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18068019
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -17,155 +17,195 @@
package org.apache.spark.deploy
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18068020
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -406,22 +412,173 @@ private[spark] class SparkSubmitArguments(args:
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18068115
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -406,22 +412,173 @@ private[spark] class SparkSubmitArguments(args:
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18068141
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -406,22 +412,173 @@ private[spark] class SparkSubmitArguments(args:
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18068214
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -1479,6 +1479,14 @@ private[spark] object Utils extends Logging {
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18068228
--- Diff:
core/src/test/scala/org/apache/spark/deploy/MergablePropertiesTest.scala ---
@@ -0,0 +1,55 @@
+package org.apache.spark.deploy
+
+/**
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18068223
--- Diff:
core/src/test/scala/org/apache/spark/deploy/MergablePropertiesTest.scala ---
@@ -0,0 +1,55 @@
+package org.apache.spark.deploy
--- End diff
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/2516#issuecomment-56904113
Hi @tigerquoll, this is slowly improving. I kinda skipped the test code,
although I did notice some issues with it.
Overall, I still caught a few bugs just from
Github user tigerquoll commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18068346
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -17,155 +17,195 @@
package org.apache.spark.deploy
Github user tigerquoll commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18068465
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -17,155 +17,195 @@
package org.apache.spark.deploy
Github user tigerquoll commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18068498
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -17,155 +17,195 @@
package org.apache.spark.deploy
Github user tigerquoll commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18068639
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -188,41 +228,16 @@ private[spark] class SparkSubmitArguments(args:
Github user tigerquoll commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18068723
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -406,22 +412,173 @@ private[spark] class
Github user tigerquoll commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18068816
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -406,22 +412,173 @@ private[spark] class
Github user tigerquoll commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18068897
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -406,22 +412,173 @@ private[spark] class
Github user tigerquoll commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18068968
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -406,22 +412,173 @@ private[spark] class
Github user tigerquoll commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18069354
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -406,22 +412,173 @@ private[spark] class
Github user tigerquoll commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18070264
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -406,22 +412,173 @@ private[spark] class
Github user tigerquoll commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18070363
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -406,22 +412,173 @@ private[spark] class
GitHub user tigerquoll opened a pull request:
https://github.com/apache/spark/pull/2516
Spark Core - [SPARK-3620] - Refactor of SparkSubmit Argument parsing code
Argument processing seems to have gotten a lot of attention lately, so I
thought I might throw my contribution into the
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2516#issuecomment-56634577
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r17998434
--- Diff:
core/src/main/resources/org/apache/spark/deploy/spark-submit-defaults.prop ---
@@ -0,0 +1,90 @@
+# The master URL for the cluster
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r17998489
--- Diff:
core/src/main/resources/org/apache/spark/deploy/spark-submit-defaults.prop ---
@@ -0,0 +1,90 @@
+# The master URL for the cluster
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r17998530
--- Diff:
core/src/main/resources/org/apache/spark/deploy/spark-submit-defaults.prop ---
@@ -0,0 +1,90 @@
+# The master URL for the cluster
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r17998542
--- Diff:
core/src/main/resources/org/apache/spark/deploy/spark-submit-defaults.prop ---
@@ -0,0 +1,90 @@
+# The master URL for the cluster
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r17998857
--- Diff: core/src/main/scala/org/apache/spark/SparkConf.scala ---
@@ -48,8 +50,10 @@ class SparkConf(loadDefaults: Boolean) extends Cloneable
with Logging {
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r17998933
--- Diff:
core/src/main/scala/org/apache/spark/deploy/MergedPropertyMap.scala ---
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r17999062
--- Diff:
core/src/main/scala/org/apache/spark/deploy/MergedPropertyMap.scala ---
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r17998809
--- Diff: core/src/main/scala/org/apache/spark/SparkConf.scala ---
@@ -48,8 +50,10 @@ class SparkConf(loadDefaults: Boolean) extends Cloneable
with Logging {
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r17999538
--- Diff:
core/src/main/scala/org/apache/spark/deploy/MergedPropertyMap.scala ---
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r1821
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -83,7 +88,7 @@ object SparkSubmit {
* (4) the main class for
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r1862
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -130,7 +135,7 @@ object SparkSubmit {
if
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18000140
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -139,8 +144,9 @@ object SparkSubmit {
case (MESOS, CLUSTER) =
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18000292
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -171,19 +179,20 @@ object SparkSubmit {
// All cluster managers
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18000365
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -288,11 +291,11 @@ object SparkSubmit {
}
private def
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18000466
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -394,8 +404,8 @@ object SparkSubmit {
* the user's driver program or to
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18000381
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -340,7 +343,7 @@ object SparkSubmit {
private def
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18000532
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -17,164 +17,205 @@
package org.apache.spark.deploy
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18000562
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -17,164 +17,205 @@
package org.apache.spark.deploy
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18000592
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -17,164 +17,205 @@
package org.apache.spark.deploy
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18000674
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -17,164 +17,205 @@
package org.apache.spark.deploy
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18000740
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -17,164 +17,205 @@
package org.apache.spark.deploy
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18000772
--- Diff: core/src/main/scala/org/apache/spark/deploy/configConstants.scala
---
@@ -0,0 +1,169 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18000765
--- Diff: core/src/main/scala/org/apache/spark/deploy/configConstants.scala
---
@@ -0,0 +1,169 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18000858
--- Diff: core/src/main/scala/org/apache/spark/deploy/configConstants.scala
---
@@ -0,0 +1,169 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18001005
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -17,164 +17,205 @@
package org.apache.spark.deploy
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18001020
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -17,164 +17,205 @@
package org.apache.spark.deploy
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18001099
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -17,164 +17,205 @@
package org.apache.spark.deploy
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18001302
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -17,164 +17,205 @@
package org.apache.spark.deploy
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18001707
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -17,164 +17,205 @@
package org.apache.spark.deploy
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18002121
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -17,164 +17,205 @@
package org.apache.spark.deploy
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18002144
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -17,164 +17,205 @@
package org.apache.spark.deploy
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18002334
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -406,22 +413,166 @@ private[spark] class SparkSubmitArguments(args:
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18002495
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -406,22 +413,166 @@ private[spark] class SparkSubmitArguments(args:
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18002585
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -406,22 +413,166 @@ private[spark] class SparkSubmitArguments(args:
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18002724
--- Diff: core/src/main/scala/org/apache/spark/deploy/configConstants.scala
---
@@ -0,0 +1,169 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18002822
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -406,22 +413,166 @@ private[spark] class SparkSubmitArguments(args:
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18002864
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -406,22 +413,166 @@ private[spark] class SparkSubmitArguments(args:
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18002945
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -406,22 +413,166 @@ private[spark] class SparkSubmitArguments(args:
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18003024
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -406,22 +413,166 @@ private[spark] class SparkSubmitArguments(args:
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18003122
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -406,22 +413,166 @@ private[spark] class SparkSubmitArguments(args:
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18003150
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -406,22 +413,166 @@ private[spark] class SparkSubmitArguments(args:
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18003201
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitDriverBootstrapper.scala
---
@@ -50,71 +51,63 @@ private[spark] object
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18003325
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -406,22 +413,166 @@ private[spark] class SparkSubmitArguments(args:
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18003337
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -406,22 +413,166 @@ private[spark] class SparkSubmitArguments(args:
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18003366
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -406,22 +413,166 @@ private[spark] class SparkSubmitArguments(args:
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/2516#issuecomment-56745901
Hi @tigerquoll ,
Overall I like the idea of making this code saner. But your patch currently
has a ton of style issues, several bugs (e.g. leaking open files in
Github user tigerquoll commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18008077
--- Diff:
core/src/main/resources/org/apache/spark/deploy/spark-submit-defaults.prop ---
@@ -0,0 +1,90 @@
+# The master URL for the cluster
Github user tigerquoll commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18008488
--- Diff:
core/src/main/resources/org/apache/spark/deploy/spark-submit-defaults.prop ---
@@ -0,0 +1,90 @@
+# The master URL for the cluster
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18008643
--- Diff:
core/src/main/resources/org/apache/spark/deploy/spark-submit-defaults.prop ---
@@ -0,0 +1,90 @@
+# The master URL for the cluster
Github user tigerquoll commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18008765
--- Diff: core/src/main/scala/org/apache/spark/SparkConf.scala ---
@@ -48,8 +50,10 @@ class SparkConf(loadDefaults: Boolean) extends Cloneable
with
Github user tigerquoll commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18009041
--- Diff:
core/src/main/scala/org/apache/spark/deploy/MergedPropertyMap.scala ---
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Software
Github user tigerquoll commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18009050
--- Diff:
core/src/main/scala/org/apache/spark/deploy/MergedPropertyMap.scala ---
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Software
Github user tigerquoll commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18009125
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -83,7 +88,7 @@ object SparkSubmit {
* (4) the main class
Github user tigerquoll commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18009140
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -130,7 +135,7 @@ object SparkSubmit {
if
Github user tigerquoll commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18009318
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -288,11 +291,11 @@ object SparkSubmit {
}
private def
Github user tigerquoll commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18009416
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -340,7 +343,7 @@ object SparkSubmit {
private def
Github user tigerquoll commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18009575
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -394,8 +404,8 @@ object SparkSubmit {
* the user's driver program or
Github user tigerquoll commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18009632
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -17,164 +17,205 @@
package org.apache.spark.deploy
Github user tigerquoll commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18009684
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -17,164 +17,205 @@
package org.apache.spark.deploy
Github user tigerquoll commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18009823
--- Diff: core/src/main/scala/org/apache/spark/deploy/configConstants.scala
---
@@ -0,0 +1,169 @@
+/*
+ * Licensed to the Apache Software
Github user tigerquoll commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18009818
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -17,164 +17,205 @@
package org.apache.spark.deploy
Github user tigerquoll commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18009839
--- Diff: core/src/main/scala/org/apache/spark/deploy/configConstants.scala
---
@@ -0,0 +1,169 @@
+/*
+ * Licensed to the Apache Software
Github user tigerquoll commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18010009
--- Diff: core/src/main/scala/org/apache/spark/deploy/configConstants.scala
---
@@ -0,0 +1,169 @@
+/*
+ * Licensed to the Apache Software
Github user tigerquoll commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18010136
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -17,164 +17,205 @@
package org.apache.spark.deploy
Github user tigerquoll commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18010338
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -17,164 +17,205 @@
package org.apache.spark.deploy
Github user tigerquoll commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18010388
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -17,164 +17,205 @@
package org.apache.spark.deploy
Github user tigerquoll commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18010686
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -17,164 +17,205 @@
package org.apache.spark.deploy
Github user tigerquoll commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18010816
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -17,164 +17,205 @@
package org.apache.spark.deploy
Github user tigerquoll commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18010903
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -17,164 +17,205 @@
package org.apache.spark.deploy
Github user tigerquoll commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18011020
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -17,164 +17,205 @@
package org.apache.spark.deploy
Github user tigerquoll commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18011097
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -17,164 +17,205 @@
package org.apache.spark.deploy
Github user tigerquoll commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18011564
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -406,22 +413,166 @@ private[spark] class
Github user tigerquoll commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18011608
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -406,22 +413,166 @@ private[spark] class
Github user tigerquoll commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18014406
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -406,22 +413,166 @@ private[spark] class
Github user tigerquoll commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18014511
--- Diff: core/src/main/scala/org/apache/spark/deploy/configConstants.scala
---
@@ -0,0 +1,169 @@
+/*
+ * Licensed to the Apache Software
101 - 200 of 208 matches
Mail list logo
