Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/3066#discussion_r19722086
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/package.scala ---
@@ -451,4 +451,33 @@ package object sql {
* Builder for [[Metadata]]. If
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/3066#discussion_r19722088
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/package.scala ---
@@ -451,4 +451,33 @@ package object sql {
* Builder for [[Metadata]]. If
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/3066#issuecomment-61468129
test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3066#issuecomment-61468491
[Test build #22811 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22811/consoleFull)
for PR 3066 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3066#issuecomment-61468734
[Test build #22811 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22811/consoleFull)
for PR 3066 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3066#issuecomment-61468737
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user culler commented on a diff in the pull request:
https://github.com/apache/spark/pull/3066#discussion_r19730958
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/dsl/package.scala ---
@@ -146,6 +146,31 @@ package object dsl {
def upper(e:
Github user culler commented on a diff in the pull request:
https://github.com/apache/spark/pull/3066#discussion_r19731906
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Projection.scala
---
@@ -139,6 +140,12 @@ class JoinedRow extends Row {
Github user culler commented on a diff in the pull request:
https://github.com/apache/spark/pull/3066#discussion_r19733162
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Row.scala
---
@@ -42,6 +44,31 @@ object Row {
* This method can be
Github user culler commented on a diff in the pull request:
https://github.com/apache/spark/pull/3066#discussion_r19733534
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/types/dataTypes.scala
---
@@ -187,7 +187,8 @@ case object NullType extends DataType
Github user culler commented on a diff in the pull request:
https://github.com/apache/spark/pull/3066#discussion_r19733740
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/types/timetypes.scala
---
@@ -0,0 +1,97 @@
+/*
+ * Licensed to the Apache
Github user culler commented on a diff in the pull request:
https://github.com/apache/spark/pull/3066#discussion_r19735638
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/package.scala ---
@@ -451,4 +451,33 @@ package object sql {
* Builder for [[Metadata]]. If there
Github user culler commented on a diff in the pull request:
https://github.com/apache/spark/pull/3066#discussion_r19736442
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/package.scala ---
@@ -451,4 +451,33 @@ package object sql {
* Builder for [[Metadata]]. If there
Github user culler commented on the pull request:
https://github.com/apache/spark/pull/3066#issuecomment-61488635
I have corrected the issues pointed out in the comments. Please retest.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user culler commented on a diff in the pull request:
https://github.com/apache/spark/pull/3066#discussion_r19737251
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/columnar/ColumnType.scala ---
@@ -372,6 +372,11 @@ private[sql] object TIMESTAMP extends
Github user culler commented on the pull request:
https://github.com/apache/spark/pull/3066#issuecomment-61498140
Hmmm. The GitHub docs seem to suggest that I am supposed to mention
@liancheng and @rxin in my comments. So I am doing that. My apologies if this
is superfluous or
GitHub user culler opened a pull request:
https://github.com/apache/spark/pull/3066
Timestamp and Date classes which work in the catalyst DSL.
These Timestamp and Date classes support the usual comparison operators, so
the can be used in catalyst Expressions. The come with
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3066#issuecomment-61437893
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/3066#issuecomment-61442159
@liancheng - can you take a look at this first? Thanks.
@culler - can you create a JIRA ticket at
https://issues.apache.org/jira/browse/SPARK and then update the
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/3066#discussion_r19719774
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/dsl/package.scala ---
@@ -146,6 +146,31 @@ package object dsl {
def upper(e:
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/3066#discussion_r19719985
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Projection.scala
---
@@ -139,6 +140,12 @@ class JoinedRow extends Row {
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/3066#discussion_r19720008
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Projection.scala
---
@@ -139,6 +140,12 @@ class JoinedRow extends Row {
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/3066#discussion_r19720121
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/types/dataTypes.scala
---
@@ -187,7 +187,8 @@ case object NullType extends DataType
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/3066#discussion_r19720295
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
---
@@ -124,9 +124,9 @@ object ScalaReflection {
case
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/3066#discussion_r19721009
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/dsl/package.scala ---
@@ -146,6 +146,31 @@ package object dsl {
def upper(e:
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/3066#issuecomment-61447235
Hey @culler, in general I like the DSL improvements, thanks for the work!
Left some in-line comments, and two additional hight level comments here:
1. Usually
26 matches
Mail list logo
