[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-09-06 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r77610557 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/StatisticsSuite.scala --- @@ -168,6 +171,154 @@ class StatisticsSuite extends QueryTest with

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-09-05 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r77572880 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/StatisticsSuite.scala --- @@ -168,6 +171,154 @@ class StatisticsSuite extends QueryTest with T

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-09-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/14712 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-09-02 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r77373066 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/StatisticsSuite.scala --- @@ -168,6 +170,137 @@ class StatisticsSuite extends QueryTest with

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-09-02 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r77318694 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala --- @@ -610,6 +637,14 @@ object HiveExternalCatalog { val DATASOUR

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-09-02 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r77313250 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/AnalyzeTableCommand.scala --- @@ -88,24 +85,54 @@ case class AnalyzeTableCommand(

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-09-02 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r77313069 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala --- @@ -383,21 +384,34 @@ private[spark] class HiveExternalCatalog(conf:

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-09-02 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r77310310 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/AnalyzeTableCommand.scala --- @@ -88,24 +85,54 @@ case class AnalyzeTableCommand(tabl

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-09-02 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r77309971 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala --- @@ -383,21 +384,34 @@ private[spark] class HiveExternalCatalog(co

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-09-02 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r77308279 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala --- @@ -383,21 +384,34 @@ private[spark] class HiveExternalCatalog(conf:

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-09-02 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r77307355 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala --- @@ -130,6 +130,7 @@ case class CatalogTable( crea

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-09-02 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r77307095 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/AnalyzeTableCommand.scala --- @@ -88,24 +85,54 @@ case class AnalyzeTableCommand(tabl

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-09-02 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r77306895 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala --- @@ -130,6 +130,7 @@ case class CatalogTable( createTi

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-09-02 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r77304066 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/AnalyzeTableCommand.scala --- @@ -88,24 +85,54 @@ case class AnalyzeTableCommand(

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-09-02 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r77303607 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala --- @@ -610,6 +637,14 @@ object HiveExternalCatalog { val DATA

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-09-02 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r77303388 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala --- @@ -383,21 +384,34 @@ private[spark] class HiveExternalCatalog(co

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-09-02 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r77302422 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala --- @@ -236,7 +236,8 @@ object DataSourceStrategy ex

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-09-02 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r77301653 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/AnalyzeTableCommand.scala --- @@ -88,24 +85,54 @@ case class AnalyzeTableCommand(

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-09-01 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r77301097 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/AnalyzeTableCommand.scala --- @@ -88,24 +85,54 @@ case class AnalyzeTableCommand(

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-09-01 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r77300889 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala --- @@ -130,6 +130,7 @@ case class CatalogTable( crea

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-09-01 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r77139470 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/AnalyzeTableCommand.scala --- @@ -88,24 +85,53 @@ case class AnalyzeTableCommand(tabl

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-09-01 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r77137539 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/LogicalRelation.scala --- @@ -52,7 +52,8 @@ case class LogicalRelation(

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-09-01 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r77124744 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/catalyst/SQLBuilder.scala --- @@ -590,8 +590,12 @@ class SQLBuilder private ( object E

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-08-31 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r77119270 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/LogicalRelation.scala --- @@ -72,9 +73,11 @@ case class LogicalRelation( /

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-08-31 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r77113222 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/AnalyzeTableCommand.scala --- @@ -88,24 +85,53 @@ case class AnalyzeTableCommand(

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-08-31 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r77113174 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/LogicalRelation.scala --- @@ -52,7 +52,8 @@ case class LogicalRelation(

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-08-31 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r77113054 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/AnalyzeTableCommand.scala --- @@ -88,24 +85,53 @@ case class AnalyzeTableCommand(

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-08-31 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r77108572 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/LogicalRelation.scala --- @@ -72,9 +73,11 @@ case class LogicalRelation(

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-08-31 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r77104213 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/LogicalRelation.scala --- @@ -33,7 +33,8 @@ import org.apache.spark.util.Utils

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-08-31 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r77016228 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/StatisticsSuite.scala --- @@ -168,6 +169,107 @@ class StatisticsSuite extends QueryTest with

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-08-31 Thread scwf
Github user scwf commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r77014850 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/StatisticsSuite.scala --- @@ -168,6 +169,107 @@ class StatisticsSuite extends QueryTest with TestHi

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-08-31 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r77009503 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/LogicalRelation.scala --- @@ -33,7 +33,8 @@ import org.apache.spark.util.Uti

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-08-31 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r77002553 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala --- @@ -383,21 +383,36 @@ private[spark] class HiveExternalCatalog(conf:

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-08-31 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r76967533 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala --- @@ -383,21 +383,36 @@ private[spark] class HiveExternalCatalog(co

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-08-31 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r76967205 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/LogicalRelation.scala --- @@ -33,7 +33,8 @@ import org.apache.spark.util.Util

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-08-31 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r76966709 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala --- @@ -130,6 +130,7 @@ case class CatalogTable( crea

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-08-31 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r76966560 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/LogicalRelation.scala --- @@ -33,7 +33,8 @@ import org.apache.spark.util.Uti

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-08-31 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r76949035 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/StatisticsSuite.scala --- @@ -168,6 +169,81 @@ class StatisticsSuite extends QueryTest with TestHi

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-08-31 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r76948258 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/MetastoreRelation.scala --- @@ -140,7 +145,12 @@ private[hive] case class MetastoreRelation(

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-08-30 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r76932253 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/MetastoreRelation.scala --- @@ -140,7 +145,12 @@ private[hive] case class MetastoreRelation(

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-08-30 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r76931629 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -235,14 +235,18 @@ class SessionCatalog( * Not

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-08-30 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r76931067 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/MetastoreRelation.scala --- @@ -140,7 +145,12 @@ private[hive] case class MetastoreRelation(

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-08-30 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r76930682 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/MetastoreRelation.scala --- @@ -140,7 +145,12 @@ private[hive] case class MetastoreRelation(

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-08-30 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r76929362 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala --- @@ -401,6 +401,13 @@ private[spark] class HiveExternalCatalog(conf:

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-08-30 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r76926260 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/StatisticsSuite.scala --- @@ -168,6 +169,81 @@ class StatisticsSuite extends QueryTest with T

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-08-30 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r76926133 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala --- @@ -401,6 +401,13 @@ private[spark] class HiveExternalCatalog(co

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-08-30 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r76924362 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala --- @@ -401,6 +401,13 @@ private[spark] class HiveExternalCatalog(con

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-08-30 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r76923549 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/AnalyzeTableCommand.scala --- @@ -21,25 +21,55 @@ import scala.util.control.NonF

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-08-30 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r76923392 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/AnalyzeTableCommand.scala --- @@ -21,25 +21,55 @@ import scala.util.control.NonF

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-08-30 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r76922102 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/StatisticsSuite.scala --- @@ -168,6 +169,81 @@ class StatisticsSuite extends QueryTest with TestHi

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-08-30 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r76921850 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/AnalyzeTableCommand.scala --- @@ -88,15 +116,21 @@ case class AnalyzeTableComman

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-08-30 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r76921588 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/StatisticsSuite.scala --- @@ -168,6 +169,81 @@ class StatisticsSuite extends QueryTest with TestHi

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-08-30 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r76921301 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/LogicalRelation.scala --- @@ -33,7 +33,8 @@ import org.apache.spark.util.Utils

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-08-30 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r76921020 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/StatisticsSuite.scala --- @@ -168,6 +169,81 @@ class StatisticsSuite extends QueryTest with T

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-08-30 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r76920921 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/StatisticsSuite.scala --- @@ -168,6 +169,81 @@ class StatisticsSuite extends QueryTest with T

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-08-30 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r76920817 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/StatisticsSuite.scala --- @@ -168,6 +169,81 @@ class StatisticsSuite extends QueryTest with T

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-08-30 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r76920785 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/LogicalRelation.scala --- @@ -33,7 +33,8 @@ import org.apache.spark.util.Utils

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-08-30 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r76920593 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/StatisticsSuite.scala --- @@ -168,6 +169,81 @@ class StatisticsSuite extends QueryTest with T

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-08-30 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r76920340 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/StatisticsSuite.scala --- @@ -168,6 +169,81 @@ class StatisticsSuite extends QueryTest with T

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-08-30 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r76920328 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/LogicalRelation.scala --- @@ -33,7 +33,8 @@ import org.apache.spark.util.Utils

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-08-30 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r76920300 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/StatisticsSuite.scala --- @@ -168,6 +169,81 @@ class StatisticsSuite extends QueryTest with T

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-08-30 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r76920234 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/StatisticsSuite.scala --- @@ -168,6 +169,81 @@ class StatisticsSuite extends QueryTest with T

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-08-30 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r76919947 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -235,14 +235,18 @@ class SessionCatalog( * Not

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-08-30 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r76919518 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala --- @@ -401,6 +401,13 @@ private[spark] class HiveExternalCatalog(conf:

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-08-30 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r76918381 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/LogicalRelation.scala --- @@ -33,7 +33,8 @@ import org.apache.spark.util.Utils

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-08-30 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r76918174 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -235,14 +235,18 @@ class SessionCatalog( * No

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-08-30 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r76917963 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala --- @@ -401,6 +401,13 @@ private[spark] class HiveExternalCatalog(conf:

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-08-28 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r76545213 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala --- @@ -207,9 +207,11 @@ class FindDataSourceTable(spark

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-08-28 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r76533896 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala --- @@ -401,6 +401,13 @@ private[spark] class HiveExternalCatalog(co

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-08-28 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r76533832 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala --- @@ -207,9 +207,11 @@ class FindDataSourceTable(

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-08-28 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r76533586 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/AnalyzeTableCommand.scala --- @@ -88,14 +87,66 @@ case class AnalyzeTableCommand

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-08-28 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r76533558 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/AnalyzeTableCommand.scala --- @@ -88,14 +87,66 @@ case class AnalyzeTableCommand

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-08-28 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r76533400 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/AnalyzeTableCommand.scala --- @@ -88,14 +89,70 @@ case class AnalyzeTableCommand

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-08-26 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r76388064 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala --- @@ -427,6 +430,44 @@ private[hive] class HiveClientImpl(

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-08-26 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r76386878 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala --- @@ -401,6 +401,13 @@ private[spark] class HiveExternalCatalog(conf:

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-08-26 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r76386013 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala --- @@ -427,6 +430,44 @@ private[hive] class HiveClientImpl(

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-08-26 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r76385250 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala --- @@ -401,6 +401,13 @@ private[spark] class HiveExternalCatalog(con

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-08-26 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r76381470 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala --- @@ -401,6 +401,13 @@ private[spark] class HiveExternalCatalog(conf:

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-08-26 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r76380753 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala --- @@ -401,6 +401,13 @@ private[spark] class HiveExternalCatalog(conf:

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-08-26 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r76380631 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala --- @@ -427,6 +430,44 @@ private[hive] class HiveClientImpl(

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-08-26 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r76374096 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala --- @@ -427,6 +430,44 @@ private[hive] class HiveClientImpl(

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-08-26 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r76374046 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala --- @@ -401,6 +401,13 @@ private[spark] class HiveExternalCatalog(con

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-08-25 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r76356157 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/AnalyzeTableCommand.scala --- @@ -88,14 +89,70 @@ case class AnalyzeTableCommand(tabl

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-08-25 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r76354939 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/AnalyzeTableCommand.scala --- @@ -88,14 +89,70 @@ case class AnalyzeTableCommand(tabl

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-08-25 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r76354802 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/AnalyzeTableCommand.scala --- @@ -88,14 +89,70 @@ case class AnalyzeTableCommand(tabl

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-08-25 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r76354055 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/AnalyzeTableCommand.scala --- @@ -88,14 +89,70 @@ case class AnalyzeTableCommand(tabl

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-08-25 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r76251185 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/AnalyzeTableCommand.scala --- @@ -88,14 +89,70 @@ case class AnalyzeTableCommand

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-08-25 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r76248746 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/AnalyzeTableCommand.scala --- @@ -88,14 +89,70 @@ case class AnalyzeTableCommand

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-08-25 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r76248301 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/AnalyzeTableCommand.scala --- @@ -88,14 +89,70 @@ case class AnalyzeTableCommand

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-08-21 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r75603123 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/LogicalRelation.scala --- @@ -72,9 +72,12 @@ case class LogicalRelation(

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-08-21 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r75602017 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/LogicalRelation.scala --- @@ -72,9 +72,12 @@ case class LogicalRelation(

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-08-21 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r75601984 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/MetastoreRelation.scala --- @@ -141,7 +142,16 @@ private[hive] case class MetastoreRelation(

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-08-20 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r75588230 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/AnalyzeTableCommand.scala --- @@ -33,7 +34,7 @@ import org.apache.spark.sql.catalys

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-08-20 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r75574009 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/LogicalRelation.scala --- @@ -72,9 +72,12 @@ case class LogicalRelation(

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-08-19 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r75573715 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/MetastoreRelation.scala --- @@ -141,7 +142,16 @@ private[hive] case class MetastoreRelation(

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-08-19 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r75573560 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/LogicalRelation.scala --- @@ -72,9 +72,12 @@ case class LogicalRelation(

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-08-19 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r75573529 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/LogicalRelation.scala --- @@ -72,9 +72,12 @@ case class LogicalRelation(

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-08-19 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r75573442 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/LogicalRelation.scala --- @@ -72,9 +72,12 @@ case class LogicalRelation( /

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-08-19 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r75572799 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/AnalyzeTableCommand.scala --- @@ -88,14 +90,30 @@ case class AnalyzeTableCommand(tabl

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-08-19 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r75572040 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/StatisticsSuite.scala --- @@ -168,6 +170,57 @@ class StatisticsSuite extends QueryTest with TestH

  1   2   >