[GitHub] spark pull request #14897: [SPARK-17338][SQL] add global temp view

2016-10-10 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/14897#discussion_r82659075 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/internal/CatalogImpl.scala --- @@ -292,6 +291,21 @@ class CatalogImpl(sparkSession: SparkSession) extends

[GitHub] spark pull request #14897: [SPARK-17338][SQL] add global temp view

2016-10-10 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/14897#discussion_r82658771 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -2433,31 +2433,65 @@ class Dataset[T] private[sql]( } /** -

[GitHub] spark pull request #14897: [SPARK-17338][SQL] add global temp view

2016-10-10 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/14897#discussion_r82658710 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -2433,31 +2433,65 @@ class Dataset[T] private[sql]( } /** -

[GitHub] spark pull request #14897: [SPARK-17338][SQL] add global temp view

2016-10-10 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/14897#discussion_r82658617 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/catalog/Catalog.scala --- @@ -262,15 +262,33 @@ abstract class Catalog { options: Map[String,

[GitHub] spark pull request #14897: [SPARK-17338][SQL] add global temp view

2016-10-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/14897 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request #14897: [SPARK-17338][SQL] add global temp view

2016-10-09 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/14897#discussion_r82538273 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/GlobalTempViewSuite.scala --- @@ -0,0 +1,168 @@ +/* + * Licensed to the Apache Softwa

[GitHub] spark pull request #14897: [SPARK-17338][SQL] add global temp view

2016-10-09 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/14897#discussion_r82536096 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/internal/SharedState.scala --- @@ -94,6 +69,47 @@ private[sql] class SharedState(val sparkContext: Spar

[GitHub] spark pull request #14897: [SPARK-17338][SQL] add global temp view

2016-10-09 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/14897#discussion_r82536038 --- Diff: python/pyspark/sql/catalog.py --- @@ -181,6 +181,22 @@ def dropTempView(self, viewName): """ self._jcatalog.dropTempView(vie

[GitHub] spark pull request #14897: [SPARK-17338][SQL] add global temp view

2016-10-09 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14897#discussion_r82517570 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/GlobalTempViewSuite.scala --- @@ -0,0 +1,168 @@ +/* + * Licensed to the Apache So

[GitHub] spark pull request #14897: [SPARK-17338][SQL] add global temp view

2016-10-09 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14897#discussion_r82517462 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/internal/SharedState.scala --- @@ -94,6 +69,47 @@ private[sql] class SharedState(val sparkContext:

[GitHub] spark pull request #14897: [SPARK-17338][SQL] add global temp view

2016-10-09 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14897#discussion_r82517434 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/internal/SharedState.scala --- @@ -37,39 +37,14 @@ import org.apache.spark.util.{MutableURLClassLoad

[GitHub] spark pull request #14897: [SPARK-17338][SQL] add global temp view

2016-10-09 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14897#discussion_r82517346 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala --- @@ -380,6 +380,7 @@ class SparkSqlAstBuilder(conf: SQLConf) exten

[GitHub] spark pull request #14897: [SPARK-17338][SQL] add global temp view

2016-10-09 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14897#discussion_r82517333 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/QueryExecution.scala --- @@ -125,6 +124,9 @@ class QueryExecution(val sparkSession: SparkS

[GitHub] spark pull request #14897: [SPARK-17338][SQL] add global temp view

2016-10-09 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14897#discussion_r82517028 --- Diff: python/pyspark/sql/catalog.py --- @@ -181,6 +181,22 @@ def dropTempView(self, viewName): """ self._jcatalog.dropTempView

[GitHub] spark pull request #14897: [SPARK-17338][SQL] add global temp view

2016-10-07 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/14897#discussion_r82492217 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -453,7 +534,11 @@ class SessionCatalog( val

[GitHub] spark pull request #14897: [SPARK-17338][SQL] add global temp view

2016-10-07 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/14897#discussion_r82493489 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/internal/SharedState.scala --- @@ -37,39 +37,14 @@ import org.apache.spark.util.{MutableURLClassLoader,

[GitHub] spark pull request #14897: [SPARK-17338][SQL] add global temp view

2016-10-07 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/14897#discussion_r82493266 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -2433,31 +2433,65 @@ class Dataset[T] private[sql]( } /** -

[GitHub] spark pull request #14897: [SPARK-17338][SQL] add global temp view

2016-10-07 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/14897#discussion_r82493366 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala --- @@ -183,17 +183,19 @@ case class DropTableCommand( override

[GitHub] spark pull request #14897: [SPARK-17338][SQL] add global temp view

2016-10-07 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/14897#discussion_r82279784 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/GlobalTempViewManager.scala --- @@ -0,0 +1,121 @@ +/* + * Licensed to the

[GitHub] spark pull request #14897: [SPARK-17338][SQL] add global temp view

2016-10-07 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/14897#discussion_r82299965 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -188,6 +196,11 @@ class SessionCatalog( d

[GitHub] spark pull request #14897: [SPARK-17338][SQL] add global temp view

2016-10-07 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/14897#discussion_r82493491 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/internal/SharedState.scala --- @@ -37,39 +37,14 @@ import org.apache.spark.util.{MutableURLClassLoader,

[GitHub] spark pull request #14897: [SPARK-17338][SQL] add global temp view

2016-10-07 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/14897#discussion_r82493318 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala --- @@ -380,6 +380,7 @@ class SparkSqlAstBuilder(conf: SQLConf) extends

[GitHub] spark pull request #14897: [SPARK-17338][SQL] add global temp view

2016-10-07 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/14897#discussion_r82493591 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/internal/SharedState.scala --- @@ -94,6 +69,47 @@ private[sql] class SharedState(val sparkContext: Spar

[GitHub] spark pull request #14897: [SPARK-17338][SQL] add global temp view

2016-10-07 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/14897#discussion_r82493274 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/QueryExecution.scala --- @@ -125,6 +124,9 @@ class QueryExecution(val sparkSession: SparkSessi

[GitHub] spark pull request #14897: [SPARK-17338][SQL] add global temp view

2016-10-07 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/14897#discussion_r82493549 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/GlobalTempViewSuite.scala --- @@ -0,0 +1,168 @@ +/* + * Licensed to the Apache Softwa

[GitHub] spark pull request #14897: [SPARK-17338][SQL] add global temp view

2016-10-07 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/14897#discussion_r82272178 --- Diff: python/pyspark/sql/catalog.py --- @@ -181,6 +181,22 @@ def dropTempView(self, viewName): """ self._jcatalog.dropTempView(vie

[GitHub] spark pull request #14897: [SPARK-17338][SQL] add global temp view

2016-10-07 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/14897#discussion_r82493357 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala --- @@ -183,17 +183,19 @@ case class DropTableCommand( override

[GitHub] spark pull request #14897: [SPARK-17338][SQL] add global temp view

2016-10-07 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/14897#discussion_r82493562 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/GlobalTempViewSuite.scala --- @@ -0,0 +1,107 @@ +/* + * Licensed to the Apache Softwa

[GitHub] spark pull request #14897: [SPARK-17338][SQL] add global temp view

2016-10-01 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/14897#discussion_r81463019 --- Diff: docs/sql-programming-guide.md --- @@ -220,6 +220,40 @@ The `sql` function enables applications to run SQL queries programmatically and

[GitHub] spark pull request #14897: [SPARK-17338][SQL] add global temp view

2016-09-30 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14897#discussion_r81330387 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/internal/CatalogImpl.scala --- @@ -95,20 +95,20 @@ class CatalogImpl(sparkSession: SparkSession) ext

[GitHub] spark pull request #14897: [SPARK-17338][SQL] add global temp view

2016-09-29 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/14897#discussion_r81281510 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -2433,31 +2433,65 @@ class Dataset[T] private[sql]( } /**

[GitHub] spark pull request #14897: [SPARK-17338][SQL] add global temp view

2016-09-29 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14897#discussion_r81261514 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -472,27 +557,48 @@ class SessionCatalog( *

[GitHub] spark pull request #14897: [SPARK-17338][SQL] add global temp view

2016-09-29 Thread jiangxb1987
Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/14897#discussion_r81114242 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala --- @@ -517,7 +517,8 @@ case class ShowTablesCommand(

[GitHub] spark pull request #14897: [SPARK-17338][SQL] add global temp view

2016-09-29 Thread jiangxb1987
Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/14897#discussion_r81112745 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -472,27 +557,48 @@ class SessionCatalog(

[GitHub] spark pull request #14897: [SPARK-17338][SQL] add global temp view

2016-09-28 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14897#discussion_r81044097 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -2433,31 +2433,65 @@ class Dataset[T] private[sql]( } /**

[GitHub] spark pull request #14897: [SPARK-17338][SQL] add global temp view

2016-09-28 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/14897#discussion_r81012097 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -472,27 +557,48 @@ class SessionCatalog(

[GitHub] spark pull request #14897: [SPARK-17338][SQL] add global temp view

2016-09-28 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/14897#discussion_r80988644 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/GlobalTempViewSuite.scala --- @@ -0,0 +1,123 @@ +/* + * Licensed to the Apache S

[GitHub] spark pull request #14897: [SPARK-17338][SQL] add global temp view

2016-09-28 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/14897#discussion_r80985641 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -2433,31 +2433,65 @@ class Dataset[T] private[sql]( } /**

[GitHub] spark pull request #14897: [SPARK-17338][SQL] add global temp view

2016-09-27 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14897#discussion_r80846005 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/internal/SharedState.scala --- @@ -37,39 +37,14 @@ import org.apache.spark.util.{MutableURLClassLoad

[GitHub] spark pull request #14897: [SPARK-17338][SQL] add global temp view

2016-09-25 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14897#discussion_r80407704 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala --- @@ -60,20 +90,21 @@ case class CreateViewCommand( child:

[GitHub] spark pull request #14897: [SPARK-17338][SQL] add global temp view

2016-09-25 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14897#discussion_r80403654 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -393,21 +459,25 @@ class SessionCatalog( *

[GitHub] spark pull request #14897: [SPARK-17338][SQL] add global temp view

2016-09-25 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14897#discussion_r80403612 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -371,16 +431,24 @@ class SessionCatalog( *

[GitHub] spark pull request #14897: [SPARK-17338][SQL] add global temp view

2016-09-25 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14897#discussion_r80403509 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -142,8 +149,12 @@ class SessionCatalog( //

[GitHub] spark pull request #14897: [SPARK-17338][SQL] add global temp view

2016-09-25 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14897#discussion_r80403416 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/internal/SharedState.scala --- @@ -37,6 +37,20 @@ import org.apache.spark.util.{MutableURLClassLoade

[GitHub] spark pull request #14897: [SPARK-17338][SQL] add global temp view

2016-09-25 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14897#discussion_r80403386 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala --- @@ -222,8 +265,8 @@ case class AlterViewAsCommand( qe.ass

[GitHub] spark pull request #14897: [SPARK-17338][SQL] add global temp view

2016-09-25 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14897#discussion_r80402604 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/GlobalTempViewManager.scala --- @@ -0,0 +1,96 @@ +/* + * Licensed to t

[GitHub] spark pull request #14897: [SPARK-17338][SQL] add global temp view

2016-09-25 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/14897#discussion_r80396050 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/internal/SharedState.scala --- @@ -37,6 +37,20 @@ import org.apache.spark.util.{MutableURLClassLoader,

[GitHub] spark pull request #14897: [SPARK-17338][SQL] add global temp view

2016-09-25 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/14897#discussion_r80395764 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -453,7 +532,11 @@ class SessionCatalog( val

[GitHub] spark pull request #14897: [SPARK-17338][SQL] add global temp view

2016-09-25 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/14897#discussion_r80395565 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -142,8 +149,12 @@ class SessionCatalog( // ---

[GitHub] spark pull request #14897: [SPARK-17338][SQL] add global temp view

2016-09-25 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/14897#discussion_r80395798 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala --- @@ -222,8 +265,8 @@ case class AlterViewAsCommand( qe.assertA

[GitHub] spark pull request #14897: [SPARK-17338][SQL] add global temp view

2016-09-25 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/14897#discussion_r80395752 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -393,21 +459,25 @@ class SessionCatalog( */

[GitHub] spark pull request #14897: [SPARK-17338][SQL] add global temp view

2016-09-25 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/14897#discussion_r80395517 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/GlobalTempViewManager.scala --- @@ -0,0 +1,96 @@ +/* + * Licensed to the A

[GitHub] spark pull request #14897: [SPARK-17338][SQL] add global temp view

2016-09-25 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/14897#discussion_r80396017 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/internal/CatalogImpl.scala --- @@ -277,7 +275,7 @@ class CatalogImpl(sparkSession: SparkSession) extends

[GitHub] spark pull request #14897: [SPARK-17338][SQL] add global temp view

2016-09-25 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/14897#discussion_r80395571 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -47,6 +50,8 @@ object SessionCatalog { */ c

[GitHub] spark pull request #14897: [SPARK-17338][SQL] add global temp view

2016-09-25 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/14897#discussion_r80395605 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -329,33 +343,77 @@ class SessionCatalog( // ---

[GitHub] spark pull request #14897: [SPARK-17338][SQL] add global temp view

2016-09-25 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/14897#discussion_r80395993 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/internal/CatalogImpl.scala --- @@ -277,7 +275,7 @@ class CatalogImpl(sparkSession: SparkSession) extends

[GitHub] spark pull request #14897: [SPARK-17338][SQL] add global temp view

2016-09-25 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/14897#discussion_r80395754 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -393,21 +459,25 @@ class SessionCatalog( */

[GitHub] spark pull request #14897: [SPARK-17338][SQL] add global temp view

2016-09-25 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/14897#discussion_r80396066 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/GlobalTempViewSuite.scala --- @@ -0,0 +1,107 @@ +/* + * Licensed to the Apache Softwa

[GitHub] spark pull request #14897: [SPARK-17338][SQL] add global temp view

2016-09-25 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/14897#discussion_r80395510 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/GlobalTempViewManager.scala --- @@ -0,0 +1,96 @@ +/* + * Licensed to the A

[GitHub] spark pull request #14897: [SPARK-17338][SQL] add global temp view

2016-09-25 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/14897#discussion_r80395895 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala --- @@ -197,6 +201,45 @@ case class CreateViewCommand( } }

[GitHub] spark pull request #14897: [SPARK-17338][SQL] add global temp view

2016-09-25 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/14897#discussion_r80393533 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -459,7 +459,8 @@ class Analyzer( case u: Unresol

[GitHub] spark pull request #14897: [SPARK-17338][SQL] add global temp view

2016-09-23 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/14897#discussion_r80280321 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -424,17 +496,24 @@ class SessionCatalog(

[GitHub] spark pull request #14897: [SPARK-17338][SQL] add global temp view

2016-09-23 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/14897#discussion_r80280674 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -453,7 +532,11 @@ class SessionCatalog(

[GitHub] spark pull request #14897: [SPARK-17338][SQL] add global temp view

2016-09-23 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/14897#discussion_r80282210 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala --- @@ -60,20 +90,21 @@ case class CreateViewCommand( child:

[GitHub] spark pull request #14897: [SPARK-17338][SQL] add global temp view

2016-09-23 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/14897#discussion_r80080673 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -47,6 +50,8 @@ object SessionCatalog { */

[GitHub] spark pull request #14897: [SPARK-17338][SQL] add global temp view

2016-09-23 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/14897#discussion_r80279937 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -371,16 +431,24 @@ class SessionCatalog( *

[GitHub] spark pull request #14897: [SPARK-17338][SQL] add global temp view

2016-09-23 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/14897#discussion_r80080872 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -142,8 +149,12 @@ class SessionCatalog( //

[GitHub] spark pull request #14897: [SPARK-17338][SQL] add global temp view

2016-09-23 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/14897#discussion_r80281859 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala --- @@ -19,13 +19,46 @@ package org.apache.spark.sql.execution.command

[GitHub] spark pull request #14897: [SPARK-17338][SQL] add global temp view

2016-09-23 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14897#discussion_r80198629 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -188,6 +199,10 @@ class SessionCatalog(

[GitHub] spark pull request #14897: [SPARK-17338][SQL] add global temp view

2016-09-23 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14897#discussion_r80198287 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -36,6 +36,9 @@ import org.apache.spark.sql.catalys

[GitHub] spark pull request #14897: [SPARK-17338][SQL] add global temp view

2016-09-22 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/14897#discussion_r80183259 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -188,6 +199,10 @@ class SessionCatalog(

[GitHub] spark pull request #14897: [SPARK-17338][SQL] add global temp view

2016-09-22 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/14897#discussion_r80180856 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -36,6 +36,9 @@ import org.apache.spark.sql.cataly

[GitHub] spark pull request #14897: [SPARK-17338][SQL] add global temp view

2016-09-07 Thread skambha
Github user skambha commented on a diff in the pull request: https://github.com/apache/spark/pull/14897#discussion_r77879554 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -451,7 +464,7 @@ class SessionCatalog( if (

[GitHub] spark pull request #14897: [SPARK-17338][SQL] add global temp view

2016-09-02 Thread srinathshankar
Github user srinathshankar commented on a diff in the pull request: https://github.com/apache/spark/pull/14897#discussion_r77424940 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala --- @@ -222,10 +245,19 @@ case class AlterViewAsCommand(

[GitHub] spark pull request #14897: [SPARK-17338][SQL] add global temp view

2016-09-02 Thread srinathshankar
Github user srinathshankar commented on a diff in the pull request: https://github.com/apache/spark/pull/14897#discussion_r77424851 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala --- @@ -222,10 +245,19 @@ case class AlterViewAsCommand(

[GitHub] spark pull request #14897: [SPARK-17338][SQL] add global temp view

2016-09-01 Thread clockfly
Github user clockfly commented on a diff in the pull request: https://github.com/apache/spark/pull/14897#discussion_r77265693 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala --- @@ -255,3 +287,43 @@ case class AlterViewAsCommand( sessio

[GitHub] spark pull request #14897: [SPARK-17338][SQL] add global temp view

2016-09-01 Thread clockfly
Github user clockfly commented on a diff in the pull request: https://github.com/apache/spark/pull/14897#discussion_r77265560 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala --- @@ -198,10 +219,12 @@ case class CreateViewCommand( }

[GitHub] spark pull request #14897: [SPARK-17338][SQL] add global temp view

2016-09-01 Thread clockfly
Github user clockfly commented on a diff in the pull request: https://github.com/apache/spark/pull/14897#discussion_r77264967 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala --- @@ -25,7 +25,41 @@ import org.apache.spark.sql.catalyst.catalog.{C

[GitHub] spark pull request #14897: [SPARK-17338][SQL] add global temp view

2016-09-01 Thread clockfly
Github user clockfly commented on a diff in the pull request: https://github.com/apache/spark/pull/14897#discussion_r77264028 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/TempViewManager.scala --- @@ -0,0 +1,62 @@ +/* + * Licensed to the Apac

[GitHub] spark pull request #14897: [SPARK-17338][SQL] add global temp view

2016-09-01 Thread clockfly
Github user clockfly commented on a diff in the pull request: https://github.com/apache/spark/pull/14897#discussion_r77263886 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/TempViewManager.scala --- @@ -0,0 +1,62 @@ +/* + * Licensed to the Apac

[GitHub] spark pull request #14897: [SPARK-17338][SQL] add global temp view

2016-08-31 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/14897#discussion_r77098400 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala --- @@ -255,3 +287,43 @@ case class AlterViewAsCommand( s

[GitHub] spark pull request #14897: [SPARK-17338][SQL] add global temp view

2016-08-31 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/14897#discussion_r77097547 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala --- @@ -255,3 +287,43 @@ case class AlterViewAsCommand( s

[GitHub] spark pull request #14897: [SPARK-17338][SQL] add global temp view

2016-08-31 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14897#discussion_r77097177 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala --- @@ -255,3 +287,43 @@ case class AlterViewAsCommand( sessi

[GitHub] spark pull request #14897: [SPARK-17338][SQL] add global temp view

2016-08-31 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/14897#discussion_r77008695 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala --- @@ -255,3 +287,43 @@ case class AlterViewAsCommand( s

[GitHub] spark pull request #14897: [SPARK-17338][SQL] add global temp view

2016-08-31 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/14897#discussion_r77007610 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala --- @@ -255,3 +287,43 @@ case class AlterViewAsCommand( s

[GitHub] spark pull request #14897: [SPARK-17338][SQL] add global temp view

2016-08-31 Thread cloud-fan
GitHub user cloud-fan opened a pull request: https://github.com/apache/spark/pull/14897 [SPARK-17338][SQL] add global temp view ## What changes were proposed in this pull request? global temporary view is a cross-session temporary view, which means it's shared among all ses