[GitHub] spark pull request #15082: [SPARK-17528][SQL] MutableProjection should not c...

2017-06-13 Thread cloud-fan
Github user cloud-fan closed the pull request at: https://github.com/apache/spark/pull/15082 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #15082: [SPARK-17528][SQL] MutableProjection should not c...

2016-09-15 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/15082#discussion_r79029655 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/RowTest.scala --- @@ -121,10 +121,6 @@ class RowTest extends FunSpec with Matchers {

[GitHub] spark pull request #15082: [SPARK-17528][SQL] MutableProjection should not c...

2016-09-15 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/15082#discussion_r78940604 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/RowTest.scala --- @@ -121,10 +121,6 @@ class RowTest extends FunSpec with Matchers { e

[GitHub] spark pull request #15082: [SPARK-17528][SQL] MutableProjection should not c...

2016-09-15 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/15082#discussion_r78931633 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/RowTest.scala --- @@ -121,10 +121,6 @@ class RowTest extends FunSpec with Matchers {

[GitHub] spark pull request #15082: [SPARK-17528][SQL] MutableProjection should not c...

2016-09-15 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/15082#discussion_r78927126 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/RowTest.scala --- @@ -121,10 +121,6 @@ class RowTest extends FunSpec with Matchers { e

[GitHub] spark pull request #15082: [SPARK-17528][SQL] MutableProjection should not c...

2016-09-15 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/15082#discussion_r78915332 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/RowTest.scala --- @@ -121,10 +121,6 @@ class RowTest extends FunSpec with Matchers {

[GitHub] spark pull request #15082: [SPARK-17528][SQL] MutableProjection should not c...

2016-09-14 Thread cloud-fan
GitHub user cloud-fan reopened a pull request: https://github.com/apache/spark/pull/15082 [SPARK-17528][SQL] MutableProjection should not cache content from the input row ## What changes were proposed in this pull request? For performance reasons, `UnsafeRow.getString`, `ge

[GitHub] spark pull request #15082: [SPARK-17528][SQL] MutableProjection should not c...

2016-09-14 Thread cloud-fan
Github user cloud-fan closed the pull request at: https://github.com/apache/spark/pull/15082 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #15082: [SPARK-17528][SQL] MutableProjection should not c...

2016-09-13 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/15082#discussion_r78667613 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala --- @@ -276,6 +276,11 @@ class CodegenContext {

[GitHub] spark pull request #15082: [SPARK-17528][SQL] MutableProjection should not c...

2016-09-13 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/15082#discussion_r78615957 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/SpecificMutableRow.scala --- @@ -225,10 +227,20 @@ final class SpecificMu

[GitHub] spark pull request #15082: [SPARK-17528][SQL] MutableProjection should not c...

2016-09-13 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/15082#discussion_r78611782 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/SpecificMutableRow.scala --- @@ -225,10 +227,20 @@ final class SpecificMut

[GitHub] spark pull request #15082: [SPARK-17528][SQL] MutableProjection should not c...

2016-09-13 Thread cloud-fan
GitHub user cloud-fan opened a pull request: https://github.com/apache/spark/pull/15082 [SPARK-17528][SQL] MutableProjection should not cache content from the input row ## What changes were proposed in this pull request? For performance reasons, `UnsafeRow.getString`, `getS