[GitHub] spark pull request #15647: [SPARK-18088][ML] Various ChiSqSelector cleanups

Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/15647 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #15647: [SPARK-18088][ML] Various ChiSqSelector cleanups

Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/15647#discussion_r85354084 --- Diff: docs/ml-features.md --- @@ -1333,14 +1333,14 @@ for more details on the API. `ChiSqSelector` stands for Chi-Squared feature selection. It

[GitHub] spark pull request #15647: [SPARK-18088][ML] Various ChiSqSelector cleanups

Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/15647#discussion_r85354615 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/ChiSqSelector.scala --- @@ -44,67 +44,78 @@ private[feature] trait ChiSqSelectorParams extends

[GitHub] spark pull request #15647: [SPARK-18088][ML] Various ChiSqSelector cleanups

Github user mpjlu commented on a diff in the pull request: https://github.com/apache/spark/pull/15647#discussion_r85311930 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/feature/ChiSqSelector.scala --- @@ -171,18 +171,19 @@ object ChiSqSelectorModel extends

[GitHub] spark pull request #15647: [SPARK-18088][ML] Various ChiSqSelector cleanups

Github user mpjlu commented on a diff in the pull request: https://github.com/apache/spark/pull/15647#discussion_r85311619 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/ChiSqSelector.scala --- @@ -44,67 +44,78 @@ private[feature] trait ChiSqSelectorParams extends

[GitHub] spark pull request #15647: [SPARK-18088][ML] Various ChiSqSelector cleanups

Github user mpjlu commented on a diff in the pull request: https://github.com/apache/spark/pull/15647#discussion_r85311677 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/ChiSqSelector.scala --- @@ -44,67 +44,78 @@ private[feature] trait ChiSqSelectorParams extends

[GitHub] spark pull request #15647: [SPARK-18088][ML] Various ChiSqSelector cleanups

Github user mpjlu commented on a diff in the pull request: https://github.com/apache/spark/pull/15647#discussion_r85310898 --- Diff: docs/mllib-feature-extraction.md --- @@ -227,22 +227,19 @@ both speed and statistical learning behavior.

[GitHub] spark pull request #15647: [SPARK-18088][ML] Various ChiSqSelector cleanups

Github user mpjlu commented on a diff in the pull request: https://github.com/apache/spark/pull/15647#discussion_r85310797 --- Diff: docs/ml-features.md --- @@ -1333,14 +1333,14 @@ for more details on the API. `ChiSqSelector` stands for Chi-Squared feature selection. It

[GitHub] spark pull request #15647: [SPARK-18088][ML] Various ChiSqSelector cleanups

Github user mpjlu commented on a diff in the pull request: https://github.com/apache/spark/pull/15647#discussion_r85310862 --- Diff: docs/mllib-feature-extraction.md --- @@ -227,22 +227,19 @@ both speed and statistical learning behavior.

[GitHub] spark pull request #15647: [SPARK-18088][ML] Various ChiSqSelector cleanups

Github user mpjlu commented on a diff in the pull request: https://github.com/apache/spark/pull/15647#discussion_r85310501 --- Diff: docs/ml-features.md --- @@ -1333,14 +1333,14 @@ for more details on the API. `ChiSqSelector` stands for Chi-Squared feature selection. It

[GitHub] spark pull request #15647: [SPARK-18088][ML] Various ChiSqSelector cleanups

GitHub user jkbradley opened a pull request: https://github.com/apache/spark/pull/15647 [SPARK-18088][ML] Various ChiSqSelector cleanups ## What changes were proposed in this pull request? * Renamed kbest to numTopFeatures * Renamed alpha to fpr * Added missing