Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/16149
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/16149#discussion_r91982251
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -467,10 +469,12 @@ object GeneralizedLinearRegression
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/16149#discussion_r91958478
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -467,10 +469,12 @@ object GeneralizedLinearRegression
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/16149#discussion_r91956672
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -467,10 +469,12 @@ object GeneralizedLinearRegression
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/16149#discussion_r91901487
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/GeneralizedLinearRegressionSuite.scala
---
@@ -715,7 +715,7 @@ class
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/16149#discussion_r91898659
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -467,10 +469,12 @@ object GeneralizedLinearRegression
Github user actuaryzhang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16149#discussion_r91643659
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -468,11 +469,7 @@ object
Github user actuaryzhang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16149#discussion_r91643515
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/GeneralizedLinearRegressionSuite.scala
---
@@ -715,7 +715,7 @@ class
Github user actuaryzhang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16149#discussion_r91563322
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/GeneralizedLinearRegressionSuite.scala
---
@@ -715,7 +715,7 @@ class
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/16149#discussion_r91453574
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -215,6 +215,7 @@ class GeneralizedLinearRegression
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/16149#discussion_r91453386
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/GeneralizedLinearRegressionSuite.scala
---
@@ -715,7 +715,7 @@ class
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/16149#discussion_r91453428
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -468,11 +469,7 @@ object GeneralizedLinearRegression
Github user actuaryzhang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16149#discussion_r91440862
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -479,7 +485,12 @@ object
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/16149#discussion_r91432167
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -479,7 +485,12 @@ object GeneralizedLinearRegression
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/16149#discussion_r91431539
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -467,10 +467,16 @@ object GeneralizedLinearRegression
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/16149#discussion_r91431452
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/GeneralizedLinearRegressionSuite.scala
---
@@ -708,73 +708,72 @@ class
Github user actuaryzhang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16149#discussion_r91246870
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -479,7 +479,12 @@ object
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/16149#discussion_r91168760
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -479,7 +479,12 @@ object GeneralizedLinearRegression
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/16149#discussion_r91021502
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -479,7 +479,12 @@ object GeneralizedLinearRegression
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/16149#discussion_r90968163
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -479,7 +479,12 @@ object GeneralizedLinearRegression
GitHub user actuaryzhang opened a pull request:
https://github.com/apache/spark/pull/16149
[SPARK-18715][ML]Fix AIC calculations in Binomial GLM
The AIC calculation in Binomial GLM seems to be off when the response or
weight is non-integer: the result is different from that in R.
21 matches
Mail list logo
