Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/21193
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user rednaxelafx commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r189785968
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeBlockSuite.scala
---
@@ -23,12 +23,20 @@ import
Github user rednaxelafx commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r189786155
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
---
@@ -167,9 +170,40 @@ object Block {
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r189767747
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
---
@@ -167,9 +170,40 @@ object Block {
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r189768074
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
---
@@ -167,9 +170,40 @@ object Block {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r189617272
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
---
@@ -167,9 +170,40 @@ object Block {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r189616918
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
---
@@ -167,9 +170,40 @@ object Block {
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r189430164
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
---
@@ -114,6 +114,115 @@ object JavaCode {
}
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r189279129
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeBlockSuite.scala
---
@@ -0,0 +1,130 @@
+/*
+ * Licensed
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r189264892
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
---
@@ -114,6 +114,115 @@ object JavaCode {
}
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r189264507
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeBlockSuite.scala
---
@@ -0,0 +1,130 @@
+/*
+ * Licensed
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r189259397
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
---
@@ -114,6 +114,115 @@ object JavaCode {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r189259323
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
---
@@ -114,6 +114,115 @@ object JavaCode {
Github user rednaxelafx commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r189229566
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeBlockSuite.scala
---
@@ -0,0 +1,130 @@
+/*
+ *
Github user rednaxelafx commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r189225184
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
---
@@ -114,6 +114,115 @@ object JavaCode {
Github user rednaxelafx commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r189229229
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeBlockSuite.scala
---
@@ -0,0 +1,130 @@
+/*
+ *
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r189213433
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
---
@@ -114,6 +114,115 @@ object JavaCode {
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r189212543
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
---
@@ -114,6 +114,115 @@ object JavaCode {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r189208663
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -259,8 +260,8 @@ trait CodegenSupport extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r189206358
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/inputFileBlock.scala
---
@@ -88,7 +89,7 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r189208302
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
---
@@ -114,6 +114,115 @@ object JavaCode {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r189208129
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/ColumnarBatchScan.scala
---
@@ -58,14 +59,14 @@ private[sql] trait ColumnarBatchScan
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r189206338
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/inputFileBlock.scala
---
@@ -65,8 +66,8 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r189202465
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala
---
@@ -100,17 +101,18 @@ abstract class Expression
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r189204054
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
---
@@ -114,6 +114,115 @@ object JavaCode {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r189207159
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeBlockSuite.scala
---
@@ -0,0 +1,130 @@
+/*
+ *
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r189207915
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeBlockSuite.scala
---
@@ -0,0 +1,130 @@
+/*
+ *
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r189206126
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/inputFileBlock.scala
---
@@ -42,8 +43,8 @@ case class InputFileName()
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r188959114
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
---
@@ -114,6 +114,115 @@ object JavaCode {
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r188956140
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
---
@@ -114,6 +114,115 @@ object JavaCode {
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r188955270
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
---
@@ -114,6 +114,115 @@ object JavaCode {
}
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r188954468
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
---
@@ -114,6 +114,115 @@ object JavaCode {
}
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r188950746
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
---
@@ -114,6 +114,115 @@ object JavaCode {
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r188950520
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
---
@@ -114,6 +114,115 @@ object JavaCode {
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r18894
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
---
@@ -114,6 +114,113 @@ object JavaCode {
}
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r188907963
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
---
@@ -114,6 +114,113 @@ object JavaCode {
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r188904786
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
---
@@ -114,6 +114,113 @@ object JavaCode {
}
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r188857554
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
---
@@ -114,6 +114,113 @@ object JavaCode {
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r188830465
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
---
@@ -114,6 +114,113 @@ object JavaCode {
}
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r187982910
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -623,8 +624,14 @@ case class Cast(child: Expression,
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r187978104
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -623,8 +624,14 @@ case class Cast(child: Expression,
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r187612068
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
---
@@ -114,6 +114,113 @@ object JavaCode {
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r187058840
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala
---
@@ -100,17 +101,18 @@ abstract class Expression
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r187058702
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -623,8 +624,14 @@ case class Cast(child: Expression,
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r187036570
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -56,19 +57,19 @@ import
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r187034014
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -623,8 +624,14 @@ case class Cast(child: Expression,
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r187033550
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -623,8 +624,14 @@ case class Cast(child: Expression,
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r186681857
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -623,8 +624,14 @@ case class Cast(child: Expression,
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r186677863
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala
---
@@ -100,17 +101,18 @@ abstract class Expression
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r186683015
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -56,19 +57,19 @@ import
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r186674665
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -623,8 +624,14 @@ case class Cast(child: Expression,
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r186679356
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala
---
@@ -119,7 +121,7 @@ abstract class Expression extends
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r186679287
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
---
@@ -114,6 +114,113 @@ object JavaCode {
}
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r186679018
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
---
@@ -114,6 +114,113 @@ object JavaCode {
}
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r186670840
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
---
@@ -114,6 +114,113 @@ object JavaCode {
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r186670675
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
---
@@ -114,6 +114,113 @@ object JavaCode {
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r186669860
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala
---
@@ -119,7 +121,7 @@ abstract class Expression
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r186661027
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -623,8 +624,14 @@ case class Cast(child: Expression,
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r186644321
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -623,8 +624,14 @@ case class Cast(child: Expression,
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r186630931
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -623,8 +624,14 @@ case class Cast(child: Expression,
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r186630643
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -623,8 +624,14 @@ case class Cast(child: Expression,
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r186627928
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -623,8 +624,14 @@ case class Cast(child: Expression,
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r186627099
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -623,8 +624,14 @@ case class Cast(child: Expression,
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r186627026
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -623,8 +624,14 @@ case class Cast(child: Expression,
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r186626823
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -623,8 +624,14 @@ case class Cast(child: Expression,
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r186625672
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -623,8 +624,14 @@ case class Cast(child: Expression,
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r186624071
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -623,8 +624,14 @@ case class Cast(child: Expression,
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r186621034
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
---
@@ -114,19 +114,128 @@ object JavaCode {
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r186618899
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
---
@@ -114,19 +114,128 @@ object JavaCode {
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r186618877
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
---
@@ -114,19 +114,128 @@ object JavaCode {
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r186618580
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
---
@@ -114,19 +114,128 @@ object JavaCode {
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r186618412
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -623,8 +624,14 @@ case class Cast(child: Expression,
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r186617171
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
---
@@ -114,19 +114,128 @@ object JavaCode {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r186615731
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -623,8 +624,14 @@ case class Cast(child: Expression,
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r186617013
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
---
@@ -114,19 +114,128 @@ object JavaCode {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r186616773
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
---
@@ -114,19 +114,128 @@ object JavaCode {
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r186361480
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
---
@@ -112,6 +112,112 @@ object JavaCode {
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r186359947
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/codegen/ExprValueSuite.scala
---
@@ -17,6 +17,8 @@
package
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r186356233
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/codegen/ExprValueSuite.scala
---
@@ -17,6 +17,8 @@
package
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r186263675
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -64,7 +64,7 @@ case class
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r186263241
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -64,7 +64,7 @@ case class
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r186254876
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
---
@@ -112,6 +112,112 @@ object JavaCode {
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r186251510
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
---
@@ -112,6 +112,112 @@ object JavaCode {
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r186251439
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
---
@@ -112,6 +112,112 @@ object JavaCode {
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r186251251
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
---
@@ -112,6 +112,112 @@ object JavaCode {
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r186251147
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
---
@@ -112,6 +112,112 @@ object JavaCode {
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r186251103
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
---
@@ -112,6 +112,112 @@ object JavaCode {
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r186251067
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
---
@@ -112,6 +112,112 @@ object JavaCode {
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r186250918
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
---
@@ -112,6 +112,112 @@ object JavaCode {
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r186250803
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
---
@@ -112,6 +112,112 @@ object JavaCode {
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r186250693
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
---
@@ -112,6 +112,112 @@ object JavaCode {
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r186250678
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
---
@@ -112,6 +112,112 @@ object JavaCode {
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r186250676
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
---
@@ -112,6 +112,112 @@ object JavaCode {
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r186250659
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
---
@@ -112,6 +112,112 @@ object JavaCode {
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r186250552
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
---
@@ -112,6 +112,112 @@ object JavaCode {
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r186247026
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
---
@@ -112,6 +112,112 @@ object JavaCode {
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r186247501
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
---
@@ -112,6 +112,112 @@ object JavaCode {
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r186247824
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
---
@@ -112,6 +112,112 @@ object JavaCode {
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r186248265
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
---
@@ -112,6 +112,112 @@ object JavaCode {
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r185995523
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
---
@@ -112,6 +112,112 @@ object JavaCode {
1 - 100 of 101 matches
Mail list logo
