Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/2065#discussion_r16758766
--- Diff:
external/flume/src/main/scala/org/apache/spark/streaming/flume/FlumeBatchFetcher.scala
---
@@ -0,0 +1,160 @@
+/*
+ * Licensed to the Apache
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1929#issuecomment-53529843
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19293/consoleFull)
for PR 1929 at commit
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/2065#discussion_r16758798
--- Diff:
external/flume/src/main/scala/org/apache/spark/streaming/flume/FlumeBatchFetcher.scala
---
@@ -0,0 +1,160 @@
+/*
+ * Licensed to the Apache
Github user chenghao-intel commented on the pull request:
https://github.com/apache/spark/pull/2155#issuecomment-53529874
This is a follow up of #2114 after discussing with @marmbrus
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2155#issuecomment-53529888
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19292/consoleFull)
for PR 2155 at commit
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/2065#discussion_r16758820
--- Diff:
external/flume/src/main/scala/org/apache/spark/streaming/flume/FlumeBatchFetcher.scala
---
@@ -0,0 +1,160 @@
+/*
+ * Licensed to the Apache
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/2065#issuecomment-53530019
This now looks quite good to me. There were a few more formatting issues,
should take 5 minutes to solve :)
---
If your project is set up for it, you can reply to this
GitHub user andrewor14 opened a pull request:
https://github.com/apache/spark/pull/2156
[SPARK-3167] Handle special driver configs in Windows (Branch 1.1)
This is an effort to bring the Windows scripts up to speed after recent
splashing changes in #1845.
You can merge this pull
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2143#issuecomment-53530146
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19289/consoleFull)
for PR 2143 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1846#issuecomment-53530198
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19287/consoleFull)
for PR 1846 at commit
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/2143#issuecomment-53530260
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/2143#issuecomment-53530257
The failed unit test is unrelated to this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/1241#discussion_r16759047
--- Diff:
core/src/main/scala/org/apache/spark/shuffle/ShuffleBlockManager.scala ---
@@ -0,0 +1,31 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/1241#discussion_r16759034
--- Diff:
core/src/main/scala/org/apache/spark/shuffle/FileShuffleBlockManager.scala ---
@@ -15,21 +15,24 @@
* limitations under the License.
*/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2143#issuecomment-53530699
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19296/consoleFull)
for PR 2143 at commit
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/1241#discussion_r16759141
--- Diff:
core/src/main/scala/org/apache/spark/shuffle/sort/SortShuffleManager.scala ---
@@ -17,14 +17,18 @@
package org.apache.spark.shuffle.sort
Github user ScrapCodes closed the pull request at:
https://github.com/apache/spark/pull/996
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user ScrapCodes commented on the pull request:
https://github.com/apache/spark/pull/1685#issuecomment-53530947
This looks good to me, given automated tests pass.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/1241#discussion_r16759235
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -34,8 +34,11 @@ import org.apache.spark.io.CompressionCodec
import
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/1241#discussion_r16759256
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -85,18 +87,62 @@ private[spark] class BlockManager(
val
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/1241#discussion_r16759266
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -107,6 +153,11 @@ private[spark] class BlockManager(
}
}
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/1241#discussion_r16759276
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -573,7 +634,7 @@ private[spark] class BlockManager(
serializer:
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/1241#discussion_r16759291
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -573,7 +634,7 @@ private[spark] class BlockManager(
serializer:
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/1241#discussion_r16759331
--- Diff: core/src/main/scala/org/apache/spark/storage/DiskStore.scala ---
@@ -89,25 +89,33 @@ private[spark] class DiskStore(blockManager:
BlockManager,
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/1241#issuecomment-53531388
Thanks for doing this. To help with the review, can you write a short
design doc discussing the interfaces between different components, similar to
the one attached here
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/1241#discussion_r16759577
--- Diff: core/src/main/scala/org/apache/spark/storage/DiskStore.scala ---
@@ -89,25 +89,33 @@ private[spark] class DiskStore(blockManager:
BlockManager,
Github user mateiz commented on the pull request:
https://github.com/apache/spark/pull/2152#issuecomment-53531754
test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/1241#discussion_r16759644
--- Diff: core/src/main/scala/org/apache/spark/storage/DiskStore.scala ---
@@ -121,20 +129,16 @@ private[spark] class DiskStore(blockManager:
BlockManager,
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/1241#discussion_r16759699
--- Diff:
core/src/main/scala/org/apache/spark/shuffle/ShuffleBlockManager.scala ---
@@ -0,0 +1,31 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2152#issuecomment-53532166
QA tests have started for PR 2152. This patch merges cleanly. brView
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19297/consoleFull
---
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/1241#discussion_r16759777
--- Diff:
core/src/main/scala/org/apache/spark/shuffle/IndexShuffleBlockManager.scala ---
@@ -0,0 +1,106 @@
+/*
+ * Licensed to the Apache Software
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/1241#discussion_r16759788
--- Diff:
core/src/main/scala/org/apache/spark/shuffle/IndexShuffleBlockManager.scala ---
@@ -0,0 +1,106 @@
+/*
+ * Licensed to the Apache Software
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/1241#discussion_r16759807
--- Diff:
core/src/main/scala/org/apache/spark/shuffle/IndexShuffleBlockManager.scala ---
@@ -0,0 +1,106 @@
+/*
+ * Licensed to the Apache Software
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2129#issuecomment-53532419
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19291/consoleFull)
for PR 2129 at commit
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/1241#discussion_r16759871
--- Diff:
core/src/main/scala/org/apache/spark/shuffle/IndexShuffleBlockManager.scala ---
@@ -0,0 +1,106 @@
+/*
+ * Licensed to the Apache Software
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2154#issuecomment-53532443
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19290/consoleFull)
for PR 2154 at commit
GitHub user baishuo opened a pull request:
https://github.com/apache/spark/pull/2157
[SPARK-3241][SQL] create NumberFormat instance by threadsafe way
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/baishuo/spark
Github user andrewor14 closed the pull request at:
https://github.com/apache/spark/pull/2156
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/1241#discussion_r16759951
--- Diff:
core/src/main/scala/org/apache/spark/shuffle/IndexShuffleBlockManager.scala ---
@@ -0,0 +1,106 @@
+/*
+ * Licensed to the Apache Software
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/1241#discussion_r16759963
--- Diff:
core/src/main/scala/org/apache/spark/shuffle/IndexShuffleBlockManager.scala ---
@@ -0,0 +1,106 @@
+/*
+ * Licensed to the Apache Software
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2157#issuecomment-53532690
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/1241#discussion_r16760004
--- Diff:
core/src/main/scala/org/apache/spark/shuffle/IndexShuffleBlockManager.scala ---
@@ -0,0 +1,106 @@
+/*
+ * Licensed to the Apache Software
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/1241#discussion_r16760032
--- Diff:
core/src/main/scala/org/apache/spark/shuffle/IndexShuffleBlockManager.scala ---
@@ -0,0 +1,106 @@
+/*
+ * Licensed to the Apache Software
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2131#discussion_r16760036
--- Diff: core/src/main/scala/org/apache/spark/CacheManager.scala ---
@@ -68,7 +68,9 @@ private[spark] class CacheManager(blockManager:
BlockManager)
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2131#discussion_r16760052
--- Diff: core/src/main/scala/org/apache/spark/ui/storage/StorageTab.scala
---
@@ -70,8 +70,10 @@ class StorageListener(storageStatusListener:
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1929#issuecomment-53533093
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19293/consoleFull)
for PR 1929 at commit
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2131#discussion_r16760122
--- Diff: core/src/test/scala/org/apache/spark/CacheManagerSuite.scala ---
@@ -87,4 +99,12 @@ class CacheManagerSuite extends FunSuite with
BeforeAndAfter
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/1241#discussion_r16760213
--- Diff:
core/src/main/scala/org/apache/spark/shuffle/IndexShuffleBlockManager.scala ---
@@ -0,0 +1,106 @@
+/*
+ * Licensed to the Apache Software
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/1241#discussion_r16760248
--- Diff:
core/src/main/scala/org/apache/spark/shuffle/hash/HashShuffleManager.scala ---
@@ -25,6 +25,9 @@ import org.apache.spark.shuffle._
* mapper
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2065#issuecomment-53533488
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19298/consoleFull)
for PR 2065 at commit
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/1241#discussion_r16760326
--- Diff:
core/src/main/scala/org/apache/spark/shuffle/FileShuffleBlockManager.scala ---
@@ -181,17 +171,30 @@ class ShuffleBlockManager(blockManager:
Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/2131#discussion_r16760352
--- Diff: core/src/main/scala/org/apache/spark/CacheManager.scala ---
@@ -68,7 +68,9 @@ private[spark] class CacheManager(blockManager:
BlockManager)
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2131#discussion_r16760497
--- Diff: core/src/main/scala/org/apache/spark/CacheManager.scala ---
@@ -68,7 +68,9 @@ private[spark] class CacheManager(blockManager:
BlockManager)
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2143#issuecomment-53534120
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19296/consoleFull)
for PR 2143 at commit
GitHub user ScrapCodes opened a pull request:
https://github.com/apache/spark/pull/2158
[SPARK-3200][REPL] Classes defined with reference to external variables,...
... should not crash REPL.
You can merge this pull request into a Git repository by running:
$ git pull
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2155#issuecomment-53534171
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19292/consoleFull)
for PR 2155 at commit
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2131#discussion_r16760627
--- Diff: core/src/test/scala/org/apache/spark/CacheManagerSuite.scala ---
@@ -87,4 +99,12 @@ class CacheManagerSuite extends FunSuite with
BeforeAndAfter
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/2143#issuecomment-53534279
Okay thanks TD and Andrew - I'm pulling this in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2158#issuecomment-53534504
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19299/consoleFull)
for PR 2158 at commit
Github user colorant commented on a diff in the pull request:
https://github.com/apache/spark/pull/1241#discussion_r16760826
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -107,6 +153,11 @@ private[spark] class BlockManager(
}
}
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/2056#issuecomment-53534681
This was fixed by a different approach in #2143.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/2143
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user chenghao-intel commented on the pull request:
https://github.com/apache/spark/pull/2157#issuecomment-53534767
I don't think we need to change anything. `NumberFormat` is not thread-safe
mean we can not share the same `NumberFormat` instance among different threads
(coz
Github user colorant commented on a diff in the pull request:
https://github.com/apache/spark/pull/1241#discussion_r16760900
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -107,6 +153,11 @@ private[spark] class BlockManager(
}
}
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2131#discussion_r16761022
--- Diff: core/src/main/scala/org/apache/spark/ui/storage/StorageTab.scala
---
@@ -70,8 +70,10 @@ class StorageListener(storageStatusListener:
Github user tnachen commented on the pull request:
https://github.com/apache/spark/pull/2145#issuecomment-53535667
Ok I just tried it on a mesos cluster and it didn't work.
The classpath it put in the Mesos command is where spark lives in the spark
shell in another host, but
Github user gkossakowski commented on the pull request:
https://github.com/apache/spark/pull/1929#issuecomment-53536315
@gkossakowski, thanks for the detailed reply. From my point of view, what
we want when new JARs are added is for earlier JARs to take precedence. This is
what
Github user uncleGen commented on a diff in the pull request:
https://github.com/apache/spark/pull/2131#discussion_r16761636
--- Diff: core/src/main/scala/org/apache/spark/CacheManager.scala ---
@@ -68,7 +68,9 @@ private[spark] class CacheManager(blockManager:
BlockManager)
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/2145#issuecomment-53536988
@tnachen Thanks a lot! I'm currently working on another version that can
figure out executor side classpath correctly. The basic idea is:
1. we still start the
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/2145#issuecomment-53537143
Hey guys, yeah this is an issue with the approach of using the utilities
from the standalone deploy mode for this - it makes assumptions that don't hold
in mesos mode.
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/1929#issuecomment-53537357
@mateiz I'd prefer not to merge this into branch-1.1 at this point unless
you see a really compelling need. Scarred from Spark 1.0.0 which actually
released with a
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2065#issuecomment-53537410
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19298/consoleFull)
for PR 2065 at commit
Github user uncleGen commented on a diff in the pull request:
https://github.com/apache/spark/pull/2131#discussion_r16762096
--- Diff: core/src/test/scala/org/apache/spark/CacheManagerSuite.scala ---
@@ -87,4 +99,12 @@ class CacheManagerSuite extends FunSuite with
BeforeAndAfter
Github user tnachen commented on the pull request:
https://github.com/apache/spark/pull/2145#issuecomment-53537607
I'm glad we're having these conversations :) Really helping folks that have
bad experience using Mesos with Spark. I'm looking forward for the fix and once
it's updated
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2150#issuecomment-53537794
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2147#issuecomment-53537765
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2152#issuecomment-53537875
QA results for PR 2152:br- This patch PASSES unit tests.br- This patch
merges cleanlybr- This patch adds no public classesbrbrFor more
information see test
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/2153
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2153#issuecomment-53538008
Thanks for looking this over! Merged to master and 1.1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user tnachen commented on the pull request:
https://github.com/apache/spark/pull/2145#issuecomment-53538424
Also I think I didn't mention it explicitly, I've been testing with having
a spark tar ball available through a HTTP server and setting SPARK_EXECUTOR_URI
to that, and
Github user colorant commented on a diff in the pull request:
https://github.com/apache/spark/pull/1241#discussion_r16762489
--- Diff: core/src/main/scala/org/apache/spark/storage/DiskStore.scala ---
@@ -121,20 +129,16 @@ private[spark] class DiskStore(blockManager:
BlockManager,
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2158#issuecomment-53538916
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19299/consoleFull)
for PR 2158 at commit
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/1241#discussion_r16762641
--- Diff: core/src/main/scala/org/apache/spark/storage/DiskStore.scala ---
@@ -121,20 +129,16 @@ private[spark] class DiskStore(blockManager:
BlockManager,
Github user scwf commented on the pull request:
https://github.com/apache/spark/pull/2145#issuecomment-53539011
hi @liancheng , is there a situation we should cover ` -Dfoo=bar bar ` ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/2151#issuecomment-53539701
Merged into master and branch-1.1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/2151
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user colorant commented on a diff in the pull request:
https://github.com/apache/spark/pull/1241#discussion_r16763705
--- Diff: core/src/main/scala/org/apache/spark/storage/DiskStore.scala ---
@@ -121,20 +129,16 @@ private[spark] class DiskStore(blockManager:
BlockManager,
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/2146#issuecomment-53542182
LGTM. Merged into master and branch-1.1. Thanks! (This doesn't touch code,
so I skipped Jenkins.)
---
If your project is set up for it, you can reply to this email and
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/2146
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user byF commented on the pull request:
https://github.com/apache/spark/pull/2084#issuecomment-53542655
I had a problem with running the tests, eventually [figured it
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/2065#issuecomment-53542841
This looks real good now. Thanks @harishreedharan for all changes and the
wonderful refactoring. I am going to quickly test this in my local flume set up
for double
Github user baishuo commented on the pull request:
https://github.com/apache/spark/pull/2157#issuecomment-53544332
thank you @chenghao-intel . I think I didnt express what I think clearly.
why there is a threadlocal is to ensure there is one and only one NumberFormat
instance in
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2056#issuecomment-53544987
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19302/consoleFull)
for PR 2056 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2056#issuecomment-53545458
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19303/consoleFull)
for PR 2056 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2056#issuecomment-53545805
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19303/consoleFull)
for PR 2056 at commit
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/2157#discussion_r16765443
--- Diff: sql/hive/src/main/scala/org/apache/spark/SparkHadoopWriter.scala
---
@@ -71,7 +71,7 @@ private[hive] class SparkHiveHadoopWriter(
}
Github user witgo commented on the pull request:
https://github.com/apache/spark/pull/2056#issuecomment-53546333
@tdas @pwendell We do not need to wait for clear `RDD`,`Broadcast`
#2143 does not solve the timeout in [removeShuffle
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/2065#issuecomment-53546318
Alright, tested this. Merging it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/2157#issuecomment-53546624
Sorry for commenting out of order -- I missed the original comment.
@baishuo why do you want to avoid multiple instances per thread? that does not
solve a thread-safety
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2056#issuecomment-53546851
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19304/consoleFull)
for PR 2056 at commit
1 - 100 of 451 matches
Mail list logo
