[GitHub] spark pull request: [SPARK-4123][Project Infra][WIP]: Show new dep...

2015-03-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5093#issuecomment-85121921 [Test build #29007 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29007/consoleFull) for PR 5093 at commit

[GitHub] spark pull request: [SPARK-4123][Project Infra][WIP]: Show new dep...

2015-03-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5093#issuecomment-85121933 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-6471][SQL]: Metastore schema should onl...

2015-03-23 Thread saucam
GitHub user saucam opened a pull request: https://github.com/apache/spark/pull/5141 [SPARK-6471][SQL]: Metastore schema should only be a subset of parquet schema to support dropping of columns using replace columns Currently in the parquet relation 2 implementation, error is thrown

[GitHub] spark pull request: SPARK-6414: Spark driver failed with NPE on jo...

2015-03-23 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/5124#discussion_r26961357 --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala --- @@ -805,7 +806,7 @@ class DAGScheduler( } val

[GitHub] spark pull request: [SPARK-6463] [SQL]AttributeSet.equal should co...

2015-03-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5133#issuecomment-85127620 [Test build #29010 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29010/consoleFull) for PR 5133 at commit

[GitHub] spark pull request: [SPARK-3454] [WIP] separate json endpoints for...

2015-03-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4435#issuecomment-85127615 [Test build #29011 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29011/consoleFull) for PR 4435 at commit

[GitHub] spark pull request: SPARK-6414: Spark driver failed with NPE on jo...

2015-03-23 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/5124#issuecomment-85132931 (Sorry, that should have been `SparkContext.localProperties.initialValue` above; I've revised my comment) --- If your project is set up for it, you can reply to this

[GitHub] spark pull request: [SPARK-4086][GraphX]: Fold-style aggregation f...

2015-03-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5142#issuecomment-85142892 [Test build #29018 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29018/consoleFull) for PR 5142 at commit

[GitHub] spark pull request: [SPARK-5124][Core] A standard RPC interface an...

2015-03-23 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/4588#discussion_r26960440 --- Diff: core/src/test/scala/org/apache/spark/rpc/RpcEnvSuite.scala --- @@ -0,0 +1,526 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] spark pull request: [SPARK-3454] [WIP] separate json endpoints for...

2015-03-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4435#issuecomment-85123710 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-3454] [WIP] separate json endpoints for...

2015-03-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4435#issuecomment-85123697 [Test build #29002 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29002/consoleFull) for PR 4435 at commit

[GitHub] spark pull request: SPARK-6414: Spark driver failed with NPE on jo...

2015-03-23 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/5124#issuecomment-85124958 Jenkins, this is ok to test. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: SPARK-6414: Spark driver failed with NPE on jo...

2015-03-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5124#issuecomment-85125446 [Test build #29009 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29009/consoleFull) for PR 5124 at commit

[GitHub] spark pull request: [SPARK-3454] [WIP] separate json endpoints for...

2015-03-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4435#issuecomment-85129025 [Test build #29013 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29013/consoleFull) for PR 4435 at commit

[GitHub] spark pull request: [SPARK-4123][Project Infra][WIP]: Show new dep...

2015-03-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5093#issuecomment-85131070 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4123][Project Infra][WIP]: Show new dep...

2015-03-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5093#issuecomment-85131065 [Test build #29014 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29014/consoleFull) for PR 5093 at commit

[GitHub] spark pull request: [SPARK-4123][Project Infra][WIP]: Show new dep...

2015-03-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5093#issuecomment-85131060 [Test build #29014 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29014/consoleFull) for PR 5093 at commit

[GitHub] spark pull request: [SPARK-6322][SQL] CTAS should consider the cas...

2015-03-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5014#issuecomment-85131959 [Test build #28999 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28999/consoleFull) for PR 5014 at commit

[GitHub] spark pull request: [WIP][SPARK-3468] WebUI Timeline-View feature

2015-03-23 Thread kayousterhout
Github user kayousterhout commented on the pull request: https://github.com/apache/spark/pull/2342#issuecomment-85132747 @sarutak it sounds like the plan is to significantly change the implementation; if that's the case, then yes, closing this PR and opening a new one when the new

[GitHub] spark pull request: [SPARK-4086][GraphX]: Fold-style aggregation f...

2015-03-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5142#issuecomment-85135520 [Test build #29016 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29016/consoleFull) for PR 5142 at commit

[GitHub] spark pull request: [SPARK-5342][YARN] Allow long running Spark ap...

2015-03-23 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/4688#discussion_r26965565 --- Diff: launcher/src/main/java/org/apache/spark/launcher/SparkSubmitOptionParser.java --- @@ -57,6 +57,8 @@ protected final String REPOSITORIES =

[GitHub] spark pull request: [SPARK-4086][GraphX]: Fold-style aggregation f...

2015-03-23 Thread brennonyork
GitHub user brennonyork opened a pull request: https://github.com/apache/spark/pull/5142 [SPARK-4086][GraphX]: Fold-style aggregation for VertexRDD Adds five new methods into the `VertexRDD` suite to allow for fold-style calling conventions. Those methods are: *

[GitHub] spark pull request: [SPARK-6369] [SQL] [WIP] Uses commit coordinat...

2015-03-23 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/5139#issuecomment-85141856 @aarondav if you have time, I'd appreciate your input here. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: SPARK-6414: Spark driver failed with NPE on jo...

2015-03-23 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/5124#issuecomment-85132588 It looks like this NPE bug has been around for a while, but it seems pretty hard to hit (which is probably why it hasn't been reported before). I think that we should

[GitHub] spark pull request: [SPARK-6428] Added explicit types for all publ...

2015-03-23 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/5125#discussion_r26966209 --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala --- @@ -986,7 +986,7 @@ class SparkContext(config: SparkConf) extends Logging with

[GitHub] spark pull request: [SPARK-5342][YARN] Allow long running Spark ap...

2015-03-23 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/4688#issuecomment-85142115 Looks OK to me. The code in `Client.scala` is getting pretty hard to follow, would probably benefit from some cleanup later on... --- If your project is set up for it,

[GitHub] spark pull request: [Spark-4848] Stand-alone cluster: Allow differ...

2015-03-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5140#issuecomment-85147160 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-5775] BugFix: GenericRow cannot be cast...

2015-03-23 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/4697#issuecomment-85147251 Thanks! Merged to branch-1.2 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [Spark-4848] Stand-alone cluster: Allow differ...

2015-03-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5140#issuecomment-85147094 [Test build #29005 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29005/consoleFull) for PR 5140 at commit

[GitHub] spark pull request: [SPARK-5124][Core] A standard RPC interface an...

2015-03-23 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/4588#discussion_r26960403 --- Diff: core/src/test/scala/org/apache/spark/rpc/RpcEnvSuite.scala --- @@ -0,0 +1,526 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] spark pull request: [SPARK-6471][SQL]: Metastore schema should onl...

2015-03-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5141#issuecomment-85122746 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-5559] [Streaming] [Test] Remove oppotun...

2015-03-23 Thread sarutak
Github user sarutak commented on the pull request: https://github.com/apache/spark/pull/4337#issuecomment-85122775 Sorry, I had no time until last weekend but now I have. I'll address that soon. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [SPARK-4123][Project Infra][WIP]: Show new dep...

2015-03-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5093#issuecomment-85123943 [Test build #29008 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29008/consoleFull) for PR 5093 at commit

[GitHub] spark pull request: [SPARK-4123][Project Infra][WIP]: Show new dep...

2015-03-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5093#issuecomment-85123947 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4123][Project Infra][WIP]: Show new dep...

2015-03-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5093#issuecomment-85123940 [Test build #29008 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29008/consoleFull) for PR 5093 at commit

[GitHub] spark pull request: [SPARK-3454] [WIP] separate json endpoints for...

2015-03-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4435#issuecomment-85124453 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-3454] [WIP] separate json endpoints for...

2015-03-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4435#issuecomment-85124440 [Test build #29003 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29003/consoleFull) for PR 4435 at commit

[GitHub] spark pull request: [SPARK-6463] [SQL]AttributeSet.equal should co...

2015-03-23 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/5133#issuecomment-85126028 Jenkins, test this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-5559] [Streaming] [Test] Remove oppotun...

2015-03-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4337#issuecomment-85134053 [Test build #29015 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29015/consoleFull) for PR 4337 at commit

[GitHub] spark pull request: [SPARK-5342][YARN] Allow long running Spark ap...

2015-03-23 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/4688#discussion_r26965498 --- Diff: launcher/src/main/java/org/apache/spark/launcher/SparkSubmitOptionParser.java --- @@ -108,6 +110,8 @@ { REPOSITORIES }, { STATUS

[GitHub] spark pull request: [SPARK-6428] Added explicit types for all publ...

2015-03-23 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/5125#discussion_r26966555 --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala --- @@ -986,7 +986,7 @@ class SparkContext(config: SparkConf) extends Logging with

[GitHub] spark pull request: [SPARK-3454] [WIP] separate json endpoints for...

2015-03-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4435#issuecomment-85141005 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-3533][Core][PySpark] Add saveAsTextFile...

2015-03-23 Thread nchammas
Github user nchammas commented on the pull request: https://github.com/apache/spark/pull/4895#issuecomment-85119879 @srowen [SPARK-3533](https://issues.apache.org/jira/browse/SPARK-3533) has a lot of votes and watchers, and there are a few linked questions on Stack Overflow from

[GitHub] spark pull request: [SPARK-5124][Core] A standard RPC interface an...

2015-03-23 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/4588#discussion_r26960291 --- Diff: core/src/test/scala/org/apache/spark/rpc/RpcEnvSuite.scala --- @@ -0,0 +1,526 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] spark pull request: [SPARK-5124][Core] A standard RPC interface an...

2015-03-23 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/4588#issuecomment-8519 Left mostly minor comments, otherwise looks good. We can iron out any kinks later. There's just some odd code in the test suite, where you're calling `stop` in a

[GitHub] spark pull request: [SPARK-6124] Support jdbc connection propertie...

2015-03-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4859#issuecomment-85129177 [Test build #29012 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29012/consoleFull) for PR 4859 at commit

[GitHub] spark pull request: [SPARK-6124] Support jdbc connection propertie...

2015-03-23 Thread aarondav
Github user aarondav commented on the pull request: https://github.com/apache/spark/pull/4859#issuecomment-85131353 This LGTM, we'll merge this and later add a jdbc() version. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [WIP][SPARK-3468] WebUI Timeline-View feature

2015-03-23 Thread sarutak
Github user sarutak commented on the pull request: https://github.com/apache/spark/pull/2342#issuecomment-85131296 I apologize for my late reply. I had no time until last weekend. Actually, I'm reconsidering what and how should be visualized and trying implementing. I could

[GitHub] spark pull request: [SPARK-6322][SQL] CTAS should consider the cas...

2015-03-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5014#issuecomment-85131979 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-6345][STREAMING][MLLIB] Fix for trainin...

2015-03-23 Thread tdas
Github user tdas commented on the pull request: https://github.com/apache/spark/pull/5037#issuecomment-85133430 BTW, I really think we should merge this soon for 1.3.1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-4123][Project Infra][WIP]: Show new dep...

2015-03-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5093#issuecomment-85135353 [Test build #29017 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29017/consoleFull) for PR 5093 at commit

[GitHub] spark pull request: [SPARK-4123][Project Infra][WIP]: Show new dep...

2015-03-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5093#issuecomment-85135359 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4123][Project Infra][WIP]: Show new dep...

2015-03-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5093#issuecomment-85135350 [Test build #29017 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29017/consoleFull) for PR 5093 at commit

[GitHub] spark pull request: [SPARK-6322][SQL] CTAS should consider the cas...

2015-03-23 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/5014#discussion_r26965253 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicOperators.scala --- @@ -142,7 +142,7 @@ case class

[GitHub] spark pull request: [SPARK-4086][GraphX]: Fold-style aggregation f...

2015-03-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5142#issuecomment-85135767 [Test build #29016 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29016/consoleFull) for PR 5142 at commit

[GitHub] spark pull request: [SPARK-4086][GraphX]: Fold-style aggregation f...

2015-03-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5142#issuecomment-85135778 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-6308] [MLlib] [Sql] Override TypeName i...

2015-03-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5118#issuecomment-85136374 [Test build #29001 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29001/consoleFull) for PR 5118 at commit

[GitHub] spark pull request: [SPARK-6308] [MLlib] [Sql] Override TypeName i...

2015-03-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5118#issuecomment-85136390 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-5342][YARN] Allow long running Spark ap...

2015-03-23 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/4688#discussion_r26966346 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala --- @@ -540,6 +560,27 @@ private[spark] class Client( amContainer }

[GitHub] spark pull request: [WIP][SPARK-3468] WebUI Timeline-View feature

2015-03-23 Thread sarutak
Github user sarutak commented on the pull request: https://github.com/apache/spark/pull/2342#issuecomment-85139282 @kayousterhout The basic idea is not changed but I try to use vis.js instead of D3.js because vis.js is easy to build rich timeline view. This is under

[GitHub] spark pull request: [SPARK-6428] Added explicit types for all publ...

2015-03-23 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/5125#discussion_r26966597 --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala --- @@ -986,7 +986,7 @@ class SparkContext(config: SparkConf) extends Logging with

[GitHub] spark pull request: [SPARK-3454] [WIP] separate json endpoints for...

2015-03-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4435#issuecomment-85140966 [Test build #29011 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29011/consoleFull) for PR 4435 at commit

[GitHub] spark pull request: [SPARK-6428] Added explicit types for all publ...

2015-03-23 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/5125#discussion_r26967311 --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala --- @@ -986,7 +986,7 @@ class SparkContext(config: SparkConf) extends Logging with

[GitHub] spark pull request: [SPARK-5095][MESOS] Support capping cores and ...

2015-03-23 Thread tnachen
Github user tnachen commented on a diff in the pull request: https://github.com/apache/spark/pull/4027#discussion_r26987588 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/CoarseMesosSchedulerBackend.scala --- @@ -63,20 +63,25 @@ private[spark] class

[GitHub] spark pull request: [SPARK-2691][Mesos] Support for Mesos DockerIn...

2015-03-23 Thread tnachen
Github user tnachen commented on the pull request: https://github.com/apache/spark/pull/3074#issuecomment-85232216 @hellertime how about just add the Apache license on the top of the Dockerfile? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [SPARK-6122][Core] Upgrade Tachyon client vers...

2015-03-23 Thread calvinjia
Github user calvinjia commented on the pull request: https://github.com/apache/spark/pull/4867#issuecomment-85234685 @JoshRosen Just from a quick glance at the output log, it seems to be a style issue (line 100 characters). I don't think this patch should have caused the issues,

[GitHub] spark pull request: [SPARK-5750][SPARK-3441][SPARK-5836][CORE] Add...

2015-03-23 Thread sryza
Github user sryza commented on a diff in the pull request: https://github.com/apache/spark/pull/5074#discussion_r26988014 --- Diff: docs/programming-guide.md --- @@ -1086,6 +1086,62 @@ for details. /tr /table +### Shuffle operations + +Certain operations

[GitHub] spark pull request: [SPARK-2691][Mesos] Support for Mesos DockerIn...

2015-03-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3074#issuecomment-85256109 [Test build #29037 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29037/consoleFull) for PR 3074 at commit

[GitHub] spark pull request: [SPARK-2691][Mesos] Support for Mesos DockerIn...

2015-03-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3074#issuecomment-85256117 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-6325] [core,yarn] Do not change target ...

2015-03-23 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/5018#issuecomment-85262710 @vanzin @sryza Thanks for working on the fix. I was away for the past week and did not have the chance to review this before it went in. Regarding the code being

[GitHub] spark pull request: [SPARK-6209] Clean up connections in ExecutorC...

2015-03-23 Thread mccheah
Github user mccheah commented on the pull request: https://github.com/apache/spark/pull/4944#issuecomment-85264973 Yeah it looks okay to me but I also would feel more comfortable if a second core committer took a look. --- If your project is set up for it, you can reply to this

[GitHub] spark pull request: [SPARK-6428] Added explicit types for all publ...

2015-03-23 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/5125#discussion_r26995821 --- Diff: core/src/main/scala/org/apache/spark/deploy/worker/DriverRunner.scala --- @@ -169,8 +177,8 @@ private[deploy] class DriverRunner(

[GitHub] spark pull request: [SPARK-6477][Build]: Run MIMA tests before the...

2015-03-23 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/5145#issuecomment-85267784 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-6478] New RDD.pipeWithPartition method

2015-03-23 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/5147#issuecomment-85275593 I'm a little hesitant to want to add a new `withPartition` or `withSplit`-like method, since we've been deprecating those in favor of using things like TaskContext.

[GitHub] spark pull request: [SPARK-5253] [ML] LinearRegression with L1/L2 ...

2015-03-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4259#issuecomment-85275422 [Test build #29042 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29042/consoleFull) for PR 4259 at commit

[GitHub] spark pull request: [SPARK-5750][SPARK-3441][SPARK-5836][CORE] Add...

2015-03-23 Thread sryza
Github user sryza commented on a diff in the pull request: https://github.com/apache/spark/pull/5074#discussion_r26987728 --- Diff: docs/programming-guide.md --- @@ -1086,6 +1086,62 @@ for details. /tr /table +### Shuffle operations + +Certain operations

[GitHub] spark pull request: [SPARK-2691][Mesos] Support for Mesos DockerIn...

2015-03-23 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/3074#issuecomment-85235696 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: New RDD.pipeWithPartition method

2015-03-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5147#issuecomment-85235660 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-2691][Mesos] Support for Mesos DockerIn...

2015-03-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3074#issuecomment-85235864 [Test build #29036 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29036/consoleFull) for PR 3074 at commit

[GitHub] spark pull request: [SPARK-6122][Core] Upgrade Tachyon client vers...

2015-03-23 Thread calvinjia
Github user calvinjia commented on the pull request: https://github.com/apache/spark/pull/4867#issuecomment-85237240 @srowen Oh I see the build still failed after the fix to that patch. Strange that there would be issues between now and the last test run for this patch since there

[GitHub] spark pull request: [SPARK-5338][MESOS] Add cluster mode support f...

2015-03-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5144#issuecomment-85243242 [Test build #29038 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29038/consoleFull) for PR 5144 at commit

[GitHub] spark pull request: [SPARK-6406] Launcher backward compatibility i...

2015-03-23 Thread nishkamravi2
Github user nishkamravi2 commented on the pull request: https://github.com/apache/spark/pull/5085#issuecomment-85244894 Thanks for the comments @vanzin. Will address them soon. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-4086][GraphX]: Fold-style aggregation f...

2015-03-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5142#issuecomment-85247503 [Test build #29033 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29033/consoleFull) for PR 5142 at commit

[GitHub] spark pull request: [SPARK-4086][GraphX]: Fold-style aggregation f...

2015-03-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5142#issuecomment-85247520 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-6322][SQL] CTAS should consider the cas...

2015-03-23 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/5014#discussion_r26994637 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicOperators.scala --- @@ -142,7 +142,7 @@ case class

[GitHub] spark pull request: [SPARK-4123][Project Infra][WIP]: Show new dep...

2015-03-23 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/5093#discussion_r26996263 --- Diff: dev/tests/pr_new_dependencies.sh --- @@ -0,0 +1,85 @@ +#!/usr/bin/env bash + +# +# Licensed to the Apache Software Foundation (ASF)

[GitHub] spark pull request: [SPARK-5253] [ML] LinearRegression with L1/L2 ...

2015-03-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4259#issuecomment-85275731 [Test build #29042 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29042/consoleFull) for PR 4259 at commit

[GitHub] spark pull request: [SPARK-5253] [ML] LinearRegression with L1/L2 ...

2015-03-23 Thread dbtsai
Github user dbtsai commented on the pull request: https://github.com/apache/spark/pull/4259#issuecomment-85275887 @jkbradley and @mengxr I just rebased it. Will do couple optimizations to avoid the scaling on the datasets which can be done in the optimization instead. You guys can

[GitHub] spark pull request: [SPARK-5253] [ML] LinearRegression with L1/L2 ...

2015-03-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4259#issuecomment-85275736 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-5253] [ML] LinearRegression with L1/L2 ...

2015-03-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4259#issuecomment-85278373 [Test build #29043 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29043/consoleFull) for PR 4259 at commit

[GitHub] spark pull request: [SPARK-5095][MESOS] Support capping cores and ...

2015-03-23 Thread tnachen
Github user tnachen commented on a diff in the pull request: https://github.com/apache/spark/pull/4027#discussion_r26988123 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/CoarseMesosSchedulerBackend.scala --- @@ -204,35 +209,43 @@ private[spark] class

[GitHub] spark pull request: [SPARK-5095][MESOS] Support capping cores and ...

2015-03-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4027#issuecomment-85239748 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-5095][MESOS] Support capping cores and ...

2015-03-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4027#issuecomment-85239717 [Test build #29034 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29034/consoleFull) for PR 4027 at commit

[GitHub] spark pull request: SPARK-6480 [CORE] histogram() bucket function ...

2015-03-23 Thread srowen
GitHub user srowen opened a pull request: https://github.com/apache/spark/pull/5148 SPARK-6480 [CORE] histogram() bucket function is wrong in some simple edge cases Fix fastBucketFunction for histogram() to handle edge conditions more correctly. Add a test, and fix existing one

[GitHub] spark pull request: [SPARK-5961][Streaming]Allow specific nodes in...

2015-03-23 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/5114#discussion_r26993189 --- Diff: external/flume/src/main/scala/org/apache/spark/streaming/flume/FlumeInputDStream.scala --- @@ -44,12 +44,14 @@ import

[GitHub] spark pull request: [SPARK-2691][Mesos] Support for Mesos DockerIn...

2015-03-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3074#issuecomment-85254916 [Test build #29036 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29036/consoleFull) for PR 3074 at commit

[GitHub] spark pull request: [SPARK-6420] Driver's Block Manager does not u...

2015-03-23 Thread marsishandsome
Github user marsishandsome commented on the pull request: https://github.com/apache/spark/pull/5095#issuecomment-85257353 @tgravescs You are right. Maybe we should provide two choices: Ip and Hostname. Both will be automatically figured out by Spark. --- If your project is set up

[GitHub] spark pull request: [SPARK-6428] Added explicit types for all publ...

2015-03-23 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/5125#discussion_r26995786 --- Diff: core/src/main/scala/org/apache/spark/deploy/worker/DriverRunner.scala --- @@ -33,6 +33,8 @@ import org.apache.spark.deploy.master.DriverState

[GitHub] spark pull request: [SPARK-6428] Added explicit types for all publ...

2015-03-23 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/5125#discussion_r26996110 --- Diff: core/src/main/scala/org/apache/spark/rdd/JdbcRDD.scala --- @@ -70,7 +71,8 @@ class JdbcRDD[T: ClassTag]( }).toArray } -

[GitHub] spark pull request: [SPARK-6322][SQL] CTAS should consider the cas...

2015-03-23 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/5014#discussion_r26997137 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicOperators.scala --- @@ -142,7 +142,7 @@ case class

<    1   2   3   4   5   6   >