Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15599
**[Test build #67381 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67381/consoleFull)**
for PR 15599 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15599
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67381/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15513
**[Test build #67383 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67383/consoleFull)**
for PR 15513 at commit
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15580#discussion_r84577126
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetOptions.scala
---
@@ -35,7 +35,7 @@ private[parquet] class
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14529
**[Test build #67390 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67390/consoleFull)**
for PR 14529 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/15595
@CodingCat I think we need a test maybe (at least the one specified in the
JIRA) to confirm this PR fixes that problem and avoid the regression in the
future.
---
If your project is set up
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15354
**[Test build #67387 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67387/consoleFull)**
for PR 15354 at commit
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r84573731
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala
---
@@ -286,7 +324,12 @@ case class Divide(left:
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r84573927
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
---
@@ -159,28 +167,69 @@ case class Pi() extends
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r84573878
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -847,7 +1010,16 @@ case class
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r84574029
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
---
@@ -603,8 +823,16 @@ case class Unhex(child:
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r84574107
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
---
@@ -518,7 +563,12 @@ case class GreaterThan(left:
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r84573696
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala
---
@@ -25,7 +25,11 @@ import org.apache.spark.sql.types._
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r84574135
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -986,7 +1155,14 @@ case class
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r84574143
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -1100,7 +1304,14 @@ case class
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r84573971
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
---
@@ -384,71 +502,157 @@ case class Log2(child:
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r84574050
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala
---
@@ -159,8 +183,15 @@ case class Sha1(child: Expression)
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r84573906
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
---
@@ -149,7 +153,11 @@ case class EulerNumber()
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r84573897
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
---
@@ -140,7 +140,11 @@ abstract class
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r84573728
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala
---
@@ -209,8 +239,16 @@ case class Multiply(left:
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r84574009
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
---
@@ -384,71 +502,157 @@ case class Log2(child:
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r84573769
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala
---
@@ -367,8 +410,16 @@ case class Remainder(left:
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r84574033
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
---
@@ -666,8 +910,16 @@ case class ShiftLeft(left:
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r84573688
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala
---
@@ -62,7 +66,11 @@ case class UnaryMinus(child:
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r84574087
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
---
@@ -435,8 +458,15 @@ case class EqualTo(left:
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/15072
@liancheng @hvanhovell @davies @cloud-fan Would there be other things maybe
I should take care of ?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/15049
gentle ping @davies @liancheng @yhuai
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/14788
@rxin @hvanhovell @cloud-fan Could I please ask the behaviour we want here?
1. Separate expressions for both `DateType` and `TimestampType`
2. Returns `DateType` for `DateType` and
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/15580
@rxin BTW, could I please ask to include
https://github.com/apache/spark/pull/14529 in your future related PRs? I will
close if you will.
---
If your project is set up for it, you can reply
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/15599
If we do not have a test case, could you post the exception before the fix
and the exception output after the fix? Thanks!
---
If your project is set up for it, you can reply to this email and
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15596#discussion_r84579127
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/limit.scala ---
@@ -36,14 +36,14 @@ import org.apache.spark.util.Utils
case class
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15072#discussion_r84579406
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -2725,4 +2725,14 @@ class Dataset[T] private[sql](
@inline private def
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15072
LGTM - pending jenkins
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r84574950
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -706,7 +842,16 @@ case class
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/14627
@liancheng If you are uncertain of `OrcFileOperator.scala` I will
definitely remove this in this PR.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15587
**[Test build #67388 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67388/consoleFull)**
for PR 15587 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/15566
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/15566
I have changed it to `This PR makes partition spec case preserving at
parser`, sorry for the confusion.
Previously we were lazy and alway lower case the column names in partition
spec.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15513
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67385/
Test PASSed.
---
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15072
@HyukjinKwon can we move this into a set specific method within Dataset
itself, for example:
```scala
/** A convenient function to wrap a set based logical plan and produce a
Dataset. */
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15513
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user maver1ck commented on the issue:
https://github.com/apache/spark/pull/15599
I can try this fix on Monday.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14529
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14529
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67390/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15354
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15354
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67387/
Test PASSed.
---
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/15513
@srowen Oh, I didn't notice the review was being proceeded but just pushed
another commit. Will try to address the comments as well.
---
If your project is set up for it, you can reply to this
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15513
**[Test build #67382 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67382/consoleFull)**
for PR 15513 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15513
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15513
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67382/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15513
**[Test build #67384 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67384/consoleFull)**
for PR 15513 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/15354
@felixcheung Thank you for pinging!
@marmbrus Do you please mind if I handle checking the schema ahead for
csv/json in read/write in another PR?
---
If your project is set up for it,
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15354
**[Test build #67387 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67387/consoleFull)**
for PR 15354 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/15361
@chenghao-intel @davies Would there be other things maybe I should test or
take care of?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/15072
@hvanhovell Oh, that looks cleaner and nicer. I will try.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15595
+1 on adding a test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15072
**[Test build #67392 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67392/consoleFull)**
for PR 15072 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14529
**[Test build #67390 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67390/consoleFull)**
for PR 14529 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15072
**[Test build #67393 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67393/consoleFull)**
for PR 15072 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15072
**[Test build #67392 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67392/consoleFull)**
for PR 15072 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15072
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67392/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15072
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user erenavsarogullari commented on the issue:
https://github.com/apache/spark/pull/15463
Thanks all for the support. Jenkins looks failed due to timeout.
Jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15599
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15513
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/15539
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user naliazheli commented on the issue:
https://github.com/apache/spark/pull/15517
dataset.checkpoint is what i need.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/13771
gentle ping @davies
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15513
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15513
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67384/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15513
**[Test build #67384 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67384/consoleFull)**
for PR 15513 at commit
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15590
This is pretty cool.
I was wondering how much code this shares with the regular hash based
aggregation path? And if it is worth the effort to integrate the two paths? We
can do this in
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15428
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67386/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15428
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15428
**[Test build #67386 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67386/consoleFull)**
for PR 15428 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13988
**[Test build #67391 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67391/consoleFull)**
for PR 13988 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15513
**[Test build #67382 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67382/consoleFull)**
for PR 15513 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/14660
Could you please take a look please @rxin and @liancheng?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15566
**[Test build #67389 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67389/consoleFull)**
for PR 15566 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15566
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15566
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67389/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15587
**[Test build #67388 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67388/consoleFull)**
for PR 15587 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15587
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15587
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67388/
Test PASSed.
---
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r84574163
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/xml/xpath.scala
---
@@ -150,8 +220,18 @@ case class XPathString(xml:
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r84573933
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
---
@@ -159,28 +167,69 @@ case class Pi() extends
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r84573871
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -706,7 +842,16 @@ case class TimeAdd(start:
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r84574104
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
---
@@ -490,7 +525,12 @@ case class LessThan(left:
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r84573952
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
---
@@ -361,13 +465,27 @@ case class Factorial(child:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15428
**[Test build #67386 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67386/consoleFull)**
for PR 15428 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15513
**[Test build #67383 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67383/consoleFull)**
for PR 15513 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15513
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67383/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13988
**[Test build #67391 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67391/consoleFull)**
for PR 13988 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/15591
@AbhiMadav I think we need a test to confirm this PR fixes that problem and
avoid the regression in the future.
---
If your project is set up for it, you can reply to this email and have your
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15513
**[Test build #67385 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67385/consoleFull)**
for PR 15513 at commit
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15591#discussion_r84578800
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -615,11 +616,8 @@ class
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/15398
@jodersky Sorry. I misunderstood your point in the offline discussion.
After reading the codes, I think your original proposal is right. This PR needs
to clean up the test suite `LIKE literal
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15072#discussion_r84580480
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -2725,4 +2725,14 @@ class Dataset[T] private[sql](
@inline private def
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r84576139
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala
---
@@ -367,8 +410,16 @@ case class Remainder(left:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15513
**[Test build #67385 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67385/consoleFull)**
for PR 15513 at commit
1 - 100 of 294 matches
Mail list logo
