[GitHub] spark pull request #21405: [SPARK-24361][SQL] Polish code block manipulation...

2018-07-05 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/21405#discussion_r200249108 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala --- @@ -118,10 +119,10 @@ object JavaCode { /**

[GitHub] spark pull request #21405: [SPARK-24361][SQL] Polish code block manipulation...

2018-07-05 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/21405#discussion_r200249000 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeBlockSuite.scala --- @@ -133,4 +133,55 @@ class CodeBlockSuite

[GitHub] spark pull request #21700: [SPARK-24717][SS] Split out max retain version of...

2018-07-05 Thread tedyu
Github user tedyu commented on a diff in the pull request: https://github.com/apache/spark/pull/21700#discussion_r200248889 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/HDFSBackedStateStoreProvider.scala --- @@ -240,7 +244,11 @@ private[state]

[GitHub] spark issue #21552: [SPARK-24544][SQL] Print actual failure cause when look ...

2018-07-05 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/21552 Why Spark doesn't fail when create this function? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark pull request #21677: [SPARK-24692][TESTS] Improvement FilterPushdownBe...

2018-07-05 Thread wangyum
Github user wangyum commented on a diff in the pull request: https://github.com/apache/spark/pull/21677#discussion_r200246934 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/FilterPushdownBenchmark.scala --- @@ -427,16 +245,122 @@ object

[GitHub] spark pull request #21700: [SPARK-24717][SS] Split out max retain version of...

2018-07-05 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/spark/pull/21700#discussion_r200249261 --- Diff: sql/core/src/main/java/org/apache/spark/sql/streaming/state/BoundedSortedMap.java --- @@ -0,0 +1,79 @@ +/* + * Licensed to the

[GitHub] spark issue #21405: [SPARK-24361][SQL] Polish code block manipulation API

2018-07-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21405 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21405: [SPARK-24361][SQL] Polish code block manipulation API

2018-07-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21405 **[Test build #92637 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92637/testReport)** for PR 21405 at commit

[GitHub] spark issue #21405: [SPARK-24361][SQL] Polish code block manipulation API

2018-07-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21405 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/697/

[GitHub] spark pull request #21677: [SPARK-24692][TESTS] Improvement FilterPushdownBe...

2018-07-05 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/21677#discussion_r200244218 --- Diff: sql/core/benchmarks/FilterPushdownBenchmark-results.txt --- @@ -0,0 +1,556 @@ +[ Pushdown for many distinct

[GitHub] spark pull request #21405: [SPARK-24361][SQL] Polish code block manipulation...

2018-07-05 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/21405#discussion_r200244308 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala --- @@ -291,5 +328,8 @@ class LiteralValue(val

[GitHub] spark pull request #21405: [SPARK-24361][SQL] Polish code block manipulation...

2018-07-05 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/21405#discussion_r200244488 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala --- @@ -118,10 +119,10 @@ object JavaCode {

[GitHub] spark issue #20345: [SPARK-23172][SQL] Expand the ReorderJoin rule to handle...

2018-07-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20345 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92632/ Test PASSed. ---

[GitHub] spark pull request #21405: [SPARK-24361][SQL] Polish code block manipulation...

2018-07-05 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/21405#discussion_r200247248 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeBlockSuite.scala --- @@ -133,4 +133,55 @@ class

[GitHub] spark pull request #21405: [SPARK-24361][SQL] Polish code block manipulation...

2018-07-05 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/21405#discussion_r200247398 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeBlockSuite.scala --- @@ -133,4 +133,55 @@ class

[GitHub] spark issue #21677: [SPARK-24692][TESTS] Improvement FilterPushdownBenchmark

2018-07-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21677 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21677: [SPARK-24692][TESTS] Improvement FilterPushdownBenchmark

2018-07-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21677 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92633/ Test PASSed. ---

[GitHub] spark pull request #21700: [SPARK-24717][SS] Split out max retain version of...

2018-07-05 Thread tedyu
Github user tedyu commented on a diff in the pull request: https://github.com/apache/spark/pull/21700#discussion_r200242174 --- Diff: sql/core/src/main/java/org/apache/spark/sql/streaming/state/BoundedSortedMap.java --- @@ -0,0 +1,79 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #21677: [SPARK-24692][TESTS] Improvement FilterPushdownBe...

2018-07-05 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/21677#discussion_r200245212 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/FilterPushdownBenchmark.scala --- @@ -427,16 +245,122 @@ object

[GitHub] spark issue #21552: [SPARK-24544][SQL] Print actual failure cause when look ...

2018-07-05 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/21552 ah, I see. It seems we should do that. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #21405: [SPARK-24361][SQL] Polish code block manipulation...

2018-07-05 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/21405#discussion_r200245418 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeBlockSuite.scala --- @@ -133,4 +133,55 @@ class

[GitHub] spark issue #20345: [SPARK-23172][SQL] Expand the ReorderJoin rule to handle...

2018-07-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20345 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20345: [SPARK-23172][SQL] Expand the ReorderJoin rule to handle...

2018-07-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20345 **[Test build #92632 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92632/testReport)** for PR 20345 at commit

[GitHub] spark issue #21677: [SPARK-24692][TESTS] Improvement FilterPushdownBenchmark

2018-07-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21677 **[Test build #92633 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92633/testReport)** for PR 21677 at commit

[GitHub] spark issue #21713: [SPARK-24737][SQL] Type coercion between StructTypes.

2018-07-05 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/21713 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #21677: [SPARK-24692][TESTS] Improvement FilterPushdownBe...

2018-07-05 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/21677#discussion_r200244688 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/FilterPushdownBenchmark.scala --- @@ -44,8 +49,33 @@ object

[GitHub] spark pull request #21700: [SPARK-24717][SS] Split out max retain version of...

2018-07-05 Thread tedyu
Github user tedyu commented on a diff in the pull request: https://github.com/apache/spark/pull/21700#discussion_r200242876 --- Diff: sql/core/src/main/java/org/apache/spark/sql/streaming/state/BoundedSortedMap.java --- @@ -0,0 +1,79 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #21556: [SPARK-24549][SQL] Support Decimal type push down...

2018-07-05 Thread wangyum
Github user wangyum commented on a diff in the pull request: https://github.com/apache/spark/pull/21556#discussion_r200246162 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilters.scala --- @@ -82,6 +120,30 @@ private[parquet] class

[GitHub] spark pull request #21667: [SPARK-24691][SQL]Dispatch the type support check...

2018-07-05 Thread gengliangwang
Github user gengliangwang commented on a diff in the pull request: https://github.com/apache/spark/pull/21667#discussion_r200256945 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/DataSourceScanExec.scala --- @@ -306,6 +306,7 @@ case class FileSourceScanExec(

[GitHub] spark issue #21405: [SPARK-24361][SQL] Polish code block manipulation API

2018-07-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21405 **[Test build #92640 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92640/testReport)** for PR 21405 at commit

[GitHub] spark issue #21717: [SPARK-24743] [Examples]Update the JavaDirectKafkaWordCo...

2018-07-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21717 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21717: [SPARK-24743] [Examples]Update the JavaDirectKafkaWordCo...

2018-07-05 Thread cluo512
Github user cluo512 commented on the issue: https://github.com/apache/spark/pull/21717 @srowen --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21717: [SPARK-24743] [Examples]Update the JavaDirectKafkaWordCo...

2018-07-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21717 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21718: [SPARK-24744][STRUCTRURED STREAMING] Set the SparkSessio...

2018-07-05 Thread bethunebtj
Github user bethunebtj commented on the issue: https://github.com/apache/spark/pull/21718 Follow. I meet this problem too. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21584: [SPARK-24433][K8S][WIP] Initial R Bindings for SparkR on...

2018-07-05 Thread ifilonenko
Github user ifilonenko commented on the issue: https://github.com/apache/spark/pull/21584 @felixcheung @mccheah by that logic.. should then both Python and R images be version configurable? This is all handled in the `bin/docker-image-tool.sh` ? Aren't those configurations just way

[GitHub] spark pull request #21658: [SPARK-24678][Spark-Streaming] Give priority in u...

2018-07-05 Thread sharkdtu
Github user sharkdtu commented on a diff in the pull request: https://github.com/apache/spark/pull/21658#discussion_r200310184 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala --- @@ -1569,7 +1569,7 @@ private[spark] object BlockManager {

[GitHub] spark issue #21713: [SPARK-24737][SQL] Type coercion between StructTypes.

2018-07-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21713 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21713: [SPARK-24737][SQL] Type coercion between StructTypes.

2018-07-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21713 **[Test build #92643 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92643/testReport)** for PR 21713 at commit

[GitHub] spark issue #21713: [SPARK-24737][SQL] Type coercion between StructTypes.

2018-07-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21713 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/704/

[GitHub] spark pull request #21700: [SPARK-24717][SS] Split out max retain version of...

2018-07-05 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/spark/pull/21700#discussion_r200249732 --- Diff: sql/core/src/main/java/org/apache/spark/sql/streaming/state/BoundedSortedMap.java --- @@ -0,0 +1,79 @@ +/* + * Licensed to the

[GitHub] spark pull request #21677: [SPARK-24692][TESTS] Improvement FilterPushdownBe...

2018-07-05 Thread wangyum
Github user wangyum commented on a diff in the pull request: https://github.com/apache/spark/pull/21677#discussion_r200262948 --- Diff: sql/core/benchmarks/FilterPushdownBenchmark-results.txt --- @@ -0,0 +1,556 @@ +[ Pushdown for many distinct value

[GitHub] spark pull request #21717: [SPARK-24743] [Examples]Update the JavaDirectKafk...

2018-07-05 Thread cluo512
GitHub user cluo512 opened a pull request: https://github.com/apache/spark/pull/21717 [SPARK-24743] [Examples]Update the JavaDirectKafkaWordCount example to support the new API of kafka ## What changes were proposed in this pull request? Add some required configs for Kafka

[GitHub] spark issue #21658: [SPARK-24678][Spark-Streaming] Give priority in use of '...

2018-07-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21658 **[Test build #92634 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92634/testReport)** for PR 21658 at commit

[GitHub] spark issue #21405: [SPARK-24361][SQL] Polish code block manipulation API

2018-07-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21405 **[Test build #92637 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92637/testReport)** for PR 21405 at commit

[GitHub] spark issue #21713: [SPARK-24737][SQL] Type coercion between StructTypes.

2018-07-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21713 **[Test build #92636 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92636/testReport)** for PR 21713 at commit

[GitHub] spark issue #21713: [SPARK-24737][SQL] Type coercion between StructTypes.

2018-07-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21713 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/698/

[GitHub] spark issue #21405: [SPARK-24361][SQL] Polish code block manipulation API

2018-07-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21405 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92637/ Test FAILed. ---

[GitHub] spark issue #21713: [SPARK-24737][SQL] Type coercion between StructTypes.

2018-07-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21713 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21713: [SPARK-24737][SQL] Type coercion between StructTypes.

2018-07-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21713 **[Test build #92638 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92638/testReport)** for PR 21713 at commit

[GitHub] spark pull request #21677: [SPARK-24692][TESTS] Improvement FilterPushdownBe...

2018-07-05 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/21677#discussion_r200261091 --- Diff: sql/core/benchmarks/FilterPushdownBenchmark-results.txt --- @@ -0,0 +1,556 @@ +[ Pushdown for many distinct

[GitHub] spark pull request #21677: [SPARK-24692][TESTS] Improvement FilterPushdownBe...

2018-07-05 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/21677#discussion_r200261237 --- Diff: sql/core/benchmarks/FilterPushdownBenchmark-results.txt --- @@ -0,0 +1,556 @@ +[ Pushdown for many distinct

[GitHub] spark pull request #21556: [SPARK-24549][SQL] Support Decimal type push down...

2018-07-05 Thread wangyum
Github user wangyum commented on a diff in the pull request: https://github.com/apache/spark/pull/21556#discussion_r200275960 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilters.scala --- @@ -37,26 +39,50 @@ import

[GitHub] spark issue #21718: [SPARK-24744][STRUCTRURED STREAMING] Set the SparkSessio...

2018-07-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21718 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21693: [SPARK-24673][SQL] scala sql function from_utc_timestamp...

2018-07-05 Thread zzcclp
Github user zzcclp commented on the issue: https://github.com/apache/spark/pull/21693 @HyukjinKwon will this pr be merged into branch-2.3/branch-2.2 too? --- - To unsubscribe, e-mail:

[GitHub] spark pull request #21713: [SPARK-24737][SQL] Type coercion between StructTy...

2018-07-05 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21713#discussion_r200315553 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala --- @@ -166,6 +166,30 @@ object TypeCoercion {

[GitHub] spark pull request #21405: [SPARK-24361][SQL] Polish code block manipulation...

2018-07-05 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/21405#discussion_r200259117 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeBlockSuite.scala --- @@ -133,4 +133,55 @@ class CodeBlockSuite

[GitHub] spark issue #21556: [SPARK-24549][SQL] Support Decimal type push down to the...

2018-07-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21556 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21717: [SPARK-24743] [Examples]Update the JavaDirectKafkaWordCo...

2018-07-05 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21717 I would fill the PR description to explain what changes were proposed in more details. cc @koeninger --- - To unsubscribe,

[GitHub] spark pull request #21718: [SPARK-24744][STRUCTRURED STREAMING] Set the Spar...

2018-07-05 Thread bjkonglu
GitHub user bjkonglu opened a pull request: https://github.com/apache/spark/pull/21718 [SPARK-24744][STRUCTRURED STREAMING] Set the SparkSession configurati… # Background When I use structured streaming to construct my application, there is something odd! The application

[GitHub] spark pull request #21717: [SPARK-24743] [Examples]Update the JavaDirectKafk...

2018-07-05 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/21717#discussion_r200289077 --- Diff: examples/src/main/java/org/apache/spark/examples/streaming/JavaDirectKafkaWordCount.java --- @@ -50,25 +52,30 @@ private static final

[GitHub] spark issue #21717: [SPARK-24743] [Examples]Update the JavaDirectKafkaWordCo...

2018-07-05 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/21717 This seems to be on par with Scala example `DirectKafkaWordCount`. --- - To unsubscribe, e-mail:

[GitHub] spark issue #21713: [SPARK-24737][SQL] Type coercion between StructTypes.

2018-07-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21713 **[Test build #92638 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92638/testReport)** for PR 21713 at commit

[GitHub] spark pull request #21713: [SPARK-24737][SQL] Type coercion between StructTy...

2018-07-05 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/21713#discussion_r200251401 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala --- @@ -166,6 +166,30 @@ object TypeCoercion {

[GitHub] spark pull request #21530: [spark][pyspark][sql] Correcting code for Documen...

2018-07-05 Thread DaniHoon
Github user DaniHoon closed the pull request at: https://github.com/apache/spark/pull/21530 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21049: [SPARK-23957][SQL] Remove redundant sort operators from ...

2018-07-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21049 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/699/

[GitHub] spark issue #21049: [SPARK-23957][SQL] Remove redundant sort operators from ...

2018-07-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21049 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21405: [SPARK-24361][SQL] Polish code block manipulation API

2018-07-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21405 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21405: [SPARK-24361][SQL] Polish code block manipulation API

2018-07-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21405 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/701/

[GitHub] spark pull request #21677: [SPARK-24692][TESTS] Improvement FilterPushdownBe...

2018-07-05 Thread wangyum
Github user wangyum commented on a diff in the pull request: https://github.com/apache/spark/pull/21677#discussion_r200260115 --- Diff: sql/core/benchmarks/FilterPushdownBenchmark-results.txt --- @@ -0,0 +1,556 @@ +[ Pushdown for many distinct value

[GitHub] spark issue #21693: [SPARK-24673][SQL] scala sql function from_utc_timestamp...

2018-07-05 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21693 Merged to master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #21693: [SPARK-24673][SQL] scala sql function from_utc_ti...

2018-07-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/21693 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #21704: [SPARK-24734][SQL] Fix containsNull of Concat for...

2018-07-05 Thread mn-mikke
Github user mn-mikke commented on a diff in the pull request: https://github.com/apache/spark/pull/21704#discussion_r200265965 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -2007,7 +2007,14 @@ case class

[GitHub] spark pull request #21713: [SPARK-24737][SQL] Type coercion between StructTy...

2018-07-05 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/21713#discussion_r200275396 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala --- @@ -166,6 +166,30 @@ object TypeCoercion {

[GitHub] spark issue #21718: [SPARK-24744][STRUCTRURED STREAMING] Set the SparkSessio...

2018-07-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21718 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21718: [SPARK-24744][STRUCTRURED STREAMING] Set the SparkSessio...

2018-07-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21718 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #21717: [SPARK-24743] [Examples]Update the JavaDirectKafk...

2018-07-05 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/21717#discussion_r200288285 --- Diff: examples/src/main/java/org/apache/spark/examples/streaming/JavaDirectKafkaWordCount.java --- @@ -26,8 +26,10 @@ import scala.Tuple2;

[GitHub] spark pull request #21713: [SPARK-24737][SQL] Type coercion between StructTy...

2018-07-05 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/21713#discussion_r200277231 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala --- @@ -166,6 +166,30 @@ object TypeCoercion {

[GitHub] spark pull request #21713: [SPARK-24737][SQL] Type coercion between StructTy...

2018-07-05 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/21713#discussion_r200281741 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala --- @@ -166,6 +166,30 @@ object TypeCoercion {

[GitHub] spark issue #21718: [SPARK-24744][STRUCTRURED STREAMING] Set the SparkSessio...

2018-07-05 Thread wguangliang
Github user wguangliang commented on the issue: https://github.com/apache/spark/pull/21718 it is neccessary that user can restart the spark app and change the configuration without deleting the checkpoint --- - To

[GitHub] spark pull request #21717: [SPARK-24743] [Examples]Update the JavaDirectKafk...

2018-07-05 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/21717#discussion_r200299285 --- Diff: examples/src/main/java/org/apache/spark/examples/streaming/JavaDirectKafkaWordCount.java --- @@ -50,25 +52,30 @@ private static final

[GitHub] spark pull request #21667: [SPARK-24691][SQL]Dispatch the type support check...

2018-07-05 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/21667#discussion_r200304260 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JsonFileFormat.scala --- @@ -148,6 +144,23 @@ class JsonFileFormat

[GitHub] spark issue #21693: [SPARK-24673][SQL] scala sql function from_utc_timestamp...

2018-07-05 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/21693 Basically, bugs are only backported to the earlier versions. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

[GitHub] spark issue #21667: [SPARK-24691][SQL]Dispatch the type support check in Fil...

2018-07-05 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/21667 My major concern is when to apply this check. Ideally this should happen during analysis. --- - To unsubscribe, e-mail:

[GitHub] spark issue #21712: [SPARK-22384][SQL][followup] Refine partition pruning wh...

2018-07-05 Thread jinxing64
Github user jinxing64 commented on the issue: https://github.com/apache/spark/pull/21712 Thanks for ping me. LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #21667: [SPARK-24691][SQL]Dispatch the type support check...

2018-07-05 Thread gengliangwang
Github user gengliangwang commented on a diff in the pull request: https://github.com/apache/spark/pull/21667#discussion_r200255604 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileFormat.scala --- @@ -152,6 +152,11 @@ trait FileFormat { }

[GitHub] spark issue #21667: [SPARK-24691][SQL]Dispatch the type support check in Fil...

2018-07-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21667 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/700/

[GitHub] spark issue #21667: [SPARK-24691][SQL]Dispatch the type support check in Fil...

2018-07-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21667 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21667: [SPARK-24691][SQL]Dispatch the type support check in Fil...

2018-07-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21667 **[Test build #92639 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92639/testReport)** for PR 21667 at commit

[GitHub] spark issue #21405: [SPARK-24361][SQL] Polish code block manipulation API

2018-07-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21405 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21405: [SPARK-24361][SQL] Polish code block manipulation API

2018-07-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21405 **[Test build #92642 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92642/testReport)** for PR 21405 at commit

[GitHub] spark issue #21556: [SPARK-24549][SQL] Support Decimal type push down to the...

2018-07-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21556 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/702/

[GitHub] spark issue #21405: [SPARK-24361][SQL] Polish code block manipulation API

2018-07-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21405 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/703/

[GitHub] spark issue #21556: [SPARK-24549][SQL] Support Decimal type push down to the...

2018-07-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21556 **[Test build #92641 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92641/testReport)** for PR 21556 at commit

[GitHub] spark issue #21713: [SPARK-24737][SQL] Type coercion between StructTypes.

2018-07-05 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/21713 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #21657: [SPARK-24676][SQL] Project required data from CSV...

2018-07-05 Thread MaxGekk
Github user MaxGekk commented on a diff in the pull request: https://github.com/apache/spark/pull/21657#discussion_r200291945 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/UnivocityParser.scala --- @@ -38,24 +38,28 @@ class UnivocityParser(

[GitHub] spark pull request #21717: [SPARK-24743] [Examples]Update the JavaDirectKafk...

2018-07-05 Thread cluo512
Github user cluo512 commented on a diff in the pull request: https://github.com/apache/spark/pull/21717#discussion_r200306144 --- Diff: examples/src/main/java/org/apache/spark/examples/streaming/JavaDirectKafkaWordCount.java --- @@ -50,25 +52,30 @@ private static final

[GitHub] spark issue #21584: [SPARK-24433][K8S][WIP] Initial R Bindings for SparkR on...

2018-07-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21584 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21658: [SPARK-24678][Spark-Streaming] Give priority in use of '...

2018-07-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21658 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21713: [SPARK-24737][SQL] Type coercion between StructTypes.

2018-07-05 Thread ueshin
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/21713 Jenkins, retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21658: [SPARK-24678][Spark-Streaming] Give priority in use of '...

2018-07-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21658 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92634/ Test FAILed. ---

  1   2   3   4   >