[GitHub] [spark] SparkQA commented on pull request #28379: [SPARK-28040][SPARK-28070][R] Write type object s3

2020-04-30 Thread GitBox
SparkQA commented on pull request #28379: URL: https://github.com/apache/spark/pull/28379#issuecomment-621686236 **[Test build #122121 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122121/testReport)** for PR 28379 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28379: [SPARK-28040][SPARK-28070][R] Write type object s3

2020-04-30 Thread GitBox
AmplabJenkins commented on pull request #28379: URL: https://github.com/apache/spark/pull/28379#issuecomment-621686317 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] gatorsmile commented on a change in pull request #28407: [SPARK-31607][SQL] Improve the perf of CTESubstitution

2020-04-30 Thread GitBox
gatorsmile commented on a change in pull request #28407: URL: https://github.com/apache/spark/pull/28407#discussion_r417823026 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CTESubstitution.scala ## @@ -159,17 +146,36 @@ object

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28420: [SPARK-31615][SQL] Pretty string output for sql method of RuntimeRepl…

2020-04-30 Thread GitBox
AmplabJenkins removed a comment on pull request #28420: URL: https://github.com/apache/spark/pull/28420#issuecomment-621675201 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] yaooqinn commented on a change in pull request #28420: [SPARK-31615][SQL] Pretty string output for sql method of RuntimeRepl…

2020-04-30 Thread GitBox
yaooqinn commented on a change in pull request #28420: URL: https://github.com/apache/spark/pull/28420#discussion_r417827135 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala ## @@ -1206,7 +1207,7 @@ case class

[GitHub] [spark] SparkQA commented on pull request #28420: [SPARK-31615][SQL] Pretty string output for sql method of RuntimeRepl…

2020-04-30 Thread GitBox
SparkQA commented on pull request #28420: URL: https://github.com/apache/spark/pull/28420#issuecomment-621678519 **[Test build #122123 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122123/testReport)** for PR 28420 at commit

[GitHub] [spark] cloud-fan commented on a change in pull request #28420: [SPARK-31615][SQL] Pretty string output for sql method of RuntimeRepl…

2020-04-30 Thread GitBox
cloud-fan commented on a change in pull request #28420: URL: https://github.com/apache/spark/pull/28420#discussion_r417825867 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala ## @@ -1206,7 +1207,7 @@ case class

[GitHub] [spark] viirya commented on a change in pull request #28407: [SPARK-31607][SQL] Improve the perf of CTESubstitution

2020-04-30 Thread GitBox
viirya commented on a change in pull request #28407: URL: https://github.com/apache/spark/pull/28407#discussion_r417825103 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CTESubstitution.scala ## @@ -159,17 +146,36 @@ object CTESubstitution

[GitHub] [spark] viirya commented on a change in pull request #28407: [SPARK-31607][SQL] Improve the perf of CTESubstitution

2020-04-30 Thread GitBox
viirya commented on a change in pull request #28407: URL: https://github.com/apache/spark/pull/28407#discussion_r417825103 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CTESubstitution.scala ## @@ -159,17 +146,36 @@ object CTESubstitution

[GitHub] [spark] AmplabJenkins commented on pull request #28420: [SPARK-31615][SQL] Pretty string output for sql method of RuntimeRepl…

2020-04-30 Thread GitBox
AmplabJenkins commented on pull request #28420: URL: https://github.com/apache/spark/pull/28420#issuecomment-621675201 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28420: [SPARK-31615][SQL] Pretty string output for sql method of RuntimeRepl…

2020-04-30 Thread GitBox
SparkQA commented on pull request #28420: URL: https://github.com/apache/spark/pull/28420#issuecomment-621674699 **[Test build #122122 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122122/testReport)** for PR 28420 at commit

[GitHub] [spark] yaooqinn opened a new pull request #28420: [SPARK-31615][SQL] Pretty string output for sql method of RuntimeRepl…

2020-04-30 Thread GitBox
yaooqinn opened a new pull request #28420: URL: https://github.com/apache/spark/pull/28420 …aceable expressions ### What changes were proposed in this pull request? The RuntimeReplaceable ones are runtime replaceable, thus, their original parameters are not going to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28379: [SPARK-28040][SPARK-28070][R] Write type object s3

2020-04-30 Thread GitBox
AmplabJenkins removed a comment on pull request #28379: URL: https://github.com/apache/spark/pull/28379#issuecomment-621664257 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28395: [SPARK-31549][PYSPARK] Add a develop API invoking collect on Python RDD with user-specified job group

2020-04-30 Thread GitBox
AmplabJenkins removed a comment on pull request #28395: URL: https://github.com/apache/spark/pull/28395#issuecomment-621664205 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28395: [SPARK-31549][PYSPARK] Add a develop API invoking collect on Python RDD with user-specified job group

2020-04-30 Thread GitBox
AmplabJenkins commented on pull request #28395: URL: https://github.com/apache/spark/pull/28395#issuecomment-621664205 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #28379: [SPARK-28040][SPARK-28070][R] Write type object s3

2020-04-30 Thread GitBox
AmplabJenkins commented on pull request #28379: URL: https://github.com/apache/spark/pull/28379#issuecomment-621664257 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] dilipbiswal commented on a change in pull request #28407: [SPARK-31607][SQL] Improve the perf of CTESubstitution

2020-04-30 Thread GitBox
dilipbiswal commented on a change in pull request #28407: URL: https://github.com/apache/spark/pull/28407#discussion_r417810157 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CTESubstitution.scala ## @@ -159,17 +146,36 @@ object

[GitHub] [spark] SparkQA commented on pull request #28395: [SPARK-31549][PYSPARK] Add a develop API invoking collect on Python RDD with user-specified job group

2020-04-30 Thread GitBox
SparkQA commented on pull request #28395: URL: https://github.com/apache/spark/pull/28395#issuecomment-621663547 **[Test build #122120 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122120/testReport)** for PR 28395 at commit

[GitHub] [spark] SparkQA commented on pull request #28379: [SPARK-28040][SPARK-28070][R] Write type object s3

2020-04-30 Thread GitBox
SparkQA commented on pull request #28379: URL: https://github.com/apache/spark/pull/28379#issuecomment-621663562 **[Test build #122121 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122121/testReport)** for PR 28379 at commit

[GitHub] [spark] zhengruifeng commented on a change in pull request #28349: [SPARK-30642][ML][PYSPARK] LinearSVC blockify input vectors

2020-04-30 Thread GitBox
zhengruifeng commented on a change in pull request #28349: URL: https://github.com/apache/spark/pull/28349#discussion_r417808922 ## File path: mllib/src/main/scala/org/apache/spark/ml/classification/LinearSVC.scala ## @@ -154,31 +156,56 @@ class LinearSVC @Since("2.2.0") (

[GitHub] [spark] igreenfield commented on a change in pull request #26624: [SPARK-8981][core] Add MDC support in Executor

2020-04-30 Thread GitBox
igreenfield commented on a change in pull request #26624: URL: https://github.com/apache/spark/pull/26624#discussion_r417809101 ## File path: core/src/main/scala/org/apache/spark/util/ThreadUtils.scala ## @@ -17,21 +17,101 @@ package org.apache.spark.util +import

[GitHub] [spark] igreenfield commented on a change in pull request #26624: [SPARK-8981][core] Add MDC support in Executor

2020-04-30 Thread GitBox
igreenfield commented on a change in pull request #26624: URL: https://github.com/apache/spark/pull/26624#discussion_r417808971 ## File path: core/src/main/scala/org/apache/spark/util/ThreadUtils.scala ## @@ -17,21 +17,101 @@ package org.apache.spark.util +import

[GitHub] [spark] igreenfield commented on a change in pull request #26624: [SPARK-8981][core] Add MDC support in Executor

2020-04-30 Thread GitBox
igreenfield commented on a change in pull request #26624: URL: https://github.com/apache/spark/pull/26624#discussion_r417808501 ## File path: core/src/main/scala/org/apache/spark/util/ThreadUtils.scala ## @@ -17,21 +17,101 @@ package org.apache.spark.util +import

[GitHub] [spark] igreenfield commented on a change in pull request #26624: [SPARK-8981][core] Add MDC support in Executor

2020-04-30 Thread GitBox
igreenfield commented on a change in pull request #26624: URL: https://github.com/apache/spark/pull/26624#discussion_r417808048 ## File path: core/src/main/scala/org/apache/spark/executor/Executor.scala ## @@ -104,7 +104,7 @@ private[spark] class Executor(

[GitHub] [spark] xuanyuanking commented on a change in pull request #28393: [SPARK-31595][SQL] Spark sql should allow unescaped quote mark in quoted string

2020-04-30 Thread GitBox
xuanyuanking commented on a change in pull request #28393: URL: https://github.com/apache/spark/pull/28393#discussion_r417806531 ## File path: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLCLIDriver.scala ## @@ -519,13 +520,13 @@

[GitHub] [spark] AmplabJenkins commented on pull request #28412: [SPARK-31608][CORE][WEBUI] Add a new type of KVStore to make loading UI faster

2020-04-30 Thread GitBox
AmplabJenkins commented on pull request #28412: URL: https://github.com/apache/spark/pull/28412#issuecomment-621660613 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28412: [SPARK-31608][CORE][WEBUI] Add a new type of KVStore to make loading UI faster

2020-04-30 Thread GitBox
AmplabJenkins removed a comment on pull request #28412: URL: https://github.com/apache/spark/pull/28412#issuecomment-621660613 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #28412: [SPARK-31608][CORE][WEBUI] Add a new type of KVStore to make loading UI faster

2020-04-30 Thread GitBox
SparkQA commented on pull request #28412: URL: https://github.com/apache/spark/pull/28412#issuecomment-621660096 **[Test build #122119 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122119/testReport)** for PR 28412 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28123: [SPARK-31350][SQL] Coalesce bucketed tables for join if applicable

2020-04-30 Thread GitBox
AmplabJenkins removed a comment on pull request #28123: URL: https://github.com/apache/spark/pull/28123#issuecomment-621657311 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28123: [SPARK-31350][SQL] Coalesce bucketed tables for join if applicable

2020-04-30 Thread GitBox
AmplabJenkins commented on pull request #28123: URL: https://github.com/apache/spark/pull/28123#issuecomment-621657311 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #28408: [SPARK-31557][SQL] Fix timestamps rebasing in legacy parsers

2020-04-30 Thread GitBox
AmplabJenkins commented on pull request #28408: URL: https://github.com/apache/spark/pull/28408#issuecomment-621657317 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28408: [SPARK-31557][SQL] Fix timestamps rebasing in legacy parsers

2020-04-30 Thread GitBox
AmplabJenkins removed a comment on pull request #28408: URL: https://github.com/apache/spark/pull/28408#issuecomment-621657317 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #28123: [SPARK-31350][SQL] Coalesce bucketed tables for join if applicable

2020-04-30 Thread GitBox
SparkQA commented on pull request #28123: URL: https://github.com/apache/spark/pull/28123#issuecomment-621656650 **[Test build #122118 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122118/testReport)** for PR 28123 at commit

[GitHub] [spark] SparkQA commented on pull request #28408: [SPARK-31557][SQL] Fix timestamps rebasing in legacy parsers

2020-04-30 Thread GitBox
SparkQA commented on pull request #28408: URL: https://github.com/apache/spark/pull/28408#issuecomment-621656609 **[Test build #122117 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122117/testReport)** for PR 28408 at commit

[GitHub] [spark] imback82 commented on pull request #28123: [SPARK-31350][SQL] Coalesce bucketed tables for join if applicable

2020-04-30 Thread GitBox
imback82 commented on pull request #28123: URL: https://github.com/apache/spark/pull/28123#issuecomment-621655308 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28419: [R] small tidying of sh scripts for R

2020-04-30 Thread GitBox
AmplabJenkins removed a comment on pull request #28419: URL: https://github.com/apache/spark/pull/28419#issuecomment-621653502 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28123: [SPARK-31350][SQL] Coalesce bucketed tables for join if applicable

2020-04-30 Thread GitBox
AmplabJenkins removed a comment on pull request #28123: URL: https://github.com/apache/spark/pull/28123#issuecomment-621653771 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28418: [SPARK-28424][TESTS][FOLLOW-UP] Add test cases for all interval units

2020-04-30 Thread GitBox
AmplabJenkins removed a comment on pull request #28418: URL: https://github.com/apache/spark/pull/28418#issuecomment-621653466 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28408: [SPARK-31557][SQL] Fix timestamps rebasing in legacy parsers

2020-04-30 Thread GitBox
AmplabJenkins removed a comment on pull request #28408: URL: https://github.com/apache/spark/pull/28408#issuecomment-621653656 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28379: [SPARK-28040][SPARK-28070][R] Write type object s3

2020-04-30 Thread GitBox
AmplabJenkins removed a comment on pull request #28379: URL: https://github.com/apache/spark/pull/28379#issuecomment-621653443 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28379: [SPARK-28040][SPARK-28070][R] Write type object s3

2020-04-30 Thread GitBox
AmplabJenkins removed a comment on pull request #28379: URL: https://github.com/apache/spark/pull/28379#issuecomment-621653434 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] cloud-fan commented on pull request #28408: [SPARK-31557][SQL] Fix timestamps rebasing in legacy parsers

2020-04-30 Thread GitBox
cloud-fan commented on pull request #28408: URL: https://github.com/apache/spark/pull/28408#issuecomment-621654109 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] SparkQA removed a comment on pull request #28419: [R] small tidying of sh scripts for R

2020-04-30 Thread GitBox
SparkQA removed a comment on pull request #28419: URL: https://github.com/apache/spark/pull/28419#issuecomment-621647256 **[Test build #122116 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122116/testReport)** for PR 28419 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #28408: [SPARK-31557][SQL] Fix timestamps rebasing in legacy parsers

2020-04-30 Thread GitBox
SparkQA removed a comment on pull request #28408: URL: https://github.com/apache/spark/pull/28408#issuecomment-621605413 **[Test build #122108 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122108/testReport)** for PR 28408 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28123: [SPARK-31350][SQL] Coalesce bucketed tables for join if applicable

2020-04-30 Thread GitBox
AmplabJenkins removed a comment on pull request #28123: URL: https://github.com/apache/spark/pull/28123#issuecomment-621653766 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28418: [SPARK-28424][TESTS][FOLLOW-UP] Add test cases for all interval units

2020-04-30 Thread GitBox
AmplabJenkins removed a comment on pull request #28418: URL: https://github.com/apache/spark/pull/28418#issuecomment-621653451 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28419: [R] small tidying of sh scripts for R

2020-04-30 Thread GitBox
AmplabJenkins removed a comment on pull request #28419: URL: https://github.com/apache/spark/pull/28419#issuecomment-621653497 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA removed a comment on pull request #28418: [SPARK-28424][TESTS][FOLLOW-UP] Add test cases for all interval units

2020-04-30 Thread GitBox
SparkQA removed a comment on pull request #28418: URL: https://github.com/apache/spark/pull/28418#issuecomment-621631387 **[Test build #122113 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122113/testReport)** for PR 28418 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28408: [SPARK-31557][SQL] Fix timestamps rebasing in legacy parsers

2020-04-30 Thread GitBox
AmplabJenkins removed a comment on pull request #28408: URL: https://github.com/apache/spark/pull/28408#issuecomment-621653648 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] cloud-fan edited a comment on pull request #28407: [SPARK-31607][SQL] Improve the perf of CTESubstitution

2020-04-30 Thread GitBox
cloud-fan edited a comment on pull request #28407: URL: https://github.com/apache/spark/pull/28407#issuecomment-621642692 > Just a side note that due to its eager way of substitution it can also cause performance degradation with queries where a CTE is defined but never actually used.

[GitHub] [spark] SparkQA removed a comment on pull request #28379: [SPARK-28040][SPARK-28070][R] Write type object s3

2020-04-30 Thread GitBox
SparkQA removed a comment on pull request #28379: URL: https://github.com/apache/spark/pull/28379#issuecomment-621644153 **[Test build #122115 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122115/testReport)** for PR 28379 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #28123: [SPARK-31350][SQL] Coalesce bucketed tables for join if applicable

2020-04-30 Thread GitBox
SparkQA removed a comment on pull request #28123: URL: https://github.com/apache/spark/pull/28123#issuecomment-621581634 **[Test build #122102 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122102/testReport)** for PR 28123 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28408: [SPARK-31557][SQL] Fix timestamps rebasing in legacy parsers

2020-04-30 Thread GitBox
AmplabJenkins commented on pull request #28408: URL: https://github.com/apache/spark/pull/28408#issuecomment-621653648 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #28123: [SPARK-31350][SQL] Coalesce bucketed tables for join if applicable

2020-04-30 Thread GitBox
AmplabJenkins commented on pull request #28123: URL: https://github.com/apache/spark/pull/28123#issuecomment-621653766 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28123: [SPARK-31350][SQL] Coalesce bucketed tables for join if applicable

2020-04-30 Thread GitBox
SparkQA commented on pull request #28123: URL: https://github.com/apache/spark/pull/28123#issuecomment-621653362 **[Test build #122102 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122102/testReport)** for PR 28123 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28419: [R] small tidying of sh scripts for R

2020-04-30 Thread GitBox
AmplabJenkins commented on pull request #28419: URL: https://github.com/apache/spark/pull/28419#issuecomment-621653497 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28408: [SPARK-31557][SQL] Fix timestamps rebasing in legacy parsers

2020-04-30 Thread GitBox
SparkQA commented on pull request #28408: URL: https://github.com/apache/spark/pull/28408#issuecomment-621653368 **[Test build #122108 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122108/testReport)** for PR 28408 at commit

[GitHub] [spark] SparkQA commented on pull request #28379: [SPARK-28040][SPARK-28070][R] Write type object s3

2020-04-30 Thread GitBox
SparkQA commented on pull request #28379: URL: https://github.com/apache/spark/pull/28379#issuecomment-621653370 **[Test build #122115 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122115/testReport)** for PR 28379 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28379: [SPARK-28040][SPARK-28070][R] Write type object s3

2020-04-30 Thread GitBox
AmplabJenkins commented on pull request #28379: URL: https://github.com/apache/spark/pull/28379#issuecomment-621653434 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #28418: [SPARK-28424][TESTS][FOLLOW-UP] Add test cases for all interval units

2020-04-30 Thread GitBox
AmplabJenkins commented on pull request #28418: URL: https://github.com/apache/spark/pull/28418#issuecomment-621653451 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] cloud-fan commented on a change in pull request #26624: [SPARK-8981][core] Add MDC support in Executor

2020-04-30 Thread GitBox
cloud-fan commented on a change in pull request #26624: URL: https://github.com/apache/spark/pull/26624#discussion_r417797723 ## File path: core/src/main/scala/org/apache/spark/util/ThreadUtils.scala ## @@ -17,21 +17,101 @@ package org.apache.spark.util +import java.util

[GitHub] [spark] xuanyuanking commented on pull request #28390: [SPARK-27340][SS][TESTS][FOLLOW-UP] Rephrase API comments and simplify tests

2020-04-30 Thread GitBox
xuanyuanking commented on pull request #28390: URL: https://github.com/apache/spark/pull/28390#issuecomment-621653199 Thanks for the review. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] SparkQA commented on pull request #28419: [R] small tidying of sh scripts for R

2020-04-30 Thread GitBox
SparkQA commented on pull request #28419: URL: https://github.com/apache/spark/pull/28419#issuecomment-621653372 **[Test build #122116 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122116/testReport)** for PR 28419 at commit

[GitHub] [spark] SparkQA commented on pull request #28418: [SPARK-28424][TESTS][FOLLOW-UP] Add test cases for all interval units

2020-04-30 Thread GitBox
SparkQA commented on pull request #28418: URL: https://github.com/apache/spark/pull/28418#issuecomment-621653364 **[Test build #122113 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122113/testReport)** for PR 28418 at commit

[GitHub] [spark] cloud-fan commented on a change in pull request #26624: [SPARK-8981][core] Add MDC support in Executor

2020-04-30 Thread GitBox
cloud-fan commented on a change in pull request #26624: URL: https://github.com/apache/spark/pull/26624#discussion_r417797121 ## File path: core/src/main/scala/org/apache/spark/util/ThreadUtils.scala ## @@ -17,21 +17,101 @@ package org.apache.spark.util +import java.util

[GitHub] [spark] cloud-fan commented on a change in pull request #26624: [SPARK-8981][core] Add MDC support in Executor

2020-04-30 Thread GitBox
cloud-fan commented on a change in pull request #26624: URL: https://github.com/apache/spark/pull/26624#discussion_r417796843 ## File path: core/src/main/scala/org/apache/spark/util/ThreadUtils.scala ## @@ -17,21 +17,101 @@ package org.apache.spark.util +import java.util

[GitHub] [spark] cloud-fan commented on a change in pull request #26624: [SPARK-8981][core] Add MDC support in Executor

2020-04-30 Thread GitBox
cloud-fan commented on a change in pull request #26624: URL: https://github.com/apache/spark/pull/26624#discussion_r417795307 ## File path: core/src/main/scala/org/apache/spark/executor/Executor.scala ## @@ -674,6 +677,18 @@ private[spark] class Executor( } } +

[GitHub] [spark] cloud-fan commented on a change in pull request #26624: [SPARK-8981][core] Add MDC support in Executor

2020-04-30 Thread GitBox
cloud-fan commented on a change in pull request #26624: URL: https://github.com/apache/spark/pull/26624#discussion_r417795158 ## File path: core/src/main/scala/org/apache/spark/executor/Executor.scala ## @@ -104,7 +104,7 @@ private[spark] class Executor(

[GitHub] [spark] dilipbiswal commented on a change in pull request #28393: [SPARK-31595][SQL] Spark sql should allow unescaped quote mark in quoted string

2020-04-30 Thread GitBox
dilipbiswal commented on a change in pull request #28393: URL: https://github.com/apache/spark/pull/28393#discussion_r417794434 ## File path: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLCLIDriver.scala ## @@ -519,13 +520,13 @@

[GitHub] [spark] dilipbiswal commented on a change in pull request #28393: [SPARK-31595][SQL] Spark sql should allow unescaped quote mark in quoted string

2020-04-30 Thread GitBox
dilipbiswal commented on a change in pull request #28393: URL: https://github.com/apache/spark/pull/28393#discussion_r417794207 ## File path: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLCLIDriver.scala ## @@ -519,13 +520,13 @@

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28419: [R] small tidying of sh scripts for R

2020-04-30 Thread GitBox
AmplabJenkins removed a comment on pull request #28419: URL: https://github.com/apache/spark/pull/28419#issuecomment-621647788 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28419: [R] small tidying of sh scripts for R

2020-04-30 Thread GitBox
AmplabJenkins commented on pull request #28419: URL: https://github.com/apache/spark/pull/28419#issuecomment-621647788 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28419: [R] small tidying of sh scripts for R

2020-04-30 Thread GitBox
SparkQA commented on pull request #28419: URL: https://github.com/apache/spark/pull/28419#issuecomment-621647256 **[Test build #122116 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122116/testReport)** for PR 28419 at commit

[GitHub] [spark] MichaelChirico opened a new pull request #28419: [R] small tidying of sh scripts for R

2020-04-30 Thread GitBox
MichaelChirico opened a new pull request #28419: URL: https://github.com/apache/spark/pull/28419 ### What changes were proposed in this pull request? Some tidying of `sh` scripts in `R/` ### Why are the changes needed? Not strictly needed, but the

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28379: [SPARK-28040][SPARK-28070][R] Write type object s3

2020-04-30 Thread GitBox
AmplabJenkins removed a comment on pull request #28379: URL: https://github.com/apache/spark/pull/28379#issuecomment-621644697 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] stczwd commented on a change in pull request #28280: [SPARK-31438][CORE][WIP] Support JobCleaned Status in SparkListener

2020-04-30 Thread GitBox
stczwd commented on a change in pull request #28280: URL: https://github.com/apache/spark/pull/28280#discussion_r417788796 ## File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/InsertIntoHiveTable.scala ## @@ -99,6 +99,12 @@ case class InsertIntoHiveTable(

[GitHub] [spark] stczwd commented on a change in pull request #28280: [SPARK-31438][CORE][WIP] Support JobCleaned Status in SparkListener

2020-04-30 Thread GitBox
stczwd commented on a change in pull request #28280: URL: https://github.com/apache/spark/pull/28280#discussion_r417788682 ## File path: core/src/main/scala/org/apache/spark/scheduler/JobCleanedHookListener.scala ## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software

[GitHub] [spark] AmplabJenkins commented on pull request #28379: [SPARK-28040][SPARK-28070][R] Write type object s3

2020-04-30 Thread GitBox
AmplabJenkins commented on pull request #28379: URL: https://github.com/apache/spark/pull/28379#issuecomment-621644697 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28349: [SPARK-30642][ML][PYSPARK] LinearSVC blockify input vectors

2020-04-30 Thread GitBox
AmplabJenkins removed a comment on pull request #28349: URL: https://github.com/apache/spark/pull/28349#issuecomment-621644053 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28349: [SPARK-30642][ML][PYSPARK] LinearSVC blockify input vectors

2020-04-30 Thread GitBox
AmplabJenkins commented on pull request #28349: URL: https://github.com/apache/spark/pull/28349#issuecomment-621644053 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28379: [SPARK-28040][SPARK-28070][R] Write type object s3

2020-04-30 Thread GitBox
SparkQA commented on pull request #28379: URL: https://github.com/apache/spark/pull/28379#issuecomment-621644153 **[Test build #122115 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122115/testReport)** for PR 28379 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #28349: [SPARK-30642][ML][PYSPARK] LinearSVC blockify input vectors

2020-04-30 Thread GitBox
SparkQA removed a comment on pull request #28349: URL: https://github.com/apache/spark/pull/28349#issuecomment-621585838 **[Test build #122103 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122103/testReport)** for PR 28349 at commit

[GitHub] [spark] SparkQA commented on pull request #28349: [SPARK-30642][ML][PYSPARK] LinearSVC blockify input vectors

2020-04-30 Thread GitBox
SparkQA commented on pull request #28349: URL: https://github.com/apache/spark/pull/28349#issuecomment-621643162 **[Test build #122103 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122103/testReport)** for PR 28349 at commit

[GitHub] [spark] cloud-fan edited a comment on pull request #28407: [SPARK-31607][SQL] Improve the perf of CTESubstitution

2020-04-30 Thread GitBox
cloud-fan edited a comment on pull request #28407: URL: https://github.com/apache/spark/pull/28407#issuecomment-621642692 > Just a side note that due to its eager way of substitution it can also cause performance degradation with queries where a CTE is defined but never actually used.

[GitHub] [spark] cloud-fan commented on pull request #28407: [SPARK-31607][SQL] Improve the perf of CTESubstitution

2020-04-30 Thread GitBox
cloud-fan commented on pull request #28407: URL: https://github.com/apache/spark/pull/28407#issuecomment-621642692 > Just a side note that due to its eager way of substitution it can also cause performance degradation with queries where a CTE is defined but never actually used. Yea

[GitHub] [spark] MaxGekk commented on pull request #28329: [SPARK-31554][SQL][TESTS] Retry flaky tests from CliSuite

2020-04-30 Thread GitBox
MaxGekk commented on pull request #28329: URL: https://github.com/apache/spark/pull/28329#issuecomment-621642370 It seems @juliuszsompolski 's PR https://github.com/apache/spark/pull/28156 fixed the issue. I am closing this.

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28417: [SPARK-31612][SQL][DOCS] SQL Reference clean up

2020-04-30 Thread GitBox
AmplabJenkins removed a comment on pull request #28417: URL: https://github.com/apache/spark/pull/28417#issuecomment-621637681 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] cloud-fan commented on pull request #28390: [SPARK-27340][SS][TESTS][FOLLOW-UP] Rephrase API comments and simplify tests

2020-04-30 Thread GitBox
cloud-fan commented on pull request #28390: URL: https://github.com/apache/spark/pull/28390#issuecomment-621638010 thanks, merging to master/3.0! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] SparkQA commented on pull request #28417: [SPARK-31612][SQL][DOCS] SQL Reference clean up

2020-04-30 Thread GitBox
SparkQA commented on pull request #28417: URL: https://github.com/apache/spark/pull/28417#issuecomment-621637596 **[Test build #122114 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122114/testReport)** for PR 28417 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #28417: [SPARK-31612][SQL][DOCS] SQL Reference clean up

2020-04-30 Thread GitBox
SparkQA removed a comment on pull request #28417: URL: https://github.com/apache/spark/pull/28417#issuecomment-621633791 **[Test build #122114 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122114/testReport)** for PR 28417 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28417: [SPARK-31612][SQL][DOCS] SQL Reference clean up

2020-04-30 Thread GitBox
AmplabJenkins commented on pull request #28417: URL: https://github.com/apache/spark/pull/28417#issuecomment-621637681 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] yaooqinn commented on a change in pull request #28402: [SPARK-31586][SQL][FOLLOWUP] Restore SQL string for datetime - interval operations

2020-04-30 Thread GitBox
yaooqinn commented on a change in pull request #28402: URL: https://github.com/apache/spark/pull/28402#discussion_r417778568 ## File path: sql/core/src/test/resources/sql-tests/results/ansi/interval.sql.out ## @@ -689,7 +689,7 @@ select interval '2-2' year to month +

[GitHub] [spark] AmplabJenkins removed a comment on pull request #27978: [SPARK-31127][ML] Implement abstract Selector

2020-04-30 Thread GitBox
AmplabJenkins removed a comment on pull request #27978: URL: https://github.com/apache/spark/pull/27978#issuecomment-621634148 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28417: [SPARK-31612][SQL][DOCS] SQL Reference clean up

2020-04-30 Thread GitBox
AmplabJenkins removed a comment on pull request #28417: URL: https://github.com/apache/spark/pull/28417#issuecomment-621634224 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28417: [SPARK-31612][SQL][DOCS] SQL Reference clean up

2020-04-30 Thread GitBox
AmplabJenkins commented on pull request #28417: URL: https://github.com/apache/spark/pull/28417#issuecomment-621634224 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #27978: [SPARK-31127][ML] Implement abstract Selector

2020-04-30 Thread GitBox
AmplabJenkins removed a comment on pull request #27978: URL: https://github.com/apache/spark/pull/27978#issuecomment-621634142 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #27978: [SPARK-31127][ML] Implement abstract Selector

2020-04-30 Thread GitBox
AmplabJenkins commented on pull request #27978: URL: https://github.com/apache/spark/pull/27978#issuecomment-621634142 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #27978: [SPARK-31127][ML] Implement abstract Selector

2020-04-30 Thread GitBox
SparkQA removed a comment on pull request #27978: URL: https://github.com/apache/spark/pull/27978#issuecomment-621596096 **[Test build #122106 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122106/testReport)** for PR 27978 at commit

[GitHub] [spark] SparkQA commented on pull request #28417: [SPARK-31612][SQL][DOCS] SQL Reference clean up

2020-04-30 Thread GitBox
SparkQA commented on pull request #28417: URL: https://github.com/apache/spark/pull/28417#issuecomment-621633791 **[Test build #122114 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122114/testReport)** for PR 28417 at commit

[GitHub] [spark] SparkQA commented on pull request #27978: [SPARK-31127][ML] Implement abstract Selector

2020-04-30 Thread GitBox
SparkQA commented on pull request #27978: URL: https://github.com/apache/spark/pull/27978#issuecomment-621633725 **[Test build #122106 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122106/testReport)** for PR 27978 at commit

<    1   2   3   4   5   6   7   >