[GitHub] spark pull request: [WIP][SPARK-1594][MLLIB] Cleaning up MLlib API...

2014-04-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/524#issuecomment-41247971 Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/14429/ --- If your project is set up for it, you can r

[GitHub] spark pull request: [WIP][SPARK-1594][MLLIB] Cleaning up MLlib API...

2014-04-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/524#issuecomment-41247970 Merged build finished. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [WIP][SPARK-1594][MLLIB] Cleaning up MLlib API...

2014-04-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/524#issuecomment-41247888 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [WIP][SPARK-1594][MLLIB] Cleaning up MLlib API...

2014-04-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/524#issuecomment-41247878 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] spark pull request: [WIP][SPARK-1594] Cleaning up MLlib APIs and g...

2014-04-23 Thread mengxr
GitHub user mengxr opened a pull request: https://github.com/apache/spark/pull/524 [WIP][SPARK-1594] Cleaning up MLlib APIs and guide Final pass before the v1.0 release. * Remove `VectorRDDs` * Move `BinaryClassificationMetrics` from `evaluation.binary` to `evaluation`

[GitHub] spark pull request: Fixed bug for Jira Issue# 1527

2014-04-23 Thread aarondav
Github user aarondav commented on a diff in the pull request: https://github.com/apache/spark/pull/517#discussion_r11937108 --- Diff: core/src/test/scala/org/apache/spark/storage/DiskBlockManagerSuite.scala --- @@ -26,6 +26,7 @@ import com.google.common.io.Files import org.sca

[GitHub] spark pull request: SPARK-1438 RDD.sample() make seed param option...

2014-04-23 Thread smartnut007
Github user smartnut007 commented on the pull request: https://github.com/apache/spark/pull/477#issuecomment-41246796 ok. removed redundant 'import random' --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d

[GitHub] spark pull request: SPARK-1587 Fix thread leak

2014-04-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/504 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] spark pull request: SPARK-1509: add zipWithIndex zipWithUniqueId m...

2014-04-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/423#issuecomment-41246765 Merged build finished. All automated tests passed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: SPARK-1589: Fix the incorrect compare

2014-04-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/508 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] spark pull request: [Fix #79] Replace Breakable For Loops By While...

2014-04-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/503 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] spark pull request: SPARK-1509: add zipWithIndex zipWithUniqueId m...

2014-04-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/423#issuecomment-41246766 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/14428/ --- If your project

[GitHub] spark pull request: SPARK-1587 Fix thread leak

2014-04-23 Thread aarondav
Github user aarondav commented on the pull request: https://github.com/apache/spark/pull/504#issuecomment-41246258 Looks good to me too -- didn't check too much for further missing pieces, but what's here seems good to go. Merged into master and branch-1.0. --- If your project is set

[GitHub] spark pull request: Generalize pattern for planning hash joins.

2014-04-23 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/418#issuecomment-41245858 Overall looks pretty good. I left some comments mainly on readability. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request: Generalize pattern for planning hash joins.

2014-04-23 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/418#discussion_r11936766 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala --- @@ -28,51 +28,14 @@ import org.apache.spark.sql.parquet._ abstract

[GitHub] spark pull request: Generalize pattern for planning hash joins.

2014-04-23 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/418#discussion_r11936750 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/patterns.scala --- @@ -102,6 +105,55 @@ object PhysicalOperation extends PredicateHe

[GitHub] spark pull request: [SQL] Add support for parsing indexing into ar...

2014-04-23 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/518#issuecomment-41245652 hmm we should check those as well --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not hav

[GitHub] spark pull request: [SQL] Add support for parsing indexing into ar...

2014-04-23 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/518#issuecomment-41245630 Test code isn't checked. On Apr 23, 2014 10:37 PM, "Reynold Xin" wrote: > @pwendell any idea how come scalastyle > didn't ca

[GitHub] spark pull request: Generalize pattern for planning hash joins.

2014-04-23 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/418#discussion_r11936670 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/patterns.scala --- @@ -102,6 +105,55 @@ object PhysicalOperation extends PredicateHe

[GitHub] spark pull request: [Hot Fix #469] Fix flaky test in SparkListener...

2014-04-23 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/516#discussion_r11936630 --- Diff: core/src/test/scala/org/apache/spark/scheduler/SparkListenerSuite.scala --- @@ -177,6 +177,7 @@ class SparkListenerSuite extends FunSuite with Local

[GitHub] spark pull request: Fixed bug for Jira Issue# 1527

2014-04-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/517#issuecomment-41245179 Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/14427/ --- If your project is set up for it, you can r

[GitHub] spark pull request: Fixed bug for Jira Issue# 1527

2014-04-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/517#issuecomment-41245178 Merged build finished. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [Hot Fix #469] Fix flaky test in SparkListener...

2014-04-23 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/516#discussion_r11936481 --- Diff: core/src/test/scala/org/apache/spark/scheduler/SparkListenerSuite.scala --- @@ -177,6 +177,7 @@ class SparkListenerSuite extends FunSuite with Lo

[GitHub] spark pull request: SPARK-1438 RDD.sample() make seed param option...

2014-04-23 Thread advancedxy
Github user advancedxy commented on a diff in the pull request: https://github.com/apache/spark/pull/477#discussion_r11936467 --- Diff: python/pyspark/rddsampler.py --- @@ -38,17 +38,15 @@ def initRandomGenerator(self, split): if self._use_numpy: import

[GitHub] spark pull request: SPARK-1509: add zipWithIndex zipWithUniqueId m...

2014-04-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/423#issuecomment-41244978 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: SPARK-1509: add zipWithIndex zipWithUniqueId m...

2014-04-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/423#issuecomment-41244971 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] spark pull request: Generalize pattern for planning hash joins.

2014-04-23 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/418#discussion_r11936429 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala --- @@ -37,10 +38,20 @@ trait Predicate extends Expression {

[GitHub] spark pull request: Generalize pattern for planning hash joins.

2014-04-23 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/418#discussion_r11936425 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala --- @@ -37,10 +38,20 @@ trait Predicate extends Expression {

[GitHub] spark pull request: Generalize pattern for planning hash joins.

2014-04-23 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/418#discussion_r11936410 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala --- @@ -37,10 +38,20 @@ trait Predicate extends Expression {

[GitHub] spark pull request: SPARK-1509: add zipWithIndex zipWithUniqueId m...

2014-04-23 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/423#issuecomment-41244779 Jenkins, test this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi

[GitHub] spark pull request: SPARK-1601 & SPARK-1602: two bug fixes related...

2014-04-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/521#issuecomment-41244750 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/14425/ --- If your project

[GitHub] spark pull request: [Fix #79] Replace Breakable For Loops By While...

2014-04-23 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/503#issuecomment-41244771 Thanks. I've merged this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f

[GitHub] spark pull request: SPARK-1601 & SPARK-1602: two bug fixes related...

2014-04-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/521#issuecomment-41244749 Merged build finished. All automated tests passed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [Hot Fix #469] Fix flaky test in SparkListener...

2014-04-23 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/516#discussion_r11936322 --- Diff: core/src/test/scala/org/apache/spark/scheduler/SparkListenerSuite.scala --- @@ -177,6 +177,7 @@ class SparkListenerSuite extends FunSuite with Lo

[GitHub] spark pull request: [Fix #79] Replace Breakable For Loops By While...

2014-04-23 Thread techaddict
Github user techaddict commented on the pull request: https://github.com/apache/spark/pull/503#issuecomment-41244496 @rxin all suggested changes done, tests passed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: SPARK-1438 RDD.sample() make seed param option...

2014-04-23 Thread advancedxy
Github user advancedxy commented on the pull request: https://github.com/apache/spark/pull/477#issuecomment-41244424 hi, @smartnut007, I don't think I could make the call. So, I didn't reply the question which one to use. should ask @mateiz ! --- If your project is set up for it,

[GitHub] spark pull request: [SQL] Add support for parsing indexing into ar...

2014-04-23 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/518#issuecomment-41244366 @pwendell any idea how come scalastyle didn't catch the line width violation? Is spark sql not checked? --- If your project is set up for it, you can reply to this email and

[GitHub] spark pull request: [Fix #79] Replace Breakable For Loops By While...

2014-04-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/503#issuecomment-41244344 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/14424/ --- If your project

[GitHub] spark pull request: [Fix #79] Replace Breakable For Loops By While...

2014-04-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/503#issuecomment-41244343 Merged build finished. All automated tests passed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: SPARK-1589: Fix the incorrect compare

2014-04-23 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/508#issuecomment-41244282 Thanks. I'm merging this since the failed test is a flaky one that we are already fixing somewhere else. --- If your project is set up for it, you can reply to this email an

[GitHub] spark pull request: SPARK-1145: Memory mapping with many small blo...

2014-04-23 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/43#issuecomment-41244245 Don't we want this in? I know a few cases on beefy machines jobs are failing because of this. --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request: SPARK-1589: Fix the incorrect compare

2014-04-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/508#issuecomment-41244229 Merged build finished. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: SPARK-1589: Fix the incorrect compare

2014-04-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/508#issuecomment-41244230 Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/14423/ --- If your project is set up for it, you can r

[GitHub] spark pull request: Fixed bug for Jira Issue# 1527

2014-04-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/517#issuecomment-41244191 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: Fixed bug for Jira Issue# 1527

2014-04-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/517#issuecomment-41244185 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] spark pull request: [Hot Fix #469] Fix flaky test in SparkListener...

2014-04-23 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/516#discussion_r11936200 --- Diff: core/src/test/scala/org/apache/spark/scheduler/SparkListenerSuite.scala --- @@ -177,6 +177,7 @@ class SparkListenerSuite extends FunSuite with LocalSpa

[GitHub] spark pull request: Mark all fields of EdgePartition, Graph, and G...

2014-04-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/520 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] spark pull request: Update Java api for setJobGroup with interrupt...

2014-04-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/522 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] spark pull request: [Hot Fix #469] Fix flaky test in SparkListener...

2014-04-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/516 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] spark pull request: SPARK-1588 Re-add support for SPARK_YARN_USER_...

2014-04-23 Thread mridulm
Github user mridulm commented on the pull request: https://github.com/apache/spark/pull/514#issuecomment-41244177 ah ok, that sucks ... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] spark pull request: SPARK-1586 Windows build fixes

2014-04-23 Thread mridulm
Github user mridulm commented on the pull request: https://github.com/apache/spark/pull/505#issuecomment-41244129 Quite a lot of them still fail - all failures now are from sql/hive - and all of them are path related issues iirc. I am not sure if they were due to the paths hardcode

[GitHub] spark pull request: [Hot Fix #469] Fix flaky test in SparkListener...

2014-04-23 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/516#discussion_r11936165 --- Diff: core/src/test/scala/org/apache/spark/scheduler/SparkListenerSuite.scala --- @@ -177,6 +177,7 @@ class SparkListenerSuite extends FunSuite with Local

[GitHub] spark pull request: Fixed bug for Jira Issue# 1527

2014-04-23 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/517#issuecomment-41244038 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [Hot Fix #469] Fix flaky test in SparkListener...

2014-04-23 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/516#discussion_r11936152 --- Diff: core/src/test/scala/org/apache/spark/scheduler/SparkListenerSuite.scala --- @@ -50,9 +50,9 @@ class SparkListenerSuite extends FunSuite with LocalSp

[GitHub] spark pull request: Fixed bug for Jira Issue# 1527

2014-04-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/517#issuecomment-41243761 Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/14426/ --- If your project is set up for it, you can r

[GitHub] spark pull request: Fixed bug for Jira Issue# 1527

2014-04-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/517#issuecomment-41243759 Merged build finished. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: SPARK-1583: Fix a bug that using java.util.Has...

2014-04-23 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/500#issuecomment-41243649 Looks great. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

[GitHub] spark pull request: SPARK-1577: Enabling reference tracking by def...

2014-04-23 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/499#issuecomment-41243517 Is the problem A has a reference to the outer level repl object? Maybe a better solution here is to turn reference tracking off when we serialize closures in the shell mode .

[GitHub] spark pull request: SPARK-1438 RDD.sample() make seed param option...

2014-04-23 Thread smartnut007
Github user smartnut007 commented on the pull request: https://github.com/apache/spark/pull/477#issuecomment-41243430 @mateiz @advancedxy new commit covers all suggestions so far. Any thoughts ? --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] spark pull request: Fixed bug for Jira Issue# 1527

2014-04-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/517#issuecomment-41243367 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: SPARK-1559

2014-04-23 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/471#issuecomment-41243371 This technically changes some behavior, but it is what I'd expect. @pwendell / @mateiz thoughts? --- If your project is set up for it, you can reply to this email and have y

[GitHub] spark pull request: Fixed bug for Jira Issue# 1527

2014-04-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/517#issuecomment-41243364 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] spark pull request: Fixed bug for Jira Issue# 1527

2014-04-23 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/517#issuecomment-41243159 Jenkins, test this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: SPARK-1601 & SPARK-1602: two bug fixes related...

2014-04-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/521#issuecomment-41243128 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] spark pull request: SPARK-1601 & SPARK-1602: two bug fixes related...

2014-04-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/521#issuecomment-41243141 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SQL] Add support for parsing indexing into ar...

2014-04-23 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/518#discussion_r11935835 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala --- @@ -28,6 +28,18 @@ class SQLQuerySuite extends QueryTest { // Make sure the

[GitHub] spark pull request: SPARK-1601 & SPARK-1602: two bug fixes related...

2014-04-23 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/521#issuecomment-41242993 Ok I brought this up to date. There are couple commits that show up because the asf git bot hasn't sync those commits to github yet. --- If your project is set up for it, yo

[GitHub] spark pull request: Mark all fields of EdgePartition, Graph, and G...

2014-04-23 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/520#issuecomment-41242853 Thanks. Merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

[GitHub] spark pull request: Update Java api for setJobGroup with interrupt...

2014-04-23 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/522#issuecomment-41242815 Merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark pull request: [Hot Fix #469] Fix flaky test in SparkListener...

2014-04-23 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/516#issuecomment-41242784 Thanks. I've merged this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f

[GitHub] spark pull request: SPARK-1583: Fix a bug that using java.util.Has...

2014-04-23 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/500#issuecomment-41242752 Actually it's probably fixed here already: https://github.com/apache/spark/pull/516/files --- If your project is set up for it, you can reply to this email and have your rep

[GitHub] spark pull request: [Fix #79] Replace Breakable For Loops By While...

2014-04-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/503#issuecomment-41242705 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] spark pull request: SPARK-1589: Fix the incorrect compare

2014-04-23 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/508#issuecomment-41242686 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi

[GitHub] spark pull request: SPARK-1589: Fix the incorrect compare

2014-04-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/508#issuecomment-41242704 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] spark pull request: [Fix #79] Replace Breakable For Loops By While...

2014-04-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/503#issuecomment-41242711 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: SPARK-1589: Fix the incorrect compare

2014-04-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/508#issuecomment-41242707 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: Update Java api for setJobGroup with interrupt...

2014-04-23 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/522#issuecomment-41242640 lgtm --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wi

[GitHub] spark pull request: [Fix #79] Replace Breakable For Loops By While...

2014-04-23 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/503#discussion_r11935731 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/tree/DecisionTree.scala --- @@ -82,32 +80,32 @@ class DecisionTree (private val strategy: Strategy) extends

[GitHub] spark pull request: [Fix #79] Replace Breakable For Loops By While...

2014-04-23 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/503#issuecomment-41242555 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi

[GitHub] spark pull request: SPARK-1601 & SPARK-1602: Do not put partially ...

2014-04-23 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/521#discussion_r11935665 --- Diff: core/src/test/scala/org/apache/spark/JobCancellationSuite.scala --- @@ -206,3 +235,9 @@ class JobCancellationSuite extends FunSuite with ShouldMatchers

[GitHub] spark pull request: SPARK-1235: manage the DAGScheduler EventProce...

2014-04-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/186#issuecomment-41242105 Merged build finished. All automated tests passed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: SPARK-1235: manage the DAGScheduler EventProce...

2014-04-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/186#issuecomment-41242106 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/14422/ --- If your project

[GitHub] spark pull request: Add unit test to spark_ec2 script

2014-04-23 Thread shivaram
Github user shivaram commented on the pull request: https://github.com/apache/spark/pull/134#issuecomment-41241727 Thanks @logc -- I had some style comments that I left inline. The dependencies + License look good to me. I am not really sure why we dont use `requirements.txt`

[GitHub] spark pull request: Add unit test to spark_ec2 script

2014-04-23 Thread shivaram
Github user shivaram commented on a diff in the pull request: https://github.com/apache/spark/pull/134#discussion_r11935429 --- Diff: ec2/tests.py --- @@ -0,0 +1,25 @@ +import unittest --- End diff -- This should probably include ``` #!/usr/bin/env pyt

[GitHub] spark pull request: Add unit test to spark_ec2 script

2014-04-23 Thread shivaram
Github user shivaram commented on a diff in the pull request: https://github.com/apache/spark/pull/134#discussion_r11935449 --- Diff: ec2/tests.py --- @@ -0,0 +1,25 @@ +import unittest + +from boto import ec2 +import mock +import moto + +import spark_ec2

[GitHub] spark pull request: Add unit test to spark_ec2 script

2014-04-23 Thread shivaram
Github user shivaram commented on a diff in the pull request: https://github.com/apache/spark/pull/134#discussion_r11935416 --- Diff: ec2/tests.py --- @@ -0,0 +1,25 @@ +import unittest + +from boto import ec2 +import mock +import moto + +import spark_ec2

[GitHub] spark pull request: SPARK-1235: manage the DAGScheduler EventProce...

2014-04-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/186#issuecomment-41241645 Merged build finished. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: SPARK-1235: manage the DAGScheduler EventProce...

2014-04-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/186#issuecomment-41241646 Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/14421/ --- If your project is set up for it, you can r

[GitHub] spark pull request: SPARK-1119 and other build improvements

2014-04-23 Thread berngp
Github user berngp commented on the pull request: https://github.com/apache/spark/pull/502#issuecomment-41241443 Makes sense to me. On Wednesday, April 23, 2014, Li Guoqiang wrote: > @berngp > Most of the people uses the same version of

[GitHub] spark pull request: SPARK-1235: manage the DAGScheduler EventProce...

2014-04-23 Thread CodingCat
Github user CodingCat commented on the pull request: https://github.com/apache/spark/pull/186#issuecomment-41241245 @mateiz @markhamstra , it was changed since akka 2.1.x https://www.assembla.com/spaces/akka/tickets/2031#/activity/ticket: --- If your project is set up for it, you can

[GitHub] spark pull request: SPARK-1235: manage the DAGScheduler EventProce...

2014-04-23 Thread CodingCat
Github user CodingCat commented on the pull request: https://github.com/apache/spark/pull/186#issuecomment-41240857 Hey, @markhamstra @mateiz , thanks for that the Jenkins is so busy tonight, the test of this PR keeps failingwhen running with the other 4 test jobs, https://github.

[GitHub] spark pull request: SPARK-1235: manage the DAGScheduler EventProce...

2014-04-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/186#issuecomment-41240723 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: SPARK-1235: manage the DAGScheduler EventProce...

2014-04-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/186#issuecomment-41240720 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] spark pull request: [Fix #79] Replace Breakable For Loops By While...

2014-04-23 Thread techaddict
Github user techaddict commented on the pull request: https://github.com/apache/spark/pull/503#issuecomment-41240253 @mateiz retest this please, I think failure is due to some other PR, as these changes have nothing to do with Streaming. --- If your project is set up for it, you can

[GitHub] spark pull request: SPARK-1119 and other build improvements

2014-04-23 Thread witgo
Github user witgo commented on the pull request: https://github.com/apache/spark/pull/502#issuecomment-41239453 @berngp Most of the people uses the same version of HDFS vs YARN. We can be so ```xml 1.0.4 ${hadoop.version} ``` ```xml yar

[GitHub] spark pull request: Update Java api for setJobGroup with interrupt...

2014-04-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/522#issuecomment-41239291 Merged build finished. All automated tests passed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: Update Java api for setJobGroup with interrupt...

2014-04-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/522#issuecomment-41239292 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/14420/ --- If your project

[GitHub] spark pull request: SPARK-1583: Fix a bug that using java.util.Has...

2014-04-23 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/500#issuecomment-41238805 > Do you have time to fix that flaky test? Sure. I need some time to confirm my guess. --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: SPARK-1589: Fix the incorrect compare

2014-04-23 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/508#issuecomment-41238701 Sorry that I forgot to run scalastyle. Already fixed it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: SPARK-1119 and other build improvements

2014-04-23 Thread berngp
Github user berngp commented on the pull request: https://github.com/apache/spark/pull/502#issuecomment-41238386 Yes it will, not every one uses the same version of HDFS vs YARN. On Wednesday, April 23, 2014, Li Guoqiang wrote: > @berngp @

  1   2   3   4   5   6   >