[GitHub] spark issue #18846: [SPARK-21642][CORE] Use FQDN for DRIVER_HOST_ADDRESS ins...

2017-08-08 Thread zsxwing
Github user zsxwing commented on the issue: https://github.com/apache/spark/pull/18846 @thide I think DRIVER_HOST_ADDRESS will be used to generate the driver url. Could you check if this line still works after your change? https://github.com/apache/spark/blob/b35660dd0e930f4b484a0

[GitHub] spark issue #18890: [SPARK-21596][SS] Ensure places calling HDFSMetadataLog....

2017-08-08 Thread zsxwing
Github user zsxwing commented on the issue: https://github.com/apache/spark/pull/18890 Merged. Could you close the PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #18867: [SPARK-21663][TESTS]test("remote fetch below max RPC mes...

2017-08-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18867 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #18867: [SPARK-21663][TESTS]test("remote fetch below max RPC mes...

2017-08-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18867 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80437/ Test PASSed. ---

[GitHub] spark issue #18867: [SPARK-21663][TESTS]test("remote fetch below max RPC mes...

2017-08-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18867 **[Test build #80437 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80437/testReport)** for PR 18867 at commit [`5fb7403`](https://github.com/apache/spark/commit/5

[GitHub] spark issue #18890: [SPARK-21596][SS] Ensure places calling HDFSMetadataLog....

2017-08-08 Thread zsxwing
Github user zsxwing commented on the issue: https://github.com/apache/spark/pull/18890 Thanks! Merging to branch-2.2. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark pull request #18797: [SPARK-21523][ML] update breeze to 0.13.2 for an ...

2017-08-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/18797 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark issue #18797: [SPARK-21523][ML] update breeze to 0.13.2 for an emergen...

2017-08-08 Thread yanboliang
Github user yanboliang commented on the issue: https://github.com/apache/spark/pull/18797 Merged into master and branch-2.2. Thanks for all. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

[GitHub] spark issue #18789: SPARK-20433 Bump jackson from 2.6.5 to 2.6.7.1

2017-08-08 Thread ash211
Github user ash211 commented on the issue: https://github.com/apache/spark/pull/18789 @srowen sorry for not picking up on this -- thanks for pushing it over the finish line in your PR! --- If your project is set up for it, you can reply to this email and have your reply appear on Git

[GitHub] spark issue #18499: [SPARK-21176][WEB UI] Use a single ProxyServlet to proxy...

2017-08-08 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18499 @aosagie do we still need the previous fix for SPARK-21176? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does no

[GitHub] spark pull request #18499: [SPARK-21176][WEB UI] Use a single ProxyServlet t...

2017-08-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/18499 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark issue #18421: [SPARK-21213][SQL] Support collecting partition-level st...

2017-08-08 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/18421 @mbasmanova Really thank you for your contribution! LGTM except the above four comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark issue #18499: [SPARK-21176][WEB UI] Use a single ProxyServlet to proxy...

2017-08-08 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18499 thanks, merging to master! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wi

[GitHub] spark pull request #18421: [SPARK-21213][SQL] Support collecting partition-l...

2017-08-08 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18421#discussion_r132099901 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/StatisticsSuite.scala --- @@ -256,6 +257,222 @@ class StatisticsSuite extends StatisticsColl

[GitHub] spark pull request #18421: [SPARK-21213][SQL] Support collecting partition-l...

2017-08-08 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18421#discussion_r132099286 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala --- @@ -1033,25 +998,126 @@ private[spark] class HiveExternalCatalo

[GitHub] spark issue #18787: [SPARK-21583][SQL] Create a ColumnarBatch from ArrowColu...

2017-08-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18787 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80438/ Test PASSed. ---

[GitHub] spark issue #18787: [SPARK-21583][SQL] Create a ColumnarBatch from ArrowColu...

2017-08-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18787 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #18787: [SPARK-21583][SQL] Create a ColumnarBatch from ArrowColu...

2017-08-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18787 **[Test build #80438 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80438/testReport)** for PR 18787 at commit [`23d19df`](https://github.com/apache/spark/commit/2

[GitHub] spark issue #18421: [SPARK-21213][SQL] Support collecting partition-level st...

2017-08-08 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/18421 There are still two remaining comments. Could you also address them? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark issue #18869: [SPARK-21654][SQL] Complement SQL predicates expression ...

2017-08-08 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/18869 @gatorsmile Sure. Let's wait after #18818. I'll look at it too. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does no

[GitHub] spark issue #18869: [SPARK-21654][SQL] Complement SQL predicates expression ...

2017-08-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18869 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #18818: [SPARK-21110][SQL] Structs, arrays, and other orderable ...

2017-08-08 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/18818 Also add `NULL` in the test case? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enable

[GitHub] spark issue #18869: [SPARK-21654][SQL] Complement SQL predicates expression ...

2017-08-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18869 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80435/ Test PASSed. ---

[GitHub] spark issue #18869: [SPARK-21654][SQL] Complement SQL predicates expression ...

2017-08-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18869 **[Test build #80435 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80435/testReport)** for PR 18869 at commit [`1369fd5`](https://github.com/apache/spark/commit/1

[GitHub] spark issue #18869: [SPARK-21654][SQL] Complement SQL predicates expression ...

2017-08-08 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/18869 @viirya Could you hold this PR at first? There is a related PR https://github.com/apache/spark/pull/18818 that is changing the underlying semantics. We also need to update the description after t

[GitHub] spark issue #18709: [SPARK-21504] [SQL] Add spark version info into table me...

2017-08-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18709 **[Test build #80445 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80445/testReport)** for PR 18709 at commit [`f5a26cc`](https://github.com/apache/spark/commit/f5

[GitHub] spark issue #18880: [SPARK-21665][Core]Need to close resources after use

2017-08-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18880 **[Test build #80444 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80444/testReport)** for PR 18880 at commit [`7bd2904`](https://github.com/apache/spark/commit/7b

[GitHub] spark issue #18890: [SPARK-21596][SS] Ensure places calling HDFSMetadataLog....

2017-08-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18890 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #18890: [SPARK-21596][SS] Ensure places calling HDFSMetadataLog....

2017-08-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18890 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80436/ Test PASSed. ---

[GitHub] spark issue #18790: [SPARK-21587][SS] Added pushdown through watermarks.

2017-08-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18790 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80434/ Test PASSed. ---

[GitHub] spark issue #18790: [SPARK-21587][SS] Added pushdown through watermarks.

2017-08-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18790 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #18890: [SPARK-21596][SS] Ensure places calling HDFSMetadataLog....

2017-08-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18890 **[Test build #80436 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80436/testReport)** for PR 18890 at commit [`532529a`](https://github.com/apache/spark/commit/5

[GitHub] spark issue #18790: [SPARK-21587][SS] Added pushdown through watermarks.

2017-08-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18790 **[Test build #80434 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80434/testReport)** for PR 18790 at commit [`4cae897`](https://github.com/apache/spark/commit/4

[GitHub] spark issue #18866: [SPARK-21649][SQL] Support writing data into hive bucket...

2017-08-08 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18866 Hash function is not the only issue, one important difference is: hive will shuffle before write, and make sure one bucket has only one file. Spark doesn't shuffle and each write task may write a

[GitHub] spark issue #16774: [SPARK-19357][ML] Adding parallel model evaluation in ML...

2017-08-08 Thread WeichenXu123
Github user WeichenXu123 commented on the issue: https://github.com/apache/spark/pull/16774 @BryanCutler You are right. Once `Future` complete the model can be cleaned by GC. So the memory cost of the code has been optimized already. I didn't look at the code carefully a few days ago.

[GitHub] spark issue #18790: [SPARK-21587][SS] Added pushdown through watermarks.

2017-08-08 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/18790 It sounds like we need to revisit all the optimizer rules for `EventTimeWatermark`? We can do it in the separate PRs. --- If your project is set up for it, you can reply to this email and have y

[GitHub] spark issue #18846: [SPARK-21642][CORE] Use FQDN for DRIVER_HOST_ADDRESS ins...

2017-08-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18846 **[Test build #80443 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80443/testReport)** for PR 18846 at commit [`afc07ee`](https://github.com/apache/spark/commit/af

[GitHub] spark issue #18846: [SPARK-21642][CORE] Use FQDN for DRIVER_HOST_ADDRESS ins...

2017-08-08 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18846 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] spark pull request #18707: [SPARK-21503][UI]: Spark UI shows incorrect task ...

2017-08-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/18707 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request #18790: [SPARK-21587][SS] Added pushdown through watermar...

2017-08-08 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18790#discussion_r132095065 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -410,6 +413,14 @@ object PushProjectionThroughUnion

[GitHub] spark issue #18707: [SPARK-21503][UI]: Spark UI shows incorrect task status ...

2017-08-08 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18707 I was just asking about different fixes, I'm ok with the current fix. thanks, merging to master/2.2! --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark issue #18756: [SPARK-21548][SQL] "Support insert into serial columns o...

2017-08-08 Thread lvdongr
Github user lvdongr commented on the issue: https://github.com/apache/spark/pull/18756 The target of this pr is support to insert into specified columns, all columns is no need , like insert into t(a, c) values (1, 0.8) . --- If your project is set up for it, you can repl

[GitHub] spark pull request #18790: [SPARK-21587][SS] Added pushdown through watermar...

2017-08-08 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18790#discussion_r132094610 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -410,6 +413,14 @@ object PushProjectionThroughUnion

[GitHub] spark issue #18709: [SPARK-21504] [SQL] Add spark version info into table me...

2017-08-08 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18709 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fea

[GitHub] spark pull request #18709: [SPARK-21504] [SQL] Add spark version info into t...

2017-08-08 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18709#discussion_r132094303 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala --- @@ -205,6 +205,9 @@ case class BucketSpec( *

[GitHub] spark issue #18756: [SPARK-21548][SQL] "Support insert into serial columns o...

2017-08-08 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/18756 I think this pr should be fixed in that way, maybe. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #18756: [SPARK-21548][SQL] "Support insert into serial columns o...

2017-08-08 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/18756 I'm still not looking into this pr though, IMHO it would be good for users to select parts of columns like other databases; ``` postgres=# create table t(a int, b text, c float8, d int);

[GitHub] spark issue #18648: [SPARK-21428] Turn IsolatedClientLoader off while using ...

2017-08-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18648 **[Test build #80442 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80442/testReport)** for PR 18648 at commit [`6c0bf70`](https://github.com/apache/spark/commit/6c

[GitHub] spark pull request #18648: [SPARK-21428] Turn IsolatedClientLoader off while...

2017-08-08 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18648#discussion_r132093341 --- Diff: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/HiveCliSessionStateSuite.scala --- @@ -0,0 +1,56 @@ +/* + *

[GitHub] spark pull request #18790: [SPARK-21587][SS] Added pushdown through watermar...

2017-08-08 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18790#discussion_r132093307 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -872,6 +886,25 @@ object PushDownPredicate extends

[GitHub] spark issue #18648: [SPARK-21428] Turn IsolatedClientLoader off while using ...

2017-08-08 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18648 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if t

[GitHub] spark issue #17894: [WIP][SPARK-17134][ML] Use level 2 BLAS operations in Lo...

2017-08-08 Thread WeichenXu123
Github user WeichenXu123 commented on the issue: https://github.com/apache/spark/pull/17894 I am also interested in implementation by level-3 BLAS. Can you post a design doc first? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark issue #18855: [SPARK-3151] [Block Manager] DiskStore.getBytes fails fo...

2017-08-08 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18855 since this PR only focus on `DiskStore`, shall we remove the new tests in `BlockManagerSuite`? Seems the OOM only happens in `BlockManagerSuite` --- If your project is set up for it, you can repl

[GitHub] spark pull request #18814: [SPARK-21608][SPARK-9221][SQL] Window rangeBetwee...

2017-08-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/18814 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark issue #18814: [SPARK-21608][SPARK-9221][SQL] Window rangeBetween() API...

2017-08-08 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18814 thanks, merging to master! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wi

[GitHub] spark issue #18756: [SPARK-21548][SQL] "Support insert into serial columns o...

2017-08-08 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/18756 I see. This PR still requires users to provide all the columns, right? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proj

[GitHub] spark issue #15435: [SPARK-17139][ML] Add model summary for MultinomialLogis...

2017-08-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15435 **[Test build #80441 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80441/testReport)** for PR 15435 at commit [`403680c`](https://github.com/apache/spark/commit/40

[GitHub] spark issue #18869: [SPARK-21654][SQL] Complement SQL predicates expression ...

2017-08-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18869 **[Test build #80440 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80440/testReport)** for PR 18869 at commit [`b64c9e6`](https://github.com/apache/spark/commit/b6

[GitHub] spark issue #18869: [SPARK-21654][SQL] Complement SQL predicates expression ...

2017-08-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18869 **[Test build #80439 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80439/testReport)** for PR 18869 at commit [`bca2b0b`](https://github.com/apache/spark/commit/bc

[GitHub] spark pull request #18869: [SPARK-21654][SQL] Complement SQL predicates expr...

2017-08-08 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18869#discussion_r132088990 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala --- @@ -564,8 +611,27 @@ case class EqualNullSafe(left: Exp

[GitHub] spark pull request #18849: [SPARK-21617][SQL] Store correct table metadata w...

2017-08-08 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18849#discussion_r132088495 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala --- @@ -1175,6 +1205,27 @@ private[spark] class HiveExternalCatalog(con

[GitHub] spark pull request #18869: [SPARK-21654][SQL] Complement SQL predicates expr...

2017-08-08 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/18869#discussion_r132088507 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala --- @@ -564,8 +611,27 @@ case class EqualNullSafe(left

[GitHub] spark issue #18630: [SPARK-12559][SPARK SUBMIT] fix --packages for stand-alo...

2017-08-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18630 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #18630: [SPARK-12559][SPARK SUBMIT] fix --packages for stand-alo...

2017-08-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18630 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80433/ Test PASSed. ---

[GitHub] spark issue #18630: [SPARK-12559][SPARK SUBMIT] fix --packages for stand-alo...

2017-08-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18630 **[Test build #80433 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80433/testReport)** for PR 18630 at commit [`a177992`](https://github.com/apache/spark/commit/a

[GitHub] spark pull request #18875: [SPARK-21513][SQL] Allow UDF to_json support conv...

2017-08-08 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/18875#discussion_r132088249 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala --- @@ -659,13 +660,19 @@ case class StructsToJso

[GitHub] spark pull request #18849: [SPARK-21617][SQL] Store correct table metadata w...

2017-08-08 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18849#discussion_r132087575 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala --- @@ -908,7 +909,13 @@ private[hive] object HiveClientImpl {

[GitHub] spark issue #18887: [SPARK-20642][core] Store FsHistoryProvider listing data...

2017-08-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18887 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80431/ Test FAILed. ---

[GitHub] spark issue #18887: [SPARK-20642][core] Store FsHistoryProvider listing data...

2017-08-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18887 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #18887: [SPARK-20642][core] Store FsHistoryProvider listing data...

2017-08-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18887 **[Test build #80431 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80431/testReport)** for PR 18887 at commit [`1ec1a67`](https://github.com/apache/spark/commit/1

[GitHub] spark issue #18474: [SPARK-21235][TESTS] UTest should clear temp results whe...

2017-08-08 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/18474 Thanks for reproduction @kiszk. @wangjiaochun, I think the cause should be explained here. I remember I reviewed similar PRs before where the cause was `Utils.getOrCreateLocalRootDirs` is being

[GitHub] spark issue #18787: [SPARK-21583][SQL] Create a ColumnarBatch from ArrowColu...

2017-08-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18787 **[Test build #80438 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80438/testReport)** for PR 18787 at commit [`23d19df`](https://github.com/apache/spark/commit/23

[GitHub] spark issue #18890: [SPARK-21596][SS] Ensure places calling HDFSMetadataLog....

2017-08-08 Thread zsxwing
Github user zsxwing commented on the issue: https://github.com/apache/spark/pull/18890 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featu

[GitHub] spark issue #18787: [SPARK-21583][SQL] Create a ColumnarBatch from ArrowColu...

2017-08-08 Thread BryanCutler
Github user BryanCutler commented on the issue: https://github.com/apache/spark/pull/18787 jenkins retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark pull request #18884: [SPARK-21669] Internal API for collecting metrics...

2017-08-08 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18884#discussion_r132086218 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileFormatWriter.scala --- @@ -269,50 +278,57 @@ object FileFormatWriter extend

[GitHub] spark issue #18849: [SPARK-21617][SQL] Store correct table metadata when alt...

2017-08-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18849 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80432/ Test FAILed. ---

[GitHub] spark issue #18849: [SPARK-21617][SQL] Store correct table metadata when alt...

2017-08-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18849 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark pull request #18884: [SPARK-21669] Internal API for collecting metrics...

2017-08-08 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18884#discussion_r132085558 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileFormatWriter.scala --- @@ -269,50 +278,57 @@ object FileFormatWriter extend

[GitHub] spark issue #18867: [SPARK-21663][TESTS]test("remote fetch below max RPC mes...

2017-08-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18867 **[Test build #80437 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80437/testReport)** for PR 18867 at commit [`5fb7403`](https://github.com/apache/spark/commit/5f

[GitHub] spark issue #18849: [SPARK-21617][SQL] Store correct table metadata when alt...

2017-08-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18849 **[Test build #80432 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80432/testReport)** for PR 18849 at commit [`7b777ed`](https://github.com/apache/spark/commit/7

[GitHub] spark issue #18799: [SPARK-21596][SS]Ensure places calling HDFSMetadataLog.g...

2017-08-08 Thread tdas
Github user tdas commented on the issue: https://github.com/apache/spark/pull/18799 Never mind @zsxwing I already opened a PR #18890 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featu

[GitHub] spark issue #18890: [SPARK-21596][SS] Ensure places calling HDFSMetadataLog....

2017-08-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18890 **[Test build #80436 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80436/testReport)** for PR 18890 at commit [`532529a`](https://github.com/apache/spark/commit/53

[GitHub] spark pull request #18890: [SPARK-21596][SS] Ensure places calling HDFSMetad...

2017-08-08 Thread tdas
GitHub user tdas opened a pull request: https://github.com/apache/spark/pull/18890 [SPARK-21596][SS] Ensure places calling HDFSMetadataLog.get check the return value When I was investigating a flaky test, I realized that many places don't check the return value of `HDFSMetadataLog.

[GitHub] spark issue #18869: [SPARK-21654][SQL] Complement SQL predicates expression ...

2017-08-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18869 **[Test build #80435 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80435/testReport)** for PR 18869 at commit [`1369fd5`](https://github.com/apache/spark/commit/13

[GitHub] spark issue #18869: [SPARK-21654][SQL] Complement SQL predicates expression ...

2017-08-08 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/18869 @gatorsmile I've checked the binary predicates in this change. Related test cases are added. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request #18869: [SPARK-21654][SQL] Complement SQL predicates expr...

2017-08-08 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18869#discussion_r132084124 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala --- @@ -484,7 +501,20 @@ object Equality { }

[GitHub] spark issue #18799: [SPARK-21596][SS]Ensure places calling HDFSMetadataLog.g...

2017-08-08 Thread tdas
Github user tdas commented on the issue: https://github.com/apache/spark/pull/18799 Merged to master. But there were conflicts with 2.2. Can you make another PR for 2.2. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark issue #15435: [SPARK-17139][ML] Add model summary for MultinomialLogis...

2017-08-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15435 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark pull request #18799: [SPARK-21596][SS]Ensure places calling HDFSMetada...

2017-08-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/18799 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark issue #15435: [SPARK-17139][ML] Add model summary for MultinomialLogis...

2017-08-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15435 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80428/ Test FAILed. ---

[GitHub] spark issue #18790: [SPARK-21587][SS] Added pushdown through watermarks.

2017-08-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18790 **[Test build #80434 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80434/testReport)** for PR 18790 at commit [`4cae897`](https://github.com/apache/spark/commit/4c

[GitHub] spark issue #15435: [SPARK-17139][ML] Add model summary for MultinomialLogis...

2017-08-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15435 **[Test build #80428 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80428/testReport)** for PR 15435 at commit [`cb0a818`](https://github.com/apache/spark/commit/c

[GitHub] spark issue #18790: [SPARK-21587][SS] Added pushdown through watermarks.

2017-08-08 Thread tdas
Github user tdas commented on the issue: https://github.com/apache/spark/pull/18790 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or i

[GitHub] spark pull request #18869: [SPARK-21654][SQL] Complement SQL predicates expr...

2017-08-08 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18869#discussion_r132081911 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala --- @@ -484,7 +501,20 @@ object Equality { }

[GitHub] spark issue #18799: [SPARK-21596][SS]Ensure places calling HDFSMetadataLog.g...

2017-08-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18799 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80429/ Test PASSed. ---

[GitHub] spark issue #18799: [SPARK-21596][SS]Ensure places calling HDFSMetadataLog.g...

2017-08-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18799 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #18799: [SPARK-21596][SS]Ensure places calling HDFSMetadataLog.g...

2017-08-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18799 **[Test build #80429 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80429/testReport)** for PR 18799 at commit [`16b02da`](https://github.com/apache/spark/commit/1

[GitHub] spark pull request #18867: [SPARK-21663][TESTS]test("remote fetch below max ...

2017-08-08 Thread jiangxb1987
Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/18867#discussion_r132081417 --- Diff: core/src/test/scala/org/apache/spark/MapOutputTrackerSuite.scala --- @@ -176,7 +176,7 @@ class MapOutputTrackerSuite extends SparkFunSuite {

[GitHub] spark issue #18790: [SPARK-21587][SS] Added pushdown through watermarks.

2017-08-08 Thread tdas
Github user tdas commented on the issue: https://github.com/apache/spark/pull/18790 Ok to test On Aug 8, 2017 7:48 PM, "UCB AMPLab" wrote: > Can one of the admins verify this patch? > > — > You are receiving this because you commented. > Reply to thi

[GitHub] spark issue #18790: [SPARK-21587][SS] Added pushdown through watermarks.

2017-08-08 Thread tdas
Github user tdas commented on the issue: https://github.com/apache/spark/pull/18790 Ok to test On Aug 8, 2017 7:48 PM, "UCB AMPLab" wrote: > Can one of the admins verify this patch? > > — > You are receiving this because you commented. > Reply t

  1   2   3   4   5   6   >