[GitHub] [spark] SparkQA commented on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax

2019-08-01 Thread GitBox
SparkQA commented on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax URL: https://github.com/apache/spark/pull/25001#issuecomment-517579718 **[Test build #108552 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/108552/testReport)** for PR 250

[GitHub] [spark] SparkQA commented on issue #25215: [SPARK-28445][SQL][Python] Fix error when PythonUDF is used in both group by and aggregate expression

2019-08-01 Thread GitBox
SparkQA commented on issue #25215: [SPARK-28445][SQL][Python] Fix error when PythonUDF is used in both group by and aggregate expression URL: https://github.com/apache/spark/pull/25215#issuecomment-517579715 **[Test build #108551 has started](https://amplab.cs.berkeley.edu/jenkins/job/Spar

[GitHub] [spark] AmplabJenkins removed a comment on issue #25215: [SPARK-28445][SQL][Python] Fix error when PythonUDF is used in both group by and aggregate expression

2019-08-01 Thread GitBox
AmplabJenkins removed a comment on issue #25215: [SPARK-28445][SQL][Python] Fix error when PythonUDF is used in both group by and aggregate expression URL: https://github.com/apache/spark/pull/25215#issuecomment-517578937 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #25215: [SPARK-28445][SQL][Python] Fix error when PythonUDF is used in both group by and aggregate expression

2019-08-01 Thread GitBox
AmplabJenkins removed a comment on issue #25215: [SPARK-28445][SQL][Python] Fix error when PythonUDF is used in both group by and aggregate expression URL: https://github.com/apache/spark/pull/25215#issuecomment-517578943 Test PASSed. Refer to this link for build results (access rights t

[GitHub] [spark] AmplabJenkins removed a comment on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax

2019-08-01 Thread GitBox
AmplabJenkins removed a comment on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax URL: https://github.com/apache/spark/pull/25001#issuecomment-517579031 Merged build finished. Test PASSed. This is an automate

[GitHub] [spark] AmplabJenkins removed a comment on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax

2019-08-01 Thread GitBox
AmplabJenkins removed a comment on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax URL: https://github.com/apache/spark/pull/25001#issuecomment-517579041 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley

[GitHub] [spark] AmplabJenkins commented on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax

2019-08-01 Thread GitBox
AmplabJenkins commented on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax URL: https://github.com/apache/spark/pull/25001#issuecomment-517579031 Merged build finished. Test PASSed. This is an automated messag

[GitHub] [spark] AmplabJenkins commented on issue #25215: [SPARK-28445][SQL][Python] Fix error when PythonUDF is used in both group by and aggregate expression

2019-08-01 Thread GitBox
AmplabJenkins commented on issue #25215: [SPARK-28445][SQL][Python] Fix error when PythonUDF is used in both group by and aggregate expression URL: https://github.com/apache/spark/pull/25215#issuecomment-517578937 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax

2019-08-01 Thread GitBox
AmplabJenkins commented on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax URL: https://github.com/apache/spark/pull/25001#issuecomment-517579041 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jen

[GitHub] [spark] AmplabJenkins commented on issue #25215: [SPARK-28445][SQL][Python] Fix error when PythonUDF is used in both group by and aggregate expression

2019-08-01 Thread GitBox
AmplabJenkins commented on issue #25215: [SPARK-28445][SQL][Python] Fix error when PythonUDF is used in both group by and aggregate expression URL: https://github.com/apache/spark/pull/25215#issuecomment-517578943 Test PASSed. Refer to this link for build results (access rights to CI ser

[GitHub] [spark] cloud-fan commented on a change in pull request #25215: [SPARK-28445][SQL][Python] Fix error when PythonUDF is used in both group by and aggregate expression

2019-08-01 Thread GitBox
cloud-fan commented on a change in pull request #25215: [SPARK-28445][SQL][Python] Fix error when PythonUDF is used in both group by and aggregate expression URL: https://github.com/apache/spark/pull/25215#discussion_r310002712 ## File path: sql/core/src/main/scala/org/apache/spar

[GitHub] [spark] beliefer commented on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax

2019-08-01 Thread GitBox
beliefer commented on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax URL: https://github.com/apache/spark/pull/25001#issuecomment-517578477 > plz uncoment the some existing tests for ESCAPE? > > https://github.com/apache/spark/blob/4e7a4cd20e2f6e19b45fee6bfd24071ce4

[GitHub] [spark] AmplabJenkins removed a comment on issue #25335: [SPARK-28601][CORE] Use StandardCharsets.UTF_8 instead of "UTF-8" string representation

2019-08-01 Thread GitBox
AmplabJenkins removed a comment on issue #25335: [SPARK-28601][CORE] Use StandardCharsets.UTF_8 instead of "UTF-8" string representation URL: https://github.com/apache/spark/pull/25335#issuecomment-517577499 Test FAILed. Refer to this link for build results (access rights to CI server ne

[GitHub] [spark] AmplabJenkins removed a comment on issue #25335: [SPARK-28601][CORE] Use StandardCharsets.UTF_8 instead of "UTF-8" string representation

2019-08-01 Thread GitBox
AmplabJenkins removed a comment on issue #25335: [SPARK-28601][CORE] Use StandardCharsets.UTF_8 instead of "UTF-8" string representation URL: https://github.com/apache/spark/pull/25335#issuecomment-517576437 Can one of the admins verify this patch? -

[GitHub] [spark] SparkQA removed a comment on issue #25335: [SPARK-28601][CORE] Use StandardCharsets.UTF_8 instead of "UTF-8" string representation

2019-08-01 Thread GitBox
SparkQA removed a comment on issue #25335: [SPARK-28601][CORE] Use StandardCharsets.UTF_8 instead of "UTF-8" string representation URL: https://github.com/apache/spark/pull/25335#issuecomment-517574776 **[Test build #108548 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullR

[GitHub] [spark] AmplabJenkins removed a comment on issue #25335: [SPARK-28601][CORE] Use StandardCharsets.UTF_8 instead of "UTF-8" string representation

2019-08-01 Thread GitBox
AmplabJenkins removed a comment on issue #25335: [SPARK-28601][CORE] Use StandardCharsets.UTF_8 instead of "UTF-8" string representation URL: https://github.com/apache/spark/pull/25335#issuecomment-517577491 Merged build finished. Test FAILed. --

[GitHub] [spark] AmplabJenkins commented on issue #25335: [SPARK-28601][CORE] Use StandardCharsets.UTF_8 instead of "UTF-8" string representation

2019-08-01 Thread GitBox
AmplabJenkins commented on issue #25335: [SPARK-28601][CORE] Use StandardCharsets.UTF_8 instead of "UTF-8" string representation URL: https://github.com/apache/spark/pull/25335#issuecomment-517577491 Merged build finished. Test FAILed. --

[GitHub] [spark] AmplabJenkins commented on issue #25335: [SPARK-28601][CORE] Use StandardCharsets.UTF_8 instead of "UTF-8" string representation

2019-08-01 Thread GitBox
AmplabJenkins commented on issue #25335: [SPARK-28601][CORE] Use StandardCharsets.UTF_8 instead of "UTF-8" string representation URL: https://github.com/apache/spark/pull/25335#issuecomment-517577499 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA commented on issue #25335: [SPARK-28601][CORE] Use StandardCharsets.UTF_8 instead of "UTF-8" string representation

2019-08-01 Thread GitBox
SparkQA commented on issue #25335: [SPARK-28601][CORE] Use StandardCharsets.UTF_8 instead of "UTF-8" string representation URL: https://github.com/apache/spark/pull/25335#issuecomment-517577483 **[Test build #108548 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestB

[GitHub] [spark] viirya commented on a change in pull request #25215: [SPARK-28445][SQL][Python] Fix error when PythonUDF is used in both group by and aggregate expression

2019-08-01 Thread GitBox
viirya commented on a change in pull request #25215: [SPARK-28445][SQL][Python] Fix error when PythonUDF is used in both group by and aggregate expression URL: https://github.com/apache/spark/pull/25215#discussion_r310001611 ## File path: sql/core/src/main/scala/org/apache/spark/sq

[GitHub] [spark] cloud-fan commented on issue #25308: [SPARK-28576][SQL] fix the dead lock issue when enable new adaptive execution

2019-08-01 Thread GitBox
cloud-fan commented on issue #25308: [SPARK-28576][SQL] fix the dead lock issue when enable new adaptive execution URL: https://github.com/apache/spark/pull/25308#issuecomment-517576697 I tried #25316 (rebased to the latest master) myself, and the UI works: ``` scala> spark.conf.set("

[GitHub] [spark] AmplabJenkins removed a comment on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax

2019-08-01 Thread GitBox
AmplabJenkins removed a comment on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax URL: https://github.com/apache/spark/pull/25001#issuecomment-517576638 Merged build finished. Test PASSed. This is an automate

[GitHub] [spark] AmplabJenkins removed a comment on issue #25335: [SPARK-28601][CORE] Use StandardCharsets.UTF_8 instead of "UTF-8" string representation

2019-08-01 Thread GitBox
AmplabJenkins removed a comment on issue #25335: [SPARK-28601][CORE] Use StandardCharsets.UTF_8 instead of "UTF-8" string representation URL: https://github.com/apache/spark/pull/25335#issuecomment-517576221 Can one of the admins verify this patch? -

[GitHub] [spark] AmplabJenkins commented on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax

2019-08-01 Thread GitBox
AmplabJenkins commented on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax URL: https://github.com/apache/spark/pull/25001#issuecomment-517576638 Merged build finished. Test PASSed. This is an automated messag

[GitHub] [spark] AmplabJenkins commented on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax

2019-08-01 Thread GitBox
AmplabJenkins commented on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax URL: https://github.com/apache/spark/pull/25001#issuecomment-517576644 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jen

[GitHub] [spark] AmplabJenkins removed a comment on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax

2019-08-01 Thread GitBox
AmplabJenkins removed a comment on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax URL: https://github.com/apache/spark/pull/25001#issuecomment-517576644 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley

[GitHub] [spark] AmplabJenkins commented on issue #25335: [SPARK-28601][CORE] Use StandardCharsets.UTF_8 instead of "UTF-8" string representation

2019-08-01 Thread GitBox
AmplabJenkins commented on issue #25335: [SPARK-28601][CORE] Use StandardCharsets.UTF_8 instead of "UTF-8" string representation URL: https://github.com/apache/spark/pull/25335#issuecomment-517576437 Can one of the admins verify this patch? -

[GitHub] [spark] AmplabJenkins commented on issue #25335: [SPARK-28601][CORE] Use StandardCharsets.UTF_8 instead of "UTF-8" string representation

2019-08-01 Thread GitBox
AmplabJenkins commented on issue #25335: [SPARK-28601][CORE] Use StandardCharsets.UTF_8 instead of "UTF-8" string representation URL: https://github.com/apache/spark/pull/25335#issuecomment-517576221 Can one of the admins verify this patch? -

[GitHub] [spark] dilipbiswal commented on issue #25320: [SPARK-28532][SPARK-28530][SQL][FOLLOWUP] Inline doc for FixedPoint(1) batches "Subquery" and "Join Reorder"

2019-08-01 Thread GitBox
dilipbiswal commented on issue #25320: [SPARK-28532][SPARK-28530][SQL][FOLLOWUP] Inline doc for FixedPoint(1) batches "Subquery" and "Join Reorder" URL: https://github.com/apache/spark/pull/25320#issuecomment-517576035 Just a minor comment , otherwise LGTM

[GitHub] [spark] gatorsmile commented on issue #25252: [SPARK-28510][SQL] Implement Spark's own GetFunctionsOperation

2019-08-01 Thread GitBox
gatorsmile commented on issue #25252: [SPARK-28510][SQL] Implement Spark's own GetFunctionsOperation URL: https://github.com/apache/spark/pull/25252#issuecomment-517575683 LGTM Thanks! Merged to master. This is an auto

[GitHub] [spark] SparkQA commented on issue #25335: [SPARK-28601][CORE] Use StandardCharsets.UTF_8 instead of "UTF-8" string representation

2019-08-01 Thread GitBox
SparkQA commented on issue #25335: [SPARK-28601][CORE] Use StandardCharsets.UTF_8 instead of "UTF-8" string representation URL: https://github.com/apache/spark/pull/25335#issuecomment-517574776 **[Test build #108548 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBu

[GitHub] [spark] SparkQA commented on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax

2019-08-01 Thread GitBox
SparkQA commented on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax URL: https://github.com/apache/spark/pull/25001#issuecomment-517574804 **[Test build #108549 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/108549/testReport)** for PR 250

[GitHub] [spark] SparkQA commented on issue #24938: [SPARK-27946][SQL] Hive DDL to Spark DDL conversion USING "show create table"

2019-08-01 Thread GitBox
SparkQA commented on issue #24938: [SPARK-27946][SQL] Hive DDL to Spark DDL conversion USING "show create table" URL: https://github.com/apache/spark/pull/24938#issuecomment-517574809 **[Test build #108550 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/1085

[GitHub] [spark] beliefer commented on a change in pull request #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax

2019-08-01 Thread GitBox
beliefer commented on a change in pull request #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax URL: https://github.com/apache/spark/pull/25001#discussion_r30411 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/StringUtilsSuite.scala ##

[GitHub] [spark] dilipbiswal commented on issue #24938: [SPARK-27946][SQL] Hive DDL to Spark DDL conversion USING "show create table"

2019-08-01 Thread GitBox
dilipbiswal commented on issue #24938: [SPARK-27946][SQL] Hive DDL to Spark DDL conversion USING "show create table" URL: https://github.com/apache/spark/pull/24938#issuecomment-517574534 thanks @viirya This is an automated m

[GitHub] [spark] AmplabJenkins removed a comment on issue #24938: [SPARK-27946][SQL] Hive DDL to Spark DDL conversion USING "show create table"

2019-08-01 Thread GitBox
AmplabJenkins removed a comment on issue #24938: [SPARK-27946][SQL] Hive DDL to Spark DDL conversion USING "show create table" URL: https://github.com/apache/spark/pull/24938#issuecomment-517574119 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #24938: [SPARK-27946][SQL] Hive DDL to Spark DDL conversion USING "show create table"

2019-08-01 Thread GitBox
AmplabJenkins removed a comment on issue #24938: [SPARK-27946][SQL] Hive DDL to Spark DDL conversion USING "show create table" URL: https://github.com/apache/spark/pull/24938#issuecomment-517574126 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] HeartSaVioR commented on a change in pull request #22282: [SPARK-23539][SS] Add support for Kafka headers in Structured Streaming

2019-08-01 Thread GitBox
HeartSaVioR commented on a change in pull request #22282: [SPARK-23539][SS] Add support for Kafka headers in Structured Streaming URL: https://github.com/apache/spark/pull/22282#discussion_r30196 ## File path: external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010

[GitHub] [spark] AmplabJenkins commented on issue #24938: [SPARK-27946][SQL] Hive DDL to Spark DDL conversion USING "show create table"

2019-08-01 Thread GitBox
AmplabJenkins commented on issue #24938: [SPARK-27946][SQL] Hive DDL to Spark DDL conversion USING "show create table" URL: https://github.com/apache/spark/pull/24938#issuecomment-517574119 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #24938: [SPARK-27946][SQL] Hive DDL to Spark DDL conversion USING "show create table"

2019-08-01 Thread GitBox
AmplabJenkins commented on issue #24938: [SPARK-27946][SQL] Hive DDL to Spark DDL conversion USING "show create table" URL: https://github.com/apache/spark/pull/24938#issuecomment-517574126 Test PASSed. Refer to this link for build results (access rights to CI server needed): https:

[GitHub] [spark] HeartSaVioR opened a new pull request #25335: [SPARK-28601][CORE] Use StandardCharsets.UTF_8 instead of "UTF-8" string representation

2019-08-01 Thread GitBox
HeartSaVioR opened a new pull request #25335: [SPARK-28601][CORE] Use StandardCharsets.UTF_8 instead of "UTF-8" string representation URL: https://github.com/apache/spark/pull/25335 ## What changes were proposed in this pull request? This patch tries to keep consistency whenever UTF-

[GitHub] [spark] viirya commented on issue #24938: [SPARK-27946][SQL] Hive DDL to Spark DDL conversion USING "show create table"

2019-08-01 Thread GitBox
viirya commented on issue #24938: [SPARK-27946][SQL] Hive DDL to Spark DDL conversion USING "show create table" URL: https://github.com/apache/spark/pull/24938#issuecomment-517573782 @dilipbiswal Good question! Currently, looks like we may know if it is hive transactional table by looking

[GitHub] [spark] xianyinxin commented on issue #25197: [SPARK-21067][SQL] Initialize the HdfsEncryptionShim and the underlying FileSystem(FS) e…

2019-08-01 Thread GitBox
xianyinxin commented on issue #25197: [SPARK-21067][SQL] Initialize the HdfsEncryptionShim and the underlying FileSystem(FS) e… URL: https://github.com/apache/spark/pull/25197#issuecomment-517573271 Thank you for the clarify @AngersZh . Since this solution is not good enough, cl

[GitHub] [spark] xianyinxin closed pull request #25197: [SPARK-21067][SQL] Initialize the HdfsEncryptionShim and the underlying FileSystem(FS) e…

2019-08-01 Thread GitBox
xianyinxin closed pull request #25197: [SPARK-21067][SQL] Initialize the HdfsEncryptionShim and the underlying FileSystem(FS) e… URL: https://github.com/apache/spark/pull/25197 This is an automated message from the Apache Gi

[GitHub] [spark] AmplabJenkins removed a comment on issue #25327: [SPARK-28593][CORE] Rename ShuffleClient to BlockStoreClient which more close to its usage

2019-08-01 Thread GitBox
AmplabJenkins removed a comment on issue #25327: [SPARK-28593][CORE] Rename ShuffleClient to BlockStoreClient which more close to its usage URL: https://github.com/apache/spark/pull/25327#issuecomment-517569546 Test PASSed. Refer to this link for build results (access rights to CI server

[GitHub] [spark] AmplabJenkins removed a comment on issue #25327: [SPARK-28593][CORE] Rename ShuffleClient to BlockStoreClient which more close to its usage

2019-08-01 Thread GitBox
AmplabJenkins removed a comment on issue #25327: [SPARK-28593][CORE] Rename ShuffleClient to BlockStoreClient which more close to its usage URL: https://github.com/apache/spark/pull/25327#issuecomment-517569542 Merged build finished. Test PASSed. ---

[GitHub] [spark] AmplabJenkins commented on issue #25327: [SPARK-28593][CORE] Rename ShuffleClient to BlockStoreClient which more close to its usage

2019-08-01 Thread GitBox
AmplabJenkins commented on issue #25327: [SPARK-28593][CORE] Rename ShuffleClient to BlockStoreClient which more close to its usage URL: https://github.com/apache/spark/pull/25327#issuecomment-517569546 Test PASSed. Refer to this link for build results (access rights to CI server needed)

[GitHub] [spark] AmplabJenkins commented on issue #25327: [SPARK-28593][CORE] Rename ShuffleClient to BlockStoreClient which more close to its usage

2019-08-01 Thread GitBox
AmplabJenkins commented on issue #25327: [SPARK-28593][CORE] Rename ShuffleClient to BlockStoreClient which more close to its usage URL: https://github.com/apache/spark/pull/25327#issuecomment-517569542 Merged build finished. Test PASSed. ---

[GitHub] [spark] xuanyuanking commented on a change in pull request #25327: [SPARK-28593][CORE] Rename ShuffleClient to BlockStoreClient which more close to its usage

2019-08-01 Thread GitBox
xuanyuanking commented on a change in pull request #25327: [SPARK-28593][CORE] Rename ShuffleClient to BlockStoreClient which more close to its usage URL: https://github.com/apache/spark/pull/25327#discussion_r309995027 ## File path: core/src/main/scala/org/apache/spark/storage/Bloc

[GitHub] [spark] SparkQA commented on issue #25327: [SPARK-28593][CORE] Rename ShuffleClient to BlockStoreClient which more close to its usage

2019-08-01 Thread GitBox
SparkQA commented on issue #25327: [SPARK-28593][CORE] Rename ShuffleClient to BlockStoreClient which more close to its usage URL: https://github.com/apache/spark/pull/25327#issuecomment-517568035 **[Test build #108547 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullReques

[GitHub] [spark] xuanyuanking commented on a change in pull request #25327: [SPARK-28593][CORE] Rename ShuffleClient to BlockStoreClient which more close to its usage

2019-08-01 Thread GitBox
xuanyuanking commented on a change in pull request #25327: [SPARK-28593][CORE] Rename ShuffleClient to BlockStoreClient which more close to its usage URL: https://github.com/apache/spark/pull/25327#discussion_r309994773 ## File path: core/src/main/scala/org/apache/spark/storage/Bloc

[GitHub] [spark] xuanyuanking commented on a change in pull request #25327: [SPARK-28593][CORE] Rename ShuffleClient to BlockStoreClient which more close to its usage

2019-08-01 Thread GitBox
xuanyuanking commented on a change in pull request #25327: [SPARK-28593][CORE] Rename ShuffleClient to BlockStoreClient which more close to its usage URL: https://github.com/apache/spark/pull/25327#discussion_r309994266 ## File path: core/src/main/scala/org/apache/spark/network/Blo

[GitHub] [spark] xuanyuanking commented on a change in pull request #25327: [SPARK-28593][CORE] Rename ShuffleClient to BlockStoreClient which more close to its usage

2019-08-01 Thread GitBox
xuanyuanking commented on a change in pull request #25327: [SPARK-28593][CORE] Rename ShuffleClient to BlockStoreClient which more close to its usage URL: https://github.com/apache/spark/pull/25327#discussion_r309994236 ## File path: common/network-shuffle/src/main/java/org/apache/

[GitHub] [spark] cloud-fan commented on a change in pull request #25215: [SPARK-28445][SQL][Python] Fix error when PythonUDF is used in both group by and aggregate expression

2019-08-01 Thread GitBox
cloud-fan commented on a change in pull request #25215: [SPARK-28445][SQL][Python] Fix error when PythonUDF is used in both group by and aggregate expression URL: https://github.com/apache/spark/pull/25215#discussion_r309992580 ## File path: sql/core/src/main/scala/org/apache/spar

[GitHub] [spark] AmplabJenkins removed a comment on issue #25327: [SPARK-28593][CORE] Rename ShuffleClient to BlockStoreClient which more close to its usage

2019-08-01 Thread GitBox
AmplabJenkins removed a comment on issue #25327: [SPARK-28593][CORE] Rename ShuffleClient to BlockStoreClient which more close to its usage URL: https://github.com/apache/spark/pull/25327#issuecomment-517563880 Test FAILed. Refer to this link for build results (access rights to CI server

[GitHub] [spark] cloud-fan commented on issue #25330: [SPARK-28565][SQL] DataFrameWriter saveAsTable support for V2 catalogs

2019-08-01 Thread GitBox
cloud-fan commented on issue #25330: [SPARK-28565][SQL] DataFrameWriter saveAsTable support for V2 catalogs URL: https://github.com/apache/spark/pull/25330#issuecomment-517564220 I'd like to call a discussion about the v2 session catalog. I think v2 session catalog is an extension of the b

[GitHub] [spark] SparkQA removed a comment on issue #25327: [SPARK-28593][CORE] Rename ShuffleClient to BlockStoreClient which more close to its usage

2019-08-01 Thread GitBox
SparkQA removed a comment on issue #25327: [SPARK-28593][CORE] Rename ShuffleClient to BlockStoreClient which more close to its usage URL: https://github.com/apache/spark/pull/25327#issuecomment-517542171 **[Test build #108544 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPu

[GitHub] [spark] AmplabJenkins removed a comment on issue #25327: [SPARK-28593][CORE] Rename ShuffleClient to BlockStoreClient which more close to its usage

2019-08-01 Thread GitBox
AmplabJenkins removed a comment on issue #25327: [SPARK-28593][CORE] Rename ShuffleClient to BlockStoreClient which more close to its usage URL: https://github.com/apache/spark/pull/25327#issuecomment-517563876 Merged build finished. Test FAILed. ---

[GitHub] [spark] AmplabJenkins commented on issue #25327: [SPARK-28593][CORE] Rename ShuffleClient to BlockStoreClient which more close to its usage

2019-08-01 Thread GitBox
AmplabJenkins commented on issue #25327: [SPARK-28593][CORE] Rename ShuffleClient to BlockStoreClient which more close to its usage URL: https://github.com/apache/spark/pull/25327#issuecomment-517563876 Merged build finished. Test FAILed. ---

[GitHub] [spark] AmplabJenkins commented on issue #25327: [SPARK-28593][CORE] Rename ShuffleClient to BlockStoreClient which more close to its usage

2019-08-01 Thread GitBox
AmplabJenkins commented on issue #25327: [SPARK-28593][CORE] Rename ShuffleClient to BlockStoreClient which more close to its usage URL: https://github.com/apache/spark/pull/25327#issuecomment-517563880 Test FAILed. Refer to this link for build results (access rights to CI server needed)

[GitHub] [spark] SparkQA commented on issue #25327: [SPARK-28593][CORE] Rename ShuffleClient to BlockStoreClient which more close to its usage

2019-08-01 Thread GitBox
SparkQA commented on issue #25327: [SPARK-28593][CORE] Rename ShuffleClient to BlockStoreClient which more close to its usage URL: https://github.com/apache/spark/pull/25327#issuecomment-517563610 **[Test build #108544 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullReque

[GitHub] [spark] AmplabJenkins commented on issue #25215: [SPARK-28445][SQL][Python] Fix error when PythonUDF is used in both group by and aggregate expression

2019-08-01 Thread GitBox
AmplabJenkins commented on issue #25215: [SPARK-28445][SQL][Python] Fix error when PythonUDF is used in both group by and aggregate expression URL: https://github.com/apache/spark/pull/25215#issuecomment-517563383 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #25215: [SPARK-28445][SQL][Python] Fix error when PythonUDF is used in both group by and aggregate expression

2019-08-01 Thread GitBox
AmplabJenkins removed a comment on issue #25215: [SPARK-28445][SQL][Python] Fix error when PythonUDF is used in both group by and aggregate expression URL: https://github.com/apache/spark/pull/25215#issuecomment-517563383 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #25215: [SPARK-28445][SQL][Python] Fix error when PythonUDF is used in both group by and aggregate expression

2019-08-01 Thread GitBox
AmplabJenkins removed a comment on issue #25215: [SPARK-28445][SQL][Python] Fix error when PythonUDF is used in both group by and aggregate expression URL: https://github.com/apache/spark/pull/25215#issuecomment-517563388 Test PASSed. Refer to this link for build results (access rights t

[GitHub] [spark] AmplabJenkins commented on issue #25215: [SPARK-28445][SQL][Python] Fix error when PythonUDF is used in both group by and aggregate expression

2019-08-01 Thread GitBox
AmplabJenkins commented on issue #25215: [SPARK-28445][SQL][Python] Fix error when PythonUDF is used in both group by and aggregate expression URL: https://github.com/apache/spark/pull/25215#issuecomment-517563388 Test PASSed. Refer to this link for build results (access rights to CI ser

[GitHub] [spark] viirya commented on a change in pull request #24938: [SPARK-27946][SQL] Hive DDL to Spark DDL conversion USING "show create table"

2019-08-01 Thread GitBox
viirya commented on a change in pull request #24938: [SPARK-27946][SQL] Hive DDL to Spark DDL conversion USING "show create table" URL: https://github.com/apache/spark/pull/24938#discussion_r309991310 ## File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveShowCreateTab

[GitHub] [spark] cloud-fan commented on a change in pull request #24980: [SPARK-28178][SQL] DataSourceV2: DataFrameWriter.insertInfo

2019-08-01 Thread GitBox
cloud-fan commented on a change in pull request #24980: [SPARK-28178][SQL] DataSourceV2: DataFrameWriter.insertInfo URL: https://github.com/apache/spark/pull/24980#discussion_r309991243 ## File path: sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ## @@

[GitHub] [spark] AmplabJenkins removed a comment on issue #25334: [SPARK-28598][SQL][WIP] Few date time manipulation functions does not provide versions supporting Column as input through the Datafram

2019-08-01 Thread GitBox
AmplabJenkins removed a comment on issue #25334: [SPARK-28598][SQL][WIP] Few date time manipulation functions does not provide versions supporting Column as input through the Dataframe API URL: https://github.com/apache/spark/pull/25334#issuecomment-517562312 Test PASSed. Refer to this

[GitHub] [spark] AmplabJenkins removed a comment on issue #25334: [SPARK-28598][SQL][WIP] Few date time manipulation functions does not provide versions supporting Column as input through the Datafram

2019-08-01 Thread GitBox
AmplabJenkins removed a comment on issue #25334: [SPARK-28598][SQL][WIP] Few date time manipulation functions does not provide versions supporting Column as input through the Dataframe API URL: https://github.com/apache/spark/pull/25334#issuecomment-517562304 Merged build finished. Test PA

[GitHub] [spark] SparkQA removed a comment on issue #25334: [SPARK-28598][SQL][WIP] Few date time manipulation functions does not provide versions supporting Column as input through the Dataframe API

2019-08-01 Thread GitBox
SparkQA removed a comment on issue #25334: [SPARK-28598][SQL][WIP] Few date time manipulation functions does not provide versions supporting Column as input through the Dataframe API URL: https://github.com/apache/spark/pull/25334#issuecomment-517522787 **[Test build #108539 has started](

[GitHub] [spark] AmplabJenkins commented on issue #25334: [SPARK-28598][SQL][WIP] Few date time manipulation functions does not provide versions supporting Column as input through the Dataframe API

2019-08-01 Thread GitBox
AmplabJenkins commented on issue #25334: [SPARK-28598][SQL][WIP] Few date time manipulation functions does not provide versions supporting Column as input through the Dataframe API URL: https://github.com/apache/spark/pull/25334#issuecomment-517562312 Test PASSed. Refer to this link for

[GitHub] [spark] AmplabJenkins commented on issue #25334: [SPARK-28598][SQL][WIP] Few date time manipulation functions does not provide versions supporting Column as input through the Dataframe API

2019-08-01 Thread GitBox
AmplabJenkins commented on issue #25334: [SPARK-28598][SQL][WIP] Few date time manipulation functions does not provide versions supporting Column as input through the Dataframe API URL: https://github.com/apache/spark/pull/25334#issuecomment-517562304 Merged build finished. Test PASSed. -

[GitHub] [spark] SparkQA commented on issue #25215: [SPARK-28445][SQL][Python] Fix error when PythonUDF is used in both group by and aggregate expression

2019-08-01 Thread GitBox
SparkQA commented on issue #25215: [SPARK-28445][SQL][Python] Fix error when PythonUDF is used in both group by and aggregate expression URL: https://github.com/apache/spark/pull/25215#issuecomment-517561852 **[Test build #108546 has started](https://amplab.cs.berkeley.edu/jenkins/job/Spar

[GitHub] [spark] SparkQA commented on issue #25334: [SPARK-28598][SQL][WIP] Few date time manipulation functions does not provide versions supporting Column as input through the Dataframe API

2019-08-01 Thread GitBox
SparkQA commented on issue #25334: [SPARK-28598][SQL][WIP] Few date time manipulation functions does not provide versions supporting Column as input through the Dataframe API URL: https://github.com/apache/spark/pull/25334#issuecomment-517561826 **[Test build #108539 has finished](https:/

[GitHub] [spark] viirya commented on a change in pull request #25215: [SPARK-28445][SQL][Python] Fix error when PythonUDF is used in both group by and aggregate expression

2019-08-01 Thread GitBox
viirya commented on a change in pull request #25215: [SPARK-28445][SQL][Python] Fix error when PythonUDF is used in both group by and aggregate expression URL: https://github.com/apache/spark/pull/25215#discussion_r309990350 ## File path: sql/core/src/test/scala/org/apache/spark/sq

[GitHub] [spark] yunzoud commented on a change in pull request #25307: [SPARK-28574][CORE] Allow to config different sizes for event queues

2019-08-01 Thread GitBox
yunzoud commented on a change in pull request #25307: [SPARK-28574][CORE] Allow to config different sizes for event queues URL: https://github.com/apache/spark/pull/25307#discussion_r309989426 ## File path: core/src/test/scala/org/apache/spark/scheduler/SparkListenerSuite.scala ##

[GitHub] [spark] yunzoud commented on a change in pull request #25307: [SPARK-28574][CORE] Allow to config different sizes for event queues

2019-08-01 Thread GitBox
yunzoud commented on a change in pull request #25307: [SPARK-28574][CORE] Allow to config different sizes for event queues URL: https://github.com/apache/spark/pull/25307#discussion_r309989434 ## File path: core/src/main/scala/org/apache/spark/scheduler/LiveListenerBus.scala ##

[GitHub] [spark] dilipbiswal commented on issue #24759: [SPARK-27395][SQL][WIP] Improve EXPLAIN command

2019-08-01 Thread GitBox
dilipbiswal commented on issue #24759: [SPARK-27395][SQL][WIP] Improve EXPLAIN command URL: https://github.com/apache/spark/pull/24759#issuecomment-517558722 @cloud-fan Sounds good Wenchen. This is an automated message from t

[GitHub] [spark] viirya commented on a change in pull request #25215: [SPARK-28445][SQL][Python] Fix error when PythonUDF is used in both group by and aggregate expression

2019-08-01 Thread GitBox
viirya commented on a change in pull request #25215: [SPARK-28445][SQL][Python] Fix error when PythonUDF is used in both group by and aggregate expression URL: https://github.com/apache/spark/pull/25215#discussion_r309988383 ## File path: sql/catalyst/src/main/scala/org/apache/spar

[GitHub] [spark] itsvikramagr edited a comment on issue #24922: [SPARK-28120][SS] Rocksdb state storage implementation

2019-08-01 Thread GitBox
itsvikramagr edited a comment on issue #24922: [SPARK-28120][SS] Rocksdb state storage implementation URL: https://github.com/apache/spark/pull/24922#issuecomment-517556064 > I agree keeping state in memory is not scalable, and the result looks promising. It might be better to have anothe

[GitHub] [spark] itsvikramagr commented on issue #24922: [SPARK-28120][SS] Rocksdb state storage implementation

2019-08-01 Thread GitBox
itsvikramagr commented on issue #24922: [SPARK-28120][SS] Rocksdb state storage implementation URL: https://github.com/apache/spark/pull/24922#issuecomment-517556064 > I agree keeping state in memory is not scalable, and the result looks promising. It might be better to have another kind

[GitHub] [spark] yunzoud commented on a change in pull request #25307: [SPARK-28574][CORE] Allow to config different sizes for event queues

2019-08-01 Thread GitBox
yunzoud commented on a change in pull request #25307: [SPARK-28574][CORE] Allow to config different sizes for event queues URL: https://github.com/apache/spark/pull/25307#discussion_r309986249 ## File path: core/src/main/scala/org/apache/spark/scheduler/AsyncEventQueue.scala ##

[GitHub] [spark] AmplabJenkins removed a comment on issue #24623: [SPARK-27739][SQL] df.persist should save stats from optimized plan

2019-08-01 Thread GitBox
AmplabJenkins removed a comment on issue #24623: [SPARK-27739][SQL] df.persist should save stats from optimized plan URL: https://github.com/apache/spark/pull/24623#issuecomment-517554340 Merged build finished. Test PASSed. T

[GitHub] [spark] AmplabJenkins removed a comment on issue #24623: [SPARK-27739][SQL] df.persist should save stats from optimized plan

2019-08-01 Thread GitBox
AmplabJenkins removed a comment on issue #24623: [SPARK-27739][SQL] df.persist should save stats from optimized plan URL: https://github.com/apache/spark/pull/24623#issuecomment-517554344 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://a

[GitHub] [spark] AmplabJenkins commented on issue #24623: [SPARK-27739][SQL] df.persist should save stats from optimized plan

2019-08-01 Thread GitBox
AmplabJenkins commented on issue #24623: [SPARK-27739][SQL] df.persist should save stats from optimized plan URL: https://github.com/apache/spark/pull/24623#issuecomment-517554340 Merged build finished. Test PASSed. This is a

[GitHub] [spark] AmplabJenkins commented on issue #24623: [SPARK-27739][SQL] df.persist should save stats from optimized plan

2019-08-01 Thread GitBox
AmplabJenkins commented on issue #24623: [SPARK-27739][SQL] df.persist should save stats from optimized plan URL: https://github.com/apache/spark/pull/24623#issuecomment-517554344 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs

[GitHub] [spark] xianyinxin commented on a change in pull request #25115: [SPARK-28351][SQL] Support DELETE in DataSource V2

2019-08-01 Thread GitBox
xianyinxin commented on a change in pull request #25115: [SPARK-28351][SQL] Support DELETE in DataSource V2 URL: https://github.com/apache/spark/pull/25115#discussion_r309985700 ## File path: sql/core/src/test/scala/org/apache/spark/sql/sources/v2/TestInMemoryTableCatalog.scala ##

[GitHub] [spark] SparkQA removed a comment on issue #24623: [SPARK-27739][SQL] df.persist should save stats from optimized plan

2019-08-01 Thread GitBox
SparkQA removed a comment on issue #24623: [SPARK-27739][SQL] df.persist should save stats from optimized plan URL: https://github.com/apache/spark/pull/24623#issuecomment-517520016 **[Test build #108538 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/108538

[GitHub] [spark] SparkQA commented on issue #24623: [SPARK-27739][SQL] df.persist should save stats from optimized plan

2019-08-01 Thread GitBox
SparkQA commented on issue #24623: [SPARK-27739][SQL] df.persist should save stats from optimized plan URL: https://github.com/apache/spark/pull/24623#issuecomment-517553897 **[Test build #108538 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/108538/testRe

[GitHub] [spark] xianyinxin commented on a change in pull request #25115: [SPARK-28351][SQL] Support DELETE in DataSource V2

2019-08-01 Thread GitBox
xianyinxin commented on a change in pull request #25115: [SPARK-28351][SQL] Support DELETE in DataSource V2 URL: https://github.com/apache/spark/pull/25115#discussion_r309985171 ## File path: sql/core/src/test/scala/org/apache/spark/sql/sources/v2/TestInMemoryTableCatalog.scala ##

[GitHub] [spark] xianyinxin commented on a change in pull request #25115: [SPARK-28351][SQL] Support DELETE in DataSource V2

2019-08-01 Thread GitBox
xianyinxin commented on a change in pull request #25115: [SPARK-28351][SQL] Support DELETE in DataSource V2 URL: https://github.com/apache/spark/pull/25115#discussion_r309984996 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/V2WriteSupportCheck.

[GitHub] [spark] xianyinxin commented on a change in pull request #25115: [SPARK-28351][SQL] Support DELETE in DataSource V2

2019-08-01 Thread GitBox
xianyinxin commented on a change in pull request #25115: [SPARK-28351][SQL] Support DELETE in DataSource V2 URL: https://github.com/apache/spark/pull/25115#discussion_r309985017 ## File path: sql/core/src/test/scala/org/apache/spark/sql/sources/v2/TestInMemoryTableCatalog.scala ##

[GitHub] [spark] xianyinxin commented on a change in pull request #25115: [SPARK-28351][SQL] Support DELETE in DataSource V2

2019-08-01 Thread GitBox
xianyinxin commented on a change in pull request #25115: [SPARK-28351][SQL] Support DELETE in DataSource V2 URL: https://github.com/apache/spark/pull/25115#discussion_r309984823 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceResolution.sc

[GitHub] [spark] xianyinxin commented on a change in pull request #25115: [SPARK-28351][SQL] Support DELETE in DataSource V2

2019-08-01 Thread GitBox
xianyinxin commented on a change in pull request #25115: [SPARK-28351][SQL] Support DELETE in DataSource V2 URL: https://github.com/apache/spark/pull/25115#discussion_r309984947 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DeleteFromTableExec.

[GitHub] [spark] gengliangwang commented on a change in pull request #25300: [SPARK-28503][SQL] Return null result on cast an out-of-range value to a integral type

2019-08-01 Thread GitBox
gengliangwang commented on a change in pull request #25300: [SPARK-28503][SQL] Return null result on cast an out-of-range value to a integral type URL: https://github.com/apache/spark/pull/25300#discussion_r309984934 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/ca

[GitHub] [spark] JkSelf commented on issue #25308: [SPARK-28576][SQL] fix the dead lock issue when enable new adaptive execution

2019-08-01 Thread GitBox
JkSelf commented on issue #25308: [SPARK-28576][SQL] fix the dead lock issue when enable new adaptive execution URL: https://github.com/apache/spark/pull/25308#issuecomment-517552574 @cloud-fan Got it, thanks. But it seems the main query does not update the subquery in my test with [PR#25

[GitHub] [spark] SparkQA commented on issue #25115: [SPARK-28351][SQL] Support DELETE in DataSource V2

2019-08-01 Thread GitBox
SparkQA commented on issue #25115: [SPARK-28351][SQL] Support DELETE in DataSource V2 URL: https://github.com/apache/spark/pull/25115#issuecomment-517552170 **[Test build #108545 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/108545/testReport)** for PR 25

[GitHub] [spark] xianyinxin commented on a change in pull request #25115: [SPARK-28351][SQL] Support DELETE in DataSource V2

2019-08-01 Thread GitBox
xianyinxin commented on a change in pull request #25115: [SPARK-28351][SQL] Support DELETE in DataSource V2 URL: https://github.com/apache/spark/pull/25115#discussion_r309984091 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceResolution.sc

[GitHub] [spark] xianyinxin commented on a change in pull request #25115: [SPARK-28351][SQL] Support DELETE in DataSource V2

2019-08-01 Thread GitBox
xianyinxin commented on a change in pull request #25115: [SPARK-28351][SQL] Support DELETE in DataSource V2 URL: https://github.com/apache/spark/pull/25115#discussion_r309983893 ## File path: sql/catalyst/src/main/java/org/apache/spark/sql/sources/v2/SupportsDelete.java ##

[GitHub] [spark] AmplabJenkins removed a comment on issue #25115: [SPARK-28351][SQL] Support DELETE in DataSource V2

2019-08-01 Thread GitBox
AmplabJenkins removed a comment on issue #25115: [SPARK-28351][SQL] Support DELETE in DataSource V2 URL: https://github.com/apache/spark/pull/25115#issuecomment-517551775 Merged build finished. Test PASSed. This is an automat

  1   2   3   4   5   6   7   8   9   >