[GitHub] [spark] yaooqinn commented on a change in pull request #26465: [SPARK-29390][SQL] Add the justify_days(), justify_hours() and justif_interval() functions

2019-11-11 Thread GitBox
yaooqinn commented on a change in pull request #26465: [SPARK-29390][SQL] Add the justify_days(), justify_hours() and justif_interval() functions URL: https://github.com/apache/spark/pull/26465#discussion_r345057918 ## File path:

[GitHub] [spark] AmplabJenkins removed a comment on issue #26425: [SPARK-29789][SQL] should not parse the bucket column name when creating v2 tables

2019-11-11 Thread GitBox
AmplabJenkins removed a comment on issue #26425: [SPARK-29789][SQL] should not parse the bucket column name when creating v2 tables URL: https://github.com/apache/spark/pull/26425#issuecomment-552777507 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #26425: [SPARK-29789][SQL] should not parse the bucket column name when creating v2 tables

2019-11-11 Thread GitBox
AmplabJenkins removed a comment on issue #26425: [SPARK-29789][SQL] should not parse the bucket column name when creating v2 tables URL: https://github.com/apache/spark/pull/26425#issuecomment-552777515 Test PASSed. Refer to this link for build results (access rights to CI server

[GitHub] [spark] AmplabJenkins commented on issue #26425: [SPARK-29789][SQL] should not parse the bucket column name when creating v2 tables

2019-11-11 Thread GitBox
AmplabJenkins commented on issue #26425: [SPARK-29789][SQL] should not parse the bucket column name when creating v2 tables URL: https://github.com/apache/spark/pull/26425#issuecomment-552777515 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #26425: [SPARK-29789][SQL] should not parse the bucket column name when creating v2 tables

2019-11-11 Thread GitBox
AmplabJenkins commented on issue #26425: [SPARK-29789][SQL] should not parse the bucket column name when creating v2 tables URL: https://github.com/apache/spark/pull/26425#issuecomment-552777507 Merged build finished. Test PASSed.

[GitHub] [spark] SparkQA commented on issue #26425: [SPARK-29789][SQL] should not parse the bucket column name when creating v2 tables

2019-11-11 Thread GitBox
SparkQA commented on issue #26425: [SPARK-29789][SQL] should not parse the bucket column name when creating v2 tables URL: https://github.com/apache/spark/pull/26425#issuecomment-552776357 **[Test build #113610 has

[GitHub] [spark] SparkQA removed a comment on issue #26425: [SPARK-29789][SQL] should not parse the bucket column name when creating v2 tables

2019-11-11 Thread GitBox
SparkQA removed a comment on issue #26425: [SPARK-29789][SQL] should not parse the bucket column name when creating v2 tables URL: https://github.com/apache/spark/pull/26425#issuecomment-552724928 **[Test build #113610 has

[GitHub] [spark] cloud-fan commented on issue #26461: [SPARK-29831][SQL] Scan Hive partitioned table should not dramatically increase data parallelism

2019-11-11 Thread GitBox
cloud-fan commented on issue #26461: [SPARK-29831][SQL] Scan Hive partitioned table should not dramatically increase data parallelism URL: https://github.com/apache/spark/pull/26461#issuecomment-552776318 > Maybe we can also rely on maxSplitBytes in Hive Scan and decide parallelism?

[GitHub] [spark] cloud-fan commented on a change in pull request #26463: [SPARK-29837][SQL] PostgreSQL dialect: cast to boolean

2019-11-11 Thread GitBox
cloud-fan commented on a change in pull request #26463: [SPARK-29837][SQL] PostgreSQL dialect: cast to boolean URL: https://github.com/apache/spark/pull/26463#discussion_r345055743 ## File path:

[GitHub] [spark] cloud-fan commented on a change in pull request #26463: [SPARK-29837][SQL] PostgreSQL dialect: cast to boolean

2019-11-11 Thread GitBox
cloud-fan commented on a change in pull request #26463: [SPARK-29837][SQL] PostgreSQL dialect: cast to boolean URL: https://github.com/apache/spark/pull/26463#discussion_r345055219 ## File path:

[GitHub] [spark] cloud-fan commented on a change in pull request #26463: [SPARK-29837][SQL] PostgreSQL dialect: cast to boolean

2019-11-11 Thread GitBox
cloud-fan commented on a change in pull request #26463: [SPARK-29837][SQL] PostgreSQL dialect: cast to boolean URL: https://github.com/apache/spark/pull/26463#discussion_r345054980 ## File path:

[GitHub] [spark] cloud-fan commented on a change in pull request #26463: [SPARK-29837][SQL] PostgreSQL dialect: cast to boolean

2019-11-11 Thread GitBox
cloud-fan commented on a change in pull request #26463: [SPARK-29837][SQL] PostgreSQL dialect: cast to boolean URL: https://github.com/apache/spark/pull/26463#discussion_r345054707 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala

[GitHub] [spark] cloud-fan commented on a change in pull request #26437: [SPARK-29800][SQL] Plan non-correlated Exists 's subquery in PlanSubqueries

2019-11-11 Thread GitBox
cloud-fan commented on a change in pull request #26437: [SPARK-29800][SQL] Plan non-correlated Exists 's subquery in PlanSubqueries URL: https://github.com/apache/spark/pull/26437#discussion_r345054174 ## File path:

[GitHub] [spark] viirya commented on issue #26461: [SPARK-29831][SQL] Scan Hive partitioned table should not dramatically increase data parallelism

2019-11-11 Thread GitBox
viirya commented on issue #26461: [SPARK-29831][SQL] Scan Hive partitioned table should not dramatically increase data parallelism URL: https://github.com/apache/spark/pull/26461#issuecomment-552774504 > spark.default.parallelism doesn't really affect data source scan AFAIK. We do have a

[GitHub] [spark] cloud-fan commented on a change in pull request #26437: [SPARK-29800][SQL] Plan non-correlated Exists 's subquery in PlanSubqueries

2019-11-11 Thread GitBox
cloud-fan commented on a change in pull request #26437: [SPARK-29800][SQL] Plan non-correlated Exists 's subquery in PlanSubqueries URL: https://github.com/apache/spark/pull/26437#discussion_r345053263 ## File path:

[GitHub] [spark] cloud-fan commented on a change in pull request #26437: [SPARK-29800][SQL] Plan non-correlated Exists 's subquery in PlanSubqueries

2019-11-11 Thread GitBox
cloud-fan commented on a change in pull request #26437: [SPARK-29800][SQL] Plan non-correlated Exists 's subquery in PlanSubqueries URL: https://github.com/apache/spark/pull/26437#discussion_r345052924 ## File path:

[GitHub] [spark] AmplabJenkins removed a comment on issue #26463: [SPARK-29837][SQL] PostgreSQL dialect: cast to boolean

2019-11-11 Thread GitBox
AmplabJenkins removed a comment on issue #26463: [SPARK-29837][SQL] PostgreSQL dialect: cast to boolean URL: https://github.com/apache/spark/pull/26463#issuecomment-552772595 Merged build finished. Test PASSed. This is an

[GitHub] [spark] AmplabJenkins removed a comment on issue #26463: [SPARK-29837][SQL] PostgreSQL dialect: cast to boolean

2019-11-11 Thread GitBox
AmplabJenkins removed a comment on issue #26463: [SPARK-29837][SQL] PostgreSQL dialect: cast to boolean URL: https://github.com/apache/spark/pull/26463#issuecomment-552772600 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] cloud-fan commented on a change in pull request #26437: [SPARK-29800][SQL] Plan non-correlated Exists 's subquery in PlanSubqueries

2019-11-11 Thread GitBox
cloud-fan commented on a change in pull request #26437: [SPARK-29800][SQL] Plan non-correlated Exists 's subquery in PlanSubqueries URL: https://github.com/apache/spark/pull/26437#discussion_r345052634 ## File path:

[GitHub] [spark] cloud-fan commented on a change in pull request #26437: [SPARK-29800][SQL] Plan non-correlated Exists 's subquery in PlanSubqueries

2019-11-11 Thread GitBox
cloud-fan commented on a change in pull request #26437: [SPARK-29800][SQL] Plan non-correlated Exists 's subquery in PlanSubqueries URL: https://github.com/apache/spark/pull/26437#discussion_r345052326 ## File path:

[GitHub] [spark] AmplabJenkins commented on issue #26463: [SPARK-29837][SQL] PostgreSQL dialect: cast to boolean

2019-11-11 Thread GitBox
AmplabJenkins commented on issue #26463: [SPARK-29837][SQL] PostgreSQL dialect: cast to boolean URL: https://github.com/apache/spark/pull/26463#issuecomment-552772595 Merged build finished. Test PASSed. This is an automated

[GitHub] [spark] AmplabJenkins commented on issue #26463: [SPARK-29837][SQL] PostgreSQL dialect: cast to boolean

2019-11-11 Thread GitBox
AmplabJenkins commented on issue #26463: [SPARK-29837][SQL] PostgreSQL dialect: cast to boolean URL: https://github.com/apache/spark/pull/26463#issuecomment-552772600 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] cloud-fan commented on a change in pull request #26465: [SPARK-29390][SQL] Add the justify_days(), justify_hours() and justif_interval() functions

2019-11-11 Thread GitBox
cloud-fan commented on a change in pull request #26465: [SPARK-29390][SQL] Add the justify_days(), justify_hours() and justif_interval() functions URL: https://github.com/apache/spark/pull/26465#discussion_r345051840 ## File path:

[GitHub] [spark] cloud-fan commented on a change in pull request #26465: [SPARK-29390][SQL] Add the justify_days(), justify_hours() and justif_interval() functions

2019-11-11 Thread GitBox
cloud-fan commented on a change in pull request #26465: [SPARK-29390][SQL] Add the justify_days(), justify_hours() and justif_interval() functions URL: https://github.com/apache/spark/pull/26465#discussion_r345051327 ## File path:

[GitHub] [spark] AmplabJenkins removed a comment on issue #26480: [SPARK-29808][ML][PYTHON] StopWordsRemover should support multi-cols

2019-11-11 Thread GitBox
AmplabJenkins removed a comment on issue #26480: [SPARK-29808][ML][PYTHON] StopWordsRemover should support multi-cols URL: https://github.com/apache/spark/pull/26480#issuecomment-552769456 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #26480: [SPARK-29808][ML][PYTHON] StopWordsRemover should support multi-cols

2019-11-11 Thread GitBox
AmplabJenkins removed a comment on issue #26480: [SPARK-29808][ML][PYTHON] StopWordsRemover should support multi-cols URL: https://github.com/apache/spark/pull/26480#issuecomment-552769465 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #26480: [SPARK-29808][ML][PYTHON] StopWordsRemover should support multi-cols

2019-11-11 Thread GitBox
AmplabJenkins commented on issue #26480: [SPARK-29808][ML][PYTHON] StopWordsRemover should support multi-cols URL: https://github.com/apache/spark/pull/26480#issuecomment-552769456 Merged build finished. Test PASSed. This is

[GitHub] [spark] AngersZhuuuu commented on issue #26406: [SPARK-29145][SQL][FOLLOW-UP] Move tests from `SubquerySuite` to `subquery/in-subquery/in-joins.sql`

2019-11-11 Thread GitBox
AngersZh commented on issue #26406: [SPARK-29145][SQL][FOLLOW-UP] Move tests from `SubquerySuite` to `subquery/in-subquery/in-joins.sql` URL: https://github.com/apache/spark/pull/26406#issuecomment-552769401 @maropu Passed test, any more work to do?

[GitHub] [spark] AmplabJenkins commented on issue #26480: [SPARK-29808][ML][PYTHON] StopWordsRemover should support multi-cols

2019-11-11 Thread GitBox
AmplabJenkins commented on issue #26480: [SPARK-29808][ML][PYTHON] StopWordsRemover should support multi-cols URL: https://github.com/apache/spark/pull/26480#issuecomment-552769465 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] cloud-fan commented on issue #26461: [SPARK-29831][SQL] Scan Hive partitioned table should not dramatically increase data parallelism

2019-11-11 Thread GitBox
cloud-fan commented on issue #26461: [SPARK-29831][SQL] Scan Hive partitioned table should not dramatically increase data parallelism URL: https://github.com/apache/spark/pull/26461#issuecomment-552769026 I agree with the problem mentioned by @viirya , but I'm not sure this config is the

[GitHub] [spark] SparkQA removed a comment on issue #26480: [SPARK-29808][ML][PYTHON] StopWordsRemover should support multi-cols

2019-11-11 Thread GitBox
SparkQA removed a comment on issue #26480: [SPARK-29808][ML][PYTHON] StopWordsRemover should support multi-cols URL: https://github.com/apache/spark/pull/26480#issuecomment-552751882 **[Test build #113614 has

[GitHub] [spark] SparkQA commented on issue #26480: [SPARK-29808][ML][PYTHON] StopWordsRemover should support multi-cols

2019-11-11 Thread GitBox
SparkQA commented on issue #26480: [SPARK-29808][ML][PYTHON] StopWordsRemover should support multi-cols URL: https://github.com/apache/spark/pull/26480#issuecomment-552768706 **[Test build #113614 has

[GitHub] [spark] cloud-fan commented on issue #26418: [SPARK-29783][SQL] Support SQL Standard/ISO_8601 output style for interval type

2019-11-11 Thread GitBox
cloud-fan commented on issue #26418: [SPARK-29783][SQL] Support SQL Standard/ISO_8601 output style for interval type URL: https://github.com/apache/spark/pull/26418#issuecomment-552766814 the part I worry most is the SQL STANDARD style. For `-2 day 23 hour`, if we use SQL STANDARD style

[GitHub] [spark] Ngone51 commented on a change in pull request #26463: [SPARK-29837][SQL] PostgreSQL dialect: cast to boolean

2019-11-11 Thread GitBox
Ngone51 commented on a change in pull request #26463: [SPARK-29837][SQL] PostgreSQL dialect: cast to boolean URL: https://github.com/apache/spark/pull/26463#discussion_r345045212 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala

[GitHub] [spark] cloud-fan commented on a change in pull request #26479: [SPARK-29855][SQL] typed literals with negative sign with proper result or exception

2019-11-11 Thread GitBox
cloud-fan commented on a change in pull request #26479: [SPARK-29855][SQL] typed literals with negative sign with proper result or exception URL: https://github.com/apache/spark/pull/26479#discussion_r345044456 ## File path:

[GitHub] [spark] AmplabJenkins removed a comment on issue #26481: [WIP][SPARK-29840][SQL] PostgreSQL dialect: cast to integer

2019-11-11 Thread GitBox
AmplabJenkins removed a comment on issue #26481: [WIP][SPARK-29840][SQL] PostgreSQL dialect: cast to integer URL: https://github.com/apache/spark/pull/26481#issuecomment-552764490 Can one of the admins verify this patch?

[GitHub] [spark] AmplabJenkins commented on issue #26481: [WIP][SPARK-29840][SQL] PostgreSQL dialect: cast to integer

2019-11-11 Thread GitBox
AmplabJenkins commented on issue #26481: [WIP][SPARK-29840][SQL] PostgreSQL dialect: cast to integer URL: https://github.com/apache/spark/pull/26481#issuecomment-552765089 Can one of the admins verify this patch? This is an

[GitHub] [spark] cloud-fan commented on a change in pull request #26219: [SPARK-29563][SQL] CREATE TABLE LIKE should look up catalog/table like v2 commands

2019-11-11 Thread GitBox
cloud-fan commented on a change in pull request #26219: [SPARK-29563][SQL] CREATE TABLE LIKE should look up catalog/table like v2 commands URL: https://github.com/apache/spark/pull/26219#discussion_r345043711 ## File path:

[GitHub] [spark] cloud-fan commented on a change in pull request #26219: [SPARK-29563][SQL] CREATE TABLE LIKE should look up catalog/table like v2 commands

2019-11-11 Thread GitBox
cloud-fan commented on a change in pull request #26219: [SPARK-29563][SQL] CREATE TABLE LIKE should look up catalog/table like v2 commands URL: https://github.com/apache/spark/pull/26219#discussion_r345043711 ## File path:

[GitHub] [spark] AmplabJenkins commented on issue #26481: [WIP][SPARK-29840][SQL] PostgreSQL dialect: cast to integer

2019-11-11 Thread GitBox
AmplabJenkins commented on issue #26481: [WIP][SPARK-29840][SQL] PostgreSQL dialect: cast to integer URL: https://github.com/apache/spark/pull/26481#issuecomment-552764490 Can one of the admins verify this patch? This is an

[GitHub] [spark] cloud-fan commented on a change in pull request #26219: [SPARK-29563][SQL] CREATE TABLE LIKE should look up catalog/table like v2 commands

2019-11-11 Thread GitBox
cloud-fan commented on a change in pull request #26219: [SPARK-29563][SQL] CREATE TABLE LIKE should look up catalog/table like v2 commands URL: https://github.com/apache/spark/pull/26219#discussion_r345042723 ## File path:

[GitHub] [spark] cloud-fan commented on a change in pull request #26219: [SPARK-29563][SQL] CREATE TABLE LIKE should look up catalog/table like v2 commands

2019-11-11 Thread GitBox
cloud-fan commented on a change in pull request #26219: [SPARK-29563][SQL] CREATE TABLE LIKE should look up catalog/table like v2 commands URL: https://github.com/apache/spark/pull/26219#discussion_r345042409 ## File path:

[GitHub] [spark] amanomer opened a new pull request #26481: [WIP][SPARK-29838][SQL] PostgreSQL dialect: cast to integer

2019-11-11 Thread GitBox
amanomer opened a new pull request #26481: [WIP][SPARK-29838][SQL] PostgreSQL dialect: cast to integer URL: https://github.com/apache/spark/pull/26481 ### What changes were proposed in this pull request? To make SparkSQL's `cast as int` behavior consistent with PostgreSQL when

[GitHub] [spark] MaxGekk commented on a change in pull request #26479: [SPARK-29855][SQL] typed literals with negative sign with proper result or exception

2019-11-11 Thread GitBox
MaxGekk commented on a change in pull request #26479: [SPARK-29855][SQL] typed literals with negative sign with proper result or exception URL: https://github.com/apache/spark/pull/26479#discussion_r345040668 ## File path:

[GitHub] [spark] MaxGekk commented on a change in pull request #26479: [SPARK-29855][SQL] typed literals with negative sign with proper result or exception

2019-11-11 Thread GitBox
MaxGekk commented on a change in pull request #26479: [SPARK-29855][SQL] typed literals with negative sign with proper result or exception URL: https://github.com/apache/spark/pull/26479#discussion_r345040291 ## File path:

[GitHub] [spark] cloud-fan commented on issue #26479: [SPARK-29855][SQL] typed literals with negative sign with proper result or exception

2019-11-11 Thread GitBox
cloud-fan commented on issue #26479: [SPARK-29855][SQL] typed literals with negative sign with proper result or exception URL: https://github.com/apache/spark/pull/26479#issuecomment-552760958 looks reasonable to me. Is it a common behavior in other DBs like pgsql?

[GitHub] [spark] cloud-fan commented on a change in pull request #26479: [SPARK-29855][SQL] typed literals with negative sign with proper result or exception

2019-11-11 Thread GitBox
cloud-fan commented on a change in pull request #26479: [SPARK-29855][SQL] typed literals with negative sign with proper result or exception URL: https://github.com/apache/spark/pull/26479#discussion_r345040238 ## File path:

[GitHub] [spark] cloud-fan commented on a change in pull request #26463: [SPARK-29837][SQL] PostgreSQL dialect: cast to boolean

2019-11-11 Thread GitBox
cloud-fan commented on a change in pull request #26463: [SPARK-29837][SQL] PostgreSQL dialect: cast to boolean URL: https://github.com/apache/spark/pull/26463#discussion_r345039472 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala

[GitHub] [spark] cloud-fan commented on a change in pull request #26219: [SPARK-29563][SQL] CREATE TABLE LIKE should look up catalog/table like v2 commands

2019-11-11 Thread GitBox
cloud-fan commented on a change in pull request #26219: [SPARK-29563][SQL] CREATE TABLE LIKE should look up catalog/table like v2 commands URL: https://github.com/apache/spark/pull/26219#discussion_r345038983 ## File path:

[GitHub] [spark] 07ARB commented on issue #26477: [SPARK-29776][SQL] rpad returning invalid value when parameter is empty

2019-11-11 Thread GitBox
07ARB commented on issue #26477: [SPARK-29776][SQL] rpad returning invalid value when parameter is empty URL: https://github.com/apache/spark/pull/26477#issuecomment-552759351 @HyukjinKwon , please verify this PR. This is an

[GitHub] [spark] Ngone51 commented on a change in pull request #26463: [SPARK-29837][SQL] PostgreSQL dialect: cast to boolean

2019-11-11 Thread GitBox
Ngone51 commented on a change in pull request #26463: [SPARK-29837][SQL] PostgreSQL dialect: cast to boolean URL: https://github.com/apache/spark/pull/26463#discussion_r345035046 ## File path:

[GitHub] [spark] AmplabJenkins removed a comment on issue #26479: [SPARK-29855][SQL] typed literals with negative sign with proper result or exception

2019-11-11 Thread GitBox
AmplabJenkins removed a comment on issue #26479: [SPARK-29855][SQL] typed literals with negative sign with proper result or exception URL: https://github.com/apache/spark/pull/26479#issuecomment-552753984 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #26479: [SPARK-29855][SQL] typed literals with negative sign with proper result or exception

2019-11-11 Thread GitBox
AmplabJenkins removed a comment on issue #26479: [SPARK-29855][SQL] typed literals with negative sign with proper result or exception URL: https://github.com/apache/spark/pull/26479#issuecomment-552753992 Test PASSed. Refer to this link for build results (access rights to CI server

[GitHub] [spark] AmplabJenkins commented on issue #26479: [SPARK-29855][SQL] typed literals with negative sign with proper result or exception

2019-11-11 Thread GitBox
AmplabJenkins commented on issue #26479: [SPARK-29855][SQL] typed literals with negative sign with proper result or exception URL: https://github.com/apache/spark/pull/26479#issuecomment-552753992 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #26479: [SPARK-29855][SQL] typed literals with negative sign with proper result or exception

2019-11-11 Thread GitBox
AmplabJenkins commented on issue #26479: [SPARK-29855][SQL] typed literals with negative sign with proper result or exception URL: https://github.com/apache/spark/pull/26479#issuecomment-552753984 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #26480: [SPARK-29808][ML][PYTHON] StopWordsRemover should support multi-cols

2019-11-11 Thread GitBox
AmplabJenkins removed a comment on issue #26480: [SPARK-29808][ML][PYTHON] StopWordsRemover should support multi-cols URL: https://github.com/apache/spark/pull/26480#issuecomment-552753705 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #26480: [SPARK-29808][ML][PYTHON] StopWordsRemover should support multi-cols

2019-11-11 Thread GitBox
AmplabJenkins removed a comment on issue #26480: [SPARK-29808][ML][PYTHON] StopWordsRemover should support multi-cols URL: https://github.com/apache/spark/pull/26480#issuecomment-552753711 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #26478: [SPARK-29853][SQL]lpad returning empty instead of NULL for empty pad …

2019-11-11 Thread GitBox
AmplabJenkins removed a comment on issue #26478: [SPARK-29853][SQL]lpad returning empty instead of NULL for empty pad … URL: https://github.com/apache/spark/pull/26478#issuecomment-552752714 Can one of the admins verify this patch?

[GitHub] [spark] AmplabJenkins commented on issue #26480: [SPARK-29808][ML][PYTHON] StopWordsRemover should support multi-cols

2019-11-11 Thread GitBox
AmplabJenkins commented on issue #26480: [SPARK-29808][ML][PYTHON] StopWordsRemover should support multi-cols URL: https://github.com/apache/spark/pull/26480#issuecomment-552753711 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #26478: [SPARK-29853][SQL]lpad returning empty instead of NULL for empty pad …

2019-11-11 Thread GitBox
AmplabJenkins commented on issue #26478: [SPARK-29853][SQL]lpad returning empty instead of NULL for empty pad … URL: https://github.com/apache/spark/pull/26478#issuecomment-552753596 Can one of the admins verify this patch?

[GitHub] [spark] AmplabJenkins commented on issue #26480: [SPARK-29808][ML][PYTHON] StopWordsRemover should support multi-cols

2019-11-11 Thread GitBox
AmplabJenkins commented on issue #26480: [SPARK-29808][ML][PYTHON] StopWordsRemover should support multi-cols URL: https://github.com/apache/spark/pull/26480#issuecomment-552753705 Merged build finished. Test PASSed. This is

[GitHub] [spark] AmplabJenkins commented on issue #26478: [SPARK-29853][SQL]lpad returning empty instead of NULL for empty pad …

2019-11-11 Thread GitBox
AmplabJenkins commented on issue #26478: [SPARK-29853][SQL]lpad returning empty instead of NULL for empty pad … URL: https://github.com/apache/spark/pull/26478#issuecomment-552752714 Can one of the admins verify this patch?

[GitHub] [spark] AmplabJenkins removed a comment on issue #26477: [SPARK-29776][SQL] rpad returning invalid value when parameter is empty

2019-11-11 Thread GitBox
AmplabJenkins removed a comment on issue #26477: [SPARK-29776][SQL] rpad returning invalid value when parameter is empty URL: https://github.com/apache/spark/pull/26477#issuecomment-552743106 Can one of the admins verify this patch?

[GitHub] [spark] AmplabJenkins commented on issue #26477: [SPARK-29776][SQL] rpad returning invalid value when parameter is empty

2019-11-11 Thread GitBox
AmplabJenkins commented on issue #26477: [SPARK-29776][SQL] rpad returning invalid value when parameter is empty URL: https://github.com/apache/spark/pull/26477#issuecomment-552752723 Can one of the admins verify this patch?

[GitHub] [spark] SparkQA commented on issue #26479: [SPARK-29855][SQL] typed literals with negative sign with proper result or exception

2019-11-11 Thread GitBox
SparkQA commented on issue #26479: [SPARK-29855][SQL] typed literals with negative sign with proper result or exception URL: https://github.com/apache/spark/pull/26479#issuecomment-552752803 **[Test build #113615 has

[GitHub] [spark] SparkQA commented on issue #26480: [SPARK-29808][ML][PYTHON] StopWordsRemover should support multi-cols

2019-11-11 Thread GitBox
SparkQA commented on issue #26480: [SPARK-29808][ML][PYTHON] StopWordsRemover should support multi-cols URL: https://github.com/apache/spark/pull/26480#issuecomment-552751882 **[Test build #113614 has

[GitHub] [spark] Ngone51 commented on a change in pull request #26463: [SPARK-29837][SQL] PostgreSQL dialect: cast to boolean

2019-11-11 Thread GitBox
Ngone51 commented on a change in pull request #26463: [SPARK-29837][SQL] PostgreSQL dialect: cast to boolean URL: https://github.com/apache/spark/pull/26463#discussion_r345030984 ## File path:

[GitHub] [spark] amanomer commented on issue #26317: [SPARK-29628][SQL] Forcibly create a temporary view in CREATE VIEW if referencing a temporary view

2019-11-11 Thread GitBox
amanomer commented on issue #26317: [SPARK-29628][SQL] Forcibly create a temporary view in CREATE VIEW if referencing a temporary view URL: https://github.com/apache/spark/pull/26317#issuecomment-552750431 @cloud-fan Kindly look into this PR.

[GitHub] [spark] Ngone51 commented on a change in pull request #26463: [SPARK-29837][SQL] PostgreSQL dialect: cast to boolean

2019-11-11 Thread GitBox
Ngone51 commented on a change in pull request #26463: [SPARK-29837][SQL] PostgreSQL dialect: cast to boolean URL: https://github.com/apache/spark/pull/26463#discussion_r345030210 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala

[GitHub] [spark] cloud-fan commented on issue #25702: [SPARK-29001][CORE] Print events that take too long time to process

2019-11-11 Thread GitBox
cloud-fan commented on issue #25702: [SPARK-29001][CORE] Print events that take too long time to process URL: https://github.com/apache/spark/pull/25702#issuecomment-552749651 thanks, merging to master! This is an automated

[GitHub] [spark] cloud-fan closed pull request #25702: [SPARK-29001][CORE] Print events that take too long time to process

2019-11-11 Thread GitBox
cloud-fan closed pull request #25702: [SPARK-29001][CORE] Print events that take too long time to process URL: https://github.com/apache/spark/pull/25702 This is an automated message from the Apache Git Service. To respond

[GitHub] [spark] qudade edited a comment on issue #26118: [SPARK-24915][Python] Fix Row handling with Schema.

2019-11-11 Thread GitBox
qudade edited a comment on issue #26118: [SPARK-24915][Python] Fix Row handling with Schema. URL: https://github.com/apache/spark/pull/26118#issuecomment-552749031 @zero323 @HyukjinKwon I did some performance tests (Details in [this

[GitHub] [spark] qudade commented on issue #26118: [SPARK-24915][Python] Fix Row handling with Schema.

2019-11-11 Thread GitBox
qudade commented on issue #26118: [SPARK-24915][Python] Fix Row handling with Schema. URL: https://github.com/apache/spark/pull/26118#issuecomment-552749031 @zero323 @HyukjinKwon I did some performance tests (Details inhttps://gist.github.com/qudade/dc9d01f55d27d65ab66d68e3b8d1588d).

[GitHub] [spark] cloud-fan commented on issue #26473: [WIP] Strict parsing of day-time strings to intervals

2019-11-11 Thread GitBox
cloud-fan commented on issue #26473: [WIP] Strict parsing of day-time strings to intervals URL: https://github.com/apache/spark/pull/26473#issuecomment-552747382 +1 to keep the old implementation and add a legacy config to fallback

[GitHub] [spark] iRakson commented on a change in pull request #26467: [SPARK-29477]Improve tooltip for Streaming tab

2019-11-11 Thread GitBox
iRakson commented on a change in pull request #26467: [SPARK-29477]Improve tooltip for Streaming tab URL: https://github.com/apache/spark/pull/26467#discussion_r345028095 ## File path: streaming/src/main/scala/org/apache/spark/streaming/ui/BatchPage.scala ## @@ -37,10

[GitHub] [spark] huaxingao commented on a change in pull request #26480: [SPARK-29808][ML][PYTHON] StopWordsRemover should support multi-cols

2019-11-11 Thread GitBox
huaxingao commented on a change in pull request #26480: [SPARK-29808][ML][PYTHON] StopWordsRemover should support multi-cols URL: https://github.com/apache/spark/pull/26480#discussion_r345028011 ## File path: mllib/src/main/scala/org/apache/spark/ml/feature/StopWordsRemover.scala

[GitHub] [spark] yaooqinn commented on issue #26479: [SPARK-29855][SQL] typed literals with negative sign with proper result or exception

2019-11-11 Thread GitBox
yaooqinn commented on issue #26479: [SPARK-29855][SQL] typed literals with negative sign with proper result or exception URL: https://github.com/apache/spark/pull/26479#issuecomment-552746551 cc @cloud-fan @maropu @HyukjinKwon @MaxGekk, thanks a lot

[GitHub] [spark] huaxingao opened a new pull request #26480: [SPARK-29808][ML][PYTHON] StopWordsRemover should support multi-cols

2019-11-11 Thread GitBox
huaxingao opened a new pull request #26480: [SPARK-29808][ML][PYTHON] StopWordsRemover should support multi-cols URL: https://github.com/apache/spark/pull/26480 ### What changes were proposed in this pull request? Add multi-cols support in StopWordsRemover ### Why are the changes

[GitHub] [spark] yaooqinn opened a new pull request #26479: [SPARK-29855][SQL] typed literals with negative sign with proper result or exception

2019-11-11 Thread GitBox
yaooqinn opened a new pull request #26479: [SPARK-29855][SQL] typed literals with negative sign with proper result or exception URL: https://github.com/apache/spark/pull/26479 ### What changes were proposed in this pull request? ```sql -- !query 83 select -integer '7' --

[GitHub] [spark] 07ARB opened a new pull request #26478: [SPARK-29853][SQL]lpad returning empty instead of NULL for empty pad …

2019-11-11 Thread GitBox
07ARB opened a new pull request #26478: [SPARK-29853][SQL]lpad returning empty instead of NULL for empty pad … URL: https://github.com/apache/spark/pull/26478 ### What changes were proposed in this pull request? lpad returning NULL instead of empty for empty pad value. ### Why

[GitHub] [spark] AmplabJenkins removed a comment on issue #25971: [SPARK-29298][CORE] Separate block manager heartbeat endpoint from driver endpoint

2019-11-11 Thread GitBox
AmplabJenkins removed a comment on issue #25971: [SPARK-29298][CORE] Separate block manager heartbeat endpoint from driver endpoint URL: https://github.com/apache/spark/pull/25971#issuecomment-552743462 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #25971: [SPARK-29298][CORE] Separate block manager heartbeat endpoint from driver endpoint

2019-11-11 Thread GitBox
AmplabJenkins removed a comment on issue #25971: [SPARK-29298][CORE] Separate block manager heartbeat endpoint from driver endpoint URL: https://github.com/apache/spark/pull/25971#issuecomment-552743470 Test PASSed. Refer to this link for build results (access rights to CI server

[GitHub] [spark] AmplabJenkins commented on issue #25971: [SPARK-29298][CORE] Separate block manager heartbeat endpoint from driver endpoint

2019-11-11 Thread GitBox
AmplabJenkins commented on issue #25971: [SPARK-29298][CORE] Separate block manager heartbeat endpoint from driver endpoint URL: https://github.com/apache/spark/pull/25971#issuecomment-552743462 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #25971: [SPARK-29298][CORE] Separate block manager heartbeat endpoint from driver endpoint

2019-11-11 Thread GitBox
AmplabJenkins commented on issue #25971: [SPARK-29298][CORE] Separate block manager heartbeat endpoint from driver endpoint URL: https://github.com/apache/spark/pull/25971#issuecomment-552743470 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #26477: [SPARK-29776][SQL] rpad returning invalid value when parameter is empty

2019-11-11 Thread GitBox
AmplabJenkins commented on issue #26477: [SPARK-29776][SQL] rpad returning invalid value when parameter is empty URL: https://github.com/apache/spark/pull/26477#issuecomment-552743106 Can one of the admins verify this patch?

[GitHub] [spark] cloud-fan commented on a change in pull request #26473: [WIP] Strict parsing of day-time strings to intervals

2019-11-11 Thread GitBox
cloud-fan commented on a change in pull request #26473: [WIP] Strict parsing of day-time strings to intervals URL: https://github.com/apache/spark/pull/26473#discussion_r345024238 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/IntervalUtilsSuite.scala

[GitHub] [spark] SparkQA commented on issue #25728: [SPARK-29020][WIP][SQL] Improving array_sort behaviour

2019-11-11 Thread GitBox
SparkQA commented on issue #25728: [SPARK-29020][WIP][SQL] Improving array_sort behaviour URL: https://github.com/apache/spark/pull/25728#issuecomment-552742241 **[Test build #113613 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/113613/testReport)** for

[GitHub] [spark] AmplabJenkins removed a comment on issue #26476: [SPARK-29851][SQL] V2 catalog: Change default behavior of dropping namespace to cascade

2019-11-11 Thread GitBox
AmplabJenkins removed a comment on issue #26476: [SPARK-29851][SQL] V2 catalog: Change default behavior of dropping namespace to cascade URL: https://github.com/apache/spark/pull/26476#issuecomment-552740931 Test FAILed. Refer to this link for build results (access rights to CI server

[GitHub] [spark] SparkQA commented on issue #26471: [SPARK-29850][SQL] sort-merge-join an empty table should not memory leak

2019-11-11 Thread GitBox
SparkQA commented on issue #26471: [SPARK-29850][SQL] sort-merge-join an empty table should not memory leak URL: https://github.com/apache/spark/pull/26471#issuecomment-552741202 **[Test build #113611 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #26476: [SPARK-29851][SQL] V2 catalog: Change default behavior of dropping namespace to cascade

2019-11-11 Thread GitBox
AmplabJenkins removed a comment on issue #26476: [SPARK-29851][SQL] V2 catalog: Change default behavior of dropping namespace to cascade URL: https://github.com/apache/spark/pull/26476#issuecomment-552740923 Merged build finished. Test FAILed.

[GitHub] [spark] 07ARB opened a new pull request #26477: [SPARK-29776][SQL] rpad returning invalid value when parameter is empty

2019-11-11 Thread GitBox
07ARB opened a new pull request #26477: [SPARK-29776][SQL] rpad returning invalid value when parameter is empty URL: https://github.com/apache/spark/pull/26477 ### What changes were proposed in this pull request? rpad returning null value when padding parameter is empty ### Why

[GitHub] [spark] SparkQA commented on issue #25971: [SPARK-29298][CORE] Separate block manager heartbeat endpoint from driver endpoint

2019-11-11 Thread GitBox
SparkQA commented on issue #25971: [SPARK-29298][CORE] Separate block manager heartbeat endpoint from driver endpoint URL: https://github.com/apache/spark/pull/25971#issuecomment-552741231 **[Test build #113612 has

[GitHub] [spark] cloud-fan commented on issue #26176: [SPARK-29519][SQL] SHOW TBLPROPERTIES should do multi-catalog resolution.

2019-11-11 Thread GitBox
cloud-fan commented on issue #26176: [SPARK-29519][SQL] SHOW TBLPROPERTIES should do multi-catalog resolution. URL: https://github.com/apache/spark/pull/26176#issuecomment-552741205 thanks, merging to master! This is an

[GitHub] [spark] cloud-fan closed pull request #26176: [SPARK-29519][SQL] SHOW TBLPROPERTIES should do multi-catalog resolution.

2019-11-11 Thread GitBox
cloud-fan closed pull request #26176: [SPARK-29519][SQL] SHOW TBLPROPERTIES should do multi-catalog resolution. URL: https://github.com/apache/spark/pull/26176 This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on issue #26476: [SPARK-29851][SQL] V2 catalog: Change default behavior of dropping namespace to cascade

2019-11-11 Thread GitBox
AmplabJenkins commented on issue #26476: [SPARK-29851][SQL] V2 catalog: Change default behavior of dropping namespace to cascade URL: https://github.com/apache/spark/pull/26476#issuecomment-552740923 Merged build finished. Test FAILed.

[GitHub] [spark] huaxingao commented on issue #25573: [SPARK-28833][DOCS][SQL] Document ALTER VIEW command

2019-11-11 Thread GitBox
huaxingao commented on issue #25573: [SPARK-28833][DOCS][SQL] Document ALTER VIEW command URL: https://github.com/apache/spark/pull/25573#issuecomment-552740967 @kevinyu98 The build failure seems to be OK. I always have that failure too.

[GitHub] [spark] AmplabJenkins commented on issue #26476: [SPARK-29851][SQL] V2 catalog: Change default behavior of dropping namespace to cascade

2019-11-11 Thread GitBox
AmplabJenkins commented on issue #26476: [SPARK-29851][SQL] V2 catalog: Change default behavior of dropping namespace to cascade URL: https://github.com/apache/spark/pull/26476#issuecomment-552740931 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA removed a comment on issue #26476: [SPARK-29851][SQL] V2 catalog: Change default behavior of dropping namespace to cascade

2019-11-11 Thread GitBox
SparkQA removed a comment on issue #26476: [SPARK-29851][SQL] V2 catalog: Change default behavior of dropping namespace to cascade URL: https://github.com/apache/spark/pull/26476#issuecomment-552720168 **[Test build #113609 has

[GitHub] [spark] SparkQA commented on issue #26476: [SPARK-29851][SQL] V2 catalog: Change default behavior of dropping namespace to cascade

2019-11-11 Thread GitBox
SparkQA commented on issue #26476: [SPARK-29851][SQL] V2 catalog: Change default behavior of dropping namespace to cascade URL: https://github.com/apache/spark/pull/26476#issuecomment-552740675 **[Test build #113609 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #26413: [SPARK-16872][ML][PYSPARK] Impl Gaussian Naive Bayes Classifier

2019-11-11 Thread GitBox
AmplabJenkins removed a comment on issue #26413: [SPARK-16872][ML][PYSPARK] Impl Gaussian Naive Bayes Classifier URL: https://github.com/apache/spark/pull/26413#issuecomment-552740105 Merged build finished. Test PASSed. This

  1   2   3   4   5   6   7   8   9   >