[GitHub] [spark] AmplabJenkins removed a comment on pull request #28490: [SPARK-31670][SQL]Resolve Struct Field in Grouping Aggregate with same ExprId

2020-06-06 Thread GitBox
AmplabJenkins removed a comment on pull request #28490: URL: https://github.com/apache/spark/pull/28490#issuecomment-640160868 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28490: [SPARK-31670][SQL]Resolve Struct Field in Grouping Aggregate with same ExprId

2020-06-06 Thread GitBox
AmplabJenkins commented on pull request #28490: URL: https://github.com/apache/spark/pull/28490#issuecomment-640160868 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #28490: [SPARK-31670][SQL]Resolve Struct Field in Grouping Aggregate with same ExprId

2020-06-06 Thread GitBox
AngersZh commented on a change in pull request #28490: URL: https://github.com/apache/spark/pull/28490#discussion_r436327006 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -1479,11 +1486,70 @@ class Analyzer(

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #28490: [SPARK-31670][SQL]Resolve Struct Field in Grouping Aggregate with same ExprId

2020-06-06 Thread GitBox
AngersZh commented on a change in pull request #28490: URL: https://github.com/apache/spark/pull/28490#discussion_r436327053 ## File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala ## @@ -3496,6 +3496,88 @@ class SQLQuerySuite extends QueryTest with

[GitHub] [spark] SparkQA commented on pull request #28490: [SPARK-31670][SQL]Resolve Struct Field in Grouping Aggregate with same ExprId

2020-06-06 Thread GitBox
SparkQA commented on pull request #28490: URL: https://github.com/apache/spark/pull/28490#issuecomment-640160759 **[Test build #123595 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123595/testReport)** for PR 28490 at commit

[GitHub] [spark] maropu commented on a change in pull request #28490: [SPARK-31670][SQL]Resolve Struct Field in Grouping Aggregate with same ExprId

2020-06-06 Thread GitBox
maropu commented on a change in pull request #28490: URL: https://github.com/apache/spark/pull/28490#discussion_r436326494 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -1479,11 +1486,70 @@ class Analyzer( // Skip

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28593: [SPARK-31710][SQL] Fail casting numeric to timestamp by default

2020-06-06 Thread GitBox
AmplabJenkins removed a comment on pull request #28593: URL: https://github.com/apache/spark/pull/28593#issuecomment-640159372 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28593: [SPARK-31710][SQL] Fail casting numeric to timestamp by default

2020-06-06 Thread GitBox
AmplabJenkins commented on pull request #28593: URL: https://github.com/apache/spark/pull/28593#issuecomment-640159372 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28593: [SPARK-31710][SQL] Fail casting numeric to timestamp by default

2020-06-06 Thread GitBox
SparkQA commented on pull request #28593: URL: https://github.com/apache/spark/pull/28593#issuecomment-640159284 **[Test build #123594 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123594/testReport)** for PR 28593 at commit

[GitHub] [spark] maropu commented on a change in pull request #28490: [SPARK-31670][SQL]Resolve Struct Field in Grouping Aggregate with same ExprId

2020-06-06 Thread GitBox
maropu commented on a change in pull request #28490: URL: https://github.com/apache/spark/pull/28490#discussion_r436325004 ## File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala ## @@ -3496,6 +3496,88 @@ class SQLQuerySuite extends QueryTest with

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #28490: [SPARK-31670][SQL]Resolve Struct Field in Grouping Aggregate with same ExprId

2020-06-06 Thread GitBox
AngersZh commented on a change in pull request #28490: URL: https://github.com/apache/spark/pull/28490#discussion_r436324728 ## File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala ## @@ -3496,6 +3496,88 @@ class SQLQuerySuite extends QueryTest with

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #28490: [SPARK-31670][SQL]Resolve Struct Field in Grouping Aggregate with same ExprId

2020-06-06 Thread GitBox
AngersZh commented on a change in pull request #28490: URL: https://github.com/apache/spark/pull/28490#discussion_r436324734 ## File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala ## @@ -3496,6 +3496,88 @@ class SQLQuerySuite extends QueryTest with

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #28490: [SPARK-31670][SQL]Resolve Struct Field in Grouping Aggregate with same ExprId

2020-06-06 Thread GitBox
AngersZh commented on a change in pull request #28490: URL: https://github.com/apache/spark/pull/28490#discussion_r436324690 ## File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala ## @@ -3496,6 +3496,88 @@ class SQLQuerySuite extends QueryTest with

[GitHub] [spark] sarutak commented on pull request #28439: [SPARK-30119][WEBUI] Add Pagination Support to Streaming Page

2020-06-06 Thread GitBox
sarutak commented on pull request #28439: URL: https://github.com/apache/spark/pull/28439#issuecomment-640154667 Merged to `master`. This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] iRakson commented on pull request #28439: [SPARK-30119][WEBUI] Add Pagination Support to Streaming Page

2020-06-06 Thread GitBox
iRakson commented on pull request #28439: URL: https://github.com/apache/spark/pull/28439#issuecomment-640154383 Thank You. :) @sarutak @srowen This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] iRakson commented on pull request #28439: [SPARK-30119][WEBUI] Add Pagination Support to Streaming Page

2020-06-06 Thread GitBox
iRakson commented on pull request #28439: URL: https://github.com/apache/spark/pull/28439#issuecomment-640154356 > @iRakson Could you update the screenshots in the description? Updated. This is an automated

[GitHub] [spark] sarutak commented on a change in pull request #28702: [SPARK-31756][WEBUI][3.0] Add real headless browser support for UI test

2020-06-06 Thread GitBox
sarutak commented on a change in pull request #28702: URL: https://github.com/apache/spark/pull/28702#discussion_r436321863 ## File path: core/src/test/scala/org/apache/spark/ui/RealBrowserUISeleniumSuite.scala ## @@ -0,0 +1,109 @@ +/* + * Licensed to the Apache Software

[GitHub] [spark] sarutak commented on pull request #28439: [SPARK-30119][WEBUI] Add Pagination Support to Streaming Page

2020-06-06 Thread GitBox
sarutak commented on pull request #28439: URL: https://github.com/apache/spark/pull/28439#issuecomment-640153962 @iRakson Could you update the screenshots in the description? This is an automated message from the Apache Git

[GitHub] [spark] sarutak closed pull request #28439: [SPARK-30119][WEBUI] Add Pagination Support to Streaming Page

2020-06-06 Thread GitBox
sarutak closed pull request #28439: URL: https://github.com/apache/spark/pull/28439 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #28490: [SPARK-31670][SQL]Struct Field in groupByExpr with CUBE

2020-06-06 Thread GitBox
AngersZh commented on a change in pull request #28490: URL: https://github.com/apache/spark/pull/28490#discussion_r436322459 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -1479,11 +1486,70 @@ class Analyzer(

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #28490: [SPARK-31670][SQL]Struct Field in groupByExpr with CUBE

2020-06-06 Thread GitBox
AngersZh commented on a change in pull request #28490: URL: https://github.com/apache/spark/pull/28490#discussion_r436322434 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -1479,11 +1486,70 @@ class Analyzer(

[GitHub] [spark] sarutak commented on pull request #28439: [SPARK-30119][WEBUI] Add Pagination Support to Streaming Page

2020-06-06 Thread GitBox
sarutak commented on pull request #28439: URL: https://github.com/apache/spark/pull/28439#issuecomment-640153612 I'll merge this time. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] sarutak commented on pull request #28585: [SPARK-31765][WEBUI][test-maven] Upgrade HtmlUnit >= 2.37.0

2020-06-06 Thread GitBox
sarutak commented on pull request #28585: URL: https://github.com/apache/spark/pull/28585#issuecomment-640153448 The errors were reproduced in PR builder and they are fixed by excluding the old `bytebuddy` so I believe it's safe to merge. What do you think, @dongjoon-hyun ?

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #28490: [SPARK-31670][SQL]Struct Field in groupByExpr with CUBE

2020-06-06 Thread GitBox
AngersZh commented on a change in pull request #28490: URL: https://github.com/apache/spark/pull/28490#discussion_r436322246 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -510,10 +510,12 @@ class Analyzer( //

[GitHub] [spark] sarutak commented on pull request #28439: [SPARK-30119][WEBUI] Add Pagination Support to Streaming Page

2020-06-06 Thread GitBox
sarutak commented on pull request #28439: URL: https://github.com/apache/spark/pull/28439#issuecomment-640153162 I've inspected again and it seems ok to me. This is an automated message from the Apache Git Service. To

[GitHub] [spark] sarutak commented on a change in pull request #28702: [SPARK-31756][WEBUI][3.0] Add real headless browser support for UI test

2020-06-06 Thread GitBox
sarutak commented on a change in pull request #28702: URL: https://github.com/apache/spark/pull/28702#discussion_r436321863 ## File path: core/src/test/scala/org/apache/spark/ui/RealBrowserUISeleniumSuite.scala ## @@ -0,0 +1,109 @@ +/* + * Licensed to the Apache Software

[GitHub] [spark] oleg-smith commented on pull request #28488: [SPARK-29083][CORE] Prefetch elements in rdd.toLocalIterator

2020-06-06 Thread GitBox
oleg-smith commented on pull request #28488: URL: https://github.com/apache/spark/pull/28488#issuecomment-640149979 @holdenk could you merge if everything is fine to you? This is an automated message from the Apache Git

[GitHub] [spark] gatorsmile commented on a change in pull request #28702: [SPARK-31756][WEBUI][3.0] Add real headless browser support for UI test

2020-06-06 Thread GitBox
gatorsmile commented on a change in pull request #28702: URL: https://github.com/apache/spark/pull/28702#discussion_r436319781 ## File path: core/src/test/scala/org/apache/spark/ui/RealBrowserUISeleniumSuite.scala ## @@ -0,0 +1,109 @@ +/* + * Licensed to the Apache Software

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28744: [SPARK-31923][Core]Ignore internal accumulators that use unrecognized types rather than crashing

2020-06-06 Thread GitBox
AmplabJenkins removed a comment on pull request #28744: URL: https://github.com/apache/spark/pull/28744#issuecomment-640144482 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28744: [SPARK-31923][Core]Ignore internal accumulators that use unrecognized types rather than crashing

2020-06-06 Thread GitBox
AmplabJenkins commented on pull request #28744: URL: https://github.com/apache/spark/pull/28744#issuecomment-640144482 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28744: [SPARK-31923][Core]Ignore internal accumulators that use unrecognized types rather than crashing

2020-06-06 Thread GitBox
SparkQA removed a comment on pull request #28744: URL: https://github.com/apache/spark/pull/28744#issuecomment-640131304 **[Test build #123592 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123592/testReport)** for PR 28744 at commit

[GitHub] [spark] SparkQA commented on pull request #28744: [SPARK-31923][Core]Ignore internal accumulators that use unrecognized types rather than crashing

2020-06-06 Thread GitBox
SparkQA commented on pull request #28744: URL: https://github.com/apache/spark/pull/28744#issuecomment-640144346 **[Test build #123592 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123592/testReport)** for PR 28744 at commit

[GitHub] [spark] huaxingao commented on a change in pull request #28710: [SPARK-31893][ML] Add a generic ClassificationSummary trait

2020-06-06 Thread GitBox
huaxingao commented on a change in pull request #28710: URL: https://github.com/apache/spark/pull/28710#discussion_r436316633 ## File path: project/MimaExcludes.scala ## @@ -49,7 +49,34 @@ object MimaExcludes { //[SPARK-31840] Add instance weight support in

[GitHub] [spark] AmplabJenkins removed a comment on pull request #27066: [SPARK-31317][SQL] Add withField method to Column

2020-06-06 Thread GitBox
AmplabJenkins removed a comment on pull request #27066: URL: https://github.com/apache/spark/pull/27066#issuecomment-640142420 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #27066: [SPARK-31317][SQL] Add withField method to Column

2020-06-06 Thread GitBox
AmplabJenkins removed a comment on pull request #27066: URL: https://github.com/apache/spark/pull/27066#issuecomment-640142419 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #27066: [SPARK-31317][SQL] Add withField method to Column

2020-06-06 Thread GitBox
AmplabJenkins commented on pull request #27066: URL: https://github.com/apache/spark/pull/27066#issuecomment-640142419 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #27066: [SPARK-31317][SQL] Add withField method to Column

2020-06-06 Thread GitBox
SparkQA removed a comment on pull request #27066: URL: https://github.com/apache/spark/pull/27066#issuecomment-640126191 **[Test build #123591 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123591/testReport)** for PR 27066 at commit

[GitHub] [spark] SparkQA commented on pull request #27066: [SPARK-31317][SQL] Add withField method to Column

2020-06-06 Thread GitBox
SparkQA commented on pull request #27066: URL: https://github.com/apache/spark/pull/27066#issuecomment-640142371 **[Test build #123591 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123591/testReport)** for PR 27066 at commit

[GitHub] [spark] maropu commented on a change in pull request #28490: [SPARK-31670][SQL]Struct Field in groupByExpr with CUBE

2020-06-06 Thread GitBox
maropu commented on a change in pull request #28490: URL: https://github.com/apache/spark/pull/28490#discussion_r436311072 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -510,10 +510,12 @@ class Analyzer( //

[GitHub] [spark] maropu commented on pull request #28743: [SPARK-31920][PYTHON] Fix pandas conversion using Arrow with __arrow_array__ columns

2020-06-06 Thread GitBox
maropu commented on pull request #28743: URL: https://github.com/apache/spark/pull/28743#issuecomment-640139579 Thanks for your work, @moskvax! The failures looks valid, so could you fix them first? This is an automated

[GitHub] [spark] maropu commented on a change in pull request #28490: [SPARK-31670][SQL]Struct Field in groupByExpr with CUBE

2020-06-06 Thread GitBox
maropu commented on a change in pull request #28490: URL: https://github.com/apache/spark/pull/28490#discussion_r436311072 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -510,10 +510,12 @@ class Analyzer( //

[GitHub] [spark] siknezevic commented on a change in pull request #27246: [SPARK-30536][CORE][SQL] Sort-merge join operator spilling performance improvements

2020-06-06 Thread GitBox
siknezevic commented on a change in pull request #27246: URL: https://github.com/apache/spark/pull/27246#discussion_r436311708 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/ExternalAppendOnlyUnsafeRowArray.scala ## @@ -82,6 +82,8 @@ private[sql] class

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28743: [SPARK-31920][PYTHON] Fix pandas conversion using Arrow with __arrow_array__ columns

2020-06-06 Thread GitBox
AmplabJenkins removed a comment on pull request #28743: URL: https://github.com/apache/spark/pull/28743#issuecomment-640136976 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28743: [SPARK-31920][PYTHON] Fix pandas conversion using Arrow with __arrow_array__ columns

2020-06-06 Thread GitBox
AmplabJenkins removed a comment on pull request #28743: URL: https://github.com/apache/spark/pull/28743#issuecomment-640136974 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #28743: [SPARK-31920][PYTHON] Fix pandas conversion using Arrow with __arrow_array__ columns

2020-06-06 Thread GitBox
AmplabJenkins commented on pull request #28743: URL: https://github.com/apache/spark/pull/28743#issuecomment-640136974 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28743: [SPARK-31920][PYTHON] Fix pandas conversion using Arrow with __arrow_array__ columns

2020-06-06 Thread GitBox
SparkQA removed a comment on pull request #28743: URL: https://github.com/apache/spark/pull/28743#issuecomment-640135313 **[Test build #123593 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123593/testReport)** for PR 28743 at commit

[GitHub] [spark] SparkQA commented on pull request #28743: [SPARK-31920][PYTHON] Fix pandas conversion using Arrow with __arrow_array__ columns

2020-06-06 Thread GitBox
SparkQA commented on pull request #28743: URL: https://github.com/apache/spark/pull/28743#issuecomment-640136929 **[Test build #123593 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123593/testReport)** for PR 28743 at commit

[GitHub] [spark] github-actions[bot] commented on pull request #25398: [SPARK-28659][SQL] Use data source if convertible in insert overwrite directory

2020-06-06 Thread GitBox
github-actions[bot] commented on pull request #25398: URL: https://github.com/apache/spark/pull/25398#issuecomment-640136192 We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue

[GitHub] [spark] github-actions[bot] closed pull request #27215: [SPARK-30514][K8S] add python environment support for JavaMainAppResource

2020-06-06 Thread GitBox
github-actions[bot] closed pull request #27215: URL: https://github.com/apache/spark/pull/27215 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [spark] wangyum commented on pull request #28741: [WIP][SPARK-31919][SQL] Push down more predicates through Join

2020-06-06 Thread GitBox
wangyum commented on pull request #28741: URL: https://github.com/apache/spark/pull/28741#issuecomment-640136037 It seems this solution cannot be fully optimized. PostgreSQL: ``` Aggregate (cost=77.33..77.34 rows=1 width=128) -> Nested Loop (cost=0.00..77.31 rows=1

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28743: [SPARK-31920][PYTHON] Fix pandas conversion using Arrow with __arrow_array__ columns

2020-06-06 Thread GitBox
AmplabJenkins removed a comment on pull request #28743: URL: https://github.com/apache/spark/pull/28743#issuecomment-640135423 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28743: [SPARK-31920][PYTHON] Fix pandas conversion using Arrow with __arrow_array__ columns

2020-06-06 Thread GitBox
AmplabJenkins commented on pull request #28743: URL: https://github.com/apache/spark/pull/28743#issuecomment-640135423 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28743: [SPARK-31920][PYTHON] Fix pandas conversion using Arrow with __arrow_array__ columns

2020-06-06 Thread GitBox
SparkQA commented on pull request #28743: URL: https://github.com/apache/spark/pull/28743#issuecomment-640135313 **[Test build #123593 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123593/testReport)** for PR 28743 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28743: [SPARK-31920][PYTHON] Fix pandas conversion using Arrow with __arrow_array__ columns

2020-06-06 Thread GitBox
AmplabJenkins removed a comment on pull request #28743: URL: https://github.com/apache/spark/pull/28743#issuecomment-640075128 Can one of the admins verify this patch? This is an automated message from the Apache Git

[GitHub] [spark] maropu commented on pull request #28743: [SPARK-31920][PYTHON] Fix pandas conversion using Arrow with __arrow_array__ columns

2020-06-06 Thread GitBox
maropu commented on pull request #28743: URL: https://github.com/apache/spark/pull/28743#issuecomment-640135230 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] maropu commented on pull request #28743: [SPARK-31920][PYTHON] Fix pandas conversion using Arrow with __arrow_array__ columns

2020-06-06 Thread GitBox
maropu commented on pull request #28743: URL: https://github.com/apache/spark/pull/28743#issuecomment-640135250 cc: @HyukjinKwon @viirya This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28744: [SPARK-31923][Core]Ignore internal accumulators that use unrecognized types rather than crashing

2020-06-06 Thread GitBox
AmplabJenkins removed a comment on pull request #28744: URL: https://github.com/apache/spark/pull/28744#issuecomment-640131400 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28744: [SPARK-31923][Core]Ignore internal accumulators that use unrecognized types rather than crashing

2020-06-06 Thread GitBox
AmplabJenkins commented on pull request #28744: URL: https://github.com/apache/spark/pull/28744#issuecomment-640131400 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28744: [SPARK-31923][Core]Ignore internal accumulators that use unrecognized types rather than crashing

2020-06-06 Thread GitBox
SparkQA commented on pull request #28744: URL: https://github.com/apache/spark/pull/28744#issuecomment-640131304 **[Test build #123592 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123592/testReport)** for PR 28744 at commit

[GitHub] [spark] zsxwing opened a new pull request #28744: [SPARK-31923][Core]Ignore internal accumulators that use unrecognized types rather than crashing

2020-06-06 Thread GitBox
zsxwing opened a new pull request #28744: URL: https://github.com/apache/spark/pull/28744 ### What changes were proposed in this pull request? Ignore internal accumulators that use unrecognized types rather than crashing so that an event log containing such accumulators can still be

[GitHub] [spark] SparkQA commented on pull request #27066: [SPARK-31317][SQL] Add withField method to Column

2020-06-06 Thread GitBox
SparkQA commented on pull request #27066: URL: https://github.com/apache/spark/pull/27066#issuecomment-640126191 **[Test build #123591 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123591/testReport)** for PR 27066 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28490: [SPARK-31670][SQL]Struct Field in groupByExpr with CUBE

2020-06-06 Thread GitBox
AmplabJenkins removed a comment on pull request #28490: URL: https://github.com/apache/spark/pull/28490#issuecomment-640104812 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28490: [SPARK-31670][SQL]Struct Field in groupByExpr with CUBE

2020-06-06 Thread GitBox
AmplabJenkins commented on pull request #28490: URL: https://github.com/apache/spark/pull/28490#issuecomment-640104812 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28490: [SPARK-31670][SQL]Struct Field in groupByExpr with CUBE

2020-06-06 Thread GitBox
SparkQA removed a comment on pull request #28490: URL: https://github.com/apache/spark/pull/28490#issuecomment-640071894 **[Test build #123589 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123589/testReport)** for PR 28490 at commit

[GitHub] [spark] SparkQA commented on pull request #28490: [SPARK-31670][SQL]Struct Field in groupByExpr with CUBE

2020-06-06 Thread GitBox
SparkQA commented on pull request #28490: URL: https://github.com/apache/spark/pull/28490#issuecomment-640104588 **[Test build #123589 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123589/testReport)** for PR 28490 at commit

[GitHub] [spark] srowen commented on pull request #28258: [SPARK-31486] [CORE] spark.submit.waitAppCompletion flag to control spark-submit exit in Standalone Cluster Mode

2020-06-06 Thread GitBox
srowen commented on pull request #28258: URL: https://github.com/apache/spark/pull/28258#issuecomment-640101643 @Ngone51 any final thoughts? This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] akshatb1 commented on pull request #28258: [SPARK-31486] [CORE] spark.submit.waitAppCompletion flag to control spark-submit exit in Standalone Cluster Mode

2020-06-06 Thread GitBox
akshatb1 commented on pull request #28258: URL: https://github.com/apache/spark/pull/28258#issuecomment-640098574 @srowen : Gentle reminder, kindly take a look when you get a chance. Thanks. This is an automated message from

[GitHub] [spark] srowen commented on pull request #28439: [SPARK-30119][WEBUI] Add Pagination Support to Streaming Page

2020-06-06 Thread GitBox
srowen commented on pull request #28439: URL: https://github.com/apache/spark/pull/28439#issuecomment-640097483 If you're OK with it @sarutak I'll merge This is an automated message from the Apache Git Service. To respond

[GitHub] [spark] srowen commented on a change in pull request #28710: [SPARK-31893][ML] Add a generic ClassificationSummary trait

2020-06-06 Thread GitBox
srowen commented on a change in pull request #28710: URL: https://github.com/apache/spark/pull/28710#discussion_r436288381 ## File path: project/MimaExcludes.scala ## @@ -49,7 +49,34 @@ object MimaExcludes { //[SPARK-31840] Add instance weight support in

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28742: [SPARK-31921][CORE] Fix the wrong warning: "App app-xxx requires more resource than any of Workers could have"

2020-06-06 Thread GitBox
AmplabJenkins removed a comment on pull request #28742: URL: https://github.com/apache/spark/pull/28742#issuecomment-640091898 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28742: [SPARK-31921][CORE] Fix the wrong warning: "App app-xxx requires more resource than any of Workers could have"

2020-06-06 Thread GitBox
AmplabJenkins commented on pull request #28742: URL: https://github.com/apache/spark/pull/28742#issuecomment-640091898 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28742: [SPARK-31921][CORE] Fix the wrong warning: "App app-xxx requires more resource than any of Workers could have"

2020-06-06 Thread GitBox
SparkQA removed a comment on pull request #28742: URL: https://github.com/apache/spark/pull/28742#issuecomment-640072903 **[Test build #123590 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123590/testReport)** for PR 28742 at commit

[GitHub] [spark] SparkQA commented on pull request #28742: [SPARK-31921][CORE] Fix the wrong warning: "App app-xxx requires more resource than any of Workers could have"

2020-06-06 Thread GitBox
SparkQA commented on pull request #28742: URL: https://github.com/apache/spark/pull/28742#issuecomment-640091614 **[Test build #123590 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123590/testReport)** for PR 28742 at commit

[GitHub] [spark] HyukjinKwon commented on a change in pull request #28731: [SPARK-31909][SQL] Add SPARK_SUBMIT_OPTS to Beeline Script

2020-06-06 Thread GitBox
HyukjinKwon commented on a change in pull request #28731: URL: https://github.com/apache/spark/pull/28731#discussion_r436279847 ## File path: bin/beeline ## @@ -28,5 +28,7 @@ if [ -z "${SPARK_HOME}" ]; then source "$(dirname "$0")"/find-spark-home fi +.

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28743: [SPARK-31920] Fix pandas conversion using Arrow with __arrow_array__ columns

2020-06-06 Thread GitBox
AmplabJenkins removed a comment on pull request #28743: URL: https://github.com/apache/spark/pull/28743#issuecomment-640074996 Can one of the admins verify this patch? This is an automated message from the Apache Git

[GitHub] [spark] AmplabJenkins commented on pull request #28743: [SPARK-31920] Fix pandas conversion using Arrow with __arrow_array__ columns

2020-06-06 Thread GitBox
AmplabJenkins commented on pull request #28743: URL: https://github.com/apache/spark/pull/28743#issuecomment-640075128 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #28743: [SPARK-31920] Fix pandas conversion using Arrow with __arrow_array__ columns

2020-06-06 Thread GitBox
AmplabJenkins commented on pull request #28743: URL: https://github.com/apache/spark/pull/28743#issuecomment-640074996 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To

[GitHub] [spark] moskvax opened a new pull request #28743: [SPARK-31920] Fix pandas conversion using Arrow with __arrow_array__ columns

2020-06-06 Thread GitBox
moskvax opened a new pull request #28743: URL: https://github.com/apache/spark/pull/28743 ### What changes were proposed in this pull request? 1. Cast pandas DataFrame columns to object before passing to `pa.Schema.from_pandas`, to avoid a potential failed type check for

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28742: [SPARK-31921][CORE] Fix the wrong warning: "App app-xxx requires more resource than any of Workers could have"

2020-06-06 Thread GitBox
AmplabJenkins removed a comment on pull request #28742: URL: https://github.com/apache/spark/pull/28742#issuecomment-640072083 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #28742: [SPARK-31921][CORE] Fix the wrong warning: "App app-xxx requires more resource than any of Workers could have"

2020-06-06 Thread GitBox
SparkQA commented on pull request #28742: URL: https://github.com/apache/spark/pull/28742#issuecomment-640072903 **[Test build #123590 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123590/testReport)** for PR 28742 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28490: [SPARK-31670][SQL]Struct Field in groupByExpr with CUBE

2020-06-06 Thread GitBox
AmplabJenkins removed a comment on pull request #28490: URL: https://github.com/apache/spark/pull/28490#issuecomment-640072138 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28490: [SPARK-31670][SQL]Struct Field in groupByExpr with CUBE

2020-06-06 Thread GitBox
AmplabJenkins commented on pull request #28490: URL: https://github.com/apache/spark/pull/28490#issuecomment-640072138 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #28742: [SPARK-31921][CORE] Fix the wrong warning: "App app-xxx requires more resource than any of Workers could have"

2020-06-06 Thread GitBox
AmplabJenkins commented on pull request #28742: URL: https://github.com/apache/spark/pull/28742#issuecomment-640072083 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] Ngone51 commented on pull request #28742: [SPARK-31921][CORE] Fix the wrong warning: "App app-xxx requires more resource than any of Workers could have"

2020-06-06 Thread GitBox
Ngone51 commented on pull request #28742: URL: https://github.com/apache/spark/pull/28742#issuecomment-640071958 ping @tgravescs @jiangxb1987 Please take a look, thanks! This is an automated message from the Apache Git

[GitHub] [spark] SparkQA commented on pull request #28490: [SPARK-31670][SQL]Struct Field in groupByExpr with CUBE

2020-06-06 Thread GitBox
SparkQA commented on pull request #28490: URL: https://github.com/apache/spark/pull/28490#issuecomment-640071894 **[Test build #123589 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123589/testReport)** for PR 28490 at commit

[GitHub] [spark] Ngone51 opened a new pull request #28742: [SPARK-31921][CORE] Fix the wrong warning: "App app-xxx requires more resource than any of Workers could have"

2020-06-06 Thread GitBox
Ngone51 opened a new pull request #28742: URL: https://github.com/apache/spark/pull/28742 ### What changes were proposed in this pull request? This PR adds the check to see whether the allocated executors for the waiting application is empty before recognizing it as a

[GitHub] [spark] srowen commented on pull request #28585: [SPARK-31765][WEBUI][test-maven] Upgrade HtmlUnit >= 2.37.0

2020-06-06 Thread GitBox
srowen commented on pull request #28585: URL: https://github.com/apache/spark/pull/28585#issuecomment-640067780 Heh, do we think it's safe to merge again? An exclusion is probably fine, but now it depends on something it needs only transitively. We could also manage the version

[GitHub] [spark] maropu commented on a change in pull request #28741: [WIP][SPARK-31919][SQL] Push down more predicates through Join

2020-06-06 Thread GitBox
maropu commented on a change in pull request #28741: URL: https://github.com/apache/spark/pull/28741#discussion_r436268072 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/PushPredicateThroughJoin.scala ## @@ -0,0 +1,248 @@ +/* + * Licensed to

[GitHub] [spark] holdenk commented on pull request #28700: [SPARK-31860][BUILD] only push release tags on succes

2020-06-06 Thread GitBox
holdenk commented on pull request #28700: URL: https://github.com/apache/spark/pull/28700#issuecomment-640058818 Yes, although that seems like the right thing to do anyways. On Fri, Jun 5, 2020 at 7:22 PM Wenchen Fan wrote: > with this patch, does it mean we have to re-do all

[GitHub] [spark] maropu commented on a change in pull request #28741: [WIP][SPARK-31919][SQL] Push down more predicates through Join

2020-06-06 Thread GitBox
maropu commented on a change in pull request #28741: URL: https://github.com/apache/spark/pull/28741#discussion_r436267250 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/PushPredicateThroughJoin.scala ## @@ -0,0 +1,248 @@ +/* + * Licensed to

[GitHub] [spark] maropu commented on pull request #28741: [WIP][SPARK-31919][SQL] Push down more predicates through Join

2020-06-06 Thread GitBox
maropu commented on pull request #28741: URL: https://github.com/apache/spark/pull/28741#issuecomment-640057173 Just to check; it seems this PR doesn't depend on CNF conversion, but we could get the totally same performance gains with https://github.com/apache/spark/pull/28733?

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28741: [WIP][SPARK-31919][SQL] Push down more predicates through Join

2020-06-06 Thread GitBox
AmplabJenkins removed a comment on pull request #28741: URL: https://github.com/apache/spark/pull/28741#issuecomment-640054008 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28741: [WIP][SPARK-31919][SQL] Push down more predicates through Join

2020-06-06 Thread GitBox
AmplabJenkins commented on pull request #28741: URL: https://github.com/apache/spark/pull/28741#issuecomment-640054008 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28741: [WIP][SPARK-31919][SQL] Push down more predicates through Join

2020-06-06 Thread GitBox
SparkQA removed a comment on pull request #28741: URL: https://github.com/apache/spark/pull/28741#issuecomment-640008330 **[Test build #123587 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123587/testReport)** for PR 28741 at commit

[GitHub] [spark] SparkQA commented on pull request #28741: [WIP][SPARK-31919][SQL] Push down more predicates through Join

2020-06-06 Thread GitBox
SparkQA commented on pull request #28741: URL: https://github.com/apache/spark/pull/28741#issuecomment-640053672 **[Test build #123587 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123587/testReport)** for PR 28741 at commit

[GitHub] [spark] yaooqinn closed pull request #28727: [SPARK-31879][SQL][test-java11] Preset monday start(iso) for the first day of week by reflection

2020-06-06 Thread GitBox
yaooqinn closed pull request #28727: URL: https://github.com/apache/spark/pull/28727 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28593: [SPARK-31710][SQL] Fail casting numeric to timestamp by default

2020-06-06 Thread GitBox
AmplabJenkins removed a comment on pull request #28593: URL: https://github.com/apache/spark/pull/28593#issuecomment-640028119 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28593: [SPARK-31710][SQL] Fail casting numeric to timestamp by default

2020-06-06 Thread GitBox
AmplabJenkins removed a comment on pull request #28593: URL: https://github.com/apache/spark/pull/28593#issuecomment-640028118 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #28593: [SPARK-31710][SQL] Fail casting numeric to timestamp by default

2020-06-06 Thread GitBox
AmplabJenkins commented on pull request #28593: URL: https://github.com/apache/spark/pull/28593#issuecomment-640028118 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28593: [SPARK-31710][SQL] Fail casting numeric to timestamp by default

2020-06-06 Thread GitBox
SparkQA removed a comment on pull request #28593: URL: https://github.com/apache/spark/pull/28593#issuecomment-640009693 **[Test build #123588 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123588/testReport)** for PR 28593 at commit

  1   2   >