AmplabJenkins removed a comment on pull request #28490:
URL: https://github.com/apache/spark/pull/28490#issuecomment-640160868
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #28490:
URL: https://github.com/apache/spark/pull/28490#issuecomment-640160868
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AngersZh commented on a change in pull request #28490:
URL: https://github.com/apache/spark/pull/28490#discussion_r436327006
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##
@@ -1479,11 +1486,70 @@ class Analyzer(
AngersZh commented on a change in pull request #28490:
URL: https://github.com/apache/spark/pull/28490#discussion_r436327053
##
File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
##
@@ -3496,6 +3496,88 @@ class SQLQuerySuite extends QueryTest with
SparkQA commented on pull request #28490:
URL: https://github.com/apache/spark/pull/28490#issuecomment-640160759
**[Test build #123595 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123595/testReport)**
for PR 28490 at commit
maropu commented on a change in pull request #28490:
URL: https://github.com/apache/spark/pull/28490#discussion_r436326494
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##
@@ -1479,11 +1486,70 @@ class Analyzer(
// Skip
AmplabJenkins removed a comment on pull request #28593:
URL: https://github.com/apache/spark/pull/28593#issuecomment-640159372
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #28593:
URL: https://github.com/apache/spark/pull/28593#issuecomment-640159372
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #28593:
URL: https://github.com/apache/spark/pull/28593#issuecomment-640159284
**[Test build #123594 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123594/testReport)**
for PR 28593 at commit
maropu commented on a change in pull request #28490:
URL: https://github.com/apache/spark/pull/28490#discussion_r436325004
##
File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
##
@@ -3496,6 +3496,88 @@ class SQLQuerySuite extends QueryTest with
AngersZh commented on a change in pull request #28490:
URL: https://github.com/apache/spark/pull/28490#discussion_r436324728
##
File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
##
@@ -3496,6 +3496,88 @@ class SQLQuerySuite extends QueryTest with
AngersZh commented on a change in pull request #28490:
URL: https://github.com/apache/spark/pull/28490#discussion_r436324734
##
File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
##
@@ -3496,6 +3496,88 @@ class SQLQuerySuite extends QueryTest with
AngersZh commented on a change in pull request #28490:
URL: https://github.com/apache/spark/pull/28490#discussion_r436324690
##
File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
##
@@ -3496,6 +3496,88 @@ class SQLQuerySuite extends QueryTest with
sarutak commented on pull request #28439:
URL: https://github.com/apache/spark/pull/28439#issuecomment-640154667
Merged to `master`.
This is an automated message from the Apache Git Service.
To respond to the message, please
iRakson commented on pull request #28439:
URL: https://github.com/apache/spark/pull/28439#issuecomment-640154383
Thank You. :) @sarutak @srowen
This is an automated message from the Apache Git Service.
To respond to the
iRakson commented on pull request #28439:
URL: https://github.com/apache/spark/pull/28439#issuecomment-640154356
> @iRakson Could you update the screenshots in the description?
Updated.
This is an automated
sarutak commented on a change in pull request #28702:
URL: https://github.com/apache/spark/pull/28702#discussion_r436321863
##
File path:
core/src/test/scala/org/apache/spark/ui/RealBrowserUISeleniumSuite.scala
##
@@ -0,0 +1,109 @@
+/*
+ * Licensed to the Apache Software
sarutak commented on pull request #28439:
URL: https://github.com/apache/spark/pull/28439#issuecomment-640153962
@iRakson Could you update the screenshots in the description?
This is an automated message from the Apache Git
sarutak closed pull request #28439:
URL: https://github.com/apache/spark/pull/28439
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
AngersZh commented on a change in pull request #28490:
URL: https://github.com/apache/spark/pull/28490#discussion_r436322459
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##
@@ -1479,11 +1486,70 @@ class Analyzer(
AngersZh commented on a change in pull request #28490:
URL: https://github.com/apache/spark/pull/28490#discussion_r436322434
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##
@@ -1479,11 +1486,70 @@ class Analyzer(
sarutak commented on pull request #28439:
URL: https://github.com/apache/spark/pull/28439#issuecomment-640153612
I'll merge this time.
This is an automated message from the Apache Git Service.
To respond to the message,
sarutak commented on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-640153448
The errors were reproduced in PR builder and they are fixed by excluding the
old `bytebuddy` so I believe it's safe to merge.
What do you think, @dongjoon-hyun ?
AngersZh commented on a change in pull request #28490:
URL: https://github.com/apache/spark/pull/28490#discussion_r436322246
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##
@@ -510,10 +510,12 @@ class Analyzer(
//
sarutak commented on pull request #28439:
URL: https://github.com/apache/spark/pull/28439#issuecomment-640153162
I've inspected again and it seems ok to me.
This is an automated message from the Apache Git Service.
To
sarutak commented on a change in pull request #28702:
URL: https://github.com/apache/spark/pull/28702#discussion_r436321863
##
File path:
core/src/test/scala/org/apache/spark/ui/RealBrowserUISeleniumSuite.scala
##
@@ -0,0 +1,109 @@
+/*
+ * Licensed to the Apache Software
oleg-smith commented on pull request #28488:
URL: https://github.com/apache/spark/pull/28488#issuecomment-640149979
@holdenk could you merge if everything is fine to you?
This is an automated message from the Apache Git
gatorsmile commented on a change in pull request #28702:
URL: https://github.com/apache/spark/pull/28702#discussion_r436319781
##
File path:
core/src/test/scala/org/apache/spark/ui/RealBrowserUISeleniumSuite.scala
##
@@ -0,0 +1,109 @@
+/*
+ * Licensed to the Apache Software
AmplabJenkins removed a comment on pull request #28744:
URL: https://github.com/apache/spark/pull/28744#issuecomment-640144482
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #28744:
URL: https://github.com/apache/spark/pull/28744#issuecomment-640144482
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA removed a comment on pull request #28744:
URL: https://github.com/apache/spark/pull/28744#issuecomment-640131304
**[Test build #123592 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123592/testReport)**
for PR 28744 at commit
SparkQA commented on pull request #28744:
URL: https://github.com/apache/spark/pull/28744#issuecomment-640144346
**[Test build #123592 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123592/testReport)**
for PR 28744 at commit
huaxingao commented on a change in pull request #28710:
URL: https://github.com/apache/spark/pull/28710#discussion_r436316633
##
File path: project/MimaExcludes.scala
##
@@ -49,7 +49,34 @@ object MimaExcludes {
//[SPARK-31840] Add instance weight support in
AmplabJenkins removed a comment on pull request #27066:
URL: https://github.com/apache/spark/pull/27066#issuecomment-640142420
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
AmplabJenkins removed a comment on pull request #27066:
URL: https://github.com/apache/spark/pull/27066#issuecomment-640142419
Merged build finished. Test FAILed.
This is an automated message from the Apache Git Service.
To
AmplabJenkins commented on pull request #27066:
URL: https://github.com/apache/spark/pull/27066#issuecomment-640142419
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA removed a comment on pull request #27066:
URL: https://github.com/apache/spark/pull/27066#issuecomment-640126191
**[Test build #123591 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123591/testReport)**
for PR 27066 at commit
SparkQA commented on pull request #27066:
URL: https://github.com/apache/spark/pull/27066#issuecomment-640142371
**[Test build #123591 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123591/testReport)**
for PR 27066 at commit
maropu commented on a change in pull request #28490:
URL: https://github.com/apache/spark/pull/28490#discussion_r436311072
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##
@@ -510,10 +510,12 @@ class Analyzer(
//
maropu commented on pull request #28743:
URL: https://github.com/apache/spark/pull/28743#issuecomment-640139579
Thanks for your work, @moskvax! The failures looks valid, so could you fix
them first?
This is an automated
maropu commented on a change in pull request #28490:
URL: https://github.com/apache/spark/pull/28490#discussion_r436311072
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##
@@ -510,10 +510,12 @@ class Analyzer(
//
siknezevic commented on a change in pull request #27246:
URL: https://github.com/apache/spark/pull/27246#discussion_r436311708
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/ExternalAppendOnlyUnsafeRowArray.scala
##
@@ -82,6 +82,8 @@ private[sql] class
AmplabJenkins removed a comment on pull request #28743:
URL: https://github.com/apache/spark/pull/28743#issuecomment-640136976
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
AmplabJenkins removed a comment on pull request #28743:
URL: https://github.com/apache/spark/pull/28743#issuecomment-640136974
Merged build finished. Test FAILed.
This is an automated message from the Apache Git Service.
To
AmplabJenkins commented on pull request #28743:
URL: https://github.com/apache/spark/pull/28743#issuecomment-640136974
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA removed a comment on pull request #28743:
URL: https://github.com/apache/spark/pull/28743#issuecomment-640135313
**[Test build #123593 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123593/testReport)**
for PR 28743 at commit
SparkQA commented on pull request #28743:
URL: https://github.com/apache/spark/pull/28743#issuecomment-640136929
**[Test build #123593 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123593/testReport)**
for PR 28743 at commit
github-actions[bot] commented on pull request #25398:
URL: https://github.com/apache/spark/pull/25398#issuecomment-640136192
We're closing this PR because it hasn't been updated in a while. This isn't
a judgement on the merit of the PR in any way. It's just a way of keeping the
PR queue
github-actions[bot] closed pull request #27215:
URL: https://github.com/apache/spark/pull/27215
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
wangyum commented on pull request #28741:
URL: https://github.com/apache/spark/pull/28741#issuecomment-640136037
It seems this solution cannot be fully optimized.
PostgreSQL:
```
Aggregate (cost=77.33..77.34 rows=1 width=128)
-> Nested Loop (cost=0.00..77.31 rows=1
AmplabJenkins removed a comment on pull request #28743:
URL: https://github.com/apache/spark/pull/28743#issuecomment-640135423
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #28743:
URL: https://github.com/apache/spark/pull/28743#issuecomment-640135423
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #28743:
URL: https://github.com/apache/spark/pull/28743#issuecomment-640135313
**[Test build #123593 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123593/testReport)**
for PR 28743 at commit
AmplabJenkins removed a comment on pull request #28743:
URL: https://github.com/apache/spark/pull/28743#issuecomment-640075128
Can one of the admins verify this patch?
This is an automated message from the Apache Git
maropu commented on pull request #28743:
URL: https://github.com/apache/spark/pull/28743#issuecomment-640135230
ok to test
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
maropu commented on pull request #28743:
URL: https://github.com/apache/spark/pull/28743#issuecomment-640135250
cc: @HyukjinKwon @viirya
This is an automated message from the Apache Git Service.
To respond to the message,
AmplabJenkins removed a comment on pull request #28744:
URL: https://github.com/apache/spark/pull/28744#issuecomment-640131400
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #28744:
URL: https://github.com/apache/spark/pull/28744#issuecomment-640131400
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #28744:
URL: https://github.com/apache/spark/pull/28744#issuecomment-640131304
**[Test build #123592 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123592/testReport)**
for PR 28744 at commit
zsxwing opened a new pull request #28744:
URL: https://github.com/apache/spark/pull/28744
### What changes were proposed in this pull request?
Ignore internal accumulators that use unrecognized types rather than
crashing so that an event log containing such accumulators can still be
SparkQA commented on pull request #27066:
URL: https://github.com/apache/spark/pull/27066#issuecomment-640126191
**[Test build #123591 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123591/testReport)**
for PR 27066 at commit
AmplabJenkins removed a comment on pull request #28490:
URL: https://github.com/apache/spark/pull/28490#issuecomment-640104812
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #28490:
URL: https://github.com/apache/spark/pull/28490#issuecomment-640104812
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA removed a comment on pull request #28490:
URL: https://github.com/apache/spark/pull/28490#issuecomment-640071894
**[Test build #123589 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123589/testReport)**
for PR 28490 at commit
SparkQA commented on pull request #28490:
URL: https://github.com/apache/spark/pull/28490#issuecomment-640104588
**[Test build #123589 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123589/testReport)**
for PR 28490 at commit
srowen commented on pull request #28258:
URL: https://github.com/apache/spark/pull/28258#issuecomment-640101643
@Ngone51 any final thoughts?
This is an automated message from the Apache Git Service.
To respond to the
akshatb1 commented on pull request #28258:
URL: https://github.com/apache/spark/pull/28258#issuecomment-640098574
@srowen : Gentle reminder, kindly take a look when you get a chance. Thanks.
This is an automated message from
srowen commented on pull request #28439:
URL: https://github.com/apache/spark/pull/28439#issuecomment-640097483
If you're OK with it @sarutak I'll merge
This is an automated message from the Apache Git Service.
To respond
srowen commented on a change in pull request #28710:
URL: https://github.com/apache/spark/pull/28710#discussion_r436288381
##
File path: project/MimaExcludes.scala
##
@@ -49,7 +49,34 @@ object MimaExcludes {
//[SPARK-31840] Add instance weight support in
AmplabJenkins removed a comment on pull request #28742:
URL: https://github.com/apache/spark/pull/28742#issuecomment-640091898
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #28742:
URL: https://github.com/apache/spark/pull/28742#issuecomment-640091898
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA removed a comment on pull request #28742:
URL: https://github.com/apache/spark/pull/28742#issuecomment-640072903
**[Test build #123590 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123590/testReport)**
for PR 28742 at commit
SparkQA commented on pull request #28742:
URL: https://github.com/apache/spark/pull/28742#issuecomment-640091614
**[Test build #123590 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123590/testReport)**
for PR 28742 at commit
HyukjinKwon commented on a change in pull request #28731:
URL: https://github.com/apache/spark/pull/28731#discussion_r436279847
##
File path: bin/beeline
##
@@ -28,5 +28,7 @@ if [ -z "${SPARK_HOME}" ]; then
source "$(dirname "$0")"/find-spark-home
fi
+.
AmplabJenkins removed a comment on pull request #28743:
URL: https://github.com/apache/spark/pull/28743#issuecomment-640074996
Can one of the admins verify this patch?
This is an automated message from the Apache Git
AmplabJenkins commented on pull request #28743:
URL: https://github.com/apache/spark/pull/28743#issuecomment-640075128
Can one of the admins verify this patch?
This is an automated message from the Apache Git Service.
To
AmplabJenkins commented on pull request #28743:
URL: https://github.com/apache/spark/pull/28743#issuecomment-640074996
Can one of the admins verify this patch?
This is an automated message from the Apache Git Service.
To
moskvax opened a new pull request #28743:
URL: https://github.com/apache/spark/pull/28743
### What changes were proposed in this pull request?
1. Cast pandas DataFrame columns to object before passing to
`pa.Schema.from_pandas`, to avoid a potential failed type check for
AmplabJenkins removed a comment on pull request #28742:
URL: https://github.com/apache/spark/pull/28742#issuecomment-640072083
This is an automated message from the Apache Git Service.
To respond to the message, please log on
SparkQA commented on pull request #28742:
URL: https://github.com/apache/spark/pull/28742#issuecomment-640072903
**[Test build #123590 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123590/testReport)**
for PR 28742 at commit
AmplabJenkins removed a comment on pull request #28490:
URL: https://github.com/apache/spark/pull/28490#issuecomment-640072138
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #28490:
URL: https://github.com/apache/spark/pull/28490#issuecomment-640072138
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins commented on pull request #28742:
URL: https://github.com/apache/spark/pull/28742#issuecomment-640072083
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
Ngone51 commented on pull request #28742:
URL: https://github.com/apache/spark/pull/28742#issuecomment-640071958
ping @tgravescs @jiangxb1987 Please take a look, thanks!
This is an automated message from the Apache Git
SparkQA commented on pull request #28490:
URL: https://github.com/apache/spark/pull/28490#issuecomment-640071894
**[Test build #123589 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123589/testReport)**
for PR 28490 at commit
Ngone51 opened a new pull request #28742:
URL: https://github.com/apache/spark/pull/28742
### What changes were proposed in this pull request?
This PR adds the check to see whether the allocated executors for the
waiting application is empty before recognizing it as a
srowen commented on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-640067780
Heh, do we think it's safe to merge again?
An exclusion is probably fine, but now it depends on something it needs only
transitively. We could also manage the version
maropu commented on a change in pull request #28741:
URL: https://github.com/apache/spark/pull/28741#discussion_r436268072
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/PushPredicateThroughJoin.scala
##
@@ -0,0 +1,248 @@
+/*
+ * Licensed to
holdenk commented on pull request #28700:
URL: https://github.com/apache/spark/pull/28700#issuecomment-640058818
Yes, although that seems like the right thing to do anyways.
On Fri, Jun 5, 2020 at 7:22 PM Wenchen Fan wrote:
> with this patch, does it mean we have to re-do all
maropu commented on a change in pull request #28741:
URL: https://github.com/apache/spark/pull/28741#discussion_r436267250
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/PushPredicateThroughJoin.scala
##
@@ -0,0 +1,248 @@
+/*
+ * Licensed to
maropu commented on pull request #28741:
URL: https://github.com/apache/spark/pull/28741#issuecomment-640057173
Just to check; it seems this PR doesn't depend on CNF conversion, but we
could get the totally same performance gains with
https://github.com/apache/spark/pull/28733?
AmplabJenkins removed a comment on pull request #28741:
URL: https://github.com/apache/spark/pull/28741#issuecomment-640054008
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #28741:
URL: https://github.com/apache/spark/pull/28741#issuecomment-640054008
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA removed a comment on pull request #28741:
URL: https://github.com/apache/spark/pull/28741#issuecomment-640008330
**[Test build #123587 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123587/testReport)**
for PR 28741 at commit
SparkQA commented on pull request #28741:
URL: https://github.com/apache/spark/pull/28741#issuecomment-640053672
**[Test build #123587 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123587/testReport)**
for PR 28741 at commit
yaooqinn closed pull request #28727:
URL: https://github.com/apache/spark/pull/28727
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
AmplabJenkins removed a comment on pull request #28593:
URL: https://github.com/apache/spark/pull/28593#issuecomment-640028119
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
AmplabJenkins removed a comment on pull request #28593:
URL: https://github.com/apache/spark/pull/28593#issuecomment-640028118
Merged build finished. Test FAILed.
This is an automated message from the Apache Git Service.
To
AmplabJenkins commented on pull request #28593:
URL: https://github.com/apache/spark/pull/28593#issuecomment-640028118
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA removed a comment on pull request #28593:
URL: https://github.com/apache/spark/pull/28593#issuecomment-640009693
**[Test build #123588 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123588/testReport)**
for PR 28593 at commit
1 - 100 of 125 matches
Mail list logo