Github user kevinyu98 commented on the pull request:
https://github.com/apache/spark/pull/12893#issuecomment-217083169
test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user kevinyu98 commented on the pull request:
https://github.com/apache/spark/pull/12893#issuecomment-217286258
Hello Wenchen: I have gone through all the alias method in Column, delegate
to the the "name" method. Can you help check?
BTW, I am just curi
Github user kevinyu98 commented on the pull request:
https://github.com/apache/spark/pull/12893#issuecomment-217329536
@cloud-fan : I have change the codes, can you review it again? Thanks very
much.
---
If your project is set up for it, you can reply to this email and have your
Github user kevinyu98 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12893#discussion_r62280265
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Column.scala ---
@@ -883,7 +895,7 @@ class Column(protected[sql] val expr: Expression)
extends
Github user kevinyu98 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12893#discussion_r62203218
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Column.scala ---
@@ -68,6 +68,18 @@ class TypedColumn[-T, U](
}
new TypedColumn[T
Github user kevinyu98 commented on the pull request:
https://github.com/apache/spark/pull/11184#issuecomment-212290104
@marmbrus : Hello Michael, can you help review this PR? Let me know
anything I need to change. Thank very much ! Kevin
---
If your project is set up for it, you
Github user kevinyu98 closed the pull request at:
https://github.com/apache/spark/pull/11184
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user kevinyu98 commented on the pull request:
https://github.com/apache/spark/pull/11184#issuecomment-212496355
@marmbrus : sorry, just saw Wenchen Fan's update from jira, the problem has
been solved. I will close this PR.
---
If your project is set up for it, you can reply
Github user kevinyu98 commented on the pull request:
https://github.com/apache/spark/pull/12893#issuecomment-217608216
Thank you very much !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user kevinyu98 opened a pull request:
https://github.com/apache/spark/pull/16841
[SPARK-18871][SQL][TESTS] New test cases for IN/NOT IN subquery 3ird batch
## What changes were proposed in this pull request?
This is 3ird batch of test case for IN/NOT IN subquery
GitHub user kevinyu98 opened a pull request:
https://github.com/apache/spark/pull/16759
[SPARK-18871][SQL][TESTS] New test cases for IN/NOT IN subquery 2nd batch
## What changes were proposed in this pull request?
This is 2nd batch of test case for IN/NOT IN subquery
GitHub user kevinyu98 opened a pull request:
https://github.com/apache/spark/pull/16692
[SPARK-19335] Introduce UPSERT feature to SPARK
## What changes were proposed in this pull request?
This PR proposes to add the UPSERT feature support into SPARK through
Github user kevinyu98 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16712#discussion_r98079046
--- Diff:
sql/core/src/test/resources/sql-tests/results/subquery/scalar-subquery/scalar-subquery-select.sql.out
---
@@ -0,0 +1,198
Github user kevinyu98 commented on the issue:
https://github.com/apache/spark/pull/16915
@gatorsmile thanks a lot.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user kevinyu98 commented on the issue:
https://github.com/apache/spark/pull/16841
Hello Pete: Thanks for running the test case. Can you send the failing test
case file to me? Also I can provide new test files with the output files, can
you help test on your platforms? thanks
Github user kevinyu98 commented on the issue:
https://github.com/apache/spark/pull/16841
@gatorsmile sure, I will do that. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user kevinyu98 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16841#discussion_r100924238
--- Diff:
sql/core/src/test/resources/sql-tests/inputs/subquery/in-subquery/in-multiple-columns.sql
---
@@ -0,0 +1,127 @@
+-- A test suite
Github user kevinyu98 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16915#discussion_r100942352
--- Diff:
sql/core/src/test/resources/sql-tests/results/subquery/in-subquery/in-with-cte.sql.out
---
@@ -0,0 +1,368 @@
+-- Automatically generated
Github user kevinyu98 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16841#discussion_r100924389
--- Diff:
sql/core/src/test/resources/sql-tests/results/subquery/in-subquery/in-multiple-columns.sql.out
---
@@ -0,0 +1,178 @@
+-- Automatically
GitHub user kevinyu98 opened a pull request:
https://github.com/apache/spark/pull/16915
[SPARK-18871][SQL][TESTS] New test cases for IN/NOT IN subquery 4th batch
## What changes were proposed in this pull request?
This is 4th batch of test case for IN/NOT IN subquery
Github user kevinyu98 commented on the issue:
https://github.com/apache/spark/pull/13506
@vanzin Hello Marcelo: I am so sorry that I didn't notice your update. I
have fix the merge conflicts and can you help review it? Thanks.
---
If your project is set up for it, you can reply
Github user kevinyu98 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12646#discussion_r77079325
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java ---
@@ -501,6 +578,38 @@ public UTF8String trimRight
Github user kevinyu98 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12646#discussion_r77079247
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java ---
@@ -488,6 +543,28 @@ public UTF8String trimLeft
Github user kevinyu98 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12646#discussion_r77078045
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java ---
@@ -476,6 +476,61 @@ public UTF8String trim
Github user kevinyu98 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12646#discussion_r77079523
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -431,56 +432,233 @@ case class FindInSet
Github user kevinyu98 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12646#discussion_r77094689
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -431,56 +432,233 @@ case class FindInSet
Github user kevinyu98 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12646#discussion_r77094867
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala
---
@@ -1789,6 +1803,133 @@ class SQLQuerySuite extends
Github user kevinyu98 commented on the issue:
https://github.com/apache/spark/pull/12646
@chenghao-intel I have updated the codes based on your comments. Thanks a
lot.
Sure, I will work on that jira, so the fix is to just remove the space,
nothing else, right
Github user kevinyu98 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16337#discussion_r94496915
--- Diff:
sql/core/src/test/resources/sql-tests/results/subquery/in-subquery/simple-in.sql.out
---
@@ -0,0 +1,176 @@
+-- Automatically generated
Github user kevinyu98 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16337#discussion_r94359988
--- Diff:
sql/core/src/test/resources/sql-tests/results/subquery/in-subquery/simple-in.sql.out
---
@@ -0,0 +1,176 @@
+-- Automatically generated
Github user kevinyu98 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16337#discussion_r94360158
--- Diff:
sql/core/src/test/resources/sql-tests/results/subquery/in-subquery/simple-in.sql.out
---
@@ -0,0 +1,176 @@
+-- Automatically generated
Github user kevinyu98 commented on the issue:
https://github.com/apache/spark/pull/16337
Hello All:
I have divided the test case to small groups based the discussion, and this
pr will be the first pr for the IN subquery, it covers the simple and group-by
cases
Github user kevinyu98 commented on the issue:
https://github.com/apache/spark/pull/16337
when I click the link, it shows
Test Result (no failures), not sure why the Test Failed.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user kevinyu98 commented on the issue:
https://github.com/apache/spark/pull/16337
Nat will run against DB2 and provide result.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user kevinyu98 opened a pull request:
https://github.com/apache/spark/pull/16337
[SPARK-18871][SQL] New test cases for IN/NOT IN subquery
## What changes were proposed in this pull request?
This PR extends the existing IN/NOT IN subquery test cases coverage, adding
Github user kevinyu98 commented on the issue:
https://github.com/apache/spark/pull/16337
I just run build/sbt "test-only org.apache.spark.sql.streaming.StreamSuite"
on my local machine, also the whole sql suite, it works fine. Can you re-run
the test? Thanks
---
If yo
Github user kevinyu98 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16337#discussion_r93823421
--- Diff:
sql/core/src/test/resources/sql-tests/inputs/subquery/in-subquery/in-group-by.sql
---
@@ -0,0 +1,117 @@
+-- A test suite for GROUP
Github user kevinyu98 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16337#discussion_r93823418
--- Diff:
sql/core/src/test/resources/sql-tests/inputs/subquery/in-subquery/simple-in.sql
---
@@ -0,0 +1,92 @@
+-- A test suite for simple
Github user kevinyu98 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16337#discussion_r93823414
--- Diff:
sql/core/src/test/resources/sql-tests/inputs/subquery/in-subquery/in-group-by.sql
---
@@ -0,0 +1,117 @@
+-- A test suite for GROUP
Github user kevinyu98 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16337#discussion_r93823423
--- Diff:
sql/core/src/test/resources/sql-tests/inputs/subquery/in-subquery/in-group-by.sql
---
@@ -0,0 +1,117 @@
+-- A test suite for GROUP
Github user kevinyu98 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16337#discussion_r93823420
--- Diff:
sql/core/src/test/resources/sql-tests/inputs/subquery/in-subquery/simple-in.sql
---
@@ -0,0 +1,92 @@
+-- A test suite for simple
Github user kevinyu98 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16337#discussion_r93823424
--- Diff:
sql/core/src/test/resources/sql-tests/inputs/subquery/in-subquery/in-group-by.sql
---
@@ -0,0 +1,117 @@
+-- A test suite for GROUP
Github user kevinyu98 commented on the issue:
https://github.com/apache/spark/pull/16337
We will separate this file to multiple files.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user kevinyu98 commented on the issue:
https://github.com/apache/spark/pull/16337
Hello Nat, thanks for the result checking and detail explanation. Based on
your assessment, I have comment out 4 test cases for now, pending on the
investigation of those open JIRAs
Github user kevinyu98 commented on the issue:
https://github.com/apache/spark/pull/12646
Hello André: I will resolve the conflict, at the meantimes, do you have
any comments for this PR? Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user kevinyu98 commented on the issue:
https://github.com/apache/spark/pull/12646
@hvanhovell: Would you have some cycles to review this PR? I would
appreciated some feedback on this.. Thanks.
---
If your project is set up for it, you can reply to this email and have your
Github user kevinyu98 commented on the issue:
https://github.com/apache/spark/pull/12646
@gatorsmile Hello Xiao, can you help retest this ? Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user kevinyu98 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12646#discussion_r132565420
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
---
@@ -2658,4 +2659,23 @@ class SQLQuerySuite extends QueryTest
Github user kevinyu98 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12646#discussion_r132568764
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
---
@@ -1108,7 +1108,11 @@ class AstBuilder(conf: SQLConf
Github user kevinyu98 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12646#discussion_r132569051
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
---
@@ -1121,6 +1125,30 @@ class AstBuilder(conf: SQLConf
Github user kevinyu98 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12646#discussion_r132575620
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -502,69 +503,311 @@ case class FindInSet
Github user kevinyu98 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12646#discussion_r132578914
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -2304,7 +2304,15 @@ object functions {
* @group string_funcs
Github user kevinyu98 commented on the issue:
https://github.com/apache/spark/pull/12646
retest please. I run successfully at local. Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user kevinyu98 commented on the issue:
https://github.com/apache/spark/pull/12646
can retest this please? The Jenkin log didn't show which test case failed.
It run successfully in local. Thanks
---
If your project is set up for it, you can reply to this email and have your
Github user kevinyu98 commented on the issue:
https://github.com/apache/spark/pull/12646
retest please, thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user kevinyu98 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12646#discussion_r128426729
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -2304,7 +2304,15 @@ object functions {
* @group string_funcs
Github user kevinyu98 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12646#discussion_r132305587
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
---
@@ -1121,6 +1125,30 @@ class AstBuilder(conf: SQLConf
Github user kevinyu98 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12646#discussion_r131579031
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
---
@@ -1121,6 +1125,30 @@ class AstBuilder(conf: SQLConf
Github user kevinyu98 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12646#discussion_r131578995
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
---
@@ -1121,6 +1125,30 @@ class AstBuilder(conf: SQLConf
Github user kevinyu98 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12646#discussion_r131578980
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -2304,7 +2304,15 @@ object functions {
* @group string_funcs
Github user kevinyu98 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12646#discussion_r114379826
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -461,68 +462,270 @@ case class FindInSet
Github user kevinyu98 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12646#discussion_r114375187
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -431,56 +432,233 @@ case class FindInSet
Github user kevinyu98 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12646#discussion_r117166463
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java ---
@@ -510,6 +510,67 @@ public UTF8String trim
Github user kevinyu98 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12646#discussion_r117166374
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java ---
@@ -510,6 +510,67 @@ public UTF8String trim
Github user kevinyu98 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12646#discussion_r117166341
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -461,68 +462,246 @@ case class FindInSet
Github user kevinyu98 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12646#discussion_r117166353
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
---
@@ -1069,6 +1069,8 @@ class AstBuilder(conf: SQLConf
Github user kevinyu98 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12646#discussion_r117166332
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -461,68 +462,246 @@ case class FindInSet
Github user kevinyu98 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12646#discussion_r117167238
--- Diff:
common/unsafe/src/test/java/org/apache/spark/unsafe/types/UTF8StringSuite.java
---
@@ -730,4 +726,49 @@ public void testToLong() throws
Github user kevinyu98 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12646#discussion_r116914922
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -461,68 +462,249 @@ case class FindInSet
Github user kevinyu98 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12646#discussion_r116801079
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -461,68 +462,249 @@ case class FindInSet
Github user kevinyu98 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12646#discussion_r116801196
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -461,68 +462,249 @@ case class FindInSet
Github user kevinyu98 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12646#discussion_r116801124
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -461,68 +462,249 @@ case class FindInSet
Github user kevinyu98 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12646#discussion_r116801096
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -461,68 +462,249 @@ case class FindInSet
Github user kevinyu98 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12646#discussion_r116801153
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -461,68 +462,249 @@ case class FindInSet
Github user kevinyu98 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12646#discussion_r116801167
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -461,68 +462,249 @@ case class FindInSet
Github user kevinyu98 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12646#discussion_r116801021
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -2382,7 +2390,15 @@ object functions {
* @group string_funcs
Github user kevinyu98 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12646#discussion_r116801056
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -2447,7 +2463,15 @@ object functions {
* @group string_funcs
Github user kevinyu98 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12646#discussion_r116800916
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
---
@@ -1091,6 +1094,23 @@ class AstBuilder(conf: SQLConf
Github user kevinyu98 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12646#discussion_r116800983
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -2306,7 +2306,15 @@ object functions {
* @group string_funcs
Github user kevinyu98 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12646#discussion_r116801008
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -2306,7 +2306,15 @@ object functions {
* @group string_funcs
Github user kevinyu98 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12646#discussion_r116801040
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -2382,7 +2390,15 @@ object functions {
* @group string_funcs
Github user kevinyu98 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12646#discussion_r116801396
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -461,68 +462,249 @@ case class FindInSet
Github user kevinyu98 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12646#discussion_r116801339
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -461,68 +462,249 @@ case class FindInSet
Github user kevinyu98 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12646#discussion_r116801366
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -461,68 +462,249 @@ case class FindInSet
Github user kevinyu98 commented on the issue:
https://github.com/apache/spark/pull/12646
test please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user kevinyu98 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12646#discussion_r116657546
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -461,68 +462,249 @@ case class FindInSet
Github user kevinyu98 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12646#discussion_r116661760
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -461,68 +462,249 @@ case class FindInSet
Github user kevinyu98 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12646#discussion_r116671752
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
---
@@ -1106,10 +1126,22 @@ class AstBuilder(conf: SQLConf
Github user kevinyu98 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12646#discussion_r116671392
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -461,68 +462,249 @@ case class FindInSet
Github user kevinyu98 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12646#discussion_r116672397
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
---
@@ -1086,10 +1106,22 @@ class AstBuilder extends
Github user kevinyu98 commented on the issue:
https://github.com/apache/spark/pull/13506
sure
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user kevinyu98 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12646#discussion_r117867377
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java ---
@@ -510,6 +510,69 @@ public UTF8String trim
Github user kevinyu98 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12646#discussion_r117867561
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java ---
@@ -510,6 +510,69 @@ public UTF8String trim
Github user kevinyu98 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12646#discussion_r117867416
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java ---
@@ -510,6 +510,69 @@ public UTF8String trim
Github user kevinyu98 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12646#discussion_r117867452
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java ---
@@ -510,6 +510,69 @@ public UTF8String trim
Github user kevinyu98 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12646#discussion_r117871483
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala
---
@@ -2015,4 +2015,121 @@ class SQLQuerySuite extends
Github user kevinyu98 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12646#discussion_r117867609
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java ---
@@ -510,6 +510,69 @@ public UTF8String trim
Github user kevinyu98 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12646#discussion_r117867632
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java ---
@@ -510,6 +510,69 @@ public UTF8String trim
Github user kevinyu98 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12646#discussion_r117867680
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java ---
@@ -510,6 +510,69 @@ public UTF8String trim
Github user kevinyu98 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12646#discussion_r117871066
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java ---
@@ -510,6 +510,69 @@ public UTF8String trim
101 - 200 of 372 matches
Mail list logo
