[GitHub] spark pull request: [SPARK-14874][SQL][Streaming] Remove the obsol...

2016-04-26 Thread lw-lin
Github user lw-lin commented on the pull request: https://github.com/apache/spark/pull/12638#issuecomment-214943354 just rebase to master to resolve some conflicts --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14942][SQL][Streaming] First construct ...

2016-04-26 Thread lw-lin
GitHub user lw-lin opened a pull request: https://github.com/apache/spark/pull/12725 [SPARK-14942][SQL][Streaming] First construct a batch then run the batch for continuous queries ## Problem Currently in `StreamExecution`, we first run the batch, then construct the next

[GitHub] spark pull request: [SPARK-14942][SQL][Streaming] First construct ...

2016-04-26 Thread lw-lin
Github user lw-lin commented on the pull request: https://github.com/apache/spark/pull/12725#issuecomment-214979767 @marmbrus @tdas @zsxwing would you mind taking a look? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-14911][Core] Fix a potential data race ...

2016-04-26 Thread lw-lin
Github user lw-lin commented on the pull request: https://github.com/apache/spark/pull/12681#issuecomment-214983254 @davies thanks for the review & merging :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-14942][SQL][Streaming] Reduce delay bet...

2016-04-28 Thread lw-lin
Github user lw-lin commented on the pull request: https://github.com/apache/spark/pull/12725#issuecomment-215405018 Sure, I'll add a manual timed executor and some dedicated tests as well. --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] spark pull request: [SPARK-15022][SPARK-15023] Add support for tes...

2016-04-29 Thread lw-lin
GitHub user lw-lin opened a pull request: https://github.com/apache/spark/pull/12797 [SPARK-15022][SPARK-15023] Add support for testing against the `ProcessingTime(intervalMS > 0)` trigger and `ManualClock` ## What changes were proposed in this pull request? Currently

[GitHub] spark pull request: [SPARK-15022][SPARK-15023] Add support for tes...

2016-04-29 Thread lw-lin
Github user lw-lin commented on the pull request: https://github.com/apache/spark/pull/12797#issuecomment-215924685 still editing, will explain why ProcessingTimeExecutor, where for a batch it should run batchRunner only once but might run multiple times under certain conditions

[GitHub] spark pull request: [SPARK-15022][SPARK-15023] Add support for tes...

2016-04-29 Thread lw-lin
Github user lw-lin commented on a diff in the pull request: https://github.com/apache/spark/pull/12797#discussion_r61663787 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/ProcessingTimeExecutorSuite.scala --- @@ -21,19 +21,41 @@ import

[GitHub] spark pull request: [SPARK-15022][SPARK-15023] Add support for tes...

2016-04-29 Thread lw-lin
Github user lw-lin commented on a diff in the pull request: https://github.com/apache/spark/pull/12797#discussion_r61663843 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamSuite.scala --- @@ -136,6 +136,22 @@ class StreamSuite extends StreamTest with

[GitHub] spark pull request: [SPARK-14942][SQL][Streaming] Reduce delay bet...

2016-04-29 Thread lw-lin
Github user lw-lin commented on the pull request: https://github.com/apache/spark/pull/12725#issuecomment-215927916 For things to be easy to review, I've added the manual timed executor for testing general cases in [a separate PR](https://github.com/apache/spark/pull/12797).

[GitHub] spark pull request: [SPARK-15022][SPARK-15023] Add support for tes...

2016-04-29 Thread lw-lin
Github user lw-lin commented on the pull request: https://github.com/apache/spark/pull/12797#issuecomment-215928373 @marmbrus @tdas @zsxwing would you mind taking a look? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-14884][SQL][Streaming][WebUI] Fix call ...

2016-05-02 Thread lw-lin
Github user lw-lin commented on a diff in the pull request: https://github.com/apache/spark/pull/12650#discussion_r61835312 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala --- @@ -99,7 +99,15 @@ class StreamExecution

[GitHub] spark pull request: [SPARK-14884][SQL][Streaming][WebUI] Fix call ...

2016-05-02 Thread lw-lin
Github user lw-lin commented on a diff in the pull request: https://github.com/apache/spark/pull/12650#discussion_r61835377 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SQLExecution.scala --- @@ -46,7 +45,11 @@ private[sql] object SQLExecution { val

[GitHub] spark pull request: [SPARK-14884][SQL][Streaming][WebUI] Fix call ...

2016-05-02 Thread lw-lin
Github user lw-lin commented on the pull request: https://github.com/apache/spark/pull/12650#issuecomment-216427977 @zsxwing I've made updates per your comments; would you take a another look? Thanks! --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: [SPARK-15022][SPARK-15023][SQL][Streaming] Add...

2016-05-02 Thread lw-lin
Github user lw-lin commented on a diff in the pull request: https://github.com/apache/spark/pull/12797#discussion_r61837469 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/TriggerExecutor.scala --- @@ -65,8 +65,22 @@ case class ProcessingTimeExecutor

[GitHub] spark pull request: [SPARK-15022][SPARK-15023][SQL][Streaming] Add...

2016-05-02 Thread lw-lin
Github user lw-lin commented on a diff in the pull request: https://github.com/apache/spark/pull/12797#discussion_r61837727 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/TriggerExecutor.scala --- @@ -65,8 +65,22 @@ case class ProcessingTimeExecutor

[GitHub] spark pull request: [SPARK-15022][SPARK-15023][SQL][Streaming] Add...

2016-05-02 Thread lw-lin
Github user lw-lin commented on a diff in the pull request: https://github.com/apache/spark/pull/12797#discussion_r61837747 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/ProcessingTimeExecutorSuite.scala --- @@ -21,19 +21,41 @@ import

[GitHub] spark pull request: [SPARK-15022][SPARK-15023][SQL][Streaming] Add...

2016-05-03 Thread lw-lin
Github user lw-lin commented on a diff in the pull request: https://github.com/apache/spark/pull/12797#discussion_r61976475 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/StreamTest.scala --- @@ -142,7 +142,10 @@ trait StreamTest extends QueryTest with Timeouts

[GitHub] spark pull request: [SPARK-15022][SPARK-15023][SQL][Streaming] Add...

2016-05-03 Thread lw-lin
Github user lw-lin commented on a diff in the pull request: https://github.com/apache/spark/pull/12797#discussion_r61976675 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/TriggerExecutor.scala --- @@ -65,8 +65,13 @@ case class ProcessingTimeExecutor

[GitHub] spark pull request: [SPARK-15022][SPARK-15023][SQL][Streaming] Add...

2016-05-03 Thread lw-lin
Github user lw-lin commented on a diff in the pull request: https://github.com/apache/spark/pull/12797#discussion_r61977204 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/TriggerExecutor.scala --- @@ -65,8 +65,13 @@ case class ProcessingTimeExecutor

[GitHub] spark pull request: [SPARK-15022][SPARK-15023][SQL][Streaming] Add...

2016-05-03 Thread lw-lin
Github user lw-lin commented on the pull request: https://github.com/apache/spark/pull/12797#issuecomment-216705209 @marmbrus @zsxwing thank you for the patient review! :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] spark pull request: [SPARK-14942][SQL][Streaming] Reduce delay bet...

2016-05-06 Thread lw-lin
Github user lw-lin commented on a diff in the pull request: https://github.com/apache/spark/pull/12725#discussion_r62410548 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala --- @@ -122,7 +122,7 @@ class StreamExecution

[GitHub] spark pull request: [SPARK-14942][SQL][Streaming] Reduce delay bet...

2016-05-06 Thread lw-lin
Github user lw-lin commented on a diff in the pull request: https://github.com/apache/spark/pull/12725#discussion_r62410545 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/IncrementalExecution.scala --- @@ -27,12 +27,12 @@ import

[GitHub] spark pull request: [SPARK-14942][SQL][Streaming] Reduce delay bet...

2016-05-06 Thread lw-lin
Github user lw-lin commented on the pull request: https://github.com/apache/spark/pull/12725#issuecomment-217608390 I've addressed comments and expanded tests; @zsxwing would you mind taking another look? Thanks! --- If your project is set up for it, you can reply to this emai

[GitHub] spark pull request: [WIP][SPARK-15208][Core][Docs] Update spark ex...

2016-05-07 Thread lw-lin
GitHub user lw-lin opened a pull request: https://github.com/apache/spark/pull/12981 [WIP][SPARK-15208][Core][Docs] Update spark examples with AccumulatorV2 ## What changes were proposed in this pull request? The patch updates the codes & docs in the example module as

[GitHub] spark pull request: [WIP][SPARK-15208][Core][Docs] Update spark ex...

2016-05-07 Thread lw-lin
Github user lw-lin commented on the pull request: https://github.com/apache/spark/pull/12981#issuecomment-217689734 Once the AccumulatorV2 Java API is finalized, I would update the Java & Python part. Thanks --- If your project is set up for it, you can reply to this email and

[GitHub] spark pull request: [SPARK-14942][SQL][Streaming] Reduce delay bet...

2016-05-09 Thread lw-lin
Github user lw-lin commented on the pull request: https://github.com/apache/spark/pull/12725#issuecomment-218016900 @zsxwing would you take another look? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14942][SQL][Streaming] Reduce delay bet...

2016-05-15 Thread lw-lin
Github user lw-lin commented on the pull request: https://github.com/apache/spark/pull/12725#issuecomment-219336043 @marmbrus @zsxwing maybe this is ready to go? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-14025][STREAMING][WEBUI] Fix streaming ...

2016-03-19 Thread lw-lin
GitHub user lw-lin opened a pull request: https://github.com/apache/spark/pull/11845 [SPARK-14025][STREAMING][WEBUI] Fix streaming job descriptions on the event line ## What changes were proposed in this pull request? Removed the extra `...` for each streaming job&#

[GitHub] spark pull request: [SPARK-14025][STREAMING][WEBUI] Fix streaming ...

2016-03-19 Thread lw-lin
Github user lw-lin commented on the pull request: https://github.com/apache/spark/pull/11845#issuecomment-198695846 @andrewor14 @zsxwing would you mind taking a look at this when you have time? Thanks! --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request: [SPARK-14025][STREAMING][WEBUI] Fix streaming ...

2016-03-19 Thread lw-lin
Github user lw-lin commented on the pull request: https://github.com/apache/spark/pull/11845#issuecomment-198707142 @srowen thanks for looking at this! I believe job descriptions were intended to contains only plain texts at first, but HTMLs were introduced in for streaming

[GitHub] spark pull request: [SPARK-14025][STREAMING][WEBUI] Fix streaming ...

2016-03-19 Thread lw-lin
Github user lw-lin commented on the pull request: https://github.com/apache/spark/pull/11845#issuecomment-198708658 Besides, the blue/green bar in the event line itself is a clickable, linking to the specific job page. The `` thing is superfluous, let's figure out how to remo

[GitHub] spark pull request: [SPARK-14025][STREAMING][WEBUI] Fix streaming ...

2016-03-19 Thread lw-lin
Github user lw-lin commented on the pull request: https://github.com/apache/spark/pull/11845#issuecomment-198710234 Actually we've intentionally escaped the description for the event line, so that it will be rendered as plain texts; please see https://github.com/apache/spark

[GitHub] spark pull request: [SPARK-14025][STREAMING][WEBUI] Fix streaming ...

2016-03-19 Thread lw-lin
Github user lw-lin commented on the pull request: https://github.com/apache/spark/pull/11845#issuecomment-198714597 Maybe let's summarize a little bit: - job/stage descriptions are used at 2 places: the `Event Timeline` and the text tables (`CompletedJobs`/`CompletedS

[GitHub] spark pull request: [SPARK-14025][STREAMING][WEBUI] Fix streaming ...

2016-03-19 Thread lw-lin
Github user lw-lin commented on the pull request: https://github.com/apache/spark/pull/11845#issuecomment-198718502 Ah, I guess the reason is: - for the blue box in the event timeline, itself is clickable both for streaming/non-streaming jobs, so it's unnecessary to contai

[GitHub] spark pull request: [SPARK-14025][STREAMING][WEBUI] Fix streaming ...

2016-03-19 Thread lw-lin
Github user lw-lin commented on the pull request: https://github.com/apache/spark/pull/11845#issuecomment-198718851 Maybe @andrewor14 will explain better :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-14028][STREAMING][KINESIS][TESTS] Remov...

2016-03-20 Thread lw-lin
GitHub user lw-lin opened a pull request: https://github.com/apache/spark/pull/11850 [SPARK-14028][STREAMING][KINESIS][TESTS] Remove deprecated methods; fix two other warnings ## What changes were proposed in this pull request? - Removed two methods that has been

[GitHub] spark pull request: [SPARK-14028][STREAMING][KINESIS][TESTS] Remov...

2016-03-20 Thread lw-lin
Github user lw-lin commented on a diff in the pull request: https://github.com/apache/spark/pull/11850#discussion_r56760713 --- Diff: external/kinesis-asl/src/test/java/org/apache/spark/streaming/kinesis/JavaKinesisStreamSuite.java --- @@ -34,11 +35,13 @@ public class

[GitHub] spark pull request: [SPARK-14028][STREAMING][KINESIS][TESTS] Remov...

2016-03-20 Thread lw-lin
Github user lw-lin commented on a diff in the pull request: https://github.com/apache/spark/pull/11850#discussion_r56760750 --- Diff: external/kinesis-asl/src/test/scala/org/apache/spark/streaming/kinesis/KinesisFunSuite.scala --- @@ -40,7 +40,7 @@ trait KinesisFunSuite extends

[GitHub] spark pull request: [SPARK-14028][STREAMING][KINESIS][TESTS] Remov...

2016-03-20 Thread lw-lin
Github user lw-lin commented on a diff in the pull request: https://github.com/apache/spark/pull/11850#discussion_r56760767 --- Diff: external/kinesis-asl/src/test/scala/org/apache/spark/streaming/kinesis/KinesisStreamSuite.scala --- @@ -99,14 +99,10 @@ abstract class

[GitHub] spark pull request: [SPARK-14028][STREAMING][KINESIS][TESTS] Remov...

2016-03-20 Thread lw-lin
Github user lw-lin commented on a diff in the pull request: https://github.com/apache/spark/pull/11850#discussion_r56760778 --- Diff: external/kinesis-asl/src/test/scala/org/apache/spark/streaming/kinesis/KinesisStreamSuite.scala --- @@ -154,7 +150,9 @@ abstract class

[GitHub] spark pull request: [SPARK-14028][STREAMING][KINESIS][TESTS] Remov...

2016-03-21 Thread lw-lin
Github user lw-lin commented on the pull request: https://github.com/apache/spark/pull/11850#issuecomment-199169765 @srowen thanks for the review! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-14025][STREAMING][WEBUI] Fix streaming ...

2016-03-21 Thread lw-lin
Github user lw-lin commented on the pull request: https://github.com/apache/spark/pull/11845#issuecomment-199583350 @andrewor14 thank you for the informative review. Will soon update this PR accordingly. --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request: [SPARK-14025][STREAMING][WEBUI] Fix streaming ...

2016-03-22 Thread lw-lin
Github user lw-lin commented on the pull request: https://github.com/apache/spark/pull/11845#issuecomment-199727209 Updated with new commits. Tests passed on my local machine; I wonder why scalastyle checks failed (this PR doesn't touch this code sn

[GitHub] spark pull request: [SPARK-14025][STREAMING][WEBUI] Fix streaming ...

2016-03-22 Thread lw-lin
Github user lw-lin commented on a diff in the pull request: https://github.com/apache/spark/pull/11845#discussion_r57100182 --- Diff: core/src/main/scala/org/apache/spark/ui/UIUtils.scala --- @@ -445,22 +445,36 @@ private[spark] object UIUtils extends Logging

[GitHub] spark pull request: [SPARK-14025][STREAMING][WEBUI] Fix streaming ...

2016-03-22 Thread lw-lin
Github user lw-lin commented on a diff in the pull request: https://github.com/apache/spark/pull/11845#discussion_r57100194 --- Diff: core/src/main/scala/org/apache/spark/ui/UIUtils.scala --- @@ -417,7 +417,7 @@ private[spark] object UIUtils extends Logging { * attempts to

[GitHub] spark pull request: [SPARK-14089][CORE][MLLIB] Remove methods that...

2016-03-22 Thread lw-lin
GitHub user lw-lin opened a pull request: https://github.com/apache/spark/pull/11910 [SPARK-14089][CORE][MLLIB] Remove methods that has been deprecated since 1.1.x, 1.2.x and 1.3.x ## What changes were proposed in this pull request? Removed methods that has been deprecated

[GitHub] spark pull request: [SPARK-14089][CORE][MLLIB] Remove methods that...

2016-03-22 Thread lw-lin
Github user lw-lin commented on the pull request: https://github.com/apache/spark/pull/11910#issuecomment-200141425 I also checked that these deprecated-and-should-be-removed methods exist only in core and mllib, i.e. no such methods exist in sql, streaming, yarn, etc., so only

[GitHub] spark pull request: [SPARK-14089][CORE][MLLIB] Remove methods that...

2016-03-22 Thread lw-lin
Github user lw-lin commented on a diff in the pull request: https://github.com/apache/spark/pull/11910#discussion_r57103353 --- Diff: core/src/main/java/org/apache/spark/api/java/StorageLevels.java --- @@ -40,19 +40,6 @@ * Create a new StorageLevel object. * @param

[GitHub] spark pull request: [SPARK-14089][CORE][MLLIB] Remove methods that...

2016-03-23 Thread lw-lin
Github user lw-lin commented on the pull request: https://github.com/apache/spark/pull/11910#issuecomment-200360008 Updated with a new commit removing two methods deprecated in `ML` since 1.5.x. Recently deprecated methods (since 1.6) throughout Spark are kept. Please let me know if

[GitHub] spark pull request: [SPARK-14089][CORE][MLLIB] Remove methods that...

2016-03-23 Thread lw-lin
Github user lw-lin commented on a diff in the pull request: https://github.com/apache/spark/pull/11910#discussion_r57166028 --- Diff: core/src/main/java/org/apache/spark/api/java/StorageLevels.java --- @@ -40,19 +40,6 @@ * Create a new StorageLevel object. * @param

[GitHub] spark pull request: [SPARK-14025][STREAMING][WEBUI] Fix streaming ...

2016-03-23 Thread lw-lin
Github user lw-lin commented on the pull request: https://github.com/apache/spark/pull/11845#issuecomment-200573435 Thank you all for your kind review & comments, @srowen @andrewor14 @zsxwing ! --- If your project is set up for it, you can reply to this email and have your r

[GitHub] spark pull request: [SPARK-14089][CORE][MLLIB] Remove methods that...

2016-03-24 Thread lw-lin
Github user lw-lin commented on the pull request: https://github.com/apache/spark/pull/11910#issuecomment-201156796 Jenkins test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-14089][CORE][MLLIB] Remove methods that...

2016-03-26 Thread lw-lin
Github user lw-lin commented on the pull request: https://github.com/apache/spark/pull/11910#issuecomment-201806898 @rxin @srowen @mengxr thank you all for the review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-12857][STREAMING] Streaming tab in web ...

2016-03-29 Thread lw-lin
GitHub user lw-lin opened a pull request: https://github.com/apache/spark/pull/12032 [SPARK-12857][STREAMING] Streaming tab in web UI uses records and events interchangeably ## What changes were proposed in this pull request? Currently the Streaming tab in web UI uses

[GitHub] spark pull request: [SPARK-12857][STREAMING] Streaming tab in web ...

2016-03-29 Thread lw-lin
Github user lw-lin commented on the pull request: https://github.com/apache/spark/pull/12032#issuecomment-202808056 No public documents need to change, since we have been using the term "records" consistently. Strings on the Streaming tab has been changed from &

[GitHub] spark pull request: [SPARK-13211][STREAMING] Deprecate certain con...

2016-03-29 Thread lw-lin
GitHub user lw-lin opened a pull request: https://github.com/apache/spark/pull/12035 [SPARK-13211][STREAMING] Deprecate certain constructors of StreamingContext's ## What changes were proposed in this pull request? These constructors, each of which takes a checkpoint

[GitHub] spark pull request: [SPARK-13211][STREAMING] Deprecate certain con...

2016-03-29 Thread lw-lin
Github user lw-lin commented on the pull request: https://github.com/apache/spark/pull/12035#issuecomment-202881741 As reported in [\[Spark-13211\]](https://issues.apache.org/jira/browse/SPARK-13211), `StreamingContext` would throw `NoSuchElementException` when created from non

[GitHub] spark pull request: Enable test: o.a.s.streaming.JobGeneratorSuite...

2016-03-09 Thread lw-lin
GitHub user lw-lin opened a pull request: https://github.com/apache/spark/pull/11626 Enable test: o.a.s.streaming.JobGeneratorSuite "Do not clear received… ## How was this patch tested? unit test You can merge this pull request into a Git repository by ru

[GitHub] spark pull request: Enable test: o.a.s.streaming.JobGeneratorSuite...

2016-03-09 Thread lw-lin
Github user lw-lin commented on the pull request: https://github.com/apache/spark/pull/11626#issuecomment-194639133 Local tests passed, so maybe we can enable this again for 2.0.0. @rxin @zsxwing would you mind taking a look please? Thanks! --- If your project is set up for it, you

[GitHub] spark pull request: [SPARK-7420][STREAMING][TESTS] Enable test: o....

2016-03-09 Thread lw-lin
Github user lw-lin commented on the pull request: https://github.com/apache/spark/pull/11626#issuecomment-194672903 @rxin thanks ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-13618][STREAMING][WEB-UI] Make Streamin...

2016-03-10 Thread lw-lin
GitHub user lw-lin opened a pull request: https://github.com/apache/spark/pull/11633 [SPARK-13618][STREAMING][WEB-UI] Make Streaming web UI page display rate-limit lines on statistics graph - Part 2 ## What changes were proposed in this pull request? (Please fill in

[GitHub] spark pull request: [SPARK-13618][STREAMING][WEB-UI] Make Streamin...

2016-03-10 Thread lw-lin
GitHub user lw-lin opened a pull request: https://github.com/apache/spark/pull/11634 [SPARK-13618][STREAMING][WEB-UI] Make Streaming web UI page display rate-limit lines on statistics graph - Part 3 ## What changes were proposed in this pull request? (Please fill in

[GitHub] spark pull request: [SPARK-13618][STREAMING][WEB-UI] Make Streamin...

2016-03-10 Thread lw-lin
Github user lw-lin commented on the pull request: https://github.com/apache/spark/pull/11470#issuecomment-194874328 @zsxwing Points taken -- indeed no need to display rate-limit line when an `InputDStream` instance is not _under rate control_: I've added a

[GitHub] spark pull request: [SPARK-13618][STREAMING][WEB-UI] Make Streamin...

2016-03-10 Thread lw-lin
Github user lw-lin commented on the pull request: https://github.com/apache/spark/pull/11470#issuecomment-194880816 All three parts are now ready for review. I've also drafted a design doc (please see [Spark-13618](https://issues.apache.org/jira/browse/SPARK-13618)), hopefully i

[GitHub] spark pull request: [SPARK-13618][STREAMING][WEB-UI] Make Streamin...

2016-03-10 Thread lw-lin
Github user lw-lin commented on the pull request: https://github.com/apache/spark/pull/11633#issuecomment-194881019 All three parts are now ready for review. I've also drafted a design doc (please see [Spark-13618](https://issues.apache.org/jira/browse/SPARK-13618)), hopefully i

[GitHub] spark pull request: [SPARK-13618][STREAMING][WEB-UI] Make Streamin...

2016-03-10 Thread lw-lin
Github user lw-lin commented on the pull request: https://github.com/apache/spark/pull/11634#issuecomment-194881087 All three parts are now ready for review. I've also drafted a design doc (please see [Spark-13618](https://issues.apache.org/jira/browse/SPARK-13618)), hopefully i

[GitHub] spark pull request: Display rate limit on streaming web ui part 3

2016-03-10 Thread lw-lin
GitHub user lw-lin opened a pull request: https://github.com/apache/spark/pull/11643 Display rate limit on streaming web ui part 3 ## What changes were proposed in this pull request? This PR makes Streaming web UI display rate-limit lines in the statistics graph

[GitHub] spark pull request: Display rate limit on streaming web ui part 3

2016-03-10 Thread lw-lin
Github user lw-lin commented on the pull request: https://github.com/apache/spark/pull/11643#issuecomment-195148951 All three parts are now ready for review. I've also drafted a design doc (please see [Spark-13618](https://issues.apache.org/jira/browse/SPARK-13618)), hopefully i

[GitHub] spark pull request: [SPARK-13618][STREAMING][WEB-UI] Make Streamin...

2016-03-10 Thread lw-lin
Github user lw-lin closed the pull request at: https://github.com/apache/spark/pull/11634 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [WIP][SPARK-13809][SQL] State store for stream...

2016-03-10 Thread lw-lin
Github user lw-lin commented on a diff in the pull request: https://github.com/apache/spark/pull/11645#discussion_r55794434 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/StateStore.scala --- @@ -0,0 +1,462 @@ +/* + * Licensed to the

[GitHub] spark pull request: [WIP][SPARK-13809][SQL] State store for stream...

2016-03-10 Thread lw-lin
Github user lw-lin commented on a diff in the pull request: https://github.com/apache/spark/pull/11645#discussion_r55794512 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/StateStore.scala --- @@ -0,0 +1,462 @@ +/* + * Licensed to the

[GitHub] spark pull request: [WIP][SPARK-13809][SQL] State store for stream...

2016-03-10 Thread lw-lin
Github user lw-lin commented on a diff in the pull request: https://github.com/apache/spark/pull/11645#discussion_r55794534 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/StateStore.scala --- @@ -0,0 +1,462 @@ +/* + * Licensed to the

[GitHub] spark pull request: [STREAMING][MINOR] Fix a duplicate "be" in com...

2016-03-10 Thread lw-lin
GitHub user lw-lin opened a pull request: https://github.com/apache/spark/pull/11650 [STREAMING][MINOR] Fix a duplicate "be" in comments You can merge this pull request into a Git repository by running: $ git pull https://github.com/lw-lin/spark typo Alternative

[GitHub] spark pull request: [STREAMING][MINOR] Fix a duplicate "be" in com...

2016-03-11 Thread lw-lin
Github user lw-lin commented on the pull request: https://github.com/apache/spark/pull/11650#issuecomment-195299373 @rxin @zsxwing Would you take a look when you have time? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request: [STREAMING][MINOR] Fix a duplicate "be" in com...

2016-03-11 Thread lw-lin
Github user lw-lin commented on the pull request: https://github.com/apache/spark/pull/11650#issuecomment-195335583 Sure, I'll close this for now. Thanks for your time! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

[GitHub] spark pull request: [STREAMING][MINOR] Fix a duplicate "be" in com...

2016-03-11 Thread lw-lin
Github user lw-lin closed the pull request at: https://github.com/apache/spark/pull/11650 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [STREAMING][MINOR] Fix a duplicate "be" in com...

2016-03-11 Thread lw-lin
Github user lw-lin commented on the pull request: https://github.com/apache/spark/pull/11650#issuecomment-195655635 Sure. @rxin thank you for your review and patient guidance! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-14556][SQL] Code clean-ups for package ...

2016-04-12 Thread lw-lin
Github user lw-lin commented on the pull request: https://github.com/apache/spark/pull/12323#issuecomment-209201130 @zsxwing thank you for the review & merging ! :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] spark pull request: [SPARK-13992][Core][PySpark][FollowUp] Update ...

2016-04-12 Thread lw-lin
Github user lw-lin commented on the pull request: https://github.com/apache/spark/pull/12126#issuecomment-209216092 @rxin would you mind taking a look, or should I close this PR? Thank you! :-) --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [SPARK-13992][Core][PySpark][FollowUp] Update ...

2016-04-12 Thread lw-lin
Github user lw-lin commented on the pull request: https://github.com/apache/spark/pull/12126#issuecomment-209217089 Jenkins retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-14630][Build][Core][SQL][Streaming] Cod...

2016-04-14 Thread lw-lin
GitHub user lw-lin opened a pull request: https://github.com/apache/spark/pull/12389 [SPARK-14630][Build][Core][SQL][Streaming] Code style: public abstract methods should have explicit return types ## What changes were proposed in this pull request? Currently many public

[GitHub] spark pull request: [WIP][SPARK-14629][SPARK-14630] Add support fo...

2016-04-14 Thread lw-lin
GitHub user lw-lin opened a pull request: https://github.com/apache/spark/pull/12396 [WIP][SPARK-14629][SPARK-14630] Add support for custom scala style rules & Add rule PublicAbstractMethodsHaveTypeChecker ## What changes were proposed in this pull req

[GitHub] spark pull request: [WIP][SPARK-14629][SPARK-14630] Add support fo...

2016-04-14 Thread lw-lin
Github user lw-lin commented on the pull request: https://github.com/apache/spark/pull/12396#issuecomment-210013991 As per [Scalastyle - Custom rules](http://www.scalastyle.org/custom-rules.html), I installed the jar on my local machine, and verified that the added rule works

[GitHub] spark pull request: [SPARK-14630][Build][Core][SQL][Streaming] Cod...

2016-04-14 Thread lw-lin
Github user lw-lin commented on the pull request: https://github.com/apache/spark/pull/12389#issuecomment-210258876 @srowen @rxin thank you for the review & merging! :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] spark pull request: [WIP][SPARK-14629][SPARK-14630][Build] Add sup...

2016-04-14 Thread lw-lin
Github user lw-lin commented on a diff in the pull request: https://github.com/apache/spark/pull/12396#discussion_r59821242 --- Diff: pom.xml --- @@ -2237,6 +2237,13 @@ ${project.build.sourceEncoding} ${project.reporting.outputEncoding

[GitHub] spark pull request: [WIP][SPARK-14629][SPARK-14630][Build] Add sup...

2016-04-14 Thread lw-lin
Github user lw-lin commented on the pull request: https://github.com/apache/spark/pull/12396#issuecomment-210262145 hi @vanzin I'm not sure how to build and pre-install some jar for every Spark build on Jenkins's machine -- should some build scripts be modified? Coul

[GitHub] spark pull request: [WIP][SPARK-14629][SPARK-14630][Build] Add sup...

2016-04-14 Thread lw-lin
Github user lw-lin commented on the pull request: https://github.com/apache/spark/pull/12396#issuecomment-210314939 I see; will follow @rxin 's advise. So I'm closing this. @rxin @vanzin @srowen thank you all for the comments! :-) --- If your project is set up f

[GitHub] spark pull request: [WIP][SPARK-14629][SPARK-14630][Build] Add sup...

2016-04-14 Thread lw-lin
Github user lw-lin closed the pull request at: https://github.com/apache/spark/pull/12396 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [DO_NOT_MERGE][Test] Investigate MemorySinkSui...

2016-04-16 Thread lw-lin
GitHub user lw-lin opened a pull request: https://github.com/apache/spark/pull/12443 [DO_NOT_MERGE][Test] Investigate MemorySinkSuite flakiness You can merge this pull request into a Git repository by running: $ git pull https://github.com/lw-lin/spark fix-memory-sink-suite

[GitHub] spark pull request: [DO_NOT_MERGE][Test] Investigate MemorySinkSui...

2016-04-16 Thread lw-lin
Github user lw-lin commented on the pull request: https://github.com/apache/spark/pull/12443#issuecomment-210937812 Jenkins retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [Spark-14687][Core][SQL][MLlib] Call path.getF...

2016-04-16 Thread lw-lin
GitHub user lw-lin opened a pull request: https://github.com/apache/spark/pull/12450 [Spark-14687][Core][SQL][MLlib] Call path.getFileSystem(conf) instead of call FileSystem.get(conf) ## What changes were proposed in this pull request? - replaced `FileSystem.get(conf

[GitHub] spark pull request: [SPARK-14672][SQL] Move HiveContext analyze lo...

2016-04-17 Thread lw-lin
Github user lw-lin commented on the pull request: https://github.com/apache/spark/pull/12448#issuecomment-211025518 Seems like `org.apache.spark.sql.hive.HiveSparkSubmitSuite` have been failing since this merging: https://spark-tests.appspot.com/tests

[GitHub] spark pull request: [DO_NOT_MERGE][Test] Investigate MemorySinkSui...

2016-04-17 Thread lw-lin
Github user lw-lin closed the pull request at: https://github.com/apache/spark/pull/12443 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [Spark-14687][Core][SQL][MLlib] Call path.getF...

2016-04-17 Thread lw-lin
Github user lw-lin commented on the pull request: https://github.com/apache/spark/pull/12450#issuecomment-211209966 Jenkins retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [Spark-14687][Core][SQL][MLlib] Call path.getF...

2016-04-18 Thread lw-lin
Github user lw-lin commented on the pull request: https://github.com/apache/spark/pull/12450#issuecomment-211679362 Jenkins retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-14701][Streaming] First stop the event ...

2016-04-18 Thread lw-lin
GitHub user lw-lin opened a pull request: https://github.com/apache/spark/pull/12489 [SPARK-14701][Streaming] First stop the event loop, then stop the checkpoint writer in JobGenerator ## What changes were proposed in this pull request? The stopping order of the `event

[GitHub] spark pull request: [SPARK-14701][Streaming] First stop the event ...

2016-04-18 Thread lw-lin
Github user lw-lin commented on the pull request: https://github.com/apache/spark/pull/12489#issuecomment-211724261 @zsxwing would you mind taking a look? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14747][SQL] Add assertStreaming/assertN...

2016-04-20 Thread lw-lin
GitHub user lw-lin opened a pull request: https://github.com/apache/spark/pull/12521 [SPARK-14747][SQL] Add assertStreaming/assertNoneStreaming checks in DataFrameWriter ## Problem If an end user happens to write code mixed with continuous-query-oriented methods and non

[GitHub] spark pull request: [SPARK-14747][SQL] Add assertStreaming/assertN...

2016-04-20 Thread lw-lin
Github user lw-lin commented on the pull request: https://github.com/apache/spark/pull/12521#issuecomment-212303861 @rxin @marmbrus would you mind taking a look when you have time? Thanks! :-) And I'm not sure we should disallow calling methods like `parquet()`, `text(

<    1   2   3   4   5   6   >